From 4a0602e69f1bf8bbd748bed677930d515792b7d5 Mon Sep 17 00:00:00 2001 From: Neil Date: Fri, 11 Sep 2026 00:06:03 -0700 Subject: [PATCH] docs(windows): say the arch proxy is superseded, not complementary Both the removed `electronArch === process.arch` check and `conptyTargetsArch` answer one question: does build/Release hold a binary this slice can load. Re-adding the proxy alongside the header read as insurance would restore the skip the header read exists to close -- the arm64 slice cross-built on x64. Recorded at the guard because a reviewer cannot see a silently-preferred wrong guard in a diff where both fixes appear to have landed. --- config/packaged-runtime-node-modules.cjs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/config/packaged-runtime-node-modules.cjs b/config/packaged-runtime-node-modules.cjs index 385400d9996..5486ba59a8b 100644 --- a/config/packaged-runtime-node-modules.cjs +++ b/config/packaged-runtime-node-modules.cjs @@ -395,6 +395,10 @@ function prunePackagedNodePty(resourcesDir, electronPlatformName, electronArch) // that with `electronArch === process.arch`, which also skipped the arm64 slice cross-built on // an x64 Windows host -- a rebuild that DOES produce a correct arm64 addon. That slice then // shipped the unpatched prebuild as a live fallback. Read the header instead of guessing. + // + // The proxy is SUPERSEDED, not complementary: both answer "does build/Release hold a binary + // this slice can load", and re-adding `electronArch === process.arch` alongside this as + // insurance would restore the skip in the exact case the header read exists to cover. if (electronPlatformName === 'win32') { const releaseAddon = join(nodePtyDir, 'build', 'Release', 'conpty.node') if (conptyTargetsArch(releaseAddon, electronArch)) {