From 4a3db11e16bc2fc0d46d555eb792408cd1a35325 Mon Sep 17 00:00:00 2001
From: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
Date: Sun, 7 Jun 2026 20:51:04 -0700
Subject: [PATCH] feat: show persistent underline on PR link buttons in review
 headers (#4861)

---
 .../components/right-sidebar/ChecksPanel.review-header.test.tsx | 1 +
 src/renderer/src/components/right-sidebar/ChecksPanel.tsx       | 2 +-
 .../SourceControl.hosted-review-header-link.test.tsx            | 1 +
 src/renderer/src/components/right-sidebar/SourceControl.tsx     | 2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/renderer/src/components/right-sidebar/ChecksPanel.review-header.test.tsx b/src/renderer/src/components/right-sidebar/ChecksPanel.review-header.test.tsx
index 4b4b79af5b6..af2a2c546c2 100644
--- a/src/renderer/src/components/right-sidebar/ChecksPanel.review-header.test.tsx
+++ b/src/renderer/src/components/right-sidebar/ChecksPanel.review-header.test.tsx
@@ -48,6 +48,7 @@ describe('ChecksPanelReviewHeader', () => {
 
     expect(markup).toContain('Open on GitHub')
     expect(markup).toContain('#2964')
+    expect(markup).toContain('underline decoration-border underline-offset-2')
     expect(markup).toContain('More PR actions')
     expect(markup).toContain('unlink PR')
     expect(markup).toContain('Link another PR')
diff --git a/src/renderer/src/components/right-sidebar/ChecksPanel.tsx b/src/renderer/src/components/right-sidebar/ChecksPanel.tsx
index 8e378e3a773..537927d0780 100644
--- a/src/renderer/src/components/right-sidebar/ChecksPanel.tsx
+++ b/src/renderer/src/components/right-sidebar/ChecksPanel.tsx
@@ -139,7 +139,7 @@ export function ChecksPanelReviewHeader({
       <ReviewIcon className="size-4 text-muted-foreground shrink-0" />
       <button
         type="button"
-        className="rounded px-0.5 text-[12px] font-semibold text-foreground underline-offset-2 hover:text-foreground hover:underline focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
+        className="rounded px-0.5 text-[12px] font-semibold text-foreground underline decoration-border underline-offset-2 hover:text-foreground hover:decoration-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
         title={`Open on ${reviewHostLabel}`}
         onClick={onOpenReview}
       >
diff --git a/src/renderer/src/components/right-sidebar/SourceControl.hosted-review-header-link.test.tsx b/src/renderer/src/components/right-sidebar/SourceControl.hosted-review-header-link.test.tsx
index 3dc607a8e46..4ed326fb9ed 100644
--- a/src/renderer/src/components/right-sidebar/SourceControl.hosted-review-header-link.test.tsx
+++ b/src/renderer/src/components/right-sidebar/SourceControl.hosted-review-header-link.test.tsx
@@ -31,6 +31,7 @@ describe('HostedReviewHeaderLink', () => {
 
     expect(markup).toContain('<button')
     expect(markup).toContain('PR #2192')
+    expect(markup).toContain('underline decoration-border underline-offset-2')
     expect(markup).not.toContain('href=')
     expect(markup).not.toContain('target="_blank"')
 
diff --git a/src/renderer/src/components/right-sidebar/SourceControl.tsx b/src/renderer/src/components/right-sidebar/SourceControl.tsx
index fe6cddfddb9..2c1154aad2b 100644
--- a/src/renderer/src/components/right-sidebar/SourceControl.tsx
+++ b/src/renderer/src/components/right-sidebar/SourceControl.tsx
@@ -1004,7 +1004,7 @@ export function HostedReviewHeaderLink({
 }): React.JSX.Element {
   const label = hostedReviewLabel(review)
   const className =
-    'shrink-0 border-0 bg-transparent p-0 text-left font-medium leading-none text-foreground opacity-80 hover:text-foreground hover:underline'
+    'shrink-0 border-0 bg-transparent p-0 text-left font-medium leading-none text-foreground underline decoration-border underline-offset-2 opacity-80 hover:text-foreground hover:decoration-foreground'
 
   if (review.provider === 'github' || review.provider === 'gitlab') {
     return (