From 4ba241c00e521d74b1ec2cabfe36d5faef53ac63 Mon Sep 17 00:00:00 2001 From: Neil Date: Wed, 11 Nov 2026 16:21:13 -0800 Subject: [PATCH] fix(cloud): a paste that isn't a code shows the refusal instead of nothing --- src/main/orca-cloud-agents/claude-setup-code.test.ts | 3 +++ src/main/orca-cloud-agents/claude-setup-run.ts | 7 +++++++ src/main/orca-cloud-agents/orca-cloud-agents-service.ts | 1 + 3 files changed, 11 insertions(+) diff --git a/src/main/orca-cloud-agents/claude-setup-code.test.ts b/src/main/orca-cloud-agents/claude-setup-code.test.ts index 104033627ec..b2544a01ffe 100644 --- a/src/main/orca-cloud-agents/claude-setup-code.test.ts +++ b/src/main/orca-cloud-agents/claude-setup-code.test.ts @@ -176,6 +176,9 @@ describe('service: the code from the strip, Settings or the chat UI', () => { canReopen: true }) expect(service.submitClaudeCode('not a code')).toEqual({ ok: false, error: 'invalid_code' }) + // A paste that isn't a code shows the refusal; the CLI never sees it. + expect(service.setups().claude).toMatchObject({ phase: 'browser', code: 'rejected' }) + expect(children[0]!.writes).toEqual([]) expect(service.submitClaudeCode(` ${CODE} `)).toEqual({ ok: true, value: true }) expect(service.setups().claude).toMatchObject({ phase: 'browser', code: 'checking' }) expect(children[0]!.writes[0]).toBe(CODE) diff --git a/src/main/orca-cloud-agents/claude-setup-run.ts b/src/main/orca-cloud-agents/claude-setup-run.ts index bc6819025f7..e0927aec250 100644 --- a/src/main/orca-cloud-agents/claude-setup-run.ts +++ b/src/main/orca-cloud-agents/claude-setup-run.ts @@ -13,6 +13,8 @@ export type ClaudeSetupRun = { url: () => string | null /** Types a (normalized) code into the waiting CLI; false when it can't take one now. */ submit: (code: string) => boolean + /** A paste that isn't a code at all: shown like a refused code, and the CLI never sees it. */ + refuse: () => void /** Abandons the run (cancel, sign-out, paste instead); nothing it reports afterwards lands. */ stop: () => void } @@ -105,6 +107,11 @@ export function startClaudeSetupRun(args: { browser({ code: 'checking' }) return true }, + refuse: () => { + if (live && submitter) { + browser({ code: 'rejected' }) + } + }, stop: () => { live = false url = null diff --git a/src/main/orca-cloud-agents/orca-cloud-agents-service.ts b/src/main/orca-cloud-agents/orca-cloud-agents-service.ts index 2c8f9073388..4d135c60bed 100644 --- a/src/main/orca-cloud-agents/orca-cloud-agents-service.ts +++ b/src/main/orca-cloud-agents/orca-cloud-agents-service.ts @@ -275,6 +275,7 @@ export function createOrcaCloudAgentsService(deps: OrcaCloudAgentsServiceDeps) { submitClaudeCode: (raw: string): OrcaCloudAgentsResult => { const code = normalizeClaudeSetupCode(raw) if (!code) { + claudeRun?.refuse() return { ok: false, error: 'invalid_code' } } return claudeRun?.submit(code)