From 4d4f0dca2a9f06bd3b2806542816179da7f0d4e9 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sat, 30 May 2026 03:05:44 -0700 Subject: [PATCH] perf: reuse mounted ref in resource usage status (#3595) --- .../status-bar/ResourceUsageStatusSegment.tsx | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx b/src/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx index 2e1b6f0eaaf..c050482cf90 100644 --- a/src/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx +++ b/src/renderer/src/components/status-bar/ResourceUsageStatusSegment.tsx @@ -28,6 +28,7 @@ import { DialogTitle } from '@/components/ui/dialog' import { cn } from '@/lib/utils' +import { useMountedRef } from '@/hooks/useMountedRef' import { activateAndRevealWorktree } from '@/lib/worktree-activation' import { activateTabAndFocusPane } from '@/lib/activate-tab-and-focus-pane' import { installWindowVisibilityInterval } from '@/lib/window-visibility-interval' @@ -695,7 +696,7 @@ export function ResourceUsageStatusSegment({ // somewhere stable for keyboard users. const popoverBodyRef = useRef(null) const popoverBodyFocusFrameRef = useRef(null) - const mountedRef = useRef(true) + const mountedRef = useMountedRef() const cancelPopoverBodyFocusFrame = useCallback((): void => { if (popoverBodyFocusFrameRef.current === null) { @@ -707,13 +708,6 @@ export function ResourceUsageStatusSegment({ useEffect(() => cancelPopoverBodyFocusFrame, [cancelPopoverBodyFocusFrame]) - useEffect(() => { - mountedRef.current = true - return () => { - mountedRef.current = false - } - }, []) - const setPopoverBodyNode = useCallback( (node: HTMLDivElement | null): void => { // Why: the queued post-kill focus is only valid while the popover body exists. @@ -745,7 +739,7 @@ export function ResourceUsageStatusSegment({ setSessionsError(true) } } - }, [runtimeEnvironmentActive]) + }, [mountedRef, runtimeEnvironmentActive]) const daemonActions = useDaemonActions({ onRestartSettled: () => { @@ -1096,7 +1090,7 @@ export function ResourceUsageStatusSegment({ void refreshSessions() } } - }, [cancelPopoverBodyFocusFrame, killConfirm, refreshSessions]) + }, [cancelPopoverBodyFocusFrame, killConfirm, mountedRef, refreshSessions]) const openSpaceResults = useCallback((): void => { setOpen(false)