feat(source-control-ai): support OMP generation (#20624)

* feat(source-control-ai): support OMP text generation Read prompts on stdin, retain OMP configured model by default, and reuse JSON model discovery. Co-authored-by: unknown <1784931579@qq.com> * test(source-control-ai): cover OMP large input and model overrides * fix(omp): keep configured model default out of discovered catalog * fix(omp): hide config default from model discovery catalog * fix(omp): separate terminal discovery from generation defaults * test(omp): keep model probe import compatible with CLI typecheck * test: align Source Control AI registry contracts with OMP --------- Co-authored-by: unknown <1784931579@qq.com>
2026-10-02 08:02:02 +00:00 · 2026-09-19 01:54:50 -07:00
parent ef03188956
commit 4dec64d533
16 changed files with 488 additions and 5 deletions
@@ -0,0 +1,83 @@
+import { planCommitMessageGeneration } from './commit-message-plan'
+import { getAgentModelProbeSpec } from './agent-model-probe-spec'
+import { describe, expect, it } from 'vitest'
+import { getDefaultSettings } from './constants'
+import { getCommitMessageAgentSpec } from './commit-message-agent-spec'
+import { resolveSourceControlAiForOperation } from './source-control-ai'
+
+describe('OMP Source Control AI', () => {
+  it.each(['commitMessage', 'pullRequest', 'branchName'] as const)(
+    'uses the configured OMP default for %s without requiring a model override',
+    (operation) => {
+      const settings = getDefaultSettings('/tmp')
+      settings.defaultTuiAgent = 'omp'
+      const result = resolveSourceControlAiForOperation({ settings, repo: null, operation })
+      expect(result).toMatchObject({
+        ok: true,
+        value: { params: { agentId: 'omp', model: 'default' } }
+      })
+    }
+  )
+  it('delivers large diffs on stdin and keeps generation isolated from tools and extensions', () => {
+    const spec = getCommitMessageAgentSpec('omp')
+    expect(spec?.promptDelivery).toBe('stdin')
+    if (!spec) {
+      throw new Error('Missing OMP spec')
+    }
+    const args = spec.buildArgs({ prompt: 'large diff', model: 'default' })
+    expect(args).toEqual([
+      '--print',
+      '--no-session',
+      '--no-tools',
+      '--no-extensions',
+      '--no-skills',
+      '--no-rules',
+      '--mode',
+      'text'
+    ])
+    expect(
+      spec?.buildArgs({ prompt: '', model: 'provider/exact-model', thinkingLevel: 'low' })
+    ).toEqual([...args, '--model', 'provider/exact-model', '--thinking', 'low'])
+  })
+  it('discovers provider-qualified models through the existing OMP JSON parser', () => {
+    const discovery = getCommitMessageAgentSpec('omp')?.modelDiscovery
+    expect(discovery?.args).toEqual(['models', '--json'])
+    expect(
+      discovery?.parse(
+        JSON.stringify({
+          models: [{ provider: 'provider', id: 'm', selector: 'provider/m', name: 'Model' }]
+        })
+      )
+    ).toEqual([{ id: 'provider/m', label: 'Model', description: 'provider' }])
+  })
+  it.each(['escape', 'literal'] as const)(
+    'plans recipe model overrides with %s path parsing',
+    (backslash) => {
+      const prompt = `diff --git a/a b/a\n${'large patch\n'.repeat(10000)}`
+      const result = planCommitMessageGeneration(
+        {
+          agentId: 'omp',
+          model: 'provider/model',
+          backslash,
+          agentArgs: '--model provider/override'
+        },
+        prompt
+      )
+      expect(result.ok).toBe(true)
+      if (!result.ok) {
+        throw new Error(result.error)
+      }
+      expect(result.plan.stdinPayload).toBe(prompt)
+      expect(result.plan.args).not.toContain(prompt)
+      expect(result.plan.args.filter((arg) => arg === '--model')).toHaveLength(1)
+      expect(result.plan.args).toContain('provider/override')
+      expect(result.plan.args).not.toContain('provider/model')
+    }
+  )
+})
+
+it('does not expose OMP config default as a terminal discovery model', () => {
+  const spec = getAgentModelProbeSpec('omp')
+  expect(spec?.models.some((model) => model.id === 'default')).toBe(false)
+  expect(spec?.defaultModelId).toBe('')
+})