From 53bd6afc022c602f3eb94d83cdfbc209d2db1ec9 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Mon, 13 Jul 2026 12:40:04 -0700 Subject: [PATCH] docs(e2e): note the WINCH bar is illustrative, not a Windows ground truth The reveal repro asserts on pty:getSize convergence; the bottom-bar TUI only makes the pane WINCH-reactive. Record that a long-lived process can miss Node's stdout 'resize' event under Windows ConPTY even when the OS PTY was resized, so future readers don't add a flaky bar-content check. --- tests/e2e/terminal-reveal-stale-pty-resize-repro.spec.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/e2e/terminal-reveal-stale-pty-resize-repro.spec.ts b/tests/e2e/terminal-reveal-stale-pty-resize-repro.spec.ts index 801317ad79f..f2a40b73e67 100644 --- a/tests/e2e/terminal-reveal-stale-pty-resize-repro.spec.ts +++ b/tests/e2e/terminal-reveal-stale-pty-resize-repro.spec.ts @@ -87,6 +87,14 @@ function bottomBarTuiScript(runId: string): string { // Why: redraw ONLY on SIGWINCH, like an idle Claude Code session. Periodic // output would trigger the foreground grid-drift check, which heals the // desync and masks the bug the field reports hit while idle. + // + // The bar is illustrative, NOT the assertion target: this spec asserts on + // pty:getSize converging to xterm's grid. Do not assert on the bar's printed + // cols — Node's `process.stdout.on('resize')` is unreliable under Windows + // ConPTY (no SIGWINCH; a long-lived process can miss the notification while + // the OS PTY is in fact resized), so a bar-content check flakes there even + // though delivery succeeded (confirmed via base-vs-fix A/B + fresh-process + // console read on Windows). return [ 'const draw = () => {', ' const rows = process.stdout.rows || 24',