From 5427f85a82265286e363eb57a7e6ea7a4b779ccc Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sun, 6 Sep 2026 03:45:54 -0700 Subject: [PATCH] diagnostic: retain host job breakaway in MSYS ownership experiment --- .github/workflows/windows-terminal-restart-e2e.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/windows-terminal-restart-e2e.yml b/.github/workflows/windows-terminal-restart-e2e.yml index addf1776bb9..1c805483910 100644 --- a/.github/workflows/windows-terminal-restart-e2e.yml +++ b/.github/workflows/windows-terminal-restart-e2e.yml @@ -45,12 +45,11 @@ jobs: - name: Install dependencies run: pnpm install --frozen-lockfile - - name: Diagnose MSYS automatic breakaway without native breakaway flags + - name: Diagnose strict PTY job with host breakaway retained shell: pwsh run: | $sourcePath = Join-Path (Get-Location) 'node_modules/node-pty/src/win/conpty.cc' $sourceText = [System.IO.File]::ReadAllText($sourcePath) - $sourceText = $sourceText.Replace('JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE | JOB_OBJECT_LIMIT_BREAKAWAY_OK', 'JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE') $sourceText = $sourceText.Replace('jobLimits.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_BREAKAWAY_OK;', 'jobLimits.BasicLimitInformation.LimitFlags = 0;') [System.IO.File]::WriteAllText($sourcePath, $sourceText) node config/scripts/rebuild-native-deps.mjs --force