From 5612349f6c6d953074a5fc660ee6399745f4f445 Mon Sep 17 00:00:00 2001
From: Kelvin Amoaba <97001695+AmoabaKelvin@users.noreply.github.com>
Date: Mon, 16 Nov 2026 21:55:15 +0000
Subject: [PATCH] fix(browser): match toolbar icons to app chrome and make
annotate an icon (#43269)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Drop the address field's 3px focus ring for a hairline border, size the
toolbar buttons like other pane headers (24px, 14px muted icons), and
replace the Annotate split button with one icon. Grab and Draw move to
the icon's right-click menu and the top of the ⋯ menu.
---
.../markup-tools/MarkupDrawButton.tsx | 11 +-
.../address-bar/BrowserAddressBar.tsx | 4 +-
.../assemble-chrome/browser-page-toolbar.tsx | 6 +-
.../extensions/browser-extension-toolbar.tsx | 10 +-
.../feedback/browser-egress-indicator.tsx | 6 +-
.../browser-toolbar-profile-sub.tsx | 8 +-
...n.tsx => browser-annotate-tool-button.tsx} | 197 +++++++++---------
.../browser-chrome-toolbar.fixture.tsx | 116 +++++++++++
.../toolbar/browser-chrome-toolbar.tsx | 40 ++--
.../browser-navigation-control-row.tsx | 21 +-
.../toolbar/browser-reload-control.tsx | 7 +-
.../toolbar/browser-toolbar-menu-dropdown.tsx | 23 +-
.../browser-toolbar-page-display-items.tsx | 4 +-
.../toolbar/use-browser-chrome-tool-fold.ts | 9 +-
.../remote-browser-page-toolbar.tsx | 15 +-
.../doc-preview-artifact-share.tsx | 3 +-
.../doc-preview-document-chip.tsx | 4 +-
.../doc-preview-overflow-menu.tsx | 9 +-
.../workspace-doc/doc-preview-toolbar.tsx | 2 +-
.../use-doc-preview-guest-tools.ts | 2 +-
src/renderer/src/i18n/locales/en.json | 1 -
src/renderer/src/i18n/locales/ja.json | 1 -
src/renderer/src/i18n/locales/zh.json | 1 -
23 files changed, 295 insertions(+), 205 deletions(-)
rename src/renderer/src/components/browser-pane/assemble-chrome/toolbar/{browser-annotate-split-button.tsx => browser-annotate-tool-button.tsx} (52%)
create mode 100644 src/renderer/src/components/browser-pane/assemble-chrome/toolbar/browser-chrome-toolbar.fixture.tsx
diff --git a/src/renderer/src/components/browser-pane/annotate/markup-tools/MarkupDrawButton.tsx b/src/renderer/src/components/browser-pane/annotate/markup-tools/MarkupDrawButton.tsx
index 7b560e7c9b3..75654e197d4 100644
--- a/src/renderer/src/components/browser-pane/annotate/markup-tools/MarkupDrawButton.tsx
+++ b/src/renderer/src/components/browser-pane/annotate/markup-tools/MarkupDrawButton.tsx
@@ -12,7 +12,6 @@ export type MarkupDrawButtonProps = {
active?: boolean
/** Explicitly gate on pane activity: a hidden trigger anchors portaled content at the viewport origin. */
surfaceActive: boolean
- className?: string
}
/** Standalone Draw for surfaces without the element picker (remote and client-hosted pages). */
@@ -20,8 +19,7 @@ export function MarkupDrawButton({
onClick,
disabled,
active,
- surfaceActive,
- className
+ surfaceActive
}: MarkupDrawButtonProps): React.JSX.Element {
const t = useTranslate()
const label = t('auto.components.browser-pane.markup.drawButton', 'Draw on screenshot')
@@ -40,10 +38,9 @@ export function MarkupDrawButton({
{/* Why: wrap in a span so the tooltip still fires when disabled. */}
diff --git a/src/renderer/src/components/browser-pane/assemble-chrome/address-bar/BrowserAddressBar.tsx b/src/renderer/src/components/browser-pane/assemble-chrome/address-bar/BrowserAddressBar.tsx
index a8f70d33a6c..774191ea412 100644
--- a/src/renderer/src/components/browser-pane/assemble-chrome/address-bar/BrowserAddressBar.tsx
+++ b/src/renderer/src/components/browser-pane/assemble-chrome/address-bar/BrowserAddressBar.tsx
@@ -349,7 +349,7 @@ export default function BrowserAddressBar({
ref={setAddressBarFormRef}
data-orca-browser-address-bar-overlay={overlay ? 'true' : undefined}
className={cn(
- 'flex items-center gap-2 rounded-lg bg-muted px-2.5 transition-colors focus-within:bg-background focus-within:ring-[3px] focus-within:ring-ring/50',
+ 'flex items-center gap-2 rounded-lg border border-transparent bg-muted px-2.5 transition-colors focus-within:border-border',
// Position against the toolbar row so the overlay spans it, not the squeezed slot.
overlay
? 'absolute inset-x-2 top-1/2 z-30 h-8 -translate-y-1/2 bg-background shadow-[0_10px_24px_rgba(0,0,0,0.18)]'
@@ -362,7 +362,7 @@ export default function BrowserAddressBar({
submitTypedValue()
}}
>
- {leadingIcon ?? }
+ {leadingIcon ?? }
- state.activeContextualTourId === 'browser' ? state.activeContextualTourStepIndex : null
- )
const localHtmlFilePath = getShareableBrowserArtifactFile(currentBrowserUrl)?.filePath ?? null
// Why the URL check first: every other page skips the workspace-owner lookup on each store write.
const canOpenSourceFile = useAppStore(
@@ -156,7 +153,6 @@ export function BrowserPageToolbar({
) : (
-
+
)
}
@@ -114,9 +114,9 @@ function PinnedActionButton({