starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-03 00:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(orcad): skip the live-terminal runtime hand-over across a protocol bump (#24429)

Browse Source 
* test(orcad): skip the Bun-to-Node live-terminal hand-over across a protocol bump

The last Bun orcad's daemon reports protocol 38 forever, so asserting the
adopted daemon matches this checkout's PROTOCOL_VERSION failed every bump.
Ask the Bun slot's daemon for its protocol once, run the hand-over when it
matches, and skip with the two versions named when it does not: a daemon
at another protocol is never adopted across an update.

* test(orcad): clean up the Bun protocol probe even when its launch fails

The probe's cleanup ran only after a successful launch, so a launch that
timed out or threw left its orcad and daemon running. One finally now
stops the orcad, kills what it launched, and kills any daemon named by a
pid file in the probe's data root.
This commit is contained in:
Jinwoo Hong
2026-10-01 14:28:05 -04:00
committed by GitHub
parent beccdec74c
commit 56c7642aae
2 changed files with 51 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/node-server-tests.yml
+2 -2
View File
@@ -125,8 +125,8 @@ jobs:
pnpm build:orcad-prebuilds --smoke
- run: pnpm build:orcad
# Design D7 upgrade and rollback: the last Bun orcad, built from a main commit that shipped
# it at this PROTOCOL_VERSION, beside this checkout's Node slot. Same lockfile, so its build
# reuses this checkout's node_modules.
# it, beside this checkout's Node slot; the live-terminal hand-over skips once PROTOCOL_VERSION
# moves past the Bun daemon's. Same lockfile, so its build reuses this checkout's node_modules.
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
if: runner.os == 'Linux'
with: