Revamp onboarding notification setup (#2670)

src/shared/constants.ts

@@ -31,7 +31,7 @@ export const DEFAULT_HIDE_SLEEPING_WORKSPACES = false
 
 // Why: the onboarding wizard's last step index. Centralized so backfill,
 // clamps, and UI step references all agree on the same upper bound.
-export const ONBOARDING_FINAL_STEP = 5
+export const ONBOARDING_FINAL_STEP = 6
 
 export const ORCA_BROWSER_PARTITION = 'persist:orca-browser'
 // Why: blank browser tabs must start from an inert guest URL that does not
@@ -120,6 +120,7 @@ export function getDefaultNotificationSettings(): NotificationSettings {
     agentTaskComplete: true,
     terminalBell: false,
     suppressWhenFocused: true,
+    customSoundId: 'system',
     customSoundPath: null,
     customSoundVolume: 100
   }

src/shared/telemetry-events.ts

@@ -441,6 +441,7 @@ const onboardingValueKindSchema = z.enum([
   'agent',
   'theme',
   'notifications',
+  'agent_setup',
   'integrations',
   'repo'
 ])

src/shared/types.ts

@@ -1354,6 +1354,18 @@ export type NotificationSettings = {
   agentTaskComplete: boolean
   terminalBell: boolean
   suppressWhenFocused: boolean
+  customSoundId:
+    | 'system'
+    | 'two-tone'
+    | 'bong'
+    | 'thump'
+    | 'blip'
+    | 'sonar'
+    | 'blop'
+    | 'ding'
+    | 'clack'
+    | 'beep'
+    | 'custom'
   customSoundPath: string | null
   customSoundVolume: number
 }