From 5bca966fc23830001ae95c6bcd3734831050a613 Mon Sep 17 00:00:00 2001
From: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
Date: Thu, 30 Jul 2026 15:38:13 -0700
Subject: [PATCH] test(source-control): align dirty+unavailable intent
 expectation

Create PR preparation is allowed when review lookup is unavailable; only final create stays fail-closed. Update the local-blocker snapshot test to match.
---
 ...trol-hosted-review-creation-eligibility-snapshot.test.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/renderer/src/components/right-sidebar/source-control-hosted-review-creation-eligibility-snapshot.test.ts b/src/renderer/src/components/right-sidebar/source-control-hosted-review-creation-eligibility-snapshot.test.ts
index 13d7bc5dac9..63382aca024 100644
--- a/src/renderer/src/components/right-sidebar/source-control-hosted-review-creation-eligibility-snapshot.test.ts
+++ b/src/renderer/src/components/right-sidebar/source-control-hosted-review-creation-eligibility-snapshot.test.ts
@@ -32,7 +32,7 @@ describe('resolveHostedReviewCreationProviderForTarget', () => {
 })
 
 describe('buildLocalBlockerHostedReviewCreationEligibility', () => {
-  it('reports dirty without offering create intent when the review lookup failed', () => {
+  it('reports dirty with unavailable lookup while still allowing prepare-only Create PR intent', () => {
     const eligibility = buildLocalBlockerHostedReviewCreationEligibility('github', {
       ...featureBranch,
       hasUncommittedChanges: true,
@@ -45,7 +45,7 @@ describe('buildLocalBlockerHostedReviewCreationEligibility', () => {
       nextAction: 'commit',
       reviewLookupOutcome: 'unavailable'
     })
-    // Why: branch guidance can remain specific, but a failed lookup cannot authorize creation.
+    // Why: local prep (stage/commit/push) is safe without lookup authority; final create stays fail-closed in main.
     expect(
       resolveCreatePrIntentEligibility({
         stagedCount: 1,
@@ -56,7 +56,7 @@ describe('buildLocalBlockerHostedReviewCreationEligibility', () => {
         hostedReviewCreation: eligibility,
         branchCommitsAhead: 0
       })
-    ).toEqual({ eligible: false, kind: null })
+    ).toEqual({ eligible: true, kind: 'dirty' })
   })
 
   it('prefers dirty over no_upstream when both apply, matching main-process ordering', () => {