From 5fe78d415b3770cbb50e95f0356791cd44851a4e Mon Sep 17 00:00:00 2001 From: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Date: Wed, 11 Nov 2026 20:04:49 -0800 Subject: [PATCH] test(browser): keep text on the guest when the root frame probe fails --- .../cdp/input/guest-direct-key-input.test.ts | 64 +++++++++++++++---- 1 file changed, 51 insertions(+), 13 deletions(-) diff --git a/src/main/browser/cdp/input/guest-direct-key-input.test.ts b/src/main/browser/cdp/input/guest-direct-key-input.test.ts index bab2a9d759c..03835ffa597 100644 --- a/src/main/browser/cdp/input/guest-direct-key-input.test.ts +++ b/src/main/browser/cdp/input/guest-direct-key-input.test.ts @@ -1,22 +1,60 @@ import { describe, expect, it, vi } from 'vitest' -import { dispatchPageKeyEvent } from './guest-direct-key-input' +import { dispatchPageKeyEvent, routePageTextInsertion } from './guest-direct-key-input' import { createMockWebContents, mockAsWebContents } from '../transport/cdp-ws-proxy-test-harness' +import type * as FocusedFrameRouteModule from './guest-focused-frame-route' -vi.mock('./guest-focused-frame-route', () => ({ - resolveFocusedFrameRoute: async () => ({ kind: 'unknown' }) -})) +const forceUnknownRoute = vi.hoisted(() => ({ enabled: false })) + +vi.mock('./guest-focused-frame-route', async (importActual) => { + const actual = await importActual() + return { + resolveFocusedFrameRoute: (...args: Parameters) => + forceUnknownRoute.enabled + ? Promise.resolve({ kind: 'unknown' }) + : actual.resolveFocusedFrameRoute(...args) + } +}) + +function createGuest() { + const mock = createMockWebContents() + mock.webContents.getType.mockReturnValue('webview') + const insertText = vi.fn(async (_text: string) => {}) + Object.assign(mock.webContents, { insertText }) + return { mock, insertText } +} describe('guest input route admission', () => { it('refuses keys when the focused guest frame cannot be resolved', async () => { - const mock = createMockWebContents() - mock.webContents.getType.mockReturnValue('webview') + forceUnknownRoute.enabled = true + try { + const { mock } = createGuest() + await expect( + dispatchPageKeyEvent( + mockAsWebContents(mock), + { type: 'keyDown', key: 'a', text: 'a' }, + async () => ({}) + ) + ).rejects.toMatchObject({ code: 'browser_input_target_unavailable' }) + expect(mock.webContents.focus).not.toHaveBeenCalled() + } finally { + forceUnknownRoute.enabled = false + } + }) - await expect( - dispatchPageKeyEvent( - mockAsWebContents(mock), - { type: 'keyDown', key: 'a', text: 'a' }, - async () => ({}) - ) - ).rejects.toMatchObject({ code: 'browser_input_target_unavailable' }) + it('keeps text on the guest without borrowing focus when the root frame probe fails', async () => { + const { mock, insertText } = createGuest() + const send = vi.fn(async (method: string) => { + if (method === 'Runtime.evaluate') { + throw new Error('probe context destroyed') + } + return {} + }) + + const route = await routePageTextInsertion(mockAsWebContents(mock), send) + await route.deliver({ text: 'First\nSecond 🙏' }) + + expect(insertText).toHaveBeenCalledWith('First\nSecond 🙏') + expect(mock.webContents.focus).not.toHaveBeenCalled() + expect(send).not.toHaveBeenCalledWith('Input.insertText', expect.anything()) }) })