From 67701bfa14bdbcda7df3e6311edf27af667e2aa2 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Fri, 7 Aug 2026 18:54:26 -0700 Subject: [PATCH] test(ssh): state plainly that the reconnect spec is a forward guard MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was run against an unfixed tree and passed, so it does not prove the STA-3077 fixes and should not be read as if it does. A clean severed transport does not reproduce the field conditions — accumulated duplicate leases, or a source returning needing re-establishment. It keeps its place as a forward guard: it counts the shells the relay actually hosts and pins their PIDs, so a later change that grafts a pane or respawns a shell fails here. Co-authored-by: Orca --- tests/e2e/ssh-reconnect-pane-cardinality.spec.ts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/e2e/ssh-reconnect-pane-cardinality.spec.ts b/tests/e2e/ssh-reconnect-pane-cardinality.spec.ts index 1edd312153a..cc8c8753ef7 100644 --- a/tests/e2e/ssh-reconnect-pane-cardinality.spec.ts +++ b/tests/e2e/ssh-reconnect-pane-cardinality.spec.ts @@ -1,3 +1,18 @@ +/** + * Forward regression guard for pane and remote-PTY cardinality across + * reconnects, run against a real OpenSSH container. + * + * Scope, stated honestly: this spec passes both with and without the STA-3077 + * fixes — it was run against an unfixed tree and did not fail. A clean severed + * transport reconnects without producing the conditions that grafted panes in + * the field, which needed accumulated duplicate leases or a source that came + * back needing re-establishment. So it does NOT prove those fixes; the oracles + * that do are in `src/main/ssh-reattach-pane-cardinality.test.ts`. + * + * It still earns its place: it counts the shells the relay actually hosts, on + * the container, and pins their PIDs — so a future change that grafts a pane or + * kills and respawns a shell fails here. + */ import type { Page, TestInfo } from '@stablyai/playwright-test' import { test, expect } from './helpers/orca-app' import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'