From 68ea5e570fabc001ca2a0142e0efc3aed9e0ee01 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Sun, 26 Jul 2026 18:43:09 -0700 Subject: [PATCH] docs(terminal): correct the last fresh-shell over-claim on the quarantine arm The arming doc still asserted the endpoint "was actually replaced". The signal is a rejected write (dead socket); ensureConnected respawns only on a daemon-gone error, so a transient drop reconnects to the same sessions. This is the doc read before the two call sites already corrected in 3e23dddd14. --- .../components/terminal-pane/terminal-input-quarantine.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/src/components/terminal-pane/terminal-input-quarantine.ts b/src/renderer/src/components/terminal-pane/terminal-input-quarantine.ts index c883dac9a9a..416227702c1 100644 --- a/src/renderer/src/components/terminal-pane/terminal-input-quarantine.ts +++ b/src/renderer/src/components/terminal-pane/terminal-input-quarantine.ts @@ -36,9 +36,9 @@ function containsLineTerminator(data: string): boolean { return LINE_TERMINATORS.some((terminator) => data.includes(terminator)) } -/** Arm only when the endpoint was actually replaced. A recovery that keeps the - * same live shell has no mangled line to suppress, and quarantining there - * would eat a legitimate command. */ +/** Arm only when the endpoint stopped accepting writes and may have been + * replaced. A recovery that always keeps the same live shell has no mangled + * line to suppress, and quarantining there would eat a legitimate command. */ export function armTerminalInputQuarantine(tabId: string, now: number = Date.now()): void { // Prune first: entries are only meaningful for QUARANTINE_MAX_MS, and a tab // closed mid-quarantine would otherwise leave one behind forever.