From 866d46a0b5ae03119b37ecd987d67a2873c71456 Mon Sep 17 00:00:00 2001 From: Neil Date: Wed, 11 Nov 2026 21:21:36 -0800 Subject: [PATCH 1/3] fix(cloud): RR-c1 submit-time validation: Create stays enabled; on Orca Cloud with a folder it stops and shows the error under Project --- .../NewWorkspaceComposerFooter.tsx | 7 +- .../NewWorkspaceComposerProjectSection.tsx | 25 +++- .../run-on/OrcaCloudNeedsRepoLine.tsx | 8 +- .../OrcaCloudNeedsRepoSubmit.fixture.tsx | 133 ++++++++++++++++++ .../new-workspace/run-on/cloud-start-view.ts | 8 +- .../run-on/orca-cloud-needs-repo.test.tsx | 58 ++++++-- .../run-on/use-composer-cloud-start.ts | 18 ++- .../run-on/use-needs-repo-submit-guard.ts | 34 +++++ 8 files changed, 253 insertions(+), 38 deletions(-) create mode 100644 src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoSubmit.fixture.tsx create mode 100644 src/renderer/src/components/new-workspace/run-on/use-needs-repo-submit-guard.ts diff --git a/src/renderer/src/components/new-workspace/NewWorkspaceComposerFooter.tsx b/src/renderer/src/components/new-workspace/NewWorkspaceComposerFooter.tsx index af036a8453d..6d7b407a71f 100644 --- a/src/renderer/src/components/new-workspace/NewWorkspaceComposerFooter.tsx +++ b/src/renderer/src/components/new-workspace/NewWorkspaceComposerFooter.tsx @@ -36,11 +36,8 @@ export function NewWorkspaceComposerFooter({ }: NewWorkspaceComposerFooterProps): React.JSX.Element { const t = useTranslate() // RR-c1: why Create waits (a folder project on Orca Cloud), on hover and for screen readers. + // RR-c1: set only after a Create stopped for it; the button stays enabled and points at the error. const needsRepo = Boolean(cloudStart?.needsGitHubRepo) - const needsRepoReason = t( - 'components.newWorkspace.cloudOnly.needsRepository', - 'Orca Cloud needs a GitHub repository.' - ) return ( <> {createError ? ( @@ -77,7 +74,7 @@ export function NewWorkspaceComposerFooter({ ) : null} - +