From 75ecad41d509ffcd111ff1627b8e95a78d5e40be Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sat, 24 Oct 2026 21:05:19 -0700 Subject: [PATCH] test(git-bash): give ssh-agent a load-tolerant bound in the Windows pane proof (#33287) The detached ssh-agent proof waited 10s for eval "$(ssh-agent -s)" to print its pid. On a loaded runner the shell had already accepted and started the command (OSC 133;C) when the bound tripped; the leading terminal queries are the pane's normal prelude, not a missing marker. Across eight instrumented CI runs the marker took 0.5-1.1s, so keep waiting on the marker but cap it at 30s. --- .../agent-foreground-process-git-bash.win32.test.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/providers/agent-foreground-process-git-bash.win32.test.ts b/src/main/providers/agent-foreground-process-git-bash.win32.test.ts index 20c49ee7250..4c774ce0d92 100644 --- a/src/main/providers/agent-foreground-process-git-bash.win32.test.ts +++ b/src/main/providers/agent-foreground-process-git-bash.win32.test.ts @@ -175,7 +175,8 @@ describeOnWindows("Git Bash launcher shell proof with Orca's real launch", () => await vi.waitFor(() => expect(output).toContain('$'), { timeout: 20_000 }) // ssh-agent forks, setsids off the console, and its Win32 parent exits. proc.write('eval "$(ssh-agent -s)"; echo ORCA_AGENT_$SSH_AGENT_PID\r') - await vi.waitFor(() => expect(output).toMatch(/ORCA_AGENT_\d+/), { timeout: 10_000 }) + // Usually ~1s, but it exceeded 10s on a loaded runner; the bound only catches a hang. + await vi.waitFor(() => expect(output).toMatch(/ORCA_AGENT_\d+/), { timeout: 30_000 }) agentPid = Number(/ORCA_AGENT_(\d+)/.exec(output)?.[1]) await vi.waitFor(async () => expect(await inspect(true)).toBe('no-children'), { timeout: 10_000 @@ -196,5 +197,5 @@ describeOnWindows("Git Bash launcher shell proof with Orca's real launch", () => } proc.kill() } - }, 60_000) + }, 90_000) })