From 77a77981566fd22dcd226ce7d464499ca60dc2b4 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Tue, 30 Jun 2026 11:26:20 -0700 Subject: [PATCH] Fix mobile Source Control primary action styling (#6918) Co-authored-by: Orca --- mobile/src/source-control/MobileSourceControlContent.tsx | 3 ++- .../source-control/MobileSourceControlCreatePrEntry.tsx | 7 ++----- mobile/src/source-control/mobile-source-control-styles.ts | 4 ++-- mobile/src/theme/mobile-theme.ts | 5 ----- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/mobile/src/source-control/MobileSourceControlContent.tsx b/mobile/src/source-control/MobileSourceControlContent.tsx index 8a209d36163..1b50db62479 100644 --- a/mobile/src/source-control/MobileSourceControlContent.tsx +++ b/mobile/src/source-control/MobileSourceControlContent.tsx @@ -51,7 +51,8 @@ export function MobileSourceControlContent({ state }: Props) { } = state const ioBusy = busyAction !== null || openingPath !== null || openingBranchPath !== null const shouldShowGenerateButton = stagedCount > 0 || generatingMessage - const createPrHeroActive = createPrAction.visible && !createPrAction.disabled + const createPrHeroActive = + createPrAction.visible && !createPrAction.disabled && !createPrAction.pushFirst return ( <> diff --git a/mobile/src/source-control/MobileSourceControlCreatePrEntry.tsx b/mobile/src/source-control/MobileSourceControlCreatePrEntry.tsx index 7d14270cca7..c58838e68aa 100644 --- a/mobile/src/source-control/MobileSourceControlCreatePrEntry.tsx +++ b/mobile/src/source-control/MobileSourceControlCreatePrEntry.tsx @@ -28,14 +28,11 @@ export function MobileSourceControlCreatePrEntry({ action }: Props) { accessibilityHint={action.hint} > {action.loading ? ( - + ) : ( )} diff --git a/mobile/src/source-control/mobile-source-control-styles.ts b/mobile/src/source-control/mobile-source-control-styles.ts index 84dd6d166ae..3d22020651f 100644 --- a/mobile/src/source-control/mobile-source-control-styles.ts +++ b/mobile/src/source-control/mobile-source-control-styles.ts @@ -180,7 +180,7 @@ const baseStyles = StyleSheet.create({ createPrButton: { minHeight: 42, borderRadius: radii.button, - backgroundColor: colors.accentBlueCta, + backgroundColor: colors.textPrimary, alignItems: 'center', justifyContent: 'center', flexDirection: 'row', @@ -196,7 +196,7 @@ const baseStyles = StyleSheet.create({ opacity: 0.78 }, createPrButtonText: { - color: colors.onAccentBlue, + color: colors.bgBase, fontSize: typography.bodySize, fontWeight: '700' }, diff --git a/mobile/src/theme/mobile-theme.ts b/mobile/src/theme/mobile-theme.ts index f564f4739cb..76b14415a32 100644 --- a/mobile/src/theme/mobile-theme.ts +++ b/mobile/src/theme/mobile-theme.ts @@ -18,11 +18,6 @@ export const colors = { surfaceBright: '#f5f5f5', accentBlue: '#3b82f6', - // Primary-CTA fill (darker than accentBlue) so white on-fill text/icons clear - // WCAG AA 4.5:1; accentBlue itself is ~3.7:1 on white and stays a link/accent tint. - accentBlueCta: '#2563eb', - // On-fill text/icon color for the primary-CTA button. - onAccentBlue: '#ffffff', statusGreen: '#22c55e', statusAmber: '#f59e0b',