From 7909dad7bad2baeeb2ff58999fd6b98a58a7a599 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Fri, 18 Sep 2026 03:42:48 -0700 Subject: [PATCH] fix(ci): keep mobile patches LF so Windows can parse them (#21439) A Windows checkout CRLF-converted mobile/patches/*.patch because no gitattributes rule covered them, and pnpm rejected the result with ERR_PNPM_INVALID_PATCH, failing package (windows) and the verify aggregate. config/patches/*.patch has been pinned -text for this exact reason; mobile/patches/ was added later and never got the same rule. git ls-files --eol showed all three mobile patches with an empty attr against attr/-text on every config patch. --- .gitattributes | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitattributes b/.gitattributes index 1f031677aab..2f291d4d627 100644 --- a/.gitattributes +++ b/.gitattributes @@ -23,6 +23,9 @@ # runs `git apply` on one must force `-c core.autocrlf=input` rather than trust # the host's setting. See config/scripts/windows-process-tree-gyp-rebuild.mjs. /config/patches/*.patch -text +# Same reason, and pnpm parses these too: a CRLF checkout makes the mobile +# patches unparseable, so Windows packaging dies on ERR_PNPM_INVALID_PATCH. +/mobile/patches/*.patch -text # The xterm bundle hunks also make a diff nobody can read; review the hand-written # source patch under xterm-src/ instead. The sibling patches stay diffable. /config/patches/@xterm__xterm@*.patch -diff