From 7b46cc4aef9b91acdcbe11fc535b3a59f95bcdfb Mon Sep 17 00:00:00 2001
From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>
Date: Wed, 16 Sep 2026 16:57:58 -0700
Subject: [PATCH] test(orchestration): name the migration-revert helper for its
 domain role
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The rename to revertToV41Shape tripped the naming audit — "shape" describes
structure rather than what the helper does, which is undo the principal migration.
---
 .../db/schema/principal-column-migration.test.ts            | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/runtime/orchestration/db/schema/principal-column-migration.test.ts b/src/main/runtime/orchestration/db/schema/principal-column-migration.test.ts
index 8ead36086a1..3eef5cae8ec 100644
--- a/src/main/runtime/orchestration/db/schema/principal-column-migration.test.ts
+++ b/src/main/runtime/orchestration/db/schema/principal-column-migration.test.ts
@@ -12,8 +12,8 @@ const LEAF2 = '22222222-2222-4222-8222-222222222222'
 const LEAF3 = '33333333-3333-4333-8333-333333333333'
 const STRUCTURED_PANE = `structured-agent-session-sess1:${LEAF2}`
 
-/** Puts an already-migrated database back into pre-principal (v41) shape for the direct-unit cases. */
-function revertToV41Shape(db: OrchestrationDb): void {
+/** Undoes the principal migration so the direct-unit cases start from a v41 database. */
+function revertPrincipalMigration(db: OrchestrationDb): void {
   db.db.exec(`
     DROP TRIGGER IF EXISTS trg_runs_remember_coordinator_insert;
     DROP TRIGGER IF EXISTS trg_runs_remember_coordinator_update;
@@ -71,7 +71,7 @@ describe('principal column migration', () => {
   it('v41 -> v42 migrates and backfills by classification, and is idempotent', () => {
     const db = new OrchestrationDb(':memory:')
     try {
-      revertToV41Shape(db)
+      revertPrincipalMigration(db)
       seedV41Rows(db)
       migrateV42.call(db, 41)