test: remove low-value browser, image, and ACP suites (#41329)

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
This commit is contained in:
OrcaWin
2026-11-11 18:30:07 -08:00
committed by GitHub
co-authored by OrcaWin
parent 6f2e3bde15
commit 7bafdc9f0f
10 changed files with 2 additions and 464 deletions
+1 -24
View File
@@ -1,18 +1,4 @@
import type * as HtmlParser from 'hast-util-from-html-isomorphic'
import { describe, expect, it, vi } from 'vitest'
const traversal = vi.hoisted(() => ({ fail: false }))
vi.mock('hast-util-from-html-isomorphic', async (load) => {
const actual = await load<typeof HtmlParser>()
return {
...actual,
fromHtmlIsomorphic: (...args: Parameters<typeof actual.fromHtmlIsomorphic>) => {
if (traversal.fail) {
throw new Error('Optional image HTML could not be parsed')
}
return actual.fromHtmlIsomorphic(...args)
}
}
})
import { describe, expect, it } from 'vitest'
import { githubBodyImageUrls } from './body-image-urls'
const original = 'https://github.com/user-attachments/assets/ce11040a-fb66-4289-927f-547b16dfc488'
@@ -20,15 +6,6 @@ const signed =
'https://private-user-images.githubusercontent.com/1/2-ce11040a-fb66-4289-927f-547b16dfc488.png?jwt=TEST&download=1'
describe('GitHub body image sources', () => {
it('leaves the optional map absent if HTML extraction fails', () => {
traversal.fail = true
try {
expect(githubBodyImageUrls(`![shot](${original})`, `<img src="${signed}">`)).toBeUndefined()
} finally {
traversal.fail = false
}
})
it('matches rendered images to canonical assets without changing editable Markdown', () => {
const body = `![shot](${original})\n<img src="https://github.enterprise/team/repo/assets/42/ab11040a-fb66-4289-927f-547b16dfc488">\n![missing](https://github.com/user-attachments/assets/cc11040a-fb66-4289-927f-547b16dfc488)\n\`https://github.com/user-attachments/assets/dd11040a-fb66-4289-927f-547b16dfc488\``
const html = `<img src="https://private-user-images.githubusercontent.com/1/2-ce11040a-fb66-4289-927f-547b16dfc488.png?jwt=TEST&amp;download=1"><img src="https://github.enterprise/storage/ab11040a-fb66-4289-927f-547b16dfc488.png?jwt=TEST"><code>https://private-user-images.githubusercontent.com/1/dd11040a-fb66-4289-927f-547b16dfc488.png</code>`
@@ -1,109 +0,0 @@
import { beforeEach, describe, expect, it, vi } from 'vitest'
const {
acquireMock,
ghExecFileAsyncMock,
noteRepositoryRateLimitSpendMock,
projectHostAuthenticationErrorMock,
repositoryRateLimitGuardMock,
releaseMock,
runGraphqlMock,
runRestMock
} = vi.hoisted(() => ({
acquireMock: vi.fn(),
ghExecFileAsyncMock: vi.fn(),
noteRepositoryRateLimitSpendMock: vi.fn(),
projectHostAuthenticationErrorMock: vi.fn(),
repositoryRateLimitGuardMock: vi.fn(),
releaseMock: vi.fn(),
runGraphqlMock: vi.fn(),
runRestMock: vi.fn()
}))
vi.mock('./internals', () => ({
acquire: acquireMock,
release: releaseMock,
extractExecError: (err: unknown) => ({
stderr: err instanceof Error ? err.message : String(err),
stdout: ''
}),
ghExecFileAsync: ghExecFileAsyncMock,
rateLimitGuard: () => ({ blocked: false }),
noteRateLimitSpend: vi.fn(),
repositoryRateLimitGuard: repositoryRateLimitGuardMock,
noteRepositoryRateLimitSpend: noteRepositoryRateLimitSpendMock,
projectHostAuthenticationError: projectHostAuthenticationErrorMock,
projectGhExecOptions: (host?: string) => ({ host: host ?? 'github.com' }),
classifyProjectError: (stderr: string) => ({ type: 'unknown', message: stderr }),
rateLimitedError: () => ({ type: 'rate_limited', message: 'rate limited' }),
runGraphql: runGraphqlMock,
runRest: runRestMock,
validateSlugArgs: (owner: string, repo: string) =>
owner && repo ? { ok: true } : { ok: false, error: { type: 'validation_error' } },
assertPositiveInt: (value: number, name: string) =>
Number.isInteger(value) && value > 0
? { ok: true, value }
: { ok: false, error: { type: 'validation_error', message: `${name} invalid` } }
}))
import { updateIssueBySlug } from './mutations'
describe('Project accepted body representations', () => {
beforeEach(() => {
acquireMock.mockReset().mockResolvedValue(undefined)
ghExecFileAsyncMock.mockReset().mockResolvedValue({ stdout: '', stderr: '' })
noteRepositoryRateLimitSpendMock.mockReset()
projectHostAuthenticationErrorMock.mockReset().mockResolvedValue(null)
repositoryRateLimitGuardMock.mockReset().mockReturnValue({ blocked: false })
releaseMock.mockReset()
runRestMock.mockReset().mockResolvedValue({ ok: true, data: {} })
})
it('does not attach a Project issue map from a different accepted body snapshot', async () => {
const body =
'![shot](https://github.com/user-attachments/assets/ce11040a-fb66-4289-927f-547b16dfc488)'
runRestMock.mockResolvedValueOnce({
ok: true,
data: {
body: `${body}\nchanged elsewhere`,
body_html:
'<img src="https://private-user-images.githubusercontent.com/1/ce11040a-fb66-4289-927f-547b16dfc488.png?jwt=TEST">'
}
})
await expect(
updateIssueBySlug({ owner: 'acme', repo: 'widgets', number: 12, updates: { body } })
).resolves.toEqual({ ok: true, bodyImageUrls: undefined })
})
it.each([null, true])(
'finishes a Project compound save with unusable optional HTML (%s)',
async (html) => {
const body =
'![new](https://github.com/user-attachments/assets/ce11040a-fb66-4289-927f-547b16dfc488)'
runRestMock.mockResolvedValueOnce({
ok: true,
data: html === null ? null : { body, body_html: html }
})
await expect(
updateIssueBySlug({
owner: 'acme',
repo: 'widgets',
number: 12,
updates: { body, addLabels: ['saved-label'] }
})
).resolves.toEqual({ ok: true, bodyImageUrls: undefined })
expect(runRestMock).toHaveBeenCalledWith(
[
'-X',
'POST',
'repos/acme/widgets/issues/12/labels',
'--raw-field',
'labels[]=saved-label'
],
undefined,
'core',
{ host: 'github.com' }
)
}
)
})