From 7c08d4070200dc09ae2e62e09de7eace2b429621 Mon Sep 17 00:00:00 2001
From: orca-bug-scan-bot <orca-bug-scan-bot@stably.ai>
Date: Tue, 5 May 2026 14:25:01 -0700
Subject: [PATCH] fix: address pr-bug-scan findings from #1429

Narrowed App.tsx theme useEffect dependency from full settings object to settings?.theme so unrelated settings mutations no longer re-run applyDocumentTheme and kill in-progress UI transitions.
---
 src/renderer/src/App.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/renderer/src/App.tsx b/src/renderer/src/App.tsx
index 00efe96c5a4..4630ad36a04 100644
--- a/src/renderer/src/App.tsx
+++ b/src/renderer/src/App.tsx
@@ -514,7 +514,7 @@ function App(): React.JSX.Element {
       mq.addEventListener('change', handler)
       return () => mq.removeEventListener('change', handler)
     }
-  }, [settings])
+  }, [settings?.theme])
 
   useEffect(() => {
     document.documentElement.style.setProperty(