From 8641b3af0970b030cebbc263233585cc1ef83a4b Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sat, 12 Sep 2026 18:49:34 -0700 Subject: [PATCH] perf: remove repeated sibling scans from cyclic agent lineage cleanup (#20302) --- .../agent-lineage-cycle-cleanup-benchmark.mjs | 90 +++++++++++++++++++ .../dashboard/agent-row-lineage-model.test.ts | 38 ++++++++ .../dashboard/agent-row-lineage-model.ts | 16 ++-- 3 files changed, 134 insertions(+), 10 deletions(-) create mode 100644 config/scripts/agent-lineage-cycle-cleanup-benchmark.mjs diff --git a/config/scripts/agent-lineage-cycle-cleanup-benchmark.mjs b/config/scripts/agent-lineage-cycle-cleanup-benchmark.mjs new file mode 100644 index 00000000000..47407764e0f --- /dev/null +++ b/config/scripts/agent-lineage-cycle-cleanup-benchmark.mjs @@ -0,0 +1,90 @@ +// Run: node --expose-gc config/scripts/agent-lineage-cycle-cleanup-benchmark.mjs [baseline-ref] +import assert from 'node:assert/strict' +import { execFileSync } from 'node:child_process' +import { readFile } from 'node:fs/promises' +import { performance } from 'node:perf_hooks' +import { transform } from 'esbuild' +import { buildCounterbalancedSchedule } from './counterbalanced-benchmark-schedule.mjs' + +const sourcePath = 'src/renderer/src/components/dashboard/agent-row-lineage-model.ts' +const baseline = process.argv[2] ?? '20ab9950654' +const beforeSource = execFileSync('git', ['show', `${baseline}:${sourcePath}`], { + encoding: 'utf8', + windowsHide: true +}) +async function load(source) { + const { code } = await transform(source, { loader: 'ts', format: 'esm' }) + return (await import(`data:text/javascript;base64,${Buffer.from(code).toString('base64')}`)) + .buildAgentRowLineageTree +} +const before = await load(beforeSource) +const after = await load(await readFile(sourcePath, 'utf8')) + +function row(index, parent) { + return { + paneKey: `pane-${index}`, + entry: { + terminalHandle: `term-${index}`, + orchestration: parent === undefined ? undefined : { parentPaneKey: `pane-${parent}` } + } + } +} + +// Exercise duplicate keys, disconnected cycles, missing parents, and handle fallback. +let seed = 7391 +function random(max) { + seed = (Math.imul(seed, 1664525) + 1013904223) >>> 0 + return seed % max +} +for (let sample = 0; sample < 500; sample++) { + const rows = Array.from({ length: 40 }, () => { + const value = row(random(30), random(40)) + value.entry.orchestration.parentTerminalHandle = `term-${random(40)}` + value.entry.orchestration.coordinatorHandle = `term-${random(40)}` + return value + }) + if (sample % 2 === 0) { + rows.unshift(row('root', undefined)) + } + assert.deepEqual(after(rows), before(rows)) +} + +const results = [] +for (const [shape, count] of [ + ['flat', 1000], + ['all-cycles', 1000], + ['mixed-cycles', 100], + ['mixed-cycles', 500], + ['mixed-cycles', 1000] +]) { + const rows = Array.from({ length: count }, (_, index) => + row(index, shape === 'flat' ? undefined : index ^ 1) + ) + if (shape === 'mixed-cycles') { + rows.unshift(row('root', undefined)) + } + assert.deepEqual(after(rows), before(rows)) + for (let warmup = 0; warmup < 30; warmup++) { + before(rows) + after(rows) + } + const samples = { before: [], after: [] } + for (const pair of buildCounterbalancedSchedule(8, 'before', 'after')) { + for (const arm of pair) { + global.gc?.() + const run = arm === 'before' ? before : after + const cpu = process.cpuUsage() + const start = performance.now() + for (let iteration = 0; iteration < 30; iteration++) { + run(rows) + } + const wallMs = (performance.now() - start) / 30 + const used = process.cpuUsage(cpu) + samples[arm].push({ wallMs, cpuMs: (used.user + used.system) / 30_000 }) + } + } + results.push({ shape, count, samples }) +} +console.log( + JSON.stringify({ baseline, node: process.version, parityGraphs: 500, results }, null, 2) +) diff --git a/src/renderer/src/components/dashboard/agent-row-lineage-model.test.ts b/src/renderer/src/components/dashboard/agent-row-lineage-model.test.ts index 458f0dd9bb1..016d1503e76 100644 --- a/src/renderer/src/components/dashboard/agent-row-lineage-model.test.ts +++ b/src/renderer/src/components/dashboard/agent-row-lineage-model.test.ts @@ -212,3 +212,41 @@ describe('buildAgentRowLineageTree', () => { ]) }) }) + +describe('unreachable lineage cleanup', () => { + it('bounds pane-key reads while flattening disconnected cycles', () => { + let paneKeyReads = 0 + const root = makeRow('root') + const cycles = Array.from({ length: 200 }, (_, index) => { + const row = makeRow(`cycle-${index}`, { parentPaneKey: `cycle-${index ^ 1}` }) + Object.defineProperty(row, 'paneKey', { + get() { + paneKeyReads++ + return `cycle-${index}` + } + }) + return row + }) + const tree = buildAgentRowLineageTree([root, ...cycles]) + const measuredReads = paneKeyReads + expect(tree.rootRows).toEqual([root, ...cycles]) + expect(tree.childrenByParentPaneKey.size).toBe(0) + expect(tree.childPaneKeys.size).toBe(0) + expect(measuredReads).toBeLessThanOrEqual(cycles.length * 20) + }) + + it('preserves reachable edges and promotes the first disconnected duplicate in input order', () => { + const root = makeRow('root') + const child = makeRow('child', { parentPaneKey: 'root' }) + const first = makeRow('cycle-a', { parentPaneKey: 'cycle-b' }) + const second = makeRow('cycle-b', { parentPaneKey: 'cycle-a' }) + const duplicate = makeRow('cycle-a', { parentPaneKey: 'cycle-b' }) + const descendant = makeRow('descendant', { parentPaneKey: 'cycle-b' }) + const tree = buildAgentRowLineageTree([first, root, child, second, duplicate, descendant]) + + expect(tree.rootRows).toEqual([root, first, second, descendant]) + expect(tree.rootRows[1]).toBe(first) + expect([...tree.childrenByParentPaneKey]).toEqual([['root', [child]]]) + expect([...tree.childPaneKeys]).toEqual(['child']) + }) +}) diff --git a/src/renderer/src/components/dashboard/agent-row-lineage-model.ts b/src/renderer/src/components/dashboard/agent-row-lineage-model.ts index 1770ba71eba..11f61a2755a 100644 --- a/src/renderer/src/components/dashboard/agent-row-lineage-model.ts +++ b/src/renderer/src/components/dashboard/agent-row-lineage-model.ts @@ -107,20 +107,16 @@ export function buildAgentRowLineageTree( const normalizedChildrenByParentPaneKey = new Map(childrenByParentPaneKey) const normalizedChildPaneKeys = new Set(childPaneKeys) + const promotedPaneKeys = new Set() for (const row of unreachableRows) { - if (!rootRows.some((rootRow) => rootRow.paneKey === row.paneKey)) { - rootRows.push(row) + if (promotedPaneKeys.has(row.paneKey)) { + continue } + promotedPaneKeys.add(row.paneKey) + rootRows.push(row) normalizedChildPaneKeys.delete(row.paneKey) + // Every child of a reachable parent is reachable, so only these parent lists need removal. normalizedChildrenByParentPaneKey.delete(row.paneKey) - for (const [parentPaneKey, siblings] of normalizedChildrenByParentPaneKey) { - const visibleSiblings = siblings.filter((sibling) => sibling.paneKey !== row.paneKey) - if (visibleSiblings.length === 0) { - normalizedChildrenByParentPaneKey.delete(parentPaneKey) - } else if (visibleSiblings.length !== siblings.length) { - normalizedChildrenByParentPaneKey.set(parentPaneKey, visibleSiblings) - } - } } return {