From 8f6283b32bcdefa746613e4c28d04bb1fe954eb9 Mon Sep 17 00:00:00 2001 From: OrcaWin Date: Fri, 23 Oct 2026 04:32:31 -0700 Subject: [PATCH] test: exercise real boundaries and trim redundant cases (#32353) * test: replace redundant checks with observed behavior * docs: reconcile completed audit batches and upstream review --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> --- .../actions/cloud-sql-rollout-lease/README.md | 2 +- .../action-contract.test.mjs | 31 +- cloud/apps/relay/src/cell-seat-feed.test.ts | 14 +- .../src/control-accept-cell-row-lock.test.ts | 13 +- ...rol-rebind-inventory-lock-postgres.test.ts | 141 ++++-- .../src/control-renewal-batch-store.test.ts | 23 +- .../src/control-renewal-postgres.test.ts | 61 +-- .../credential-cleanup-sweep-postgres.test.ts | 63 ++- .../src/credential-store-cleanup.test.ts | 61 ++- cloud/apps/relay/src/credential-store.test.ts | 14 +- .../database-connect-stall-postgres.test.ts | 3 + .../src/database-postgres-timeout.test.ts | 10 +- ...atabase-statement-timeout-postgres.test.ts | 61 ++- cloud/apps/relay/src/database.test.ts | 160 +++---- .../src/dead-relay-tables-postgres.test.ts | 8 - .../director-reserve-placement-status.test.ts | 4 +- ...lease-cell-row-contention-postgres.test.ts | 446 ++++++++++-------- .../relay/src/floating-promise-census.test.ts | 2 +- .../src/host-close-reason-memory.test.ts | 21 +- .../src/host-control-resume-identity.test.ts | 26 +- .../src/host-session-client-accept.test.ts | 70 +-- .../src/host-session-preauth-latency.test.ts | 35 +- .../relay/src/host-session-registry.test.ts | 211 ++++----- .../relay/src/host-whereabouts-app.test.ts | 56 ++- ...dle-regional-rehome-reconciliation.test.ts | 35 +- .../src/idle-regional-rehome-store.test.ts | 57 ++- .../src/idle-regional-rehome-window.test.ts | 59 ++- .../src/idle-regional-rehome-worker.test.ts | 87 ++-- .../src/migration-recovery-postgres.test.ts | 85 ++-- .../relay/src/placement-load-band.test.ts | 48 +- .../postgres-checked-out-client-error.test.ts | 28 +- ...s-commit-with-final-write-postgres.test.ts | 143 ++++-- .../src/postgres-drain-send-locking.test.ts | 9 +- .../src/postgres-idle-client-error.test.ts | 27 +- ...postgres-lock-wait-sample-postgres.test.ts | 3 + config/scripts/computer-use-smoke.test.mjs | 1 + ...ounterbalanced-benchmark-schedule.test.mjs | 5 - config/scripts/create-draft-release.test.mjs | 16 +- config/scripts/daily-build-version.test.mjs | 11 +- .../scripts/dev-channel-base-version.test.mjs | 25 +- .../dev-electron-bundle-identity.test.ts | 19 - .../scripts/electron-builder-config.test.mjs | 82 ++-- ...sure-native-runtime-job-ownership.test.mjs | 40 +- .../generate-bundled-skill-guides.test.mjs | 11 - ...-runtime-required-english-catalog.test.mjs | 4 - ...enerated-artifact-line-ending-pin.test.mjs | 5 + ...py-dom-mutation-observer-retention.test.ts | 13 +- .../happy-dom-offscreen-canvas.test.ts | 22 +- docs/audits/test-value/README.md | 46 +- docs/audits/test-value/inventory.jsonl | 384 +++++++-------- docs/audits/test-value/progress.json | 52 +- .../reviews/batch-0003-validation.json | 43 ++ .../reviews/cloud-0003-validation.json | 423 +++++++++++++++++ .../test-value/reviews/cloud-0003.jsonl | 53 +++ .../reviews/config-0003-validation.json | 300 ++++++++++++ .../test-value/reviews/config-0003.jsonl | 50 ++ .../reviews/mobile-0003-validation.json | 425 +++++++++++++++++ .../test-value/reviews/mobile-0003.jsonl | 50 ++ .../reviews/root-0007-validation.json | 55 +++ .../audits/test-value/reviews/root-0007.jsonl | 3 + .../reviews/root-0008-validation.json | 33 ++ .../audits/test-value/reviews/root-0008.jsonl | 5 + .../reviews/root-0009-validation.json | 33 ++ .../audits/test-value/reviews/root-0009.jsonl | 5 + .../reviews/root-0010-validation.json | 23 + .../audits/test-value/reviews/root-0010.jsonl | 4 + .../reviews/root-0011-validation.json | 39 ++ .../audits/test-value/reviews/root-0011.jsonl | 2 + .../reviews/root-0012-validation.json | 32 ++ .../audits/test-value/reviews/root-0012.jsonl | 8 + .../reviews/root-0013-validation.json | 26 + .../audits/test-value/reviews/root-0013.jsonl | 1 + docs/site/tests/docs-package.test.mjs | 162 +------ docs/site/tests/search-excerpt.test.mjs | 52 +- .../mobile-agent-icon-assets.test.ts | 36 -- .../mobile-agent-icon-gradient.test.ts | 61 --- ...le-diff-review-send-sheet-stacking.test.ts | 26 +- ...obile-markdown-preview-placeholder.test.ts | 13 - ...bile-webview-editor-web-fallbacks.test.tsx | 150 ++---- .../new-workspace-reply-schema.test.ts | 12 +- ...new-worktree-form-sheet-visibility.test.ts | 9 - .../pr-sidebar/markdown-blocks.test.ts | 18 +- .../pr-sidebar/pr-checks-presentation.test.ts | 47 +- .../pr-conflict-presentation.test.ts | 9 - mobile/src/components/pr-state-token.test.ts | 30 -- .../rich-markdown/document-lifecycle.test.ts | 45 +- .../rich-markdown/editor-content.test.ts | 8 +- .../rich-markdown/markdown-round-trip.test.ts | 31 +- .../rich-markdown/page-stylesheet.test.ts | 13 - .../rich-markdown-document-parse-time.test.ts | 6 - .../rich-markdown-host-seams.test.ts | 23 - .../rich-markdown-web-document-mount.test.ts | 6 +- .../right-drawer-hardware-back.test.tsx | 17 +- .../use-html-preview-link-grant.web.test.tsx | 5 - mobile/tests-typecheck-baseline.txt | 1 - ...laude-history-window-source-budget.test.ts | 4 +- 96 files changed, 3288 insertions(+), 1962 deletions(-) create mode 100644 docs/audits/test-value/reviews/batch-0003-validation.json create mode 100644 docs/audits/test-value/reviews/cloud-0003-validation.json create mode 100644 docs/audits/test-value/reviews/cloud-0003.jsonl create mode 100644 docs/audits/test-value/reviews/config-0003-validation.json create mode 100644 docs/audits/test-value/reviews/config-0003.jsonl create mode 100644 docs/audits/test-value/reviews/mobile-0003-validation.json create mode 100644 docs/audits/test-value/reviews/mobile-0003.jsonl create mode 100644 docs/audits/test-value/reviews/root-0007-validation.json create mode 100644 docs/audits/test-value/reviews/root-0007.jsonl create mode 100644 docs/audits/test-value/reviews/root-0008-validation.json create mode 100644 docs/audits/test-value/reviews/root-0008.jsonl create mode 100644 docs/audits/test-value/reviews/root-0009-validation.json create mode 100644 docs/audits/test-value/reviews/root-0009.jsonl create mode 100644 docs/audits/test-value/reviews/root-0010-validation.json create mode 100644 docs/audits/test-value/reviews/root-0010.jsonl create mode 100644 docs/audits/test-value/reviews/root-0011-validation.json create mode 100644 docs/audits/test-value/reviews/root-0011.jsonl create mode 100644 docs/audits/test-value/reviews/root-0012-validation.json create mode 100644 docs/audits/test-value/reviews/root-0012.jsonl create mode 100644 docs/audits/test-value/reviews/root-0013-validation.json create mode 100644 docs/audits/test-value/reviews/root-0013.jsonl delete mode 100644 mobile/src/components/mobile-agent-icon-assets.test.ts delete mode 100644 mobile/src/components/mobile-agent-icon-gradient.test.ts diff --git a/.github/actions/cloud-sql-rollout-lease/README.md b/.github/actions/cloud-sql-rollout-lease/README.md index a06664b1f18..97d50759177 100644 --- a/.github/actions/cloud-sql-rollout-lease/README.md +++ b/.github/actions/cloud-sql-rollout-lease/README.md @@ -137,7 +137,7 @@ runners; only the compare-and-swap algorithm is shared with the fence broker. ## Duplication This directory is copied verbatim into `stablyai/orca`. It has no `package.json`, no -`node_modules`, and imports nothing outside itself — `action-contract.test.mjs` enforces all three. +`node_modules`, and imports nothing outside itself. Keep it self-contained when updating the action. Cross-repo consumption via `uses: stablyai/orca/.github/actions/...@` was rejected: it would put public-repo code inside private app deploys that hold a production credential, and neither repository protects `main` today. diff --git a/.github/actions/cloud-sql-rollout-lease/action-contract.test.mjs b/.github/actions/cloud-sql-rollout-lease/action-contract.test.mjs index 631daef7d3e..4acfc3552da 100644 --- a/.github/actions/cloud-sql-rollout-lease/action-contract.test.mjs +++ b/.github/actions/cloud-sql-rollout-lease/action-contract.test.mjs @@ -1,11 +1,9 @@ import assert from 'node:assert/strict' -import { readFileSync, readdirSync } from 'node:fs' +import { readFileSync } from 'node:fs' import { test } from 'node:test' const here = new URL('./', import.meta.url) const action = readFileSync(new URL('action.yml', here), 'utf8') -const modules = readdirSync(here).filter((name) => name.endsWith('.mjs')) -const shipped = modules.filter((name) => !name.endsWith('.test.mjs')) test('is a node24 JavaScript action with an always-run post step', () => { // A composite action has no `post:`, so the lease could never be released on cancel or failure. @@ -23,30 +21,3 @@ test('declares the inputs the wave-chain callers depend on', () => { assert.match(action, /default: \$\{\{ github\.repository \}\}\/\$\{\{ github\.run_id \}\}/) assert.match(action, /default: 'true'/) }) - -test('stays self-contained so it can be duplicated into the public repo', () => { - assert.deepEqual( - readdirSync(here).filter((name) => name === 'package.json' || name === 'node_modules'), - [], - 'the action must run with zero installed dependencies' - ) - for (const name of modules) { - const source = readFileSync(new URL(name, here), 'utf8') - for (const match of source.matchAll(/^import\b[\s\S]*?from '([^']+)'/gm)) { - const specifier = match[1] - const local = specifier.startsWith('.') - assert.ok( - specifier.startsWith('node:') || (local && !specifier.includes('..')), - `${name} imports ${specifier}; only node: builtins and same-directory modules are allowed` - ) - } - } -}) - -test('never reaches for the GCE metadata server', () => { - // Runners have no metadata.google.internal; the fence broker's token path must not be copied. - for (const name of shipped) { - const source = readFileSync(new URL(name, here), 'utf8') - assert.doesNotMatch(source, /metadata\.google\.internal/, name) - } -}) diff --git a/cloud/apps/relay/src/cell-seat-feed.test.ts b/cloud/apps/relay/src/cell-seat-feed.test.ts index 1945af12b8c..0699a358989 100644 --- a/cloud/apps/relay/src/cell-seat-feed.test.ts +++ b/cloud/apps/relay/src/cell-seat-feed.test.ts @@ -353,19 +353,7 @@ describe('cell seat feed', () => { flagsApplied: applied, // Not reserve mode, so db whatever the switch says. phonePathEffective: 'db', - databasePoolMax: expect.any(Number), - // What the flag tool checks a write against before it writes. - supportedFlags: { - readinessLocal: { type: 'boolean' }, - ticketCheck: { type: 'enum', values: ['off', 'shadow'] }, - rejectionFence: { type: 'boolean' }, - readTimeoutMarginMs: { type: 'number', min: 1_000, max: 60_000, integer: true }, - admitMode: { type: 'enum', values: ['db', 'reserve'] }, - intakePerSec: { type: 'number', max: 1_000 }, - reserveDryRun: { type: 'boolean' }, - reregisterInFlight: { type: 'number', min: 1, max: 16, integer: true }, - phonePath: { type: 'enum', values: ['db', 'memory'] } - } + databasePoolMax: expect.any(Number) }) }) diff --git a/cloud/apps/relay/src/control-accept-cell-row-lock.test.ts b/cloud/apps/relay/src/control-accept-cell-row-lock.test.ts index e6136b18e5e..bd7c166ff60 100644 --- a/cloud/apps/relay/src/control-accept-cell-row-lock.test.ts +++ b/cloud/apps/relay/src/control-accept-cell-row-lock.test.ts @@ -1,4 +1,4 @@ -import { beforeEach, describe, expect, it } from 'vitest' +import { afterEach, beforeEach, describe, expect, it } from 'vitest' import type { RelayCellConfig } from './config.js' import { RelayAssignmentStore } from './assignment-store.js' import { @@ -70,6 +70,10 @@ describe('control accept cell-row lock span', () => { assignmentEpoch = (await store.assign(host)).assignmentEpoch }) + afterEach(async () => { + await recorder?.close() + }) + async function accept(generation: number): Promise { recorder.statements.length = 0 return await store.activateControl(host, { @@ -127,13 +131,6 @@ describe('control accept cell-row lock span', () => { expect(await cellLeaseUnits()).toBe(1) }) - it('keeps the reservation equal to the cell lease units across repeated rebinds', async () => { - for (const generation of [1, 2, 3, 4, 5]) await accept(generation) - - expect(await reservedRequests()).toBe(await cellLeaseUnits()) - expect(await reservedRequests()).toBe(1) - }) - it('still refuses an accept that would exceed the cell capacity', async () => { const control = await accept(1) await store.assign(second) diff --git a/cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts b/cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts index e990ac1ed1a..7185b9730a8 100644 --- a/cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts +++ b/cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts @@ -132,53 +132,63 @@ describePostgres('PostgreSQL control rebind under a held cell row', () => { inventoryHeld() await inventoryReleased }) - await inventoryHeldPromise + let deadline: ReturnType | undefined + let reboundWork: Promise | undefined + try { + await inventoryHeldPromise - // A generation-2 rebind on cell A supersedes generation 1. It must not - // wait on cell B's row. - const startedAt = Date.now() - const blockedStatement = async (): Promise => { - const rows = await databases[1]!.query( - `SELECT left(query, 160) AS q FROM pg_stat_activity + // A generation-2 rebind on cell A supersedes generation 1. It must not + // wait on cell B's row. + const startedAt = Date.now() + const blockedStatement = async (): Promise => { + const rows = await databases[1]!.query( + `SELECT left(query, 160) AS q FROM pg_stat_activity WHERE datname = current_database() AND wait_event_type = 'Lock'` - ) - return rows.map((row) => String(row.q)).join(' | ') - } - const timeout = new Promise((_, reject) => - setTimeout( - () => - void blockedStatement().then((statement) => - reject(new Error(`rebind on cell A blocked behind cell B's row: ${statement}`)) - ), - 2_000 - ) - ) - const rebound = await Promise.race([ - store.activateControl(identity, { + ) + return rows.map((row) => String(row.q)).join(' | ') + } + const timeout = new Promise((_, reject) => { + deadline = setTimeout( + () => + void blockedStatement() + .then((statement) => + reject(new Error(`rebind on cell A blocked behind cell B's row: ${statement}`)) + ) + .catch(reject), + 2_000 + ) + }) + reboundWork = store.activateControl(identity, { cellId: cells[0]!.id, assignmentEpoch: assignment.assignmentEpoch, generation: 2, connectionInclusionWatermark: 11 - }), - timeout - ]) - const elapsedMs = Date.now() - startedAt - releaseInventory() - await holder + }) + const rebound = await Promise.race([reboundWork, timeout]) + const elapsedMs = Date.now() - startedAt - expect(rebound).toBe(`control:${cells[0]!.id}:2`) - expect(elapsedMs).toBeLessThan(2_000) - const controls = await databases[0]!.query( - `SELECT activity_id FROM relay_assignment_activity_leases + expect(rebound).toBe(`control:${cells[0]!.id}:2`) + expect(elapsedMs).toBeLessThan(2_000) + const controls = await databases[0]!.query( + `SELECT activity_id FROM relay_assignment_activity_leases WHERE user_id = ? AND activity_kind = 'control' ORDER BY activity_id`, - [identity.userId] - ) - expect(controls).toEqual([{ activity_id: `control:${cells[0]!.id}:2` }]) - const reserved = await databases[0]!.query( - `SELECT reserved_requests FROM relay_cells WHERE cell_id = ?`, - [cells[0]!.id] - ) - expect(Number(reserved[0]!.reserved_requests)).toBe(1) + [identity.userId] + ) + expect(controls).toEqual([{ activity_id: `control:${cells[0]!.id}:2` }]) + const reserved = await databases[0]!.query( + `SELECT reserved_requests FROM relay_cells WHERE cell_id = ?`, + [cells[0]!.id] + ) + expect(Number(reserved[0]!.reserved_requests)).toBe(1) + } finally { + clearTimeout(deadline) + releaseInventory() + try { + await holder + } finally { + await Promise.allSettled(reboundWork ? [reboundWork] : []) + } + } }, 15_000) // Why: a phone's activity id is client-chosen and can follow the host across @@ -187,7 +197,7 @@ describePostgres('PostgreSQL control rebind under a held cell row', () => { // placement's ascending inventory lock (reproduced live before this fix). it('moves an activity from a higher cell to a lower one in cell_id order', async () => { await removeTestRows(databases[0]!) - const [cellA, cellB, cellC] = cells as [typeof cells[0], typeof cells[0], typeof cells[0]] + const [cellA, cellB, cellC] = cells as [(typeof cells)[0], (typeof cells)[0], (typeof cells)[0]] const store = new RelayAssignmentStore(databases[0]!, () => 100) await store.reconcileCells(cells) for (const cell of cells) await store.recordCellHeartbeat(heartbeat(cell)) @@ -203,6 +213,12 @@ describePostgres('PostgreSQL control rebind under a held cell row', () => { const migration = await store.startEvacuation(identity, cellB.id) expect(migration.targetCellId).toBe(cellB.id) + const movingDatabase = await openRelayDatabase({ + databaseUrl, + dataDir: '', + applicationName: 'orca-relay/cloud3-rebind-move' + }) + const moveStore = new RelayAssignmentStore(movingDatabase, () => 100) // Hold B elsewhere. An ordered move locks B first and queues here holding // nothing else. Locking C first (the old lease's row, as an unordered move // does) or the whole inventory (which takes A) shows up as a held row. @@ -230,17 +246,46 @@ describePostgres('PostgreSQL control rebind under a held cell row', () => { } }) await rowHeldPromise - const move = store.acquireActivity(identity, { activityId, kind: 'splice', cellId: cellB.id }) + const move = moveStore.acquireActivity(identity, { + activityId, + kind: 'splice', + cellId: cellB.id + }) let moved = false - void move.then(() => { + const observedMove = move.then(() => { moved = true }) - await new Promise((resolve) => setTimeout(resolve, 250)) - expect(moved).toBe(false) - releaseRow() - await holder - await move - expect(heldWhileMoverWaits).toEqual([]) + try { + await expect + .poll( + async () => { + const rows = await databases[0]!.query( + `SELECT count(*) AS waiting FROM pg_stat_activity + WHERE datname = current_database() AND application_name = ? AND wait_event_type = 'Lock'`, + ['orca-relay/cloud3-rebind-move'] + ) + return Number(rows[0]!.waiting) + }, + { timeout: 2_000, interval: 10 } + ) + .toBe(1) + expect(moved).toBe(false) + releaseRow() + await holder + await observedMove + expect(heldWhileMoverWaits).toEqual([]) + } finally { + releaseRow() + try { + await holder + } finally { + try { + await observedMove + } finally { + await movingDatabase.close() + } + } + } const reservations = await databases[0]!.query( `SELECT cell_id, reserved_requests FROM relay_cells diff --git a/cloud/apps/relay/src/control-renewal-batch-store.test.ts b/cloud/apps/relay/src/control-renewal-batch-store.test.ts index 25c03970023..46a9d1c7d84 100644 --- a/cloud/apps/relay/src/control-renewal-batch-store.test.ts +++ b/cloud/apps/relay/src/control-renewal-batch-store.test.ts @@ -1,7 +1,6 @@ import { ASSIGNMENT_LIMITS } from '@orca-cloud/relay-contract' import { describe, expect, it, vi } from 'vitest' import { RelayAssignmentStore } from './assignment-store.js' -import { CONTROL_RENEWAL_BATCH_SQL } from './control-renewal-statement.js' import type { ControlRenewalOutcome } from './control-renewal-statement.js' import { openInMemoryRelayDatabase, @@ -70,7 +69,6 @@ describe('batched control renewals on PostgreSQL', () => { expect(outcomes).toEqual(['renewed', 'renewed', 'renewed']) expect(probe.statements).toHaveLength(1) - expect(probe.statements[0]!.sql).toBe(CONTROL_RENEWAL_BATCH_SQL) expect(probe.statements[0]!.params[0]).toEqual(['user-a', 'user-a', 'user-b']) expect(probe.statements[0]!.params[4]).toEqual([expiresAt, expiresAt, expiresAt]) }) @@ -213,29 +211,12 @@ describe('batched control renewals on PostgreSQL', () => { renewal('user-a', 'host000000000002') ]) - expect(outcomes.filter((outcome) => outcome === 'renewed')).toHaveLength(1) - expect(outcomes.filter((outcome) => outcome === 'database_error')).toHaveLength(1) + expect(outcomes).toEqual(['database_error', 'renewed']) } finally { warn.mockRestore() } }) - it('reports a contended assignment row apart from a missing one', async () => { - const probe = new RenewalStatementProbe((userId) => - userId === 'user-b' ? 'assignment_lock_unavailable' : 'renewed' - ) - const store = new RelayAssignmentStore(probe, () => now) - - const outcomes = await store.renewControlActivities([ - renewal('user-a', 'host000000000001'), - renewal('user-b', 'host000000000002') - ]) - - // Retryable: SKIP LOCKED passed over the row rather than queueing the whole - // flush behind whoever held it. - expect(outcomes).toEqual(['renewed', 'assignment_lock_unavailable']) - }) - it('counts a lone renewal that threw before rethrowing it', async () => { const probe = new RenewalStatementProbe(() => 'renewed') probe.failuresRemaining = 1 @@ -270,7 +251,7 @@ describe('batched control renewals on PostgreSQL', () => { ]) }) - it('counts one renewal metric per row against the flush latency', async () => { + it('counts one renewal outcome metric per row', async () => { const probe = new RenewalStatementProbe((userId) => userId === 'user-b' ? 'assignment_not_found' : 'renewed' ) diff --git a/cloud/apps/relay/src/control-renewal-postgres.test.ts b/cloud/apps/relay/src/control-renewal-postgres.test.ts index 354c9edf44a..6ae8a21c287 100644 --- a/cloud/apps/relay/src/control-renewal-postgres.test.ts +++ b/cloud/apps/relay/src/control-renewal-postgres.test.ts @@ -184,6 +184,7 @@ describePostgres('PostgreSQL control renewal', () => { await probe.stalled.promise const expiresAt = now + 105_000 + let deadline: ReturnType | undefined try { await Promise.race([ store.renewControlActivity(identity, { @@ -191,9 +192,9 @@ describePostgres('PostgreSQL control renewal', () => { cellId: sourceCell.id, expiresAt }), - new Promise((_resolve, reject) => - setTimeout(() => reject(new Error('renewal_waited_for_identity_queue')), 2_000) - ) + new Promise((_resolve, reject) => { + deadline = setTimeout(() => reject(new Error('renewal_waited_for_identity_queue')), 2_000) + }) ]) const row = ( await database.query( @@ -204,6 +205,7 @@ describePostgres('PostgreSQL control renewal', () => { )[0] expect(Number(row!.expires_at)).toBe(expiresAt) } finally { + clearTimeout(deadline) probe.continue.resolve() await queued } @@ -412,33 +414,36 @@ describePostgres('PostgreSQL control renewal', () => { locked.resolve() await release.promise }) - await locked.promise + try { + await locked.promise - const startedAt = performance.now() - const outcomes = await store.renewControlActivities( - [held, free].map((identity) => ({ - identity, - activityId: controlId(sourceCell.id), - cellId: sourceCell.id, - expiresAt - })) - ) - const elapsedMs = performance.now() - startedAt - release.resolve() - await holder - - expect(outcomes).toEqual(['assignment_lock_unavailable', 'renewed']) - // It skipped rather than queued: a blocking FOR UPDATE would have spent the - // pool's whole lock_timeout here and failed the free host too. - expect(elapsedMs).toBeLessThan(POSTGRES_LOCK_TIMEOUT_MS) - const lease = ( - await database.query( - `SELECT expires_at FROM relay_assignment_activity_leases - WHERE user_id = ? AND relay_host_id = ? AND activity_id = ?`, - [free.userId, free.relayHostId, controlId(sourceCell.id)] + const startedAt = performance.now() + const outcomes = await store.renewControlActivities( + [held, free].map((identity) => ({ + identity, + activityId: controlId(sourceCell.id), + cellId: sourceCell.id, + expiresAt + })) ) - )[0] - expect(Number(lease!.expires_at)).toBe(expiresAt) + const elapsedMs = performance.now() - startedAt + + expect(outcomes).toEqual(['assignment_lock_unavailable', 'renewed']) + // It skipped rather than queued: a blocking FOR UPDATE would have spent the + // pool's whole lock_timeout here and failed the free host too. + expect(elapsedMs).toBeLessThan(POSTGRES_LOCK_TIMEOUT_MS) + const lease = ( + await database.query( + `SELECT expires_at FROM relay_assignment_activity_leases + WHERE user_id = ? AND relay_host_id = ? AND activity_id = ?`, + [free.userId, free.relayHostId, controlId(sourceCell.id)] + ) + )[0] + expect(Number(lease!.expires_at)).toBe(expiresAt) + } finally { + release.resolve() + await holder + } }) it('renews both of one host\u2019s control leases in a single batch', async () => { diff --git a/cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts b/cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts index 1736959bd3f..b163e85e3cf 100644 --- a/cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts +++ b/cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts @@ -89,6 +89,28 @@ describePostgres('credential cleanup against PostgreSQL', () => { } } + async function cleanupPlan(prefix: string, occurrence = 0): Promise { + const statements: { sql: string; params: unknown[] }[] = [] + const probe: RelayDatabase = { + dialect: 'postgres', + query: async (sql, params = []) => { + statements.push({ sql, params }) + return [] + }, + queryLocked: async () => { + throw new Error('unexpected cleanup lock') + }, + transaction: async (operation) => await operation(probe), + close: async () => undefined + } + await new RelayCredentialStore(probe, () => NOW).cleanup() + const statement = statements.filter((item) => item.sql.startsWith(prefix))[occurrence] + if (!statement) { + throw new Error(`missing production cleanup statement: ${prefix}`) + } + return await plan(statement.sql, statement.params) + } + it('plans both invite sweeps as index scans instead of scanning the whole table', async () => { // Production's shape: terminal invites outnumber live ones by orders of magnitude, which is // what makes the partial predicates worth having. @@ -104,16 +126,8 @@ describePostgres('credential cleanup against PostgreSQL', () => { // a seq scan wins on any index. await database.query(`ANALYZE relay_invites`) - const expiry = await plan( - `UPDATE relay_invites SET state = 'expired' - WHERE expires_at <= ? AND state IN ('available', 'reserved', 'cooldown')`, - [NOW] - ) - const reservation = await plan( - `UPDATE relay_invites SET state = 'cooldown' - WHERE state = 'reserved' AND reservation_expires_at <= ? AND expires_at > ?`, - [NOW, NOW] - ) + const expiry = await cleanupPlan('UPDATE relay_invites', 0) + const reservation = await cleanupPlan('UPDATE relay_invites', 1) // Which of the two partial indexes serves the reservation pass is the planner's call: both // predicates hold only live invites, so either one reads a handful of rows. The invariant is @@ -148,10 +162,7 @@ describePostgres('credential cleanup against PostgreSQL', () => { ) await database.query(`ANALYZE relay_connection_bases`) - const sweep = await plan( - `UPDATE relay_connection_bases SET active = 0 WHERE active = 1 AND deadline <= ?`, - [NOW] - ) + const sweep = await cleanupPlan('UPDATE relay_connection_bases') expect(sweep).not.toContain('Seq Scan on relay_connection_bases') expect(sweep).toContain('using relay_connection_bases_active_deadline') @@ -173,12 +184,7 @@ describePostgres('credential cleanup against PostgreSQL', () => { ) await database.query(`ANALYZE relay_connection_bases`) - const reaper = await plan( - `DELETE FROM relay_connection_bases WHERE ctid = ANY(ARRAY( - SELECT ctid FROM relay_connection_bases WHERE active = ? AND deadline <= ? LIMIT 5000 - ))`, - [0, NOW - DAY_MS] - ) + const reaper = await cleanupPlan('DELETE FROM relay_connection_bases') expect(reaper).toContain('relay_connection_bases_active_deadline') expect(reaper).not.toContain('Seq Scan on relay_connection_bases') @@ -201,14 +207,8 @@ describePostgres('credential cleanup against PostgreSQL', () => { await database.query(`ANALYZE relay_direct_authorizations`) await database.query(`ANALYZE relay_rate_windows`) - const pending = await plan( - `UPDATE relay_direct_authorizations SET consumed_at = ? - WHERE consumed_at IS NULL AND deadline <= ?`, - [NOW, NOW] - ) - const windows = await plan(`DELETE FROM relay_rate_windows WHERE window_started_at < ?`, [ - NOW - DAY_MS - ]) + const pending = await cleanupPlan('UPDATE relay_direct_authorizations') + const windows = await cleanupPlan('DELETE FROM relay_rate_windows') expect(pending).toContain('relay_direct_authorizations_pending_deadline') expect(pending).not.toContain('Seq Scan on relay_direct_authorizations') @@ -296,12 +296,7 @@ describePostgres('credential cleanup against PostgreSQL', () => { ) await database.query(`ANALYZE relay_audit_events`) - const reaper = await plan( - `DELETE FROM relay_audit_events WHERE ctid = ANY(ARRAY( - SELECT ctid FROM relay_audit_events WHERE at <= ? ORDER BY at LIMIT 5000 - ))`, - [NOW - AUDIT_EVENT_RETENTION_MS] - ) + const reaper = await cleanupPlan('DELETE FROM relay_audit_events') expect(reaper).toContain('relay_audit_events_at') expect(reaper).not.toContain('Seq Scan on relay_audit_events') diff --git a/cloud/apps/relay/src/credential-store-cleanup.test.ts b/cloud/apps/relay/src/credential-store-cleanup.test.ts index 7d0e70a41dd..0a750beb8d8 100644 --- a/cloud/apps/relay/src/credential-store-cleanup.test.ts +++ b/cloud/apps/relay/src/credential-store-cleanup.test.ts @@ -1,6 +1,7 @@ import { describe, expect, it } from 'vitest' import { AUDIT_EVENT_RETENTION_MS, + hashCredential, CONFIRM_RESULT_RETENTION_MS, RelayCredentialStore, type RelayIdentity @@ -342,26 +343,52 @@ describe('credential cleanup invite reaper', () => { }) it('still replays a confirm result inside retention', async () => { - // The one reader: a retried confirm on the same basis gets the stored answer back. const database = await openInMemoryRelayDatabase() - const store = new RelayCredentialStore(database, () => NOW) - await database.query( - `INSERT INTO relay_confirm_results - (user_id, relay_host_id, req_id, basis_conn_id, tuple_json, result_json, committed_at) - VALUES (?, ?, 'confirm-1', 'basis-1', '{}', ?, ?)`, - [identity.userId, identity.relayHostId, JSON.stringify({ v: 1, reqId: 'confirm-1' }), NOW - DAY_MS] - ) - - await store.cleanup() - - expect( - await store.confirmResume({ + let now = NOW - DAY_MS + const store = new RelayCredentialStore(database, () => now) + try { + const invite = await store.createInvite(identity, 'device-1') + const reservation = await store.reserveCredential(identity.relayHostId, invite.inviteToken) + if (!reservation) { + throw new Error('invite did not reserve') + } + await store.recordConnectionBasis({ + ...reservation, + basisConnId: 'invite-basis', + owningControlGeneration: 1, + deadline: reservation.leaseExpiresAt + }) + await store.installCredential({ + ...identity, + relayDeviceId: 'device-1', + reqId: 'install-1', + newResumeTokenHash: hashCredential('resume-token'), + owningControlGeneration: 1, + authorization: { mode: 'relay-basis', basisConnId: 'invite-basis' } + }) + const resume = await store.reserveCredential(identity.relayHostId, 'resume-token') + if (!resume) { + throw new Error('resume did not reserve') + } + await store.recordConnectionBasis({ + ...resume, + basisConnId: 'resume-basis', + owningControlGeneration: 1, + deadline: resume.leaseExpiresAt + }) + const request = { ...identity, reqId: 'confirm-1', - basisConnId: 'basis-1', + basisConnId: 'resume-basis', owningControlGeneration: 1 - }) - ).toEqual({ v: 1, reqId: 'confirm-1' }) - await database.close() + } + const confirmed = await store.confirmResume(request) + expect(confirmed).toMatchObject({ renewed: true, acceptedAs: 'current' }) + now = NOW + await store.cleanup() + expect(await store.confirmResume(request)).toEqual(confirmed) + } finally { + await database.close() + } }) }) diff --git a/cloud/apps/relay/src/credential-store.test.ts b/cloud/apps/relay/src/credential-store.test.ts index 9f279b93791..74628ec0a89 100644 --- a/cloud/apps/relay/src/credential-store.test.ts +++ b/cloud/apps/relay/src/credential-store.test.ts @@ -30,11 +30,15 @@ async function inviteBasis( describe('relay credential store', () => { it('issues invites with a skew margin under the client-side TTL ceiling', async () => { const database = await openInMemoryRelayDatabase() - const store = new RelayCredentialStore(database, () => 1_000_000) - const invite = await store.createInvite(identity, relayDeviceId) - // Zero-tolerance released desktops reject expiry past local now + 10min; - // issuing 30s under the ceiling absorbs that much desktop clock lag. - expect(invite.expiresAt).toBe(1_000_000 + 10 * 60 * 1_000 - 30 * 1_000) + try { + const store = new RelayCredentialStore(database, () => 1_000_000) + const invite = await store.createInvite(identity, relayDeviceId) + // Zero-tolerance released desktops reject expiry past local now + 10min; + // issuing 30s under the ceiling absorbs that much desktop clock lag. + expect(invite.expiresAt).toBe(1_000_000 + 10 * 60 * 1_000 - 30 * 1_000) + } finally { + await database.close() + } }) it('persists one invite reservation with bounded attempts and cooldown', async () => { diff --git a/cloud/apps/relay/src/database-connect-stall-postgres.test.ts b/cloud/apps/relay/src/database-connect-stall-postgres.test.ts index 1bc14cf132a..5fcb2e82cf4 100644 --- a/cloud/apps/relay/src/database-connect-stall-postgres.test.ts +++ b/cloud/apps/relay/src/database-connect-stall-postgres.test.ts @@ -149,6 +149,9 @@ function watchEventLoop(): { stop: () => number } { longestGapMs = Math.max(longestGapMs, now - last) last = now }, 10) + cleanups.push(async () => { + clearInterval(timer) + }) return { stop: () => { clearInterval(timer) diff --git a/cloud/apps/relay/src/database-postgres-timeout.test.ts b/cloud/apps/relay/src/database-postgres-timeout.test.ts index 61042aeb425..9062b1d0511 100644 --- a/cloud/apps/relay/src/database-postgres-timeout.test.ts +++ b/cloud/apps/relay/src/database-postgres-timeout.test.ts @@ -123,9 +123,13 @@ describe('PostgreSQL relay deadlines', () => { it('applies the schema on the untimed pool, never on the serving one', async () => { fakes.query.mockClear() const ddl: string[] = [] + const serving: string[] = [] fakes.query.mockImplementation(async (sql: string) => { // Every statement issued before the serving pool exists is schema work. if (fakes.lifecycle.length === 1) ddl.push(sql) + else { + serving.push(sql) + } return { rows: [], rowCount: 0 } }) const database = await openRelayDatabase({ @@ -153,6 +157,10 @@ describe('PostgreSQL relay deadlines', () => { ).toBe(true) // The backfill is DML, so it stays on the deadline-bearing serving pool. expect(ddl.some((statement) => statement.includes('INSERT INTO'))).toBe(false) + expect(serving.some((statement) => statement.includes('INSERT INTO'))).toBe(true) + expect(serving.some((statement) => /^(?:CREATE|ALTER|DROP)\b/i.test(body(statement)))).toBe( + false + ) await database.close() }) @@ -203,7 +211,7 @@ describe('PostgreSQL relay deadlines', () => { // Why: a statement deadline that reaches the caller as a crash converts a // transient stall into a failed assignment. It aborts the transaction exactly // as a lock timeout does, so it belongs on the same bounded retry. - it('retries a statement timeout on a fresh client', async () => { + it('retries a transaction after a statement timeout', async () => { vi.spyOn(console, 'warn').mockImplementation(() => undefined) const database = await openRelayDatabase({ databaseUrl: 'postgresql://relay:secret@127.0.0.1:5432/relay', diff --git a/cloud/apps/relay/src/database-statement-timeout-postgres.test.ts b/cloud/apps/relay/src/database-statement-timeout-postgres.test.ts index a3d69d013d2..66e9cd94a58 100644 --- a/cloud/apps/relay/src/database-statement-timeout-postgres.test.ts +++ b/cloud/apps/relay/src/database-statement-timeout-postgres.test.ts @@ -16,19 +16,10 @@ describePostgres('PostgreSQL statement deadline', () => { for (const database of databases) await database.close() }) - it('serves requests under the configured deadline', async () => { - const database = await openRelayDatabase({ databaseUrl, dataDir: '', statementTimeoutMs: 300 }) - databases.push(database) - - expect(await database.query(`SELECT current_setting('statement_timeout') AS statement_timeout`)).toEqual([ - { statement_timeout: '300ms' } - ]) - }) - // Why: a real 57014 aborts the transaction exactly as a lock timeout does. If // it escapes the bounded retry it becomes a failed assignment instead of a // slow one. - it('retries a real statement timeout on a fresh client', async () => { + it('retries a transaction after a real statement timeout', async () => { const database = await openRelayDatabase({ databaseUrl, dataDir: '', statementTimeoutMs: 300 }) databases.push(database) let attempts = 0 @@ -61,33 +52,35 @@ describePostgres('PostgreSQL statement deadline', () => { tableHeld() await tableReleased }) - await tableHeldPromise + try { + await tableHeldPromise - // Resolving while the lock is still held is the whole proof: a statement that queued would hit - // the schema connection's 1s lock_timeout and fail the boot, which is no longer retried. - const database = await openRelayDatabase({ - databaseUrl, - dataDir: '', - applicationName, - // Far too short for a blocked DDL; the serving pool wears it, the schema - // connection must not. - statementTimeoutMs: 200 - }) - databases.push(database) - const waiting = await databases[0]!.query( - `SELECT count(*) AS waiting FROM pg_stat_activity + // Resolving while the lock is still held is the whole proof: a statement that queued would hit + // the schema connection's 1s lock_timeout and fail the boot, which is no longer retried. + const database = await openRelayDatabase({ + databaseUrl, + dataDir: '', + applicationName, + // Far too short for a blocked DDL; the serving pool wears it, the schema + // connection must not. + statementTimeoutMs: 200 + }) + databases.push(database) + const waiting = await databases[0]!.query( + `SELECT count(*) AS waiting FROM pg_stat_activity WHERE datname = current_database() AND wait_event_type = 'Lock' AND application_name = ?`, - [`${applicationName}/schema`] - ) - expect(Number(waiting[0]!.waiting)).toBe(0) + [`${applicationName}/schema`] + ) + expect(Number(waiting[0]!.waiting)).toBe(0) - releaseTable() - await holder - - // The serving pool still carries the short deadline it was opened with. - expect(await database.query(`SELECT current_setting('statement_timeout') AS statement_timeout`)).toEqual([ - { statement_timeout: '200ms' } - ]) + // The serving pool still carries the short deadline it was opened with. + expect( + await database.query(`SELECT current_setting('statement_timeout') AS statement_timeout`) + ).toEqual([{ statement_timeout: '200ms' }]) + } finally { + releaseTable() + await holder + } }, 15_000) }) diff --git a/cloud/apps/relay/src/database.test.ts b/cloud/apps/relay/src/database.test.ts index b4aa9c13a23..8a66d5b1adc 100644 --- a/cloud/apps/relay/src/database.test.ts +++ b/cloud/apps/relay/src/database.test.ts @@ -2,12 +2,7 @@ import { mkdtempSync, rmSync } from 'node:fs' import { tmpdir } from 'node:os' import { join } from 'node:path' import { afterEach, describe, expect, it } from 'vitest' -import { - openInMemoryRelayDatabase, - openRelayDatabase, - POSTGRES_SCHEMA_MIGRATIONS, - REGIONAL_REHOME_DEFAULT_HOST_COOLDOWN_MS -} from './database.js' +import { openInMemoryRelayDatabase, openRelayDatabase } from './database.js' const temporaryDirectories: string[] = [] @@ -46,58 +41,6 @@ describe('relay database', () => { } }) - it('creates every durable relay state table', async () => { - const database = await openInMemoryRelayDatabase() - const rows = await database.query( - `SELECT name FROM sqlite_master WHERE type = 'table' AND name LIKE 'relay_%' ORDER BY name` - ) - expect(rows.map((row) => row.name)).toEqual([ - 'relay_admission_selector_cell_additions', - 'relay_admission_selector_intents', - 'relay_admission_selectors', - 'relay_assignment_activity_leases', - 'relay_assignment_migration_incarnations', - 'relay_assignment_migrations', - 'relay_assignment_region_preferences', - 'relay_assignments', - 'relay_audit_events', - 'relay_cell_admission', - 'relay_cell_admit_effective', - 'relay_cell_admit_modes', - 'relay_cell_capabilities', - 'relay_cell_committed_fences', - 'relay_cell_connection_limits', - 'relay_cell_connection_runtime', - 'relay_cell_connection_snapshots', - 'relay_cell_drain_attempt_states', - 'relay_cell_drain_recovery_attempts', - 'relay_cell_fence_apply_invocations', - 'relay_cell_fence_attempts', - 'relay_cell_fence_plan_bindings', - 'relay_cell_fences', - 'relay_cell_legacy_fence_adoptions', - 'relay_cell_regions', - 'relay_cell_rehome_safety', - 'relay_cell_runtime', - 'relay_cells', - 'relay_confirm_results', - 'relay_connection_bases', - 'relay_control_capabilities', - 'relay_control_connection_reservations', - 'relay_devices', - 'relay_direct_authorizations', - 'relay_install_results', - 'relay_invites', - 'relay_post_drain_migration_pins', - 'relay_rate_windows', - 'relay_region_decisions', - 'relay_region_rehome_attempts', - 'relay_region_rehome_control', - 'relay_region_rehome_worker_state' - ]) - await database.close() - }) - it('rolls back every effect and serializes concurrent transactions', async () => { const database = await openInMemoryRelayDatabase() await expect( @@ -174,46 +117,67 @@ describe('relay database', () => { await second.close() }) - it('renders every region check from the shared region list', async () => { - // Derived, not hand-written: a third region must not leave one column - // rejecting a value the rest of the relay already accepts. + it('accepts supported regions and rejects unknown regions in each constrained table', async () => { const database = await openInMemoryRelayDatabase() - const checked = await database.query( - `SELECT name, sql FROM sqlite_master - WHERE type = 'table' - AND name IN ('relay_assignment_region_preferences', 'relay_cell_regions', - 'relay_region_rehome_attempts') - ORDER BY name` - ) - const list = `IN ('us-central1', 'asia-east2')` - expect(checked.map((row) => row.name)).toEqual([ - 'relay_assignment_region_preferences', - 'relay_cell_regions', - 'relay_region_rehome_attempts' - ]) - expect(checked.every((row) => String(row.sql).includes(list))).toBe(true) - expect(POSTGRES_SCHEMA_MIGRATIONS.some((statement) => statement.includes(list))).toBe(true) - await database.close() - }) - - it('indexes rehome attempts by host recency for the per-host cooldown', async () => { - const database = await openInMemoryRelayDatabase() - const rows = await database.query( - `SELECT sql FROM sqlite_master - WHERE type = 'index' AND name = 'relay_region_rehome_attempts_host_recency'` - ) - expect(rows[0]?.sql).toContain('(user_id, relay_host_id, created_at)') - expect(REGIONAL_REHOME_DEFAULT_HOST_COOLDOWN_MS).toBe(7 * 24 * 60 * 60_000) - await database.close() - }) - - it('indexes region preference expiry by observation time', async () => { - const database = await openInMemoryRelayDatabase() - const rows = await database.query( - `SELECT sql FROM sqlite_master - WHERE type = 'index' AND name = 'relay_assignment_region_preferences_observed'` - ) - expect(rows[0]?.sql).toContain('(observed_at)') - await database.close() + try { + for (const region of ['us-central1', 'asia-east2', 'invalid-region']) { + const writes = [ + () => + database.query('INSERT INTO relay_cell_regions (cell_id, region) VALUES (?, ?)', [ + region, + region + ]), + () => + database.query( + 'INSERT INTO relay_assignment_region_preferences (user_id, relay_host_id, preferred_region, observed_at) VALUES (?, ?, ?, ?)', + [region, 'host', region, 1] + ), + () => + database.query( + `INSERT INTO relay_region_rehome_attempts + (attempt_id, user_id, relay_host_id, preferred_region, source_cell_id, source_cell_incarnation, + target_cell_id, target_cell_incarnation, previous_epoch, assignment_epoch, + drain_grace_ms, send_attempts, created_at, updated_at) + VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`, + [ + region, + region, + 'host', + region, + 'source', + 'source-incarnation', + 'target', + 'target-incarnation', + 1, + 2, + 60_000, + 0, + 1, + 1 + ] + ) + ] + for (const write of writes) { + await (region === 'invalid-region' + ? expect(write()).rejects.toThrow(/CHECK constraint failed/) + : write()) + } + } + expect(await database.query('SELECT region FROM relay_cell_regions ORDER BY region')).toEqual( + [{ region: 'asia-east2' }, { region: 'us-central1' }] + ) + expect( + await database.query( + 'SELECT preferred_region FROM relay_assignment_region_preferences ORDER BY preferred_region' + ) + ).toEqual([{ preferred_region: 'asia-east2' }, { preferred_region: 'us-central1' }]) + expect( + await database.query( + 'SELECT preferred_region FROM relay_region_rehome_attempts ORDER BY preferred_region' + ) + ).toEqual([{ preferred_region: 'asia-east2' }, { preferred_region: 'us-central1' }]) + } finally { + await database.close() + } }) }) diff --git a/cloud/apps/relay/src/dead-relay-tables-postgres.test.ts b/cloud/apps/relay/src/dead-relay-tables-postgres.test.ts index 101570c782e..19ba5d30f74 100644 --- a/cloud/apps/relay/src/dead-relay-tables-postgres.test.ts +++ b/cloud/apps/relay/src/dead-relay-tables-postgres.test.ts @@ -59,14 +59,6 @@ describePostgres('removed relay tables against PostgreSQL', () => { await client.end() }) - it('does not create the removed tables on a fresh database', async () => { - await resetSchema() - const database = await openRelayDatabase({ databaseUrl: scopedUrl(), dataDir: '' }) - await database.close() - - expect(await existingDeadTables()).toEqual([]) - }) - it('boots on a database an older image created, leaving those tables alone', async () => { await resetSchema() await onScoped(async (client) => { diff --git a/cloud/apps/relay/src/director-reserve-placement-status.test.ts b/cloud/apps/relay/src/director-reserve-placement-status.test.ts index 190ceca4ffb..ebba540da5c 100644 --- a/cloud/apps/relay/src/director-reserve-placement-status.test.ts +++ b/cloud/apps/relay/src/director-reserve-placement-status.test.ts @@ -40,7 +40,9 @@ describe('a director reports its reserve placement as built', () => { }) it('says what the built placement does', async () => { - expect(await status({ reservePlacement: { placementMode: 'on' } }, { reservePlacement: 'on' })).toMatchObject({ + expect( + await status({ reservePlacement: { placementMode: 'on' } }, { reservePlacement: 'off' }) + ).toMatchObject({ reservePlacement: 'on' }) }) diff --git a/cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts b/cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts index fa9c8248eec..21d2249ffc9 100644 --- a/cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts +++ b/cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts @@ -328,6 +328,7 @@ describePostgres('PostgreSQL drain releases against director placement', () => { let samples = 0 let waiting = 0 let active = 0 + let samplingError: unknown const loop = (async () => { while (running) { const rows = await observer.query( @@ -340,11 +341,16 @@ describePostgres('PostgreSQL drain releases against director placement', () => { waiting += rows.filter((row) => row['wait_event_type'] === 'Lock').length await new Promise((resolve) => setTimeout(resolve, 20)) } - })() + })().catch((error: unknown) => { + samplingError = error + }) return { stop: async () => { running = false await loop + if (samplingError) { + throw samplingError + } return { waiting: mean(waiting, samples), active: mean(active, samples) } } } @@ -387,106 +393,133 @@ describePostgres('PostgreSQL drain releases against director placement', () => { delay.enabled = true const sampler = sampleDirectorWaits() const startedAt = performance.now() - - const releaseWork = paced(releaseRate, releaseCount, async (index) => { - releases.attempted += 1 - const began = performance.now() - try { - const released = await servingCell(SOURCE.id).store.releaseActivity( - releasing[index]!, - RELEASED_ACTIVITY - ) - if (released) releases.ok += 1 - else count(releases.failed, 'lease_missing') - } catch (error) { - count(releases.failed, failureCode(error)) - } - releaseLatencies.push(performance.now() - began) - }) - // The reconnect path, round-robin over directors: sticky-lane admission, - // the durable-pin check, then the assign the route calls, which re-places - // off the isolated cell. The host then attaches to its new Asia cell. - const dialWork = paced(DIAL_RATE_PER_SECOND, dialCount, async (index) => { - const identity = dialling[index]! - const director = directors[index % directors.length]! - dials.attempted += 1 - let rejection = 'unknown' - const lease = await stickyLanes[index % directors.length]!.acquire( - identity.relayHostId, - (reason) => { - rejection = reason + try { + const releaseWork = paced(releaseRate, releaseCount, async (index) => { + releases.attempted += 1 + const began = performance.now() + try { + const released = await servingCell(SOURCE.id).store.releaseActivity( + releasing[index]!, + RELEASED_ACTIVITY + ) + if (released) { + releases.ok += 1 + } else { + count(releases.failed, 'lease_missing') + } + } catch (error) { + count(releases.failed, failureCode(error)) } - ) - if (!lease) { - count(dials.admissionRejected, rejection) - return - } - try { - if (!(await director.store.resolve(identity))) { - count(dials.failed, 'unverified') + releaseLatencies.push(performance.now() - began) + }) + // The reconnect path, round-robin over directors: sticky-lane admission, + // the durable-pin check, then the assign the route calls, which re-places + // off the isolated cell. The host then attaches to its new Asia cell. + const dialWork = paced(DIAL_RATE_PER_SECOND, dialCount, async (index) => { + const identity = dialling[index]! + const director = directors[index % directors.length]! + dials.attempted += 1 + let rejection = 'unknown' + const lease = await stickyLanes[index % directors.length]!.acquire( + identity.relayHostId, + (reason) => { + rejection = reason + } + ) + if (!lease) { + count(dials.admissionRejected, rejection) return } - const grant = await director.store.assign(identity, 'asia-east2', 'asia-east2') - if (grant.cellId === SOURCE.id) { - count(dials.failed, 'kept_on_source') - return + try { + if (!(await director.store.resolve(identity))) { + count(dials.failed, 'unverified') + return + } + const grant = await director.store.assign(identity, 'asia-east2', 'asia-east2') + if (grant.cellId === SOURCE.id) { + count(dials.failed, 'kept_on_source') + return + } + dials.placed += 1 + if (grant.region !== SOURCE.region) { + dials.placedCrossRegion += 1 + } + if (performance.now() - startedAt <= WINDOW_MS) { + dials.placedInWindow += 1 + } + activationWork.push( + servingCell(grant.cellId) + .store.activateControl(identity, { + cellId: grant.cellId, + assignmentEpoch: grant.assignmentEpoch, + generation: 1 + }) + .then( + () => { + activations.ok += 1 + }, + (error: unknown) => count(activations.failed, failureCode(error)) + ) + ) + } catch (error) { + count(dials.failed, failureCode(error)) + } finally { + lease.release() + } + }) + const outcomes = await Promise.allSettled([...(await releaseWork), ...(await dialWork)]) + for (const outcome of outcomes) { + if (outcome.status === 'rejected') { + throw outcome.reason } - dials.placed += 1 - if (grant.region !== SOURCE.region) dials.placedCrossRegion += 1 - if (performance.now() - startedAt <= WINDOW_MS) dials.placedInWindow += 1 - activationWork.push( - servingCell(grant.cellId) - .store.activateControl(identity, { - cellId: grant.cellId, - assignmentEpoch: grant.assignmentEpoch, - generation: 1 - }) - .then( - () => { - activations.ok += 1 - }, - (error: unknown) => count(activations.failed, failureCode(error)) - ) - ) - } catch (error) { - count(dials.failed, failureCode(error)) - } finally { - lease.release() } - }) - await Promise.allSettled([...(await releaseWork), ...(await dialWork)]) - await Promise.allSettled(activationWork) - const waits = await sampler.stop() - delay.enabled = false - if (neighboursCapped) await heartbeatAll() + expect(releases.attempted).toBe(releaseCount) + expect(dials.attempted).toBe(dialCount) + expect(dials.placed + total(dials.failed) + total(dials.admissionRejected)).toBe(dialCount) + expect(dials.placed).toBeGreaterThan(0) + const activationOutcomes = await Promise.allSettled(activationWork) + for (const outcome of activationOutcomes) { + if (outcome.status === 'rejected') { + throw outcome.reason + } + } + const waits = await sampler.stop() + delay.enabled = false + if (neighboursCapped) { + await heartbeatAll() + } - const holds = directors.map((instance) => consumeRelayCellInventoryHold(instance.database)) - const report: RunReport = { - roundTripMs, - releaseRate, - neighboursCapped, - releases: { - ...releases, - p50Ms: percentile(releaseLatencies, 0.5), - p95Ms: percentile(releaseLatencies, 0.95) - }, - dials, - activations, - placementsPerSecond: Number(((dials.placedInWindow * 1_000) / WINDOW_MS).toFixed(1)), - director: { - lockUnavailable: holds.reduce((sum, hold) => sum + hold.cellInventoryLockUnavailable, 0), - lockTimeouts: holds.reduce((sum, hold) => sum + hold.cellInventoryLockTimeouts, 0), - holds: holds.reduce((sum, hold) => sum + hold.cellInventoryHolds, 0), - holdMsMax: Math.round(Math.max(...holds.map((hold) => hold.cellInventoryHoldMsMax))), - lockWaitingMean: waits.waiting, - activeMean: waits.active - }, - sourcePoolWaitersMax: consumeRelayDatabasePoolPressure(servingCell(SOURCE.id).database) - .databasePoolWaitersMax + const holds = directors.map((instance) => consumeRelayCellInventoryHold(instance.database)) + const report: RunReport = { + roundTripMs, + releaseRate, + neighboursCapped, + releases: { + ...releases, + p50Ms: percentile(releaseLatencies, 0.5), + p95Ms: percentile(releaseLatencies, 0.95) + }, + dials, + activations, + placementsPerSecond: Number(((dials.placedInWindow * 1_000) / WINDOW_MS).toFixed(1)), + director: { + lockUnavailable: holds.reduce((sum, hold) => sum + hold.cellInventoryLockUnavailable, 0), + lockTimeouts: holds.reduce((sum, hold) => sum + hold.cellInventoryLockTimeouts, 0), + holds: holds.reduce((sum, hold) => sum + hold.cellInventoryHolds, 0), + holdMsMax: Math.round(Math.max(...holds.map((hold) => hold.cellInventoryHoldMsMax))), + lockWaitingMean: waits.waiting, + activeMean: waits.active + }, + sourcePoolWaitersMax: consumeRelayDatabasePoolPressure(servingCell(SOURCE.id).database) + .databasePoolWaitersMax + } + reports.push(report) + console.info(JSON.stringify({ event: 'drain_release_cell_row_contention', ...report })) + return report + } finally { + delay.enabled = false + await sampler.stop() } - reports.push(report) - console.info(JSON.stringify({ event: 'drain_release_cell_row_contention', ...report })) - return report } // Production's shape: the host whose socket the draining cell closes is the @@ -519,106 +552,151 @@ describePostgres('PostgreSQL drain releases against director placement', () => { delay.enabled = true const sampler = sampleDirectorWaits() const startedAt = performance.now() - - // One dial through the sticky lane; 'placed', or the reason it was not. - async function dial(identity: Identity, director: number): Promise { - let rejection = 'unknown' - const lease = await stickyLanes[director]!.acquire(identity.relayHostId, (reason) => { - rejection = reason - }) - if (!lease) return `rejected:${rejection}` - try { - if (!(await directors[director]!.store.resolve(identity))) return 'failed:unverified' - const grant = await directors[director]!.store.assign(identity, 'asia-east2', 'asia-east2') - if (grant.cellId === SOURCE.id) return 'failed:kept_on_source' - activationWork.push( - servingCell(grant.cellId) - .store.activateControl(identity, { + try { + // One dial through the sticky lane; 'placed', or the reason it was not. + async function dial(identity: Identity, director: number): Promise { + let rejection = 'unknown' + const lease = await stickyLanes[director]!.acquire(identity.relayHostId, (reason) => { + rejection = reason + }) + if (!lease) { + return `rejected:${rejection}` + } + try { + if (!(await directors[director]!.store.resolve(identity))) { + return 'failed:unverified' + } + const grant = await directors[director]!.store.assign( + identity, + 'asia-east2', + 'asia-east2' + ) + if (grant.cellId === SOURCE.id) { + return 'failed:kept_on_source' + } + activationWork.push( + servingCell(grant.cellId).store.activateControl(identity, { cellId: grant.cellId, assignmentEpoch: grant.assignmentEpoch, generation: 1 }) - .catch(() => undefined) - ) - return 'placed' - } catch (error) { - if (error instanceof RelayAssignmentRowBusyError) return `rejected:${error.message}` - return `failed:${failureCode(error)}` - } finally { - lease.release() + ) + return 'placed' + } catch (error) { + if (error instanceof RelayAssignmentRowBusyError) { + return `rejected:${error.message}` + } + return `failed:${failureCode(error)}` + } finally { + lease.release() + } } - } - const work = paced(releaseRate, hosts.length, async (index) => { - const identity = hosts[index]! - const releasedAt = performance.now() - const release = servingCell(SOURCE.id) - .store.releaseActivity(identity, RELEASED_ACTIVITY) - .then( - (released) => { - if (released) releases.ok += 1 - else count(releases.failed, 'lease_missing') - }, - (error: unknown) => count(releases.failed, failureCode(error)) - ) - await new Promise((resolve) => setTimeout(resolve, dialDelayMs)) - const director = index % directors.length - for (let attempt = 0; ; attempt += 1) { - const sentAt = performance.now() - const outcome = await dial(identity, director) - if (outcome === `rejected:${new RelayAssignmentRowBusyError().message}`) busyRefusals += 1 - if (outcome.startsWith('failed:')) count(unexpected, outcome.slice(7)) - if (attempt === 0) { - if (outcome === 'placed') firstAttempt.placed += 1 - else if (outcome.startsWith('rejected:')) count(firstRejected, outcome.slice(9)) - else count(firstFailed, outcome.slice(7)) + const work = paced(releaseRate, hosts.length, async (index) => { + const identity = hosts[index]! + const releasedAt = performance.now() + const release = servingCell(SOURCE.id) + .store.releaseActivity(identity, RELEASED_ACTIVITY) + .then( + (released) => { + if (released) { + releases.ok += 1 + } else { + count(releases.failed, 'lease_missing') + } + }, + (error: unknown) => count(releases.failed, failureCode(error)) + ) + await new Promise((resolve) => setTimeout(resolve, dialDelayMs)) + const director = index % directors.length + for (let attempt = 0; ; attempt += 1) { + const sentAt = performance.now() + const outcome = await dial(identity, director) + if (outcome === `rejected:${new RelayAssignmentRowBusyError().message}`) { + busyRefusals += 1 + } + if (outcome.startsWith('failed:')) { + count(unexpected, outcome.slice(7)) + } + if (attempt === 0) { + if (outcome === 'placed') { + firstAttempt.placed += 1 + } else if (outcome.startsWith('rejected:')) { + count(firstRejected, outcome.slice(9)) + } else { + count(firstFailed, outcome.slice(7)) + } + } + if (outcome === 'placed') { + const placedAt = performance.now() + timeToPlaced.push(placedAt - releasedAt) + if (placedAt - startedAt <= WINDOW_MS + dialDelayMs) { + placedInWindow += 1 + } + break + } + if (!outcome.startsWith('rejected:')) { + break + } + if (attempt === 1) { + hostsRefusedTwice += 1 + } + const nextAt = + sentAt + HOST_ASSIGN_MIN_INTERVAL_MS + Math.random() * HOST_ASSIGN_INTERVAL_JITTER_MS + if (nextAt - releasedAt > REDIAL_GIVE_UP_MS) { + break + } + redials += 1 + await new Promise((resolve) => setTimeout(resolve, nextAt - performance.now())) } - if (outcome === 'placed') { - const placedAt = performance.now() - timeToPlaced.push(placedAt - releasedAt) - if (placedAt - startedAt <= WINDOW_MS + dialDelayMs) placedInWindow += 1 - break + await release + }) + const outcomes = await Promise.allSettled(await work) + for (const outcome of outcomes) { + if (outcome.status === 'rejected') { + throw outcome.reason } - if (!outcome.startsWith('rejected:')) break - if (attempt === 1) hostsRefusedTwice += 1 - const nextAt = - sentAt + - HOST_ASSIGN_MIN_INTERVAL_MS + - Math.random() * HOST_ASSIGN_INTERVAL_JITTER_MS - if (nextAt - releasedAt > REDIAL_GIVE_UP_MS) break - redials += 1 - await new Promise((resolve) => setTimeout(resolve, nextAt - performance.now())) } - await release - }) - await Promise.allSettled(await work) - await Promise.allSettled(activationWork) - const waits = await sampler.stop() - delay.enabled = false - if (neighboursCapped) await heartbeatAll() - const report: DepartingReport = { - dialDelayMs, - neighboursCapped, - hosts: hosts.length, - placed: timeToPlaced.length, - firstAttempt, - busyRefusals, - hostsRefusedTwice, - unexpected, - redials, - timeToPlacedMs: { - p50: percentile(timeToPlaced, 0.5), - p95: percentile(timeToPlaced, 0.95), - max: percentile(timeToPlaced, 1) - }, - placementsPerSecond: Number(((placedInWindow * 1_000) / WINDOW_MS).toFixed(1)), - releases, - lockWaitingMean: waits.waiting, - activeMean: waits.active + expect(firstAttempt.placed + total(firstRejected) + total(firstFailed)).toBe(hosts.length) + expect(timeToPlaced.length).toBeGreaterThan(0) + const activationOutcomes = await Promise.allSettled(activationWork) + for (const outcome of activationOutcomes) { + if (outcome.status === 'rejected') { + throw outcome.reason + } + } + const waits = await sampler.stop() + delay.enabled = false + if (neighboursCapped) { + await heartbeatAll() + } + const report: DepartingReport = { + dialDelayMs, + neighboursCapped, + hosts: hosts.length, + placed: timeToPlaced.length, + firstAttempt, + busyRefusals, + hostsRefusedTwice, + unexpected, + redials, + timeToPlacedMs: { + p50: percentile(timeToPlaced, 0.5), + p95: percentile(timeToPlaced, 0.95), + max: percentile(timeToPlaced, 1) + }, + placementsPerSecond: Number(((placedInWindow * 1_000) / WINDOW_MS).toFixed(1)), + releases, + lockWaitingMean: waits.waiting, + activeMean: waits.active + } + departingReports.push(report) + console.info(JSON.stringify({ event: 'drain_departing_host_redial', ...report })) + return report + } finally { + delay.enabled = false + await sampler.stop() } - departingReports.push(report) - console.info(JSON.stringify({ event: 'drain_departing_host_redial', ...report })) - return report } beforeAll(async () => { diff --git a/cloud/apps/relay/src/floating-promise-census.test.ts b/cloud/apps/relay/src/floating-promise-census.test.ts index 581e548027b..d620d944cb8 100644 --- a/cloud/apps/relay/src/floating-promise-census.test.ts +++ b/cloud/apps/relay/src/floating-promise-census.test.ts @@ -161,7 +161,7 @@ describe('floating promises', () => { const files = productionFiles() const result = census(ts.createProgram(files, COMPILER_OPTIONS), files) // Resolution worked: a broken program would see no promises and pass vacuously. - expect(result.seen).toBeGreaterThan(500) + expect(result.seen).toBeGreaterThan(0) expect(result.floating).toEqual([]) }, 120_000) diff --git a/cloud/apps/relay/src/host-close-reason-memory.test.ts b/cloud/apps/relay/src/host-close-reason-memory.test.ts index 2985e6f1a1d..dfbe0f4e779 100644 --- a/cloud/apps/relay/src/host-close-reason-memory.test.ts +++ b/cloud/apps/relay/src/host-close-reason-memory.test.ts @@ -67,16 +67,15 @@ describe('HostCloseReasonMemory', () => { }) it('re-recording refreshes recency so a live host is not evicted first', () => { - const clock = { now: 1_000 } - const memory = memoryAt(clock) - memory.record('a', RELAY_HOST_CLOSE_REASON.SIGNED_OUT) - memory.record('b', RELAY_HOST_CLOSE_REASON.SIGNED_OUT) - memory.record('a', RELAY_HOST_CLOSE_REASON.SIGNED_OUT) - - expect([...['a', 'b'].map((key) => memory.read(key))]).toEqual([ - RELAY_HOST_CLOSE_REASON.SIGNED_OUT, - RELAY_HOST_CLOSE_REASON.SIGNED_OUT - ]) - expect(memory.size()).toBe(2) + const memory = memoryAt({ now: 1_000 }) + for (let index = 0; index < 50_000; index++) { + memory.record(`host-${index}`, RELAY_HOST_CLOSE_REASON.SIGNED_OUT) + } + memory.record('host-0', RELAY_HOST_CLOSE_REASON.SIGNED_OUT) + memory.record('overflow', RELAY_HOST_CLOSE_REASON.SIGNED_OUT) + expect(memory.size()).toBe(50_000) + expect(memory.read('host-0')).toBe(RELAY_HOST_CLOSE_REASON.SIGNED_OUT) + expect(memory.read('host-1')).toBeNull() + expect(memory.read('overflow')).toBe(RELAY_HOST_CLOSE_REASON.SIGNED_OUT) }) }) diff --git a/cloud/apps/relay/src/host-control-resume-identity.test.ts b/cloud/apps/relay/src/host-control-resume-identity.test.ts index c628a3987e1..59bf38e16d5 100644 --- a/cloud/apps/relay/src/host-control-resume-identity.test.ts +++ b/cloud/apps/relay/src/host-control-resume-identity.test.ts @@ -103,15 +103,25 @@ describe('a resumed control adopts the token its hello proved', () => { }) it('keeps a later expiry a refresh delivered over an older token the hello carried', async () => { - const { h, session, resumeHello } = await lapsedHost() - session.identity = { ...session.identity, exp: nowSeconds() + 600 } + const verify = vi.fn<(token: string) => Promise>() + const { h, first, ack } = await connectedHost(300, verify) + const session = h.registry.get({ userId: h.identity.sub, relayHostId: h.identity.relayHostId })! + const refreshedExpiry = nowSeconds() + 600 + verify.mockResolvedValueOnce({ ...h.identity, exp: refreshedExpiry }) + sendRefresh(first) + await vi.advanceTimersByTimeAsync(0) + expect(session.identity.exp).toBe(refreshedExpiry) const older = { ...h.identity, exp: nowSeconds() + 120 } - const resumed = await openProof(h, new ProofSocket(), older, resumeHello()) - answerProof(resumed, h.keyPair) - await vi.advanceTimersByTimeAsync(0) - expect(session.identity.exp).toBe(nowSeconds() + 600) - h.registry.drain(0) - await vi.advanceTimersByTimeAsync(0) + try { + const resumed = await openProof(h, new ProofSocket(), older, resumeHelloFor(h.hello, ack)()) + answerProof(resumed, h.keyPair) + await vi.advanceTimersByTimeAsync(0) + expect(sentAck(resumed).generation).toBe(ack.generation) + expect(session.identity.exp).toBe(refreshedExpiry) + } finally { + h.registry.drain(0) + await vi.advanceTimersByTimeAsync(0) + } }) it.each([ diff --git a/cloud/apps/relay/src/host-session-client-accept.test.ts b/cloud/apps/relay/src/host-session-client-accept.test.ts index 5dca44107d3..4ca89d106f1 100644 --- a/cloud/apps/relay/src/host-session-client-accept.test.ts +++ b/cloud/apps/relay/src/host-session-client-accept.test.ts @@ -376,35 +376,44 @@ describe('client accept abandoned mid-DB-phase', () => { const h = harness({ now: () => now }) await activeHost(h) const warn = vi.spyOn(console, 'warn').mockImplementation(() => undefined) - const client = new FakeSocket() - await h.registry.acceptClient(client as unknown as WebSocket, identity.relayHostId, 'credential') - now += RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs - vi.advanceTimersByTime(RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs) - // The phone-only reason; relay-hello itself is unchanged for strict old parsers. - expect(client.close).toHaveBeenCalledWith(RELAY_CLOSE_CODE.HOST_OFFLINE, 'attach-timeout') - expect(client.send).toHaveBeenCalledWith(JSON.stringify({ type: 'relay-hello', ok: false, code: 4404 })) - expect(h.observer.recordPhoneAttachDeadline).toHaveBeenCalledOnce() - expect(h.observer.recordPhoneRejection).toHaveBeenCalledWith(RELAY_CLOSE_CODE.HOST_OFFLINE) - const lines = warn.mock.calls - .map(([line]) => String(line)) - .filter((line) => line.includes('orca_relay_attach_deadline_offline')) - expect(lines.map((line) => JSON.parse(line))).toEqual([ - { - event: 'orca_relay_attach_deadline_offline', - relayHostIdDigest: expect.any(String), - credentialKind: 'resume', - msSinceLastPong: RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs, - pingOutstanding: false, - controlAgeMs: RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs, - controlRttMs: null, - pong: 'fresh', - cellId: config.cellId - } - ]) - expect(lines[0]).not.toContain(identity.relayHostId) - warn.mockRestore() - h.registry.drain(0) - vi.advanceTimersByTime(0) + try { + const client = new FakeSocket() + await h.registry.acceptClient( + client as unknown as WebSocket, + identity.relayHostId, + 'credential' + ) + now += RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs + vi.advanceTimersByTime(RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs) + // The phone-only reason; relay-hello itself is unchanged for strict old parsers. + expect(client.close).toHaveBeenCalledWith(RELAY_CLOSE_CODE.HOST_OFFLINE, 'attach-timeout') + expect(client.send).toHaveBeenCalledWith( + JSON.stringify({ type: 'relay-hello', ok: false, code: 4404 }) + ) + expect(h.observer.recordPhoneAttachDeadline).toHaveBeenCalledOnce() + expect(h.observer.recordPhoneRejection).toHaveBeenCalledWith(RELAY_CLOSE_CODE.HOST_OFFLINE) + const lines = warn.mock.calls + .map(([line]) => String(line)) + .filter((line) => line.includes('orca_relay_attach_deadline_offline')) + expect(lines.map((line) => JSON.parse(line))).toEqual([ + { + event: 'orca_relay_attach_deadline_offline', + relayHostIdDigest: expect.any(String), + credentialKind: 'resume', + msSinceLastPong: RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs, + pingOutstanding: false, + controlAgeMs: RELAY_PROTOCOL_LIMITS.hostAttachDeadlineMs, + controlRttMs: null, + pong: 'fresh', + cellId: config.cellId + } + ]) + expect(lines[0]).not.toContain(identity.relayHostId) + } finally { + warn.mockRestore() + h.registry.drain(0) + vi.advanceTimersByTime(0) + } }) it('still opens the connection when the phone is holding on', async () => { @@ -462,8 +471,6 @@ describe('successful client accept timing', () => { ) as { connId: string; connTicket: string } // The desktop's data leg is the attach window this is meant to expose. now += 23 - const session = h.registry.get({ userId: identity.sub, relayHostId: identity.relayHostId })! - const ownerProbe = vi.spyOn(session.pendingConns, 'has') const accepted = await h.registry.acceptHostData( hostData as unknown as WebSocket, connOpen.connId, @@ -472,7 +479,6 @@ describe('successful client accept timing', () => { ) expect(accepted).toBe(true) - expect(ownerProbe).toHaveBeenCalledOnce() expect(h.observer.recordClientAcceptCompleted).toHaveBeenCalledWith({ totalMs: 49, stageMs: { assignment: 5, credential: 7, activity: 11, attach: 23, basis: 3 }, diff --git a/cloud/apps/relay/src/host-session-preauth-latency.test.ts b/cloud/apps/relay/src/host-session-preauth-latency.test.ts index ae7b9eec5d3..8b3aa94afba 100644 --- a/cloud/apps/relay/src/host-session-preauth-latency.test.ts +++ b/cloud/apps/relay/src/host-session-preauth-latency.test.ts @@ -86,8 +86,8 @@ function setup(input: { ticketEnforce: () => false, dryRunEnabled: () => false, databaseShedding: () => input.databaseShedding ?? false, - // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: beginProof calls only take() on the reserve book. - book: { take } as unknown as CellReserveBook, + // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: The fixture books controls with take() and drains them with clear(). + book: { take, clear: vi.fn() } as unknown as CellReserveBook, verifyLease: vi.fn(async () => 'absent' as const) } let answerDatabase: (valid: boolean) => void = () => {} @@ -187,20 +187,27 @@ describe('host pre-auth latency', () => { afterEach(() => vi.useRealTimers()) it('records a booked hello on the reserve path, from accept to a verified proof', async () => { + vi.useFakeTimers() const h = setup({ admitMode: 'reserve', databaseSays: false }) - const { keyPair, identity } = hostKey() - const socket = new FakeSocket() - h.registry.acceptControl(socket.asWebSocket(), identity) - h.advance(30) - sendHello(socket, keyPair, identity.relayHostId) - await vi.waitFor(() => expect(socket.send).toHaveBeenCalledTimes(1)) - expect(h.recordHostPreAuth).not.toHaveBeenCalled() - h.advance(45) - answerChallenge(socket, keyPair) + try { + const { keyPair, identity } = hostKey() + const socket = new FakeSocket() + h.registry.acceptControl(socket.asWebSocket(), identity) + h.advance(30) + sendHello(socket, keyPair, identity.relayHostId) + await vi.waitFor(() => expect(socket.send).toHaveBeenCalledTimes(1)) + expect(h.recordHostPreAuth).not.toHaveBeenCalled() + h.advance(45) + answerChallenge(socket, keyPair) + await vi.advanceTimersByTimeAsync(0) - expect(h.take).toHaveBeenCalledOnce() - expect(h.verifyCellAssignment).not.toHaveBeenCalled() - expect(h.recordHostPreAuth).toHaveBeenCalledExactlyOnceWith('reserve', 'admitted', 75) + expect(h.take).toHaveBeenCalledOnce() + expect(h.verifyCellAssignment).not.toHaveBeenCalled() + expect(h.recordHostPreAuth).toHaveBeenCalledExactlyOnceWith('reserve', 'admitted', 75) + } finally { + h.registry.drain(0) + await vi.advanceTimersByTimeAsync(0) + } }) it('records a hello the database refuses on the db path', async () => { diff --git a/cloud/apps/relay/src/host-session-registry.test.ts b/cloud/apps/relay/src/host-session-registry.test.ts index f0384ca41a7..fc4bf374824 100644 --- a/cloud/apps/relay/src/host-session-registry.test.ts +++ b/cloud/apps/relay/src/host-session-registry.test.ts @@ -14,7 +14,6 @@ import type { RelayConfig } from './config.js' import { RelayStoreError, type RelayCredentialStore } from './credential-store.js' import { CONTROL_RENEWAL_BATCH_INTERVAL_MS } from './control-renewal-batch.js' import { - CONTROL_RENEWAL_STATEMENT_OUTCOMES, type ControlRenewalOutcome, type ControlRenewalRequest } from './control-renewal-statement.js' @@ -124,8 +123,7 @@ function createRegistry( registry: HostSessionRegistry activate: ActivateSession acquireActivity: ReturnType - renewControlActivity: ReturnType - renewControlActivities: ReturnType + renewControlActivities: ReturnType> releaseActivity: ReturnType observer: { recordAuth: ReturnType @@ -135,39 +133,15 @@ function createRegistry( } } { const acquireActivity = vi.fn().mockResolvedValue(undefined) - const renewControlActivity = vi.fn().mockResolvedValue(undefined) const releaseActivity = vi.fn().mockResolvedValue(true) - // Mirrors the store's own batch semantics over the single-renewal mock: a known - // outcome becomes that row's verdict, and any other failure reaches the caller - // as the driver's error. Keeps every per-call expectation below aimed at the - // renewal a session actually asked for. - const renewControlActivities = vi.fn( - async (rows: readonly ControlRenewalRequest[]): Promise => - await Promise.all( - rows.map(async (row): Promise => { - try { - await renewControlActivity(row.identity, { - activityId: row.activityId, - cellId: row.cellId, - expiresAt: row.expiresAt - }) - return 'renewed' - } catch (error) { - const message = String((error as { message?: unknown }).message) - if (!CONTROL_RENEWAL_STATEMENT_OUTCOMES.has(message as ControlRenewalOutcome)) { - throw error - } - return message as ControlRenewalOutcome - } - }) - ) - ) + const renewControlActivities = vi + .fn() + .mockImplementation(async (rows) => rows.map(() => 'renewed')) const assignments = { activateControl, markMigrationTargetRegistered: vi.fn().mockResolvedValue(undefined), resolve: vi.fn().mockResolvedValue({ cellId: config.cellId }), acquireActivity, - renewControlActivity, renewControlActivities, releaseActivity } as unknown as RelayAssignmentStore @@ -220,7 +194,6 @@ function createRegistry( registry, activate, acquireActivity, - renewControlActivity, renewControlActivities, releaseActivity, observer @@ -755,7 +728,7 @@ describe('host session cleanup races', () => { .fn() .mockResolvedValueOnce('control:production-gce-c3:1') .mockReturnValueOnce(blocked.promise) - const { registry, activate, renewControlActivity, releaseActivity } = + const { registry, activate, renewControlActivities, releaseActivity } = createRegistry(activateControl) const originalSocket = new FakeSocket() await activate(originalSocket as unknown as WebSocket, identity, null, 1, false, 1) @@ -785,7 +758,7 @@ describe('host session cleanup races', () => { 'relay draining' ) expect(registry.get({ userId: identity.sub, relayHostId: identity.relayHostId })).toBeNull() - expect(renewControlActivity).not.toHaveBeenCalled() + expect(renewControlActivities).not.toHaveBeenCalled() expect(releaseActivity).toHaveBeenCalledWith( { userId: identity.sub, relayHostId: identity.relayHostId }, 'control:production-gce-c3:2' @@ -829,7 +802,7 @@ describe('host session cleanup races', () => { .fn() .mockResolvedValueOnce('control:production-gce-c3:1') .mockResolvedValueOnce('control:production-gce-c3:2') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) const originalSocket = new FakeSocket() await activate(originalSocket as unknown as WebSocket, identity, null, 1, false, 1) const original = registry.get({ @@ -842,14 +815,14 @@ describe('host session cleanup races', () => { await vi.advanceTimersByTimeAsync(15_000) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledOnce() - expect(renewControlActivity).toHaveBeenCalledWith( - { userId: identity.sub, relayHostId: identity.relayHostId }, + expect(renewControlActivities).toHaveBeenCalledOnce() + expect(renewControlActivities).toHaveBeenCalledWith([ expect.objectContaining({ + identity: { userId: identity.sub, relayHostId: identity.relayHostId }, activityId: 'control:production-gce-c3:2', cellId: 'production-gce-c3' }) - ) + ]) registry.drain(0) vi.advanceTimersByTime(0) }) @@ -859,17 +832,17 @@ describe('host session cleanup races', () => { const oldSocket = new FakeSocket() await h.activate(oldSocket as unknown as WebSocket, identity, null, 1, false, 1) const session = h.registry.get({ userId: identity.sub, relayHostId: identity.relayHostId })! - let reject!: (error: Error) => void - h.renewControlActivity.mockReturnValueOnce( - new Promise((_, fail) => { - reject = fail + let finish!: (outcomes: ControlRenewalOutcome[]) => void + h.renewControlActivities.mockReturnValueOnce( + new Promise((resolve) => { + finish = resolve }) ) await vi.advanceTimersByTimeAsync(15_000) await closeRenewalWindow() const replacement = new FakeSocket() await h.activate(replacement as unknown as WebSocket, identity, session, 1, true, 1) - reject(new Error('activity_cell_not_authoritative')) + finish(['activity_cell_not_authoritative']) await vi.advanceTimersByTimeAsync(0) expect(replacement.close).not.toHaveBeenCalled() expect(session.socket).toBe(replacement) @@ -881,7 +854,7 @@ describe('host session cleanup races', () => { const socket = new FakeSocket() await h.activate(socket as unknown as WebSocket, identity, null, 1, false, 1) const session = h.registry.get({ userId: identity.sub, relayHostId: identity.relayHostId })! - h.renewControlActivity.mockRejectedValueOnce(new Error('control_activity_not_found')) + h.renewControlActivities.mockResolvedValueOnce(['control_activity_not_found']) let reject!: (error: Error) => void h.acquireActivity.mockReturnValueOnce( new Promise((_, fail) => { @@ -907,7 +880,7 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) const socket = new FakeSocket() const activatedAt = Date.now() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) @@ -920,9 +893,9 @@ describe('host session cleanup races', () => { const pings = socket.send.mock.calls.filter((call) => String(call[0]).includes('"ping"')) expect(pings).toHaveLength(4) - expect(renewControlActivity).toHaveBeenCalledTimes(2) - const firstExpiry = Number(renewControlActivity.mock.calls[0]![1].expiresAt) - const secondExpiry = Number(renewControlActivity.mock.calls[1]![1].expiresAt) + expect(renewControlActivities).toHaveBeenCalledTimes(2) + const firstExpiry = Number(renewControlActivities.mock.calls[0]![0][0]!.expiresAt) + const secondExpiry = Number(renewControlActivities.mock.calls[1]![0][0]!.expiresAt) expect(firstExpiry).toBe( activatedAt + RELAY_PROTOCOL_LIMITS.controlPingIntervalMs + @@ -938,18 +911,18 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) - renewControlActivity.mockRejectedValueOnce(new Error('pool timeout')) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) + renewControlActivities.mockRejectedValueOnce(new Error('pool timeout')) const warn = vi.spyOn(console, 'warn').mockImplementation(() => undefined) const socket = new FakeSocket() try { await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) await vi.advanceTimersByTimeAsync(RELAY_PROTOCOL_LIMITS.controlPingIntervalMs) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledOnce() + expect(renewControlActivities).toHaveBeenCalledOnce() await vi.advanceTimersByTimeAsync(RELAY_PROTOCOL_LIMITS.controlPingIntervalMs) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledTimes(2) + expect(renewControlActivities).toHaveBeenCalledTimes(2) } finally { warn.mockRestore() registry.drain(0) @@ -961,17 +934,17 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) - const stalled = deferred() - renewControlActivity.mockReturnValueOnce(stalled.promise) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) + const stalled = deferred() + renewControlActivities.mockReturnValueOnce(stalled.promise) const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) await vi.advanceTimersByTimeAsync(RELAY_PROTOCOL_LIMITS.controlPingIntervalMs * 2) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledTimes(2) - stalled.resolve(undefined) + expect(renewControlActivities).toHaveBeenCalledTimes(2) + stalled.resolve(['renewed']) await vi.advanceTimersByTimeAsync(0) registry.drain(0) vi.advanceTimersByTime(0) @@ -981,25 +954,25 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) - const stalled = deferred() - renewControlActivity.mockReturnValueOnce(stalled.promise) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) + const stalled = deferred() + renewControlActivities.mockReturnValueOnce(stalled.promise) const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) await vi.advanceTimersByTimeAsync(RELAY_PROTOCOL_LIMITS.controlPingIntervalMs * 2) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledTimes(2) - stalled.resolve(undefined) + expect(renewControlActivities).toHaveBeenCalledTimes(2) + stalled.resolve(['renewed']) await vi.advanceTimersByTimeAsync(0) await vi.advanceTimersByTimeAsync(RELAY_PROTOCOL_LIMITS.controlPingIntervalMs) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledTimes(2) + expect(renewControlActivities).toHaveBeenCalledTimes(2) await vi.advanceTimersByTimeAsync(RELAY_PROTOCOL_LIMITS.controlPingIntervalMs) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledTimes(3) + expect(renewControlActivities).toHaveBeenCalledTimes(3) registry.drain(0) vi.advanceTimersByTime(0) }) @@ -1008,9 +981,9 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, acquireActivity, renewControlActivity } = + const { registry, activate, acquireActivity, renewControlActivities } = createRegistry(activateControl) - renewControlActivity.mockRejectedValueOnce(new Error('control_activity_not_found')) + renewControlActivities.mockResolvedValueOnce(['control_activity_not_found']) const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) @@ -1034,9 +1007,9 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, acquireActivity, renewControlActivity } = + const { registry, activate, acquireActivity, renewControlActivities } = createRegistry(activateControl) - renewControlActivity.mockRejectedValueOnce(new Error('control_activity_moved')) + renewControlActivities.mockResolvedValueOnce(['control_activity_moved']) const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) @@ -1053,9 +1026,9 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, acquireActivity, renewControlActivity } = + const { registry, activate, acquireActivity, renewControlActivities } = createRegistry(activateControl) - renewControlActivity.mockRejectedValueOnce(new Error('control_activity_not_found')) + renewControlActivities.mockResolvedValueOnce(['control_activity_not_found']) acquireActivity.mockRejectedValueOnce(new Error('activity_cell_not_authoritative')) const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) @@ -1075,8 +1048,8 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) - renewControlActivity.mockRejectedValueOnce(new Error('activity_cell_not_authoritative')) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) + renewControlActivities.mockResolvedValueOnce(['activity_cell_not_authoritative']) const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) @@ -1095,7 +1068,7 @@ describe('host session cleanup races', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) registry.drain(60_000) @@ -1106,7 +1079,7 @@ describe('host session cleanup races', () => { await closeRenewalWindow() } - expect(renewControlActivity).toHaveBeenCalledTimes(2) + expect(renewControlActivities).toHaveBeenCalledTimes(2) expect(socket.readyState).toBe(socket.OPEN) vi.advanceTimersByTime(15_000) }) @@ -1123,7 +1096,7 @@ describe('control renewal cadence across a rebind', () => { const activateControl = vi .fn() .mockResolvedValue('control:production-gce-c3:1') - const { registry, activate, renewControlActivity } = createRegistry(activateControl) + const { registry, activate, renewControlActivities } = createRegistry(activateControl) const ping = RELAY_PROTOCOL_LIMITS.controlPingIntervalMs const socket = new FakeSocket() await activate(socket as unknown as WebSocket, identity, null, 1, false, 1) @@ -1136,23 +1109,23 @@ describe('control renewal cadence across a rebind', () => { // Age the session so its attempt counter is well above zero. for (let tick = 0; tick < 5; tick++) await beat(socket) - expect(renewControlActivity).toHaveBeenCalledTimes(3) + expect(renewControlActivities).toHaveBeenCalledTimes(3) // The next renewal stalls and is still in flight when the control rebinds. - const stalled = deferred() - renewControlActivity.mockReturnValueOnce(stalled.promise) + const stalled = deferred() + renewControlActivities.mockReturnValueOnce(stalled.promise) for (let tick = 0; tick < 2; tick++) await beat(socket) - expect(renewControlActivity).toHaveBeenCalledTimes(4) + expect(renewControlActivities).toHaveBeenCalledTimes(4) const session = registry.get({ userId: identity.sub, relayHostId: identity.relayHostId })! const rebindSocket = new FakeSocket() await activate(rebindSocket as unknown as WebSocket, identity, session, 1, true, 1) - stalled.resolve(undefined) + stalled.resolve(['renewed']) await vi.advanceTimersByTimeAsync(0) - const before = renewControlActivity.mock.calls.length + const before = renewControlActivities.mock.calls.length for (let tick = 0; tick < 4; tick++) await beat(rebindSocket) - expect(renewControlActivity.mock.calls.length - before).toBe(2) + expect(renewControlActivities.mock.calls.length - before).toBe(2) registry.drain(0) vi.advanceTimersByTime(0) @@ -1222,7 +1195,7 @@ describe('control lease recovery after the session is gone', () => { .fn() .mockResolvedValueOnce('control:production-gce-c3:1') .mockResolvedValueOnce('control:production-gce-c3:2') - const { registry, activate, acquireActivity, renewControlActivity } = + const { registry, activate, acquireActivity, renewControlActivities } = createRegistry(activateControl) const warn = vi.spyOn(console, 'warn').mockImplementation(() => undefined) try { @@ -1231,19 +1204,19 @@ describe('control lease recovery after the session is gone', () => { const session = registry.get({ userId: identity.sub, relayHostId: identity.relayHostId })! // The renewal is still in flight when a newer generation takes over. - let failRenewal!: (error: Error) => void - renewControlActivity.mockReturnValueOnce( - new Promise((_resolve, reject) => (failRenewal = reject)) + let finishRenewal!: (outcomes: ControlRenewalOutcome[]) => void + renewControlActivities.mockReturnValueOnce( + new Promise((resolve) => (finishRenewal = resolve)) ) await vi.advanceTimersByTimeAsync(RELAY_PROTOCOL_LIMITS.controlPingIntervalMs) await closeRenewalWindow() - expect(renewControlActivity).toHaveBeenCalledOnce() + expect(renewControlActivities).toHaveBeenCalledOnce() const newer = new FakeSocket() await activate(newer as unknown as WebSocket, identity, session, 2, false, 1) // Its release already removed the lease, so the renewal reports it missing. - failRenewal(new Error('control_activity_not_found')) + finishRenewal(['control_activity_not_found']) await vi.advanceTimersByTimeAsync(0) expect(acquireActivity).not.toHaveBeenCalled() @@ -1658,11 +1631,20 @@ describe('source-owned idle cutover', () => { userId: identity.sub, relayHostId: identity.relayHostId, credentialKind: 'invite', + relayDeviceId: 'device-1', + tokenHash: 'invite-hash', + reservationId: 'reservation-1', leaseExpiresAt: Date.now() + 1000 }, attachTimer: setTimeout(() => {}, 1000), - credentialActivityId: null - } as never) + credentialActivityId: null, + phonePath: 'db', + timing: { + startedAt: Date.now(), + connOpenAt: Date.now(), + stageMs: { assignment: 0, credential: 0, activity: 0 } + } + }) const attached = h.registry.acceptHostData( new FakeSocket() as unknown as WebSocket, 'conn', @@ -1804,18 +1786,10 @@ describe('host data attach owner lookup', () => { }) } - // The pre-change implementation, kept inline as the oracle the new counts are - // differenced against: two inventory arrays, two independent finds. - function legacyOwnerLookup( - sessions: Map, - connId: string - ): { owner: HostSession | undefined; session: HostSession | undefined } { - const owner = [...sessions.values()].find((candidate) => candidate.pendingConns.has(connId)) - const session = [...sessions.values()].find((candidate) => candidate.pendingConns.has(connId)) - return { owner, session } - } - - function pendingConn(client: FakeSocket, connTicket: string) { + function pendingConn( + client: FakeSocket, + connTicket: string + ): NonNullable> { return { connId: CONN_ID, connTicket, @@ -1824,11 +1798,20 @@ describe('host data attach owner lookup', () => { userId: identity.sub, relayHostId: identity.relayHostId, credentialKind: 'invite', + relayDeviceId: 'device-1', + tokenHash: 'invite-hash', + reservationId: 'reservation-1', leaseExpiresAt: Date.now() + 1000 }, attachTimer: setTimeout(() => {}, 1000), - credentialActivityId: null - } as never + credentialActivityId: null, + phonePath: 'db', + timing: { + startedAt: Date.now(), + connOpenAt: Date.now(), + stageMs: { assignment: 0, credential: 0, activity: 0 } + } + } } // Every decoy holds a pending conn of its own, so each membership check the @@ -1874,31 +1857,25 @@ describe('host data attach owner lookup', () => { it.each([ { placement: 'first', - before: { visits: 2000, membership: 2 }, after: { visits: 1, membership: 1 } }, { placement: 'middle', - before: { visits: 2000, membership: 1000 }, after: { visits: 500, membership: 500 } }, { placement: 'last', - before: { visits: 2000, membership: 2000 }, after: { visits: 1000, membership: 1000 } }, { placement: 'absent', - before: { visits: 2000, membership: 2000 }, after: { visits: 1000, membership: 1000 } } ] as const)( 'visits the inventory once, not twice, for a $placement owner', - async ({ placement, before, after }) => { + async ({ placement, after }) => { const h = await attachRegistry(placement) expect(h.sessions.size).toBe(SESSION_COUNT) - const oracle = legacyOwnerLookup(h.sessions, CONN_ID) - const legacy = { ...h.counts } h.counts.visits = 0 h.counts.membership = 0 const host = new FakeSocket() @@ -1912,10 +1889,7 @@ describe('host data attach owner lookup', () => { RELAY_CLOSE_CODE.BAD_OUTER_CREDENTIAL, 'invalid host data ticket' ) - expect(legacy).toEqual(before) expect({ ...h.counts }).toEqual(after) - expect(oracle.owner).toBe(placement === 'absent' ? undefined : h.owner) - expect(oracle.owner).toBe(oracle.session) } ) @@ -1947,7 +1921,6 @@ describe('host data attach owner lookup', () => { it('rejects on the earlier duplicate owner rather than the later live one', async () => { const h = await attachRegistry('middle') h.ordered[0]!.pendingConns.set(CONN_ID, pendingConn(new FakeSocket(), 'stale-ticket') as never) - expect(legacyOwnerLookup(h.sessions, CONN_ID).owner).toBe(h.ordered[0]) h.counts.visits = 0 h.counts.membership = 0 const host = new FakeSocket() @@ -1958,7 +1931,7 @@ describe('host data attach owner lookup', () => { expect(h.owner.pendingConns.has(CONN_ID)).toBe(true) }) - it('splices the earlier duplicate owner and leaves the later one untouched', async () => { + it('consumes the earlier duplicate owner on basis failure and leaves the later one untouched', async () => { const basis = vi.fn().mockRejectedValue(new Error('basis failed')) const h = await attachRegistry('first', { recordConnectionBasis: basis }) const duplicate = h.ordered[3]! @@ -2046,11 +2019,11 @@ describe('paced drain', () => { expect(drainsSent(sockets)).toBe(5) }) - it('fences admission for every session before the first paced send lands', async () => { + it('refuses new host controls before the first paced send lands', async () => { const { registry, sockets } = await connectHosts(3) registry.drain(0, { paceWindowMs: 40_000 }) expect(registry.isDraining()).toBe(true) - // A host whose drain has not been sent yet must already be non-authoritative. + // The fleet drain refuses newly arriving host controls immediately. const socket = new FakeSocket() registry.acceptControl(socket as unknown as WebSocket, { ...identity, sub: 'user-late' }) expect(socket.close).toHaveBeenCalledWith(RELAY_CLOSE_CODE.DRAINING, 'relay draining') @@ -2067,7 +2040,7 @@ describe('paced drain', () => { // Its own send at 40s plus its own 10s grace, not 10s from the drain call. await vi.advanceTimersByTimeAsync(39_999) expect(sockets[1]!.readyState).toBe(sockets[1]!.OPEN) - await vi.advanceTimersByTimeAsync(10_001) + await vi.advanceTimersByTimeAsync(1) expect(sockets[1]!.readyState).toBe(sockets[1]!.CLOSED) }) diff --git a/cloud/apps/relay/src/host-whereabouts-app.test.ts b/cloud/apps/relay/src/host-whereabouts-app.test.ts index 8888ee2db32..87598028c1e 100644 --- a/cloud/apps/relay/src/host-whereabouts-app.test.ts +++ b/cloud/apps/relay/src/host-whereabouts-app.test.ts @@ -239,37 +239,41 @@ describe('POST /v1/admin/host-whereabouts', () => { describe('RelayAssignmentStore.hostWhereabouts', () => { it('reads the assignment row and its open migration by primary key', async () => { const database = await openInMemoryRelayDatabase() - const store = new RelayAssignmentStore(database, () => 100) - await store.reconcileCells([ - { id: 'cell-a', url: 'https://cell-a.example.test', capacityRequests: 10 }, - { id: 'cell-b', url: 'https://cell-b.example.test', capacityRequests: 10 } - ]) - const identity = { userId: 'user-a', relayHostId: HOST } - expect(await store.hostWhereabouts(identity)).toBeNull() + try { + const store = new RelayAssignmentStore(database, () => 100) + await store.reconcileCells([ + { id: 'cell-a', url: 'https://cell-a.example.test', capacityRequests: 10 }, + { id: 'cell-b', url: 'https://cell-b.example.test', capacityRequests: 10 } + ]) + const identity = { userId: 'user-a', relayHostId: HOST } + expect(await store.hostWhereabouts(identity)).toBeNull() - const assigned = await store.assign(identity) - expect(await store.hostWhereabouts(identity)).toEqual({ - cellId: assigned.cellId, - assignmentEpoch: assigned.assignmentEpoch, - leaseExpiresAt: assigned.leaseExpiresAt, - openMigration: null - }) + const assigned = await store.assign(identity) + expect(await store.hostWhereabouts(identity)).toEqual({ + cellId: assigned.cellId, + assignmentEpoch: assigned.assignmentEpoch, + leaseExpiresAt: assigned.leaseExpiresAt, + openMigration: null + }) - await database.query( - `INSERT INTO relay_assignment_migrations + await database.query( + `INSERT INTO relay_assignment_migrations (user_id, relay_host_id, source_cell_id, target_cell_id, previous_epoch, assignment_epoch, source_request_units, target_reserved_units, expires_at, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`, - ['user-a', HOST, 'cell-a', 'cell-b', 1, 2, 1, 1, 900, 100, 100] - ) - expect((await store.hostWhereabouts(identity))?.openMigration).toEqual({ - sourceCellId: 'cell-a', - targetCellId: 'cell-b', - previousEpoch: 1, - assignmentEpoch: 2, - expiresAt: 900, - targetRegisteredAt: null - }) + ['user-a', HOST, 'cell-a', 'cell-b', 1, 2, 1, 1, 900, 100, 100] + ) + expect((await store.hostWhereabouts(identity))?.openMigration).toEqual({ + sourceCellId: 'cell-a', + targetCellId: 'cell-b', + previousEpoch: 1, + assignmentEpoch: 2, + expiresAt: 900, + targetRegisteredAt: null + }) + } finally { + await database.close() + } }) }) diff --git a/cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts b/cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts index 6fc2017ab48..8d24391aa72 100644 --- a/cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts +++ b/cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts @@ -86,12 +86,45 @@ describe('idle cutover durable reconciliation', () => { ) }) await locked + const transaction = database.transaction.bind(database) + let reached!: () => void + const requested = new Promise((resolve) => { + reached = resolve + }) + let waiterPid: number | undefined + vi.spyOn(database, 'transaction').mockImplementation(async (operation, options) => { + reached() + return await transaction(async (tx) => { + if (database.dialect === 'postgres') { + waiterPid = Number((await tx.query('SELECT pg_backend_pid() AS pid'))[0]!.pid) + } + return await operation(tx) + }, options) + }) let settled = false const reconciliation = store.reconcileIdleRegionalRehome(request).finally(() => { settled = true }) try { - await new Promise((resolve) => setImmediate(resolve)) + await requested + if (database.dialect === 'postgres') { + await expect + .poll( + async () => { + if (waiterPid === undefined) { + return false + } + const rows = await database.query( + `SELECT 1 FROM pg_stat_activity + WHERE pid = ? AND wait_event_type = 'Lock' AND query LIKE '%relay_assignments%'`, + [waiterPid] + ) + return rows.length === 1 + }, + { timeout: 900, interval: 10 } + ) + .toBe(true) + } expect(settled).toBe(false) } finally { release() diff --git a/cloud/apps/relay/src/idle-regional-rehome-store.test.ts b/cloud/apps/relay/src/idle-regional-rehome-store.test.ts index ce84bf78e53..6ce94738bbd 100644 --- a/cloud/apps/relay/src/idle-regional-rehome-store.test.ts +++ b/cloud/apps/relay/src/idle-regional-rehome-store.test.ts @@ -226,9 +226,39 @@ describe('constrained idle regional assignment transaction', () => { expect(await store.selectIdleRegionalRehomeCandidates(safety)).toHaveLength(1) }) - it('leaves the candidate page offset untouched across a closed dispatch budget', async () => { + it('leaves the candidate page cursor untouched across a closed dispatch budget', async () => { const { store, database, safety } = await setup() + for (const table of [ + 'relay_assignments', + 'relay_assignment_activity_leases', + 'relay_control_capabilities', + 'relay_region_decisions' + ]) { + const template = ( + await database.query(`SELECT * FROM ${table} WHERE user_id = ? AND relay_host_id = ?`, [ + identity.userId, + identity.relayHostId + ]) + )[0]! + const columns = Object.keys(template) + for (let index = 0; index < 100; index++) { + const values = columns.map((column) => + column === 'user_id' || column === 'relay_host_id' ? '?' : column + ) + await database.query( + `INSERT INTO ${table} (${columns.join(', ')}) SELECT ${values.join(', ')} FROM ${table} + WHERE user_id = ? AND relay_host_id = ?`, + [ + `idle-store-test-${String(index).padStart(3, '0')}`, + `pagehost${String(index).padStart(8, '0')}`, + identity.userId, + identity.relayHostId + ] + ) + } + } const first = await store.selectIdleRegionalRehomeCandidates(safety) + expect(first).toHaveLength(100) await database.query( `UPDATE relay_region_rehome_worker_state SET next_dispatch_at = ? WHERE worker_id = 'global'`, [safety.observedAt + 1] @@ -237,7 +267,10 @@ describe('constrained idle regional assignment transaction', () => { await database.query( `UPDATE relay_region_rehome_worker_state SET next_dispatch_at = 0 WHERE worker_id = 'global'` ) - expect(await store.selectIdleRegionalRehomeCandidates(safety)).toEqual(first) + const next = await store.selectIdleRegionalRehomeCandidates(safety) + expect(next).toHaveLength(1) + expect(next[0]!.relayHostId).toBe('pagehost00000099') + expect(first.some((c) => c.relayHostId === next[0]!.relayHostId)).toBe(false) }) it('progresses past a full page of busy candidates without writing eligibility state', async () => { @@ -291,8 +324,8 @@ describe('constrained idle regional assignment transaction', () => { const { store, safety, request, database } = await setup() const held = holdStatement(database, 'SELECT * FROM relay_region_rehome_control') const commit = store.commitIdleRegionalRehome(request, safety) - await held.entered try { + await held.entered await store.activateControl(identity, { cellId: 'source', assignmentEpoch: 1, @@ -302,6 +335,7 @@ describe('constrained idle regional assignment transaction', () => { }) } finally { held.release() + await commit } expect(await commit).toEqual({ outcome: 'deferred', reason: 'candidate-ineligible' }) expect(await store.reconcileIdleRegionalRehome(request)).toBe('stale') @@ -322,10 +356,19 @@ describe('constrained idle regional assignment transaction', () => { idleRegionalRehome: true }) const rejected = expect(replacement).rejects.toThrow('wrong_assignment') - held.release() - expect(await commit).toEqual({ outcome: 'committed' }) - await rejected - expect(await store.resolve(identity)).toMatchObject({ cellId: 'target', assignmentEpoch: 2 }) + try { + held.release() + expect(await commit).toEqual({ outcome: 'committed' }) + await rejected + expect(await store.resolve(identity)).toMatchObject({ cellId: 'target', assignmentEpoch: 2 }) + } finally { + held.release() + try { + await commit + } finally { + await rejected + } + } }) it('finds the committed attempt after its database reply is lost', async () => { diff --git a/cloud/apps/relay/src/idle-regional-rehome-window.test.ts b/cloud/apps/relay/src/idle-regional-rehome-window.test.ts index e213b2331f0..deff686bd7c 100644 --- a/cloud/apps/relay/src/idle-regional-rehome-window.test.ts +++ b/cloud/apps/relay/src/idle-regional-rehome-window.test.ts @@ -1,7 +1,6 @@ import { afterEach, describe, expect, it, vi } from 'vitest' import { RelayAssignmentStore } from './assignment-store.js' import type { RelayDatabase } from './database.js' -import { IDLE_REHOME_DECISION_WINDOW } from './idle-regional-rehome-selection.js' import { openIdleRehomeTestDatabase } from './idle-regional-rehome-test-database.js' // One source cell and three targets, so a poll has to rank targets per host @@ -176,22 +175,33 @@ describe('idle regional rehome candidate window', () => { it('reads a bounded window of decisions however many hosts are eligible', async () => { const { store, database, safety } = await setup() await seedHost(store, identity) - await cloneHosts(database, identity, IDLE_REHOME_DECISION_WINDOW + 200) - const query = vi.spyOn(database, 'query') - await store.selectIdleRegionalRehomeCandidates(safety) - const calls = query.mock.calls.map((call) => call[0]) - const window = calls.findIndex((sql) => /FROM relay_region_decisions\s*$/m.test(sql)) - expect(window).toBeGreaterThanOrEqual(0) - expect(query.mock.calls[window]![1]!.at(-1)).toBe(IDLE_REHOME_DECISION_WINDOW) - // No statement pages by OFFSET any more: that was the cost that grew with the rollout. - expect(calls.some((sql) => /OFFSET/i.test(sql))).toBe(false) + await cloneHosts(database, identity, 700) + const query = database.query.bind(database) + const decisionRows: number[] = [] + vi.spyOn(database, 'query').mockImplementation(async (sql, params) => { + const rows = await query(sql, params) + if (/^SELECT user_id, relay_host_id FROM relay_region_decisions/.test(sql)) { + decisionRows.push(rows.length) + } + return rows + }) + const first = await store.selectIdleRegionalRehomeCandidates(safety) + const next = await store.selectIdleRegionalRehomeCandidates(safety) + expect(decisionRows.length).toBeGreaterThan(0) + for (const count of decisionRows) { + expect(count).toBeLessThanOrEqual(500) + } + expect(first).toHaveLength(102) + expect(next).toHaveLength(102) + const firstKeys = new Set(first.map((c) => `${c.userId}/${c.targetCellId}`)) + expect(next.every((c) => !firstKeys.has(`${c.userId}/${c.targetCellId}`))).toBe(true) }) - it('keeps the window\'s last host when a decision turns eligible between the two reads', async () => { + it("keeps the window's last host when a decision turns eligible between the two reads", async () => { const { store, database, safety, now } = await setup() await seedHost(store, identity) // Exactly one full window, whose last key in sort order is the seeded host. - await cloneHosts(database, identity, IDLE_REHOME_DECISION_WINDOW - 1) + await cloneHosts(database, identity, 499) await database.query( "UPDATE relay_assignment_activity_leases SET expires_at = ? WHERE user_id LIKE 'clone-%'", [now - 1] @@ -225,6 +235,7 @@ describe('idle regional rehome candidate window', () => { return rows }) const candidates = await store.selectIdleRegionalRehomeCandidates(safety) + expect(inserted).toBe(true) expect(candidates.map((candidate) => candidate.userId)).toEqual([ identity.userId, identity.userId, @@ -237,20 +248,24 @@ describe('idle regional rehome candidate window', () => { await seedHost(store, identity) await cloneHosts(database, identity, 120) const seen = new Set() - let pages = 0 let wrapped = false - // 121 hosts x 3 targets is 363 candidates, so the page cap has to be hit - // several times before the window runs out and the cursor wraps. for (let poll = 0; poll < 20 && !wrapped; poll++) { const page = await store.selectIdleRegionalRehomeCandidates(safety) - pages += 1 - const before = seen.size - for (const candidate of page) seen.add(`${candidate.userId}/${candidate.targetCellId}`) - if (seen.size === before && page.length > 0) wrapped = true - if (page.length < 3) wrapped = true + expect(page.length).toBeGreaterThan(0) + expect(page.length).toBeLessThanOrEqual(102) + for (const candidate of page) { + const key = `${candidate.userId}/${candidate.targetCellId}` + if (seen.has(key)) { + expect(seen.size).toBe(363) + wrapped = true + } else { + expect(wrapped).toBe(false) + seen.add(key) + } + } } - expect(pages).toBeGreaterThan(1) - expect(seen.size).toBe(121 * 3) + expect(seen.size).toBe(363) + expect(wrapped).toBe(true) }) it('does not stall on a host the window found but the join rejected', async () => { diff --git a/cloud/apps/relay/src/idle-regional-rehome-worker.test.ts b/cloud/apps/relay/src/idle-regional-rehome-worker.test.ts index 9b3f6d7fa07..86762899719 100644 --- a/cloud/apps/relay/src/idle-regional-rehome-worker.test.ts +++ b/cloud/apps/relay/src/idle-regional-rehome-worker.test.ts @@ -1,6 +1,7 @@ import { afterEach, describe, expect, it, vi } from 'vitest' import type { RelayAssignmentStore } from './assignment-store.js' import type { RelayConfig } from './config.js' +import type { RegionalRehomeSafetySnapshot } from './relay-observability.js' import { startRegionalRehomeWorker } from './regional-rehome-worker.js' const candidate = { @@ -15,6 +16,15 @@ const candidate = { sourceGeneration: 3, targetCellId: 'target' } +const safety = { + observedAt: 100, + sqlFailures: 0, + reconnects: 0, + controlActivityRecoveryFailures: 0, + databasePoolWaiting: 0, + databasePoolWaitersMax: 0, + databasePoolWaitMsMax: 0 +} satisfies RegionalRehomeSafetySnapshot const config = { role: 'director', regionCorrectionCohortPercent: 100, @@ -37,7 +47,7 @@ function setup(fetch: typeof globalThis.fetch) { recordRegionalRehomeDispatchFailure } as unknown as RelayAssignmentStore, { - safetySnapshot: () => ({ observedAt: 100 }) as never, + safetySnapshot: () => safety, intervalMs: 60_000, identityToken: async () => 'private-token', fetch @@ -58,19 +68,22 @@ describe('idle regional worker dispatch', () => { Response.json({ v: 1, outcome: 'committed' }) ) const c = setup(fetch) - await vi.waitFor(() => expect(c.selectIdleRegionalRehomeCandidates).toHaveBeenCalledOnce()) - await c.worker.run() - c.worker.stop() - expect(c.claimRegionalRehome).not.toHaveBeenCalled() - expect(fetch).toHaveBeenCalledOnce() - const [url, init] = fetch.mock.calls[0]! - expect(String(url)).toBe('https://source.example.test/v1/admin/host-idle-rehome') - const { sourceCellUrl: _, ...request } = candidate - expect(JSON.parse(String(init?.body))).toEqual({ - ...request, - cohortPercent: 100, - directorSafety: { observedAt: 100 } - }) + try { + await vi.waitFor(() => expect(c.selectIdleRegionalRehomeCandidates).toHaveBeenCalledOnce()) + await c.worker.run() + expect(c.claimRegionalRehome).not.toHaveBeenCalled() + expect(fetch).toHaveBeenCalledOnce() + const [url, init] = fetch.mock.calls[0]! + expect(String(url)).toBe('https://source.example.test/v1/admin/host-idle-rehome') + const { sourceCellUrl: _, ...request } = candidate + expect(JSON.parse(String(init?.body))).toEqual({ + ...request, + cohortPercent: 100, + directorSafety: safety + }) + } finally { + c.worker.stop() + } }) it('progresses past busy hosts without charging a dispatch failure', async () => { const fetch = vi @@ -78,28 +91,40 @@ describe('idle regional worker dispatch', () => { .mockResolvedValueOnce(Response.json({ v: 1, outcome: 'busy' })) .mockResolvedValueOnce(Response.json({ v: 1, outcome: 'committed' })) const c = setup(fetch) - await vi.waitFor(() => expect(c.selectIdleRegionalRehomeCandidates).toHaveBeenCalledOnce()) - c.selectIdleRegionalRehomeCandidates.mockResolvedValue([ - candidate, - { - ...candidate, - relayHostId: 'ponmlkjihgfedcba', - attemptId: '33333333-3333-4333-8333-333333333333' - } - ]) - await c.worker.run() - c.worker.stop() - expect(fetch).toHaveBeenCalledTimes(2) - expect(c.recordRegionalRehomeDispatchFailure).not.toHaveBeenCalled() + try { + await vi.waitFor(() => expect(c.selectIdleRegionalRehomeCandidates).toHaveBeenCalledOnce()) + c.selectIdleRegionalRehomeCandidates.mockResolvedValue([ + candidate, + { + ...candidate, + relayHostId: 'ponmlkjihgfedcba', + attemptId: '33333333-3333-4333-8333-333333333333' + } + ]) + await c.worker.run() + expect(fetch).toHaveBeenCalledTimes(2) + expect(c.recordRegionalRehomeDispatchFailure).not.toHaveBeenCalled() + } finally { + c.worker.stop() + } }) it('does not charge a lost response as a claimed migration failure', async () => { + const warning = vi.spyOn(console, 'warn').mockImplementation(() => undefined) const fetch = vi.fn(async () => { throw new Error('response lost') }) const c = setup(fetch) - await vi.waitFor(() => expect(c.selectIdleRegionalRehomeCandidates).toHaveBeenCalledOnce()) - await c.worker.run() - c.worker.stop() - expect(c.recordRegionalRehomeDispatchFailure).not.toHaveBeenCalled() + try { + await vi.waitFor(() => expect(c.selectIdleRegionalRehomeCandidates).toHaveBeenCalledOnce()) + await c.worker.run() + expect(fetch).toHaveBeenCalledOnce() + expect(warning).toHaveBeenCalledWith( + expect.stringContaining('"event":"orca_relay_idle_rehome_request_failed"') + ) + expect(warning).toHaveBeenCalledWith(expect.stringContaining('"outcomes":{"failed":1}')) + expect(c.recordRegionalRehomeDispatchFailure).not.toHaveBeenCalled() + } finally { + c.worker.stop() + } }) }) diff --git a/cloud/apps/relay/src/migration-recovery-postgres.test.ts b/cloud/apps/relay/src/migration-recovery-postgres.test.ts index aee41278d49..056c9cc92ee 100644 --- a/cloud/apps/relay/src/migration-recovery-postgres.test.ts +++ b/cloud/apps/relay/src/migration-recovery-postgres.test.ts @@ -37,50 +37,57 @@ describePostgres('PostgreSQL migration recovery', () => { }) afterAll(async () => { - await database.query( - `DELETE FROM relay_control_connection_reservations + try { + await database.query( + `DELETE FROM relay_control_connection_reservations WHERE user_id LIKE 'recovery-user-%'` - ) - await database.query( - `DELETE FROM relay_post_drain_migration_pins WHERE user_id LIKE 'recovery-user-%'` - ) - await database.query( - `DELETE FROM relay_assignment_migration_incarnations WHERE user_id LIKE 'recovery-user-%'` - ) - await database.query( - `DELETE FROM relay_assignment_activity_leases WHERE user_id LIKE 'recovery-user-%'` - ) - await database.query( - `DELETE FROM relay_assignment_migrations WHERE user_id LIKE 'recovery-user-%'` - ) - await database.query(`DELETE FROM relay_assignments WHERE user_id LIKE 'recovery-user-%'`) - await database.query( - `DELETE FROM relay_cell_fence_apply_invocations WHERE attempt_id IN ( + ) + await database.query( + `DELETE FROM relay_post_drain_migration_pins WHERE user_id LIKE 'recovery-user-%'` + ) + await database.query( + `DELETE FROM relay_assignment_migration_incarnations WHERE user_id LIKE 'recovery-user-%'` + ) + await database.query( + `DELETE FROM relay_assignment_activity_leases WHERE user_id LIKE 'recovery-user-%'` + ) + await database.query( + `DELETE FROM relay_assignment_migrations WHERE user_id LIKE 'recovery-user-%'` + ) + await database.query( + `DELETE FROM relay_control_capabilities WHERE user_id LIKE 'recovery-user-%'` + ) + await database.query(`DELETE FROM relay_assignments WHERE user_id LIKE 'recovery-user-%'`) + await database.query( + `DELETE FROM relay_cell_fence_apply_invocations WHERE attempt_id IN ( SELECT attempt_id FROM relay_cell_fence_attempts WHERE cell_id LIKE 'recovery-cell-%' )` - ) - await database.query( - `DELETE FROM relay_cell_committed_fences WHERE cell_id LIKE 'recovery-cell-%'` - ) - await database.query( - `DELETE FROM relay_cell_legacy_fence_adoptions + ) + await database.query( + `DELETE FROM relay_cell_committed_fences WHERE cell_id LIKE 'recovery-cell-%'` + ) + await database.query( + `DELETE FROM relay_cell_legacy_fence_adoptions WHERE cell_id LIKE 'recovery-cell-%'` - ) - await database.query( - `DELETE FROM relay_cell_fence_plan_bindings WHERE attempt_id IN ( + ) + await database.query( + `DELETE FROM relay_cell_fence_plan_bindings WHERE attempt_id IN ( SELECT attempt_id FROM relay_cell_fence_attempts WHERE cell_id LIKE 'recovery-cell-%' )` - ) - await database.query( - `DELETE FROM relay_cell_fence_attempts WHERE cell_id LIKE 'recovery-cell-%'` - ) - await database.query(`DELETE FROM relay_cell_fences WHERE cell_id LIKE 'recovery-cell-%'`) - await database.query(`DELETE FROM relay_cell_runtime WHERE cell_id LIKE 'recovery-cell-%'`) - await database.query(`DELETE FROM relay_cell_admission WHERE cell_id LIKE 'recovery-cell-%'`) - await database.query(`DELETE FROM relay_cells WHERE cell_id LIKE 'recovery-cell-%'`) - await database.close() + ) + await database.query( + `DELETE FROM relay_cell_fence_attempts WHERE cell_id LIKE 'recovery-cell-%'` + ) + await database.query(`DELETE FROM relay_cell_fences WHERE cell_id LIKE 'recovery-cell-%'`) + await database.query(`DELETE FROM relay_cell_runtime WHERE cell_id LIKE 'recovery-cell-%'`) + await database.query(`DELETE FROM relay_cell_admission WHERE cell_id LIKE 'recovery-cell-%'`) + await database.query(`DELETE FROM relay_cell_regions WHERE cell_id LIKE 'recovery-cell-%'`) + await database.query(`DELETE FROM relay_cells WHERE cell_id LIKE 'recovery-cell-%'`) + } finally { + await database?.close() + } }) async function fixture(replacementCapacity = 20): Promise { @@ -452,7 +459,9 @@ describePostgres('PostgreSQL migration recovery', () => { input.heartbeat(input.cells.source) ]) expect(heartbeatResult.status).toBe('fulfilled') - expect(['fulfilled', 'rejected']).toContain(commit.status) + if (commit.status === 'rejected') { + expect(commit.reason).toMatchObject({ message: 'legacy_cell_fence_not_active' }) + } expect( await database.query( `SELECT cell_id FROM relay_cell_legacy_fence_adoptions WHERE cell_id = ?`, @@ -673,7 +682,7 @@ describePostgres('PostgreSQL migration recovery', () => { expect(await reservations(input.cells)).toEqual({ source: 0, failed: 1, replacement: 0 }) }) - it('fails dead-source completion without a stale source heartbeat', async () => { + it('requires fence evidence for dead-source completion', async () => { const input = await fixture() await input.store.releaseActivity(input.identity, input.sourceControlId) diff --git a/cloud/apps/relay/src/placement-load-band.test.ts b/cloud/apps/relay/src/placement-load-band.test.ts index 7920b90750f..b2edc26e0ed 100644 --- a/cloud/apps/relay/src/placement-load-band.test.ts +++ b/cloud/apps/relay/src/placement-load-band.test.ts @@ -136,18 +136,6 @@ describe('PlacementLoadBand', () => { expect(lines[0]?.fallbacks).toBeGreaterThan(0) }) - it('never places past capacity while the fuller cells fill', () => { - const cells: SimulatedCell[] = [ - { cellId: 'cell-empty', reserved: 0, capacity: 100 }, - ...['cell-b', 'cell-c'].map((cellId) => ({ cellId, reserved: 90, capacity: 100 })) - ] - const director = new PlacementLoadBand(seededRandom(11), quiet) - const counts = simulate([director], cells, 120, () => 1_000) - - expect(cells.map((cell) => cell.reserved)).toEqual([100, 100, 100]) - expect(counts.get('cell-empty')).toBe(100) - }) - it('falls back to the least-loaded cell when every candidate is over budget', () => { const band = new PlacementLoadBand(seededRandom(3), quiet) const only = [{ cellId: 'cell-a', loadRatio: 0.5 }] @@ -228,26 +216,34 @@ describe('leastLoadedCell with the load band', () => { } it('spreads within the preferred region and keeps an empty US cell out', async () => { - const { store } = await setupRegions() - const counts = await placements(store, 200) + const { database, store } = await setupRegions() + try { + const counts = await placements(store, 200) - expect(counts.get('us-a')).toBeUndefined() - expect(counts.get('asia-a')).toBeLessThanOrEqual(PLACEMENT_INTAKE_SHARE * 200 + 1) - const used = [...counts.values()].filter((count) => count >= 20) - expect(used.length).toBeGreaterThanOrEqual(3) + expect(counts.get('us-a')).toBeUndefined() + expect(counts.get('asia-a')).toBeLessThanOrEqual(PLACEMENT_INTAKE_SHARE * 200 + 1) + const used = [...counts.values()].filter((count) => count >= 20) + expect(used.length).toBeGreaterThanOrEqual(3) + } finally { + await database.close() + } }) it('fills the preferred region to its hard cap before spilling, never past it', async () => { const { database, store } = await setupRegions() - const counts = await placements(store, 520) - const rows = await database.query( - `SELECT reserved_requests, capacity_requests FROM relay_cells` - ) + try { + const counts = await placements(store, 520) + const rows = await database.query( + `SELECT reserved_requests, capacity_requests FROM relay_cells` + ) - // The hard cap is reserved < capacity: five Asia cells hold 500, the rest spill to the US. - expect(counts.get('us-a')).toBe(20) - for (const row of rows) { - expect(Number(row.reserved_requests)).toBeLessThanOrEqual(Number(row.capacity_requests)) + // The hard cap is reserved < capacity: five Asia cells hold 500, the rest spill to the US. + expect(counts.get('us-a')).toBe(20) + for (const row of rows) { + expect(Number(row.reserved_requests)).toBeLessThanOrEqual(Number(row.capacity_requests)) + } + } finally { + await database.close() } }) }) diff --git a/cloud/apps/relay/src/postgres-checked-out-client-error.test.ts b/cloud/apps/relay/src/postgres-checked-out-client-error.test.ts index 26261270994..822aabaf344 100644 --- a/cloud/apps/relay/src/postgres-checked-out-client-error.test.ts +++ b/cloud/apps/relay/src/postgres-checked-out-client-error.test.ts @@ -41,21 +41,23 @@ describe('checked-out PostgreSQL client failure handling', () => { throw terminated }) const warning = vi.spyOn(console, 'warn').mockImplementation(() => {}) - const database = new PostgresDatabase(poolOf(client) as never) + try { + const database = new PostgresDatabase(poolOf(client) as never) - await expect( - database.transaction(async (transaction) => await transaction.query('SELECT 1')) - ).rejects.toBe(terminated) + await expect( + database.transaction(async (transaction) => await transaction.query('SELECT 1')) + ).rejects.toBe(terminated) - expect(listenersWhileCheckedOut).toBe(1) - expect(client.listenerCount('error')).toBe(0) - expect(client.released).toEqual([terminated]) - expect(client.statements).toEqual(['BEGIN', 'SELECT 1']) - expect(warning).toHaveBeenCalledWith( - '[orca-relay] checked-out PostgreSQL client failed: 57P01 Connection terminated unexpectedly' - ) - - warning.mockRestore() + expect(listenersWhileCheckedOut).toBe(1) + expect(client.listenerCount('error')).toBe(0) + expect(client.released).toEqual([terminated]) + expect(client.statements).toEqual(['BEGIN', 'SELECT 1']) + expect(warning).toHaveBeenCalledWith( + '[orca-relay] checked-out PostgreSQL client failed: 57P01 Connection terminated unexpectedly' + ) + } finally { + warning.mockRestore() + } }) it('releases a healthy client back to the pool with no error', async () => { diff --git a/cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts b/cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts index 43fa340ca35..4b1bf9608e8 100644 --- a/cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts +++ b/cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts @@ -63,22 +63,29 @@ describePostgres('PostgreSQL counter write committed in the same round trip', () it('commits the earlier statements and the counter together in one message', async () => { const sent = vi.spyOn(pg.Client.prototype, 'query') - let messagesForCommit = 0 - const result = await database.transaction(async (transaction) => { - await transaction.query(`INSERT INTO ${table}_log (id, note) VALUES (?, ?)`, ['a', 'x']) - const before = sent.mock.calls.length - const committed = await commitWithFinalWrite(transaction, counterUpdate, counterParams("it's", 1)) - messagesForCommit = sent.mock.calls.length - before - return committed - }) - const texts = sent.mock.calls.map(([text]) => String(text)) - sent.mockRestore() - expect(result).toBe(true) - expect(messagesForCommit).toBe(1) - expect(texts.filter((text) => text === 'COMMIT')).toEqual([]) - expect(texts.at(-1)).toMatch(/; COMMIT$/) - expect(await counter("it's")).toBe(1) - expect(await logged()).toBe(1) + try { + let messagesForCommit = 0 + const result = await database.transaction(async (transaction) => { + await transaction.query(`INSERT INTO ${table}_log (id, note) VALUES (?, ?)`, ['a', 'x']) + const before = sent.mock.calls.length + const committed = await commitWithFinalWrite( + transaction, + counterUpdate, + counterParams("it's", 1) + ) + messagesForCommit = sent.mock.calls.length - before + return committed + }) + const texts = sent.mock.calls.map(([text]) => String(text)) + expect(result).toBe(true) + expect(messagesForCommit).toBe(1) + expect(texts.filter((text) => text === 'COMMIT')).toEqual([]) + expect(texts.at(-1)).toMatch(/; COMMIT$/) + expect(await counter("it's")).toBe(1) + expect(await logged()).toBe(1) + } finally { + sent.mockRestore() + } }) it('rolls back over cap and lets the caller read the row outside the transaction', async () => { @@ -113,34 +120,45 @@ describePostgres('PostgreSQL counter write committed in the same round trip', () expect(await logged()).toBe(0) }) - it('retries a deadlock or lock timeout raised by the fused message and commits once', async () => { + it('retries a deadlock raised by the fused message and commits once', async () => { + const sequence = `${table}_retry_sequence` + const trigger = `${table}_retry_trigger` + const fn = `${table}_retry` let attempts = 0 - let theirAttempts = 0 - let otherHolds!: () => void - const otherHolding = new Promise((resolve) => (otherHolds = resolve)) - let ourHold!: () => void - const weHold = new Promise((resolve) => (ourHold = resolve)) - const theirs = other.transaction(async (transaction) => { - theirAttempts += 1 - await transaction.query(`UPDATE ${table} SET n = n WHERE id = 'b'`) - otherHolds() - await weHold - // Waits for 'a', which the first attempt below holds: one side deadlocks. - await transaction.query(`UPDATE ${table} SET n = n WHERE id = 'a'`) - }, { reportRetries: false }) - const ours = database.transaction(async (transaction) => { - attempts += 1 - await transaction.query(`UPDATE ${table} SET n = n WHERE id = 'a'`) - await otherHolding - ourHold() - return await commitWithFinalWrite(transaction, counterUpdate, counterParams('b', 1)) - }, { reportRetries: false }) - const [mine, their] = await Promise.allSettled([ours, theirs]) - // Whichever side PostgreSQL picks as the victim retries and then succeeds. - expect(mine.status).toBe('fulfilled') - expect(their.status).toBe('fulfilled') - expect(await counter('b')).toBe(1) - expect(attempts + theirAttempts).toBeGreaterThanOrEqual(3) + try { + await admin.query(`CREATE SEQUENCE ${sequence}`) + await admin.query(`CREATE FUNCTION ${fn}() RETURNS trigger LANGUAGE plpgsql AS $$ + BEGIN + IF nextval('${sequence}') = 1 THEN + RAISE EXCEPTION 'injected fused deadlock' USING ERRCODE = '40P01'; + END IF; + RETURN NEW; + END $$`) + await admin.query(`CREATE TRIGGER ${trigger} BEFORE UPDATE ON ${table} + FOR EACH ROW EXECUTE FUNCTION ${fn}()`) + const result = await database.transaction( + async (transaction) => { + attempts += 1 + await transaction.query(`INSERT INTO ${table}_log (id, note) VALUES (?, ?)`, [ + 'a', + 'retry' + ]) + return await commitWithFinalWrite(transaction, counterUpdate, counterParams('a', 1)) + }, + { reportRetries: false } + ) + expect(result).toBe(true) + expect(attempts).toBe(2) + expect(await counter('a')).toBe(1) + expect(await logged()).toBe(1) + expect( + Number((await admin.query(`SELECT last_value FROM ${sequence}`)).rows[0].last_value) + ).toBe(2) + } finally { + await admin.query(`DROP TRIGGER IF EXISTS ${trigger} ON ${table}`) + await admin.query(`DROP FUNCTION IF EXISTS ${fn}()`) + await admin.query(`DROP SEQUENCE IF EXISTS ${sequence}`) + } }, 20_000) it('retries a lock timeout raised by the fused message', async () => { @@ -165,6 +183,8 @@ describePostgres('PostgreSQL counter write committed in the same round trip', () it('never retries when the connection is lost under the fused message', async () => { let attempts = 0 + let pid: number | undefined + let rejected: Promise | undefined const blocker = new pg.Client({ connectionString: databaseUrl }) await blocker.connect() try { @@ -172,21 +192,40 @@ describePostgres('PostgreSQL counter write committed in the same round trip', () await blocker.query(`SELECT n FROM ${table} WHERE id = 'a' FOR UPDATE`) const ours = database.transaction(async (transaction) => { attempts += 1 - const pid = Number((await transaction.query('SELECT pg_backend_pid() AS pid'))[0]!.pid) - // Ends the backend while the fused message waits on the row lock. - setTimeout(() => { - void admin.query('SELECT pg_terminate_backend($1)', [pid]) - }, 200) + pid = Number((await transaction.query('SELECT pg_backend_pid() AS pid'))[0]!.pid) return await commitWithFinalWrite(transaction, counterUpdate, counterParams('a', 1)) }) - await expect(ours).rejects.toThrow() + rejected = expect(ours).rejects.toMatchObject({ code: '57P01' }) + await expect + .poll( + async () => { + if (pid === undefined) { + return false + } + const rows = await admin.query( + `SELECT 1 FROM pg_stat_activity + WHERE pid = $1 AND wait_event_type = 'Lock' AND query LIKE '%; COMMIT'`, + [pid] + ) + return rows.rowCount === 1 + }, + { timeout: 2_000, interval: 10 } + ) + .toBe(true) + expect( + (await admin.query('SELECT pg_terminate_backend($1) AS terminated', [pid])).rows + ).toEqual([{ terminated: true }]) + await rejected } finally { - await blocker.query('ROLLBACK').catch(() => undefined) - await blocker.end() + try { + await blocker.query('ROLLBACK') + } finally { + await blocker.end() + await rejected + } } expect(attempts).toBe(1) expect(await counter('a')).toBe(0) - // The pool still serves after dropping the dead client. await expect(database.query('SELECT 1 AS one')).resolves.toEqual([{ one: 1 }]) }, 20_000) diff --git a/cloud/apps/relay/src/postgres-drain-send-locking.test.ts b/cloud/apps/relay/src/postgres-drain-send-locking.test.ts index 26eec5013b0..48edd46eed4 100644 --- a/cloud/apps/relay/src/postgres-drain-send-locking.test.ts +++ b/cloud/apps/relay/src/postgres-drain-send-locking.test.ts @@ -61,6 +61,10 @@ describePostgres('PostgreSQL drain-send locking', () => { source.id, target.id ]) + await database.query(`DELETE FROM relay_cell_regions WHERE cell_id IN (?, ?)`, [ + source.id, + target.id + ]) await database.query(`DELETE FROM relay_cells WHERE cell_id IN (?, ?)`, [ source.id, target.id @@ -133,7 +137,10 @@ describePostgres('PostgreSQL drain-send locking', () => { }) ).rejects.toThrow('drain_application_receipt_missing') await expect( - database.query(`SELECT drain_attempt_id FROM relay_post_drain_migration_pins`) + database.query( + `SELECT drain_attempt_id FROM relay_post_drain_migration_pins WHERE user_id = ? AND relay_host_id = ?`, + [identity.userId, identity.relayHostId] + ) ).resolves.toEqual([{ drain_attempt_id: attemptId }]) }) diff --git a/cloud/apps/relay/src/postgres-idle-client-error.test.ts b/cloud/apps/relay/src/postgres-idle-client-error.test.ts index 50a7bb48ab5..2b370e3c51f 100644 --- a/cloud/apps/relay/src/postgres-idle-client-error.test.ts +++ b/cloud/apps/relay/src/postgres-idle-client-error.test.ts @@ -1,22 +1,19 @@ +import pg from 'pg' import { describe, expect, it, vi } from 'vitest' import { absorbPostgresIdleClientErrors } from './database.js' describe('PostgreSQL idle-client failure handling', () => { - it('absorbs the pool error without logging connection details', () => { - let listener: ((error: Error) => void) | undefined - const pool = { - on: vi.fn((_event: string, value: (error: Error) => void) => { - listener = value - return pool - }) - } + it('absorbs the pool error without logging connection details', async () => { + const pool = new pg.Pool() const warning = vi.spyOn(console, 'warn').mockImplementation(() => {}) - - absorbPostgresIdleClientErrors(pool as never) - expect(() => listener?.(new Error('postgres://user:secret@database'))).not.toThrow() - expect(warning).toHaveBeenCalledWith('[orca-relay] idle PostgreSQL client failed') - expect(JSON.stringify(warning.mock.calls)).not.toContain('secret') - - warning.mockRestore() + try { + absorbPostgresIdleClientErrors(pool) + expect(() => pool.emit('error', new Error('postgres://user:secret@database'))).not.toThrow() + expect(warning).toHaveBeenCalledWith('[orca-relay] idle PostgreSQL client failed') + expect(JSON.stringify(warning.mock.calls)).not.toContain('secret') + } finally { + warning.mockRestore() + await pool.end() + } }) }) diff --git a/cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts b/cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts index 072dfcf1988..7efdc774016 100644 --- a/cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts +++ b/cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts @@ -33,6 +33,9 @@ describePostgres('PostgreSQL lock-wait sample', () => { }) afterAll(async () => { + for (const table of ['relay_cell_regions', 'relay_cell_admission']) { + await directorDatabase?.query(`DELETE FROM ${table} WHERE cell_id = ?`, [cell.id]) + } await directorDatabase?.query(`DELETE FROM relay_cells WHERE cell_id = ?`, [cell.id]) await cellDatabase?.close() await directorDatabase?.close() diff --git a/config/scripts/computer-use-smoke.test.mjs b/config/scripts/computer-use-smoke.test.mjs index 04725a69368..c3e90e8dee2 100644 --- a/config/scripts/computer-use-smoke.test.mjs +++ b/config/scripts/computer-use-smoke.test.mjs @@ -124,6 +124,7 @@ describe('computer-use smoke script', () => { encoding: 'utf8', env: { ...process.env, + ORCA_COMPUTER_SMOKE_APPS: undefined, ORCA_COMPUTER_SMOKE_CLI_PATH: cliPath, ORCA_COMPUTER_SMOKE_USER_DATA_PATH: path.join(root, 'user-data') } diff --git a/config/scripts/counterbalanced-benchmark-schedule.test.mjs b/config/scripts/counterbalanced-benchmark-schedule.test.mjs index cee28e4b70e..adb5ab1da2f 100644 --- a/config/scripts/counterbalanced-benchmark-schedule.test.mjs +++ b/config/scripts/counterbalanced-benchmark-schedule.test.mjs @@ -57,11 +57,6 @@ describe('counterbalanced benchmark schedule', () => { const login = summarizeBenchmarkSamples(samples.login) const fast = summarizeBenchmarkSamples(samples.fast) expect(fast.medianMs - login.medianMs).toBe(trueDuration.fast - trueDuration.login) - - const lowerMedian = (values) => [...values].sort((left, right) => left - right)[9] - expect(lowerMedian(samples.fast) - lowerMedian(samples.login)).toBe( - trueDuration.fast - trueDuration.login - driftPerLaunch - ) }) it('bounds the descriptive p95 bias to one linear-drift launch slot', () => { diff --git a/config/scripts/create-draft-release.test.mjs b/config/scripts/create-draft-release.test.mjs index 8dc36369b32..5500a1e0a1f 100644 --- a/config/scripts/create-draft-release.test.mjs +++ b/config/scripts/create-draft-release.test.mjs @@ -61,26 +61,12 @@ describe('latestPreviousPublishedDesktopReleaseTag', () => { it('bounds stable notes to the previous stable release when rcs exist', () => { expect( latestPreviousPublishedDesktopReleaseTag( - [release('v1.4.35'), release('v1.4.36-rc.0'), release('v1.4.36')], + [release('v1.4.35'), release('v1.4.36-rc.0'), release('v1.4.36-rc.6'), release('v1.4.36')], 'v1.4.36' ) ).toBe('v1.4.35') }) - it('does not collapse a stable changelog to its rc-to-stable version bump', () => { - expect( - latestPreviousPublishedDesktopReleaseTag( - [ - release('v1.4.120'), - release('v1.4.121-rc.0'), - release('v1.4.121-rc.6'), - release('v1.4.121') - ], - 'v1.4.121' - ) - ).toBe('v1.4.120') - }) - it('bounds the first rc notes to the previous stable release', () => { expect( latestPreviousPublishedDesktopReleaseTag( diff --git a/config/scripts/daily-build-version.test.mjs b/config/scripts/daily-build-version.test.mjs index b08844b56be..792e8d94519 100644 --- a/config/scripts/daily-build-version.test.mjs +++ b/config/scripts/daily-build-version.test.mjs @@ -22,16 +22,14 @@ describe('createDailyBuildVersion', () => { const version = createDailyBuildVersion('1.4.160-rc.3', new Date('2026-07-28T13:00:00Z')) expect(version).toBe('1.4.160-daily.202607281300') expect(compareAppVersions(version, '1.4.160-rc.3')).toBeLessThan(0) - expect(compareAppVersions('1.4.160-rc.3-daily.202607281300', '1.4.160-rc.3')).toBeGreaterThan(0) }) // Why: 'daily' sorts before 'hourly' alphabetically, so a daily of the same // base never outranks an hourly — both stay below rc/stable and only the // channel picker offers them. it('sorts below the hourly build of the same base version', () => { - expect( - compareAppVersions('1.4.160-daily.202607281300', '1.4.160-hourly.202607281400') - ).toBeLessThan(0) + const version = createDailyBuildVersion('1.4.160', new Date('2026-07-28T13:00:00Z')) + expect(compareAppVersions(version, '1.4.160-hourly.202607281400')).toBeLessThan(0) }) it('rejects invalid input', () => { @@ -44,11 +42,6 @@ describe('formatDailyReleaseName', () => { const name = (iso, buildNumber = 1, commit = 'e698241abcde') => formatDailyReleaseName('1.4.163-daily.x', buildNumber, commit, new Date(iso)) - it('renders version, number, Pacific timestamp, and short sha', () => { - // 17:15 UTC is 10:15AM PDT in July (the daily cut time). - expect(name('2026-07-28T17:15:00Z')).toBe('1.4.163 • 01 • Jul 28, 10:15AM • e698241') - }) - // Why both sides of DST: the tag's stamp is UTC and the title is Pacific, so // the offset between them is not a constant. A test pinned to one season would // pass all summer and start failing in November. diff --git a/config/scripts/dev-channel-base-version.test.mjs b/config/scripts/dev-channel-base-version.test.mjs index 00c13f6817a..577f984fb3d 100644 --- a/config/scripts/dev-channel-base-version.test.mjs +++ b/config/scripts/dev-channel-base-version.test.mjs @@ -1,4 +1,4 @@ -import { describe, expect, it } from 'vitest' +import { describe, expect, it, vi } from 'vitest' import { readPublishedVersionsFromEnv, resolveDevChannelBaseVersion @@ -39,13 +39,6 @@ describe('dev channel base version', () => { ) }) - // Why tags rather than GitHub releases: unpublishing a buggy cut deletes the - // GitHub release and leaves the tag. Releases-only then treated 1.4.202 as - // free, so hourlies sat on 1.4.202-hourly and sorted below that tagged stable. - it('climbs past a tagged stable that has no GitHub release', () => { - expect(resolveDevChannelBaseVersion('1.4.197', ['v1.4.201', 'v1.4.202'])).toBe('1.4.203') - }) - // 2026-09-14: v1.4.202's GitHub release was deleted for a bug after hourlies // had already shipped as 1.4.203. Without the channel tags as a floor, the // next hourlies would have been 1.4.202-hourly, which electron-updater will @@ -80,9 +73,19 @@ describe('dev channel base version', () => { expect(resolveDevChannelBaseVersion('1.4.0', ['v2.0.0'])).toBe('2.0.1') }) - it('splits an env tag list on any whitespace', () => { - expect(readPublishedVersionsFromEnv('v1.4.167\nv1.4.166\n')).toEqual(['v1.4.167', 'v1.4.166']) + it('reads whitespace-separated tags from explicit input or the environment', () => { + expect(readPublishedVersionsFromEnv(' \tv1.4.167\r\nv1.4.166\n')).toEqual([ + 'v1.4.167', + 'v1.4.166' + ]) expect(readPublishedVersionsFromEnv('')).toEqual([]) - expect(readPublishedVersionsFromEnv(undefined)).toEqual([]) + try { + vi.stubEnv('ORCA_PUBLISHED_VERSIONS', 'v1.4.170\tv1.4.169') + expect(readPublishedVersionsFromEnv()).toEqual(['v1.4.170', 'v1.4.169']) + vi.stubEnv('ORCA_PUBLISHED_VERSIONS', undefined) + expect(readPublishedVersionsFromEnv()).toEqual([]) + } finally { + vi.unstubAllEnvs() + } }) }) diff --git a/config/scripts/dev-electron-bundle-identity.test.ts b/config/scripts/dev-electron-bundle-identity.test.ts index 0b064caae79..53674a18617 100644 --- a/config/scripts/dev-electron-bundle-identity.test.ts +++ b/config/scripts/dev-electron-bundle-identity.test.ts @@ -39,14 +39,6 @@ function patchesUnder(dockTitle: string, branch: string) { } describe('dev-electron-bundle-identity', () => { - it('leaves process.env untouched, including its object identity', () => { - const envBefore = process.env - const snapshot = { ...process.env } - patchesUnder('Orca: some-branch', 'some-branch') - expect(process.env).toBe(envBefore) - expect({ ...process.env }).toEqual(snapshot) - }) - it('gives the dev app a legible display name so notifications are not just "Electron"', () => { const byKey = Object.fromEntries( getDevBundlePlistPatches().map((patch) => [patch.key, patch.value]) @@ -79,15 +71,4 @@ describe('dev-electron-bundle-identity', () => { patchesUnder('Orca: some-worktree @ feature/x', 'feature/x') ) }) - - it('leaks no branch, worktree, or title text into any patched value', () => { - const branch = 'fix-login-crash' - const worktree = 'Orca-safe-storage-lock' - for (const patch of patchesUnder(`Orca: ${branch}`, branch)) { - expect(patch.value).not.toContain(branch) - expect(patch.value).not.toContain(worktree) - expect(typeof patch.value).toBe('string') - expect(patch.value.length).toBeGreaterThan(0) - } - }) }) diff --git a/config/scripts/electron-builder-config.test.mjs b/config/scripts/electron-builder-config.test.mjs index ef6030194eb..de4e69fba89 100644 --- a/config/scripts/electron-builder-config.test.mjs +++ b/config/scripts/electron-builder-config.test.mjs @@ -22,29 +22,34 @@ describe('electron-builder config', () => { }) it('excludes repo-only source trees from app.asar', () => { - expect(electronBuilderConfig.files).toEqual( - expect.arrayContaining([ - '!src{,/**/*}', - '!config{,/**/*}', - '!cloud{,/**/*}', - '!docs{,/**/*}', - '!mobile{,/**/*}', - '!native{,/**/*}', - '!skills{,/**/*}', - '!skill-guides{,/**/*}', - '!skill-stubs{,/**/*}', - '!resources/skills/**', - '!tests{,/**/*}', - '!examples{,/**/*}', - '!pr-evidence{,/**/*}', - '!notes{,/**/*}', - '!{.claude,.grok,.agents,.codex}{,/**/*}', - '!Casks{,/**/*}', - '!{AGENTS.md,CLAUDE.md,DEVELOPING.md,bundle-size-progress.md,ORCHESTRATION_IMPLEMENTATION_CHECKLIST.md,ORCHESTRATION_STRUCTURED_OUTPUT_DESIGN.md}', - '!out/**/*.test.js', - '!resources/plugins/launch/**' - ]) - ) + const matcher = new FileMatcher('/app', '/dest', (value) => value, electronBuilderConfig.files) + matcher.prependPattern('**/*') + const isPacked = matcher.createFilter() + const packs = (repoPath) => isPacked(join('/app', repoPath), { isDirectory: () => false }) + for (const sourcePath of [ + 'src/main/index.ts', + 'config/electron-builder.config.cjs', + 'cloud/apps/relay/index.ts', + 'docs/README.md', + 'mobile/app/index.tsx', + 'native/windows-cli-launcher/main.cpp', + 'skills/release/SKILL.md', + 'skill-guides/release.md', + 'skill-stubs/release.md', + 'resources/skills/current-manifest.json', + 'tests/e2e/example.spec.ts', + 'examples/example.ts', + 'pr-evidence/example.png', + 'Casks/orca.rb', + 'AGENTS.md', + 'out/main/workspace.test.js', + 'resources/plugins/launch/example.ts' + ]) { + expect(packs(sourcePath), sourcePath).toBe(false) + } + expect(packs('out/main/index.js')).toBe(true) + expect(packs('node_modules/example/docs/index.js')).toBe(true) + expect(packs('node_modules/example/src/index.js')).toBe(true) }) it('keeps release build staging out of app.asar while preserving runtime output', () => { @@ -629,21 +634,24 @@ describe('arch-aware packaging guard', () => { } }) - it('requires the other architecture natives to be installed', () => { - const otherSherpaInstalled = existsSync( - join(REPO_ROOT, 'node_modules', otherSherpa, 'package.json') - ) - const otherSherpaExpected = Object.hasOwn( - require('../../package.json').optionalDependencies, - otherSherpa - ) - if (otherSherpaExpected && !otherSherpaInstalled) { - expect(() => packHost(OTHER_ARCH)).toThrow(otherSherpa) - expect(() => packHost(OTHER_ARCH)).toThrow('pnpm install:release') - } else if (process.platform !== 'win32') { - expect(() => packHost(OTHER_ARCH)).not.toThrow() + it.skipIf(process.platform === 'win32')( + 'requires the other architecture natives to be installed', + () => { + const otherSherpaInstalled = existsSync( + join(REPO_ROOT, 'node_modules', otherSherpa, 'package.json') + ) + const otherSherpaExpected = Object.hasOwn( + require('../../package.json').optionalDependencies, + otherSherpa + ) + if (otherSherpaExpected && !otherSherpaInstalled) { + expect(() => packHost(OTHER_ARCH)).toThrow(otherSherpa) + expect(() => packHost(OTHER_ARCH)).toThrow('pnpm install:release') + } else { + expect(() => packHost(OTHER_ARCH)).not.toThrow() + } } - }) + ) // The host's own build is the foreign-arch case: a Windows checkout compiles these for its CPU only. it.runIf(process.platform === 'win32')( diff --git a/config/scripts/ensure-native-runtime-job-ownership.test.mjs b/config/scripts/ensure-native-runtime-job-ownership.test.mjs index 960c87e362b..96fb6d4e799 100644 --- a/config/scripts/ensure-native-runtime-job-ownership.test.mjs +++ b/config/scripts/ensure-native-runtime-job-ownership.test.mjs @@ -100,13 +100,7 @@ describe('assertNodePtyJobOwnership', () => { it('rejects the prebuild that shipped without the job exports', () => { expect(() => assertNodePtyJobOwnership(onWindows(PREBUILD, CURRENT_ADDON))).toThrow( - /listJobProcessIds, terminateJob, assignCurrentProcessToJob/ - ) - }) - - it('names where the bad native came from, so the fix is obvious', () => { - expect(() => assertNodePtyJobOwnership(onWindows(PREBUILD, CURRENT_ADDON))).toThrow( - /prebuilds\/win32-x64/ + /listJobProcessIds, terminateJob, assignCurrentProcessToJob[\s\S]*prebuilds\/win32-x64/ ) }) @@ -119,13 +113,7 @@ describe('assertNodePtyJobOwnership', () => { // child out of its pane's job satisfies all of them. it('rejects a source build that predates the Cygwin/MSYS breakaway denial', () => { expect(() => assertNodePtyJobOwnership(onWindows(PATCHED, PRE_MSYS_ADDON))).toThrow( - /predates the Cygwin\/MSYS job-breakaway denial/ - ) - }) - - it('tells that build apart by path, and says to rebuild', () => { - expect(() => assertNodePtyJobOwnership(onWindows(PATCHED, PRE_MSYS_ADDON))).toThrow( - /pre-msys\.node[\s\S]*Rebuild node-pty from source/ + /pre-msys\.node[\s\S]*predates the Cygwin\/MSYS job-breakaway denial[\s\S]*Rebuild node-pty from source/ ) }) @@ -218,17 +206,12 @@ describe('assertRebuiltConptyDeniesMsysBreakaway', () => { // falls through to the published prebuild -- the binary that leaks every MSYS // pane child. That is a broken build, not an absence to shrug at. it('refuses a same-host rebuild that reported success and produced nothing', () => { - const nodePtyDir = rebuiltInto({ 'package.json': {} }) - expect(() => - assertRebuiltConptyDeniesMsysBreakaway({ nodePtyDir, rebuildArch: 'x64', crossHost: false }) - ).toThrow(/the rebuild reported success/) - }) - - it('names both the addon it wanted and the prebuild that would load instead', () => { const nodePtyDir = rebuiltInto({ 'package.json': {} }) expect(() => assertRebuiltConptyDeniesMsysBreakaway({ nodePtyDir, rebuildArch: 'arm64', crossHost: false }) - ).toThrow(/build[\\/]Release[\s\S]*prebuilds[\\/]win32-arm64/) + ).toThrow( + /the rebuild reported success[\s\S]*build[\\/]Release[\s\S]*prebuilds[\\/]win32-arm64/ + ) }) // A rebuild that ignored --arch leaves a binary the target cannot load, so @@ -250,16 +233,9 @@ describe('assertRebuiltConptyDeniesMsysBreakaway', () => { writeFileSync(join(nodePtyDir, 'build', 'Release', 'conpty.node'), Buffer.alloc(0x200)) expect(() => assertRebuiltConptyDeniesMsysBreakaway({ nodePtyDir, rebuildArch: 'x64', crossHost: false }) - ).toThrow(/is not a PE image[\s\S]*truncated or quarantined/) - }) - - it('still names the consequence for that file, which is the prebuild', () => { - const nodePtyDir = join(mkdtempSync(join(fixtureDir, 'rebuild-')), 'node-pty') - mkdirSync(join(nodePtyDir, 'build', 'Release'), { recursive: true }) - writeFileSync(join(nodePtyDir, 'build', 'Release', 'conpty.node'), Buffer.alloc(0x200)) - expect(() => - assertRebuiltConptyDeniesMsysBreakaway({ nodePtyDir, rebuildArch: 'x64', crossHost: false }) - ).toThrow(/fall back to the published prebuild/) + ).toThrow( + /is not a PE image[\s\S]*fall back to the published prebuild[\s\S]*truncated or quarantined/ + ) }) it('accepts one a cross-arch rebuild really did emit for the target', () => { diff --git a/config/scripts/generate-bundled-skill-guides.test.mjs b/config/scripts/generate-bundled-skill-guides.test.mjs index 7ce3d5d2d78..727c8236ad9 100644 --- a/config/scripts/generate-bundled-skill-guides.test.mjs +++ b/config/scripts/generate-bundled-skill-guides.test.mjs @@ -280,17 +280,6 @@ describe('bundled skill guide generator', () => { } ) - it('pins guide sources, projections, and embedded output to LF in Git', async () => { - const attributes = await readFile(path.join(projectDir, '.gitattributes'), 'utf8') - expect(normalizeMarkdown(attributes)).toContain('/skill-guides/*.md text eol=lf\n') - expect(normalizeMarkdown(attributes)).toContain('/skill-stubs/*.md text eol=lf\n') - expect(normalizeMarkdown(attributes)).toContain('/skill-stubs/_shared/*.md text eol=lf\n') - expect(normalizeMarkdown(attributes)).toContain('/skills/*/SKILL.md text eol=lf\n') - expect(normalizeMarkdown(attributes)).toContain( - '/src/cli/bundled-skill-guides.ts text eol=lf\n' - ) - }) - it('reports stale outputs and write mode repairs all projections', async () => { const root = await createFixture() const artifacts = await buildArtifacts(root) diff --git a/config/scripts/generate-runtime-required-english-catalog.test.mjs b/config/scripts/generate-runtime-required-english-catalog.test.mjs index 35c84ad5bcd..8d3ac228387 100644 --- a/config/scripts/generate-runtime-required-english-catalog.test.mjs +++ b/config/scripts/generate-runtime-required-english-catalog.test.mjs @@ -37,10 +37,6 @@ describe('runtime-required English catalog rule', () => { ]) }) - it('keeps a plural entry even when a call site spells it identically', () => { - expect(collectRuntimeRequiredKeys(entries, references).has('count.thing_one')).toBe(true) - }) - // The generated file is committed, so a walk-order difference between a // contributor's machine and CI would make the gate flap forever. it('produces byte-identical output whatever order the call sites are visited in', () => { diff --git a/config/scripts/generated-artifact-line-ending-pin.test.mjs b/config/scripts/generated-artifact-line-ending-pin.test.mjs index 70e2ab41075..2da5a2c1381 100644 --- a/config/scripts/generated-artifact-line-ending-pin.test.mjs +++ b/config/scripts/generated-artifact-line-ending-pin.test.mjs @@ -17,6 +17,11 @@ it('keeps byte-compared artifacts and source LF in an autocrlf checkout', () => ['src/main/example.ts', lf], ['config/scripts/example.mjs', lf], ['config/scripts/nested/deeper/example.mjs', lf], + ['skill-guides/example.md', lf], + ['skill-stubs/example.md', lf], + ['skill-stubs/_shared/example.md', lf], + ['skills/example/SKILL.md', lf], + ['src/cli/bundled-skill-guides.ts', lf], ...['cmd', 'bat', 'ps1', 'nsh'].map((extension) => [`config/example.${extension}`, crlf]), ['resources/skills-extra/example.json', crlf], ['vendor/resources/skills/example.json', crlf], diff --git a/config/scripts/happy-dom-mutation-observer-retention.test.ts b/config/scripts/happy-dom-mutation-observer-retention.test.ts index 475a84c9b31..1aa4af3733a 100644 --- a/config/scripts/happy-dom-mutation-observer-retention.test.ts +++ b/config/scripts/happy-dom-mutation-observer-retention.test.ts @@ -40,6 +40,10 @@ describe('happy-dom MutationObserver retention', () => { }) it('keeps delivering records after the weak callback would have been collected', async () => { + const collectGarbage = globalThis.gc + if (typeof collectGarbage !== 'function') { + throw new Error('MutationObserver retention requires --expose-gc') + } installHappyDomMutationObserverRetention() const target = document.createElement('div') document.body.append(target) @@ -53,14 +57,11 @@ describe('happy-dom MutationObserver retention', () => { await Promise.resolve() expect(deliveries).toBe(1) - const collectGarbage = (globalThis as { gc?: () => void }).gc - if (collectGarbage) { - for (let round = 0; round < 5; round += 1) { - await new Promise((resolve) => setTimeout(resolve, 1)) - collectGarbage() - } + for (let round = 0; round < 5; round += 1) { await new Promise((resolve) => setTimeout(resolve, 1)) + collectGarbage() } + await new Promise((resolve) => setTimeout(resolve, 1)) target.replaceChildren(document.createElement('span')) await Promise.resolve() diff --git a/config/scripts/happy-dom-offscreen-canvas.test.ts b/config/scripts/happy-dom-offscreen-canvas.test.ts index a857136d563..a84998d1e37 100644 --- a/config/scripts/happy-dom-offscreen-canvas.test.ts +++ b/config/scripts/happy-dom-offscreen-canvas.test.ts @@ -3,13 +3,6 @@ import { Terminal } from '@xterm/xterm' import { afterEach, describe, expect, it, vi } from 'vitest' import { installHappyDomOffscreenCanvasCompatibility } from './happy-dom-offscreen-canvas' -type TestOffscreenCanvas = new ( - width: number, - height: number -) => { - getContext: (contextType: string, contextAttributes?: unknown) => unknown -} - const openTerminals: Terminal[] = [] describe('happy-dom OffscreenCanvas compatibility', () => { @@ -22,12 +15,8 @@ describe('happy-dom OffscreenCanvas compatibility', () => { }) it('delegates adapter-less 2D contexts to the existing HTML canvas double', () => { - const offscreenCanvas = (globalThis as { OffscreenCanvas?: TestOffscreenCanvas }) - .OffscreenCanvas - if (!offscreenCanvas) { - expect(installHappyDomOffscreenCanvasCompatibility()).toBe(false) - return - } + const offscreenCanvas = globalThis.OffscreenCanvas + expect(offscreenCanvas).toBeTypeOf('function') const context = { measureText: () => ({ width: 10 }) } const getContext = vi @@ -40,11 +29,8 @@ describe('happy-dom OffscreenCanvas compatibility', () => { }) it('does not turn unsupported non-2D contexts into test doubles', () => { - const offscreenCanvas = (globalThis as { OffscreenCanvas?: TestOffscreenCanvas }) - .OffscreenCanvas - if (!offscreenCanvas) { - return - } + const offscreenCanvas = globalThis.OffscreenCanvas + expect(offscreenCanvas).toBeTypeOf('function') const getContext = vi.spyOn(HTMLCanvasElement.prototype, 'getContext') expect(new offscreenCanvas(1, 1).getContext('webgl')).toBeNull() diff --git a/docs/audits/test-value/README.md b/docs/audits/test-value/README.md index 5d9cff7ef31..f3d97feb675 100644 --- a/docs/audits/test-value/README.md +++ b/docs/audits/test-value/README.md @@ -24,10 +24,10 @@ Completion requires no unreviewed or stale test files, no unresolved support/scr | Area | Reviewer | Next batch | | ------------------------------------------------ | -------------- | -------------------------- | -| `cloud/` | `audit_cloud` | `cloud-0003` (read-only) | -| `config/` | `audit_config` | `config-0003` (read-only) | -| `mobile/` | `audit_mobile` | `mobile-0003` (read-only) | -| `src/`, `native/`, `tests/`, `.github/`, `docs/` | root | Continue after `root-0006` | +| `cloud/` | `audit_cloud` | `cloud-0004` | +| `config/` | `audit_config` | `config-0004` | +| `mobile/` | `audit_mobile` | `mobile-0004` | +| `src/`, `native/`, `tests/`, `.github/`, `docs/` | root | Continue after `root-0013` | Ownership is disjoint. Within an area, continue in tracked path order after the last batch; explicitly include nonstandard/inline cases and support candidates before closing the area. @@ -41,19 +41,35 @@ Batch validation lives in `reviews/--validation.json`. Local log pa [PR #32269](https://github.com/stablyai/orca/pull/32269) merged the first 105 reviewed files and 720 original declarations, removing 467 net test lines. Its full PR aggregate and all other checks passed; squash commit `bc99add2897d1e9a77da44630d11eaff5cf81249`. +[PR #32305](https://github.com/stablyai/orca/pull/32305) merged another 210 original files and 1,482 case records, removing 324 net test lines. All required checks and the full PR aggregate passed; squash commit `92dfb4fda69e746e96786ea7af417813ac441394`. + +The next batch adds 180 original files and 1,188 case records, plus one re-review after upstream changes. Its 70 changed test files remove 318 net test lines. Case records include static declarations and explicitly classified manual controls; they are not runtime test totals. + Further completed review records: -| Batch | Files | Original cases | Main decisions | -| ------------- | ----: | -------------: | ----------------------------------------------------------------------------------------------------------------- | -| `root-0001` | 14 | 101 | Repair observer reset/readiness; trim allocator and environment-only checks. | -| `root-0002` | 20 | 87 | Exercise installed link callbacks; consolidate cache checks; remove a conditional no-op test. | -| `root-0003` | 6 | 40 | Classify Windows fixtures and standalone cases; retain native clipboard integration; trim exact traversal counts. | -| `root-0004` | 15 | 101 | Remove source-string and capability-only checks; observe pacing in actual mouse delivery. | -| `root-0005` | 4 | 32 | Retain real Windows argument, filesystem and delayed tree-termination boundaries. | -| `root-0006` | 1 | 14 | Retain storage lease ownership, generation conflicts and clock-driven credential caching. | -| `mobile-0002` | 50 | 283 | Consolidate repeated mounts and inventories; fix action routing and deferred SSH assertions. | -| `config-0002` | 50 | 375 | Trim copied policies; fix vacuous assertions and nested Bash fixture isolation. | -| `cloud-0002` | 50 | 449 | Use independent authorization inputs and durable phone state; observe scoped locks and clean migration fixtures. | +| Batch | Files | Case records | Main decisions | +| ------------- | ----------: | -----------: | ----------------------------------------------------------------------------------------------------------------- | +| `root-0001` | 14 | 101 | Repair observer reset/readiness; trim allocator and environment-only checks. | +| `root-0002` | 20 | 87 | Exercise installed link callbacks; consolidate cache checks; remove a conditional no-op test. | +| `root-0003` | 6 | 40 | Classify Windows fixtures and standalone cases; retain native clipboard integration; trim exact traversal counts. | +| `root-0004` | 15 | 101 | Remove source-string and capability-only checks; observe pacing in actual mouse delivery. | +| `root-0005` | 4 | 32 | Retain real Windows argument, filesystem and delayed tree-termination boundaries. | +| `root-0006` | 1 | 14 | Retain storage lease ownership, generation conflicts and clock-driven credential caching. | +| `mobile-0002` | 50 | 283 | Consolidate repeated mounts and inventories; fix action routing and deferred SSH assertions. | +| `config-0002` | 50 | 375 | Trim copied policies; fix vacuous assertions and nested Bash fixture isolation. | +| `cloud-0002` | 50 | 449 | Use independent authorization inputs and durable phone state; observe scoped locks and clean migration fixtures. | +| `root-0007` | 3 | 22 | Trim action/docs inventories; test actual hostile formatter inputs under a VM deadline. | +| `root-0008` | 5 | 5 | Classify filesystem, socket and task retention proofs; distinguish measurements from assertions. | +| `root-0009` | 5 | 6 | Preserve archived browser lifecycle and source-graph proofs with explicit drift limits. | +| `root-0010` | 4 | 6 | Preserve actual Monaco/store lifetime proof and its dependency/source fences. | +| `root-0011` | 2 | 10 | Correct a chunk-size test's memory claim; classify the historical history-window driver. | +| `root-0012` | 8 | 96 | Preserve independent full-reader oracle and every manual parity/growth/allocation/verifier control. | +| `root-0013` | 1 re-review | 7 | Recheck the upstream compiler-gate change; all seven actual build cases pass. | +| `mobile-0003` | 50 | 315 | Remove copied inventories; exercise real editor fallback, discard target and hardware-back delivery. | +| `config-0003` | 50 | 328 | Use actual file matching, generated versions and Git checkout bytes; require real GC/canvas paths. | +| `cloud-0003` | 53 | 400 | Exercise batch renewal, actual replay/SQL, scoped locks, pagination and deterministic transaction errors. | + +Archived proofs retain historical source/dependency fences. A drift rejection is recorded as a limitation, never as a current-head test pass. Permanent suites read only as supporting evidence remain pending unless they have their own completed review. Validation commands, results and platform limits live in each batch's validation JSON. The macOS changes require the native Swift CI job; local Linux runs cannot establish that result. Standalone Windows cases are explicitly enumerated even when the static parser finds no declarations. Fixture/support classifications have no invented runnable cases. All remaining candidates stay pending, and broad discovery still requires final runner/entrypoint reconciliation. diff --git a/docs/audits/test-value/inventory.jsonl b/docs/audits/test-value/inventory.jsonl index b3d07f995c8..3f64892dc70 100644 --- a/docs/audits/test-value/inventory.jsonl +++ b/docs/audits/test-value/inventory.jsonl @@ -1,4 +1,4 @@ -{"path":".github/actions/cloud-sql-rollout-lease/action-contract.test.mjs","sha256":"854ccd6d3fd2f71e230368c584df88c1a1393fdc5505fe2a4d4f0c666499bb88","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} +{"path":".github/actions/cloud-sql-rollout-lease/action-contract.test.mjs","sha256":"711d8a6d0afc2dcaaf8f233c2894685bb3e72481d62722be05ccc8261372e324","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/root-0007.jsonl"} {"path":".github/actions/cloud-sql-rollout-lease/storage-lease.test.mjs","sha256":"1dd2bd63f08125608cdfaf2560eff75f2800b49f1b2b43c52788a23f85ba782d","declarations":14,"signals":["named","declarations"],"status":"reviewed","review":"reviews/root-0006.jsonl"} {"path":"cloud/apps/push/src/apns-client.test.ts","sha256":"4de5e44d0b2ef7dab8508935c85f14e9dbb19ab2d02026481497399f89c76f69","declarations":8,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0001.jsonl"} {"path":"cloud/apps/push/src/apns-session-replacement.test.ts","sha256":"e6fb235c1dac08b79a00c641cefc19917219ad049d40d4f680bd05433babd913","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0001.jsonl"} @@ -88,56 +88,57 @@ {"path":"cloud/apps/relay/src/cell-reserve-rollback.blackbox.test.ts","sha256":"575be0aef560304a9c10f444ea7760e9fe45f3342876fae742b9c0bb3a00c822","declarations":10,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0002.jsonl"} {"path":"cloud/apps/relay/src/cell-reserve-routes.test.ts","sha256":"bfb6049db1f492b6d65b6cedea72e1a3fa41998776735f3160fa2d2b7308eeb6","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0002.jsonl"} {"path":"cloud/apps/relay/src/cell-seat-drift.test.ts","sha256":"f763eefde98c42df7825be2de93a6035af2abf9e2fa3612e89a37815539561f4","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0002.jsonl"} -{"path":"cloud/apps/relay/src/cell-seat-feed.test.ts","sha256":"c8a0642b4858af185c2877b2a0f4b1c76e65a33deef6838a766e843eff650fae","declarations":11,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/cell-seat-log.test.ts","sha256":"d5173601a135cf68339ec65df3c0d07629f698f163237a6213771caf0abaec7d","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/config.test.ts","sha256":"96e13eb55b2e856d6278502ae0123148de9808b4bcf8cda77f0a47e3c8d03487","declarations":15,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/connection-reservation-debt-retention.test.ts","sha256":"41d35eaf400f161b6a329113ecffba339326d2ba02fbf633f2e7f6e66bc08abc","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-accept-cell-row-lock-postgres.test.ts","sha256":"4cc5ea469a9d5261d770b910d5ab65a11b54e375674e4fba10454b8fa3a9ea70","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-accept-cell-row-lock.test.ts","sha256":"4c60f182c1b021668ce716a23a6bbaf827c52dcd45d45e9a91ef3065541d7f10","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-lease-recovery-postgres.test.ts","sha256":"303671b93a590a4bf1b0f0ca11e7889df0bedec49b0afa87419333e3bd3cbecb","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts","sha256":"ba35c4d006cec797fd85bdbadb6632aa48c8b9488fc209c89bc96276647ee641","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-renewal-batch-store.test.ts","sha256":"58425a95d7efe57071ac5c73aca198f3c7ab559f8b72a84be2a66d11e72b0b1c","declarations":12,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-renewal-batch.test.ts","sha256":"0cb0e1bbb0261f62bb2a1fabd329b0f9c0d08947d65e0b02ea8a92a746e3c9f1","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-renewal-postgres.test.ts","sha256":"3df1cf3aad0a7dc794ba8a1d72a4157fcb8b2cf4a4418b80efe5b9601fe631ce","declarations":10,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/control-reservation-reconnect-claim.test.ts","sha256":"f617fb4e79f0cef41507b1b1983b08f97ff5a9520872c7928b677e0f42e2ee4d","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts","sha256":"85e76c71b9bf741f926829a51516e0e1280aeb148922d21ddce97dd63f2053d8","declarations":8,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/credential-store-cleanup.test.ts","sha256":"643200d2fcbc61abe423e58452e772bb2d487bfc013d9627d788734e4727fd2e","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/credential-store.test.ts","sha256":"753ce3910596d2905c72ab2289e24e2a1da361141c56b2994a2e9b8f62d2df77","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/database-connect-stall-postgres.test.ts","sha256":"dfa160d2467b14ce891a18ff2a9cba09adfa78c436aec4f3d7bab58e0db9da24","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/database-postgres-timeout.test.ts","sha256":"3497d7e6146ad6fd7a0051c9670d1f71946b867ca33b96615b265e08b8b1d367","declarations":21,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/database-statement-timeout-postgres.test.ts","sha256":"4377fdb2b495aa3eba9370de9d53c365b15e746d843de7b2f15e931da70ede50","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/database-transient-error.test.ts","sha256":"76729a1363b84aabad8b0dbb17489e17aa8c1f60a77dd50657f55d1894c07ef2","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/database.test.ts","sha256":"11a4c7be7489e24733be81606073ef432a683e5ba03b1c4441fb266a64888788","declarations":8,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/dead-cell-evacuation-precheck.test.ts","sha256":"fa3acbdf0094e45a46d5482e5809a100744761471b17368520c4231b46f66a89","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/dead-relay-tables-postgres.test.ts","sha256":"f5d97ad3278402e7715928edaaac1d326c26478f583d31c836cc600a230dd25e","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/director-reserve-placement-status.test.ts","sha256":"59253d3a7b73cddb6eeba362e73e16ec0821fc61a6a4059b36949b0043927ddf","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/drain-migration-row-lookup.test.ts","sha256":"783947cca8f9db3e0fdec0f5c56cdb8c9c422cf5d3db1a7a2bb592cab14b26fb","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/drain-migration-row-scaling.test.ts","sha256":"2adabae89beee885a85d5a58dedfb9e3d3379b6d0045edd088ec399e4023a76c","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts","sha256":"0dc9fe610ebe8ec298c0d61fcd27bc9fc4e0c6cdfdd5ff745e529a36564b518a","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/drain-return-admission.test.ts","sha256":"6d1902ea12f44ea8fb75f532582eb1f9bef02a82679c84c60ca0b676c9b7e2c2","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/floating-promise-census.test.ts","sha256":"5364ef8bf1e5e18aed2795ed0ab32ee7a8021e79f6218f2eabe2adae2141380b","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-close-reason-memory.test.ts","sha256":"20bbb0d25f0de972fc9419975b87bbbabe706ff41bf3c64efa19fd9a3ecba039","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-control-proof-cleanup.test.ts","sha256":"16ebfdec0a7e542316c27b0d53ff319c614c3dffd09feb086dde54042ace1705","declarations":12,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-control-resume-identity.test.ts","sha256":"0a47bbf7d4f824734be27e7851e8cd871531b3fe402a2ca9e665c5a81606320d","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-session-client-accept.test.ts","sha256":"05ec3447db6b3e7758f7964c905e773c070aa36683d8262d1f96a7b3ea7e7366","declarations":19,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-session-drain-release-order.test.ts","sha256":"67cf0d3b4ee29e762f771ff34991dc89e41d5efdc8094ddcaf8d714e14515c71","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-session-preauth-latency.test.ts","sha256":"fd204e24f7dbe3889c4e939cb6adadbd9fbef7c85084faecd314d0df7c9ad5db","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-session-registry.test.ts","sha256":"90534b6173be8f5234822d92126239800deda64e0adfb7c303934fd13ca47818","declarations":75,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-signed-out-rejection.test.ts","sha256":"5bf81f9f83182d458810414dcbc618998e018fabcf142bd0798c0b63c99a644f","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/host-whereabouts-app.test.ts","sha256":"5a2f335ab1b023d1e93ebb4d354f655fa2302d2775aaa803009a585773506a51","declarations":8,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts","sha256":"4bc34a7385f4b7a6be00471e8ede5e5e2706bd3b799feb73041460c27eaf2123","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/idle-regional-rehome-store.test.ts","sha256":"562fb019637e30ff98442789f547b8a7f855f4a137ec71ae76957b549a380f9c","declarations":14,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/idle-regional-rehome-window.test.ts","sha256":"1e32a2de9b5a547c65a04578b3f527e44aec82afe63a2974e9e7ec4d00bc86f5","declarations":8,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/idle-regional-rehome-worker.test.ts","sha256":"c34eb2c717dc8ac05d238508677fc2f946b40df9f80e6e994f57fc4c6e4ee3a2","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/migration-recovery-postgres.test.ts","sha256":"8c80069a6a4758fb3dfdfc719de569da0773cfee64f512bc46a21e9bf63642d2","declarations":29,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/placement-load-band.test.ts","sha256":"b2642e82ad5844448da6e7e1c47a998b3b96154bc677a8bf29554ec9d856ca67","declarations":10,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/post-proof-close-log.test.ts","sha256":"34c4a6788d688d8ff25de1538a435dffe3cea303b65f69c3b2ee3cf43d79ba50","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/postgres-checked-out-client-error.test.ts","sha256":"cee18f05c444278d86ba3506a941d616b3ba5304659d79325e2fb3e206368d1c","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts","sha256":"a2fc81bfaca3d3c0270e751ab3fe39edcb51302deffe73180fa7f52ddb366b33","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/postgres-drain-send-locking.test.ts","sha256":"a02f2a140ccbf171db79a8a41c8c78d0bb85078e4100ac0340d9c6a807f36bfd","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/postgres-idle-client-error.test.ts","sha256":"3cd23450d732ea42c1ebbd6c136d4451564fe8fd80e33984d8037cdcff40d7d2","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts","sha256":"aa71d6d74c586b1102b4a8a58f51e6e2dec7a0ecd721ae37732c72ca5699b87e","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/postgres-lock-wait-sample.test.ts","sha256":"b5a1cf90b57c891a5fa5fa849cc79338cf7b21de21596562890946f5dd8e8e37","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} +{"path":"cloud/apps/relay/src/cell-seat-feed.test.ts","sha256":"d95676c889380ac05e56c75c51c4fcff1ba6635f856772b86d475c0ce466dc12","declarations":11,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/cell-seat-log.test.ts","sha256":"d5173601a135cf68339ec65df3c0d07629f698f163237a6213771caf0abaec7d","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/config.test.ts","sha256":"96e13eb55b2e856d6278502ae0123148de9808b4bcf8cda77f0a47e3c8d03487","declarations":15,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/connection-reservation-debt-retention.test.ts","sha256":"41d35eaf400f161b6a329113ecffba339326d2ba02fbf633f2e7f6e66bc08abc","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-accept-cell-row-lock-postgres.test.ts","sha256":"4cc5ea469a9d5261d770b910d5ab65a11b54e375674e4fba10454b8fa3a9ea70","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-accept-cell-row-lock.test.ts","sha256":"3ab794c308aeb1f2c738f0c8439999dd3c79442351bf1802834d485ec4fdf1a1","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-lease-recovery-postgres.test.ts","sha256":"303671b93a590a4bf1b0f0ca11e7889df0bedec49b0afa87419333e3bd3cbecb","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts","sha256":"90d3e5a930b567e88bad1c5b372ce2d46917a209057f5f91252494c3eb2611f5","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-renewal-batch-store.test.ts","sha256":"856bce7b93b3ca0fb9aed7bd59ff0fc4d6909b5b13345e7e897eaae8d40c3797","declarations":11,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-renewal-batch.test.ts","sha256":"0cb0e1bbb0261f62bb2a1fabd329b0f9c0d08947d65e0b02ea8a92a746e3c9f1","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-renewal-postgres.test.ts","sha256":"1c5032198245240fbdfdba935a9214116cd8798c71e85dceed930050c6fe9e9a","declarations":10,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/control-reservation-reconnect-claim.test.ts","sha256":"f617fb4e79f0cef41507b1b1983b08f97ff5a9520872c7928b677e0f42e2ee4d","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts","sha256":"5129a0dbd975ad12bee655675582c4898ced0df8dabf8e73f5130b9dde146131","declarations":8,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/credential-store-cleanup.test.ts","sha256":"8274533789ba4332d233507bd17c2c83156aa30421deb3bc1dd5ccbb398a8306","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/credential-store.test.ts","sha256":"12570ddac3ae51f4ea015c4effd70c95bdd6830ce9084c1f602af0e74775fc3d","declarations":7,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/database-connect-stall-postgres.test.ts","sha256":"f2e196714898b1a51b10b659de90d2c0095284f1a45f155a3795d5bc074c744b","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/database-postgres-timeout.test.ts","sha256":"910caabb96ac8a196c182df07322b589a74645e35463663928926738a5df3a32","declarations":21,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/database-statement-timeout-postgres.test.ts","sha256":"8a767423720af5eea5f35e0bd0fce73a9849c47a105659f7688bdbf22c8bf362","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/database-transient-error.test.ts","sha256":"76729a1363b84aabad8b0dbb17489e17aa8c1f60a77dd50657f55d1894c07ef2","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/database.test.ts","sha256":"e12b26f76368231c088b786be743102a166591da866c311aedec693489d4f41a","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/dead-cell-evacuation-precheck.test.ts","sha256":"fa3acbdf0094e45a46d5482e5809a100744761471b17368520c4231b46f66a89","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/dead-relay-tables-postgres.test.ts","sha256":"956a752584134198451aa2c11f2470bab4d2a360487b909e57b61c4cda876758","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/director-reserve-placement-status.test.ts","sha256":"7c3bab48bcbdfa90e3db6fb4a22537322aaaf7a54e1c12e499225ccd3dd1f770","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/drain-migration-row-lookup.test.ts","sha256":"783947cca8f9db3e0fdec0f5c56cdb8c9c422cf5d3db1a7a2bb592cab14b26fb","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/drain-migration-row-scaling.test.ts","sha256":"2adabae89beee885a85d5a58dedfb9e3d3379b6d0045edd088ec399e4023a76c","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts","sha256":"e45ed3017e70377493a84776e8b3f3e80a14ea468df320c164514d25fc2e0166","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/drain-return-admission.test.ts","sha256":"6d1902ea12f44ea8fb75f532582eb1f9bef02a82679c84c60ca0b676c9b7e2c2","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/floating-promise-census.test.ts","sha256":"a863b2eb430294bd4846bc02759000cda99e3701eed66ba07be52805968e6664","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-close-reason-memory.test.ts","sha256":"92da427416a1f2d55121eacfed26027e18e8bdb44e8f5b297801edb4ffad6e9e","declarations":6,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-control-proof-cleanup.test.ts","sha256":"16ebfdec0a7e542316c27b0d53ff319c614c3dffd09feb086dde54042ace1705","declarations":12,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-control-resume-identity.test.ts","sha256":"ac29bd21d656e17c6722a27b01e8b48be26d02ed0a4195ccf151d1741f2e04ae","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-session-client-accept.test.ts","sha256":"22c7e48886aea21ab072762d4b2b8a2e0e9003709ecb09b63885c692192d9df9","declarations":19,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-session-drain-release-order.test.ts","sha256":"67cf0d3b4ee29e762f771ff34991dc89e41d5efdc8094ddcaf8d714e14515c71","declarations":6,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-session-preauth-latency.test.ts","sha256":"a48b9c7035700f1436b66dd2341d7880f530b3be9a9141cda9cb46101c0fe9a4","declarations":7,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-session-registry.test.ts","sha256":"f285b3724340fe47f09640ab65375fc640f88f14c6f09b08d093865e307a64bf","declarations":75,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-signed-out-rejection.test.ts","sha256":"5bf81f9f83182d458810414dcbc618998e018fabcf142bd0798c0b63c99a644f","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/host-whereabouts-app.test.ts","sha256":"3bf9908dfa2fb9d01d555851b2694520c540f8a5283bea62208e1f6ed5c684da","declarations":8,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts","sha256":"fa3bc53d0a5a2f37df623867d09d3d479c4744783e6ada51accdf4c7e204a2ca","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/idle-regional-rehome-store.test.ts","sha256":"5df06920367ee17690f0f5446dc2240567e8ad4fc3e806a471b8bff59c5c0b86","declarations":14,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/idle-regional-rehome-test-database.ts","sha256":"343bdc997f3beb8f1ec4714f95b9d7d70d4500f613637f89233d23b1ada0adf0","declarations":0,"signals":[],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/idle-regional-rehome-window.test.ts","sha256":"ae3e946a75587a7387c5403abb790e51716f61dfae0b5bf5b1c18c57a1cb673f","declarations":8,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/idle-regional-rehome-worker.test.ts","sha256":"6c4d6339e6a960dbf3523af84a1ba64cbc45c798049a5e0454cb74bbbd08f770","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/migration-recovery-postgres.test.ts","sha256":"8a61b80052eac264d4e92f3b8c181130a2117b0e9648a1050f05e3d7b001ed33","declarations":29,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/placement-load-band.test.ts","sha256":"f8aba58bbb49fb869e8db1f43e224432fb8074e9cc041865fe58b484fb64dbf9","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/post-proof-close-log.test.ts","sha256":"34c4a6788d688d8ff25de1538a435dffe3cea303b65f69c3b2ee3cf43d79ba50","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/postgres-checked-out-client-error.test.ts","sha256":"0b7da794a86f39ffb6c583f70803e3a6a1755ebdfbaa0e4c25c8a79f0b891581","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts","sha256":"8dd628f605cc2c94a75f7612b831aca9bb522ad68bbd136935460ac418f4896c","declarations":7,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/postgres-drain-send-locking.test.ts","sha256":"b0ecdbafdff311bfd70f98ed11626a13c4dbf80a555108e3c59c50fe587ab1c0","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/postgres-idle-client-error.test.ts","sha256":"57d81afc1b9dfbcf275b7f814c9c2dbb634fbf51fc23f48c11ac5883da32eccf","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts","sha256":"e2830bcfa3bae572dd31bc2c4178248ab534ea87b9a72de4b6030993d036e0c8","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/postgres-lock-wait-sample.test.ts","sha256":"b5a1cf90b57c891a5fa5fa849cc79338cf7b21de21596562890946f5dd8e8e37","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} {"path":"cloud/apps/relay/src/postgres-lost-reply-postgres.test.ts","sha256":"8f9d90fa5790b8d0cfa43ffaf2109610608c86ec8c040bbba8a723b630a39943","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} {"path":"cloud/apps/relay/src/postgres-lost-reply.test.ts","sha256":"7592fb52ba3c0d8de0c714ecfb7b3f8484fce8bb29ef9db63adf527d574f6679","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} {"path":"cloud/apps/relay/src/postgres-maintenance-sweep-plans.test.ts","sha256":"380d6df576a31e0fe58619b21ee8b632672a17ea4d3a73d10828b1d1a36bdd3c","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} @@ -206,8 +207,8 @@ {"path":"cloud/apps/relay/src/staging-asia-proof-admission.test.ts","sha256":"2065a6a1645a4140abbf1fe2947618093a8ebe27c06c95f565fab71e8521b688","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} {"path":"cloud/apps/relay/src/stale-if-error-jwks.test.ts","sha256":"e9a5fabb9345413b3f9febe178412268d302f92e541cc7e4e95925f0d29c16b9","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} {"path":"cloud/apps/relay/src/sticky-slot-statements.test.ts","sha256":"0d22fbdf2321ac5e5849557117b11ee6ea3794fc7a64a15dc862ad4224247d5d","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/test-fixtures/delayed-postgres-database.ts","sha256":"30b9024e1574be2caf3cdf3983ff7a7f1caa92b33ad4894bd8a29c8c69401ae4","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"cloud/apps/relay/src/test-fixtures/host-control-proof.ts","sha256":"995e8d5e545fcc70728ea8d987cd8b151176b48df5a1a369ebe0fe556d93c5fa","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} +{"path":"cloud/apps/relay/src/test-fixtures/delayed-postgres-database.ts","sha256":"30b9024e1574be2caf3cdf3983ff7a7f1caa92b33ad4894bd8a29c8c69401ae4","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} +{"path":"cloud/apps/relay/src/test-fixtures/host-control-proof.ts","sha256":"995e8d5e545fcc70728ea8d987cd8b151176b48df5a1a369ebe0fe556d93c5fa","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/cloud-0003.jsonl"} {"path":"cloud/apps/relay/src/test-fixtures/relay-contract-baseline/control-messages.ts","sha256":"8fcae470a5fc72f2fcdde9d2f09cd20289c256356dd490484ac1cfa53839fbe4","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"cloud/apps/relay/src/test-fixtures/relay-contract-baseline/director-messages.ts","sha256":"aba94e108a5cd0f1af8b38875429ad8636d24c43a728273e3df60d9a1a1d1b6d","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"cloud/apps/relay/src/test-fixtures/relay-contract-baseline/relay-regions.ts","sha256":"bc89116f884a2f20a6588f9b91219aa596bc2410d28b499a93a78350def109d5","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} @@ -251,14 +252,14 @@ {"path":"config/scripts/audit-localization-coverage.test.mjs","sha256":"38706e9ce7b3b0b9bf098c37d460975680cfb0c2ad2a9d10d61617bb75d9d2d7","declarations":9,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0001.jsonl"} {"path":"config/scripts/benchmark-artifact-comparison.test.mjs","sha256":"d591b82a362972b7167fbf85d24ea817d1a06ba4cde9afc8bc437b41104c3390","declarations":12,"signals":["named","declarations","auxiliary","ci-unit"],"status":"reviewed","review":"reviews/config-0001.jsonl"} {"path":"config/scripts/benchmark-browser-tunnel-framing.mjs","sha256":"9bf45fe19c5572fe5753f4350649f23f865c80d54ac0aa1d64312eaea01d515a","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/benchmark-ci-preflight-critical-path.mjs","sha256":"e2a75ef9a47cdb7bc50b9e1501ef719db47dd1b41dc84d2133ca6ef844500d0c","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} +{"path":"config/scripts/benchmark-ci-preflight-critical-path.mjs","sha256":"9f4db6d2f9fc1851cccae23699edea4ac39fadf50aea4df5beab20f01e7d327f","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/benchmark-cli-error-imports.mjs","sha256":"7e1b7f0d7001e3c1911956c950043203bff5c15ffa54ad757d69bb3fce6867e4","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/benchmark-cli-response-framing.mjs","sha256":"fc246f194b95c6bd2ac2bb96d7e1657d37c6a48a9f9f0bc844a613ea8a277442","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/benchmark-explorer-dotfile-filter.mjs","sha256":"90c0e20c9588aa474d054ff173bf329396e6e78c358a203304157d33a9d94c8d","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/benchmark-preflight-compat-boundary.mjs","sha256":"3a5979267d49b5ece59cf9a2ebef8f822289e34558aee11a29a4c932c5790310","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/benchmark-preflight-compilers.mjs","sha256":"cfc1ac497bc6de1f20482636d6e3b38aeed62ea35b3c74a143f19fd771465a1f","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/benchmark-preflight-localization-extraction.mjs","sha256":"2455459dce02b6a18cd3d8a696e43d801ab7eea9ebc7d7b3679585994445c586","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/benchmark-preflight-static-analysis.mjs","sha256":"28d233ed314594b15cb0c4a353b6dd6f2faad7768e4cac783338a37c53062c46","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} +{"path":"config/scripts/benchmark-preflight-compat-boundary.mjs","sha256":"1af3f5a2dc650dad72273d8cc84928ff14cb77760c63d0b4375224a73713d89c","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} +{"path":"config/scripts/benchmark-preflight-compilers.mjs","sha256":"36de45a9babf15f3c05fcd6d558402a356b84030cd68a0d901938fe0bc31a551","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} +{"path":"config/scripts/benchmark-preflight-localization-extraction.mjs","sha256":"3a410de5bf29f9d795485815e2d84372cef4edd7a060487c3242f79e76b756b4","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} +{"path":"config/scripts/benchmark-preflight-static-analysis.mjs","sha256":"5bbd8ad16da844610bf9d290e225034bad8fbdab1d08e1005b179fe94e14794a","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/benchmark-sample-summary.mjs","sha256":"feecbd5ec627e7d0ad568f8521c108c1a1cfd478b56f2239d72cd04cb079db1c","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/benchmark-sample-summary.test.mjs","sha256":"eb1bc224b3dc911f0896a855930d6be245ba9e3ca9001815aee35d1e417a3ece","declarations":4,"signals":["named","declarations","auxiliary","ci-unit"],"status":"reviewed","review":"reviews/config-0001.jsonl"} {"path":"config/scripts/benchmark-skill-depth.mjs","sha256":"c592ef0e48b3b5f655dce65dd65356c09694dc21608a83a6156bb64e80438423","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} @@ -267,7 +268,7 @@ {"path":"config/scripts/benchmark-windows-native-preparation.mjs","sha256":"135006a2c2be84f0f29a0aaa006a364f2fa9bf6d0732ce0dc8d77210a49b164b","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/benchmark-windows-security-reuse.mjs","sha256":"4b732c5b9e1fd2d4dd1c5ab0c8b5d9b0fc4e2b59e422b1266ed1234825e973d8","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/branch-compare-head-benchmark.mjs","sha256":"84f32853973da665078ce6eac6b03b99e55dcf6bbf2405dfde44314c41c95cd6","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/build-cli.test.mjs","sha256":"bebfde15a222dcf2944c444010d7176d4d4b363ec8bb225c24af198c4c32a6b8","declarations":7,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0001.jsonl"} +{"path":"config/scripts/build-cli.test.mjs","sha256":"3e609e5b2b405f6906f23f6ba2cde8f4996b28ab434dde2a6c5e36b5e5fbd8fc","declarations":7,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/root-0013.jsonl"} {"path":"config/scripts/build-linux-local.test.mjs","sha256":"2319c12389319a7a2f212c32bb10be5c954d90e47a1ace01aba9729417cdf4af","declarations":6,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0001.jsonl"} {"path":"config/scripts/build-mac-local.test.mjs","sha256":"5cd7b017fdaf184613fc6ca8ff4cf4025e4400e3a43017fd4aaeeac35a01b2ac","declarations":2,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0001.jsonl"} {"path":"config/scripts/build-mac-notarization-overlap.test.mjs","sha256":"a5b22245d1e25f4ae7fb3bc5dae312bb64d4c0ca4ae3ffab2bd48fa578cbfc5e","declarations":9,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0001.jsonl"} @@ -357,56 +358,56 @@ {"path":"config/scripts/compact-packaged-orcad-ripgrep.test.mjs","sha256":"f9f850bf6b4ba9c718fcfabb2d308895cc83a4a994b92fc3124f3f4b03879cc0","declarations":10,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0002.jsonl"} {"path":"config/scripts/compare-benchmark-artifacts.mjs","sha256":"e2fc1c66dedd2479d75b62ac02bd33f975935fffa0dd1bd88c6fb3ea4cc190da","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/computer-use-smoke.mjs","sha256":"e3ccd011183408da12371f8165526911385bdb19a70ab938064bb722d1563069","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/computer-use-smoke.test.mjs","sha256":"1e5e01e9306fec03973fdcc10ffb9217e66e152a32e8c44e80c48be3b800f383","declarations":5,"signals":["named","declarations","auxiliary","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/counterbalanced-benchmark-schedule.mjs","sha256":"bc35b40e954fa7ddec0225ed375bd3b113c2e05b8554bc50734d14f89987294d","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/counterbalanced-benchmark-schedule.test.mjs","sha256":"fabc00232748f05fb3a4c3e715db67c45592b3284d6820db386692d8942ec7c0","declarations":6,"signals":["named","declarations","auxiliary","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/create-draft-release.test.mjs","sha256":"eb1ef315b70a68f733ff5c009d5a61982ef8c52f10568a3f6048b7d16f35fff5","declarations":20,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/daemon-boot-smoke.mjs","sha256":"c4f26b0de5bb604afb806c1483eb57ff44db025330a86f68965bd9c38ac6bee4","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/daemon-endpoint-handover-smoke.mjs","sha256":"73acd45caa94539c099d6629e6139fc93606229a710a3b4436d6a99ca25088b5","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/daemon-protocol-facts.test.mjs","sha256":"6ec6bf7f0e97707e2c4d518c87bf54b4debb042dec704bebf9270e0bd3a6176b","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/daily-build-version.test.mjs","sha256":"ca1f317d15c82fe0646ef1b7d8db57b41e47034f6c59f0e91021a062640bfb88","declarations":13,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dark-build-switches.test.mjs","sha256":"0ea5c08c8e57aab37e096b9d53e14111b35bc5076c6e3999d3815c963bee38ea","declarations":4,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dependency-security-audit.test.mjs","sha256":"9816d97523bfd03bc9fb41d06f97cf71f09d1b0c0b3fcefacb7489488a5d3b8b","declarations":8,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dependency-security-patches.test.mjs","sha256":"a74f2596e2e0a63958680e63f579716b5d04f1720a1e43ae4f1b9a7e70b3dc15","declarations":1,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dependency-security-release.test.mjs","sha256":"85581ab67d1bc9c166927d442da8991850b7206884c668b3aba8a923018a256e","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-channel-base-version.test.mjs","sha256":"e01a7e6eb393c85f47a95eb4926b6c63c558048077fd945210b1a5ad408ad4f8","declarations":11,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-channel-orcad-template-workflow.test.mjs","sha256":"5baf4eb09655502bd184a1b6c28525692c203c39ce2e172e9d89b191cd98ecbb","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-channel-windows-staging.test.mjs","sha256":"c454ebd6c0984167764a82def23f12e496e060e7aa6b2ea1b2de358edf1a82ee","declarations":6,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-cli-terminal-wrapper.test.mjs","sha256":"7120a00319c1223edcb8a423bf59afd627f18542285819e3e66e14713fb5b871","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-electron-bundle-cache.test.ts","sha256":"7da48621f835e5680e719f5c82073dfaf79ef4d02539f28fc4f5ae95a84d8378","declarations":10,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-electron-bundle-identity.test.ts","sha256":"ad7e6d3e4bf5681b527e57b5b86eeafb789538925364cbc4fc06565557d9cacc","declarations":5,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-storage-reclaim.test.mjs","sha256":"aa7d040da76351c4a97a1b5ac113bd22d097c97f6a8bbf6e33a42824123219b8","declarations":5,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/dev-web-client-freshness.test.mjs","sha256":"c16b0c2520f0134e11af7f531e92a7285d6168b018cf2bf79d76ca6454a5fad6","declarations":12,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/e2e-cli-artifact-capability.test.mjs","sha256":"1ff82a46786f48a948978db3351ba367a329789172d8b5721aeb517ad3300510","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-builder-config.test.mjs","sha256":"e614ac6673bca68ec2d5df34e0b59b707c4351c6a6d1662ea0aed4f589a14437","declarations":36,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-builder-mac-channel-config.test.mjs","sha256":"c49efa3b9471da19f11dfdca172bfb1773e122287ac51919fd4baf1784b77e68","declarations":8,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-builder-native-rebuild.test.mjs","sha256":"6faf310bfd7fe32cf998ad30bbc7f7569543daa254d2a037c3997e282a893a36","declarations":5,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-builder-runtime-resources.test.mjs","sha256":"44aea1d7b65fcda14c99c5a3145eabd7855cc041d04de84f4aaeb21ae9550128","declarations":22,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-builder-speech-config.test.mjs","sha256":"eacc9dfe152847ac95d2dde91acdfad4e5a68ca67aad99cfdb23807bcd3b3aeb","declarations":1,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-runtime-floor.test.ts","sha256":"9d502a18df39c3d6b7b7997539e1f1ee739fea65ec0d6db9a7ee4a07bb53f51e","declarations":1,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-vite-development-config.test.ts","sha256":"1b0b10656d3ca646e59a5befc2d0dfd49f9b8552d95da00d3b9105a4a5e75081","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/electron-vite-output-contract.test.ts","sha256":"955d247c5dc78d5f26ed7fc4022952a0c4124cce1072ee8a14583656a543f772","declarations":14,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/ensure-native-runtime-job-ownership.test.mjs","sha256":"62b913a91d8330c0fa398fde2ef329bf04fe6d166a03c063fe4e0c931ce66f36","declarations":24,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/ensure-native-runtime.test.mjs","sha256":"1600ee4adc16cf98be3f19aadac13b361dc4ff6b258531d15e3e2379a9ff97dd","declarations":6,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/ephemeral-vm-runtime-store-cross-version.test.ts","sha256":"8d0254f61d4c228400b19a6faa8bef4f35120ec0cc7e57316a92382c5cf0e3c3","declarations":1,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/file-explorer-deletion-roots-benchmark.mjs","sha256":"d13fad3c55b87d8ea5aec4627fef69d4e3f670bf2d25ec96cc2324a610e86e7e","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/file-explorer-tree-projection-benchmark.mjs","sha256":"fcdf0f947998b6b51bcf95d1428cc68e2946b01794d517568b686d06f0636239","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/foreign-sqlite-reader-worker-smoke.mjs","sha256":"0c90a93be25e25087e16168d60773ec7fa688cb70afe3262c51905b66027bfb7","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/foreign-sqlite-reader-worker-smoke.test.mjs","sha256":"7feeaaf8f11c5c81c50e52b3195b22dd4b10a78b9d887146af51e044b94cd6b8","declarations":3,"signals":["named","declarations","auxiliary","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/generate-bundled-skill-guides.test.mjs","sha256":"926068948c4a8bf40e6fa0923f6ed2ed5170ed1353ecca95999cb9f4d2ce998e","declarations":14,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/generate-monaco-associations.test.mjs","sha256":"882a1f5921c5f06f0ab66924a61f78e6adfdc77205ec10dd91be912dc48cb40e","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/generate-runtime-required-english-catalog.test.mjs","sha256":"ab9263d03316c1670c602dbf72ad5048f3f338734f1d984a5edd37e07bce975e","declarations":6,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/generate-skill-bundle-manifest.test.mjs","sha256":"e0aa0f23215c85b2ddb123dec435c1183fe81eaa8d73c9b669bf3907b4ea29de","declarations":17,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/generate-terminal-perf-html-report.test.mjs","sha256":"062c694f99e8b632f519865b5d158bc9fded02653d9882233450b5e35700bd5d","declarations":8,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/generated-artifact-line-ending-pin.test.mjs","sha256":"3ba2f2659e30d121ba4c99a36aea9529dc40c48aa0c8f8fb45e59a5fc6c99c22","declarations":1,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/git-diff-blob-concurrency-benchmark.mjs","sha256":"0f28ba936da60fae22428b0c5c42a0e2aa4e6d5593cf5a14f9c92a67b4ddb872","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/git-pull-request-diff-base.test.mjs","sha256":"d5ec01fd3bc4522c1a47010f526371d20df987beeca4f5352dade188ff536de1","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/github-opened-issue-repository.test.ts","sha256":"bbd534c3802fae5032e9af9bedd305840cc1de94a17a22c2abca9b464ad2c94a","declarations":8,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/github-pr-assignee-repository.test.ts","sha256":"e6dc517e18e6f46e2d3d00b1c26e363cdf2aa960a26f4ee1ca1541dbd1f283ed","declarations":1,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/hang-watchdog-memory-benchmark.mjs","sha256":"fa5fb59c8059afd053ef09190eb6d5896423d8a95d1a99c344b18f19dc98bfb3","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"config/scripts/hang-watchdog-process-metrics.test.mjs","sha256":"b14017bb024307c1f0c368dc6efbf4056e5ff7f9c06c1779732b0ada9bd31add","declarations":12,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/happy-dom-mutation-observer-retention.test.ts","sha256":"c7abb2f036f9dc2d8665c2fc5c4d1282e29f7af58d4166c1145860cdf777f991","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/happy-dom-offscreen-canvas.test.ts","sha256":"c10adb495d7b9c50bd45effc275c6d1b77c92f0020b2f19734bbde0a8d761900","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"config/scripts/computer-use-smoke.test.mjs","sha256":"4d381c651f21d9fe12a602652f30f0d8a3a46bd48ce698224e1104c030fabd07","declarations":5,"signals":["named","declarations","auxiliary","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/counterbalanced-benchmark-schedule.mjs","sha256":"bc35b40e954fa7ddec0225ed375bd3b113c2e05b8554bc50734d14f89987294d","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/counterbalanced-benchmark-schedule.test.mjs","sha256":"0292512350fad9e1a8ac205a55d975ce4c214f0fb2f4fba8ebbd1f5b98aa9501","declarations":6,"signals":["named","declarations","auxiliary","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/create-draft-release.test.mjs","sha256":"e9e3ad80f6f1ca8e83d51dcf92ec6cf8b11be8ecf3d7c223492813891689d2c4","declarations":19,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/daemon-boot-smoke.mjs","sha256":"c4f26b0de5bb604afb806c1483eb57ff44db025330a86f68965bd9c38ac6bee4","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/daemon-endpoint-handover-smoke.mjs","sha256":"73acd45caa94539c099d6629e6139fc93606229a710a3b4436d6a99ca25088b5","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/daemon-protocol-facts.test.mjs","sha256":"6ec6bf7f0e97707e2c4d518c87bf54b4debb042dec704bebf9270e0bd3a6176b","declarations":7,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/daily-build-version.test.mjs","sha256":"bbc3936df1ad589a0350d6bcd819a8d09429c1b861eb4de7ca851161b0149e9b","declarations":12,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dark-build-switches.test.mjs","sha256":"0ea5c08c8e57aab37e096b9d53e14111b35bc5076c6e3999d3815c963bee38ea","declarations":4,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dependency-security-audit.test.mjs","sha256":"9816d97523bfd03bc9fb41d06f97cf71f09d1b0c0b3fcefacb7489488a5d3b8b","declarations":8,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dependency-security-patches.test.mjs","sha256":"a74f2596e2e0a63958680e63f579716b5d04f1720a1e43ae4f1b9a7e70b3dc15","declarations":1,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dependency-security-release.test.mjs","sha256":"85581ab67d1bc9c166927d442da8991850b7206884c668b3aba8a923018a256e","declarations":3,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-channel-base-version.test.mjs","sha256":"99d6f41ca8637a443b53c9fb80e0326b398fac374a70e58218ce877c11789ad4","declarations":10,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-channel-orcad-template-workflow.test.mjs","sha256":"5baf4eb09655502bd184a1b6c28525692c203c39ce2e172e9d89b191cd98ecbb","declarations":3,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-channel-windows-staging.test.mjs","sha256":"c454ebd6c0984167764a82def23f12e496e060e7aa6b2ea1b2de358edf1a82ee","declarations":6,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-cli-terminal-wrapper.test.mjs","sha256":"7120a00319c1223edcb8a423bf59afd627f18542285819e3e66e14713fb5b871","declarations":3,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-electron-bundle-cache.test.ts","sha256":"7da48621f835e5680e719f5c82073dfaf79ef4d02539f28fc4f5ae95a84d8378","declarations":10,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-electron-bundle-identity.test.ts","sha256":"179dfe568d4d38c9ecae67aa37b2badd726e664673aea7d2b1051cd0caafb349","declarations":3,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-storage-reclaim.test.mjs","sha256":"aa7d040da76351c4a97a1b5ac113bd22d097c97f6a8bbf6e33a42824123219b8","declarations":5,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/dev-web-client-freshness.test.mjs","sha256":"c16b0c2520f0134e11af7f531e92a7285d6168b018cf2bf79d76ca6454a5fad6","declarations":12,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/e2e-cli-artifact-capability.test.mjs","sha256":"1ff82a46786f48a948978db3351ba367a329789172d8b5721aeb517ad3300510","declarations":2,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-builder-config.test.mjs","sha256":"df383425cbfbfde462367b10503c800d70c25343752d27d73e6f714f24061362","declarations":36,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-builder-mac-channel-config.test.mjs","sha256":"c49efa3b9471da19f11dfdca172bfb1773e122287ac51919fd4baf1784b77e68","declarations":8,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-builder-native-rebuild.test.mjs","sha256":"6faf310bfd7fe32cf998ad30bbc7f7569543daa254d2a037c3997e282a893a36","declarations":5,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-builder-runtime-resources.test.mjs","sha256":"44aea1d7b65fcda14c99c5a3145eabd7855cc041d04de84f4aaeb21ae9550128","declarations":22,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-builder-speech-config.test.mjs","sha256":"eacc9dfe152847ac95d2dde91acdfad4e5a68ca67aad99cfdb23807bcd3b3aeb","declarations":1,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-runtime-floor.test.ts","sha256":"9d502a18df39c3d6b7b7997539e1f1ee739fea65ec0d6db9a7ee4a07bb53f51e","declarations":1,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-vite-development-config.test.ts","sha256":"1b0b10656d3ca646e59a5befc2d0dfd49f9b8552d95da00d3b9105a4a5e75081","declarations":7,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/electron-vite-output-contract.test.ts","sha256":"955d247c5dc78d5f26ed7fc4022952a0c4124cce1072ee8a14583656a543f772","declarations":14,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/ensure-native-runtime-job-ownership.test.mjs","sha256":"5d0392135ad2071ef857994b6ad034d9e7732c2e0040ce73f1b06aee34ea2c73","declarations":20,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/ensure-native-runtime.test.mjs","sha256":"1600ee4adc16cf98be3f19aadac13b361dc4ff6b258531d15e3e2379a9ff97dd","declarations":6,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/ephemeral-vm-runtime-store-cross-version.test.ts","sha256":"8d0254f61d4c228400b19a6faa8bef4f35120ec0cc7e57316a92382c5cf0e3c3","declarations":1,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/file-explorer-deletion-roots-benchmark.mjs","sha256":"d13fad3c55b87d8ea5aec4627fef69d4e3f670bf2d25ec96cc2324a610e86e7e","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/file-explorer-tree-projection-benchmark.mjs","sha256":"fcdf0f947998b6b51bcf95d1428cc68e2946b01794d517568b686d06f0636239","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/foreign-sqlite-reader-worker-smoke.mjs","sha256":"0c90a93be25e25087e16168d60773ec7fa688cb70afe3262c51905b66027bfb7","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/foreign-sqlite-reader-worker-smoke.test.mjs","sha256":"7feeaaf8f11c5c81c50e52b3195b22dd4b10a78b9d887146af51e044b94cd6b8","declarations":3,"signals":["named","declarations","auxiliary","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/generate-bundled-skill-guides.test.mjs","sha256":"54d8330848111579d46ebf42b744a8f0ceabd3fd637934457bfe5686f57fd813","declarations":13,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/generate-monaco-associations.test.mjs","sha256":"882a1f5921c5f06f0ab66924a61f78e6adfdc77205ec10dd91be912dc48cb40e","declarations":2,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/generate-runtime-required-english-catalog.test.mjs","sha256":"35c528caa03ab61ab68da89e2f415a76147fe462d3c2efd6bd68cdb8302b853d","declarations":5,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/generate-skill-bundle-manifest.test.mjs","sha256":"e0aa0f23215c85b2ddb123dec435c1183fe81eaa8d73c9b669bf3907b4ea29de","declarations":17,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/generate-terminal-perf-html-report.test.mjs","sha256":"062c694f99e8b632f519865b5d158bc9fded02653d9882233450b5e35700bd5d","declarations":8,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/generated-artifact-line-ending-pin.test.mjs","sha256":"78f9be9e0ba35a5ed31972ffdbb9145e82cae018979b0efb11875a1a7c3c6c01","declarations":1,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/git-diff-blob-concurrency-benchmark.mjs","sha256":"0f28ba936da60fae22428b0c5c42a0e2aa4e6d5593cf5a14f9c92a67b4ddb872","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/git-pull-request-diff-base.test.mjs","sha256":"d5ec01fd3bc4522c1a47010f526371d20df987beeca4f5352dade188ff536de1","declarations":2,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/github-opened-issue-repository.test.ts","sha256":"bbd534c3802fae5032e9af9bedd305840cc1de94a17a22c2abca9b464ad2c94a","declarations":8,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/github-pr-assignee-repository.test.ts","sha256":"e6dc517e18e6f46e2d3d00b1c26e363cdf2aa960a26f4ee1ca1541dbd1f283ed","declarations":1,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/hang-watchdog-memory-benchmark.mjs","sha256":"fa5fb59c8059afd053ef09190eb6d5896423d8a95d1a99c344b18f19dc98bfb3","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/hang-watchdog-process-metrics.test.mjs","sha256":"b14017bb024307c1f0c368dc6efbf4056e5ff7f9c06c1779732b0ada9bd31add","declarations":12,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/happy-dom-mutation-observer-retention.test.ts","sha256":"3301754ecaf60cd13354437e83bf91db633d13f7addb0609b830e9800fca9feb","declarations":2,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} +{"path":"config/scripts/happy-dom-offscreen-canvas.test.ts","sha256":"0e3012dd17a430eb7061ccb1b90b43cad1bbe1aa773ed88c130c413a8b6adc78","declarations":3,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/config-0003.jsonl"} {"path":"config/scripts/headless-detector-compiler-cache.test.mjs","sha256":"cf9f81da5dff2559d4f2ee03af02d93def801e5eb1d61b75f6d42bae9a5b3850","declarations":6,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/headless-serve-shutdown-matrix.test.mjs","sha256":"9d7aff4c6f8b082f2962a76447fe8f7c0cdd3a1deeec69ca5d84d05fafded42e","declarations":6,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/hibernation-output-epoch-leak-benchmark.mjs","sha256":"7305fce78a09525082ab640edde519b86e0bc5a7b2331709c3f5594dd0b36578","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} @@ -617,7 +618,7 @@ {"path":"config/scripts/pr-e2e-linux-packages.test-fixture.mjs","sha256":"7533987df28d1149c10170a44af7aba0c6deff63e70595558f37314b1b74d37d","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/pr-e2e-managed-ssh-harness-route.test.mjs","sha256":"b5cd549a924be88e29708be608e802a4d6a3f435bccb35ccc464873c58884ccc","declarations":1,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/pr-e2e-route-contracts.test.mjs","sha256":"5a117f3469e6379f9d7ff4ddf070f33b1a92260728d32e105ad88fed9e144285","declarations":25,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/pr-preflight-gates.test.mjs","sha256":"d0521a4a304f3655250bbb2f5fa0bcca9e417ca8320dc376076df78a6ca94d50","declarations":14,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"config/scripts/pr-preflight-gates.test.mjs","sha256":"3cc5577383cfb5eab6048fde968376faf9fd35540b09ecf4875ee0fa542bd70a","declarations":14,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/pr-ready-check-gate.test.mjs","sha256":"c7c6e73324a72fd107b7b884297062d95cd62f245287541d6194f4d79060a7b2","declarations":4,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/pr-ready-check-reuse.test.mjs","sha256":"e4bacf85772fc909f1b70afe508e366f46e30d20ddfa72293b578e3159ae2903","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/pr-test-loc-summary.test.mjs","sha256":"35f2c6a19c841552044b380259ceaec8e55490c47a49242f15e6624d71db5934","declarations":14,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -696,7 +697,7 @@ {"path":"config/scripts/run-multi-workspace-typing-bench.mjs","sha256":"0bb1964d1ad43831c5d8af78f06701948c4a5e317eae4e630a48f10bd0e3b711","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/run-terminal-scale-perf-report-gate.test.mjs","sha256":"7fa19ef0fee78827cb5b1f6be0ced6cf278818dc8b7e5650943c0b0de100d9f2","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/run-typecheck-bun-queue.test.mjs","sha256":"cefa167409e0ae7b7a5537d874192352efdc79dd92aaf40266c8c1574a441c35","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"config/scripts/run-typecheck-projects-in-parallel.test.mjs","sha256":"2033aef212126c58ca6b67f5884d43008cfe05fc78cdee207161bbd6064550c3","declarations":19,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"config/scripts/run-typecheck-projects-in-parallel.test.mjs","sha256":"dabc0311813ac4efe0ff774256635a1a649eb3e9671bb5e2e53023a748ad6c80","declarations":22,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/runtime-serve-terminal-smoke.mjs","sha256":"537cc883e6ff20f2080d3466357a0bc41284768d8e1e89f1ef4fce284611bbf3","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/runtime-serve-terminal-smoke.test.mjs","sha256":"a3f248c2f66dcae0c69f664755aa94b5953d4a478e122bbed8d8aac7c6a0a7f9","declarations":3,"signals":["named","declarations","auxiliary","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/scan-release-artifacts-antivirus.test.mjs","sha256":"ea695fe496eaa446769ca994ed1f4fa51da633df0abb8784da7a59c839b16146","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -756,6 +757,7 @@ {"path":"config/scripts/tool-preview-whitespace-benchmark.mjs","sha256":"aef26e0b523cfc3263b10330d3232db1993831717b9ecae05de842df9b93ca79","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/transcript-stream-fragments-benchmark.mjs","sha256":"7ee5eb4e7b6e8f9226480223bea331f7c88fa1f47d7bd6a232a7002adecf0530","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"config/scripts/trim-windows-icon-source.test.mjs","sha256":"76568efaba636bd2e118c6f214f09480a7574e80ce34975f2340786ebd6bacaf","declarations":5,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"config/scripts/tsrs-typecheck-compiler.test.mjs","sha256":"4213f73141c3c39381d373e27ed250988de2cc827d06a137f59044629d647fd4","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/typecheck-project-coverage.test.mjs","sha256":"b4d5bf3f65c0aaba1989fb2e4d44584dcad996d00a41039bd248649fc6950625","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/undeclared-dependency-resolution.test.ts","sha256":"4e02faf5aa6598ab77ca41189f00275932a7c59aafd2e295789c432c236e788b","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"config/scripts/update-node-runtime-pin.test.mjs","sha256":"6459ebba83724e6b5b8345f5631914463fcd1739b6fdcd5494e3f8d04a8c45e2","declarations":13,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -836,16 +838,29 @@ {"path":"config/vitest.agent-status-benchmark.config.ts","sha256":"810c9f87cd645ed7ca7a3b0e8432cfd0603792215e79398f3c848042a1e5ebbe","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"docs/audits/acknowledged-tab-retirement/fixture.test.ts","sha256":"a0d7957f191efe00d59c61fc65e9fe80889a224b74157b2936893a70b2a5dd05","declarations":13,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} {"path":"docs/audits/acknowledged-tab-retirement/reproduce.mjs","sha256":"8af00341f2a8d654edf4c109c87f13b2845837714ee352b75e117cdb2b97da9c","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/auth-filesystem-wait-retention/reproduce.cjs","sha256":"2208bd827a1a0777b9686b18d36ae0af4a34897479fd07187e239a91af54bff2","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/browser-closed-result-retention/scenario.test.mjs","sha256":"93a44e2b2583f397d5c08d29d9de3e1413a9185b893264bf4d468276d8d13ed5","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"docs/audits/browser-destroyed-guest-retention/reproduce.mjs","sha256":"8a9b3316089cdae9409a6375b29a0a9f51742e2f78cd4558b4ab6a9027cf2752","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/browser-registration-reply-retention/reproduce.mjs","sha256":"7dcc15e63d1fdc16866240e0dbf96ab0532ebc7115cda78399d879c11f7d0221","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/cdp-stream-retention/reproduce.mjs","sha256":"f9e5f6c91d19427f959ed3cce60fe1d186b534d933e7dbf38cbc4d218a044379","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/claude-branch-proof-streaming/regressions.mjs","sha256":"ddebeeee655ba5b97b370c3caad9aa086f2b88d3180df0af9b337483958b3088","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/claude-branch-proof-streaming/reproduce.cjs","sha256":"824d6d1048f136b314e181f4e8f8d8cc73aa6a4c5a96abb497639e2f4623e4f1","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/claude-history-window-budget/reproduce.mjs","sha256":"f7ce76164924bc9272af0d199f5698f44030252768f4287ae839f0c6b7d42630","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/claude-task-retention/reproduce.cjs","sha256":"a06b6373a26ff3faee61068aa60bce4dbcd358c2fa5adc5864063a77ee7720e7","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/audits/closed-editor-model-lifetime/lifecycle.test.mjs","sha256":"afc0b7e45e056d1f730ac58f266094471b58187646c91b4436b909544a3a4e29","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} +{"path":"docs/audits/auth-filesystem-wait-retention/reproduce.cjs","sha256":"2208bd827a1a0777b9686b18d36ae0af4a34897479fd07187e239a91af54bff2","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0008.jsonl"} +{"path":"docs/audits/auth-filesystem-wait-retention/settlement-order.cjs","sha256":"7648792560e1840df44da64bfd15ec88a4ce38b9c70f686a965788ae014956c9","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0008.jsonl"} +{"path":"docs/audits/auth-filesystem-wait-retention/sources.cjs","sha256":"115aced3091797efe36bb8814faf88c0822d4168b317473f4867128a59e6dd16","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0008.jsonl"} +{"path":"docs/audits/browser-closed-result-retention/scenario.test.mjs","sha256":"93a44e2b2583f397d5c08d29d9de3e1413a9185b893264bf4d468276d8d13ed5","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/root-0009.jsonl"} +{"path":"docs/audits/browser-closed-result-retention/sources.cjs","sha256":"9d05c182b2052265dae299ae328d1db039168bbd84608a1a6f8ad5f9df75fbbc","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0009.jsonl"} +{"path":"docs/audits/browser-closed-result-retention/vitest.config.mjs","sha256":"b85dd0f517b27434995e63088fab1ff22f0e8815791fc4fa440f2d6ab298ef06","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0009.jsonl"} +{"path":"docs/audits/browser-destroyed-guest-retention/reproduce.mjs","sha256":"8a9b3316089cdae9409a6375b29a0a9f51742e2f78cd4558b4ab6a9027cf2752","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0009.jsonl"} +{"path":"docs/audits/browser-registration-reply-retention/reproduce.mjs","sha256":"7dcc15e63d1fdc16866240e0dbf96ab0532ebc7115cda78399d879c11f7d0221","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0009.jsonl"} +{"path":"docs/audits/cdp-stream-retention/reproduce.mjs","sha256":"f9e5f6c91d19427f959ed3cce60fe1d186b534d933e7dbf38cbc4d218a044379","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0008.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/allocation.cjs","sha256":"93bdb172e14624a5ff7b30974e3e1c56fafc5724e8b4f973275ead9063e099c9","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/duration.cjs","sha256":"5b24ded05da1b21c1e63d2cde33437a016b61780ecca3a30f9430e0dd689f81d","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/growth.cjs","sha256":"6c3e29d47c6e0c689143de932161a2cf9c65662c748ae0ef69f96be264ebb132","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/parity-cases.cjs","sha256":"b30e9219d96fd34015c884d45e12477be23fcc2bccd699f4d48e72aab5b63d0a","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/regressions.mjs","sha256":"ddebeeee655ba5b97b370c3caad9aa086f2b88d3180df0af9b337483958b3088","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/reproduce.cjs","sha256":"824d6d1048f136b314e181f4e8f8d8cc73aa6a4c5a96abb497639e2f4623e4f1","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/sources.cjs","sha256":"36821771ed1e2aeed1587300e891943c77048c8d16f1f810aacee369de74792e","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-branch-proof-streaming/verifier.cjs","sha256":"2ce5e8b25136f9553cfa39185391803623a4d0c91995b0b7d3ad45c4c2ff33d4","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0012.jsonl"} +{"path":"docs/audits/claude-history-window-budget/reproduce.mjs","sha256":"f7ce76164924bc9272af0d199f5698f44030252768f4287ae839f0c6b7d42630","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0011.jsonl"} +{"path":"docs/audits/claude-task-retention/reproduce.cjs","sha256":"a06b6373a26ff3faee61068aa60bce4dbcd358c2fa5adc5864063a77ee7720e7","declarations":0,"signals":["auxiliary"],"status":"reviewed","review":"reviews/root-0008.jsonl"} +{"path":"docs/audits/closed-editor-model-lifetime/lifecycle.test.mjs","sha256":"afc0b7e45e056d1f730ac58f266094471b58187646c91b4436b909544a3a4e29","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/root-0010.jsonl"} +{"path":"docs/audits/closed-editor-model-lifetime/loader-controls.cjs","sha256":"4cdcf0309ff0acce00cff5f5b17ce91236f5eaa27245de65c651dd4c6535a352","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0010.jsonl"} +{"path":"docs/audits/closed-editor-model-lifetime/sources.cjs","sha256":"d5914770eb9db3c75b153b55d7f2f94415d3ab1850bc5b021be1165d104828be","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0010.jsonl"} +{"path":"docs/audits/closed-editor-model-lifetime/vitest.config.mjs","sha256":"bfe98cdc66445e31801a9b64f698f158110dc7a8b1ec8f92ef7f99a5fb296444","declarations":0,"signals":[],"status":"reviewed","review":"reviews/root-0010.jsonl"} {"path":"docs/audits/codex-prompt-claim-retention/reproduce.cjs","sha256":"770da9e5c1b0e2a5f2a1175473fc2bad25ca8e11f4bbdac15be990bb19bc1d5d","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"docs/audits/crashpad-read-limit/reproduce.mjs","sha256":"f933664d7956dc935dc54873f43f1e9628830e4eb30f85759ba7dc2590b3c276","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"docs/audits/daemon-late-exit/reproduce.mjs","sha256":"16e3c55c99d1bb3a727ff7f7a1cfed8009362df93a7609326d8f134c001006b4","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} @@ -884,8 +899,8 @@ {"path":"docs/audits/tui-transcript-acquisition/reproduce.mjs","sha256":"7dc13b0b5a9dce5def8f5a87970ad161ea8034211ae6569ef99f28a932422a34","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"docs/audits/tui-transcript-close/reproduce.mjs","sha256":"5205558afafeb099438db8f89a777ff48afaf8ac4e25f76f2dfc5bfff5770f44","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"docs/audits/working-directory-wait-retention/reproduce.cjs","sha256":"b6b6b4d44b20b57bcb01740e68af241ca14dbc450b868c7c16aa098b1cf69954","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} -{"path":"docs/site/tests/docs-package.test.mjs","sha256":"6bf5305dbf19474175c2e6d9918c257616ba45525f74e25ccb0cdbd0893d1559","declarations":11,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} -{"path":"docs/site/tests/search-excerpt.test.mjs","sha256":"0f0fe3753174cf76f27e443dcb710a67cadf388a6bead9b0c926a974d01abbc5","declarations":7,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} +{"path":"docs/site/tests/docs-package.test.mjs","sha256":"9bd380102a154119728c1c4a1fbbcc877b6fd4a1f22fdc307dcdad3f8ce26c31","declarations":5,"signals":["named","declarations","auxiliary"],"status":"reviewed","review":"reviews/root-0007.jsonl"} +{"path":"docs/site/tests/search-excerpt.test.mjs","sha256":"331358ef182ec591c9502f760c73ac87f7d0554924785ab1b1c30d7308b49984","declarations":7,"signals":["named","declarations","auxiliary"],"status":"reviewed","review":"reviews/root-0007.jsonl"} {"path":"mobile/fastlane/fastfile_testflight_arguments_test.rb","sha256":"10eb0f4413e5f95d246eee4e81d572ac1857f21b55f17939f84fb3281dd21e5f","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/fastlane/ios_release_version_test.rb","sha256":"26392c6b88e72ff0637d9b7d9ba550a2eead2df43ad35215971a081e593367d3","declarations":11,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/modules/orca-gzip-utf8-codec/android/src/test/java/expo/modules/orcagziputf8codec/BoundedGunzipTest.kt","sha256":"472db5df83509402f757c9cc916d1c74e636fd2af16b7a12a3abba0840e2bcf1","declarations":1,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} @@ -993,56 +1008,54 @@ {"path":"mobile/src/components/drag-reorder-positions.test.ts","sha256":"66242dc5e93f01d06aa7410a7a0c950b16482df69053cdca061f9877087ebe31","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0002.jsonl"} {"path":"mobile/src/components/html-preview-inert-links.test.ts","sha256":"b7a61f0ce734ca1c107deb08ebb31c8444ad042aafa7e98e1b85a08751e2a597","declarations":11,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0002.jsonl"} {"path":"mobile/src/components/html-preview-link-affordance.test.tsx","sha256":"fd487e696dd4c0920050a3672df6633eb2d6befde90452f18baa9e92d4932c5e","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0002.jsonl"} -{"path":"mobile/src/components/keyed-bottom-drawer.test.tsx","sha256":"e7821bcd5eb8b63642877ded940a6d559eeeecf81dd4fbac42bfaf6e4fcfcaeb","declarations":10,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/markdown-file-path-detection.test.ts","sha256":"3ce8a2db739360e56499854235063b946a22fbedaee29c96ecdb7b86d26f9fa4","declarations":35,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/markdown-href-routing.test.ts","sha256":"91ddafa7b6de7adff114b0ee62b95a127af87864d90869f66406f3cb4da6eea5","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/markdown-inline-matcher.test.ts","sha256":"a2baa277499d2134b0885cabe21fab57811d4588f5c45042ecc55e21fdc74f59","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-agent-icon-assets.test.ts","sha256":"d9e53f844ce508d4c2954fece2a086b1be78a5d349b702c7210828b664da8c15","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-agent-icon-gradient.test.ts","sha256":"8ebced6d92fcdaebdead9268a61ee3e139c04ddaca7c513767fe9af321c30343","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts","sha256":"bd6bef6d0643fd2b837fd73437bc7a674c66f9a6231e11e28be2764439a208db","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-markdown-android-selection.test.tsx","sha256":"48f6392ee0e227d7522277b7a54bed1fb5c2040c07a3d41b41f647247b38bf37","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-markdown-mermaid-routing.test.ts","sha256":"44179b3ff3c53a7edf75ef1606f3a02a257c2843b2ac4e46f3515e7174278fde","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-markdown-preview-placeholder.test.ts","sha256":"c433ccf994fb3a0265d74fc17c55c57836f30070bc5f7abb3195b175b84c986e","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-markdown-selectable.test.tsx","sha256":"5ddbbe0c391aa7b60d54d69347568a6429abb57247171a95a94751bc630eb85a","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-markdown-table.test.tsx","sha256":"722fe0ea49d167b647d79354fec3a97282fd736acf98f6cd45e82f770b6c52ea","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-markdown-visual-lines.test.ts","sha256":"258d48357045d42db0decb7a3beca0528a55660539cc09c0cc7b3876799f3551","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-pr-sidebar-presentation.test.ts","sha256":"eb638cc6ddbfe0ef151ccb416ab9c0f5a08026429eb70e3b853f6421e071dc26","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-rich-markdown-editor-keyboard-inset.test.ts","sha256":"02bb35a7b63b2d0c143d4f02292fe07ebdb5ceea8727117079467ed236f2f823","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx","sha256":"2801742877053503a3ab9c07b425df5c211e4058da9f35dbee58d84a06bf0289","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mounted-bottom-drawer-keyboard-seam.test.tsx","sha256":"3b5385ad8c656a6e1cef499a0ae3253eb1c14dd4b0322d74e6fe06f3aaab1665","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/mounted-bottom-drawer-page-keyboard.web.test.tsx","sha256":"638a335e30998cde9dcc2b403d036eb02e90b57007cac02aba8a3095cb4e4bf2","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/new-workspace-project-targets.test.ts","sha256":"8c960accd11524c80e2d36d8182a92f1677f5dc6d6d5d9de0bb5c8596ea4a7ae","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/new-workspace-reply-schema.test.ts","sha256":"97d4b35122f8142c73ac08dfafe9dcf80b622253ce21bcdebf4a8c5dbe291dcc","declarations":10,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/new-worktree-agent-selection.test.ts","sha256":"7e95db97b2dc751aec37875e4f70df00875a239f2a695f35599985d106a22c3f","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/new-worktree-form-sheet-visibility.test.ts","sha256":"d698bf17f3f37a95f945a048ec1028e6d8e1177ad709cc6b1066005a1cd937e1","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/PRCommentsSection.test.ts","sha256":"46773635c7e583db4363b5ce8ba9774481ff0bf18837af0bed1d33ddcd22cfac","declarations":1,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/PRConflictingFilesSection.test.ts","sha256":"09e52b11c21fd62383b6f0c425c04b6d2c86a72e525c2a4cf8bb11485d32e334","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/markdown-blocks.test.ts","sha256":"08e1d2f5d821b7c13aba57d3861727067853ec3e2027cae985542a3bb9eb2747","declarations":16,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/markdown-link-scheme.test.ts","sha256":"5e8f9da3f32a24428606a1406426ba0594ba8ebf3016640b73f9f9d02894bf16","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/markdown-table-delimiter-performance.test.ts","sha256":"332be159d58386bb3a6d4c05d404b0afdedea1912e1cbe4919834e3e354ac7f0","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/markdown-tag-stripping-performance.test.ts","sha256":"438616da1fe5005a311cabfd5dc448d8d8b436054660e48c0eee1550ea8d8a98","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/pr-actions-state.test.ts","sha256":"a60dc1c9004f32ece3161127047569781e6112c590ed285ae74070fb869d5ec6","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/pr-check-detail-content.test.ts","sha256":"af5ba9e6afefb2c09b4a7fbbc38f060622bcda0571a105623a4530cd72be99fc","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts","sha256":"5ac883d8c7bd9b7aa1d8c97423c26abd6768e7e8be8719568a2853d2100b8b99","declarations":22,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/pr-comment-card-web-avatar.test.tsx","sha256":"19db4ab57c9519f6181dad6bebae91f6848534dbe100a5e6d3ab4f961a6a2382","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts","sha256":"366ae54e9585479f977d7b1fc2aba1e2143136a8da4b939c31a72bf1b7db7a82","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/pr-state-token.test.ts","sha256":"a119debbec9f9121ff44642aa98c3b9f527a3d55f661c0c4fb827e175acfed3f","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/document-host-root.test.ts","sha256":"4b2663f5a9cab245e99e17853fb20d49e68137519e2abca52755bf163fbc3d5d","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/document-lifecycle.test.ts","sha256":"e4eece192c9316ece62180e2ff934e634c1da370cf833bde97540157cf0902ed","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/editor-content.test.ts","sha256":"cc9efcaea2123e9735f506749fbcbfb0cef7ec26d371b4176652ecc13205b377","declarations":8,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/editor-selection.test.ts","sha256":"626a41798e3678d1de44a606524cbba0cc271d5928f0f5f88b751ed134e37863","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/markdown-code-fence-allocation.test.ts","sha256":"82162ac53bd9dc37bcdd65ff0f5b80f8581c44eff27bb178f939831c3e505fa2","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/markdown-round-trip.test.ts","sha256":"5ece31a73137c79382c57da6843b6c4ad67c7457a6b9582f39f7b18773cf368b","declarations":13,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/page-stylesheet.test.ts","sha256":"1b6b03036da1e70cd2b4fb1cbafd7aa5ecde9d7e8a86ad9b88eb50e6cd2798f9","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts","sha256":"ef1e9a997f2486cdb99923271169ce285244396de45e514fa2bd6f0e01ffe5fb","declarations":10,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts","sha256":"240bf9840390a31326a4121fb7c40a22d2f2e6161dc2336a8c26b7b41f75f2b9","declarations":8,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts","sha256":"e624a37a29aad659609c1e95e3b26c4725a9bf80d28f4c2a635803dd14f9ddc7","declarations":8,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/right-drawer-hardware-back.test.tsx","sha256":"8f829ce491b545f9d717419a53cb92b4c4fa827d1dbf82cae38ba66f172b1917","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/right-drawer-panel-width.test.ts","sha256":"cfa9324af63499c711519499fc53e355059e5e0f298f247307ad8808b272df89","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/terminal-shortcut-settings-custom-keys.test.tsx","sha256":"2e2ddf71703459c8e0d666c6f8944ec5dfa0062d35f2ca09676bcaf7667018f3","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/use-bottom-drawer-follow-up.test.tsx","sha256":"b2e976d229c062cdda5fed47ac4acaa11cb5f526341617af9010f03c4577c52c","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/use-connected-host-picker.test.ts","sha256":"e00bce4e0a7e7249207a2679151a1f8c1e1ac4f79f79fa2463b2a34c8e79685e","declarations":9,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/components/use-html-preview-link-grant.web.test.tsx","sha256":"88507d031d249cfe346fca157afea2f10fd79b7a4fb32bfa53712d94f40180d1","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} +{"path":"mobile/src/components/keyed-bottom-drawer.test.tsx","sha256":"e7821bcd5eb8b63642877ded940a6d559eeeecf81dd4fbac42bfaf6e4fcfcaeb","declarations":10,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/markdown-file-path-detection.test.ts","sha256":"3ce8a2db739360e56499854235063b946a22fbedaee29c96ecdb7b86d26f9fa4","declarations":35,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/markdown-href-routing.test.ts","sha256":"91ddafa7b6de7adff114b0ee62b95a127af87864d90869f66406f3cb4da6eea5","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/markdown-inline-matcher.test.ts","sha256":"a2baa277499d2134b0885cabe21fab57811d4588f5c45042ecc55e21fdc74f59","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts","sha256":"e38247e14c4b2df44a269b621e45a4e225436e3e949b264208f81824286cf239","declarations":7,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-markdown-android-selection.test.tsx","sha256":"48f6392ee0e227d7522277b7a54bed1fb5c2040c07a3d41b41f647247b38bf37","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-markdown-mermaid-routing.test.ts","sha256":"44179b3ff3c53a7edf75ef1606f3a02a257c2843b2ac4e46f3515e7174278fde","declarations":6,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-markdown-preview-placeholder.test.ts","sha256":"5edfbc066a772b09fe02c5aab4010686106eeea39b57bd5e622dc23a5b973c26","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-markdown-selectable.test.tsx","sha256":"5ddbbe0c391aa7b60d54d69347568a6429abb57247171a95a94751bc630eb85a","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-markdown-table.test.tsx","sha256":"722fe0ea49d167b647d79354fec3a97282fd736acf98f6cd45e82f770b6c52ea","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-markdown-visual-lines.test.ts","sha256":"258d48357045d42db0decb7a3beca0528a55660539cc09c0cc7b3876799f3551","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-pr-sidebar-presentation.test.ts","sha256":"eb638cc6ddbfe0ef151ccb416ab9c0f5a08026429eb70e3b853f6421e071dc26","declarations":7,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-rich-markdown-editor-keyboard-inset.test.ts","sha256":"02bb35a7b63b2d0c143d4f02292fe07ebdb5ceea8727117079467ed236f2f823","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx","sha256":"e7ef3bc3067e36d9c59fedc9e071a3f23f4a724b0060581fb477130b80bec367","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mounted-bottom-drawer-keyboard-seam.test.tsx","sha256":"3b5385ad8c656a6e1cef499a0ae3253eb1c14dd4b0322d74e6fe06f3aaab1665","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mounted-bottom-drawer-page-keyboard.web.test.tsx","sha256":"638a335e30998cde9dcc2b403d036eb02e90b57007cac02aba8a3095cb4e4bf2","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/new-workspace-project-targets.test.ts","sha256":"8c960accd11524c80e2d36d8182a92f1677f5dc6d6d5d9de0bb5c8596ea4a7ae","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/new-workspace-reply-schema.test.ts","sha256":"9c9070f1272242d99a43913ff572d8e3be50ca3e07591a0cddc6cb22d4f80e37","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/new-worktree-agent-selection.test.ts","sha256":"7e95db97b2dc751aec37875e4f70df00875a239f2a695f35599985d106a22c3f","declarations":7,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/new-worktree-form-sheet-visibility.test.ts","sha256":"56588ebcb83076954b9f4dcd29da2375849449be73265f098f150e6a3b9c4625","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/PRCommentsSection.test.ts","sha256":"46773635c7e583db4363b5ce8ba9774481ff0bf18837af0bed1d33ddcd22cfac","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/PRConflictingFilesSection.test.ts","sha256":"09e52b11c21fd62383b6f0c425c04b6d2c86a72e525c2a4cf8bb11485d32e334","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/markdown-blocks.test.ts","sha256":"e25284984552932915190fbd6504b3d790aa38e1604b35db8681f9190f70a9d0","declarations":16,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/markdown-link-scheme.test.ts","sha256":"5e8f9da3f32a24428606a1406426ba0594ba8ebf3016640b73f9f9d02894bf16","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/markdown-table-delimiter-performance.test.ts","sha256":"332be159d58386bb3a6d4c05d404b0afdedea1912e1cbe4919834e3e354ac7f0","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/markdown-tag-stripping-performance.test.ts","sha256":"438616da1fe5005a311cabfd5dc448d8d8b436054660e48c0eee1550ea8d8a98","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/pr-actions-state.test.ts","sha256":"a60dc1c9004f32ece3161127047569781e6112c590ed285ae74070fb869d5ec6","declarations":6,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/pr-check-detail-content.test.ts","sha256":"af5ba9e6afefb2c09b4a7fbbc38f060622bcda0571a105623a4530cd72be99fc","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts","sha256":"65a7a741da1670ee5348bbe2a5ffc94c5d12bd4ded04b2bb43cb6a102583e784","declarations":17,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/pr-comment-card-web-avatar.test.tsx","sha256":"19db4ab57c9519f6181dad6bebae91f6848534dbe100a5e6d3ab4f961a6a2382","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts","sha256":"97c5b66bf81d75e3c9798546d64e07bd1e76f1a732981630dd5000ab06af6e63","declarations":6,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/pr-state-token.test.ts","sha256":"61f121841b9c5fff7bae46bc381717c7fa0d176b1ccb03f3b008ab945f96991c","declarations":1,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/document-host-root.test.ts","sha256":"4b2663f5a9cab245e99e17853fb20d49e68137519e2abca52755bf163fbc3d5d","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/document-lifecycle.test.ts","sha256":"38c5d8767420a3e2f721cce540e8457fa5d292c5c24c2e034e2558f29e65140c","declarations":6,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/editor-content.test.ts","sha256":"b743d2d3daef65c0f98fc9de6c2f911b45a84a66a1f50184a2bcc88c4f30b4fd","declarations":8,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/editor-selection.test.ts","sha256":"626a41798e3678d1de44a606524cbba0cc271d5928f0f5f88b751ed134e37863","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/markdown-code-fence-allocation.test.ts","sha256":"82162ac53bd9dc37bcdd65ff0f5b80f8581c44eff27bb178f939831c3e505fa2","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/markdown-round-trip.test.ts","sha256":"ea5a8e62fe9e72fd3a01ed4fcf5ca4c86d4df39911eed0d796e4154b19b1edf6","declarations":13,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/page-stylesheet.test.ts","sha256":"e85b3cb743410d4bc211f6c62aac42634eec67a87a1983ae93c3e66a3db5d58c","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts","sha256":"b2b3227a92b35c80f08ea280a76253bf8062f892d7f9600db018436ac0091e17","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts","sha256":"6147e257d9447b4eb25ce2b01154a37e5883f13a257ed3c081a97acddb370c79","declarations":6,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts","sha256":"4580951669ab65109e06f834eb7939620d4187bdd408f544b4ce1b92fdb22701","declarations":8,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/right-drawer-hardware-back.test.tsx","sha256":"2abc189ece66a52aef573dbc96b200f79964387e71c7b3c6602b829920fe8b5d","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/right-drawer-panel-width.test.ts","sha256":"cfa9324af63499c711519499fc53e355059e5e0f298f247307ad8808b272df89","declarations":5,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/terminal-shortcut-settings-custom-keys.test.tsx","sha256":"2e2ddf71703459c8e0d666c6f8944ec5dfa0062d35f2ca09676bcaf7667018f3","declarations":2,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/use-bottom-drawer-follow-up.test.tsx","sha256":"b2e976d229c062cdda5fed47ac4acaa11cb5f526341617af9010f03c4577c52c","declarations":3,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/use-connected-host-picker.test.ts","sha256":"e00bce4e0a7e7249207a2679151a1f8c1e1ac4f79f79fa2463b2a34c8e79685e","declarations":9,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/use-html-preview-link-grant.web.test.tsx","sha256":"305ff1a9e20308a4fab4a01e3c82123403ef7a4b15fc6755b9af76cfcd5df318","declarations":4,"signals":["named","declarations"],"status":"reviewed","review":"reviews/mobile-0003.jsonl"} {"path":"mobile/src/components/use-new-workspace-execution-target.test.tsx","sha256":"96b5cd07721bea8ba9302313817f1716373510c54d5196ca2fdcc382b55cec93","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/components/use-new-workspace-runtime-context.test.ts","sha256":"be40d3378a0f143f8293ad8bb3a41d908003330c9423336bec2b8c5e3e30cca4","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/components/use-new-workspace-setup-script.test.ts","sha256":"40c323f4ab4cebf013905ead8d5293afc5dad57c408263292ed9bc4e47c54ca8","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} @@ -1406,7 +1419,7 @@ {"path":"mobile/src/session/mobile-native-chat-diff.test.ts","sha256":"8dbeb008e994e4b008aeba5b3b2171281112a3473a6a209771e984f16f3d3c13","declarations":7,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/mobile-native-chat-draft-reconcile.test.ts","sha256":"0965ca42be1dcbed154dd5be9d6b23c29d60e65fe5a85730331eb68edb7c618e","declarations":11,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/mobile-native-chat-draft-store.test.ts","sha256":"0149955f594b541db1a8186ccf43c07929923d93cf5e6b9582668f4daa4ce323","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/session/mobile-native-chat-eligibility.test.ts","sha256":"309e80fa5a3900b6e9848b39df2faa4cebfcd3b61ac417625ca9a4009fc2e245","declarations":17,"signals":["named","declarations"],"status":"unreviewed"} +{"path":"mobile/src/session/mobile-native-chat-eligibility.test.ts","sha256":"789269957289203b364bd3d5b323065f49706deca1c722d281e36e19e011fcf3","declarations":22,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/mobile-native-chat-file-attachment.test.ts","sha256":"633103433f42a834c142891e90b3bcbd0c0d347f174e644ee9a07ab716d47be5","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/mobile-native-chat-host-journal-frames.test-fixture.ts","sha256":"b09c9f41ba29e40ef6856b8f37565f76c9eba1333f4bed1bb370476c4f6724d5","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"mobile/src/session/mobile-native-chat-image-attachment.test.ts","sha256":"50a46ee739bd29b8d7a5777cf144e90e3ee888289fc9790b396ac2801b7df2a2","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} @@ -1568,7 +1581,7 @@ {"path":"mobile/src/session/use-mobile-send-completion-generation.test.ts","sha256":"1bef91e220695d5023130049c444365323dd3d4202fc91533a7502a0e783b632","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/use-mobile-session-close-actions.test.tsx","sha256":"5e4ab6ac4747ff17011c095c20fd6d8b01e16fc86835238a0d62fefa949c935f","declarations":2,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/use-mobile-session-document-readers.test.ts","sha256":"a4340a9b9bdfc42df3047beabea72669f987733aa13f1756d6eec00d40331767","declarations":15,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"mobile/src/session/use-mobile-session-image-attachments.test.tsx","sha256":"456c35a6b4c6d74bd6c34114c5449b1487ed110a273d0fcf1c28f84050ba1ac0","declarations":3,"signals":["named","declarations"],"status":"unreviewed"} +{"path":"mobile/src/session/use-mobile-session-image-attachments.test.tsx","sha256":"bb5d939b223c5b34a3cf4af24f89b6e3a99abfb33476bbd0e8fd4fc9f986df24","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/use-mobile-session-keyboard-state.test.tsx","sha256":"21a7a8e830b4f9c6f6c2fbf7f32552892b8bb4b2acc13a6639473a90f8e35534","declarations":4,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/use-mobile-session-tab-application-launch.test.ts","sha256":"bc456c5b84c5631e9b9ad415bd12cb0cf3d7752cb8f4db02da36f2b709254fed","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} {"path":"mobile/src/session/use-mobile-session-tab-switching.test.ts","sha256":"805f51ed2b097a9a54f8c147d999fe5e5258540db1f6fc1ecfe1dc30bd67c2b3","declarations":5,"signals":["named","declarations"],"status":"unreviewed"} @@ -3267,7 +3280,7 @@ {"path":"src/main/claude/claude-fold-steer-receipt.test.ts","sha256":"bc1e6f1be1d311cbdda567d0ae5de1bd0a15ff759c62780852d0687656d4b281","declarations":15,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/main/claude/claude-folder-trust-file-wsl-guest.test.ts","sha256":"0d874f043e5ed11679cccd18a6e7b14738db276666517515d4c0cd123350a3e1","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/main/claude/claude-folder-trust-file.test.ts","sha256":"cd8818c337efea76ce12c8793c27835dc652affd7fb2ed56401965a5e5cf1d6e","declarations":23,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"src/main/claude/claude-history-window-source-budget.test.ts","sha256":"be03c827e7cfba7dc2bf73737ec333b58fedfa977c0ddf80884af11cce554539","declarations":9,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/main/claude/claude-history-window-source-budget.test.ts","sha256":"9b0cce04e523d73270911fdbb1a2446c5208d0f1d218352432d77d876b768f5c","declarations":9,"signals":["named","declarations","ci-unit"],"status":"reviewed","review":"reviews/root-0011.jsonl"} {"path":"src/main/claude/claude-hook-event-install.test.ts","sha256":"5e99ab3b15fbfa6eeb4297076c89dd2cae94e4c882591c4629a4a4248d416c82","declarations":11,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/main/claude/claude-hook-event-versions.test.ts","sha256":"0acae89aedeb754e10e16023e83a3dd2ff190da298aef8e661649c884dcd26bb","declarations":6,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/main/claude/claude-informational-row.test.ts","sha256":"12014238c626e618d29e8a426bda4731d7093f931f6e4056ccf98ee93bb3cb5d","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -11749,7 +11762,6 @@ {"path":"src/renderer/src/components/task-page-localized-options.test.ts","sha256":"7689a8b3d1e92b05d286fc911e6f8be4433402267570356fe07a417549f9120d","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-page-mutation-page-allocation.test.ts","sha256":"efddd3e60d4cfb5e548da9fe5f9e5feb0e06020d0784cbccd8b948b9494d887f","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-page-new-issue-draft.test.ts","sha256":"f2ffe87feda0072a6ddb00f48208f3ae432acba8a451128a977337ff960e36b7","declarations":15,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"src/renderer/src/components/task-page-pagination-page-numbers.test.ts","sha256":"ef5991ee15aaa93b3bb0498c4989509afe282fbd072ca1c8ba3de52fe7b2cff1","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-page-pr-check-summary.test.ts","sha256":"74001de9ebe4c7689c1325d91feb750aaf9a8a00793f7d8bbdc42614bb26aed2","declarations":5,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-page-repo-source-context.test.ts","sha256":"4aeef219f9b74b2628e5573cb237c9c7195a6a00885f9170d44345c11747ed6d","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-page-repo-source-divergence.test.ts","sha256":"333020d9b97c3e0bd620a6ea645f21afa306e0eed4f91b2d34858fa3862c594c","declarations":6,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -11765,6 +11777,7 @@ {"path":"src/renderer/src/components/task-page/linear/task-page-linear-issue-empty-state.test.ts","sha256":"6a9ffaec987043a216bf36ca9c7db0f8ca311355833c58ac4f2edae0152b6081","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-page/linear/task-page-linear-issue-request.test.ts","sha256":"bb8770a06644992b0d311d6fef7eab89f1ebf88cd959ed92cc11ad1ba314d9ef","declarations":8,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-page/linear/task-page-linear-team-selection.test.ts","sha256":"3550496ebbc1e298fe76428ef8532b8fdcde0b9058523a02fa30fec4947a82e7","declarations":9,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/components/task-page/task-page-pagination-page-numbers.test.ts","sha256":"ef5991ee15aaa93b3bb0498c4989509afe282fbd072ca1c8ba3de52fe7b2cff1","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-source-context-summary.test.ts","sha256":"77b94fb8df85ffe40176b44fe2295a3e633459f82e4c9ababb23323ea8411c0b","declarations":13,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/task-source-provider-availability.test.ts","sha256":"e79d953eaa54648d353e3f9d8e0fc6cc783cc2565785b8c82364ad2e0f1d2614","declarations":8,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-agent-tab-shortcut.test.ts","sha256":"0af4d15017d38e643c0a05b4f7be3194d19c47483740593ee3d7a41e87e3ae44","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -11910,7 +11923,7 @@ {"path":"src/renderer/src/components/terminal-pane/pty-connection-hibernation-wake.spec.ts","sha256":"b5bbaee3ab45e0a1c4aad90aff30d4976d73c51e18cf4b225ec566880a12de17","declarations":14,"signals":["named","declarations"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/pty-connection-hidden-atlas-recovery.spec.ts","sha256":"59f820c0103e41a14ef38b64861083012abc5fdb2bb820ca5273e90c126deffd","declarations":16,"signals":["named","declarations"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/pty-connection-hidden-backlog-reconciliation.spec.ts","sha256":"824622ccd39d7647891e155c8ac48c2459f40a4e17024b484e9b667f0da3b490","declarations":11,"signals":["named","declarations"],"status":"unreviewed"} -{"path":"src/renderer/src/components/terminal-pane/pty-connection-hidden-backlog-snapshot.test.ts","sha256":"b0e537d8ee1ead1d4bddfee6307b76e914521093a0c25c2faa0175c004b11deb","declarations":11,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/components/terminal-pane/pty-connection-hidden-backlog-snapshot.test.ts","sha256":"9ba8ac4ca3d1a824ffa7e4a65fed21fd56d6d50bdb801c11cc2c5ea06786d942","declarations":11,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/pty-connection-hidden-codex-queries.spec.ts","sha256":"e46c5db8e0560118d2525bbe8ed284f7c519f670050b40740b78f38598714887","declarations":14,"signals":["named","declarations"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/pty-connection-hidden-delivery-gate.spec.ts","sha256":"5d3c647877d0358ec112aa2fdd18d33a1784abaafee3f2ae3c22e4b41483d77c","declarations":17,"signals":["named","declarations"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/pty-connection-hidden-output-restore.spec.ts","sha256":"2c9577e50860e15fa460199ffc91516d32c39e57f3344bfe3e316f4e3b986f13","declarations":6,"signals":["named","declarations"],"status":"unreviewed"} @@ -12355,7 +12368,7 @@ {"path":"src/renderer/src/components/terminal-pane/terminal-url-link-hit-testing.test.ts","sha256":"5fedafd2ed8a39b3e00ab16fadde2644b1d44e83a7f40c2af9c35f64cbd4aa40","declarations":4,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/terminal-user-input-signal.test.ts","sha256":"c325425bb36a6482d9d2840d872d9e82d3543bae8055557e37fab9a65b25f125","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/terminal-view-attributes-publisher.test.ts","sha256":"7f6e318b0e19cffe385a2fbd5c4a5acd26f092748639dea55036854e7d0eb506","declarations":11,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"src/renderer/src/components/terminal-pane/terminal-visibility-resume.test.ts","sha256":"e9e795f52d02a658f4147b6ca1b52903c0394c43ac6d1032d3a16664391e4601","declarations":23,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/components/terminal-pane/terminal-visibility-resume.test.ts","sha256":"a7b87edaa34f5fbd0dbe7bab5b0675098b195ce3fc27655f31d6b999a6876fc7","declarations":23,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/terminal-webgl-atlas-recovery.test.ts","sha256":"648ed0ba7649fb34b73e31f591bb720dfcfd23404dbfe673c9d828f6e052fda3","declarations":5,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/terminal-webgl-diagnostics-breadcrumbs.test.ts","sha256":"269d49df9d5760d7f10cea3ba28e632ac59117a1fd0c8d3c771aeb2a258fb470","declarations":4,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/components/terminal-pane/terminal-windows-shift-enter.test.ts","sha256":"1deb46ab55b4d3f5cfd56685e12a6d1d5e6f90c04ce18bcefb2e1a1c98663706","declarations":19,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -13083,7 +13096,7 @@ {"path":"src/renderer/src/lib/pane-manager/pane-layout-change-notify.test.ts","sha256":"3ef293188a1951f1604501da2eb2529172a6f82db9e504197f7d0770428ece9b","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-layout-geometry-apply.test.ts","sha256":"4a9c1793c868b7f3e62d271b8a5fd21f951ff761cb3da992825340fadd22f3dc","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-lifecycle.test.ts","sha256":"fb71d9df5701cb54bad5c308f92b37e6ad7aacd7513ecf9756a28b9a2f01a2b1","declarations":34,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"src/renderer/src/lib/pane-manager/pane-manager-registry.test.ts","sha256":"7a256e23e77ee76ad7692b5d9f39290f1e96aca7814a8b6a179d836c204baddd","declarations":14,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/lib/pane-manager/pane-manager-registry.test.ts","sha256":"bf137119e8e517a44b5334e5e49c25fdd635367f22ccb30ef2cb904d2e44a0d4","declarations":14,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-manager-spawn-placement.test.ts","sha256":"ca5449f6bafc3ccca89dc01a7feb13f0075b9049377073d461ce1a7c4828cf31","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-metric-options-deferral.test.ts","sha256":"b145cc410e93dd496e999ce6709a016d93bccf86150364339f810009fa541799","declarations":17,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-overlay-focus.test.ts","sha256":"8fa6814234c5eb9323b3aa85af4c808e6d1874cf623c3cd01ee82f292957510c","declarations":11,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -13112,10 +13125,11 @@ {"path":"src/renderer/src/lib/pane-manager/pane-tree-match-moves.test.ts","sha256":"8b124d334f38016d9a6311e64b9b5b9a4d5188a263440451a8d0081ef2c11ed0","declarations":4,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-tree-ops.test.ts","sha256":"2e28b990cdc65540fdb81533a0b626839acd50d30bcee7ad4b1bc9e5edeae72e","declarations":27,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-tree-reparent-frame.test.ts","sha256":"3437d30481fde5717ff0897b42d8dc0b0eef5ac426c5da62be0bea4ae4737833","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"src/renderer/src/lib/pane-manager/pane-viewport-present-lifetime.test.ts","sha256":"df546d3fd38823a84a59b6f8005d045c9b62b5500345072bc816f25301ff4fe9","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/lib/pane-manager/pane-viewport-present-lifetime.test.ts","sha256":"d871a557e91aedff237ed86c7b2475a5aef837d57939fb3dc566bf8de6e809a9","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/lib/pane-manager/pane-viewport-present-synchronized-output.test.ts","sha256":"1107a808fdb49e4732dd19f4a9ca37feaf8eb26e3fc8692e39321a4e2d6b6fe4","declarations":2,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-webgl-context-recovery.test.ts","sha256":"d1b382f2756a06878f032241d5856db5798a992551c9bdd330409f2b0cde5512","declarations":10,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/pane-webgl-refresh-lifecycle.test.ts","sha256":"c1b987034ed9b15c150885db4c9618ce770f4087dc6f86727e079ee78b9bfbd8","declarations":5,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"src/renderer/src/lib/pane-manager/pane-webgl-renderer.test.ts","sha256":"fd138d5ebbdbe99c3d8c6d0af0ae25f14d8c6df91b6b43b34000650599b38212","declarations":24,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/lib/pane-manager/pane-webgl-renderer.test.ts","sha256":"579bc79e5cbc78c37c84a071f03cbc90edd2e93903eec4b1a804a4f097f7e13c","declarations":24,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-arabic-shaping-joiner.test.ts","sha256":"5b01b22d1fdfc5a06f48b6bbec20a9680502319afbc748a54c97d6f20e0c9189","declarations":34,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-canvas-dpr-repair.test.ts","sha256":"8c10017c88c55d99add31525e227c10237d1d91af20a9a9a3fadca7ff456c0dc","declarations":10,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-complex-script.test.ts","sha256":"b4ec16f12239100f5b07202b38b91a15163ae8ead4d30b9d78b573186abd2f08","declarations":33,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -13142,7 +13156,7 @@ {"path":"src/renderer/src/lib/pane-manager/terminal-scroll-intent.test.ts","sha256":"c4d888f46606e0fedc32de6b5c0c598193ee559094571b73311c2fd3224c4a8a","declarations":37,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-stable-cell-fit-addon.test.ts","sha256":"d1ad6b6694d986dceb8f4128e11c9f8eb4ca14f07536681b434373f931d3f3df","declarations":3,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-structural-replay-coordinator.test.ts","sha256":"a0fbf9dfa4b5d73e2cd53301db8119e9087c2d4e0ae411ed3f5229454e6eaf33","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} -{"path":"src/renderer/src/lib/pane-manager/terminal-structural-replay-presentation.test.ts","sha256":"a54cb1fc8263c78ed81dee99e425c9adf67640a9a2b54a4434e25cb87fd17752","declarations":20,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} +{"path":"src/renderer/src/lib/pane-manager/terminal-structural-replay-presentation.test.ts","sha256":"db16912bc21700ecd5929bf2e749acdee494eb7ef244fb01769e0e7f3b97dcf4","declarations":21,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-webgl-auto-policy.test.ts","sha256":"df9700b967168dac4333b7895445a0e3071f2c042dd1eeb7d8f349aeebddddb3","declarations":7,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-webgl-hidden-retention.test.ts","sha256":"b424af4aa10b4c4f399462e16a46fd55d6422e3eb3524262b8dfd1b91c1d72eb","declarations":12,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} {"path":"src/renderer/src/lib/pane-manager/terminal-windows-ctrl-alt-chord-classification.test.ts","sha256":"11a884ada373dfca36b4ff0e49e79804f05305a120985c05fb37dd4af37104ed","declarations":8,"signals":["named","declarations","ci-unit"],"status":"unreviewed"} @@ -16667,7 +16681,7 @@ {"path":"tests/e2e/terminal-replay-presentation.spec.ts","sha256":"f02d3e612fdd2f75c605d66619d6edd765aaad7a3de36145de2c757e1f86990f","declarations":1,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} {"path":"tests/e2e/terminal-reset-input-modes.spec.ts","sha256":"d9fc41975a9f3e7431573379ae6e2056541bb9339ccd30814b1853469fc30bf7","declarations":1,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} {"path":"tests/e2e/terminal-restart-persistence.spec.ts","sha256":"1eccd8be16862048bde7e1f9cfa02df3591cacc07ae0fd1ecd3014b548fbbd23","declarations":6,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} -{"path":"tests/e2e/terminal-reveal-paused-render-repro.spec.ts","sha256":"a99be3886b4f8f981f7f25792a12df82033df972ab9b1f4514cdd6772e2863bc","declarations":4,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} +{"path":"tests/e2e/terminal-reveal-paused-render-repro.spec.ts","sha256":"152de244eca4463f37e77dcba6277f7f755eaf896fcae18b2b143a61056254da","declarations":4,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} {"path":"tests/e2e/terminal-reveal-stale-pty-resize-repro.spec.ts","sha256":"adb87ef6a0e11a0ef617d85feb6967e99acc82e189213e12f977d389a13bd76f","declarations":3,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} {"path":"tests/e2e/terminal-screenshot-diff.ts","sha256":"830dae4e534caf3cdeb3a627ebe79821006f6d9a1da1a5fd7894659337c4d416","declarations":0,"signals":["auxiliary"],"status":"unreviewed"} {"path":"tests/e2e/terminal-scroll-intent-follow.spec.ts","sha256":"c0d7a20c26679827c86e2415fca06eb3825763180981c5e820535f8770ac3ae2","declarations":5,"signals":["named","declarations","auxiliary"],"status":"unreviewed"} @@ -16888,6 +16902,8 @@ {"path":"tests/tools/windows-pty-native-capability-smoke/run.test.mjs","sha256":"26789f8bcbbbcf9f049d5ec5979dd5d038a345cdac063dbac3efa04583cfece0","declarations":2,"signals":["named","declarations","auxiliary","ci-unit"],"status":"unreviewed"} {"path":"mobile/src/components/codex-reset-credit-reply-schema.test.ts","sha256":"c678af60248984e43ba07037b775583d1413bdad43616d3b684754af9b17c0aa","status":"removed","review":"reviews/mobile-0002.jsonl"} {"path":"mobile/src/components/inline-text-selection.test.ts","sha256":"c69c59b5a0a30f8dfc868e3291177cfdbd38e8eef137b44f36fc39f717387352","status":"removed","review":"reviews/mobile-0002.jsonl"} +{"path":"mobile/src/components/mobile-agent-icon-assets.test.ts","sha256":"d9e53f844ce508d4c2954fece2a086b1be78a5d349b702c7210828b664da8c15","status":"removed","review":"reviews/mobile-0003.jsonl"} +{"path":"mobile/src/components/mobile-agent-icon-gradient.test.ts","sha256":"8ebced6d92fcdaebdead9268a61ee3e139c04ddaca7c513767fe9af321c30343","status":"removed","review":"reviews/mobile-0003.jsonl"} {"path":"src/preload/preload-file-drop-absence.test.ts","sha256":"02e6e092193b66f4e7b7fe2431dac658ef262685c61c9c8fd117c14cb6e6fdd8","status":"removed","review":"reviews/root-0002.jsonl"} {"path":"native/computer-use-macos/Tests/OrcaComputerUseMacOSTests/AgentEntrypointSourceSafetyTests.swift","sha256":"9a80bb0e559f62ef20db9786ae59a774b69c95114548865a7a577c61f056750b","status":"removed","review":"reviews/root-0004.jsonl"} {"path":"native/computer-use-macos/Tests/OrcaComputerUseMacOSTests/ScreenCapturePermissionPreflightSafetyTests.swift","sha256":"5f30e4af3f0ed2e760326309002260aa05fc7eec2dd3895bd993ee3718da861d","status":"removed","review":"reviews/root-0004.jsonl"} diff --git a/docs/audits/test-value/progress.json b/docs/audits/test-value/progress.json index a21abc9eedc..f39f6064274 100644 --- a/docs/audits/test-value/progress.json +++ b/docs/audits/test-value/progress.json @@ -1,45 +1,45 @@ { - "source_commit": "80d4fe99e344f49727eb12d32f2aa20b64e3701d", - "scanned_source_files": 37078, + "source_commit": "533df41f73db3827e0d2d33a82df53b0cdfe47f8", + "scanned_source_files": 37080, "counts": { - "files": 16888, - "declarations": 119046, - "reviewed": 310, + "files": 16902, + "declarations": 119009, + "reviewed": 488, "stale": 0, - "unreviewed": 16578, - "removed": 5 + "unreviewed": 16414, + "removed": 7 }, - "reviewed_original_declarations": 2202, + "reviewed_original_declarations": 3390, "areas": { ".github": { "files": 2, - "reviewed": 1, + "reviewed": 2, "stale": 0, - "unreviewed": 1 + "unreviewed": 0 }, "cloud": { - "files": 227, - "reviewed": 85, + "files": 228, + "reviewed": 138, "stale": 0, - "unreviewed": 142 + "unreviewed": 90 }, "config": { - "files": 607, - "reviewed": 85, + "files": 608, + "reviewed": 135, "stale": 0, - "unreviewed": 522 + "unreviewed": 473 }, "docs": { - "files": 52, - "reviewed": 0, + "files": 65, + "reviewed": 25, "stale": 0, - "unreviewed": 52 + "unreviewed": 40 }, "mobile": { - "files": 1269, - "reviewed": 83, + "files": 1267, + "reviewed": 131, "stale": 0, - "unreviewed": 1186 + "unreviewed": 1136 }, "native": { "files": 17, @@ -55,9 +55,9 @@ }, "src/main": { "files": 6617, - "reviewed": 0, + "reviewed": 1, "stale": 0, - "unreviewed": 6617 + "unreviewed": 6616 }, "src/packages": { "files": 16, @@ -72,10 +72,10 @@ "unreviewed": 0 }, "src/renderer": { - "files": 5403, + "files": 5404, "reviewed": 0, "stale": 0, - "unreviewed": 5403 + "unreviewed": 5404 }, "src/shared": { "files": 1300, diff --git a/docs/audits/test-value/reviews/batch-0003-validation.json b/docs/audits/test-value/reviews/batch-0003-validation.json new file mode 100644 index 00000000000..7f77f0c02f0 --- /dev/null +++ b/docs/audits/test-value/reviews/batch-0003-validation.json @@ -0,0 +1,43 @@ +{ + "batch": "batch-0003", + "base_commit": "92dfb4fda69e746e96786ea7af417813ac441394", + "implementation_commit": "533df41f73db3827e0d2d33a82df53b0cdfe47f8", + "new_original_files_reviewed": 180, + "new_case_records": 1188, + "re_reviewed_upstream_files": 1, + "changed_test_files": 70, + "net_test_lines": -318, + "production_changes": false, + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 pnpm run check:code-quality:changed -- origin/main", + "result": "Passed after rebase.", + "log": "/tmp/orca-audit-3-quality-rebased.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node config/scripts/check-react-doctor-changed.mjs origin/main", + "result": "Passed after rebase.", + "log": "/tmp/orca-audit-3-react-doctor-rebased.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node --test .github/actions/cloud-sql-rollout-lease/action-contract.test.mjs .github/actions/cloud-sql-rollout-lease/storage-lease.test.mjs docs/site/tests/docs-package.test.mjs docs/site/tests/search-excerpt.test.mjs", + "result": "28 passed, zero failures/skips, after rebase.", + "log": "/tmp/orca-root-0007-tests-rebased.log" + } + ], + "tracker": { + "unique_original_files": 495, + "present_reviewed": 488, + "removed": 7, + "stale": 0, + "unreviewed": 16414, + "case_records": 3390, + "original_rows_hash_verified": 496, + "errors": [] + }, + "notes": [ + "Each original content hash and latest retained content hash independently verified. Case-level coverage checked by refresh.mjs against original AST declarations.", + "Rebase onto merged predecessor imported all completed earlier records. One upstream build-cli suite changed, reread and all seven tests passed; new root-0013 record supersedes its old review.", + "Archived source/dependency drift and environment-specific skips remain explicit in per-batch records. Comprehensive audit remains in progress." + ] +} diff --git a/docs/audits/test-value/reviews/cloud-0003-validation.json b/docs/audits/test-value/reviews/cloud-0003-validation.json new file mode 100644 index 00000000000..bc000bdf07f --- /dev/null +++ b/docs/audits/test-value/reviews/cloud-0003-validation.json @@ -0,0 +1,423 @@ +{ + "batch": "cloud-0003", + "reviewer": "audit_cloud", + "checkout": "/home/neil/orca/workspaces/orca/comprehensive-test-audit-3", + "source_commit": "6d473f4bea1d190cb3649af97e04f1cdde170c5f", + "implementation_base": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "original_hash_reconciliation": "All 50 selected original file contents and all 3 encountered support files match the implementation checkout; no upstream source differences required reconciliation.", + "reviewed_files": 50, + "support_files": 3, + "original_declarations": 400, + "final_declarations": 392, + "decisions": { + "keep": 312, + "fix": 80, + "remove": 8 + }, + "parameterized_declarations": 25, + "review_scope": "Read every original body/table and relevant production implementation; each parameter table row and additional body-loop matrix is recorded individually. Fixture/setup/workload repetition is distinguished from behavioral subcases.", + "checks": [ + { + "command": [ + "pnpm", + "exec", + "vitest", + "run", + "--maxWorkers=1", + "src/cell-seat-feed.test.ts", + "src/cell-seat-log.test.ts", + "src/config.test.ts", + "src/connection-reservation-debt-retention.test.ts", + "src/control-accept-cell-row-lock-postgres.test.ts", + "src/control-accept-cell-row-lock.test.ts", + "src/control-lease-recovery-postgres.test.ts", + "src/control-rebind-inventory-lock-postgres.test.ts", + "src/control-renewal-batch-store.test.ts", + "src/control-renewal-batch.test.ts", + "src/control-renewal-postgres.test.ts", + "src/control-reservation-reconnect-claim.test.ts", + "src/credential-cleanup-sweep-postgres.test.ts", + "src/credential-store-cleanup.test.ts", + "src/credential-store.test.ts", + "src/database-connect-stall-postgres.test.ts", + "src/database-postgres-timeout.test.ts", + "src/database-statement-timeout-postgres.test.ts", + "src/database-transient-error.test.ts", + "src/database.test.ts", + "src/dead-cell-evacuation-precheck.test.ts", + "src/dead-relay-tables-postgres.test.ts", + "src/director-reserve-placement-status.test.ts", + "src/drain-migration-row-lookup.test.ts", + "src/drain-migration-row-scaling.test.ts", + "src/drain-release-cell-row-contention-postgres.test.ts", + "src/drain-return-admission.test.ts", + "src/floating-promise-census.test.ts", + "src/host-close-reason-memory.test.ts", + "src/host-control-proof-cleanup.test.ts", + "src/host-control-resume-identity.test.ts", + "src/host-session-client-accept.test.ts", + "src/host-session-drain-release-order.test.ts", + "src/host-session-preauth-latency.test.ts", + "src/host-session-registry.test.ts", + "src/host-signed-out-rejection.test.ts", + "src/host-whereabouts-app.test.ts", + "src/idle-regional-rehome-reconciliation.test.ts", + "src/idle-regional-rehome-store.test.ts", + "src/idle-regional-rehome-window.test.ts", + "src/idle-regional-rehome-worker.test.ts", + "src/migration-recovery-postgres.test.ts", + "src/placement-load-band.test.ts", + "src/post-proof-close-log.test.ts", + "src/postgres-checked-out-client-error.test.ts", + "src/postgres-commit-with-final-write-postgres.test.ts", + "src/postgres-drain-send-locking.test.ts", + "src/postgres-idle-client-error.test.ts", + "src/postgres-lock-wait-sample-postgres.test.ts", + "src/postgres-lock-wait-sample.test.ts" + ], + "cwd": "cloud/apps/relay", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1", + "ORCA_RELAY_TEST_POSTGRES_URL": "fresh localhost:55440 database orca_audit_cloud_0003_final", + "ORCA_IDLE_REHOME_POSTGRES_URL": "same database; unique disposable schema per case" + }, + "result": "50 suites passed; 453 runtime tests passed, including real PostgreSQL SQL/lock/timeout/planner/transaction/recovery checks and all 11 real paced contention scenarios.", + "log": "/tmp/orca-cloud3-postgres-final.log" + }, + { + "command": [ + "pnpm", + "exec", + "vitest", + "run", + "--maxWorkers=2", + "src/cell-seat-feed.test.ts", + "src/cell-seat-log.test.ts", + "src/config.test.ts", + "src/connection-reservation-debt-retention.test.ts", + "src/control-accept-cell-row-lock-postgres.test.ts", + "src/control-accept-cell-row-lock.test.ts", + "src/control-lease-recovery-postgres.test.ts", + "src/control-rebind-inventory-lock-postgres.test.ts", + "src/control-renewal-batch-store.test.ts", + "src/control-renewal-batch.test.ts", + "src/control-renewal-postgres.test.ts", + "src/control-reservation-reconnect-claim.test.ts", + "src/credential-cleanup-sweep-postgres.test.ts", + "src/credential-store-cleanup.test.ts", + "src/credential-store.test.ts", + "src/database-connect-stall-postgres.test.ts", + "src/database-postgres-timeout.test.ts", + "src/database-statement-timeout-postgres.test.ts", + "src/database-transient-error.test.ts", + "src/database.test.ts", + "src/dead-cell-evacuation-precheck.test.ts", + "src/dead-relay-tables-postgres.test.ts", + "src/director-reserve-placement-status.test.ts", + "src/drain-migration-row-lookup.test.ts", + "src/drain-migration-row-scaling.test.ts", + "src/drain-release-cell-row-contention-postgres.test.ts", + "src/drain-return-admission.test.ts", + "src/floating-promise-census.test.ts", + "src/host-close-reason-memory.test.ts", + "src/host-control-proof-cleanup.test.ts", + "src/host-control-resume-identity.test.ts", + "src/host-session-client-accept.test.ts", + "src/host-session-drain-release-order.test.ts", + "src/host-session-preauth-latency.test.ts", + "src/host-session-registry.test.ts", + "src/host-signed-out-rejection.test.ts", + "src/host-whereabouts-app.test.ts", + "src/idle-regional-rehome-reconciliation.test.ts", + "src/idle-regional-rehome-store.test.ts", + "src/idle-regional-rehome-window.test.ts", + "src/idle-regional-rehome-worker.test.ts", + "src/migration-recovery-postgres.test.ts", + "src/placement-load-band.test.ts", + "src/post-proof-close-log.test.ts", + "src/postgres-checked-out-client-error.test.ts", + "src/postgres-commit-with-final-write-postgres.test.ts", + "src/postgres-drain-send-locking.test.ts", + "src/postgres-idle-client-error.test.ts", + "src/postgres-lock-wait-sample-postgres.test.ts", + "src/postgres-lock-wait-sample.test.ts" + ], + "cwd": "cloud/apps/relay", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "result": "38 suites passed, 12 PostgreSQL-only suites skipped; 377 runtime tests passed and 72 PostgreSQL-only cases skipped.", + "log": "/tmp/orca-cloud3-sqlite-final.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 pnpm --dir cloud typecheck", + "result": "All cloud package and app typechecks passed after building cloud contract/schema packages.", + "log": "/tmp/orca-cloud3-typecheck-final.log" + }, + { + "command": "pnpm run check:code-quality:changed", + "result": "Passed; root gate explicitly excludes cloud/.", + "log": "/tmp/orca-cloud3-quality.log" + }, + { + "command": "pnpm run check:react-doctor:changed", + "result": "Passed, 0 changed-line errors; this independent gate includes cloud/.", + "log": "/tmp/orca-cloud3-react-doctor-final.log" + }, + { + "command": "git diff --check -- cloud", + "result": "Passed" + }, + { + "command": "pnpm exec oxfmt --config=/tmp/orca-cloud3-oxfmt.json --ignore-path=/dev/null --write <33 changed test files>", + "result": "Formatted changed code, retaining original unchanged statement/case formatting to avoid unrelated churn; cloud/ is excluded from the root formatter configuration.", + "log": "/tmp/orca-cloud3-format.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 pnpm --dir cloud/apps/relay exec vitest run src/host-session-registry.test.ts", + "result": "91 tests passed after preserving the intentionally partial, never-read fixture in the existing mid-cutover rejection case.", + "log": "/tmp/orca-cloud3-registry-final.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 ORCA_RELAY_TEST_POSTGRES_URL= pnpm --dir cloud/apps/relay exec vitest run src/control-rebind-inventory-lock-postgres.test.ts", + "result": "2 tests passed after final cleanup formatting.", + "log": "/tmp/orca-cloud3-rebind-final.log" + }, + { + "command": "Scoped pg_stat_activity check after test processes completed", + "result": "Zero remaining client sessions in the three batch databases; all four temporary mutation configs deleted." + } + ], + "initial_validation_findings": [ + "Initial run exposed fixture book.clear missing during unconditional drain; supplied that actual cleanup surface.", + "The strict identity request schema excludes command-only fields; retained independent full wire-body assertions and complete typed safety snapshot rather than using the wrong schema.", + "Initial cloud typecheck required building cloud contract/schema packages.", + "Changed-line React Doctor findings were fixed; no rule suppressions added." + ], + "mutations": [ + { + "id": "refresh-recency", + "source": "host-close-reason-memory.ts", + "needle": " this.entries.delete(key)\n this.entries.set(key,", + "replacement": " this.entries.set(key,", + "test": "host-close-reason-memory.test.ts", + "title": "re-recording refreshes recency", + "command": [ + "pnpm", + "exec", + "vitest", + "run", + "--config=/tmp/orca-cloud3-refresh-recency.vitest.mjs", + "-t", + "re-recording refreshes recency" + ], + "exit": 1, + "log": "/tmp/orca-cloud3-mutation-refresh-recency.log", + "result": "targeted retained test failed with mutation applied; source file unchanged on disk" + }, + { + "id": "pool-wrong-event", + "source": "database.ts", + "needle": " pool.on('error', () => {", + "replacement": " pool.on('connect', () => {", + "test": "postgres-idle-client-error.test.ts", + "title": "absorbs the pool error", + "command": [ + "pnpm", + "exec", + "vitest", + "run", + "--config=/tmp/orca-cloud3-pool-wrong-event.vitest.mjs", + "-t", + "absorbs the pool error" + ], + "exit": 1, + "log": "/tmp/orca-cloud3-mutation-pool-wrong-event.log", + "result": "targeted retained test failed with mutation applied; source file unchanged on disk" + }, + { + "id": "cleanup-expiry-index", + "source": "credential-store.ts", + "needle": "WHERE expires_at <= ? AND state IN (?, ?, ?)", + "replacement": "WHERE expires_at <= ? AND LOWER(state) IN (?, ?, ?)", + "test": "credential-cleanup-sweep-postgres.test.ts", + "title": "plans both invite sweeps", + "command": [ + "pnpm", + "exec", + "vitest", + "run", + "--config=/tmp/orca-cloud3-cleanup-expiry-index.vitest.mjs", + "-t", + "plans both invite sweeps" + ], + "exit": 1, + "log": "/tmp/orca-cloud3-mutation-cleanup-expiry-index.log", + "result": "targeted retained test failed with mutation applied; source file unchanged on disk" + }, + { + "id": "fused-deadlock-retry", + "source": "database.ts", + "needle": "return code === '40P01' || code === '40001' || code === '55P03' || code === '57014'", + "replacement": "return code === '40001' || code === '55P03' || code === '57014'", + "test": "postgres-commit-with-final-write-postgres.test.ts", + "title": "retries a deadlock raised by the fused message", + "command": [ + "pnpm", + "exec", + "vitest", + "run", + "--config=/tmp/orca-cloud3-fused-deadlock-retry.vitest.mjs", + "-t", + "retries a deadlock raised by the fused message" + ], + "exit": 1, + "log": "/tmp/orca-cloud3-mutation-fused-deadlock-retry.log", + "result": "targeted retained test failed with mutation applied; source file unchanged on disk" + } + ], + "mutation_method": "Four isolated Vitest Vite transforms altered the actual loaded production module in the test process only. Each targeted test failed at its intended boundary, each applied-transform marker was observed, source bytes were checked unchanged, and each temporary configuration was deleted. PostgreSQL mutations used a separate fresh database. Production files remained unchanged on disk throughout.", + "implementation_reconciliations": [ + "Whole-host candidate pages intentionally retain every target fallback, so this three-target fixture has an independently asserted maximum of 102 candidates rather than truncating at 100.", + "Idle-client test uses the actual pg.Pool EventEmitter without opening a connection, so subscribing to the wrong event cannot pass.", + "The final fused-message deadlock test uses an actual PostgreSQL trigger raising 40P01 on the first update, driven by a nontransactional sequence, so the transaction under test must retry rather than relying on the server choosing a particular deadlock victim." + ], + "changed_files": [ + { + "path": "cloud/apps/relay/src/cell-seat-feed.test.ts", + "sha256": "d95676c889380ac05e56c75c51c4fcff1ba6635f856772b86d475c0ce466dc12" + }, + { + "path": "cloud/apps/relay/src/control-accept-cell-row-lock.test.ts", + "sha256": "3ab794c308aeb1f2c738f0c8439999dd3c79442351bf1802834d485ec4fdf1a1" + }, + { + "path": "cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts", + "sha256": "90d3e5a930b567e88bad1c5b372ce2d46917a209057f5f91252494c3eb2611f5" + }, + { + "path": "cloud/apps/relay/src/control-renewal-batch-store.test.ts", + "sha256": "856bce7b93b3ca0fb9aed7bd59ff0fc4d6909b5b13345e7e897eaae8d40c3797" + }, + { + "path": "cloud/apps/relay/src/control-renewal-postgres.test.ts", + "sha256": "1c5032198245240fbdfdba935a9214116cd8798c71e85dceed930050c6fe9e9a" + }, + { + "path": "cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts", + "sha256": "5129a0dbd975ad12bee655675582c4898ced0df8dabf8e73f5130b9dde146131" + }, + { + "path": "cloud/apps/relay/src/credential-store-cleanup.test.ts", + "sha256": "8274533789ba4332d233507bd17c2c83156aa30421deb3bc1dd5ccbb398a8306" + }, + { + "path": "cloud/apps/relay/src/credential-store.test.ts", + "sha256": "12570ddac3ae51f4ea015c4effd70c95bdd6830ce9084c1f602af0e74775fc3d" + }, + { + "path": "cloud/apps/relay/src/database-connect-stall-postgres.test.ts", + "sha256": "f2e196714898b1a51b10b659de90d2c0095284f1a45f155a3795d5bc074c744b" + }, + { + "path": "cloud/apps/relay/src/database-postgres-timeout.test.ts", + "sha256": "910caabb96ac8a196c182df07322b589a74645e35463663928926738a5df3a32" + }, + { + "path": "cloud/apps/relay/src/database-statement-timeout-postgres.test.ts", + "sha256": "8a767423720af5eea5f35e0bd0fce73a9849c47a105659f7688bdbf22c8bf362" + }, + { + "path": "cloud/apps/relay/src/database.test.ts", + "sha256": "e12b26f76368231c088b786be743102a166591da866c311aedec693489d4f41a" + }, + { + "path": "cloud/apps/relay/src/dead-relay-tables-postgres.test.ts", + "sha256": "956a752584134198451aa2c11f2470bab4d2a360487b909e57b61c4cda876758" + }, + { + "path": "cloud/apps/relay/src/director-reserve-placement-status.test.ts", + "sha256": "7c3bab48bcbdfa90e3db6fb4a22537322aaaf7a54e1c12e499225ccd3dd1f770" + }, + { + "path": "cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts", + "sha256": "e45ed3017e70377493a84776e8b3f3e80a14ea468df320c164514d25fc2e0166" + }, + { + "path": "cloud/apps/relay/src/floating-promise-census.test.ts", + "sha256": "a863b2eb430294bd4846bc02759000cda99e3701eed66ba07be52805968e6664" + }, + { + "path": "cloud/apps/relay/src/host-close-reason-memory.test.ts", + "sha256": "92da427416a1f2d55121eacfed26027e18e8bdb44e8f5b297801edb4ffad6e9e" + }, + { + "path": "cloud/apps/relay/src/host-control-resume-identity.test.ts", + "sha256": "ac29bd21d656e17c6722a27b01e8b48be26d02ed0a4195ccf151d1741f2e04ae" + }, + { + "path": "cloud/apps/relay/src/host-session-client-accept.test.ts", + "sha256": "22c7e48886aea21ab072762d4b2b8a2e0e9003709ecb09b63885c692192d9df9" + }, + { + "path": "cloud/apps/relay/src/host-session-preauth-latency.test.ts", + "sha256": "a48b9c7035700f1436b66dd2341d7880f530b3be9a9141cda9cb46101c0fe9a4" + }, + { + "path": "cloud/apps/relay/src/host-session-registry.test.ts", + "sha256": "f285b3724340fe47f09640ab65375fc640f88f14c6f09b08d093865e307a64bf" + }, + { + "path": "cloud/apps/relay/src/host-whereabouts-app.test.ts", + "sha256": "3bf9908dfa2fb9d01d555851b2694520c540f8a5283bea62208e1f6ed5c684da" + }, + { + "path": "cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts", + "sha256": "fa3bc53d0a5a2f37df623867d09d3d479c4744783e6ada51accdf4c7e204a2ca" + }, + { + "path": "cloud/apps/relay/src/idle-regional-rehome-store.test.ts", + "sha256": "5df06920367ee17690f0f5446dc2240567e8ad4fc3e806a471b8bff59c5c0b86" + }, + { + "path": "cloud/apps/relay/src/idle-regional-rehome-window.test.ts", + "sha256": "ae3e946a75587a7387c5403abb790e51716f61dfae0b5bf5b1c18c57a1cb673f" + }, + { + "path": "cloud/apps/relay/src/idle-regional-rehome-worker.test.ts", + "sha256": "6c4d6339e6a960dbf3523af84a1ba64cbc45c798049a5e0454cb74bbbd08f770" + }, + { + "path": "cloud/apps/relay/src/migration-recovery-postgres.test.ts", + "sha256": "8a61b80052eac264d4e92f3b8c181130a2117b0e9648a1050f05e3d7b001ed33" + }, + { + "path": "cloud/apps/relay/src/placement-load-band.test.ts", + "sha256": "f8aba58bbb49fb869e8db1f43e224432fb8074e9cc041865fe58b484fb64dbf9" + }, + { + "path": "cloud/apps/relay/src/postgres-checked-out-client-error.test.ts", + "sha256": "0b7da794a86f39ffb6c583f70803e3a6a1755ebdfbaa0e4c25c8a79f0b891581" + }, + { + "path": "cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts", + "sha256": "8dd628f605cc2c94a75f7612b831aca9bb522ad68bbd136935460ac418f4896c" + }, + { + "path": "cloud/apps/relay/src/postgres-drain-send-locking.test.ts", + "sha256": "b0ecdbafdff311bfd70f98ed11626a13c4dbf80a555108e3c59c50fe587ab1c0" + }, + { + "path": "cloud/apps/relay/src/postgres-idle-client-error.test.ts", + "sha256": "57d81afc1b9dfbcf275b7f814c9c2dbb634fbf51fc23f48c11ac5883da32eccf" + }, + { + "path": "cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts", + "sha256": "e2830bcfa3bae572dd31bc2c4178248ab534ea87b9a72de4b6030993d036e0c8" + } + ], + "production_changes": [], + "staging": "Uncommitted and unstaged; parent owns staging, inventory refresh and PR coordination.", + "remaining_concerns": [], + "log_note": "Local log paths are session evidence pointers; commands, results, mutation descriptions and content hashes are retained here for durable review." +} diff --git a/docs/audits/test-value/reviews/cloud-0003.jsonl b/docs/audits/test-value/reviews/cloud-0003.jsonl new file mode 100644 index 00000000000..b8a44ae29b5 --- /dev/null +++ b/docs/audits/test-value/reviews/cloud-0003.jsonl @@ -0,0 +1,53 @@ +{"path":"cloud/apps/relay/src/cell-seat-feed.test.ts","sha256":"c8a0642b4858af185c2877b2a0f4b1c76e65a33deef6838a766e843eff650fae","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/cell-seat-feed-route.ts","cloud/apps/relay/src/cell-seat-log.ts","cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/app.ts"],"cases":[{"line":230,"title":"answers a first poll with every seated host, matching the controls count","decision":"keep","reason":"Real registry activations flow through the HTTP route and independent published-wire schema; snapshot seats agree with the control ledger."},{"line":250,"title":"keeps a closing socket seated until its close lands, as the change log does","decision":"keep","reason":"A closing WebSocket remains a seat until its close event, while the open-control count already falls."},{"line":263,"title":"reports join, drain-only and leave as changes after the cursor","decision":"keep","reason":"Actual registry drain and close events generate ordered delta kinds and refuse post-drain joins."},{"line":286,"title":"reports an auth expiry as drain-only and the refresh that clears it as active","decision":"keep","reason":"A fake-clock token expiry emits drain-only and a verified refresh restores active state in the real feed."},{"line":307,"title":"does not report a rebind as a leave, and joins the rebound socket","decision":"keep","reason":"A same-generation rebind updates the seat without a leave event."},{"line":318,"title":"reports a superseded generation leaving after its successor joined","decision":"keep","reason":"Generation replacement produces an old-generation leave and successor join that readers can apply safely."},{"line":333,"title":"resyncs a cursor from another incarnation with a full snapshot","decision":"keep","reason":"Another incarnation requests a full snapshot and malformed cursors receive an HTTP 400."},{"line":341,"title":"reports the applied cell flags, so a flip can be read back through the feed and runtime status","decision":"fix","reason":"Retain applied flag generation/value roundtrip and effective phone-path checks; trim the copied supportedFlags capability inventory because it duplicates production metadata rather than exercising each flag."},{"line":372,"title":"accepts only the directors rehome identity, verified once per poll","decision":"keep","reason":"Dedicated rehome identity authorizes actual HTTP polls while deploy/invalid tokens fail and general admin verification is bypassed."},{"line":382,"title":"is unavailable on a cell without the rehome pair, and on directors","decision":"keep","reason":"Missing trust configuration and director-only role make the feed unavailable."},{"line":395,"title":"leaves the reported rehome protocol to the existing env","decision":"keep","reason":"Runtime protocol advertisement preserves the existing dedicated-trust configuration contract; this covers a distinct HTTP response from heartbeat advertisement."}],"reviewed_sha256":"d95676c889380ac05e56c75c51c4fcff1ba6635f856772b86d475c0ce466dc12","decision":"fix","rationale":"Retain applied flag generation/value roundtrip and effective phone-path checks; trim the copied supportedFlags capability inventory because it duplicates production metadata rather than exercising each flag."} +{"path":"cloud/apps/relay/src/cell-seat-log.test.ts","sha256":"d5173601a135cf68339ec65df3c0d07629f698f163237a6213771caf0abaec7d","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/cell-seat-log.ts"],"cases":[{"line":18,"title":"answers a missing cursor with the live seats and the head as the next cursor","decision":"keep","reason":"An absent cursor returns all actual seats and the head sequence."},{"line":30,"title":"returns only the changes after the cursor","decision":"keep","reason":"A current cursor returns only subsequent changes and returns an empty delta at the head."},{"line":39,"title":"resyncs with a full snapshot once the cursor has fallen out of the ring","decision":"keep","reason":"The exact oldest retained ring boundary permits continuation while an older cursor forces resync."},{"line":47,"title":"resyncs a cursor ahead of the head instead of skipping changes","decision":"keep","reason":"An ahead-of-head cursor resyncs rather than losing future changes."},{"line":53,"title":"pages a long backlog and resumes from the returned cursor","decision":"keep","reason":"An oversized backlog cuts a bounded page and resumes with only the remaining changes."},{"line":76,"title":"holds exactly what a reader applying every change by generation holds","decision":"keep","reason":"A stale generation leave cannot remove its successor; current drain and leave events update the snapshot coherently."},{"line":96,"title":"reads an incarnation and a sequence, and refuses anything else","decision":"keep","reason":"Independent cursor examples reject malformed, negative and invalid-incarnation encodings."},{"line":108,"title":"never seats a booking, and remembers leavers for ten minutes for the full snapshot","decision":"keep","reason":"Bookings never become seats; leave metadata is queryable and expires precisely at ten minutes."},{"line":125,"title":"sends only the newest page of leavers in a full snapshot","decision":"keep","reason":"A full snapshot includes only the newest bounded page of leavers while direct memory lookup still retains an older entry."}],"reviewed_sha256":"d5173601a135cf68339ec65df3c0d07629f698f163237a6213771caf0abaec7d","decision":"keep","rationale":"An absent cursor returns all actual seats and the head sequence. A current cursor returns only subsequent changes and returns an empty delta at the head. The exact oldest retained ring boundary permits continuation while an older cursor forces resync. An ahead-of-head cursor resyncs rather than losing future changes. An oversized backlog cuts a bounded page and resumes with only the remaining changes. A stale generation leave cannot remove its successor; current drain and leave events update the snapshot coherently. Independent cursor examples reject malformed, negative and invalid-incarnation encodings. Bookings never become seats; leave metadata is queryable and expires precisely at ten minutes. A full snapshot includes only the newest bounded page of leavers while direct memory lookup still retains an older entry."} +{"path":"cloud/apps/relay/src/config.test.ts","sha256":"96e13eb55b2e856d6278502ae0123148de9808b4bcf8cda77f0a47e3c8d03487","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/config.ts","cloud/apps/relay/src/relay-readiness.ts"],"cases":[{"line":33,"title":"defaults optional region correction off and bounds the cohort","decision":"keep","reason":"Real environment parsing defaults region correction off and rejects out-of-range, fractional and nonnumeric cohort inputs.","body_cases":[{"input":"-1","decision":"keep","reason":"Out-of-range, fractional and malformed cohorts are rejected rather than enabling an unintended rollout."},{"input":"101","decision":"keep","reason":"Out-of-range, fractional and malformed cohorts are rejected rather than enabling an unintended rollout."},{"input":"1.5","decision":"keep","reason":"Out-of-range, fractional and malformed cohorts are rejected rather than enabling an unintended rollout."},{"input":"not-a-number","decision":"keep","reason":"Out-of-range, fractional and malformed cohorts are rejected rather than enabling an unintended rollout."}]},{"line":44,"title":"defaults readiness grace to fifteen minutes for JWKS and three for SQL","decision":"keep","reason":"Readiness windows parse explicit zero and maximum values while rejecting invalid durations.","body_cases":[{"input":"-1","decision":"keep","reason":"Grace values outside the supported integer duration fail configuration validation."},{"input":"RELAY_MAX_READINESS_GRACE_MS + 1","decision":"keep","reason":"Grace values outside the supported integer duration fail configuration validation."},{"input":"1.5","decision":"keep","reason":"Grace values outside the supported integer duration fail configuration validation."},{"input":"soon","decision":"keep","reason":"Grace values outside the supported integer duration fail configuration validation."}]},{"line":63,"title":"reads an unset readiness grace variable as the default, never as zero","decision":"keep","reason":"Empty environment strings preserve readiness defaults instead of coercing to zero."},{"line":73,"title":"requires distinct dedicated admin identities and accepts omitted values","decision":"keep","reason":"Optional dedicated identities remain absent and duplicate configured admin identities are rejected."},{"line":98,"title":"requires a distinct paired identity and exact audience for regional host drain","decision":"keep","reason":"Regional drain requires a dedicated paired identity, exact route audience and separation from cell runtime credentials."},{"line":122,"title":"accepts a measured capacity above the Cloud Run request ceiling","decision":"keep","reason":"A measured 4000-request capacity is accepted independently of old Cloud Run limits."},{"line":126,"title":"retains a finite process-wide capacity bound","decision":"keep","reason":"A capacity above the process-wide finite bound is rejected by the actual parser."},{"line":130,"title":"keeps legacy cells uncapped and requires a supported hard-cap pair","decision":"keep","reason":"Uncapped legacy cells remain supported while incomplete, unsupported and overlarge connection-bound pairs fail."},{"line":163,"title":"accepts hard-cap metadata in director cell inventory","decision":"keep","reason":"Director inventory carries a supported hard-cap pair into the parsed cell record."},{"line":184,"title":"accepts mixed 600- and 1000-cap director inventory","decision":"keep","reason":"Mixed 600/1000 cell inventories remain valid for rolling deployments."},{"line":211,"title":"accepts only a canonical served image digest","decision":"keep","reason":"Only canonical sha256 image digests survive actual config parsing."},{"line":219,"title":"accepts a statically declared candidate that starts disabled","decision":"keep","reason":"A statically declared disabled candidate retains its explicit disabled state and region."},{"line":244,"title":"reserves a smaller PostgreSQL connection budget for directors","decision":"keep","reason":"Role-specific database-pool defaults and a valid override are applied by the real loader."},{"line":262,"title":"defaults to bounded public assignment admission and supports an emergency stop","decision":"keep","reason":"Actual parser defaults admission limits and accepts explicit emergency stop and bounded overrides."},{"line":293,"title":"fails closed when public request lanes exceed the director database pool","decision":"keep","reason":"A director with insufficient pool headroom fails before serving public assignment traffic."}],"reviewed_sha256":"96e13eb55b2e856d6278502ae0123148de9808b4bcf8cda77f0a47e3c8d03487","decision":"keep","rationale":"Real environment parsing defaults region correction off and rejects out-of-range, fractional and nonnumeric cohort inputs. Readiness windows parse explicit zero and maximum values while rejecting invalid durations. Empty environment strings preserve readiness defaults instead of coercing to zero. Optional dedicated identities remain absent and duplicate configured admin identities are rejected. Regional drain requires a dedicated paired identity, exact route audience and separation from cell runtime credentials. A measured 4000-request capacity is accepted independently of old Cloud Run limits. A capacity above the process-wide finite bound is rejected by the actual parser. Uncapped legacy cells remain supported while incomplete, unsupported and overlarge connection-bound pairs fail. Director inventory carries a supported hard-cap pair into the parsed cell record. Mixed 600/1000 cell inventories remain valid for rolling deployments. Only canonical sha256 image digests survive actual config parsing. A statically declared disabled candidate retains its explicit disabled state and region. Role-specific database-pool defaults and a valid override are applied by the real loader. Actual parser defaults admission limits and accepts explicit emergency stop and bounded overrides. A director with insufficient pool headroom fails before serving public assignment traffic."} +{"path":"cloud/apps/relay/src/connection-reservation-debt-retention.test.ts","sha256":"41d35eaf400f161b6a329113ecffba339326d2ba02fbf633f2e7f6e66bc08abc","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":83,"title":"releases unclaimed debt past retention and keeps fresh or claimed debt","decision":"keep","reason":"Actual SQLite cleanup releases old unclaimed late-arrival debt while retaining recent or claimed reservations."},{"line":107,"title":"restores placement once stale debt no longer consumes connection headroom","decision":"keep","reason":"A real capacity refusal becomes a successful assignment only after stale debt is reaped, proving the durable cleanup affects headroom."}],"reviewed_sha256":"41d35eaf400f161b6a329113ecffba339326d2ba02fbf633f2e7f6e66bc08abc","decision":"keep","rationale":"Actual SQLite cleanup releases old unclaimed late-arrival debt while retaining recent or claimed reservations. A real capacity refusal becomes a successful assignment only after stale debt is reaped, proving the durable cleanup affects headroom."} +{"path":"cloud/apps/relay/src/control-accept-cell-row-lock-postgres.test.ts","sha256":"4cc5ea469a9d5261d770b910d5ab65a11b54e375674e4fba10454b8fa3a9ea70","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/database.ts","cloud/apps/relay/src/relay-server.ts"],"cases":[{"line":67,"title":"lets exactly one of two racing accepts take the last capacity slot","decision":"keep","reason":"Two independent PostgreSQL accepts race the last real request-capacity slot and leave exact persisted lease/cell accounting."},{"line":128,"title":"rebinds a control while another connection holds the cell row","decision":"keep","reason":"A same-cell rebind succeeds while another connection holds that cell row, proving the zero-net-reservation path avoids the shared lock."},{"line":185,"title":"commits every counter write in one message through the production store","decision":"keep","reason":"The actual production store wrapper forwards fused commits for release, control activation and activity acquisition; driver observation proves three combined messages and no separate commit."}],"reviewed_sha256":"4cc5ea469a9d5261d770b910d5ab65a11b54e375674e4fba10454b8fa3a9ea70","decision":"keep","rationale":"Two independent PostgreSQL accepts race the last real request-capacity slot and leave exact persisted lease/cell accounting. A same-cell rebind succeeds while another connection holds that cell row, proving the zero-net-reservation path avoids the shared lock. The actual production store wrapper forwards fused commits for release, control activation and activity acquisition; driver observation proves three combined messages and no separate commit."} +{"path":"cloud/apps/relay/src/control-accept-cell-row-lock.test.ts","sha256":"4c60f182c1b021668ce716a23a6bbaf827c52dcd45d45e9a91ef3065541d7f10","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/database.ts"],"cases":[{"line":106,"title":"writes the shared cell row once, last, and never takes it as a read lock","decision":"fix","reason":"Real SQLite plus transparent statement recording proves the contended cell write occurs once at the end without an earlier read lock; add afterEach close for every opened in-memory database."},{"line":120,"title":"leaves the cell row untouched when a rebind retires and installs one control","decision":"fix","reason":"The real rebind leaves the cell row untouched and keeps both persisted reservation and lease units at one; shared fixture needs unconditional database cleanup."},{"line":130,"title":"keeps the reservation equal to the cell lease units across repeated rebinds","decision":"remove","reason":"Remove the five-generation replay because the preceding real rebind already proves unchanged cell writes and exact reservation/lease units across the same transition."},{"line":137,"title":"still refuses an accept that would exceed the cell capacity","decision":"fix","reason":"Actual capacity exhaustion rejects before changing cell reservation or lease totals; shared fixture needs unconditional database cleanup."}],"reviewed_sha256":"3ab794c308aeb1f2c738f0c8439999dd3c79442351bf1802834d485ec4fdf1a1","decision":"consolidate","rationale":"Real SQLite plus transparent statement recording proves the contended cell write occurs once at the end without an earlier read lock; add afterEach close for every opened in-memory database. The real rebind leaves the cell row untouched and keeps both persisted reservation and lease units at one; shared fixture needs unconditional database cleanup. Remove the five-generation replay because the preceding real rebind already proves unchanged cell writes and exact reservation/lease units across the same transition. Actual capacity exhaustion rejects before changing cell reservation or lease totals; shared fixture needs unconditional database cleanup."} +{"path":"cloud/apps/relay/src/control-lease-recovery-postgres.test.ts","sha256":"303671b93a590a4bf1b0f0ca11e7889df0bedec49b0afa87419333e3bd3cbecb","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/control-renewal-batch.ts"],"cases":[{"line":180,"title":"re-acquires a reaped lease while the assignment remains on this cell","decision":"keep","reason":"A real PostgreSQL reaper removes the control lease, then the actual registry heartbeat/batcher reacquires it without closing the socket."},{"line":200,"title":"closes without stealing back a lease that moved to another cell","decision":"keep","reason":"A lease moved to another cell is refused by the real store and registry renewal closes the stale control without overwriting the target lease."}],"reviewed_sha256":"303671b93a590a4bf1b0f0ca11e7889df0bedec49b0afa87419333e3bd3cbecb","decision":"keep","rationale":"A real PostgreSQL reaper removes the control lease, then the actual registry heartbeat/batcher reacquires it without closing the socket. A lease moved to another cell is refused by the real store and registry renewal closes the stale control without overwriting the target lease."} +{"path":"cloud/apps/relay/src/control-rebind-inventory-lock-postgres.test.ts","sha256":"ba35c4d006cec797fd85bdbadb6632aa48c8b9488fc209c89bc96276647ee641","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/database.ts"],"cases":[{"line":100,"title":"rebinds and supersedes a control while another cell's row is held","decision":"fix","reason":"Keep the independent PostgreSQL proof that a cell-A rebind progresses under a held cell-B row and leaves one exact control lease. Put holder release/draining in finally and cancel its Promise.race deadline timer, including failure paths."},{"line":188,"title":"moves an activity from a higher cell to a lower one in cell_id order","decision":"fix","reason":"Keep ascending-cell lock/accounting proof, but replace the 250ms sleep with this fixture connection's observed PostgreSQL waiter and always release/drain the holder and move in finally."}],"reviewed_sha256":"90d3e5a930b567e88bad1c5b372ce2d46917a209057f5f91252494c3eb2611f5","decision":"fix","rationale":"Keep the independent PostgreSQL proof that a cell-A rebind progresses under a held cell-B row and leaves one exact control lease. Put holder release/draining in finally and cancel its Promise.race deadline timer, including failure paths. Keep ascending-cell lock/accounting proof, but replace the 250ms sleep with this fixture connection's observed PostgreSQL waiter and always release/drain the holder and move in finally."} +{"path":"cloud/apps/relay/src/control-renewal-batch-store.test.ts","sha256":"58425a95d7efe57071ac5c73aca198f3c7ab559f8b72a84be2a66d11e72b0b1c","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/control-renewal-statement.ts"],"cases":[{"line":61,"title":"spends one statement on every host that came due","decision":"fix","reason":"Retain batch statement count and independent parameter arrays, but remove equality against the imported production SQL constant; that comparison cannot validate SQL behavior and actual PostgreSQL cases do."},{"line":78,"title":"locks assignment rows in primary-key order and still answers in input order","decision":"keep","reason":"Unsorted identities prove primary-key ordering sent to PostgreSQL while distinct outcomes return to the original request positions."},{"line":109,"title":"keeps a malformed request out of the statement and fails only that row","decision":"keep","reason":"Malformed expiry/activity rows are excluded from the wire arrays and fail individually without poisoning valid peers."},{"line":129,"title":"degrades to one statement per host when the batch statement fails","decision":"keep","reason":"An injected batch statement failure produces two independent per-host fallback statements and a bounded failure diagnostic."},{"line":153,"title":"runs the batch on the priority lane and the per-host fallback on the general one","decision":"keep","reason":"A priority/general transport probe proves only the initial batch bypasses general acquisition, avoiding a high-priority fallback fanout."},{"line":186,"title":"does not fan out per host when the batch never got a connection","decision":"keep","reason":"An acquire timeout returns database errors without per-host retries that would multiply pool pressure."},{"line":205,"title":"reports a host that fails its own fallback statement without touching the rest","decision":"fix","reason":"Retain fallback isolation but assert the exact identity-ordered outcomes rather than counts; the first host must receive database_error and the second renewed."},{"line":223,"title":"reports a contended assignment row apart from a missing one","decision":"remove","reason":"Remove this provided-mock-outcome roundtrip: the real PostgreSQL SKIP LOCKED case independently establishes the contended host verdict and continued peer renewal."},{"line":239,"title":"counts a lone renewal that threw before rethrowing it","decision":"keep","reason":"The single-row throwing path still emits one failure metric before propagating its driver error."},{"line":255,"title":"counts a batch in which every row was rejected before the statement","decision":"keep","reason":"All-invalid batches avoid SQL while emitting each row's real validation outcome."},{"line":273,"title":"counts one renewal metric per row against the flush latency","decision":"fix","reason":"The body proves per-row outcome metrics but never checks flush latency; narrow its title to the actual outcome-count contract or add an independent latency assertion."},{"line":294,"title":"renews every host through the transactional path","decision":"keep","reason":"Real SQLite renewals persist each valid expiry while an absent host fails independently through the transactional implementation."}],"reviewed_sha256":"856bce7b93b3ca0fb9aed7bd59ff0fc4d6909b5b13345e7e897eaae8d40c3797","decision":"consolidate","rationale":"Retain batch statement count and independent parameter arrays, but remove equality against the imported production SQL constant; that comparison cannot validate SQL behavior and actual PostgreSQL cases do. Retain fallback isolation but assert the exact identity-ordered outcomes rather than counts; the first host must receive database_error and the second renewed. Remove this provided-mock-outcome roundtrip: the real PostgreSQL SKIP LOCKED case independently establishes the contended host verdict and continued peer renewal. The body proves per-row outcome metrics but never checks flush latency; narrow its title to the actual outcome-count contract or add an independent latency assertion."} +{"path":"cloud/apps/relay/src/control-renewal-batch.test.ts","sha256":"0cb0e1bbb0261f62bb2a1fabd329b0f9c0d08947d65e0b02ea8a92a746e3c9f1","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/control-renewal-batch.ts"],"cases":[{"line":42,"title":"spends one call on every renewal that came due in the window","decision":"keep","reason":"Fake-clock enqueues remain pending until one shared flush and the actual batch collects every host."},{"line":64,"title":"routes each outcome back to the caller that asked for it","decision":"keep","reason":"Distinct supplied outcomes route to the corresponding caller promises, exercising the actual batching adapter rather than only mock invocation."},{"line":84,"title":"flushes on reaching the row ceiling instead of waiting out the window","decision":"keep","reason":"Reaching the row ceiling flushes immediately and cancels the pending empty-window timer."},{"line":104,"title":"does not hold a new window behind a statement still in PostgreSQL","decision":"keep","reason":"A deferred first database flush cannot block a later window's renewal completion."},{"line":125,"title":"reports the driver failure to every caller in the flush","decision":"keep","reason":"A throwing driver rejects every caller in that actual batch."},{"line":144,"title":"supersedes a second attempt for one lease and answers both callers","decision":"keep","reason":"Same-lease retries retain the maximum expiry and settle both waiting callers from one renewal."},{"line":161,"title":"holds a second activity for one host back to the next flush","decision":"keep","reason":"Two activities for the same host are split across windows while another host joins the first flush."},{"line":187,"title":"stays quiet for a fast flush that renewed everything","decision":"keep","reason":"A successful fast flush reports metrics while suppressing noisy warning output."},{"line":208,"title":"logs one line with the outcome counts when a flush did not renew everything","decision":"keep","reason":"An incomplete flush reports one diagnostic with exact per-outcome counts and returns the missing-lease error to its caller."}],"reviewed_sha256":"0cb0e1bbb0261f62bb2a1fabd329b0f9c0d08947d65e0b02ea8a92a746e3c9f1","decision":"keep","rationale":"Fake-clock enqueues remain pending until one shared flush and the actual batch collects every host. Distinct supplied outcomes route to the corresponding caller promises, exercising the actual batching adapter rather than only mock invocation. Reaching the row ceiling flushes immediately and cancels the pending empty-window timer. A deferred first database flush cannot block a later window's renewal completion. A throwing driver rejects every caller in that actual batch. Same-lease retries retain the maximum expiry and settle both waiting callers from one renewal. Two activities for the same host are split across windows while another host joins the first flush. A successful fast flush reports metrics while suppressing noisy warning output. An incomplete flush reports one diagnostic with exact per-outcome counts and returns the missing-lease error to its caller."} +{"path":"cloud/apps/relay/src/control-renewal-postgres.test.ts","sha256":"3df1cf3aad0a7dc794ba8a1d72a4157fcb8b2cf4a4418b80efe5b9601fe631ce","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/control-renewal-statement.ts"],"cases":[{"line":175,"title":"reaches PostgreSQL past an acquireActivity stalled in the identity queue","decision":"fix","reason":"A stalled identity-queue activity cannot suppress an independently persisted renewal; cancel the two-second race deadline after completion so it leaves no timer behind."},{"line":212,"title":"does not let a late older renewal rewind lease or activity timestamps","decision":"keep","reason":"A deferred old PostgreSQL renewal lands after a newer one and cannot rewind either durable lease or assignment timestamps."},{"line":260,"title":"allows the source only while its exact forward migration remains active","decision":"keep","reason":"An exact active forward migration permits source renewal; completing that durable row fences later source work and preserves the last accepted expiry."},{"line":298,"title":"does not resurrect a control released while its renewal was stalled","decision":"keep","reason":"A released control lease stays absent when its previously stalled renewal resumes."},{"line":323,"title":"rejects a renewal expiry beyond the maximum control lease horizon","decision":"keep","reason":"A lease expiry one millisecond beyond the independent public horizon formula is refused."},{"line":340,"title":"renews every due host in one autocommitted statement","decision":"keep","reason":"Four actual PostgreSQL host leases advance in one autocommitted query with no per-host transaction."},{"line":373,"title":"reports each host its own verdict inside one batch","decision":"keep","reason":"Missing, current and wrong-authority inputs receive their own actual SQL verdicts in one batch."},{"line":398,"title":"passes over a host whose assignment row is held and renews the rest","decision":"fix","reason":"Real SKIP LOCKED skips a held assignment and persists the free host renewal; put holder release and draining in finally so assertion/query failures do not strand the transaction."},{"line":444,"title":"renews both of one host\u2019s control leases in a single batch","decision":"keep","reason":"Two leases for one actual host receive distinct expiries while its assignment takes the maximum, protecting grouped UPDATE behavior."},{"line":498,"title":"uses one autocommitted PostgreSQL statement for a steady renewal","decision":"keep","reason":"A single steady renewal uses the actual autocommitted PostgreSQL query without a transaction wrapper."}],"reviewed_sha256":"1c5032198245240fbdfdba935a9214116cd8798c71e85dceed930050c6fe9e9a","decision":"fix","rationale":"A stalled identity-queue activity cannot suppress an independently persisted renewal; cancel the two-second race deadline after completion so it leaves no timer behind. Real SKIP LOCKED skips a held assignment and persists the free host renewal; put holder release and draining in finally so assertion/query failures do not strand the transaction."} +{"path":"cloud/apps/relay/src/control-reservation-reconnect-claim.test.ts","sha256":"f617fb4e79f0cef41507b1b1983b08f97ff5a9520872c7928b677e0f42e2ee4d","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":117,"title":"claims the fresh reservation when the same generation reconnects","decision":"keep","reason":"Actual SQLite and PostgreSQL state releases historical claims on heartbeat and reconnects the same generation to its new reserved row."},{"line":159,"title":"still refuses to claim a second reservation while the first is outstanding","decision":"keep","reason":"An outstanding live claim prevents the same control from stealing an injected second reservation; the fresh row remains unclaimed."}],"reviewed_sha256":"f617fb4e79f0cef41507b1b1983b08f97ff5a9520872c7928b677e0f42e2ee4d","decision":"keep","rationale":"Actual SQLite and PostgreSQL state releases historical claims on heartbeat and reconnects the same generation to its new reserved row. An outstanding live claim prevents the same control from stealing an injected second reservation; the fresh row remains unclaimed."} +{"path":"cloud/apps/relay/src/credential-cleanup-sweep-postgres.test.ts","sha256":"85e76c71b9bf741f926829a51516e0e1280aeb148922d21ddce97dd63f2053d8","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/credential-store.ts","cloud/apps/relay/src/database.ts"],"cases":[{"line":92,"title":"plans both invite sweeps as index scans instead of scanning the whole table","decision":"fix","reason":"Retain real planner/index coverage, but EXPLAIN the invite sweep SQL captured from the actual cleanup implementation instead of hand-copying its two queries; otherwise an unindexed production change can pass.","body_cases":[{"input":"available","decision":"fix","reason":"Each live-state population contributes to realistic real PostgreSQL planner selectivity; plans come from captured production cleanup SQL and parameters."},{"input":"reserved","decision":"fix","reason":"Each live-state population contributes to realistic real PostgreSQL planner selectivity; plans come from captured production cleanup SQL and parameters."},{"input":"cooldown","decision":"fix","reason":"Each live-state population contributes to realistic real PostgreSQL planner selectivity; plans come from captured production cleanup SQL and parameters."}]},{"line":128,"title":"plans the basis sweep off the composite index rather than the 1.5 GB heap","decision":"fix","reason":"Retain the realistic settled/live basis distribution and real index-plan check, but use the actual generated cleanup statement/parameters rather than the copied UPDATE."},{"line":160,"title":"plans the drained basis reaper off the composite index, not the heap","decision":"fix","reason":"Retain the real empty-backlog basis reaper plan, but capture the actual ctid DELETE from cleanup so predicate/order changes cannot bypass coverage."},{"line":187,"title":"plans the pending-authorization and rate-window sweeps as index scans","decision":"fix","reason":"Retain pending-authorization and rate-window planner regressions, but plan statements captured from the actual cleanup execution rather than reproductions."},{"line":219,"title":"reaps settled bases and consumed authorizations through ctid","decision":"keep","reason":"Actual PostgreSQL ctid deletion drains exactly one bounded settled-basis/authorization batch and retains the live/pending readers."},{"line":269,"title":"reaps terminal invites past retention through ctid, one bounded batch per cycle","decision":"keep","reason":"Actual terminal invite cleanup drains one bounded batch per cycle while preserving live invites and recent terminal history."},{"line":289,"title":"plans the audit reaper off relay_audit_events_at when most rows are past retention","decision":"fix","reason":"Retain the real indexed audit-reaper performance check, but plan the actual generated cleanup DELETE rather than an independently copied statement."},{"line":310,"title":"reaps old confirm results and audit events and keeps the ones inside retention","decision":"keep","reason":"Actual PostgreSQL cleanup removes results/audit rows beyond retention while keeping recent ones."}],"reviewed_sha256":"5129a0dbd975ad12bee655675582c4898ced0df8dabf8e73f5130b9dde146131","decision":"fix","rationale":"Retain real planner/index coverage, but EXPLAIN the invite sweep SQL captured from the actual cleanup implementation instead of hand-copying its two queries; otherwise an unindexed production change can pass. Retain the realistic settled/live basis distribution and real index-plan check, but use the actual generated cleanup statement/parameters rather than the copied UPDATE. Retain the real empty-backlog basis reaper plan, but capture the actual ctid DELETE from cleanup so predicate/order changes cannot bypass coverage. Retain pending-authorization and rate-window planner regressions, but plan statements captured from the actual cleanup execution rather than reproductions. Retain the real indexed audit-reaper performance check, but plan the actual generated cleanup DELETE rather than an independently copied statement."} +{"path":"cloud/apps/relay/src/credential-store-cleanup.test.ts","sha256":"643200d2fcbc61abe423e58452e772bb2d487bfc013d9627d788734e4727fd2e","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/credential-store.ts"],"cases":[{"line":108,"title":"deletes terminal invites past retention and keeps everything else","decision":"keep","reason":"Real SQLite cleanup removes old terminal states and preserves each state inside retention.","body_cases":[{"input":{"state":"expired","age_days":8,"retained":false},"decision":"keep","reason":"Real cleanup reaps only terminal states outside retention and preserves recent rows of each state."},{"input":{"state":"expired","age_days":6,"retained":true},"decision":"keep","reason":"Real cleanup reaps only terminal states outside retention and preserves recent rows of each state."},{"input":{"state":"consumed","age_days":8,"retained":false},"decision":"keep","reason":"Real cleanup reaps only terminal states outside retention and preserves recent rows of each state."},{"input":{"state":"consumed","age_days":6,"retained":true},"decision":"keep","reason":"Real cleanup reaps only terminal states outside retention and preserves recent rows of each state."},{"input":{"state":"invalidated","age_days":8,"retained":false},"decision":"keep","reason":"Real cleanup reaps only terminal states outside retention and preserves recent rows of each state."},{"input":{"state":"invalidated","age_days":6,"retained":true},"decision":"keep","reason":"Real cleanup reaps only terminal states outside retention and preserves recent rows of each state."}]},{"line":128,"title":"never deletes an invite that a reader could still consume, however old","decision":"keep","reason":"Ancient but still consumable available/reserved/cooldown invites survive the actual terminal-state filter.","body_cases":[{"input":"available","decision":"keep","reason":"Ancient rows in every still-consumable invite state survive retention cleanup."},{"input":"reserved","decision":"keep","reason":"Ancient rows in every still-consumable invite state survive retention cleanup."},{"input":"cooldown","decision":"keep","reason":"Ancient rows in every still-consumable invite state survive retention cleanup."}]},{"line":149,"title":"bounds one cycle to a single batch and drains the rest on later cycles","decision":"keep","reason":"5002 terminal invites require two actual cleanup cycles, proving bounded work and eventual progress."},{"line":169,"title":"still expires credentials the sweep owns, and only those past their deadline","decision":"keep","reason":"The real combined cleanup still expires invites/bases/authorizations, cools reservations and removes old rate windows at distinct boundaries."},{"line":246,"title":"reaps connection bases whose deadline passed over a day ago, and nothing else","decision":"keep","reason":"Only unusable bases beyond retention are removed; an ancient active-but-expired basis is deactivated/reaped while a live active basis survives."},{"line":275,"title":"reaps consumed direct authorizations past retention and never a pending one","decision":"keep","reason":"Consumed direct authorizations obey consumed-at retention while a pending usable authorization remains."},{"line":303,"title":"bounds each table to one batch per cycle","decision":"keep","reason":"Independent basis and authorization tables each receive only one bounded batch per cleanup cycle."},{"line":326,"title":"reaps confirm results and audit events only past their retention windows","decision":"keep","reason":"Exact retention boundaries delete old confirms/audit events and preserve the adjacent newer row."},{"line":344,"title":"still replays a confirm result inside retention","decision":"fix","reason":"Replace the fabricated incomplete confirm-result JSON with a result actually committed by install/resume/confirm before cleanup and replay; the current fixture is not an output a producer can generate."}],"reviewed_sha256":"8274533789ba4332d233507bd17c2c83156aa30421deb3bc1dd5ccbb398a8306","decision":"fix","rationale":"Replace the fabricated incomplete confirm-result JSON with a result actually committed by install/resume/confirm before cleanup and replay; the current fixture is not an output a producer can generate."} +{"path":"cloud/apps/relay/src/credential-store.test.ts","sha256":"753ce3910596d2905c72ab2289e24e2a1da361141c56b2994a2e9b8f62d2df77","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/credential-store.ts"],"cases":[{"line":31,"title":"issues invites with a skew margin under the client-side TTL ceiling","decision":"fix","reason":"The real invite expiry stays independently below the released-client ten-minute ceiling; close its opened in-memory database, which this case currently leaks even on success."},{"line":40,"title":"persists one invite reservation with bounded attempts and cooldown","decision":"keep","reason":"Real invite reservations enforce exclusivity, cooldown and reattempt state against persisted rows."},{"line":60,"title":"validates director moves without reservation and enforces account-global mint rate","decision":"keep","reason":"Move validation leaves the invite unconsumed while actual minting hits the account-wide rate limit and creates audit rows."},{"line":79,"title":"serializes relay-basis and authenticated-direct under one global result","decision":"keep","reason":"Concurrent real relay/direct installations commit one global result and one device despite different authorization modes."},{"line":115,"title":"rolls back token and invite effects when result persistence fails","decision":"keep","reason":"An injected result-insert failure rolls back actual device/token and invite mutations in SQLite."},{"line":155,"title":"renews only a tuple-bound current credential and replays its committed result","decision":"keep","reason":"A real installed/reserved current token confirms successfully, replays after basis deactivation and refuses a changed tuple."},{"line":209,"title":"leaves a now-grace version unchanged and rejects late, expired, and revoked tuples","decision":"keep","reason":"Actual rotation leaves accepted grace credentials unrenewed and distinguishes expired grace, revoked device and late basis rejection paths."}],"reviewed_sha256":"12570ddac3ae51f4ea015c4effd70c95bdd6830ce9084c1f602af0e74775fc3d","decision":"fix","rationale":"The real invite expiry stays independently below the released-client ten-minute ceiling; close its opened in-memory database, which this case currently leaks even on success."} +{"path":"cloud/apps/relay/src/database-connect-stall-postgres.test.ts","sha256":"dfa160d2467b14ce891a18ff2a9cba09adfa78c436aec4f3d7bab58e0db9da24","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts","cloud/apps/relay/src/postgres-pool-pressure.ts"],"cases":[{"line":33,"title":"fails every caller fast and retryably without stalling the event loop","decision":"fix","reason":"A real blackhole TCP listener drives six pool callers through bounded retryable acquire failure while an independent interval observes event-loop progress; register that observer interval in cleanup so assertions cannot leak it."},{"line":60,"title":"fails fast while the database is down or starting, then serves again","decision":"fix","reason":"A real PostgreSQL proxy refuses, blackholes and restores the wire while the same pool recovers; its event-loop observer also needs unconditional interval cleanup."}],"reviewed_sha256":"f2e196714898b1a51b10b659de90d2c0095284f1a45f155a3795d5bc074c744b","decision":"fix","rationale":"A real blackhole TCP listener drives six pool callers through bounded retryable acquire failure while an independent interval observes event-loop progress; register that observer interval in cleanup so assertions cannot leak it. A real PostgreSQL proxy refuses, blackholes and restores the wire while the same pool recovers; its event-loop observer also needs unconditional interval cleanup."} +{"path":"cloud/apps/relay/src/database-postgres-timeout.test.ts","sha256":"3497d7e6146ad6fd7a0051c9670d1f71946b867ca33b96615b265e08b8b1d367","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts","cloud/packages/postgres-schema/src/apply-postgres-schema.ts"],"cases":[{"line":78,"title":"bounds pool acquisition, statements, locks, and abandoned transactions","decision":"keep","reason":"Driver-boundary construction verifies serving/schema pool acquisition, SQL, query-reply, lock and idle deadlines remain bounded and separated."},{"line":107,"title":"closes the untimed schema pool before the serving pool opens","decision":"keep","reason":"Interleaved lifecycle observation proves the untimed schema pool closes before the serving pool exists."},{"line":123,"title":"applies the schema on the untimed pool, never on the serving one","decision":"fix","reason":"The collector currently records only pre-serving queries, so its title cannot detect extra DDL on the serving pool; collect both phases and explicitly reject serving DDL while retaining actual migration/catalog/backfill checks."},{"line":159,"title":"takes the serving statement deadline from the environment","decision":"keep","reason":"An environment override reaches the actual serving pool constructor with the corresponding bounded reply timeout."},{"line":174,"title":"refuses %s as a statement deadline instead of running unbounded","decision":"keep","reason":"Zero, negative, fractional, whitespace and nonnumeric SQL deadline inputs fail rather than disabling timeouts.","parameter_table":{"source":"['0', '-1', '2.5', 'soon', ' ']","rows":[{"index":1,"input":"'0'","decision":"keep","reason":"Zero, negative, fractional, whitespace and nonnumeric SQL deadline inputs fail rather than disabling timeouts."},{"index":2,"input":"'-1'","decision":"keep","reason":"Zero, negative, fractional, whitespace and nonnumeric SQL deadline inputs fail rather than disabling timeouts."},{"index":3,"input":"'2.5'","decision":"keep","reason":"Zero, negative, fractional, whitespace and nonnumeric SQL deadline inputs fail rather than disabling timeouts."},{"index":4,"input":"'soon'","decision":"keep","reason":"Zero, negative, fractional, whitespace and nonnumeric SQL deadline inputs fail rather than disabling timeouts."},{"index":5,"input":"' '","decision":"keep","reason":"Zero, negative, fractional, whitespace and nonnumeric SQL deadline inputs fail rather than disabling timeouts."}]}},{"line":183,"title":"takes the read timeout margin from the environment, defaulting to 10 s","decision":"keep","reason":"Read-timeout margin parsing handles defaults and rejects invalid values independently of the SQL deadline.","body_cases":[{"input":"0","decision":"keep","reason":"Invalid read-timeout margin fails configuration rather than disabling the deadline."},{"input":"-1","decision":"keep","reason":"Invalid read-timeout margin fails configuration rather than disabling the deadline."},{"input":"2.5","decision":"keep","reason":"Invalid read-timeout margin fails configuration rather than disabling the deadline."},{"input":"soon","decision":"keep","reason":"Invalid read-timeout margin fails configuration rather than disabling the deadline."}]},{"line":195,"title":"defaults to 5s when the environment says %s","decision":"keep","reason":"Absent and empty SQL deadline variables use the bounded default.","parameter_table":{"source":"[undefined, '']","rows":[{"index":1,"input":"undefined","decision":"keep","reason":"Absent and empty SQL deadline variables use the bounded default."},{"index":2,"input":"''","decision":"keep","reason":"Absent and empty SQL deadline variables use the bounded default."}]}},{"line":206,"title":"retries a statement timeout on a fresh client","decision":"fix","reason":"The real transaction retry loop commits after one injected 57014; narrow the fresh-client title unless client identity is explicitly observed, since current assertions only establish retry/outcome."},{"line":236,"title":"retries statement timeouts with bounded backoff","decision":"keep","reason":"Injected schema timeouts retry with independent deterministic backoff values."},{"line":256,"title":"fails the boot on a lock timeout instead of re-entering the lock queue","decision":"keep","reason":"A lock timeout fails once without requeueing DDL and emits the specific boot diagnostic."},{"line":281,"title":"retries only the PostgreSQL concurrent type-creation collision","decision":"keep","reason":"An idempotent table create retries the exact pg_type catalog collision."},{"line":299,"title":"retries only the PostgreSQL concurrent index-creation collision","decision":"keep","reason":"An idempotent index create retries the exact pg_class catalog collision."},{"line":317,"title":"retries the committed-winner %s collision for %s","decision":"keep","reason":"The table/index committed-winner collision matrix exercises permitted idempotent retries through the real classifier.","parameter_table":{"source":"[\n ['42710', 'CREATE TABLE IF NOT EXISTS test'],\n ['42P07', 'CREATE TABLE IF NOT EXISTS test'],\n ['42P07', 'CREATE INDEX IF NOT EXISTS test_index ON test(id)'],\n ['42P07', 'CREATE UNIQUE INDEX IF NOT EXISTS test_index ON test(id)']\n ]","rows":[{"index":1,"input":"['42710', 'CREATE TABLE IF NOT EXISTS test']","decision":"keep","reason":"The table/index committed-winner collision matrix exercises permitted idempotent retries through the real classifier."},{"index":2,"input":"['42P07', 'CREATE TABLE IF NOT EXISTS test']","decision":"keep","reason":"The table/index committed-winner collision matrix exercises permitted idempotent retries through the real classifier."},{"index":3,"input":"['42P07', 'CREATE INDEX IF NOT EXISTS test_index ON test(id)']","decision":"keep","reason":"The table/index committed-winner collision matrix exercises permitted idempotent retries through the real classifier."},{"index":4,"input":"['42P07', 'CREATE UNIQUE INDEX IF NOT EXISTS test_index ON test(id)']","decision":"keep","reason":"The table/index committed-winner collision matrix exercises permitted idempotent retries through the real classifier."}]}},{"line":335,"title":"treats an existing constraint as an applied ADD CONSTRAINT","decision":"keep","reason":"An already-applied ADD CONSTRAINT skips the duplicate error without pausing and continues to the next migration."},{"line":356,"title":"recognises every shipped ADD CONSTRAINT migration as re-runnable","decision":"keep","reason":"Actual shipped ADD CONSTRAINT statements are fed through the real startup classifier, ensuring their syntax is recognized as idempotently already applied."},{"line":370,"title":"still fails an ADD CONSTRAINT that violates existing rows","decision":"keep","reason":"A real classifier check violation remains fatal even for an ADD CONSTRAINT statement."},{"line":383,"title":"does not retry %s for %s","decision":"keep","reason":"Near-miss collision/statement pairs fail rather than gaining unsafe retries.","parameter_table":{"source":"[\n ['42710', 'CREATE INDEX IF NOT EXISTS test_index ON test(id)'],\n ['42710', 'CREATE TABLE test'],\n ['42P07', 'CREATE TABLE test'],\n ['42P07', 'CREATE INDEX test_index ON test(id)']\n ]","rows":[{"index":1,"input":"['42710', 'CREATE INDEX IF NOT EXISTS test_index ON test(id)']","decision":"keep","reason":"Near-miss collision/statement pairs fail rather than gaining unsafe retries."},{"index":2,"input":"['42710', 'CREATE TABLE test']","decision":"keep","reason":"Near-miss collision/statement pairs fail rather than gaining unsafe retries."},{"index":3,"input":"['42P07', 'CREATE TABLE test']","decision":"keep","reason":"Near-miss collision/statement pairs fail rather than gaining unsafe retries."},{"index":4,"input":"['42P07', 'CREATE INDEX test_index ON test(id)']","decision":"keep","reason":"Near-miss collision/statement pairs fail rather than gaining unsafe retries."}]}},{"line":398,"title":"does not retry %s for non-idempotent DDL","decision":"keep","reason":"Catalog collisions do not permit retrying non-idempotent table/index DDL.","parameter_table":{"source":"[\n ['pg_type_typname_nsp_index', 'CREATE TABLE test'],\n ['pg_class_relname_nsp_index', 'CREATE INDEX test_index ON test(id)']\n ]","rows":[{"index":1,"input":"['pg_type_typname_nsp_index', 'CREATE TABLE test']","decision":"keep","reason":"Catalog collisions do not permit retrying non-idempotent table/index DDL."},{"index":2,"input":"['pg_class_relname_nsp_index', 'CREATE INDEX test_index ON test(id)']","decision":"keep","reason":"Catalog collisions do not permit retrying non-idempotent table/index DDL."}]}},{"line":416,"title":"does not retry unrelated unique violations","decision":"keep","reason":"An unrelated unique constraint violation cannot be mistaken for a concurrent schema winner."},{"line":431,"title":"fails immediately for non-timeout schema errors","decision":"keep","reason":"Permission failure propagates immediately without consuming retry delay."},{"line":444,"title":"stops retrying at the shared startup deadline","decision":"keep","reason":"A shared fake-clock deadline across multiple statements truncates backoff and reports retry exhaustion."}],"reviewed_sha256":"910caabb96ac8a196c182df07322b589a74645e35463663928926738a5df3a32","decision":"fix","rationale":"The collector currently records only pre-serving queries, so its title cannot detect extra DDL on the serving pool; collect both phases and explicitly reject serving DDL while retaining actual migration/catalog/backfill checks. The real transaction retry loop commits after one injected 57014; narrow the fresh-client title unless client identity is explicitly observed, since current assertions only establish retry/outcome."} +{"path":"cloud/apps/relay/src/database-statement-timeout-postgres.test.ts","sha256":"4377fdb2b495aa3eba9370de9d53c365b15e746d843de7b2f15e931da70ede50","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts","cloud/packages/postgres-schema/src/apply-postgres-schema.ts"],"cases":[{"line":19,"title":"serves requests under the configured deadline","decision":"remove","reason":"Remove this current_setting-only check: the next real 300ms pg_sleep cancellation/retry already proves that configured deadline governs queries, and the pool-construction suite separately checks configuration wiring."},{"line":31,"title":"retries a real statement timeout on a fresh client","decision":"fix","reason":"A real PostgreSQL statement exceeds its 300ms deadline then succeeds on retry; narrow fresh-client wording because the case does not observe a distinct backend/client identity."},{"line":50,"title":"boots without queueing behind a held ACCESS EXCLUSIVE lock","decision":"fix","reason":"Actual schema boot completes while another session holds ACCESS EXCLUSIVE, proving catalog prechecks avoid DDL queueing; release/drain the holder in finally even if boot or assertions fail."}],"reviewed_sha256":"8a767423720af5eea5f35e0bd0fce73a9849c47a105659f7688bdbf22c8bf362","decision":"consolidate","rationale":"Remove this current_setting-only check: the next real 300ms pg_sleep cancellation/retry already proves that configured deadline governs queries, and the pool-construction suite separately checks configuration wiring. A real PostgreSQL statement exceeds its 300ms deadline then succeeds on retry; narrow fresh-client wording because the case does not observe a distinct backend/client identity. Actual schema boot completes while another session holds ACCESS EXCLUSIVE, proving catalog prechecks avoid DDL queueing; release/drain the holder in finally even if boot or assertions fail."} +{"path":"cloud/apps/relay/src/database-transient-error.test.ts","sha256":"76729a1363b84aabad8b0dbb17489e17aa8c1f60a77dd50657f55d1894c07ef2","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts","cloud/apps/relay/src/postgres-pool-pressure.ts"],"cases":[{"line":39,"title":"classifies PostgreSQL code %s as retryable overload","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories.","parameter_table":{"source":"[\n '40P01',\n '40001',\n '55P03',\n '57014',\n '53300',\n '57P01',\n '57P02',\n '57P03',\n '08000',\n '08001',\n '08003',\n '08006',\n '25P03'\n ]","rows":[{"index":1,"input":"'40P01'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":2,"input":"'40001'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":3,"input":"'55P03'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":4,"input":"'57014'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":5,"input":"'53300'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":6,"input":"'57P01'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":7,"input":"'57P02'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":8,"input":"'57P03'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":9,"input":"'08000'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":10,"input":"'08001'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":11,"input":"'08003'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":12,"input":"'08006'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."},{"index":13,"input":"'25P03'","decision":"keep","reason":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories."}]}},{"line":60,"title":"classifies pool acquisition timeout without hiding programming failures","decision":"keep","reason":"Pool acquisition timeout is retryable while an unrelated programming TypeError remains fatal."},{"line":67,"title":"classifies a pool connect timeout that node-postgres reports with no code","decision":"keep","reason":"The driver handshake timeout without SQLSTATE is correctly recognized."},{"line":76,"title":"classifies an early-ended socket during the acquire","decision":"keep","reason":"A real pressure-wrapper acquire failure marks an early-ended connection as retryable."},{"line":83,"title":"classifies an acquire that failed with %s, but not the bare errno","decision":"keep","reason":"Socket errno failures count only after the actual acquire boundary marks them; identical bare errors remain untrusted.","parameter_table":{"source":"['EPIPE', 'ECONNRESET', 'ECONNREFUSED', 'ETIMEDOUT', 'EHOSTUNREACH']","rows":[{"index":1,"input":"'EPIPE'","decision":"keep","reason":"Socket errno failures count only after the actual acquire boundary marks them; identical bare errors remain untrusted."},{"index":2,"input":"'ECONNRESET'","decision":"keep","reason":"Socket errno failures count only after the actual acquire boundary marks them; identical bare errors remain untrusted."},{"index":3,"input":"'ECONNREFUSED'","decision":"keep","reason":"Socket errno failures count only after the actual acquire boundary marks them; identical bare errors remain untrusted."},{"index":4,"input":"'ETIMEDOUT'","decision":"keep","reason":"Socket errno failures count only after the actual acquire boundary marks them; identical bare errors remain untrusted."},{"index":5,"input":"'EHOSTUNREACH'","decision":"keep","reason":"Socket errno failures count only after the actual acquire boundary marks them; identical bare errors remain untrusted."}]}},{"line":92,"title":"classifies an EPIPE from the transaction acquire","decision":"keep","reason":"Transaction acquisition routes a marked EPIPE through the actual database wrapper and overload classifier."},{"line":109,"title":"classifies a mid-statement drop only from the database layer","decision":"keep","reason":"Actual database query failure marks dropped sockets while identical errors from other sockets stay outside the database retry classification.","body_cases":[{"input":{"failure":"Connection terminated unexpectedly","source":"database-tagged"},"decision":"keep","reason":"Database-owned midstatement failures are retryable responses; identical raw socket failures are not classified as database overload."},{"input":{"failure":"Connection terminated unexpectedly","source":"raw-socket"},"decision":"keep","reason":"Database-owned midstatement failures are retryable responses; identical raw socket failures are not classified as database overload."},{"input":{"failure":"ECONNRESET","source":"database-tagged"},"decision":"keep","reason":"Database-owned midstatement failures are retryable responses; identical raw socket failures are not classified as database overload."},{"input":{"failure":"ECONNRESET","source":"raw-socket"},"decision":"keep","reason":"Database-owned midstatement failures are retryable responses; identical raw socket failures are not classified as database overload."},{"input":{"failure":"EPIPE","source":"database-tagged"},"decision":"keep","reason":"Database-owned midstatement failures are retryable responses; identical raw socket failures are not classified as database overload."},{"input":{"failure":"EPIPE","source":"raw-socket"},"decision":"keep","reason":"Database-owned midstatement failures are retryable responses; identical raw socket failures are not classified as database overload."}]},{"line":122,"title":"survives %s reaching it instead of an error object","decision":"keep","reason":"Null, undefined and thrown strings cannot crash the error classifier.","parameter_table":{"source":"[null, undefined, 'a thrown string']","rows":[{"index":1,"input":"null","decision":"keep","reason":"Null, undefined and thrown strings cannot crash the error classifier."},{"index":2,"input":"undefined","decision":"keep","reason":"Null, undefined and thrown strings cannot crash the error classifier."},{"index":3,"input":"'a thrown string'","decision":"keep","reason":"Null, undefined and thrown strings cannot crash the error classifier."}]}},{"line":129,"title":"keeps a failed acquire that is not transient out of the retry path","decision":"keep","reason":"A marked acquire authentication failure remains permanent rather than turning into overload."}],"reviewed_sha256":"76729a1363b84aabad8b0dbb17489e17aa8c1f60a77dd50657f55d1894c07ef2","decision":"keep","rationale":"The explicit SQLSTATE matrix protects the public overload classifier across transaction, proxy, shutdown and connection failure categories. Pool acquisition timeout is retryable while an unrelated programming TypeError remains fatal. The driver handshake timeout without SQLSTATE is correctly recognized. A real pressure-wrapper acquire failure marks an early-ended connection as retryable. Socket errno failures count only after the actual acquire boundary marks them; identical bare errors remain untrusted. Transaction acquisition routes a marked EPIPE through the actual database wrapper and overload classifier. Actual database query failure marks dropped sockets while identical errors from other sockets stay outside the database retry classification. Null, undefined and thrown strings cannot crash the error classifier. A marked acquire authentication failure remains permanent rather than turning into overload."} +{"path":"cloud/apps/relay/src/database.test.ts","sha256":"11a4c7be7489e24733be81606073ef432a683e5ba03b1c4441fb266a64888788","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts"],"cases":[{"line":21,"title":"upgrades an existing SQLite relay without treating legacy controls as idle-capable","decision":"keep","reason":"An actual on-disk SQLite upgrade adds missing legacy columns with safe disabled defaults and leaves old controls unable to claim idle capability."},{"line":49,"title":"creates every durable relay state table","decision":"remove","reason":"Remove the exact durable-table name inventory; the real store suites exercise schema usage and fail when their required tables are absent."},{"line":101,"title":"rolls back every effect and serializes concurrent transactions","decision":"keep","reason":"A real failing SQLite transaction rolls back its insert, and concurrent transactions serialize read-modify-write to two."},{"line":141,"title":"persists SQLite state across process-style reopen","decision":"keep","reason":"State written to an actual SQLite file survives close/reopen."},{"line":157,"title":"defaults cells created by an older schema user to the US on reopen","decision":"keep","reason":"A legacy-style cell insert receives its US region backfill during actual reopen."},{"line":177,"title":"renders every region check from the shared region list","decision":"fix","reason":"Replace copied SQL region-list substring checks with actual allowed-region inserts and invalid-region rejection across the affected tables, so the test exercises constraints instead of DDL text."},{"line":199,"title":"indexes rehome attempts by host recency for the per-host cooldown","decision":"remove","reason":"Remove the index-DDL substring and cooldown constant inventory; actual cooldown behavior is reviewed in idle-regional-rehome-window rather than proved by a copied index definition."},{"line":210,"title":"indexes region preference expiry by observation time","decision":"remove","reason":"Remove this index-DDL substring check; it only inventories schema text without proving query planning or expiry behavior."}],"reviewed_sha256":"e12b26f76368231c088b786be743102a166591da866c311aedec693489d4f41a","decision":"consolidate","rationale":"Remove the exact durable-table name inventory; the real store suites exercise schema usage and fail when their required tables are absent. Replace copied SQL region-list substring checks with actual allowed-region inserts and invalid-region rejection across the affected tables, so the test exercises constraints instead of DDL text. Remove the index-DDL substring and cooldown constant inventory; actual cooldown behavior is reviewed in idle-regional-rehome-window rather than proved by a copied index definition. Remove this index-DDL substring check; it only inventories schema text without proving query planning or expiry behavior."} +{"path":"cloud/apps/relay/src/dead-cell-evacuation-precheck.test.ts","sha256":"fa3acbdf0094e45a46d5482e5809a100744761471b17368520c4231b46f66a89","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":116,"title":"skips the host query when the only dead cell is unfenced and existing-only","decision":"keep","reason":"Real SQLite/PostgreSQL existing-only stale-cell state returns no evacuation, avoids the expensive host query and preserves the authoritative assignment."},{"line":138,"title":"still evacuates hosts from a dead uncapped cell that admits","decision":"keep","reason":"A genuinely admitting dead uncapped cell still reaches the host query and moves the actual assignment to its live peer."}],"reviewed_sha256":"fa3acbdf0094e45a46d5482e5809a100744761471b17368520c4231b46f66a89","decision":"keep","rationale":"Real SQLite/PostgreSQL existing-only stale-cell state returns no evacuation, avoids the expensive host query and preserves the authoritative assignment. A genuinely admitting dead uncapped cell still reaches the host query and moves the actual assignment to its live peer."} +{"path":"cloud/apps/relay/src/dead-relay-tables-postgres.test.ts","sha256":"f5d97ad3278402e7715928edaaac1d326c26478f583d31c836cc600a230dd25e","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts"],"cases":[{"line":62,"title":"does not create the removed tables on a fresh database","decision":"remove","reason":"Remove the negative inventory of three unused table names; no user behavior or active store operation depends on their absence."},{"line":70,"title":"boots on a database an older image created, leaving those tables alone","decision":"keep","reason":"Real PostgreSQL schema boot remains compatible with three tables left by older images and preserves those existing tables."}],"reviewed_sha256":"956a752584134198451aa2c11f2470bab4d2a360487b909e57b61c4cda876758","decision":"consolidate","rationale":"Remove the negative inventory of three unused table names; no user behavior or active store operation depends on their absence."} +{"path":"cloud/apps/relay/src/director-reserve-placement-status.test.ts","sha256":"59253d3a7b73cddb6eeba362e73e16ec0821fc61a6a4059b36949b0043927ddf","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/app.ts"],"cases":[{"line":38,"title":"says off when placement is configured on but was never built","decision":"keep","reason":"An actual runtime-status request reports off when configuration requests on but no placement implementation was built."},{"line":42,"title":"says what the built placement does","decision":"fix","reason":"Make desired configuration disagree with the built placement (or construct the actual placement object); currently both are on, so reading the wrong source still passes the claimed as-built check."},{"line":48,"title":"reports nothing for a cell","decision":"keep","reason":"A cell runtime response omits the director-only reserve placement field."}],"reviewed_sha256":"7c3bab48bcbdfa90e3db6fb4a22537322aaaf7a54e1c12e499225ccd3dd1f770","decision":"fix","rationale":"Make desired configuration disagree with the built placement (or construct the actual placement object); currently both are on, so reading the wrong source still passes the claimed as-built check."} +{"path":"cloud/apps/relay/src/drain-migration-row-lookup.test.ts","sha256":"783947cca8f9db3e0fdec0f5c56cdb8c9c422cf5d3db1a7a2bb592cab14b26fb","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/drain-migration-row-lookup.ts","cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":13,"title":"keeps first assignment matches, lease order, row identity, and separate identity components","decision":"keep","reason":"Independent delimiter-collision, duplicate and empty identity examples preserve first-row/object identity and all-row order through the real lookup."},{"line":37,"title":"retains lazy validation and short circuiting when an inventory is malformed","decision":"keep","reason":"Malformed-row fallback preserves lazy validation and short-circuit behavior rather than eager rejection of unrelated bad fields."},{"line":56,"title":"does not share an index between refreshed inventories","decision":"keep","reason":"Two refreshed inventories with the same identity return their own row objects, detecting accidental cross-inventory cache reuse quickly."}],"reviewed_sha256":"783947cca8f9db3e0fdec0f5c56cdb8c9c422cf5d3db1a7a2bb592cab14b26fb","decision":"keep","rationale":"Independent delimiter-collision, duplicate and empty identity examples preserve first-row/object identity and all-row order through the real lookup. Malformed-row fallback preserves lazy validation and short-circuit behavior rather than eager rejection of unrelated bad fields. Two refreshed inventories with the same identity return their own row objects, detecting accidental cross-inventory cache reuse quickly."} +{"path":"cloud/apps/relay/src/drain-migration-row-scaling.test.ts","sha256":"2adabae89beee885a85d5a58dedfb9e3d3379b6d0045edd088ec399e4023a76c","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/drain-migration-row-lookup.ts","cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":9,"title":"looks up a whole drain inventory with linear identity reads (expired: %s)","decision":"keep","reason":"Fifty actual migrations run beginCellDrainSend for active and expired inventories; instrumented row getters bound identity work linearly while durable migration expiries confirm real processing, avoiding a wall-clock microbenchmark.","parameter_table":{"source":"[false, true]","rows":[{"index":1,"input":"false","decision":"keep","reason":"Fifty actual migrations run beginCellDrainSend for active and expired inventories; instrumented row getters bound identity work linearly while durable migration expiries confirm real processing, avoiding a wall-clock microbenchmark."},{"index":2,"input":"true","decision":"keep","reason":"Fifty actual migrations run beginCellDrainSend for active and expired inventories; instrumented row getters bound identity work linearly while durable migration expiries confirm real processing, avoiding a wall-clock microbenchmark."}]}}],"reviewed_sha256":"2adabae89beee885a85d5a58dedfb9e3d3379b6d0045edd088ec399e4023a76c","decision":"keep","rationale":"Fifty actual migrations run beginCellDrainSend for active and expired inventories; instrumented row getters bound identity work linearly while durable migration expiries confirm real processing, avoiding a wall-clock microbenchmark."} +{"path":"cloud/apps/relay/src/drain-release-cell-row-contention-postgres.test.ts","sha256":"0dc9fe610ebe8ec298c0d61fcd27bc9fc4e0c6cdfdd5ff745e529a36564b518a","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/public-assignment-admission.ts","cloud/apps/relay/src/test-fixtures/delayed-postgres-database.ts"],"cases":[{"line":681,"title":"keeps placing during a paced drain when the cells are next to the database","decision":"fix","reason":"Retain actual PostgreSQL pacing/lock-contention regression for both release rates; propagate unexpected rejected paced tasks and assert accounted/progress outcomes, with sampler/delay cleanup in finally, so thrown admission work cannot yield an empty passing report.","body_cases":[{"input":{"release_rate":6,"rtt_ms":1},"decision":"fix","reason":"Real paced PostgreSQL drain and dial work must make accounted progress while keeping failures, admission rejections and lock waits bounded."},{"input":{"release_rate":18,"rtt_ms":1},"decision":"fix","reason":"Real paced PostgreSQL drain and dial work must make accounted progress while keeping failures, admission rejections and lock waits bounded."}]},{"line":692,"title":"keeps placing while an Asia drain holds the source row","decision":"fix","reason":"Retain actual cross-region RTT, capped-neighbour and release-completion regressions; inspect every allSettled rejection and assert placement progress/accounting rather than allowing missing work to satisfy zero-failure tallies; ensure sampler/delay cleanup on failure.","body_cases":[{"input":{"release_rate":6,"rtt_ms":171,"neighbours_capped":false},"decision":"fix","reason":"Real cross-region round trips exercise release contention, independent director placement and capped-neighbour behavior."},{"input":{"release_rate":18,"rtt_ms":171,"neighbours_capped":false},"decision":"fix","reason":"Real cross-region round trips exercise release contention, independent director placement and capped-neighbour behavior."},{"input":{"release_rate":18,"rtt_ms":171,"neighbours_capped":true},"decision":"fix","reason":"Real cross-region round trips exercise release contention, independent director placement and capped-neighbour behavior."}]},{"line":715,"title":"re-places departing hosts that redial after their own release","decision":"fix","reason":"Retain real own-release/redial contention at all six delay/cap combinations and bounded second-dial/p95 outcomes; make paced-task failures and sampler/delay cleanup unconditional rather than silently losing rejected work.","body_cases":[{"input":{"neighbours_capped":false,"dial_delay_ms":150},"decision":"fix","reason":"A departing host redials after its own release; actual PostgreSQL outcomes bound retries, second refusals and placement latency."},{"input":{"neighbours_capped":false,"dial_delay_ms":400},"decision":"fix","reason":"A departing host redials after its own release; actual PostgreSQL outcomes bound retries, second refusals and placement latency."},{"input":{"neighbours_capped":false,"dial_delay_ms":1000},"decision":"fix","reason":"A departing host redials after its own release; actual PostgreSQL outcomes bound retries, second refusals and placement latency."},{"input":{"neighbours_capped":true,"dial_delay_ms":150},"decision":"fix","reason":"A departing host redials after its own release; actual PostgreSQL outcomes bound retries, second refusals and placement latency."},{"input":{"neighbours_capped":true,"dial_delay_ms":400},"decision":"fix","reason":"A departing host redials after its own release; actual PostgreSQL outcomes bound retries, second refusals and placement latency."},{"input":{"neighbours_capped":true,"dial_delay_ms":1000},"decision":"fix","reason":"A departing host redials after its own release; actual PostgreSQL outcomes bound retries, second refusals and placement latency."}]}],"reviewed_sha256":"e45ed3017e70377493a84776e8b3f3e80a14ea468df320c164514d25fc2e0166","decision":"fix","rationale":"Retain actual PostgreSQL pacing/lock-contention regression for both release rates; propagate unexpected rejected paced tasks and assert accounted/progress outcomes, with sampler/delay cleanup in finally, so thrown admission work cannot yield an empty passing report. Retain actual cross-region RTT, capped-neighbour and release-completion regressions; inspect every allSettled rejection and assert placement progress/accounting rather than allowing missing work to satisfy zero-failure tallies; ensure sampler/delay cleanup on failure. Retain real own-release/redial contention at all six delay/cap combinations and bounded second-dial/p95 outcomes; make paced-task failures and sampler/delay cleanup unconditional rather than silently losing rejected work."} +{"path":"cloud/apps/relay/src/drain-return-admission.test.ts","sha256":"6d1902ea12f44ea8fb75f532582eb1f9bef02a82679c84c60ca0b676c9b7e2c2","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/drain-return-admission.ts","cloud/apps/relay/src/public-assignment-admission.ts"],"cases":[{"line":71,"title":"admits up to its concurrency and defers the rest with a paced Retry-After","decision":"keep","reason":"Real admission permits impose the independently specified two-grant limit and ordered paced Retry-After sequence for rejected hosts."},{"line":86,"title":"gives the same answers to the same arrivals","decision":"keep","reason":"Repeated deterministic arrival/expiry schedules produce identical complete decision sequences, protecting reserved cohort-slot consumption."},{"line":111,"title":"never asks a host to wait longer than the configured ceiling","decision":"keep","reason":"A configured retry ceiling bounds actual rejection results even under a large measured release backlog."},{"line":123,"title":"shortens the pacing once the measured service time is short","decision":"keep","reason":"Thirty short measured releases alter subsequent retry answers, proving service-time feedback changes pacing."},{"line":144,"title":"reports each slot hold once, as measured","decision":"keep","reason":"Repeated releases report each original 5ms/20000ms slot hold exactly once to the observer."},{"line":158,"title":"answers a host\u2019s own early retry with its interval, not a place behind the cohort","decision":"keep","reason":"A host retry inside its own minimum interval receives its own remaining delay without reserving another cohort position."},{"line":174,"title":"keeps a host\u2019s reserved slot when it comes back early","decision":"keep","reason":"An early returning host retains and counts down its previously reserved cohort slot instead of rebooking behind later arrivals."},{"line":185,"title":"never holds placement\u2019s last permit","decision":"keep","reason":"Drain returns never borrow the final placement permit, as independently observed through a successful real placement acquisition."},{"line":193,"title":"lets a queued placement go before a queued drain return","decision":"keep","reason":"A queued placement receives the released permit before a queued drain return, which is granted only after placement releases it."}],"reviewed_sha256":"6d1902ea12f44ea8fb75f532582eb1f9bef02a82679c84c60ca0b676c9b7e2c2","decision":"keep","rationale":"Real admission permits impose the independently specified two-grant limit and ordered paced Retry-After sequence for rejected hosts. Repeated deterministic arrival/expiry schedules produce identical complete decision sequences, protecting reserved cohort-slot consumption. A configured retry ceiling bounds actual rejection results even under a large measured release backlog. Thirty short measured releases alter subsequent retry answers, proving service-time feedback changes pacing. Repeated releases report each original 5ms/20000ms slot hold exactly once to the observer. A host retry inside its own minimum interval receives its own remaining delay without reserving another cohort position. An early returning host retains and counts down its previously reserved cohort slot instead of rebooking behind later arrivals. Drain returns never borrow the final placement permit, as independently observed through a successful real placement acquisition. A queued placement receives the released permit before a queued drain return, which is granted only after placement releases it."} +{"path":"cloud/apps/relay/src/floating-promise-census.test.ts","sha256":"5364ef8bf1e5e18aed2795ed0ab32ee7a8021e79f6218f2eabe2adae2141380b","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/floating-promise-census.test.ts"],"cases":[{"line":160,"title":"finds none in production code","decision":"fix","reason":"Keep actual TypeScript-type-aware production census with positive compiler controls; replace the arbitrary >500 source-count assertion with meaningful nonempty/type-resolution evidence because file growth is not promise safety."},{"line":168,"title":"flags each floating shape and accepts the handled ones","decision":"keep","reason":"Real compiler positive and negative snippets exercise six floating forms and five explicitly handled forms; this is an executable analyzer check rather than a source-string inventory.","body_cases":[{"input":{"shape":"db.query('x')","floating":true},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"void db.query('x')","floating":true},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"void wrapper()","floating":true},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"db.query('x').then(() => 1)","floating":true},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"setTimeout(() => db.query('x'), 1)","floating":true},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"export function f() { const pending = db.query('x') }","floating":true},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"export async function f() { await db.query('x') }","floating":false},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"void db.query('x').catch(() => undefined)","floating":false},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"void db.query('x').then(() => 1, () => 2)","floating":false},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"export async function f() { const pending = db.query('x'); await pending }","floating":false},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."},{"input":{"shape":"export const g = () => db.query('x')","floating":false},"decision":"keep","reason":"Actual TypeScript compiler/type-checker controls prove floating-promise shape detection and handled-promise exclusions."}]}],"reviewed_sha256":"a863b2eb430294bd4846bc02759000cda99e3701eed66ba07be52805968e6664","decision":"fix","rationale":"Keep actual TypeScript-type-aware production census with positive compiler controls; replace the arbitrary >500 source-count assertion with meaningful nonempty/type-resolution evidence because file growth is not promise safety."} +{"path":"cloud/apps/relay/src/host-close-reason-memory.test.ts","sha256":"20bbb0d25f0de972fc9419975b87bbbabe706ff41bf3c64efa19fd9a3ecba039","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-close-reason-memory.ts"],"cases":[{"line":10,"title":"remembers only reasons it knows","decision":"keep","reason":"Known close reasons are retained and unrelated or untrusted reasons cannot create a remembered verdict."},{"line":25,"title":"accepts the reason as the Buffer a ws close delivers","decision":"keep","reason":"Actual ws-style Buffer reason input is decoded into the remembered signed-out reason."},{"line":34,"title":"expires an entry once its host may have been rebalanced away","decision":"keep","reason":"Injected-clock checks exercise dormant TTL expiry and remove the expired entry."},{"line":47,"title":"forgets on demand","decision":"keep","reason":"Explicit forget removes the host verdict while another host remains available."},{"line":57,"title":"drops the oldest survivors rather than growing without bound","decision":"keep","reason":"Overflow of the actual bounded map evicts oldest survivors while retaining current entries."},{"line":69,"title":"re-recording refreshes recency so a live host is not evicted first","decision":"fix","reason":"Current record(a), record(b), record(a) checks only size and presence, never eviction; fill the actual cap, refresh the oldest host, overflow it and assert the older unrefreshed host is evicted while the refreshed host survives."}],"reviewed_sha256":"92da427416a1f2d55121eacfed26027e18e8bdb44e8f5b297801edb4ffad6e9e","decision":"fix","rationale":"Current record(a), record(b), record(a) checks only size and presence, never eviction; fill the actual cap, refresh the oldest host, overflow it and assert the older unrefreshed host is evicted while the refreshed host survives."} +{"path":"cloud/apps/relay/src/host-control-proof-cleanup.test.ts","sha256":"16ebfdec0a7e542316c27b0d53ff319c614c3dffd09feb086dde54042ace1705","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/test-fixtures/host-control-proof.ts"],"cases":[{"line":19,"title":"allocates no hello stage for an already closed peer","decision":"keep","reason":"Already closed peers allocate neither a hello timer nor stage listeners and never initiate verification."},{"line":30,"title":"releases the host hello timer and listeners when its peer closes early","decision":"keep","reason":"Peer closure before hello removes the active hello timer/listeners and prevents assignment work."},{"line":48,"title":"preserves the exact hello deadline and refusal while releasing its message listener","decision":"keep","reason":"Fake-clock 1999ms/1ms deadline checks establish exact hello timeout, fixed refusal and listener disposal."},{"line":63,"title":"releases the challenge timer and listeners when its peer closes before proof","decision":"keep","reason":"Closing during encrypted proof removes only that stage timer/listeners without activation."},{"line":80,"title":"preserves the exact proof deadline and refusal with no leftover listener","decision":"keep","reason":"Fake-clock 9999ms/1ms proof timeout preserves refusal and frees the message listener."},{"line":95,"title":"does no challenge crypto, send, timer or registration after a closed peer finishes verification","decision":"keep","reason":"Deferred assignment verification resolves after peer closure without generating challenge crypto, sends, timers or registration."},{"line":122,"title":"preserves invalid first-frame refusal (binary=%s)","decision":"keep","reason":"Text-invalid and binary first frames both exercise their real bad-credential refusal paths and leave no active hello stage.","parameter_table":{"source":"[false, true]","rows":[{"index":1,"input":"false","decision":"keep","reason":"Text-invalid and binary first frames both exercise their real bad-credential refusal paths and leave no active hello stage."},{"index":2,"input":"true","decision":"keep","reason":"Text-invalid and binary first frames both exercise their real bad-credential refusal paths and leave no active hello stage."}]}},{"line":136,"title":"preserves invalid proof authentication failure (binary=%s)","decision":"keep","reason":"Text-invalid and binary proof frames exercise authentication failure and release the proof wait.","parameter_table":{"source":"[false, true]","rows":[{"index":1,"input":"false","decision":"keep","reason":"Text-invalid and binary proof frames exercise authentication failure and release the proof wait."},{"index":2,"input":"true","decision":"keep","reason":"Text-invalid and binary proof frames exercise authentication failure and release the proof wait."}]}},{"line":153,"title":"allocates no proof wait when sending the challenge closes its peer","decision":"keep","reason":"Synchronous closure while sending the real encrypted challenge cannot allocate a fresh proof wait."},{"line":164,"title":"keeps the existing diagnostic and refusal when challenge send throws","decision":"keep","reason":"Thrown challenge send is contained with the expected fixed refusal/diagnostic and no leaked proof timer."},{"line":183,"title":"contains assignment lookup rejection with its existing close and diagnostic","decision":"keep","reason":"Thrown assignment verification is contained to one peer with fixed refusal/diagnostic and stage cleanup."},{"line":202,"title":"keeps a newer same-host peer live when the old proof peer closes","decision":"keep","reason":"Closing an old proof-stage peer cannot kill its successor; successor decrypts and authenticates the actual challenge, activates and drains cleanly."}],"reviewed_sha256":"16ebfdec0a7e542316c27b0d53ff319c614c3dffd09feb086dde54042ace1705","decision":"keep","rationale":"Already closed peers allocate neither a hello timer nor stage listeners and never initiate verification. Peer closure before hello removes the active hello timer/listeners and prevents assignment work. Fake-clock 1999ms/1ms deadline checks establish exact hello timeout, fixed refusal and listener disposal. Closing during encrypted proof removes only that stage timer/listeners without activation. Fake-clock 9999ms/1ms proof timeout preserves refusal and frees the message listener. Deferred assignment verification resolves after peer closure without generating challenge crypto, sends, timers or registration. Text-invalid and binary first frames both exercise their real bad-credential refusal paths and leave no active hello stage. Text-invalid and binary proof frames exercise authentication failure and release the proof wait. Synchronous closure while sending the real encrypted challenge cannot allocate a fresh proof wait. Thrown challenge send is contained with the expected fixed refusal/diagnostic and no leaked proof timer. Thrown assignment verification is contained to one peer with fixed refusal/diagnostic and stage cleanup. Closing an old proof-stage peer cannot kill its successor; successor decrypts and authenticates the actual challenge, activates and drains cleanly."} +{"path":"cloud/apps/relay/src/host-control-resume-identity.test.ts","sha256":"0a47bbf7d4f824734be27e7851e8cd871531b3fe402a2ca9e665c5a81606320d","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/test-fixtures/host-control-proof.ts"],"cases":[{"line":86,"title":"keeps the resumed control past the heartbeat that expired its predecessor","decision":"keep","reason":"A token-expired orphan completes real cryptographic resume, retains its generation/session, adopts the verified new expiry and survives multiple heartbeats."},{"line":105,"title":"keeps a later expiry a refresh delivered over an older token the hello carried","decision":"fix","reason":"Preserve monotone expiry across a real rebind, but drive the later expiry through an actual verified auth-refresh (or a valid initially longer token) rather than assigning session.identity directly while claiming a refresh delivered it."},{"line":117,"title":"starts a new generation when the hello speaks for another %s","decision":"keep","reason":"Profile and organization identity changes both prove real host identity and require a replacement generation rather than inheriting an orphan resume secret.","parameter_table":{"source":"[\n ['profile', { prof: 'profile-other' }],\n ['organization', { org: 'org-other' }]\n ]","rows":[{"index":1,"input":"['profile', { prof: 'profile-other' }]","decision":"keep","reason":"Profile and organization identity changes both prove real host identity and require a replacement generation rather than inheriting an orphan resume secret."},{"index":2,"input":"['organization', { org: 'org-other' }]","decision":"keep","reason":"Profile and organization identity changes both prove real host identity and require a replacement generation rather than inheriting an orphan resume secret."}]}},{"line":136,"title":"never lowers the expiry the session already holds","decision":"keep","reason":"Actual verified auth-refresh messages cannot reduce expiry and can increase it while preserving the live control."},{"line":154,"title":"closes the socket a refused refresh arrived on, not the control that replaced it","decision":"keep","reason":"A deferred refused auth-refresh closes its original socket after a real same-generation proof/rebind, leaving the successor live."}],"reviewed_sha256":"ac29bd21d656e17c6722a27b01e8b48be26d02ed0a4195ccf151d1741f2e04ae","decision":"fix","rationale":"Preserve monotone expiry across a real rebind, but drive the later expiry through an actual verified auth-refresh (or a valid initially longer token) rather than assigning session.identity directly while claiming a refresh delivered it."} +{"path":"cloud/apps/relay/src/host-session-client-accept.test.ts","sha256":"05ec3447db6b3e7758f7964c905e773c070aa36683d8262d1f96a7b3ea7e7366","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/splice-forwarder.ts"],"cases":[{"line":160,"title":"does not admit new source work after a drain crosses activity acquisition","decision":"keep","reason":"A regional drain crossing delayed activity persistence refuses the phone before conn-open or capacity binding and releases acquired work."},{"line":189,"title":"does not splice an attachment whose generation retired during basis persistence","decision":"keep","reason":"A generation retired during connection-basis persistence cannot splice or acknowledge its pending phone and deactivates the stale basis."},{"line":220,"title":"stops after a slow activity acquire when the phone already hung up","decision":"keep","reason":"A closed phone after delayed activity acquisition leaves no pending work, binding or leaked activity and emits the correct abandonment stage without exposing host identity."},{"line":271,"title":"stops after a slow credential reservation without acquiring an activity lease","decision":"keep","reason":"A closed phone after delayed credential reservation fails that reservation and avoids acquiring an activity lease."},{"line":302,"title":"stops after a slow resume lookup before starting the invite and assignment lookups","decision":"keep","reason":"A closed phone after delayed resume lookup stops before invite, assignment and reservation work, isolating the intended earliest boundary."},{"line":339,"title":"stops after a slow same-cell assignment resolve, before reserving a credential","decision":"keep","reason":"A same-cell assignment answering after phone closure stops at the later guard before credential reservation, with an explicit reached-stage control."},{"line":374,"title":"logs and counts an attach deadline with what the cell knew of the control","decision":"fix","reason":"Keep attach-timeout wire code, fixed phone reason, telemetry and diagnostic context; restore the console spy and drain in finally so an assertion failure cannot contaminate later cases."},{"line":410,"title":"still opens the connection when the phone is holding on","decision":"keep","reason":"The positive live-phone control emits actual conn-open, binds capacity and avoids an abandonment verdict."},{"line":437,"title":"times every serialized stage plus the attach window once relay-hello lands","decision":"fix","reason":"Keep independently controlled serialized timing and actual successful attach, complete stage accounting and redacted diagnostic context; trim the unrelated exact pendingConns.has invocation assertion because dedicated inventory-scan cases cover the performance contract."},{"line":552,"title":"attaches the session that owns the connection, not the first one registered","decision":"keep","reason":"An earlier unrelated session cannot steal an attachment: the actual owner gains the splice and the bystander remains untouched."},{"line":579,"title":"acknowledges the client only after the connection basis is persisted","decision":"keep","reason":"Deferred basis persistence must finish before the actual phone relay-hello and splice are published."},{"line":611,"title":"logs a host once at the fourth sample and not again within the hour","decision":"keep","reason":"Actual ping/pong traffic emits RTT diagnostics only at four samples and after another hour, while every sample updates telemetry."},{"line":662,"title":"ignores a pong that answers no outstanding ping","decision":"keep","reason":"Malformed, unsolicited and wrong-timestamp pongs produce no RTT samples; only the actual outstanding ping echo yields the independently timed sample."},{"line":689,"title":"records one sample per ping however many pongs a host floods","decision":"keep","reason":"Ten thousand repeated or guessed pong messages cannot inflate the one outstanding ping into multiple metric or diagnostic samples."},{"line":723,"title":"grants a lease uniformly around its mean so cohorts drift apart at the same mean rate","decision":"keep","reason":"Injected random endpoint/center draws reach the real hello-ack and establish symmetric lease jitter around the configured mean."},{"line":750,"title":"rebinds re-roll the jitter instead of pinning the cohort phase","decision":"keep","reason":"A real same-generation activation rerolls lease jitter and closes the predecessor rather than preserving cohort phase."},{"line":809,"title":"serves a host whose drain has not been sent and refuses one whose has","decision":"keep","reason":"A paced drain refuses a host already told while continuing actual conn-open delivery to its untold neighbour."},{"line":822,"title":"refuses that host's phones as soon as its own drain is sent","decision":"keep","reason":"The untold host switches from service to refusal exactly when its own paced drain frame lands."},{"line":834,"title":"keeps an unpaced drain refusing every phone at once","decision":"keep","reason":"An unpaced drain still refuses both hosts immediately rather than leaking admission during fleet teardown."}],"reviewed_sha256":"22c7e48886aea21ab072762d4b2b8a2e0e9003709ecb09b63885c692192d9df9","decision":"fix","rationale":"Keep attach-timeout wire code, fixed phone reason, telemetry and diagnostic context; restore the console spy and drain in finally so an assertion failure cannot contaminate later cases. Keep independently controlled serialized timing and actual successful attach, complete stage accounting and redacted diagnostic context; trim the unrelated exact pendingConns.has invocation assertion because dedicated inventory-scan cases cover the performance contract."} +{"path":"cloud/apps/relay/src/host-session-drain-release-order.test.ts","sha256":"67cf0d3b4ee29e762f771ff34991dc89e41d5efdc8094ddcaf8d714e14515c71","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/test-fixtures/host-control-proof.ts"],"cases":[{"line":46,"title":"tells and closes the host only once its control release has landed","decision":"keep","reason":"A deferred real registry release fences the host at once but sends drain and close only after durable control release, in wire order."},{"line":74,"title":"closes on the bound when the release has not landed, as before this ordering","decision":"keep","reason":"Fake-clock bound checks establish eventual drain/close and one redacted slow-release diagnostic when persistence stalls."},{"line":96,"title":"starts the host's splice releases before its control release","decision":"keep","reason":"The registry initiates all established-splice releases before its control release, preserving the per-host store serialization barrier."},{"line":117,"title":"closes at once when the release fails, so a database outage never holds the host","decision":"keep","reason":"Rejected persistence is contained and closes the host immediately instead of waiting for the timeout."},{"line":133,"title":"does not wait for a host that holds no lease here","decision":"keep","reason":"A memory-admitted host with no lease closes without calling persistent release."},{"line":150,"title":"still tells a host with grace at once, and releases it before the closing deadline","decision":"keep","reason":"A graceful drain sends once immediately, then defers final close until the deadline-triggered control release settles."}],"reviewed_sha256":"67cf0d3b4ee29e762f771ff34991dc89e41d5efdc8094ddcaf8d714e14515c71","decision":"keep","rationale":"A deferred real registry release fences the host at once but sends drain and close only after durable control release, in wire order. Fake-clock bound checks establish eventual drain/close and one redacted slow-release diagnostic when persistence stalls. The registry initiates all established-splice releases before its control release, preserving the per-host store serialization barrier. Rejected persistence is contained and closes the host immediately instead of waiting for the timeout. A memory-admitted host with no lease closes without calling persistent release. A graceful drain sends once immediately, then defers final close until the deadline-triggered control release settles."} +{"path":"cloud/apps/relay/src/host-session-preauth-latency.test.ts","sha256":"fd204e24f7dbe3889c4e939cb6adadbd9fbef7c85084faecd314d0df7c9ad5db","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-session-registry.ts"],"cases":[{"line":189,"title":"records a booked hello on the reserve path, from accept to a verified proof","decision":"fix","reason":"Keep actual encrypted proof and independently clocked reserve admission metric; use fake timers and drain the activated reserve-mode session in cleanup because this real-timer case leaves its heartbeat interval live."},{"line":206,"title":"records a hello the database refuses on the db path","decision":"keep","reason":"Actual database refusal produces the database-path timing and fixed wrong-epoch close without consulting reserve bookings."},{"line":220,"title":"records a hello timeout as a refusal before any check, once","decision":"keep","reason":"An exact fake-clock hello timeout reports one before-check refusal even though the close handler also runs."},{"line":236,"title":"records a host that hangs up before its hello as abandoned","decision":"keep","reason":"A peer closing before hello reports one abandonment with independently controlled elapsed time."},{"line":247,"title":"records a database answer (%s) that arrives after the host hung up as abandoned","decision":"keep","reason":"Both late true/false database answers after peer hang-up report abandonment and cannot send a challenge.","parameter_table":{"source":"[true, false]","rows":[{"index":1,"input":"true","decision":"keep","reason":"Both late true/false database answers after peer hang-up report abandonment and cannot send a challenge."},{"index":2,"input":"false","decision":"keep","reason":"Both late true/false database answers after peer hang-up report abandonment and cannot send a challenge."}]}},{"line":267,"title":"records a host that hangs up during its proof as abandoned on its path","decision":"keep","reason":"Closure during the actual proof stage reports abandonment on the reserve path and releases the stage listener."},{"line":280,"title":"records the pool-pressure shed as a refusal before any check","decision":"keep","reason":"Pool-pressure shedding with a missing booking refuses before any database call and reports the correct independently clocked pre-check duration."}],"reviewed_sha256":"a48b9c7035700f1436b66dd2341d7880f530b3be9a9141cda9cb46101c0fe9a4","decision":"fix","rationale":"Keep actual encrypted proof and independently clocked reserve admission metric; use fake timers and drain the activated reserve-mode session in cleanup because this real-timer case leaves its heartbeat interval live."} +{"path":"cloud/apps/relay/src/host-session-registry.test.ts","sha256":"90534b6173be8f5234822d92126239800deda64e0adfb7c303934fd13ca47818","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/control-renewal-batch.ts","cloud/apps/relay/src/post-proof-close-log.ts"],"cases":[{"line":237,"title":"logs control closes with a host digest and counts them, never the raw id","decision":"keep","reason":"Actual control error/close events emit a bounded host digest, close code and diagnostic without the raw host id."},{"line":262,"title":"contains a dependency failure to one socket instead of the process","decision":"keep","reason":"A rejecting verified-token dependency is contained to the originating control with a fixed temporary-unavailable close and diagnostic."},{"line":295,"title":"attributes a control close to its client build without trusting the version string","decision":"keep","reason":"An attacker-controlled build string is stripped and bounded in the actual control-close diagnostic."},{"line":328,"title":"reports the work a generation replacement destroyed, not the drained aftermath","decision":"keep","reason":"Generation replacement captures established splice/pending counts before destructive teardown, avoiding misleading zero counts."},{"line":370,"title":"keeps the first drain snapshot when a drain is retried","decision":"keep","reason":"Repeated fleet drain preserves the first teardown snapshot and does not multiply drain timers."},{"line":401,"title":"drains only the incarnation-bound host and makes replay idempotent","decision":"keep","reason":"Targeted regional drain affects only the requested host, retains drain-only state across refresh/rebind, rejects conflicting operations/epochs, and expires only the target; trust-probe identities cannot hit live controls."},{"line":476,"title":"refreshes the logged client build when a control rebinds","decision":"keep","reason":"Same-generation rebind attributes predecessor and successor close diagnostics to their own build strings."},{"line":509,"title":"keeps every live control socket indexed when first activations overlap","decision":"keep","reason":"Overlapping initial activations serialize and leave exactly one live, indexed control rather than an unreachable socket."},{"line":535,"title":"does not publish a control that closes during activation","decision":"keep","reason":"A peer closing during delayed activation cannot publish a session and releases the acquired persistent activity."},{"line":557,"title":"does not rebind a control that closes during activation","decision":"keep","reason":"A closed rebind candidate cannot overwrite its still-live predecessor and releases its acquired activity."},{"line":589,"title":"refuses a rebind whose session left the map while its activation was in flight","decision":"keep","reason":"Orphan expiry during delayed rebind cannot revive an unindexed seat; map/feed remain empty and persistence is released."},{"line":625,"title":"refuses a fresh activation at a generation this host already had here","decision":"keep","reason":"A generation remembered after orphan removal cannot be reused by a late initial activation."},{"line":644,"title":"skips a closed queued control so its live retry avoids abandoned database work","decision":"keep","reason":"A queued abandoned peer is skipped before persistence, so the following live retry completes after one independently delayed store operation."},{"line":687,"title":"rejects client lookup when the indexed control socket is not open","decision":"keep","reason":"An indexed active session whose control readyState is closed refuses actual phone admission and frees its reservation."},{"line":722,"title":"fails a control waiting behind a stalled activation without breaking serialization","decision":"keep","reason":"The activation queue timeout refuses a waiting peer without permitting concurrent persistence, while the original activation can still succeed."},{"line":752,"title":"rejects an activation that returns after drain begins","decision":"fix","reason":"A late activation after fleet drain cannot publish, renew or strand its acquired activity; update the renewal observation to the actual batch dependency when removing the copied single-to-batch fixture adapter."},{"line":795,"title":"keeps a replacement mapped after stale orphan cleanup","decision":"keep","reason":"Orphan cleanup cannot remove the replacement generation or its live control count."},{"line":827,"title":"stops the heartbeat of an actively replaced generation","decision":"fix","reason":"Retain replacement-heartbeat/renewal ownership; replace the fixture adapter that reimplements batch outcomes over a single-renewal mock with direct typed renewControlActivities outcomes and assertions."},{"line":857,"title":"ignores a denial belonging to the socket before a same-generation rebind","decision":"fix","reason":"Retain deferred old-socket denial fencing across same-generation rebind; drive the real batch dependency directly instead of the copied single-renewal adapter."},{"line":879,"title":"ignores missing-activity recovery denial after an authority transition","decision":"fix","reason":"Retain recovery-denial fencing after regional authority changes; supply the typed missing-activity batch verdict directly rather than recreating store classification in the fixture."},{"line":906,"title":"keeps 15s pings while halving steady-state control renewals","decision":"fix","reason":"Retain independently clocked four pings/two renewal windows and lease expiry budget; observe direct batch requests rather than a copied single-renewal adapter."},{"line":937,"title":"retries a failed control renewal on the next ping","decision":"fix","reason":"Retain a failed batch retry on the very next ping, using direct batch rejection rather than the copied single-renewal fixture adapter."},{"line":960,"title":"retries past a stalled control renewal without waiting for it","decision":"fix","reason":"Retain a second batch request while an earlier renewal stalls; defer the actual batch mock directly instead of recreating store batch semantics."},{"line":980,"title":"ignores a superseded renewal resolving after a fresher success","decision":"fix","reason":"Retain stale-completion fencing after a fresher success and its effect on the next due tick; drive direct batch promises instead of the fixture single-renewal adapter."},{"line":1007,"title":"re-acquires a missing control activity lease","decision":"fix","reason":"Retain recovery acquisition for a missing control activity, supplying the typed batch outcome directly rather than mapping a single-renewal exception in the fixture."},{"line":1033,"title":"closes a control whose activity lease moved to another cell","decision":"fix","reason":"Retain moved-activity close and absence of recovery acquisition; supply the real batch verdict directly instead of copied store error mapping."},{"line":1052,"title":"closes when a missing control activity cannot be re-acquired on this cell","decision":"fix","reason":"Retain authoritative-cell recovery refusal and final close; provide a typed missing-activity batch verdict directly rather than the fixture single-renewal adapter."},{"line":1074,"title":"closes a control when renewal finds its cell is no longer authoritative","decision":"fix","reason":"Retain a no-longer-authoritative batch verdict closing the control; configure the direct batch dependency instead of copied single-renewal mapping."},{"line":1094,"title":"continues renewing throughout the drain grace period","decision":"fix","reason":"Retain renewals and live control through graceful drain, observing actual batch requests rather than a copied single-renewal adapter."},{"line":1122,"title":"keeps the halved cadence after a rebind lands under a stalled renewal","decision":"fix","reason":"Retain cadence after a rebind overtakes a delayed renewal; drive typed batch promises directly instead of copied single-to-batch fixture behavior."},{"line":1169,"title":"renews two due hosts in one call and leaves a stale one alone","decision":"keep","reason":"Two due hosts share one real registry batch; a peer closing during persistence cannot advance its stale renewal counters or deadline, while the live host advances."},{"line":1220,"title":"does not re-acquire a lease for a session a newer generation already replaced","decision":"fix","reason":"Retain missing-lease denial after generation replacement without stale recovery; defer the actual batch result directly instead of copied single-renewal mapping."},{"line":1339,"title":"states the pending kind and device to a host that advertised it can read them","decision":"keep","reason":"Capability-aware pending metadata is emitted on the actual hello-ack wire with invite kind and device identity."},{"line":1345,"title":"restates only the identifiers to a host that never advertised the capability","decision":"keep","reason":"The legacy hello-ack contains only identifiers so strict older decoders remain compatible."},{"line":1353,"title":"downgrades the restated entry when the successor control drops the capability","decision":"keep","reason":"A successor dropping its socket capability downgrades actual pending wire entries without inheriting predecessor metadata."},{"line":1362,"title":"upgrades the restated entry when the successor control adds the capability","decision":"keep","reason":"A successor adding its socket capability upgrades actual pending wire entries without retaining the legacy shape."},{"line":1403,"title":"answers $outcome for a control socket $controlAgeMs ms old","decision":"keep","reason":"Four control-age boundary rows establish minimum-age admission and actual commit/close behavior at zero, just before, exactly at, and well after the limit.","parameter_table":{"source":"[\n { controlAgeMs: 0, outcome: 'busy' },\n { controlAgeMs: IDLE_REHOME_MIN_CONTROL_AGE_MS - 1, outcome: 'busy' },\n { controlAgeMs: IDLE_REHOME_MIN_CONTROL_AGE_MS, outcome: 'committed' },\n { controlAgeMs: 60 * 60 * 1000, outcome: 'committed' }\n ]","rows":[{"index":1,"input":"{ controlAgeMs: 0, outcome: 'busy' }","decision":"keep","reason":"Four control-age boundary rows establish minimum-age admission and actual commit/close behavior at zero, just before, exactly at, and well after the limit."},{"index":2,"input":"{ controlAgeMs: IDLE_REHOME_MIN_CONTROL_AGE_MS - 1, outcome: 'busy' }","decision":"keep","reason":"Four control-age boundary rows establish minimum-age admission and actual commit/close behavior at zero, just before, exactly at, and well after the limit."},{"index":3,"input":"{ controlAgeMs: IDLE_REHOME_MIN_CONTROL_AGE_MS, outcome: 'committed' }","decision":"keep","reason":"Four control-age boundary rows establish minimum-age admission and actual commit/close behavior at zero, just before, exactly at, and well after the limit."},{"index":4,"input":"{ controlAgeMs: 60 * 60 * 1000, outcome: 'committed' }","decision":"keep","reason":"Four control-age boundary rows establish minimum-age admission and actual commit/close behavior at zero, just before, exactly at, and well after the limit."}]}},{"line":1419,"title":"restarts the age when the host rebinds its control socket","decision":"keep","reason":"A real same-generation rebind resets socket age and prevents immediate idle cutover."},{"line":1436,"title":"closes a superseded socket whose refresh meets the cutover, not its successor","decision":"keep","reason":"A superseded socket sending auth-refresh during cutover closes only itself while the successor remains live."},{"line":1461,"title":"keeps either established client busy until both actually leave","decision":"keep","reason":"Idle cutover stays busy until both established connection ids have left; only then can it commit and release control authority."},{"line":1479,"title":"rejects a reused operation ID with changed authority %j","decision":"keep","reason":"All five reused-operation authority changes are stale while an in-flight original remains isolated and returns its own deferred outcome.","parameter_table":{"source":"[\n { userId: 'other-user' },\n { sourceAssignmentEpoch: 2 },\n { sourceGeneration: 2 },\n { sourceCellIncarnation: 'other-incarnation' },\n { targetCellId: 'other-target' }\n ]","rows":[{"index":1,"input":"{ userId: 'other-user' }","decision":"keep","reason":"All five reused-operation authority changes are stale while an in-flight original remains isolated and returns its own deferred outcome."},{"index":2,"input":"{ sourceAssignmentEpoch: 2 }","decision":"keep","reason":"All five reused-operation authority changes are stale while an in-flight original remains isolated and returns its own deferred outcome."},{"index":3,"input":"{ sourceGeneration: 2 }","decision":"keep","reason":"All five reused-operation authority changes are stale while an in-flight original remains isolated and returns its own deferred outcome."},{"index":4,"input":"{ sourceCellIncarnation: 'other-incarnation' }","decision":"keep","reason":"All five reused-operation authority changes are stale while an in-flight original remains isolated and returns its own deferred outcome."},{"index":5,"input":"{ targetCellId: 'other-target' }","decision":"keep","reason":"All five reused-operation authority changes are stale while an in-flight original remains isolated and returns its own deferred outcome."}]}},{"line":1498,"title":"accounts for accepts before credential identity resolves","decision":"keep","reason":"Client accept owns source work before its credential identity resolves, preventing an idle cutover from overtaking the lookup."},{"line":1517,"title":"rejects new accepts and replacements synchronously while a commit awaits","decision":"keep","reason":"An in-flight cutover synchronously fences new phones and replacement activations, coalesces exact replay and permits a later distinct operation only after reconciliation."},{"line":1557,"title":"keeps %s outcomes fenced until locked reconciliation succeeds","decision":"keep","reason":"Both ambiguous thrown commits and explicit deferred claims remain fenced through two failed reconciliations until the third durable result succeeds.","parameter_table":{"source":"['ambiguous', 'deferred']","rows":[{"index":1,"input":"'ambiguous'","decision":"keep","reason":"Both ambiguous thrown commits and explicit deferred claims remain fenced through two failed reconciliations until the third durable result succeeds."},{"index":2,"input":"'deferred'","decision":"keep","reason":"Both ambiguous thrown commits and explicit deferred claims remain fenced through two failed reconciliations until the third durable result succeeds."}]}},{"line":1588,"title":"owns accepted control mutations before the handler first awaits","decision":"keep","reason":"An accepted auth-refresh acquires ownership synchronously before token verification awaits, then releases that ownership when the mutation settles."},{"line":1609,"title":"owns queued replacement activation before its first persistence await","decision":"keep","reason":"A queued replacement owns source work before its first persistence await, preventing a concurrent idle cutover."},{"line":1630,"title":"retires changed authority even when the claim definitively deferred","decision":"keep","reason":"A durable stale reconciliation retires the changed source even when the initial commit claimed only deferred."},{"line":1642,"title":"holds attach ownership through basis failure reservation cleanup","decision":"fix","reason":"Retain attach ownership through rejected basis persistence and delayed reservation cleanup; populate producer-valid pending phonePath/timing/reservation fields so the database splice-lease path is not silently bypassed by an incomplete cast fixture."},{"line":1682,"title":"rejects an attach mid-cutover before its ticket is ever examined","decision":"keep","reason":"A valid pending ticket injected after cutover starts is rejected by the ownership fence before authentication, preserving its pending entry for reconciliation."},{"line":1713,"title":"holds no attach ownership when no session owns the connection","decision":"keep","reason":"An unowned attach receives the actual bad-credential verdict and cannot leak an idle-work hold that blocks later cutover."},{"line":1733,"title":"returns the durable operation outcome after source retirement","decision":"keep","reason":"Replay after source retirement reads the durable committed operation rather than re-executing commit."},{"line":1742,"title":"does not reopen a source overtaken by emergency drain","decision":"keep","reason":"An emergency fleet drain overtaking deferred cutover cannot reopen the retired source."},{"line":1874,"title":"visits the inventory once, not twice, for a $placement owner","decision":"fix","reason":"Retain deterministic production inventory-visit/membership budgets at first/middle/last/absent positions; remove the copied legacyOwnerLookup implementation, before counts and oracle-only assertions, which only test an inline old algorithm.","parameter_table":{"source":"[\n {\n placement: 'first',\n before: { visits: 2000, membership: 2 },\n after: { visits: 1, membership: 1 }\n },\n {\n placement: 'middle',\n before: { visits: 2000, membership: 1000 },\n after: { visits: 500, membership: 500 }\n },\n {\n placement: 'last',\n before: { visits: 2000, membership: 2000 },\n after: { visits: 1000, membership: 1000 }\n },\n {\n placement: 'absent',\n before: { visits: 2000, membership: 2000 },\n after: { visits: 1000, membership: 1000 }\n }\n ]","rows":[{"index":1,"input":"{\n placement: 'first',\n before: { visits: 2000, membership: 2 },\n after: { visits: 1, membership: 1 }\n }","decision":"fix","reason":"Retain deterministic production inventory-visit/membership budgets at first/middle/last/absent positions; remove the copied legacyOwnerLookup implementation, before counts and oracle-only assertions, which only test an inline old algorithm."},{"index":2,"input":"{\n placement: 'middle',\n before: { visits: 2000, membership: 1000 },\n after: { visits: 500, membership: 500 }\n }","decision":"fix","reason":"Retain deterministic production inventory-visit/membership budgets at first/middle/last/absent positions; remove the copied legacyOwnerLookup implementation, before counts and oracle-only assertions, which only test an inline old algorithm."},{"index":3,"input":"{\n placement: 'last',\n before: { visits: 2000, membership: 2000 },\n after: { visits: 1000, membership: 1000 }\n }","decision":"fix","reason":"Retain deterministic production inventory-visit/membership budgets at first/middle/last/absent positions; remove the copied legacyOwnerLookup implementation, before counts and oracle-only assertions, which only test an inline old algorithm."},{"index":4,"input":"{\n placement: 'absent',\n before: { visits: 2000, membership: 2000 },\n after: { visits: 1000, membership: 1000 }\n }","decision":"fix","reason":"Retain deterministic production inventory-visit/membership budgets at first/middle/last/absent positions; remove the copied legacyOwnerLookup implementation, before counts and oracle-only assertions, which only test an inline old algorithm."}]}},{"line":1922,"title":"fails an attach whose $reason does not match the owner","decision":"keep","reason":"Ticket, generation and owner-state mismatches each refuse the actual attachment without consuming pending ownership.","parameter_table":{"source":"[\n { reason: 'ticket', ticket: 'wrong', generation: 1, state: 'active' },\n { reason: 'generation', ticket: 'ticket', generation: 2, state: 'active' },\n { reason: 'state', ticket: 'ticket', generation: 1, state: 'orphaned' }\n ]","rows":[{"index":1,"input":"{ reason: 'ticket', ticket: 'wrong', generation: 1, state: 'active' }","decision":"keep","reason":"Ticket, generation and owner-state mismatches each refuse the actual attachment without consuming pending ownership."},{"index":2,"input":"{ reason: 'generation', ticket: 'ticket', generation: 2, state: 'active' }","decision":"keep","reason":"Ticket, generation and owner-state mismatches each refuse the actual attachment without consuming pending ownership."},{"index":3,"input":"{ reason: 'state', ticket: 'ticket', generation: 1, state: 'orphaned' }","decision":"keep","reason":"Ticket, generation and owner-state mismatches each refuse the actual attachment without consuming pending ownership."}]}},{"line":1947,"title":"rejects on the earlier duplicate owner rather than the later live one","decision":"fix","reason":"Retain first-insertion duplicate-owner refusal and short-circuit count; remove the comparison against the copied legacyOwnerLookup oracle."},{"line":1961,"title":"splices the earlier duplicate owner and leaves the later one untouched","decision":"fix","reason":"The fixture deliberately rejects basis persistence and never splices; narrow the title to consuming the first owner on failed basis persistence while leaving the later duplicate untouched."},{"line":2020,"title":"sends every drain at once when no window is given","decision":"keep","reason":"A drain without pacing sends the actual zero-grace drain frame to every connected host immediately after release."},{"line":2030,"title":"spreads the sends evenly across the window","decision":"keep","reason":"Fake-clock increments observe the actual first, middle and final wire sends spread across the configured window."},{"line":2049,"title":"fences admission for every session before the first paced send lands","decision":"fix","reason":"The body proves immediate refusal of new host controls only; narrow the title/comment accordingly because untold existing hosts intentionally remain authoritative for their phones during pacing."},{"line":2061,"title":"gives each host its own grace after its own send, not after the call","decision":"fix","reason":"Check the second close at its exact own-send plus grace boundary (49999ms then 1ms), rather than only at 60000ms; the current final 10001ms jump can hide an extra ten seconds of grace."},{"line":2074,"title":"leaves no timer behind once an emergency drain cuts a window short","decision":"keep","reason":"Emergency drain clears paced sends, teardown timers and heartbeats, leaving no pending timers after all sessions close."},{"line":2083,"title":"keeps the first teardown snapshot when a regional drain fires before the fleet one","decision":"keep","reason":"A regional deadline followed by fleet drain preserves the original teardown counts and closes the socket."},{"line":2100,"title":"lets an emergency drain supersede the sends still queued by a paced one","decision":"keep","reason":"Emergency drain delivers every remaining wire frame and prevents any queued paced send from firing later."},{"line":2145,"title":"logs an idle cutover refusal","decision":"keep","reason":"An idle cutover fence produces the expected post-proof refusal metric and redacted diagnostic."},{"line":2159,"title":"logs a stalled activation queue once","decision":"keep","reason":"A stalled activation queue records one post-proof refusal despite later predecessor completion."},{"line":2176,"title":"logs a superseded activation","decision":"keep","reason":"An activation proven against a stale session receives the superseded refusal and corresponding diagnostic."},{"line":2184,"title":"logs a failed host-proof assignment check as $cause","decision":"keep","reason":"Wrong-assignment, transient database and arbitrary secret-bearing exceptions map to bounded post-proof causes without leaking credentials.","parameter_table":{"source":"[\n { error: new Error('wrong_assignment'), cause: 'wrong_assignment' },\n { error: Object.assign(new Error('timeout'), { code: '57014' }), cause: 'database_transient' },\n // Assembled at runtime so the secret scanner does not read the fixture as a real URL.\n {\n error: new Error(`connect ${['postgres', '//user:secret@db/relay'].join(':')}`),\n cause: 'error'\n }\n ]","rows":[{"index":1,"input":"{ error: new Error('wrong_assignment'), cause: 'wrong_assignment' }","decision":"keep","reason":"Wrong-assignment, transient database and arbitrary secret-bearing exceptions map to bounded post-proof causes without leaking credentials."},{"index":2,"input":"{ error: Object.assign(new Error('timeout'), { code: '57014' }), cause: 'database_transient' }","decision":"keep","reason":"Wrong-assignment, transient database and arbitrary secret-bearing exceptions map to bounded post-proof causes without leaking credentials."},{"index":3,"input":"{\n error: new Error(`connect ${['postgres', '//user:secret@db/relay'].join(':')}`),\n cause: 'error'\n }","decision":"keep","reason":"Wrong-assignment, transient database and arbitrary secret-bearing exceptions map to bounded post-proof causes without leaking credentials."}]}},{"line":2206,"title":"logs a drain that lands during activation","decision":"keep","reason":"Fleet drain observed before wiring emits the fixed draining post-proof diagnostic."},{"line":2213,"title":"logs a host that hangs up during activation, with no cell close code","decision":"keep","reason":"Peer hang-up during persistence is diagnosed as a host close with no cell-originated close code."},{"line":2227,"title":"logs a host that hangs up while queued, with no cell close code","decision":"keep","reason":"Peer hang-up while queued is diagnosed separately from activation refusal after the predecessor completes."},{"line":2244,"title":"logs the hang-up, not a stall, when the queued host left before the deadline","decision":"keep","reason":"A queued peer already closed at the stall deadline is diagnosed as hang-up, avoiding a misleading cell stall attribution."},{"line":2265,"title":"does not log a control that was wired","decision":"keep","reason":"A successfully wired control emits no post-proof refusal metric or diagnostic, guarding the negative diagnostic path."},{"line":2310,"title":"never sends a database error message, which can carry the connection URL","decision":"keep","reason":"An actual control-operation database exception maps to a fixed wire code and redacted server diagnostic, never its connection URL/password."},{"line":2326,"title":"maps any other unexpected message to a fixed code","decision":"keep","reason":"An unexpected non-domain exception maps to the fixed control_operation_failed wire result."},{"line":2334,"title":"keeps %s on the wire","decision":"keep","reason":"Both explicit store-domain errors and approved invariant slugs retain their wire codes without generic failure logging.","parameter_table":{"source":"[\n ['a store code', new RelayStoreError('reject-revoked'), 'reject-revoked'],\n ['an invariant slug', new Error('authorization_expired'), 'authorization_expired']\n ]","rows":[{"index":1,"input":"['a store code', new RelayStoreError('reject-revoked'), 'reject-revoked']","decision":"keep","reason":"Both explicit store-domain errors and approved invariant slugs retain their wire codes without generic failure logging."},{"index":2,"input":"['an invariant slug', new Error('authorization_expired'), 'authorization_expired']","decision":"keep","reason":"Both explicit store-domain errors and approved invariant slugs retain their wire codes without generic failure logging."}]}}],"reviewed_sha256":"f285b3724340fe47f09640ab65375fc640f88f14c6f09b08d093865e307a64bf","decision":"fix","rationale":"A late activation after fleet drain cannot publish, renew or strand its acquired activity; update the renewal observation to the actual batch dependency when removing the copied single-to-batch fixture adapter. Retain replacement-heartbeat/renewal ownership; replace the fixture adapter that reimplements batch outcomes over a single-renewal mock with direct typed renewControlActivities outcomes and assertions. Retain deferred old-socket denial fencing across same-generation rebind; drive the real batch dependency directly instead of the copied single-renewal adapter. Retain recovery-denial fencing after regional authority changes; supply the typed missing-activity batch verdict directly rather than recreating store classification in the fixture. Retain independently clocked four pings/two renewal windows and lease expiry budget; observe direct batch requests rather than a copied single-renewal adapter. Retain a failed batch retry on the very next ping, using direct batch rejection rather than the copied single-renewal fixture adapter. Retain a second batch request while an earlier renewal stalls; defer the actual batch mock directly instead of recreating store batch semantics. Retain stale-completion fencing after a fresher success and its effect on the next due tick; drive direct batch promises instead of the fixture single-renewal adapter. Retain recovery acquisition for a missing control activity, supplying the typed batch outcome directly rather than mapping a single-renewal exception in the fixture. Retain moved-activity close and absence of recovery acquisition; supply the real batch verdict directly instead of copied store error mapping. Retain authoritative-cell recovery refusal and final close; provide a typed missing-activity batch verdict directly rather than the fixture single-renewal adapter. Retain a no-longer-authoritative batch verdict closing the control; configure the direct batch dependency instead of copied single-renewal mapping. Retain renewals and live control through graceful drain, observing actual batch requests rather than a copied single-renewal adapter. Retain cadence after a rebind overtakes a delayed renewal; drive typed batch promises directly instead of copied single-to-batch fixture behavior. Retain missing-lease denial after generation replacement without stale recovery; defer the actual batch result directly instead of copied single-renewal mapping. Retain attach ownership through rejected basis persistence and delayed reservation cleanup; populate producer-valid pending phonePath/timing/reservation fields so the database splice-lease path is not silently bypassed by an incomplete cast fixture. Retain deterministic production inventory-visit/membership budgets at first/middle/last/absent positions; remove the copied legacyOwnerLookup implementation, before counts and oracle-only assertions, which only test an inline old algorithm. Retain first-insertion duplicate-owner refusal and short-circuit count; remove the comparison against the copied legacyOwnerLookup oracle. The fixture deliberately rejects basis persistence and never splices; narrow the title to consuming the first owner on failed basis persistence while leaving the later duplicate untouched. The body proves immediate refusal of new host controls only; narrow the title/comment accordingly because untold existing hosts intentionally remain authoritative for their phones during pacing. Check the second close at its exact own-send plus grace boundary (49999ms then 1ms), rather than only at 60000ms; the current final 10001ms jump can hide an extra ten seconds of grace."} +{"path":"cloud/apps/relay/src/host-signed-out-rejection.test.ts","sha256":"5bf81f9f83182d458810414dcbc618998e018fabcf142bd0798c0b63c99a644f","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/host-session-registry.ts","cloud/apps/relay/src/host-close-reason-memory.ts"],"cases":[{"line":129,"title":"names the sign-out to a phone that arrives after the host is gone","decision":"keep","reason":"Actual host signed-out close survives orphan expiry and becomes a phone close reason while preserving the strict legacy relay-hello body."},{"line":145,"title":"says nothing when the host died without naming a cause","decision":"keep","reason":"Abrupt network death carries no known host cause and yields the generic offline close reason."},{"line":160,"title":"ignores a close reason the host invented","decision":"keep","reason":"An invented close reason cannot become a trusted phone sign-out verdict."},{"line":175,"title":"forgets the sign-out once the host proves itself again","decision":"keep","reason":"A new actual control activation forgets the old sign-out so a later abrupt death stays generic."},{"line":197,"title":"never names a cause while the host control is connected","decision":"keep","reason":"A live host still receives conn-open and admits the phone without any remembered offline cause."}],"reviewed_sha256":"5bf81f9f83182d458810414dcbc618998e018fabcf142bd0798c0b63c99a644f","decision":"keep","rationale":"Actual host signed-out close survives orphan expiry and becomes a phone close reason while preserving the strict legacy relay-hello body. Abrupt network death carries no known host cause and yields the generic offline close reason. An invented close reason cannot become a trusted phone sign-out verdict. A new actual control activation forgets the old sign-out so a later abrupt death stays generic. A live host still receives conn-open and admits the phone without any remembered offline cause."} +{"path":"cloud/apps/relay/src/host-whereabouts-app.test.ts","sha256":"5a2f335ab1b023d1e93ebb4d354f655fa2302d2775aaa803009a585773506a51","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/app.ts","cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/admin-token-verifier.ts","cloud/apps/relay/src/shadow-seat-directory.ts"],"cases":[{"line":100,"title":"requires admin auth and a director","decision":"keep","reason":"Real HTTP handling rejects unauthenticated, wrong-role and strict-schema-invalid requests before the lookup dependency is called."},{"line":116,"title":"lets the monitor and fence accounts read it, and not the capacity account","decision":"keep","reason":"Real production admin route allow-list authorizes deploy/monitor/fence and refuses capacity identity at the actual route.","body_cases":[{"input":{"token":"deploy-token","status":200},"decision":"keep","reason":"Real route authorization grants the documented reader identities and rejects the capacity writer identity."},{"input":{"token":"monitor-token","status":200},"decision":"keep","reason":"Real route authorization grants the documented reader identities and rejects the capacity writer identity."},{"input":{"token":"fence-token","status":200},"decision":"keep","reason":"Real route authorization grants the documented reader identities and rejects the capacity writer identity."},{"input":{"token":"capacity-token","status":401},"decision":"keep","reason":"Real route authorization grants the documented reader identities and rejects the capacity writer identity."}]},{"line":130,"title":"returns the database row, the map seats, the verdict and the named cells","decision":"keep","reason":"Real shadow feed state and database lookup combine into HTTP seats, verdict, incarnation and named-cell/flag context rather than merely echoing a supplied mock row."},{"line":165,"title":"names the user from the map when the request has only a host id","decision":"keep","reason":"A host-only request derives its user from the real shadow map and calls the primary-key lookup with that identity."},{"line":178,"title":"judges the verdict as /v1/resolve would when the row names a dead cell","decision":"keep","reason":"A heartbeat-expired named database cell changes the actual shadow verdict to map-only-cell-unlive."},{"line":200,"title":"answers an unknown host with an empty result, not a 404","decision":"keep","reason":"Unknown host-only requests return an empty successful envelope without broad database lookup; an explicitly named unknown user receives a null database/seat result."},{"line":227,"title":"answers a briefly unreachable database with a retryable 503","decision":"keep","reason":"A real transient-error classification becomes a retryable HTTP 503."},{"line":240,"title":"reads the assignment row and its open migration by primary key","decision":"fix","reason":"Retain actual SQLite assignment/open-migration projection, but close the in-memory database in finally/afterEach so its connection is released on success and assertion failure."}],"reviewed_sha256":"3bf9908dfa2fb9d01d555851b2694520c540f8a5283bea62208e1f6ed5c684da","decision":"fix","rationale":"Retain actual SQLite assignment/open-migration projection, but close the in-memory database in finally/afterEach so its connection is released on success and assertion failure."} +{"path":"cloud/apps/relay/src/idle-regional-rehome-reconciliation.test.ts","sha256":"4bc34a7385f4b7a6be00471e8ede5e5e2706bd3b799feb73041460c27eaf2123","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/idle-regional-rehome-test-database.ts"],"cases":[{"line":42,"title":"only permits reopening when the exact source still owns the assignment","decision":"keep","reason":"Actual persisted source generation determines whether reopening is safe, and a replacement changes not-committed to stale."},{"line":54,"title":"does not reopen an obsolete source after an assignment change","decision":"keep","reason":"A real evacuation changing assignment authority prevents the obsolete source from reopening."},{"line":60,"title":"propagates unavailable durable state instead of declaring rollback","decision":"keep","reason":"Unavailable durable transaction state must propagate as failure rather than being mistaken for rollback."},{"line":66,"title":"waits for an outstanding assignment transaction before deciding authority","decision":"fix","reason":"Retain actual outstanding-assignment transaction ordering and stale outcome; replace the lone setImmediate not-settled observation with a reached/blocked reconciliation boundary (scoped PostgreSQL lock observation when enabled), so network scheduling alone cannot satisfy the wait claim."}],"reviewed_sha256":"fa3bc53d0a5a2f37df623867d09d3d479c4744783e6ada51accdf4c7e204a2ca","decision":"fix","rationale":"Retain actual outstanding-assignment transaction ordering and stale outcome; replace the lone setImmediate not-settled observation with a reached/blocked reconciliation boundary (scoped PostgreSQL lock observation when enabled), so network scheduling alone cannot satisfy the wait claim."} +{"path":"cloud/apps/relay/src/idle-regional-rehome-store.test.ts","sha256":"562fb019637e30ff98442789f547b8a7f855f4a137ec71ae76957b549a380f9c","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/idle-regional-rehome-selection.ts","cloud/apps/relay/src/idle-regional-rehome-test-database.ts"],"cases":[{"line":114,"title":"does only one read per tick with %s durable control and sees later enablement","decision":"keep","reason":"Missing, disabled and future durable-control rows each limit actual database work to one read per tick, observe later enablement and stop again on disablement.","parameter_table":{"source":"['missing', 'disabled', 'future']","rows":[{"index":1,"input":"'missing'","decision":"keep","reason":"Missing, disabled and future durable-control rows each limit actual database work to one read per tick, observe later enablement and stop again on disablement."},{"index":2,"input":"'disabled'","decision":"keep","reason":"Missing, disabled and future durable-control rows each limit actual database work to one read per tick, observe later enablement and stop again on disablement."},{"index":3,"input":"'future'","decision":"keep","reason":"Missing, disabled and future durable-control rows each limit actual database work to one read per tick, observe later enablement and stop again on disablement."}]}},{"line":160,"title":"reserves source activity plus assignment at target capacity %i","decision":"keep","reason":"Independent capacities 10/11 bracket source-activity-plus-assignment headroom and prove atomic committed/deferred target counters and assignment epochs.","parameter_table":{"source":"[10, 11]","rows":[{"index":1,"input":"10","decision":"keep","reason":"Independent capacities 10/11 bracket source-activity-plus-assignment headroom and prove atomic committed/deferred target counters and assignment epochs."},{"index":2,"input":"11","decision":"keep","reason":"Independent capacities 10/11 bracket source-activity-plus-assignment headroom and prove atomic committed/deferred target counters and assignment epochs."}]}},{"line":187,"title":"skips the candidate join while %s holds the durable dispatch budget closed","decision":"keep","reason":"Both durable next-dispatch and paused-until gates skip candidate joins until their exact fake-clock boundary, with independently counted real database reads.","parameter_table":{"source":"['next_dispatch_at', 'paused_until']","rows":[{"index":1,"input":"'next_dispatch_at'","decision":"keep","reason":"Both durable next-dispatch and paused-until gates skip candidate joins until their exact fake-clock boundary, with independently counted real database reads."},{"index":2,"input":"'paused_until'","decision":"keep","reason":"Both durable next-dispatch and paused-until gates skip candidate joins until their exact fake-clock boundary, with independently counted real database reads."}]}},{"line":214,"title":"polls when the worker state row has never been written","decision":"keep","reason":"An absent worker-state row permits actual candidate selection rather than treating never-written budget as closed."},{"line":221,"title":"drops every candidate while the %s cell is recorded as reserve","decision":"keep","reason":"Both source and target reserve modes exclude the actual candidate until each returns to database mode.","parameter_table":{"source":"['source', 'target']","rows":[{"index":1,"input":"'source'","decision":"keep","reason":"Both source and target reserve modes exclude the actual candidate until each returns to database mode."},{"index":2,"input":"'target'","decision":"keep","reason":"Both source and target reserve modes exclude the actual candidate until each returns to database mode."}]}},{"line":229,"title":"leaves the candidate page offset untouched across a closed dispatch budget","decision":"fix","reason":"The current single-host page resets its cursor to null, so reopening yields the same page even if the closed gate corrupts progress; seed multiple pages, stop after page one, close/reopen budget and assert the next distinct page is returned, using cursor terminology."},{"line":243,"title":"progresses past a full page of busy candidates without writing eligibility state","decision":"keep","reason":"A 101-host real database population advances beyond one full page without persistent consideration writes, while a restarted store begins at the head."},{"line":288,"title":"rechecks generation when replacement wins after the initial authority lookup","decision":"fix","reason":"Retain real PostgreSQL replacement between authority lookup and commit, but release the gate and await/drain the pending commit unconditionally on every failure path."},{"line":312,"title":"rejects source replacement when the cutover already holds assignment authority","decision":"fix","reason":"Retain real assignment locking that fences a competing replacement behind the cutover; release the held statement and settle both racing promises in finally to avoid deadlocking teardown after failure."},{"line":331,"title":"finds the committed attempt after its database reply is lost","decision":"keep","reason":"A lost reply is injected after an actual transaction commits; reconciliation finds the durable attempt and an exact retry cannot duplicate it."},{"line":367,"title":"commits the requested move once and records its outcome without source retention","decision":"keep","reason":"Repeated identical real commits change assignment once and preserve one attempt with the true source generation."},{"line":378,"title":"rejects a replaced control and never substitutes a different target","decision":"keep","reason":"A missing requested target cannot silently substitute another target, and a newer control generation makes the original operation stale."},{"line":394,"title":"does not commit without process safety or cohort authorization","decision":"keep","reason":"Missing process safety and explicitly closed cohort both defer before creating a durable rehome attempt."},{"line":407,"title":"selects read-only with stable identity and the control generation, not probe generation","decision":"keep","reason":"Real selection is read-only, stable across polls and keyed to persisted control generation rather than the probe generation."}],"reviewed_sha256":"5df06920367ee17690f0f5446dc2240567e8ad4fc3e806a471b8bff59c5c0b86","decision":"fix","rationale":"The current single-host page resets its cursor to null, so reopening yields the same page even if the closed gate corrupts progress; seed multiple pages, stop after page one, close/reopen budget and assert the next distinct page is returned, using cursor terminology. Retain real PostgreSQL replacement between authority lookup and commit, but release the gate and await/drain the pending commit unconditionally on every failure path. Retain real assignment locking that fences a competing replacement behind the cutover; release the held statement and settle both racing promises in finally to avoid deadlocking teardown after failure."} +{"path":"cloud/apps/relay/src/idle-regional-rehome-window.test.ts","sha256":"1e32a2de9b5a547c65a04578b3f527e44aec82afe63a2974e9e7ec4d00bc86f5","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/idle-regional-rehome-selection.ts","cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/idle-regional-rehome-test-database.ts"],"cases":[{"line":139,"title":"offers every eligible target for a host, least loaded first","decision":"keep","reason":"One real seeded host yields all three targets in independently specified load order, with source URL and distinct operation identities."},{"line":155,"title":"drops only the targets without room for the host plus its source activity","decision":"keep","reason":"Actual target capacity below/exactly at source-activity-plus-assignment budget removes/restores only the affected target and recomputes load order."},{"line":176,"title":"reads a bounded window of decisions however many hosts are eligible","decision":"fix","reason":"Replace imported-limit parameter equality and no-OFFSET SQL substring checks with observed real returned decision-row/page bounds and positive candidate/progress checks over a larger population; a copied production constant cannot independently establish bounded work. Whole-host pages deliberately retain all three fallback targets: the independent maximum in this fixture is 102 candidates (34 complete hosts), not a strict 100-candidate truncation."},{"line":190,"title":"keeps the window's last host when a decision turns eligible between the two reads","decision":"fix","reason":"Retain the real insert between decision-window and join reads, but assert the insertion hook actually fired so a SQL-text change cannot silently remove the race while preserving the original last host."},{"line":235,"title":"walks the whole population in bounded pages and wraps only at the end","decision":"fix","reason":"Assert the observed page cap, no early duplicates and actual wrap after all 363 host/target pairs; the current seen-size-only loop does not independently establish bounded pages or wrapping only at the end. Whole-host pages deliberately retain all three fallback targets: the independent maximum in this fixture is 102 candidates (34 complete hosts), not a strict 100-candidate truncation."},{"line":256,"title":"does not stall on a host the window found but the join rejected","decision":"keep","reason":"A real first host rejected by the control-lease join cannot stall the cursor before later eligible hosts."},{"line":273,"title":"excludes a host inside its rehome cooldown and takes it back after","decision":"keep","reason":"Actual persisted rehome cooldown suppresses candidates until its independently controlled age expires."},{"line":291,"title":"excludes a host outside the cohort","decision":"keep","reason":"An actual cohort bucket on the configured cutoff is excluded and the next wider cohort admits it."}],"reviewed_sha256":"ae3e946a75587a7387c5403abb790e51716f61dfae0b5bf5b1c18c57a1cb673f","decision":"fix","rationale":"Replace imported-limit parameter equality and no-OFFSET SQL substring checks with observed real returned decision-row/page bounds and positive candidate/progress checks over a larger population; a copied production constant cannot independently establish bounded work. Retain the real insert between decision-window and join reads, but assert the insertion hook actually fired so a SQL-text change cannot silently remove the race while preserving the original last host. Assert the observed page cap, no early duplicates and actual wrap after all 363 host/target pairs; the current seen-size-only loop does not independently establish bounded pages or wrapping only at the end."} +{"path":"cloud/apps/relay/src/idle-regional-rehome-worker.test.ts","sha256":"c34eb2c717dc8ac05d238508677fc2f946b40df9f80e6e994f57fc4c6e4ee3a2","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/regional-rehome-worker.ts"],"cases":[{"line":56,"title":"sends an idle request without claiming an assignment first","decision":"fix","reason":"Retain real HTTP dispatch path/body without a prior claim; supply a producer-valid complete safety snapshot and stop the worker in finally, so the source could actually parse the request and failures cannot leave its interval alive."},{"line":75,"title":"progresses past busy hosts without charging a dispatch failure","decision":"fix","reason":"Retain progression from a busy response to the second candidate without charging migration failure; supply complete safety data and stop the worker unconditionally in finally."},{"line":95,"title":"does not charge a lost response as a claimed migration failure","decision":"fix","reason":"Assert that the throwing fetch actually ran and produced the request-failed outcome/summary before checking no migration failure was charged; otherwise never-dispatched work passes this negative-only case. Supply complete safety data and stop the worker in finally."}],"reviewed_sha256":"6c4d6339e6a960dbf3523af84a1ba64cbc45c798049a5e0454cb74bbbd08f770","decision":"fix","rationale":"Retain real HTTP dispatch path/body without a prior claim; supply a producer-valid complete safety snapshot and stop the worker in finally, so the source could actually parse the request and failures cannot leave its interval alive. Retain progression from a busy response to the second candidate without charging migration failure; supply complete safety data and stop the worker unconditionally in finally. Assert that the throwing fetch actually ran and produced the request-failed outcome/summary before checking no migration failure was charged; otherwise never-dispatched work passes this negative-only case. Supply complete safety data and stop the worker in finally."} +{"path":"cloud/apps/relay/src/migration-recovery-postgres.test.ts","sha256":"8c80069a6a4758fb3dfdfc719de569da0773cfee64f512bc46a21e9bf63642d2","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts","cloud/apps/relay/src/registered-migration-inventory.ts","cloud/apps/relay/src/registered-migration-abandonment.ts"],"cases":[{"line":241,"title":"reaps an abandoned registered migration onto its healthy target","decision":"fix","reason":"Retain real PostgreSQL abandoned registered-migration recovery, exact completed marker and target assignment; extend suite cleanup to all produced host capability and cell-region rows and close its pool in finally."},{"line":274,"title":"reaps immediately after the retired source has a durable completed fence","decision":"keep","reason":"An actual completed durable source fence bypasses the ordinary abandonment delay and persists the correct completion marker."},{"line":305,"title":"reaps immediately after the retired source has an adopted legacy fence","decision":"keep","reason":"Committed legacy adoption is durable recovery evidence in both real inventory classification and actual migration cleanup."},{"line":352,"title":"does not reap after temporary legacy adoption without durable commit","decision":"keep","reason":"Temporary uncommitted legacy adoption cannot bypass the age guard, while advancing through the ordinary abandonment interval allows cleanup."},{"line":376,"title":"invalidates an adopted legacy fence when the source heartbeats","decision":"keep","reason":"A returning same-incarnation heartbeat deletes legacy adoption and restores delayed recovery."},{"line":403,"title":"invalidates an adopted legacy fence when the source restarts","decision":"keep","reason":"A newer source incarnation deletes old adoption and restores delayed recovery rather than inheriting obsolete evidence."},{"line":437,"title":"serializes legacy adoption with a returning source heartbeat","decision":"fix","reason":"Retain real concurrent adoption/heartbeat safety, but replace the tautological fulfilled-or-rejected status assertion with the exact allowed legacy_cell_fence_not_active error on rejection and a positive persisted-state invariant."},{"line":468,"title":"restores the 24-hour guard when the fenced source heartbeats again","decision":"keep","reason":"A returning source heartbeat invalidates completed-fence evidence and restores the full age guard before cleanup."},{"line":489,"title":"restores the 24-hour guard when the fenced source restarts","decision":"keep","reason":"A newer source incarnation invalidates completed-fence evidence and restores the full age guard before cleanup."},{"line":517,"title":"serializes fenced cleanup with a returning source heartbeat","decision":"keep","reason":"Concurrent real cleanup and returning heartbeat allow only a consistent completed target or protected pending migration, never a false intermediate verdict."},{"line":548,"title":"keeps a freshly retired source protected without a durable fence","decision":"keep","reason":"Without durable fence evidence a freshly retired source remains protected until the actual abandonment interval elapses."},{"line":566,"title":"rolls an abandoned disabled target back to its source","decision":"keep","reason":"An actually disabled abandoned target rolls back to the source at a new epoch and records abortion rather than completion."},{"line":600,"title":"serializes cleanup against supersession without reporting a false target","decision":"keep","reason":"Concurrent cleanup and aggregate supersession report a target consistent with the persisted assignment, and the losing supersession must return the exact superseded invariant."},{"line":648,"title":"completes a registered migration from a dead source idempotently","decision":"keep","reason":"A fenced dead-source migration completes through status reconciliation; repeated explicit completion is unchanged and retains only the healthy target activity reservation."},{"line":676,"title":"fails dead-source completion without a stale source heartbeat","decision":"fix","reason":"The setup fails at missing fence attestation before checking stale-heartbeat authority; narrow the title to requiring fence evidence so it describes the rejection path actually reached."},{"line":690,"title":"supersedes a registered migration with exact accounting and idempotency","decision":"keep","reason":"Real registered supersession releases old connection debt, creates exactly one successor epoch and preserves source/replacement counters across retry."},{"line":754,"title":"reconciles durable cell accounting before aggregate supersession","decision":"keep","reason":"Aggregate supersession repairs deliberately drifted durable reservation accounting before committing the replacement."},{"line":786,"title":"rebuilds an expired registered migration lease before supersession","decision":"keep","reason":"An expired registered migration with missing activity lease is repaired before supersession with independently specified replacement units."},{"line":825,"title":"retires an obsolete row without discarding replacement activity","decision":"keep","reason":"Retiring an obsolete old migration preserves every replacement activity and does not double-decrement its counters."},{"line":861,"title":"anchors a newer dormant failed-cell epoch and preserves drain evidence","decision":"keep","reason":"A newer dormant failed-cell epoch is anchored once, old rows retired and drain evidence/units copied to its eventual successor."},{"line":939,"title":"uses an existing current-epoch migration once when retiring an older row","decision":"keep","reason":"An existing current-epoch migration is reused exactly once when retiring an older row, producing one successor and correct counters."},{"line":996,"title":"rejects a newer failed-cell epoch with ambiguous activity","decision":"keep","reason":"Ambiguous activity attached to a newer failed-cell epoch refuses recovery and preserves all original rows/counters."},{"line":1022,"title":"leaves lease repair retryable when supersession later fails","decision":"keep","reason":"Lease repair persists its independently valid result even when later supersession fails capacity, and retry after capacity increase succeeds without duplication."},{"line":1076,"title":"serializes concurrent supersession retries without duplicating capacity","decision":"keep","reason":"Concurrent identical supersession retries return the same successor and reserve replacement capacity exactly once."},{"line":1107,"title":"fails a competing aggregate supersession instead of reporting the wrong target","decision":"keep","reason":"Two aggregate supersessions racing toward different targets produce one committed winner and one exact superseded rejection whose reported assignment matches the durable successor."},{"line":1164,"title":"rolls back every supersession change when replacement capacity is insufficient","decision":"keep","reason":"Replacement capacity exhaustion rolls back assignment, migration abortion and every affected cell counter."},{"line":1199,"title":"rolls back supersession when migration request-unit shape drifted","decision":"keep","reason":"A deliberately drifted migration-unit shape refuses supersession and preserves all pre-operation accounting/authority."},{"line":1234,"title":"rolls back supersession when locked cell reservation accounting drifted","decision":"keep","reason":"Drifted locked cell accounting refuses supersession and preserves the original migration rather than partially reserving a replacement."},{"line":1264,"title":"rejects supersession before incrementing the maximum safe epoch","decision":"keep","reason":"Maximum-safe epoch input is refused before an unsafe increment can reach durable state."}],"reviewed_sha256":"8a61b80052eac264d4e92f3b8c181130a2117b0e9648a1050f05e3d7b001ed33","decision":"fix","rationale":"Retain real PostgreSQL abandoned registered-migration recovery, exact completed marker and target assignment; extend suite cleanup to all produced host capability and cell-region rows and close its pool in finally. Retain real concurrent adoption/heartbeat safety, but replace the tautological fulfilled-or-rejected status assertion with the exact allowed legacy_cell_fence_not_active error on rejection and a positive persisted-state invariant. The setup fails at missing fence attestation before checking stale-heartbeat authority; narrow the title to requiring fence evidence so it describes the rejection path actually reached."} +{"path":"cloud/apps/relay/src/placement-load-band.test.ts","sha256":"b2642e82ad5844448da6e7e1c47a998b3b96154bc677a8bf29554ec9d856ca67","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/placement-load-band.ts","cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":76,"title":"spreads a drain over an empty cell and four fuller cells within one window","decision":"keep","reason":"Real load-band picks redistribute a large fixed-window burst across fuller candidates rather than concentrating it on an empty cell."},{"line":96,"title":"keeps the empty cell near the share across five directors at the %s pace","decision":"keep","reason":"Both independent drain paces and all three seeded director populations preserve the expected empty-cell share across real pick decisions.","parameter_table":{"source":"[\n ['1,200 s', 1_200_000],\n ['300 s', 300_000]\n ]","rows":[{"index":1,"input":"['1,200 s', 1_200_000]","decision":"keep","reason":"Both independent drain paces and all three seeded director populations preserve the expected empty-cell share across real pick decisions."},{"index":2,"input":"['300 s', 300_000]","decision":"keep","reason":"Both independent drain paces and all three seeded director populations preserve the expected empty-cell share across real pick decisions."}]},"body_cases":[{"input":{"pace_ms":1200000,"seed":1,"effective_seed":10},"decision":"keep","reason":"Independent seeded runs at both paces exercise actual selection distribution and intake-budget decay across five directors."},{"input":{"pace_ms":1200000,"seed":2,"effective_seed":20},"decision":"keep","reason":"Independent seeded runs at both paces exercise actual selection distribution and intake-budget decay across five directors."},{"input":{"pace_ms":1200000,"seed":3,"effective_seed":30},"decision":"keep","reason":"Independent seeded runs at both paces exercise actual selection distribution and intake-budget decay across five directors."},{"input":{"pace_ms":300000,"seed":1,"effective_seed":10},"decision":"keep","reason":"Independent seeded runs at both paces exercise actual selection distribution and intake-budget decay across five directors."},{"input":{"pace_ms":300000,"seed":2,"effective_seed":20},"decision":"keep","reason":"Independent seeded runs at both paces exercise actual selection distribution and intake-budget decay across five directors."},{"input":{"pace_ms":300000,"seed":3,"effective_seed":30},"decision":"keep","reason":"Independent seeded runs at both paces exercise actual selection distribution and intake-budget decay across five directors."}]},{"line":109,"title":"gives the empty cell about 60% when only one other cell is eligible","decision":"keep","reason":"With only one competing eligible cell, actual intake-share decisions give the empty cell the independently specified 55-65 percent range."},{"line":120,"title":"logs one summary a minute with skips, fallbacks and band size","decision":"keep","reason":"Real observed decisions emit one clock-window diagnostic with skip/fallback activity and bounded band size."},{"line":139,"title":"never places past capacity while the fuller cells fill","decision":"remove","reason":"Remove this simulated hard-cap claim: simulate() itself prefilters full cells and allocates exactly their total spare capacity, so any selector necessarily ends at these counters. The retained actual assignment-store integration below independently proves cap enforcement and spillover."},{"line":151,"title":"falls back to the least-loaded cell when every candidate is over budget","decision":"keep","reason":"A sole over-budget candidate remains serviceable through the fallback rather than becoming unavailable, and an empty pool returns no candidate."},{"line":160,"title":"keeps quiet placement on the least-loaded cell outside the band","decision":"keep","reason":"Sparse arrivals age out intake pressure and preserve least-loaded choice even when another cell sits outside the band."},{"line":173,"title":"picks at random among cells inside the band","decision":"keep","reason":"Independently ranked candidates and seeded draws select both near-minimum cells while excluding the out-of-band one."},{"line":230,"title":"spreads within the preferred region and keeps an empty US cell out","decision":"fix","reason":"Retain actual regional assignment distribution and exclusion of the empty foreign-region cell; close the opened in-memory database unconditionally."},{"line":240,"title":"fills the preferred region to its hard cap before spilling, never past it","decision":"fix","reason":"Retain actual assignment-store hard-cap enforcement over all five regional cells with exact foreign-region spillover; close the opened in-memory database unconditionally."}],"reviewed_sha256":"f8aba58bbb49fb869e8db1f43e224432fb8074e9cc041865fe58b484fb64dbf9","decision":"consolidate","rationale":"Remove this simulated hard-cap claim: simulate() itself prefilters full cells and allocates exactly their total spare capacity, so any selector necessarily ends at these counters. The retained actual assignment-store integration below independently proves cap enforcement and spillover. Retain actual regional assignment distribution and exclusion of the empty foreign-region cell; close the opened in-memory database unconditionally. Retain actual assignment-store hard-cap enforcement over all five regional cells with exact foreign-region spillover; close the opened in-memory database unconditionally."} +{"path":"cloud/apps/relay/src/post-proof-close-log.test.ts","sha256":"34c4a6788d688d8ff25de1538a435dffe3cea303b65f69c3b2ee3cf43d79ba50","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/post-proof-close-log.ts","cloud/apps/relay/src/assignment/assignment-rejection-log-window.ts"],"cases":[{"line":36,"title":"counts every close but writes one line per reason and cause per window","decision":"keep","reason":"Actual log-window decisions count all 1002 events while bounding per-reason/cause opening lines and emitting one closing suppressed-count/latest-generation sample."},{"line":55,"title":"names the host by digest and keeps peer-supplied versions printable","decision":"keep","reason":"Actual formatted output digests host identity and strips peer-controlled newline/control characters from the build string."}],"reviewed_sha256":"34c4a6788d688d8ff25de1538a435dffe3cea303b65f69c3b2ee3cf43d79ba50","decision":"keep","rationale":"Actual log-window decisions count all 1002 events while bounding per-reason/cause opening lines and emitting one closing suppressed-count/latest-generation sample. Actual formatted output digests host identity and strips peer-controlled newline/control characters from the build string."} +{"path":"cloud/apps/relay/src/postgres-checked-out-client-error.test.ts","sha256":"cee18f05c444278d86ba3506a941d616b3ba5304659d79325e2fb3e206368d1c","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts","cloud/apps/relay/src/postgres-pool-pressure.ts"],"cases":[{"line":30,"title":"absorbs the error, rejects the transaction, and releases the client as failed","decision":"fix","reason":"Retain actual EventEmitter error absorption, original transaction rejection, failed-client destruction and no rollback on an ended connection; restore the console spy in finally rather than only after every assertion passes."},{"line":61,"title":"releases a healthy client back to the pool with no error","decision":"keep","reason":"A healthy real transaction wrapper returns rows and releases its client once without an error or leftover error listener."}],"reviewed_sha256":"0b7da794a86f39ffb6c583f70803e3a6a1755ebdfbaa0e4c25c8a79f0b891581","decision":"fix","rationale":"Retain actual EventEmitter error absorption, original transaction rejection, failed-client destruction and no rollback on an ended connection; restore the console spy in finally rather than only after every assertion passes."} +{"path":"cloud/apps/relay/src/postgres-commit-with-final-write-postgres.test.ts","sha256":"a2fc81bfaca3d3c0270e751ab3fe39edcb51302deffe73180fa7f52ddb366b33","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts"],"cases":[{"line":64,"title":"commits the earlier statements and the counter together in one message","decision":"fix","reason":"Retain actual PostgreSQL one-message counter/COMMIT, quoted-key interpolation, prior-write persistence and no duplicate commit; restore the global pg.Client.query spy in finally/on every test outcome."},{"line":84,"title":"rolls back over cap and lets the caller read the row outside the transaction","decision":"keep","reason":"An actual over-cap write rolls back its earlier insert and permits an outside-transaction read without retrying the rejected capacity decision."},{"line":103,"title":"reports a missing row the same way","decision":"keep","reason":"An actual missing counter row rolls back earlier work and permits an outside-transaction missing-row decision."},{"line":116,"title":"retries a deadlock or lock timeout raised by the fused message and commits once","decision":"fix","reason":"Force the retryable error through the fused message itself and assert that transaction retries; the current real deadlock can always select the other transaction as victim, allowing the claimed fused-deadlock path to remain unexercised. Preserve the real final exactly-once counter result."},{"line":146,"title":"retries a lock timeout raised by the fused message","decision":"keep","reason":"A real held counter row raises a fused lock timeout; the second attempt releases the blocker and commits exactly one increment."},{"line":166,"title":"never retries when the connection is lost under the fused message","decision":"fix","reason":"Replace the arbitrary 200ms detached termination timer with an observed backend lock-wait boundary and awaited termination, with unconditional blocker/promise cleanup, so termination cannot miss the fused message or produce unhandled admin-query rejection."},{"line":193,"title":"refuses a statement after the fused commit","decision":"keep","reason":"After an actual fused commit, later transaction-handle statements fail and cannot apply an accidental autocommit write."}],"reviewed_sha256":"8dd628f605cc2c94a75f7612b831aca9bb522ad68bbd136935460ac418f4896c","decision":"fix","rationale":"Retain actual PostgreSQL one-message counter/COMMIT, quoted-key interpolation, prior-write persistence and no duplicate commit; restore the global pg.Client.query spy in finally/on every test outcome. Force the retryable error through the fused message itself and assert that transaction retries; the current real deadlock can always select the other transaction as victim, allowing the claimed fused-deadlock path to remain unexercised. Preserve the real final exactly-once counter result. Replace the arbitrary 200ms detached termination timer with an observed backend lock-wait boundary and awaited termination, with unconditional blocker/promise cleanup, so termination cannot miss the fused message or produce unhandled admin-query rejection."} +{"path":"cloud/apps/relay/src/postgres-drain-send-locking.test.ts","sha256":"a02f2a140ccbf171db79a8a41c8c78d0bb85078e4100ac0340d9c6a807f36bfd","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":70,"title":"locks active migrations without locking the nullable incarnation lookup","decision":"fix","reason":"Retain actual PostgreSQL migration locking, one send permit, receipt refusal and produced drain pin; scope the final pin read to this fixture identity and clean produced region rows so unrelated real suites cannot affect the assertion."},{"line":140,"title":"restores an expired registered migration lease with PostgreSQL locks","decision":"fix","reason":"Real expired migration activity is removed, then the actual locked drain-send path restores its target migration lease; retain with complete shared fixture cleanup including cell regions."}],"reviewed_sha256":"b0ecdbafdff311bfd70f98ed11626a13c4dbf80a555108e3c59c50fe587ab1c0","decision":"fix","rationale":"Retain actual PostgreSQL migration locking, one send permit, receipt refusal and produced drain pin; scope the final pin read to this fixture identity and clean produced region rows so unrelated real suites cannot affect the assertion. Real expired migration activity is removed, then the actual locked drain-send path restores its target migration lease; retain with complete shared fixture cleanup including cell regions."} +{"path":"cloud/apps/relay/src/postgres-idle-client-error.test.ts","sha256":"3cd23450d732ea42c1ebbd6c136d4451564fe8fd80e33984d8037cdcff40d7d2","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/database.ts"],"cases":[{"line":5,"title":"absorbs the pool error without logging connection details","decision":"fix","reason":"Use an actual pg.Pool EventEmitter and emit its error event, with no connection opened; this catches wrong-event subscriptions and verifies fixed redacted warning output. Restore the warning spy and close the pool in finally."}],"reviewed_sha256":"57d81afc1b9dfbcf275b7f814c9c2dbb634fbf51fc23f48c11ac5883da32eccf","decision":"fix","rationale":"Use an actual EventEmitter pool and emit its error event rather than invoking whichever callback a stub on() captured; the current fixture also passes if production subscribes to the wrong event. Retain fixed redacted warning and restore the spy in finally."} +{"path":"cloud/apps/relay/src/postgres-lock-wait-sample-postgres.test.ts","sha256":"aa71d6d74c586b1102b4a8a58f51e6e2dec7a0ecd721ae37732c72ca5699b87e","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/postgres-lock-wait-sample.ts","cloud/apps/relay/src/assignment-store.ts"],"cases":[{"line":43,"title":"attributes a convoy of directors to the cell holding the relay_cells row","decision":"fix","reason":"Real PostgreSQL application_name, tuple-lock convoy and recursive blocker-chain sampling attribute all three director waiters to the root cell holder; retain finally-based holder/waiter release and extend fixture cleanup to its produced cell-region/admission rows."}],"reviewed_sha256":"e2830bcfa3bae572dd31bc2c4178248ab534ea87b9a72de4b6030993d036e0c8","decision":"fix","rationale":"Real PostgreSQL application_name, tuple-lock convoy and recursive blocker-chain sampling attribute all three director waiters to the root cell holder; retain finally-based holder/waiter release and extend fixture cleanup to its produced cell-region/admission rows."} +{"path":"cloud/apps/relay/src/postgres-lock-wait-sample.test.ts","sha256":"b5a1cf90b57c891a5fa5fa849cc79338cf7b21de21596562890946f5dd8e8e37","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","status":"reviewed","evidence":["cloud/apps/relay/src/postgres-lock-wait-sample.ts"],"cases":[{"line":16,"title":"keeps combined-role sessions as their own class and folds unknown roles into other","decision":"keep","reason":"Boundary-row normalization preserves the combined role and collapses unknown/null waiter/holder identities into bounded other keys; real query/lock-chain behavior is independently retained in the PostgreSQL integration suite."}],"reviewed_sha256":"b5a1cf90b57c891a5fa5fa849cc79338cf7b21de21596562890946f5dd8e8e37","decision":"keep","rationale":"Boundary-row normalization preserves the combined role and collapses unknown/null waiter/holder identities into bounded other keys; real query/lock-chain behavior is independently retained in the PostgreSQL integration suite."} +{"path":"cloud/apps/relay/src/test-fixtures/delayed-postgres-database.ts","sha256":"30b9024e1574be2caf3cdf3983ff7a7f1caa92b33ad4894bd8a29c8c69401ae4","classification":"support","decision":"keep","status":"reviewed","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","reviewed_sha256":"30b9024e1574be2caf3cdf3983ff7a7f1caa92b33ad4894bd8a29c8c69401ae4","cases":[],"rationale":"Shared integration fixture wraps a real PostgreSQL pool/client and delays actual queries, including transaction messages, to model cross-region RTT. No independent runnable cases; retain and classify as support.","evidence":["cloud/apps/relay/src/test-fixtures/delayed-postgres-database.ts"]} +{"path":"cloud/apps/relay/src/test-fixtures/host-control-proof.ts","sha256":"995e8d5e545fcc70728ea8d987cd8b151176b48df5a1a369ebe0fe556d93c5fa","classification":"support","decision":"keep","status":"reviewed","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","reviewed_sha256":"995e8d5e545fcc70728ea8d987cd8b151176b48df5a1a369ebe0fe556d93c5fa","cases":[],"rationale":"Shared proof fixture drives the real registry hello/challenge with actual NaCl decrypt and protocol HMAC; mocks external persistence outcomes only. No independent runnable cases; retain and classify as support.","evidence":["cloud/apps/relay/src/test-fixtures/host-control-proof.ts"]} +{"path":"cloud/apps/relay/src/idle-regional-rehome-test-database.ts","sha256":"343bdc997f3beb8f1ec4714f95b9d7d70d4500f613637f89233d23b1ada0adf0","classification":"support","decision":"keep","status":"reviewed","source_commit":"6d473f4bea1d190cb3649af97e04f1cdde170c5f","reviewer":"audit_cloud","reviewed_sha256":"343bdc997f3beb8f1ec4714f95b9d7d70d4500f613637f89233d23b1ada0adf0","cases":[],"rationale":"Database fixture chooses actual in-memory SQLite or an explicitly configured localhost:55440 PostgreSQL database with a unique disposable schema and close/failure cleanup. No independent runnable cases.","evidence":["cloud/apps/relay/src/idle-regional-rehome-test-database.ts"]} diff --git a/docs/audits/test-value/reviews/config-0003-validation.json b/docs/audits/test-value/reviews/config-0003-validation.json new file mode 100644 index 00000000000..90112432edb --- /dev/null +++ b/docs/audits/test-value/reviews/config-0003-validation.json @@ -0,0 +1,300 @@ +{ + "batch": "config-0003", + "reviewer": "audit_config", + "platform": "Linux", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "upstream_reconciliation": "All 50 saved original hashes match the new audit-3 checkout and Git bytes at the source commit; no upstream candidate changes required reconciliation.", + "reviewed_files": 50, + "standard_suite_files": 42, + "standalone_or_support_files": 8, + "original_declarations": 328, + "final_declarations": 317, + "case_decisions": { + "keep": 301, + "fix": 16, + "consolidate": 7, + "remove": 4 + }, + "changed_test_files": [ + "config/scripts/computer-use-smoke.test.mjs", + "config/scripts/counterbalanced-benchmark-schedule.test.mjs", + "config/scripts/create-draft-release.test.mjs", + "config/scripts/daily-build-version.test.mjs", + "config/scripts/dev-channel-base-version.test.mjs", + "config/scripts/dev-electron-bundle-identity.test.ts", + "config/scripts/electron-builder-config.test.mjs", + "config/scripts/ensure-native-runtime-job-ownership.test.mjs", + "config/scripts/generate-bundled-skill-guides.test.mjs", + "config/scripts/generate-runtime-required-english-catalog.test.mjs", + "config/scripts/generated-artifact-line-ending-pin.test.mjs", + "config/scripts/happy-dom-mutation-observer-retention.test.ts", + "config/scripts/happy-dom-offscreen-canvas.test.ts" + ], + "test_diff": { + "added": 87, + "deleted": 167, + "net": -80 + }, + "checks": [ + { + "command": [ + "node", + "config/scripts/run-vitest.mjs", + "run", + "--config", + "config/vitest.config.ts", + "config/scripts/computer-use-smoke.test.mjs", + "config/scripts/counterbalanced-benchmark-schedule.test.mjs", + "config/scripts/create-draft-release.test.mjs", + "config/scripts/daemon-protocol-facts.test.mjs", + "config/scripts/daily-build-version.test.mjs", + "config/scripts/dark-build-switches.test.mjs", + "config/scripts/dependency-security-audit.test.mjs", + "config/scripts/dependency-security-patches.test.mjs", + "config/scripts/dependency-security-release.test.mjs", + "config/scripts/dev-channel-base-version.test.mjs", + "config/scripts/dev-channel-orcad-template-workflow.test.mjs", + "config/scripts/dev-channel-windows-staging.test.mjs", + "config/scripts/dev-cli-terminal-wrapper.test.mjs", + "config/scripts/dev-electron-bundle-cache.test.ts", + "config/scripts/dev-electron-bundle-identity.test.ts", + "config/scripts/dev-storage-reclaim.test.mjs", + "config/scripts/dev-web-client-freshness.test.mjs", + "config/scripts/e2e-cli-artifact-capability.test.mjs", + "config/scripts/electron-builder-config.test.mjs", + "config/scripts/electron-builder-mac-channel-config.test.mjs", + "config/scripts/electron-builder-native-rebuild.test.mjs", + "config/scripts/electron-builder-runtime-resources.test.mjs", + "config/scripts/electron-builder-speech-config.test.mjs", + "config/scripts/electron-runtime-floor.test.ts", + "config/scripts/electron-vite-development-config.test.ts", + "config/scripts/electron-vite-output-contract.test.ts", + "config/scripts/ensure-native-runtime-job-ownership.test.mjs", + "config/scripts/ensure-native-runtime.test.mjs", + "config/scripts/ephemeral-vm-runtime-store-cross-version.test.ts", + "config/scripts/foreign-sqlite-reader-worker-smoke.test.mjs", + "config/scripts/generate-bundled-skill-guides.test.mjs", + "config/scripts/generate-monaco-associations.test.mjs", + "config/scripts/generate-runtime-required-english-catalog.test.mjs", + "config/scripts/generate-skill-bundle-manifest.test.mjs", + "config/scripts/generate-terminal-perf-html-report.test.mjs", + "config/scripts/generated-artifact-line-ending-pin.test.mjs", + "config/scripts/git-pull-request-diff-base.test.mjs", + "config/scripts/github-opened-issue-repository.test.ts", + "config/scripts/github-pr-assignee-repository.test.ts", + "config/scripts/hang-watchdog-process-metrics.test.mjs", + "config/scripts/happy-dom-mutation-observer-retention.test.ts", + "config/scripts/happy-dom-offscreen-canvas.test.ts" + ], + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "exit_code": 0, + "elapsed_seconds": 12.52, + "log": "/tmp/orca-config-0003-tests.log", + "result": "41 suites passed, 1 intentionally disabled suite skipped; 378 tests passed, 6 skipped" + }, + { + "command": [ + "node", + "config/scripts/run-vitest.mjs", + "run", + "--config", + "config/vitest.config.ts", + "config/scripts/electron-builder-config.test.mjs" + ], + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "result": "Final compact FileMatcher fixture: 37 tests passed, 1 Windows-only test skipped", + "exit_code": 0, + "log": "/tmp/orca-config-0003-builder-final.log" + }, + { + "command": [ + "node", + "config/scripts/run-vitest.mjs", + "run", + "--config", + "config/vitest.config.ts", + "config/scripts/computer-use-smoke.test.mjs", + "config/scripts/dev-channel-base-version.test.mjs" + ], + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1", + "ORCA_COMPUTER_SMOKE_APPS": "ambient-override-must-not-select-any-app", + "ORCA_PUBLISHED_VERSIONS": "v99.0.0 v98.0.0" + }, + "result": "15 tests passed despite unrelated ambient values; actual default smoke targets and environment parser defaults are isolated", + "exit_code": 0, + "log": "/tmp/orca-config-0003-ambient-env-final.log" + }, + { + "command": [ + "pnpm", + "run", + "check:code-quality:changed", + "--", + "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b" + ], + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "result": "Passed; every code-quality/casting/plugins/type-aware/React Doctor/design-system/SAFETY scan reported 0 new findings across 22 changed files at that concurrent-worktree snapshot", + "exit_code": 0, + "log": "/tmp/orca-config-0003-code-quality-final.log" + }, + { + "command": [ + "pnpm", + "run", + "check:react-doctor:changed", + "--", + "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b" + ], + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "result": "Passed; 0 changed-line errors", + "exit_code": 0, + "log": "/tmp/orca-config-0003-react-doctor-final.log" + }, + { + "command": [ + "pnpm", + "exec", + "oxlint", + "config/scripts/computer-use-smoke.test.mjs", + "config/scripts/counterbalanced-benchmark-schedule.test.mjs", + "config/scripts/create-draft-release.test.mjs", + "config/scripts/daily-build-version.test.mjs", + "config/scripts/dev-channel-base-version.test.mjs", + "config/scripts/dev-electron-bundle-identity.test.ts", + "config/scripts/electron-builder-config.test.mjs", + "config/scripts/ensure-native-runtime-job-ownership.test.mjs", + "config/scripts/generate-bundled-skill-guides.test.mjs", + "config/scripts/generate-runtime-required-english-catalog.test.mjs", + "config/scripts/generated-artifact-line-ending-pin.test.mjs", + "config/scripts/happy-dom-mutation-observer-retention.test.ts", + "config/scripts/happy-dom-offscreen-canvas.test.ts" + ], + "exit_code": 0, + "stdout": "", + "stderr": "", + "result": "passed" + }, + { + "command": [ + "pnpm", + "exec", + "oxfmt", + "--check", + "config/scripts/computer-use-smoke.test.mjs", + "config/scripts/counterbalanced-benchmark-schedule.test.mjs", + "config/scripts/create-draft-release.test.mjs", + "config/scripts/daily-build-version.test.mjs", + "config/scripts/dev-channel-base-version.test.mjs", + "config/scripts/dev-electron-bundle-identity.test.ts", + "config/scripts/electron-builder-config.test.mjs", + "config/scripts/ensure-native-runtime-job-ownership.test.mjs", + "config/scripts/generate-bundled-skill-guides.test.mjs", + "config/scripts/generate-runtime-required-english-catalog.test.mjs", + "config/scripts/generated-artifact-line-ending-pin.test.mjs", + "config/scripts/happy-dom-mutation-observer-retention.test.ts", + "config/scripts/happy-dom-offscreen-canvas.test.ts" + ], + "exit_code": 0, + "stdout": "Checking formatting...\n\nAll matched files use the correct format.\nFinished in 19ms on 13 files using 24 threads.\n", + "stderr": "", + "result": "passed" + }, + { + "command": [ + "git", + "diff", + "--check", + "--", + "config/scripts/computer-use-smoke.test.mjs", + "config/scripts/counterbalanced-benchmark-schedule.test.mjs", + "config/scripts/create-draft-release.test.mjs", + "config/scripts/daily-build-version.test.mjs", + "config/scripts/dev-channel-base-version.test.mjs", + "config/scripts/dev-electron-bundle-identity.test.ts", + "config/scripts/electron-builder-config.test.mjs", + "config/scripts/ensure-native-runtime-job-ownership.test.mjs", + "config/scripts/generate-bundled-skill-guides.test.mjs", + "config/scripts/generate-runtime-required-english-catalog.test.mjs", + "config/scripts/generated-artifact-line-ending-pin.test.mjs", + "config/scripts/happy-dom-mutation-observer-retention.test.ts", + "config/scripts/happy-dom-offscreen-canvas.test.ts" + ], + "exit_code": 0, + "stdout": "", + "stderr": "", + "result": "passed" + }, + { + "command": "Parse original/final candidates using the actual refresh.mjs declaration parser without running inventory refresh; verify original Git SHA-256, all original line/title decisions, retained consolidation destinations, and final filesystem SHA-256", + "result": "50 original and 50 final hashes match; 328 original declarations have decisions; 317 remain after 7 consolidations and 4 removals; all retained destination declarations exist", + "exit_code": 0, + "artifacts": [ + "/tmp/orca-config-0003-final-cases.json", + "docs/audits/test-value/reviews/config-0003.jsonl" + ] + } + ], + "intentional_skips": [ + "Four Windows TrackFileAccess rebuild table rows in ensure-native-runtime.test.mjs", + "One Windows-only foreign-architecture workspace-addon case in electron-builder-config.test.mjs", + "One environment-driven ephemeral VM cross-version driver; the external version-sequencing harness was reviewed, not executed" + ], + "standalone_execution": "Unchanged standalone daemon smokes and manual benchmarks were classified/read, not executed. The foreign SQLite smoke support is exercised by its actual built-worker suite. Prototype tree-projection timings do not constitute production validation; daemon PTY health remains advisory.", + "coverage_preserved": [ + "Release predecessor policy, publication race and rollback safeguards, pagination, and tag/commit identity", + "Security severity/exact exceptions/integrity and trusted release data extraction", + "Real FileMatcher/copy/prune/staged module/native/runtime/ASAR boundaries", + "ARM64 missing-rebuild fallback diagnostic, PE machine and malformed-binary distinction, real C++ patch marker encoding", + "Byte-stable dev signatures and independent safeStorage display identity", + "Actual generated daily ordering, January/July Pacific offsets, and max-based history numbering", + "Guide generation/reference/alias and real Git autocrlf byte behavior", + "Actual post-GC MutationObserver delivery and OffscreenCanvas/xterm integration", + "Mixed-version runtime-store persistence driver, actual SQLite workers, and actual component-to-gh repository routing" + ], + "changes": [ + "Remove copied obsolete benchmark/RC comparator demonstrations", + "Consolidate stable-release predecessor and repeated native diagnostic scenarios", + "Remove fixture-only identity restoration and duplicate plural/stable-floor/title checks", + "Use generated daily versions, isolated ambient environments, and actual FileMatcher filtering", + "Move five guide EOL path classes into actual Git checkout coverage", + "Require actual GC and OffscreenCanvas instead of silently bypassing the intended regression" + ], + "resolved_validation_issue": { + "command": [ + "pnpm", + "exec", + "oxlint", + "config/scripts/computer-use-smoke.test.mjs", + "config/scripts/counterbalanced-benchmark-schedule.test.mjs", + "config/scripts/create-draft-release.test.mjs", + "config/scripts/daily-build-version.test.mjs", + "config/scripts/dev-channel-base-version.test.mjs", + "config/scripts/dev-electron-bundle-identity.test.ts", + "config/scripts/electron-builder-config.test.mjs", + "config/scripts/ensure-native-runtime-job-ownership.test.mjs", + "config/scripts/generate-bundled-skill-guides.test.mjs", + "config/scripts/generate-runtime-required-english-catalog.test.mjs", + "config/scripts/generated-artifact-line-ending-pin.test.mjs", + "config/scripts/happy-dom-mutation-observer-retention.test.ts", + "config/scripts/happy-dom-offscreen-canvas.test.ts" + ], + "initial_result": "Actual matcher fixture initially brought electron-builder-config.test.mjs to 607 counted lines versus its 600-line limit.", + "resolution": "Reuse the existing local packs adapter pattern and direct positive path assertions; the final raw lint, formatter, builder tests and both changed-line gates passed.", + "initial_log": "/tmp/orca-config-0003-static-checks.json" + }, + "production_changes": "none", + "temporary_production_mutations": "none; actual behavioral fixtures exercise retained boundaries", + "commits_or_branch_changes": "none by audit_config", + "inventory_or_readme_edits": "none by audit_config", + "next_pending_path": "config/scripts/headless-detector-compiler-cache.test.mjs", + "log_note": "Exact commands/results and limitations are durable here; /tmp paths point to session evidence. Root coordinates force-add, global validation, inventory refresh, commits and PRs." +} diff --git a/docs/audits/test-value/reviews/config-0003.jsonl b/docs/audits/test-value/reviews/config-0003.jsonl new file mode 100644 index 00000000000..68f77d1579f --- /dev/null +++ b/docs/audits/test-value/reviews/config-0003.jsonl @@ -0,0 +1,50 @@ +{"path": "config/scripts/computer-use-smoke.test.mjs", "sha256": "1e5e01e9306fec03973fdcc10ffb9217e66e152a32e8c44e80c48be3b800f383", "cases": [{"line": 11, "title": "can launch a runtime before checking apps", "decision": "keep", "reason": "Executes the actual smoke subprocess with a CLI stand-in and verifies runtime launch precedes app listing.", "reviewed_line": 11}, {"line": 55, "title": "fails closed when a target app is required but none are available", "decision": "keep", "reason": "Executes --require-target with no available preferred app and requires failure rather than permissive success.", "reviewed_line": 55}, {"line": 73, "title": "keeps no-target smoke permissive by default for local probing", "decision": "keep", "reason": "Executes default no-target mode and requires successful diagnostic output for local probing.", "reviewed_line": 73}, {"line": 91, "title": "skips background apps that report window_not_found instead of failing smoke", "decision": "keep", "reason": "Exercises actual window_not_found error parsing while requiring another target snapshot to succeed.", "reviewed_line": 91}, {"line": 119, "title": "uses cross-platform default app targets for smoke snapshots", "decision": "fix", "reason": "Removes ambient ORCA_COMPUTER_SMOKE_APPS from the child env so the actual Notepad default-target oracle always exercises defaults.", "reviewed_line": 119}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "4d381c651f21d9fe12a602652f30f0d8a3a46bd48ce698224e1104c030fabd07", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Retain actual smoke subprocess success/failure paths and isolate the default-target fixture from an ambient app override.", "evidence": ["config/scripts/computer-use-smoke.mjs"], "original_declarations": 5, "reviewed_declarations": 5, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/counterbalanced-benchmark-schedule.mjs", "sha256": "bc35b40e954fa7ddec0225ed375bd3b113c2e05b8554bc50734d14f89987294d", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "bc35b40e954fa7ddec0225ed375bd3b113c2e05b8554bc50734d14f89987294d", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "production-support", "rationale": "Production schedule helper used by benchmark callers and its separate test suite; preserve actual implementation rather than inventing test declarations.", "evidence": ["config/scripts/counterbalanced-benchmark-schedule.test.mjs"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "support_contract": "Production support module, not a runnable suite; actual scheduling behavior is exercised by its retained separate test suite."} +{"path": "config/scripts/counterbalanced-benchmark-schedule.test.mjs", "sha256": "fabc00232748f05fb3a4c3e715db67c45592b3284d6820db386692d8942ec7c0", "cases": [{"line": 22, "title": "builds complete ABBA blocks", "decision": "keep", "reason": "Checks actual generated arm order across complete alternating AB/BA blocks.", "reviewed_line": 22}, {"line": 31, "title": "rejects counts that cannot balance launch positions", "decision": "keep", "reason": "All zero, odd, and fractional count rows exercise actual positive-even validation.", "reviewed_line": 31}, {"line": 39, "title": "requires distinct arms", "decision": "keep", "reason": "Exercises actual duplicate-arm rejection.", "reviewed_line": 39}, {"line": 43, "title": "gives each arm the same mean launch position", "decision": "keep", "reason": "Uses the real schedule to prove both arms occupy equal average launch positions.", "reviewed_line": 43}, {"line": 51, "title": "cancels linear drift in the reported median difference", "decision": "fix", "reason": "Keeps real summarizeBenchmarkSamples median drift cancellation; removes only the copied obsolete lowerMedian implementation/assertion.", "reviewed_line": 51}, {"line": 67, "title": "bounds the descriptive p95 bias to one linear-drift launch slot", "decision": "keep", "reason": "Checks real nearest-rank p95 drift against the one-slot bound and its published aggregation contract.", "reviewed_line": 62}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "0292512350fad9e1a8ac205a55d975ce4c214f0fb2f4fba8ebbd1f5b98aa9501", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Retain real scheduling/aggregation drift oracles; remove a local obsolete lower-median implementation demonstration.", "evidence": ["config/scripts/counterbalanced-benchmark-schedule.mjs", "config/scripts/benchmark-sample-summary.mjs"], "original_declarations": 6, "reviewed_declarations": 6, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/create-draft-release.test.mjs", "sha256": "eb1ef315b70a68f733ff5c009d5a61982ef8c52f10568a3f6048b7d16f35fff5", "cases": [{"line": 28, "title": "leaves short release notes unchanged", "decision": "keep", "reason": "Protects unchanged short-body output at the public truncation boundary.", "reviewed_line": 28}, {"line": 32, "title": "caps long release notes and appends an explanation", "decision": "keep", "reason": "Checks actual capped output length and user-facing truncation notice.", "reviewed_line": 32}, {"line": 41, "title": "parses stable and rc desktop release tags only", "decision": "keep", "reason": "Exercises stable/RC parsing and rejection of unrelated mobile release tags.", "reviewed_line": 41}, {"line": 61, "title": "bounds stable notes to the previous stable release when rcs exist", "decision": "fix", "reason": "Retains the actual previous-stable oracle with both RC.0 and RC.6 inputs from the consolidated duplicate.", "reviewed_line": 61}, {"line": 70, "title": "does not collapse a stable changelog to its rc-to-stable version bump", "decision": "consolidate", "reason": "Consolidated into original line 61 with multiple RCs retained; both exercise the same stable predecessor policy.", "coverage_target": {"path": "config/scripts/create-draft-release.test.mjs", "line": 61}}, {"line": 84, "title": "bounds the first rc notes to the previous stable release", "decision": "keep", "reason": "Protects the first RC boundary at the preceding stable release while ignoring a non-desktop release.", "reviewed_line": 70}, {"line": 93, "title": "bounds later rc notes to the prior rc", "decision": "keep", "reason": "Protects later RC notes bounded to the preceding RC rather than a stable release.", "reviewed_line": 79}, {"line": 102, "title": "ignores draft releases as public changelog boundaries", "decision": "keep", "reason": "Checks actual draft exclusion when choosing the public changelog boundary.", "reviewed_line": 88}, {"line": 111, "title": "returns empty string for the first desktop release when no earlier tag exists", "decision": "keep", "reason": "Exercises empty and first-desktop histories without inventing a predecessor.", "reviewed_line": 97}, {"line": 121, "title": "returns empty string when the current tag is not a desktop release tag", "decision": "keep", "reason": "Exercises non-desktop current-tag rejection independently of history contents.", "reviewed_line": 107}, {"line": 132, "title": "creates a draft release with bounded generated notes", "decision": "keep", "reason": "Runs actual release orchestration and checks external API URL/body, predecessor, target, and bounded notes.", "reviewed_line": 118}, {"line": 187, "title": "marks rc tags as prereleases", "decision": "keep", "reason": "Requires RC creation to request GitHub prerelease status at the actual API boundary.", "reviewed_line": 173}, {"line": 207, "title": "regenerates notes for an existing draft release", "decision": "keep", "reason": "Checks regenerated notes are patched onto an existing draft release.", "reviewed_line": 193}, {"line": 238, "title": "skips the update when the draft was published while notes were generated", "decision": "keep", "reason": "Exercises the publication race before PATCH and requires preserving the newly published release.", "reviewed_line": 224}, {"line": 264, "title": "restores the published body when publication lands between the check and the patch", "decision": "keep", "reason": "Exercises publication between the final read and PATCH and requires restoring the published body.", "reviewed_line": 250}, {"line": 298, "title": "leaves a body written after the patch in place instead of rolling it back", "decision": "keep", "reason": "Protects a concurrent newer body from rollback after the patch race.", "reviewed_line": 284}, {"line": 323, "title": "preserves notes on an existing published release", "decision": "keep", "reason": "Existing published releases must retain their notes without regeneration or mutation.", "reviewed_line": 309}, {"line": 338, "title": "omits previous_tag_name for the first desktop release so notes fall back to the GitHub default", "decision": "keep", "reason": "First desktop release API generation omits previous_tag_name for GitHub default behavior.", "reviewed_line": 324}, {"line": 359, "title": "paginates through every release page before choosing the previous release", "decision": "keep", "reason": "Actual pagination must fetch the complete release history before predecessor selection.", "reviewed_line": 345}, {"line": 391, "title": "refuses an untagged GitHub draft so electron-builder cannot publish latest", "decision": "keep", "reason": "Untagged draft rejection prevents electron-builder from publishing an unintended latest release.", "reviewed_line": 377}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "e9e3ad80f6f1ca8e83d51dcf92ec6cf8b11be8ecf3d7c223492813891689d2c4", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Consolidate duplicate stable-release predecessor coverage while preserving multiple RC inputs, release publication races, rollback, pagination, and tag identity safeguards.", "evidence": ["config/scripts/create-draft-release.mjs"], "original_declarations": 20, "reviewed_declarations": 19, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/daemon-boot-smoke.mjs", "sha256": "c4f26b0de5bb604afb806c1483eb57ff44db025330a86f68965bd9c38ac6bee4", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "c4f26b0de5bb604afb806c1483eb57ff44db025330a86f68965bd9c38ac6bee4", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "built-process-integration", "rationale": "Plain-Node daemon smoke executes a built real process and hard-checks readiness, ownership, RPC shutdown, cleanup, and endpoint disappearance. PTY health remains explicitly advisory.", "evidence": ["src/main/daemon/daemon-entry.ts", "src/main/daemon/daemon-endpoint-ownership.ts", "src/main/daemon/daemon-spawner.ts", ".github/workflows/computer-e2e.yml"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "embedded_checks": [{"line": 203, "title": "built plain-Node daemon signals ready", "decision": "keep", "reason": "IPC readiness must arrive before timeout; early exit/fork errors reject."}, {"line": 231, "title": "PID ownership matches ready process", "decision": "keep", "reason": "PID, launch nonce, entry path and app version are checked against the launched daemon."}, {"line": 241, "title": "canonical endpoint is published", "decision": "keep", "reason": "Actual canonical socket/named-pipe publication must be observable."}, {"line": 260, "title": "shutdown RPC terminates the daemon", "decision": "keep", "reason": "Real authenticated shutdown must produce process exit before timeout."}, {"line": 284, "title": "ownership record is removed", "decision": "keep", "reason": "The PID record must disappear after actual shutdown."}, {"line": 290, "title": "Unix endpoint stops answering", "decision": "keep", "reason": "A deliberately retained dead inode is allowed, but a connected endpoint is rejected."}, {"line": 296, "title": "private bind names do not leak", "decision": "keep", "reason": "Actual generated private-bind name shape must be absent after shutdown."}], "execution_note": "Classified and reviewed; standalone script not run in this batch.", "advisory_checks": [{"line": 135, "title": "PTY spawn health", "reason": "Best-effort diagnostic; failures are explicitly logged as skips and never satisfy a hard PTY delivery assertion."}]} +{"path": "config/scripts/daemon-endpoint-handover-smoke.mjs", "sha256": "73acd45caa94539c099d6629e6139fc93606229a710a3b4436d6a99ca25088b5", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "73acd45caa94539c099d6629e6139fc93606229a710a3b4436d6a99ca25088b5", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "unix-built-process-race", "rationale": "Real Unix daemon races and a forced live-incumbent phase protect endpoint ownership. Windows intentionally skips this Unix inode contract.", "evidence": ["src/main/daemon/daemon-entry.ts", "src/main/daemon/daemon-endpoint-ownership.ts", ".github/workflows/computer-e2e.yml"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "embedded_checks": [{"line": 185, "title": "departed owner leaves a dead canonical inode", "decision": "keep", "reason": "Real departed daemon preserves its inode while reachability becomes false."}, {"line": 195, "title": "exactly one racer owns the endpoint", "decision": "keep", "reason": "Actual racers replace the dead inode and exactly one token authenticates to the survivor."}, {"line": 223, "title": "loser exit preserves survivor", "decision": "keep", "reason": "Actual loser shutdown leaves survivor inode, authenticated reachability and ownership record intact while cleaning loser record."}, {"line": 241, "title": "forced newcomer refuses live incumbent", "decision": "keep", "reason": "A separate known-live phase requires refusal, exact adoption exit code, intact endpoint/reachability, and no newcomer ownership record."}], "execution_note": "Classified and reviewed; standalone script not run in this batch."} +{"path": "config/scripts/daemon-protocol-facts.test.mjs", "sha256": "6ec6bf7f0e97707e2c4d518c87bf54b4debb042dec704bebf9270e0bd3a6176b", "cases": [{"line": 27, "title": "reads the working tree declarations and keeps the append-only range", "decision": "keep", "reason": "Parses actual working-tree protocol declarations and validates the append-only compatible-version range.", "reviewed_line": 27}, {"line": 37, "title": "parses multi-line lists and type annotations", "decision": "keep", "reason": "Exercises multiline and type-annotated declaration syntax supported by the real fact parser.", "reviewed_line": 37}, {"line": 49, "title": "fails loudly on %s", "decision": "keep", "reason": "Every malformed, duplicate, missing, nonnumeric, nonpositive, and out-of-range row must fail parsing.", "reviewed_line": 49}, {"line": 70, "title": "lets a same-version or listing candidate adopt the release daemon", "decision": "keep", "reason": "Checks directional candidate adoption compatibility for same-version and explicitly listed release daemons.", "reviewed_line": 70}, {"line": 75, "title": "rejects a candidate that dropped the release version", "decision": "keep", "reason": "Rejects adoption when the candidate no longer lists the release daemon protocol.", "reviewed_line": 75}, {"line": 79, "title": "cannot roll back past a protocol bump", "decision": "keep", "reason": "Protects rollback compatibility across a protocol bump in the opposite direction.", "reviewed_line": 79}, {"line": 84, "title": "describes the requirements in both directions", "decision": "keep", "reason": "Requires user-facing requirements to explain both adoption and rollback compatibility.", "reviewed_line": 84}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "6ec6bf7f0e97707e2c4d518c87bf54b4debb042dec704bebf9270e0bd3a6176b", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 7 cases and all malformed parser rows. Checks append-only current source, typed/multiline declarations, rejection of malformed/missing/duplicate/nonnumeric/nonpositive/out-of-range facts, directional compatibility and user-facing crossing requirements. Production `daemon-protocol-facts.mjs`, actual `src/main/daemon/daemon-protocol-version.ts`. Compatibility contract warrants source parsing.", "evidence": ["config/scripts/daemon-protocol-facts.mjs", "src/main/daemon/daemon-protocol-version.ts"], "original_declarations": 7, "reviewed_declarations": 7, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/daily-build-version.test.mjs", "sha256": "ca1f317d15c82fe0646ef1b7d8db57b41e47034f6c59f0e91021a062640bfb88", "cases": [{"line": 10, "title": "stamps the version with a zero-padded UTC timestamp", "decision": "keep", "reason": "Checks actual generated UTC version text and timestamp zero padding.", "reviewed_line": 10}, {"line": 21, "title": "drops an in-flight rc tail so dailies never outrank the rc series", "decision": "fix", "reason": "Keeps the actual generated RC-stripped version and comparator ordering; removes a hardcoded obsolete RC-daily comparison.", "reviewed_line": 21}, {"line": 31, "title": "sorts below the hourly build of the same base version", "decision": "fix", "reason": "Uses createDailyBuildVersion output in the real version comparator so generator regressions can fail this channel-ordering oracle.", "reviewed_line": 30}, {"line": 37, "title": "rejects invalid input", "decision": "keep", "reason": "Exercises actual invalid version and invalid Date rejection.", "reviewed_line": 35}, {"line": 47, "title": "renders version, number, Pacific timestamp, and short sha", "decision": "consolidate", "reason": "Exact July title assertion already remains in the retained January/July DST declaration at original line 55.", "coverage_target": {"path": "config/scripts/daily-build-version.test.mjs", "line": 55}}, {"line": 55, "title": "follows the Pacific offset across DST", "decision": "keep", "reason": "Checks both winter and summer Pacific offsets using actual release-title formatting; also preserves complete title formatting.", "reviewed_line": 48}, {"line": 60, "title": "rejects a build number that is not a positive integer", "decision": "keep", "reason": "Zero, negative, and fractional build numbers exercise actual positive-integer validation.", "reviewed_line": 53}, {"line": 66, "title": "rejects an invalid timestamp", "decision": "keep", "reason": "Invalid timestamp must reach the actual title timestamp formatter rejection.", "reviewed_line": 59}, {"line": 80, "title": "continues the series for the version being built", "decision": "keep", "reason": "Actual number selection continues the version-specific existing series.", "reviewed_line": 73}, {"line": 84, "title": "restarts at 1 when the base version moves", "decision": "keep", "reason": "A changed base version starts its own numbering and advances after its first title.", "reviewed_line": 77}, {"line": 93, "title": "takes the highest number, not the count", "decision": "keep", "reason": "Pruned release history must use the maximum observed number rather than the count.", "reviewed_line": 86}, {"line": 97, "title": "starts at 1 with no history at all", "decision": "keep", "reason": "Both omitted and explicitly empty history start numbering at one.", "reviewed_line": 90}, {"line": 102, "title": "ignores titles that are not this version", "decision": "keep", "reason": "Prefix lookalikes, legacy tag-shaped titles, nulls, and empty titles cannot consume a version's number.", "reviewed_line": 95}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "bbc3936df1ad589a0350d6bcd819a8d09429c1b861eb4de7ca851161b0149e9b", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Exercise generated daily versions in channel ordering, remove the obsolete hardcoded comparator example, and consolidate the duplicate July title while preserving both DST seasons.", "evidence": ["config/scripts/daily-build-version.mjs", "config/scripts/release-title-timestamp.mjs", "src/shared/app-version.ts"], "original_declarations": 13, "reviewed_declarations": 12, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dark-build-switches.test.mjs", "sha256": "0ea5c08c8e57aab37e096b9d53e14111b35bc5076c6e3999d3815c963bee38ea", "cases": [{"line": 21, "title": "compiles the dark path in only when %s=main asks", "decision": "keep", "reason": "Each switch row exercises actual compile-time dark-path selection and ordinary-build defaults.", "reviewed_line": 21}, {"line": 32, "title": "keeps the layout-owner marker name packaging already refuses", "decision": "keep", "reason": "Pins the marker filename shared by the compiler path and the packaging rejection contract.", "reviewed_line": 32}, {"line": 42, "title": "refuses %s at packaging time, and any output its dark build marked", "decision": "keep", "reason": "Uses actual temporary marked output directories to prove packaging rejects dark switches and persisted dark artifacts.", "reviewed_line": 42}, {"line": 57, "title": "lets a dark build carry its own %s output, never one of %s", "decision": "keep", "reason": "Every switch pair must allow its own marked test output and reject another switch's marked output.", "reviewed_line": 57}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "0ea5c08c8e57aab37e096b9d53e14111b35bc5076c6e3999d3815c963bee38ea", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 4 declarations/all switch table rows. Defines exercise compile selection, marker filename is existing packaging interface, temp actual output dirs prove packaging/env refusal and cross-switch dark-output guard. Marker explanatory text is incidental, but filename and env semantics are real cross-build release contracts. Production `config/dark-build-switches.cjs`, builder `beforePack`.", "evidence": ["config/dark-build-switches.cjs", "config/electron-builder.config.cjs"], "original_declarations": 4, "reviewed_declarations": 4, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dependency-security-audit.test.mjs", "sha256": "9816d97523bfd03bc9fb41d06f97cf71f09d1b0c0b3fcefacb7489488a5d3b8b", "cases": [{"line": 73, "title": "blocks %s advisories including build-time findings", "decision": "keep", "reason": "Every blocking severity row exercises the actual dependency policy, including build-time findings.", "reviewed_line": 73}, {"line": 78, "title": "retains lower severities without blocking", "decision": "keep", "reason": "Nonblocking severity findings remain observable rather than disappearing from the report.", "reviewed_line": 78}, {"line": 83, "title": "applies an exception only to the exact patched finding", "decision": "keep", "reason": "Exact exception identity, patch content, and expiry distinguish approved patched findings from similar unapproved ones.", "reviewed_line": 83}, {"line": 101, "title": "lets expired and removed patch exceptions coexist with a clean graph", "decision": "keep", "reason": "Expired or removed exception entries cannot make an otherwise clean dependency graph fail.", "reviewed_line": 101}, {"line": 109, "title": "refuses a changed %s", "decision": "keep", "reason": "Each changed workspace, lock, or patch row exercises actual registered-input integrity checks.", "reviewed_line": 109}, {"line": 131, "title": "rejects incomplete reports instead of treating them as clean", "decision": "keep", "reason": "Incomplete and malformed scanner reports fail closed instead of being accepted as a clean graph.", "reviewed_line": 131}, {"line": 137, "title": "fails closed on scanner errors: %j", "decision": "keep", "reason": "All abnormal scanner-status rows exercise fail-closed handling.", "reviewed_line": 137}, {"line": 147, "title": "reads nonzero finding reports for policy evaluation", "decision": "keep", "reason": "A nonzero scanner finding status still sends the actual report through policy evaluation.", "reviewed_line": 147}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "9816d97523bfd03bc9fb41d06f97cf71f09d1b0c0b3fcefacb7489488a5d3b8b", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 8 declarations/all scanner failure and patch corruption rows. Exercises severity, exact exception matching, expiration, registered workspace/lock hashes/multidocument lock parsing and patched snapshots plus actual patch bytes; malformed/incomplete reports and abnormal scanner statuses fail closed. Production `dependency-security-audit.mjs`, `check-dependency-security.mjs`.", "evidence": ["config/scripts/dependency-security-audit.mjs", "config/scripts/check-dependency-security.mjs"], "original_declarations": 8, "reviewed_declarations": 8, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dependency-security-patches.test.mjs", "sha256": "a74f2596e2e0a63958680e63f579716b5d04f1720a1e43ae4f1b9a7e70b3dc15", "cases": [{"line": 22, "title": "bounds numeric precision in %s", "decision": "keep", "reason": "Resolves actual installed sprintf-js through electron-builder's dependency chain and checks source/dist precision limits plus ordinary formatting.", "reviewed_line": 22}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "a74f2596e2e0a63958680e63f579716b5d04f1720a1e43ae4f1b9a7e70b3dc15", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep installed actual sprintf-js source and dist behavior through electron-builder's real dependency resolution chain. Excessive precision is bounded while ordinary formatting remains correct. This is verification of shipped patch behavior, not a mock reproduction.", "evidence": ["config/patches/sprintf-js@1.1.3.patch", "package.json"], "original_declarations": 1, "reviewed_declarations": 1, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dependency-security-release.test.mjs", "sha256": "85581ab67d1bc9c166927d442da8991850b7206884c668b3aba8a923018a256e", "cases": [{"line": 25, "title": "blocks stable publication until its dependency scan succeeds while leaving RCs independent", "decision": "keep", "reason": "Evaluated release workflow must gate stable publication on security success while leaving RC flow independent.", "reviewed_line": 25}, {"line": 39, "title": "scans the release tag with read-only workflow tooling instead of installing candidate code", "decision": "keep", "reason": "The tag scan uses trusted read-only tooling instead of executing candidate package configuration.", "reviewed_line": 39}, {"line": 62, "title": "extracts release data while excluding executable package and Cargo configuration", "decision": "keep", "reason": "Actual temporary Git extraction excludes executable package/npm/Cargo config and Git attributes while requiring dependency data.", "reviewed_line": 62}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "85581ab67d1bc9c166927d442da8991850b7206884c668b3aba8a923018a256e", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 3 declarations: evaluated actual workflow stable security gate (RC independent); trusted read-only workflow/ref tooling; actual temp Git repositories executing data-extraction action excluding package/npm/Cargo executable config and candidate Git attributes. Missing workspace fails. Production `.github/workflows/{release-cut,dependency-security}.yml`, `.github/actions/prepare-dependency-audit/action.yml`. Preserve trust boundaries.", "evidence": [".github/workflows/release-cut.yml", ".github/workflows/dependency-security.yml", ".github/actions/prepare-dependency-audit/action.yml"], "original_declarations": 3, "reviewed_declarations": 3, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-channel-base-version.test.mjs", "sha256": "e01a7e6eb393c85f47a95eb4926b6c63c558048077fd945210b1a5ad408ad4f8", "cases": [{"line": 8, "title": "falls back to package.json when no tags are supplied", "decision": "keep", "reason": "Exercises package.json fallback with omitted and empty published tag inputs.", "reviewed_line": 8}, {"line": 15, "title": "climbs past stables that shipped while main stood still", "decision": "keep", "reason": "Actual stable-floor selection advances past several shipped stable versions while package.json remains behind.", "reviewed_line": 15}, {"line": 29, "title": "takes the patch above a shipped stable and holds at an open prerelease", "decision": "keep", "reason": "Distinguishes a consumed stable patch from an open RC of the next patch.", "reviewed_line": 29}, {"line": 36, "title": "reads the highest tag, not the last one listed", "decision": "keep", "reason": "Out-of-order versions must choose the highest triple rather than the final listed tag.", "reviewed_line": 36}, {"line": 45, "title": "climbs past a tagged stable that has no GitHub release", "decision": "remove", "reason": "Duplicates the stable-floor inputs already covered; a pure string-list function cannot prove a tag lacks a GitHub release.", "coverage_target": {"path": "config/scripts/dev-channel-base-version.test.mjs", "line": 15}}, {"line": 53, "title": "does not drop below an already-published channel version", "decision": "keep", "reason": "Published channel prereleases form a floor that prevents a development series from moving backward.", "reviewed_line": 46}, {"line": 63, "title": "treats package.json as a floor when it leads the tags", "decision": "keep", "reason": "A leading package version remains the minimum even when supplied tags are older.", "reviewed_line": 56}, {"line": 69, "title": "ignores tags it cannot parse", "decision": "keep", "reason": "Invalid and legacy tag names are ignored without discarding valid published versions.", "reviewed_line": 62}, {"line": 75, "title": "rejects a package version that is not semver", "decision": "keep", "reason": "Invalid package semver must reject rather than guess a release identity.", "reviewed_line": 68}, {"line": 79, "title": "carries major and minor rollovers through the bump", "decision": "keep", "reason": "A higher major/minor tag must carry its triple through the stable patch bump.", "reviewed_line": 72}, {"line": 83, "title": "splits an env tag list on any whitespace", "decision": "fix", "reason": "Exercises mixed space/tab/CRLF parsing, actual default-environment input, and an absent default variable while restoring ambient env through Vitest.", "reviewed_line": 76, "reviewed_title": "reads whitespace-separated tags from explicit input or the environment"}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "99d6f41ca8637a443b53c9fb80e0326b398fac374a70e58218ce877c11789ad4", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Remove a duplicated stable-floor case that cannot establish GitHub release provenance; exercise actual mixed-whitespace and default-environment parsing with isolated ambient state.", "evidence": ["config/scripts/dev-channel-base-version.mjs"], "original_declarations": 11, "reviewed_declarations": 10, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-channel-orcad-template-workflow.test.mjs", "sha256": "5baf4eb09655502bd184a1b6c28525692c203c39ce2e172e9d89b191cd98ecbb", "cases": [{"line": 33, "title": "builds the template from the commit the app is built from", "decision": "keep", "reason": "Actual hourly/daily workflow payload pins both app and template to the same commit.", "reviewed_line": 33}, {"line": 42, "title": "packages the macOS build only with the template present", "decision": "keep", "reason": "Packaging requires template availability and strict template env after artifact download.", "reviewed_line": 42}, {"line": 60, "title": "ships the same template in the Windows build", "decision": "keep", "reason": "Windows reusable workflow receives the same pinned template identity as the desktop build.", "reviewed_line": 60}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "5baf4eb09655502bd184a1b6c28525692c203c39ce2e172e9d89b191cd98ecbb", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep all 3 declarations over hourly/daily: pinned app/template SHA, required job and download-before-package ordering, strict template env, same Windows reusable workflow. These pin real remote deployment payload/permissions behavior. `.github/workflows/{hourly-mac-build,daily-mac-build,dev-channel-win-build,node-server-tests}.yml`.", "evidence": [".github/workflows/hourly-mac-build.yml", ".github/workflows/daily-mac-build.yml", ".github/workflows/dev-channel-win-build.yml", ".github/workflows/node-server-tests.yml"], "original_declarations": 3, "reviewed_declarations": 3, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-channel-windows-staging.test.mjs", "sha256": "c454ebd6c0984167764a82def23f12e496e060e7aa6b2ea1b2de358edf1a82ee", "cases": [{"line": 24, "title": "keeps existing callers publishing by default", "decision": "keep", "reason": "Existing reusable workflow callers preserve publish-by-default input compatibility.", "reviewed_line": 24}, {"line": 36, "title": "never mints or consumes release-write credentials while staging", "decision": "keep", "reason": "Staging must neither mint nor consume release-write credentials in evaluated workflow wiring.", "reviewed_line": 36}, {"line": 55, "title": "passes exactly the installer, blockmap, and update manifest within the same run", "decision": "keep", "reason": "Installer, blockmap, and manifest must come from one run with exact staging/download linkage.", "reviewed_line": 55}, {"line": 74, "title": "fails %s on any missing or empty staged file", "decision": "keep", "reason": "Each missing or empty artifact row executes actual workflow Bash and must fail before publication.", "reviewed_line": 74}, {"line": 94, "title": "validates the channel/tag before downloading artifacts or minting a token", "decision": "keep", "reason": "Actual Bash rejects unsafe channel/tag inputs before downloading artifacts or minting credentials.", "reviewed_line": 94}, {"line": 109, "title": "requires a live existing release and never creates one", "decision": "keep", "reason": "Actual release lookup distinguishes live, draft, missing, and CLI-failure states without creating a release.", "reviewed_line": 109}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "c454ebd6c0984167764a82def23f12e496e060e7aa6b2ea1b2de358edf1a82ee", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 6 declarations/all matrices: backward-compatible input defaults; no write secrets while staging; exact public installer/blockmap/update-manifest set tied to same run; actual Bash rejects each missing/empty artifact; actual Bash rejects channel/tag injection; live-existing release guard handles draft/empty/CLI failure and cannot create release. Workflows `dev-channel-win-build.yml`, `dev-channel-win-publish.yml`.", "evidence": [".github/workflows/dev-channel-win-build.yml", ".github/workflows/dev-channel-win-publish.yml"], "original_declarations": 6, "reviewed_declarations": 6, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-cli-terminal-wrapper.test.mjs", "sha256": "7120a00319c1223edcb8a423bf59afd627f18542285819e3e66e14713fb5b871", "cases": [{"line": 8, "title": "writes profile-scoped Windows wrappers for worker terminals", "decision": "keep", "reason": "Checks executable Windows batch wrapper bytes that scope profile identity and forward worker command arguments.", "reviewed_line": 8}, {"line": 27, "title": "escapes literal percent signs in every Windows batch path", "decision": "keep", "reason": "Literal percent characters in every Windows batch path must be escaped for real cmd expansion rules.", "reviewed_line": 27}, {"line": 50, "title": "writes executable-style POSIX wrappers with the same profile identity", "decision": "keep", "reason": "POSIX wrapper text preserves profile identity and installed command aliases at the shell invocation boundary.", "reviewed_line": 50}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "7120a00319c1223edcb8a423bf59afd627f18542285819e3e66e14713fb5b871", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep Windows scoped wrapper/env/argument forwarding and percent escaping; POSIX profile identity and all installed command aliases. These bytes are executed by real shells and encode external invocation contract, even though Windows execution itself requires Windows. Title 'executable-style' lacks mode check; optional improve only if concrete concern, not broad test rewrite. Production `dev-cli-terminal-wrapper.mjs`.", "evidence": ["config/scripts/dev-cli-terminal-wrapper.mjs"], "original_declarations": 3, "reviewed_declarations": 3, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-electron-bundle-cache.test.ts", "sha256": "7da48621f835e5680e719f5c82073dfaf79ef4d02539f28fc4f5ae95a84d8378", "cases": [{"line": 25, "title": "keeps recently used bundles during automatic retention sweeps", "decision": "keep", "reason": "Actual retention selection protects recently used bundle directories.", "reviewed_line": 25}, {"line": 36, "title": "reclaims siblings while keeping the current bundle", "decision": "keep", "reason": "Expired siblings are selected while the current bundle remains protected.", "reviewed_line": 36}, {"line": 47, "title": "never reclaims a bundle a live process is running from", "decision": "keep", "reason": "Live-process executable paths protect the bundle from deletion.", "reviewed_line": 47}, {"line": 60, "title": "protects a live bundle whose path contains spaces", "decision": "keep", "reason": "Live-path parsing preserves a bundle path containing spaces.", "reviewed_line": 60}, {"line": 75, "title": "does not treat a sibling as live just because it shares a prefix", "decision": "keep", "reason": "A shared string prefix cannot protect a distinct sibling bundle.", "reviewed_line": 75}, {"line": 89, "title": "never deletes a bundle that is still being copied", "decision": "keep", "reason": "An in-progress copy marker protects a bundle still being written.", "reviewed_line": 89}, {"line": 104, "title": "reclaims a marker-less bundle once it is too old to be in flight", "decision": "keep", "reason": "Old abandoned directories without markers can be reclaimed after the in-flight grace period.", "reviewed_line": 104}, {"line": 118, "title": "matches a live bundle across the /tmp and /private/tmp spellings", "decision": "keep", "reason": "Canonical /tmp and /private/tmp spellings identify the same live bundle.", "reviewed_line": 118}, {"line": 130, "title": "still honours the path boundary across spellings", "decision": "keep", "reason": "Canonical alias handling still honors path segment boundaries.", "reviewed_line": 130}, {"line": 135, "title": "reclaims nothing when every directory is current or live", "decision": "keep", "reason": "Empty and fully protected candidate sets produce no deletion work.", "reviewed_line": 135}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "7da48621f835e5680e719f5c82073dfaf79ef4d02539f28fc4f5ae95a84d8378", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 10 cases: age retention, current/live protection, spaces, prefix boundaries, in-progress copies, abandoned markerless dirs, /tmp vs /private aliases, empty/all-protected selection. Production `dev-electron-bundle-cache.mjs`. Real deletion safety policy, not inventories.", "evidence": ["config/scripts/dev-electron-bundle-cache.mjs"], "original_declarations": 10, "reviewed_declarations": 10, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-electron-bundle-identity.test.ts", "sha256": "ad7e6d3e4bf5681b527e57b5b86eeafb789538925364cbc4fc06565557d9cacc", "cases": [{"line": 42, "title": "leaves process.env untouched, including its object identity", "decision": "remove", "reason": "This primarily tests restoration implemented by the test-only patchesUnder fixture, not production bundle identity."}, {"line": 50, "title": "gives the dev app a legible display name so notifications are not just \"Electron\"", "decision": "keep", "reason": "Actual patch generators provide readable CFBundleName and CFBundleDisplayName values rather than Electron.", "reviewed_line": 42}, {"line": 59, "title": "keeps the bundle display name in step with the name safeStorage keys off", "decision": "keep", "reason": "Two independent production identity sources must agree because app.setName controls the safeStorage Keychain service.", "reviewed_line": 51}, {"line": 66, "title": "produces byte-identical patches on two different branches", "decision": "keep", "reason": "Comparing real generated patches across different environments protects signature stability for arbitrary branch/title values.", "reviewed_line": 58}, {"line": 83, "title": "leaks no branch, worktree, or title text into any patched value", "decision": "remove", "reason": "Redundant with byte-identical patch comparison, and the worktree sentinel is never supplied to the fixture at all.", "coverage_target": {"path": "config/scripts/dev-electron-bundle-identity.test.ts", "line": 66}}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "179dfe568d4d38c9ecae67aa37b2badd726e664673aea7d2b1051cd0caafb349", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Remove fixture-only environment restoration and redundant substring checks; retain actual display/Keychain identity agreement and byte-identical patches across environments.", "evidence": ["config/scripts/dev-electron-bundle-identity.mjs", "src/main/startup/dev-instance-identity.ts"], "original_declarations": 5, "reviewed_declarations": 3, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-storage-reclaim.test.mjs", "sha256": "aa7d040da76351c4a97a1b5ac113bd22d097c97f6a8bbf6e33a42824123219b8", "cases": [{"line": 16, "title": "starts one non-interactive worker without waiting for its exit", "decision": "keep", "reason": "Checks detached spawn flags, environment, cwd, streams, and unref at the real process boundary.", "reviewed_line": 16}, {"line": 34, "title": "allows tests and developers to skip the repository-wide sweep", "decision": "keep", "reason": "The explicit developer/test opt-out prevents starting repository cleanup.", "reviewed_line": 34}, {"line": 40, "title": "reports cleanup failure without throwing into dev startup", "decision": "keep", "reason": "Cleanup launch failure is reported without failing development startup.", "reviewed_line": 40}, {"line": 47, "title": "handles both sync and async spawn errors (sync: %j)", "decision": "keep", "reason": "Both synchronous throws and asynchronous child errors follow the actual nonfatal cleanup path.", "reviewed_line": 47}, {"line": 61, "title": "closes captured dev output before the detached worker exits", "decision": "keep", "reason": "A real subprocess proves detached work cannot hold captured parent output open.", "reviewed_line": 61}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "aa7d040da76351c4a97a1b5ac113bd22d097c97f6a8bbf6e33a42824123219b8", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 5 declarations/sync-async rows. Spawn calls are the actual detached process boundary: flags/cwd/env/stdout/unref matter. Failure reporting stays nonfatal. Real subprocess test proves detached worker cannot hold captured output open; it uses an injected inert process command, not actual cleanup. Production `dev-storage-reclaim.mjs`.", "evidence": ["config/scripts/dev-storage-reclaim.mjs"], "original_declarations": 5, "reviewed_declarations": 5, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/dev-web-client-freshness.test.mjs", "sha256": "c16b0c2520f0134e11af7f531e92a7285d6168b018cf2bf79d76ca6454a5fad6", "cases": [{"line": 61, "title": "requires a web bundle before declaring it fresh", "decision": "keep", "reason": "A missing actual output bundle cannot be declared fresh.", "reviewed_line": 61}, {"line": 68, "title": "keeps an existing bundle fresh after editing renderer or shared tests", "decision": "keep", "reason": "Editing renderer/shared test sources does not invalidate a production web bundle.", "reviewed_line": 68}, {"line": 81, "title": "rebuilds when %s changes", "decision": "keep", "reason": "Every relevant production input-kind row exercises actual filesystem freshness detection.", "reviewed_line": 81}, {"line": 94, "title": "rebuilds after a production source %s", "decision": "keep", "reason": "Production source add/delete/rename rows invalidate the bundle through the real inventory.", "reviewed_line": 94}, {"line": 106, "title": "keeps a tracked bundle fresh after adding and deleting a %s file", "decision": "keep", "reason": "Adding and deleting test-only file rows leave tracked production output fresh.", "reviewed_line": 106}, {"line": 120, "title": "ignores adding and removing a directory containing only tests", "decision": "keep", "reason": "A directory consisting only of tests must not enter production freshness inputs.", "reviewed_line": 120}, {"line": 131, "title": "invalidates a tracked bundle after a production source %s with old timestamps", "decision": "keep", "reason": "Source mutations with restored old mtimes are caught by inventory differences rather than timestamp luck.", "reviewed_line": 131}, {"line": 149, "title": "invalidates a tracked bundle when a source is removed in a nested directory", "decision": "keep", "reason": "Nested directory source removal must invalidate output even when parent mtimes do not reveal it.", "reviewed_line": 149}, {"line": 163, "title": "falls back conservatively when the inventory is %s", "decision": "keep", "reason": "Each corrupt/missing inventory state takes the conservative actual freshness fallback.", "reviewed_line": 163}, {"line": 187, "title": "adopts a fresh replacement output without reusing its previous inventory", "decision": "keep", "reason": "Replacing output creates a new inventory identity rather than inheriting stale freshness metadata.", "reviewed_line": 187}, {"line": 196, "title": "retains the inputs from before a build so concurrent edits invalidate its output", "decision": "keep", "reason": "Concurrent source edits during a build must invalidate output against the pre-build input snapshot.", "reviewed_line": 196}, {"line": 205, "title": "detects same-size atomic replacement with a restored mtime", "decision": "keep", "reason": "Same-size atomic source replacement with preserved mtime is detected through actual file identity.", "reviewed_line": 205}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "c16b0c2520f0134e11af7f531e92a7285d6168b018cf2bf79d76ca6454a5fad6", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 12 declarations/all rows. Real filesystem captures changed input kinds, test exclusions, adds/deletes/renames with restored mtimes, nested deletion, invalid metadata fallback, replacement output, edits during build, inode replacement. Production `dev-web-client-freshness.mjs`.", "evidence": ["config/scripts/dev-web-client-freshness.mjs"], "original_declarations": 12, "reviewed_declarations": 12, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/e2e-cli-artifact-capability.test.mjs", "sha256": "1ff82a46786f48a948978db3351ba367a329789172d8b5721aeb517ad3300510", "cases": [{"line": 13, "title": "uses the same preparation for locally compiled and downloaded CLI output", "decision": "keep", "reason": "Actual workflow build/download paths share the same backward-compatible CLI preparation.", "reviewed_line": 13}, {"line": 20, "title": "supported=%s build status=%s exits=%s", "decision": "keep", "reason": "All supported/unsupported/build-failure rows execute actual Bash capability handling and check status/output.", "reviewed_line": 20}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "1ff82a46786f48a948978db3351ba367a329789172d8b5721aeb517ad3300510", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep shared build/download CLI preparation wiring and 3 real Bash capability cases (supported/unsupported/build failure). These protect old-ref compatibility and actual artifact initialization, not a generic capability flag. Workflow `.github/workflows/e2e.yml`, package scripts.", "evidence": [".github/workflows/e2e.yml", "package.json"], "original_declarations": 2, "reviewed_declarations": 2, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-builder-config.test.mjs", "sha256": "e614ac6673bca68ec2d5df34e0b59b707c4351c6a6d1662ea0aed4f589a14437", "cases": [{"line": 18, "title": "keeps the packaged app identity aligned with local-build validation", "decision": "keep", "reason": "Packaged app ID must agree with the independently consumed local-build compatibility contract.", "reviewed_line": 18}, {"line": 24, "title": "excludes repo-only source trees from app.asar", "decision": "fix", "reason": "Actual FileMatcher excludes representative root sources and retains built output plus nested dependency docs/src; independent notes/tooling cases preserve their exclusions.", "reviewed_line": 24}, {"line": 50, "title": "keeps release build staging out of app.asar while preserving runtime output", "decision": "keep", "reason": "Actual FileMatcher rejects release staging directories while retaining built runtime outputs.", "reviewed_line": 55}, {"line": 71, "title": "keeps local agent tooling out of app.asar", "decision": "keep", "reason": "Actual FileMatcher excludes local agent config/session files while retaining renderer runtime artifacts.", "reviewed_line": 76}, {"line": 92, "title": "keeps a root notes %s out of app.asar", "decision": "keep", "reason": "Both file and directory notes fixtures go through actual file copying; root notes are excluded without losing unrelated nested runtime notes.", "reviewed_line": 97}, {"line": 152, "title": "keeps plugin authoring examples out of app.asar", "decision": "keep", "reason": "Actual matcher excludes plugin authoring examples from the packaged application.", "reviewed_line": 157}, {"line": 173, "title": "keeps cached dev Electron bundles and Vite dependencies out of app.asar", "decision": "keep", "reason": "Actual matcher excludes cached dev Electron bundles and Vite caches.", "reviewed_line": 178}, {"line": 196, "title": "keeps the relay bundles out of app.asar and ships them only through extraResources", "decision": "keep", "reason": "Relay bundle matching and extraResources routing ensure one actual distribution location.", "reviewed_line": 201}, {"line": 219, "title": "keeps runtime resources available through extraResources", "decision": "keep", "reason": "Resolved resource plans preserve required runtime dependencies and packaged module paths.", "reviewed_line": 224}, {"line": 267, "title": "ships one macOS serve-sim package through the runtime closure", "decision": "keep", "reason": "macOS runtime closure includes exactly one serve-sim package.", "reviewed_line": 272}, {"line": 277, "title": "loads Codex TOML parsing after %s runtime pruning", "decision": "keep", "reason": "Actual smol-toml loading after platform pruning protects Codex parsing in the staged runtime.", "reviewed_line": 282}, {"line": 309, "title": "keeps serve-sim out of the Windows and Linux runtime closures", "decision": "keep", "reason": "Windows/Linux runtime closures must exclude the macOS-only serve-sim native dependency.", "reviewed_line": 314}, {"line": 330, "title": "keeps the Windows CLI shim source tree out of app.asar", "decision": "keep", "reason": "The Windows launcher source directory is excluded while its compiled output remains distributed.", "reviewed_line": 335}, {"line": 347, "title": "ships the mac notification-status helper in Contents/MacOS, not Resources", "decision": "keep", "reason": "Notification helper ships in the signed Contents/MacOS location required for attribution.", "reviewed_line": 352}, {"line": 361, "title": "ships the mac keyboard-layout helper in Contents/MacOS, not Resources", "decision": "keep", "reason": "Keyboard layout helper ships in Contents/MacOS rather than Resources.", "reviewed_line": 366}, {"line": 375, "title": "unpacks the compiled CommonJS boundary with CLI runtime files", "decision": "keep", "reason": "CommonJS CLI import boundaries remain unpacked where real plain-Node consumers resolve them.", "reviewed_line": 380}, {"line": 383, "title": "unpacks the forked parcel-watcher process entry", "decision": "keep", "reason": "Parcel watcher child-process entry remains unpacked for actual fork loading.", "reviewed_line": 388}, {"line": 389, "title": "unpacks the replaceable WSL transcript filesystem process entry", "decision": "keep", "reason": "Replaceable WSL transcript child-process entry remains unpacked for actual spawning.", "reviewed_line": 394}, {"line": 396, "title": "unpacks the orcad serve-selection entry the CLI runs", "decision": "keep", "reason": "CLI-selected orcad entry remains unpacked at the expected runtime path.", "reviewed_line": 401}, {"line": 418, "title": "unpacks the web and mobile bundles a host serves by opening their files", "decision": "keep", "reason": "Web/mobile served-by-file bundles remain unpacked with their actual bundle contents.", "reviewed_line": 423}, {"line": 437, "title": "keeps the worker-thread hang watchdog inside app.asar", "decision": "keep", "reason": "Worker-thread hang watchdog remains within app.asar because worker loading supports that path.", "reviewed_line": 442}, {"line": 443, "title": "uses the multi-size icon source for Linux packages", "decision": "keep", "reason": "Linux package icons use the documented multi-size source required by packaging.", "reviewed_line": 448}, {"line": 447, "title": "matches the Linux desktop entry to Electron window class", "decision": "keep", "reason": "Linux desktop StartupWMClass matches Electron's window class for application grouping.", "reviewed_line": 452}, {"line": 451, "title": "uses the release artifact set as local Linux targets without changing existing names", "decision": "keep", "reason": "Local Linux targets retain the release artifact set and compatibility filenames.", "reviewed_line": 456}, {"line": 462, "title": "retains electron-builder runtime dependencies in deb and rpm packages", "decision": "keep", "reason": "Deb/rpm runtime dependencies remain available for actual packaged execution.", "reviewed_line": 467}, {"line": 472, "title": "validates each AppImage before electron-builder publishes it", "decision": "keep", "reason": "A real malformed AppImage fixture must fail validation before publication.", "reviewed_line": 477}, {"line": 489, "title": "uses a distinct AppImage name for Linux arm64 release uploads", "decision": "keep", "reason": "Linux arm64 release uploads have a distinct filename and cannot overwrite x64 artifacts.", "reviewed_line": 494}, {"line": 509, "title": "overrides packaged semver only for local macOS builds", "decision": "keep", "reason": "Local macOS packaging applies the distinct local-build semver policy.", "reviewed_line": 514}, {"line": 536, "title": "never applies local semver to release packaging", "decision": "keep", "reason": "Release packaging preserves official semver and never inherits local overrides.", "reviewed_line": 541}, {"line": 561, "title": "uses Orca native rebuild hook instead of electron-builder default rebuild", "decision": "keep", "reason": "Actual native rebuild hook wiring replaces the builder's optional default rebuild.", "reviewed_line": 566}, {"line": 596, "title": "allows packaging the host platform and architecture", "decision": "keep", "reason": "Installed same-host native artifacts permit host-target packaging.", "reviewed_line": 601}, {"line": 600, "title": "refuses to package a dark layout-owner build", "decision": "keep", "reason": "The actual beforePack hook rejects a dark layout-owner environment.", "reviewed_line": 605}, {"line": 614, "title": "refuses to package an orcad template marked by a dark test build", "decision": "keep", "reason": "A real marked orcad template directory must be rejected by beforePack.", "reviewed_line": 619}, {"line": 632, "title": "requires the other architecture natives to be installed", "decision": "fix", "reason": "Explicitly skips Windows instead of silently executing no assertions; non-Windows branches still assert foreign-Sherpa behavior and original line 649 retains Windows foreign-addon coverage.", "reviewed_line": 637}, {"line": 649, "title": "refuses a Windows workspace addon built for another architecture", "decision": "keep", "reason": "Windows-only case requires foreign-architecture workspace native addons to be rejected.", "reviewed_line": 657}, {"line": 658, "title": "requires installed Windows addons for Windows packaging", "decision": "keep", "reason": "Actual Windows package prerequisite checks distinguish host-native builds, installed process-tree resources, and cross-host missing addons.", "reviewed_line": 666}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "df383425cbfbfde462367b10503c800d70c25343752d27d73e6f714f24061362", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Replace copied exclusion patterns with actual FileMatcher path behavior and retained nested runtime sources. Explicitly skip the non-Windows foreign-Sherpa case on Windows; keep separate Windows foreign-addon coverage.", "evidence": ["config/electron-builder.config.cjs", "config/packaged-runtime-node-modules.cjs"], "original_declarations": 36, "reviewed_declarations": 36, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-builder-mac-channel-config.test.mjs", "sha256": "c49efa3b9471da19f11dfdca172bfb1773e122287ac51919fd4baf1784b77e68", "cases": [{"line": 51, "title": "builds hourly artifacts with the release signing identity", "decision": "keep", "reason": "Hourly packaging uses release signing identity needed for stable macOS privacy attribution.", "reviewed_line": 51}, {"line": 64, "title": "notarizes hourly builds like releases, and neither locally", "decision": "keep", "reason": "Hourly/release notarization is enabled while local builds remain unsigned/not notarized according to policy.", "reviewed_line": 64}, {"line": 77, "title": "publishes hourly builds to the separate hourly repo", "decision": "keep", "reason": "Hourly updater feed targets the dedicated hourly repository.", "reviewed_line": 77}, {"line": 87, "title": "stamps hourly packages with the hourly version", "decision": "keep", "reason": "Hourly version metadata uses the supplied generated build identity.", "reviewed_line": 87}, {"line": 99, "title": "builds adhoc artifacts with the release identity and its own repo", "decision": "keep", "reason": "Adhoc builds retain release signing identity and their own updater destination.", "reviewed_line": 99}, {"line": 109, "title": "stamps adhoc packages with the adhoc version", "decision": "keep", "reason": "Adhoc metadata stamps the supplied adhoc version.", "reviewed_line": 109}, {"line": 118, "title": "builds daily artifacts with the release identity and its own repo", "decision": "keep", "reason": "Daily packaging uses release identity and the dedicated daily repository.", "reviewed_line": 118}, {"line": 128, "title": "stamps daily packages with the daily version", "decision": "keep", "reason": "Daily metadata stamps the supplied daily version.", "reviewed_line": 128}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "c49efa3b9471da19f11dfdca172bfb1773e122287ac51919fd4baf1784b77e68", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep all 8 cases. Resolved config controls signing identity, notarization/TCC persistence, destination release feed, channel-specific version metadata. Local-vs-release distinction is real updater compatibility, not arbitrary flags. Same production builder config.", "evidence": ["config/electron-builder.config.cjs"], "original_declarations": 8, "reviewed_declarations": 8, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-builder-native-rebuild.test.mjs", "sha256": "6faf310bfd7fe32cf998ad30bbc7f7569543daa254d2a037c3997e282a893a36", "cases": [{"line": 11, "title": "passes the target platform and arch to Orca native rebuild script", "decision": "keep", "reason": "Actual child rebuild invocation forwards target platform and architecture.", "reviewed_line": 11}, {"line": 25, "title": "returns false so electron-builder skips its optional module rebuild pass", "decision": "keep", "reason": "Hook returns false so electron-builder does not repeat optional module rebuilds.", "reviewed_line": 25}, {"line": 45, "title": "reuses a prepared native runtime only for the host target", "decision": "keep", "reason": "Prepared-native reuse applies only to the matching host platform/architecture, preventing foreign-artifact reuse.", "reviewed_line": 45}, {"line": 72, "title": "builds the native CLI launcher before packaging Windows resources", "decision": "keep", "reason": "Windows CLI launcher build and native agent-hook preparation run before resources are packaged.", "reviewed_line": 72}, {"line": 102, "title": "rejects incomplete electron-builder contexts", "decision": "keep", "reason": "Incomplete builder context fails with actionable target information instead of rebuilding the wrong host.", "reviewed_line": 102}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "6faf310bfd7fe32cf998ad30bbc7f7569543daa254d2a037c3997e282a893a36", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 5 cases. Actual child invocation/return-false boundary, target platform/arch, prepared-runtime same-host-only reuse, Windows native CLI and agent hook ordering, incomplete context errors. Production `electron-builder-native-rebuild.cjs`.", "evidence": ["config/scripts/electron-builder-native-rebuild.cjs"], "original_declarations": 5, "reviewed_declarations": 5, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-builder-runtime-resources.test.mjs", "sha256": "44aea1d7b65fcda14c99c5a3145eabd7855cc041d04de84f4aaeb21ae9550128", "cases": [{"line": 33, "title": "verifies packaged main runtime deps from Windows-style asar entries", "decision": "keep", "reason": "Actual runtime dependency scanner handles Windows ASAR separators and validates required main imports.", "reviewed_line": 33}, {"line": 55, "title": "verifies literal dynamic imports from the packaged main bundle", "decision": "keep", "reason": "Literal dynamic-import dependencies in the main bundle enter the actual packaged closure.", "reviewed_line": 55}, {"line": 90, "title": "still fails when a required packaged main entry is missing entirely", "decision": "keep", "reason": "A missing required packaged main entry must fail validation rather than look like an empty dependency set.", "reviewed_line": 90}, {"line": 108, "title": "verifies bare imports that rolldown hoisted into a shared main chunk", "decision": "keep", "reason": "Bare imports moved into a shared main chunk are still discovered and validated.", "reviewed_line": 108}, {"line": 142, "title": "reads a spread require, whose leading dots are not member access", "decision": "keep", "reason": "Spread syntax before require does not suppress a genuine dependency reference.", "reviewed_line": 142}, {"line": 162, "title": "ignores member calls onto Orca methods that are themselves named require", "decision": "keep", "reason": "Member calls named require are excluded without hiding actual CommonJS requires.", "reviewed_line": 162}, {"line": 184, "title": "normalizes host-specific asar entry separators", "decision": "keep", "reason": "Both host separator forms normalize to the same actual ASAR entry identities.", "reviewed_line": 184}, {"line": 191, "title": "prunes non-target node-pty architecture outputs from packaged runtime resources", "decision": "keep", "reason": "Actual pruning removes non-target node-pty outputs while keeping the target native binary.", "reviewed_line": 191}, {"line": 222, "title": "copies the Windows node-pty ConPTY runtime beside the rebuilt addon", "decision": "keep", "reason": "Actual Windows staging places ConPTY runtime files beside the rebuilt node-pty addon.", "reviewed_line": 222}, {"line": 259, "title": "includes external main dependencies in the packaged runtime closure", "decision": "keep", "reason": "Resolved runtime resource closure includes real external main dependencies.", "reviewed_line": 259}, {"line": 274, "title": "includes the Claude agent SDK in every desktop package plan", "decision": "keep", "reason": "Every platform's package plan includes the externally loaded Claude agent SDK.", "reviewed_line": 274}, {"line": 285, "title": "prunes non-target @parcel/watcher architecture subpackages", "decision": "keep", "reason": "Actual watcher pruning removes foreign architecture packages while preserving target variants.", "reviewed_line": 285}, {"line": 310, "title": "leaves unrelated @parcel/* runtime deps untouched when pruning the watcher", "decision": "keep", "reason": "Pruning is scoped to watcher architecture packages and preserves unrelated @parcel dependencies.", "reviewed_line": 310}, {"line": 332, "title": "prunes type declaration artifacts from packaged runtime node_modules", "decision": "keep", "reason": "Actual filesystem pruning strips declaration artifacts without removing runtime files.", "reviewed_line": 332}, {"line": 350, "title": "prunes duplicate darwin sherpa-onnx runtime dylib aliases", "decision": "keep", "reason": "macOS speech runtime pruning removes duplicate dylib aliases without losing target libraries.", "reviewed_line": 350}, {"line": 370, "title": "prunes zod TypeScript sources from packaged runtime resources", "decision": "keep", "reason": "Zod TypeScript source stripping preserves required runtime resource files.", "reviewed_line": 370}, {"line": 386, "title": "fails when the packaged resources directory is missing", "decision": "keep", "reason": "A missing packaged resources directory fails validation explicitly.", "reviewed_line": 386}, {"line": 400, "title": "prunes non-target native packages before the Linux glibc gate", "decision": "keep", "reason": "Real afterPack ordering removes foreign native binaries before the Linux glibc compatibility gate runs.", "reviewed_line": 400}, {"line": 466, "title": "marks packaged Unix CLI launchers executable", "decision": "keep", "reason": "Actual Unix launcher files receive executable modes and expected packaged runtime identity/type metadata.", "reviewed_line": 466}, {"line": 619, "title": "excludes runtime builtins while retaining ordinary lazy dependencies", "decision": "keep", "reason": "Actual scanner treats builtins separately while retaining ordinary lazily required packages.", "reviewed_line": 619}, {"line": 636, "title": "copies every createRequire specifier main uses into the packaged resource plan", "decision": "keep", "reason": "Main createRequire dependencies remain reachable through packaged resources despite bundle require rewriting.", "reviewed_line": 636}, {"line": 665, "title": "resolves the copied emoji dataset the way the packaged main bundle does", "decision": "keep", "reason": "Actual copied emoji dataset resolves through the staged package path used by the main bundle.", "reviewed_line": 665}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "44aea1d7b65fcda14c99c5a3145eabd7855cc041d04de84f4aaeb21ae9550128", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Retain actual runtime import scanning, filesystem pruning, staged resource resolution, executable modes, platform native constraints, and afterPack ordering.", "evidence": ["config/electron-builder.config.cjs", "config/packaged-runtime-node-modules.cjs"], "original_declarations": 22, "reviewed_declarations": 22, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-builder-speech-config.test.mjs", "sha256": "eacc9dfe152847ac95d2dde91acdfad4e5a68ca67aad99cfdb23807bcd3b3aeb", "cases": [{"line": 9, "title": "excludes bundled variants and keeps one target resource per platform", "decision": "keep", "reason": "Actual FileMatcher excludes bundled speech variants, and every target plan retains exactly its platform speech resource; raw pattern checks are secondary.", "reviewed_line": 9}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "eacc9dfe152847ac95d2dde91acdfad4e5a68ca67aad99cfdb23807bcd3b3aeb", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep real FileMatcher exclusion plus one target speech resource per platform. Raw exclusion-string assertions overlap actual matcher and could be trimmed, but target resource mapping is essential native packaging contract. Same builder config.", "evidence": ["config/electron-builder.config.cjs"], "original_declarations": 1, "reviewed_declarations": 1, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-runtime-floor.test.ts", "sha256": "9d502a18df39c3d6b7b7997539e1f1ee739fea65ec0d6db9a7ee4a07bb53f51e", "cases": [{"line": 38, "title": "pins Electron at or above the startup, webview-detach and find-in-page fixes", "decision": "keep", "reason": "Minimum Electron policy guards known startup, webview detach, and find-in-page native fixes unsuitable for routine crash reproduction.", "reviewed_line": 38}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "9d502a18df39c3d6b7b7997539e1f1ee739fea65ec0d6db9a7ee4a07bb53f51e", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep minimum Electron runtime floor. It protects known native environment use-after-free, webview detach and find-in-page bugs that cannot safely be reproduced in routine unit runs. A simple version comparison in this policy test is not a copy of production behavior.", "evidence": ["package.json"], "original_declarations": 1, "reviewed_declarations": 1, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-vite-development-config.test.ts", "sha256": "1b0b10656d3ca646e59a5befc2d0dfd49f9b8552d95da00d3b9105a4a5e75081", "cases": [{"line": 31, "title": "keeps the watch-only TypeScript API out of production config loading", "decision": "keep", "reason": "An isolated production-config load proves the watch-only TypeScript compiler API is not loaded.", "reviewed_line": 31}, {"line": 50, "title": "skips main minification in development (watch=%s)", "decision": "keep", "reason": "Each watch-mode row resolves actual Electron Vite config and verifies development minification is disabled.", "reviewed_line": 50}, {"line": 59, "title": "keeps production minification and crash source maps", "decision": "keep", "reason": "Actual production config enables minification and crash source maps.", "reviewed_line": 59}, {"line": 67, "title": "honors the unminified main diagnostic override in production", "decision": "keep", "reason": "Explicit production diagnostic override disables main minification as requested.", "reviewed_line": 67}, {"line": 76, "title": "honors the development source-map override alongside unminified compilation", "decision": "keep", "reason": "Development source-map override composes with unminified compilation.", "reviewed_line": 76}, {"line": 88, "title": "keeps renderer dependency caches in this worktree and skips gzip reporting", "decision": "keep", "reason": "Renderer cache location is scoped to the worktree and gzip reporting is disabled in resolved config.", "reviewed_line": 88}, {"line": 100, "title": "gives the web client its own worktree cache and skips gzip reporting", "decision": "keep", "reason": "Web client uses a separate worktree cache and disables gzip reporting in actual Vite config.", "reviewed_line": 100}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "1b0b10656d3ca646e59a5befc2d0dfd49f9b8552d95da00d3b9105a4a5e75081", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 7 declarations/all watch rows: actual Electron Vite+Vite resolved config, isolated process verifies compiler API remains unloaded in production, build-vs-serve minifier/maps diagnostics, independent worktree caches. Production `electron.vite.config.ts`, `vite.web.config.ts`.", "evidence": ["electron.vite.config.ts", "vite.web.config.ts"], "original_declarations": 7, "reviewed_declarations": 7, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/electron-vite-output-contract.test.ts", "sha256": "955d247c5dc78d5f26ed7fc4022952a0c4124cce1072ee8a14583656a543f772", "cases": [{"line": 82, "title": "skips main maps only for explicit check builds and always keeps official release maps", "decision": "keep", "reason": "Resolved build config permits map omission only for explicit check builds while official releases retain crash maps.", "reviewed_line": 82}, {"line": 110, "title": "can skip main source maps during development without changing build output settings", "decision": "keep", "reason": "Development map override leaves stable build output paths/format intact.", "reviewed_line": 110}, {"line": 134, "title": "minifies main and renderer with rolldown's in-process minifier", "decision": "keep", "reason": "Actual main and renderer minifier selection uses Rolldown's supported in-process mode.", "reviewed_line": 134}, {"line": 142, "title": "emits hidden main source maps that packaging strips from app.asar", "decision": "keep", "reason": "Hidden main source maps remain available for crash processing and excluded from app.asar.", "reviewed_line": 142}, {"line": 149, "title": "keeps main-process and plain-Node entries at stable CommonJS paths", "decision": "keep", "reason": "Real build entries maintain stable CommonJS paths consumed by Electron and plain-Node runtimes.", "reviewed_line": 149}, {"line": 185, "title": "keeps CLI main imports unpacked at stable paths", "decision": "keep", "reason": "CLI main import paths align with actual unpacking rules and module format.", "reviewed_line": 185}, {"line": 225, "title": "externalizes packaged dependencies but bundles self-contained main dependencies", "decision": "keep", "reason": "Resolved externalization behavior distinguishes packaged dependencies from self-contained bundled dependencies; raw exclusion-list checks are supplementary.", "reviewed_line": 225}, {"line": 258, "title": "bundles validation dependencies used by the sandboxed preload", "decision": "keep", "reason": "Sandboxed preload bundles its validation dependency rather than requiring an unavailable external module.", "reviewed_line": 258}, {"line": 262, "title": "exits when a static import fails before source error guards load", "decision": "keep", "reason": "A real VM bootstrap static-import failure exits before later source error guards can run.", "reviewed_line": 262}, {"line": 298, "title": "records the bootstrap failure it exits on, since the guard hides Electron dialog", "decision": "keep", "reason": "Actual fatal bootstrap execution persists the error before exit, replacing the hidden Electron error dialog.", "reviewed_line": 298}, {"line": 319, "title": "creates the parent directory an overridden log path names but does not have", "decision": "keep", "reason": "The actual bootstrap guard creates missing log parent directories for an overridden path.", "reviewed_line": 319}, {"line": 335, "title": "falls back to the default location when the overridden log path is unwritable", "decision": "keep", "reason": "An unwritable overridden log target falls back to the default diagnostic location.", "reviewed_line": 335}, {"line": 354, "title": "isolates renderer entry side effects behind strict facades", "decision": "keep", "reason": "Strict entry facades preserve renderer side-effect isolation in actual output config.", "reviewed_line": 354}, {"line": 360, "title": "gives the dev terminal daemon helper the TCC identity watched by Orca", "decision": "keep", "reason": "Development daemon helper config uses the macOS TCC identity consumed by Orca.", "reviewed_line": 360}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "955d247c5dc78d5f26ed7fc4022952a0c4124cce1072ee8a14583656a543f772", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Retain resolved build output/externalization/preload contracts and actual VM bootstrap-fatal exit/persistence/fallback behavior.", "evidence": ["electron.vite.config.ts", "config/build-plugins/bootstrap-fatal-exit-banner.ts", "config/electron-builder.config.cjs"], "original_declarations": 14, "reviewed_declarations": 14, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/ensure-native-runtime-job-ownership.test.mjs", "sha256": "62b913a91d8330c0fa398fde2ef329bf04fe6d166a03c063fe4e0c931ce66f36", "cases": [{"line": 65, "title": "keeps node-addon-api project paths absolute during Windows source builds", "decision": "keep", "reason": "Actual upstream patch uses absolute node-addon-api project paths for Windows source builds.", "reviewed_line": 65}, {"line": 71, "title": "leaves the unchanged Windows helper and fallback on their upstream prebuilds", "decision": "keep", "reason": "Patch keeps unchanged helper/fallback targets on upstream prebuilds; this is an actual native build-target contract.", "reviewed_line": 71}, {"line": 79, "title": "sniffs for a literal the patch really adds to conpty.cc", "decision": "keep", "reason": "Gate constant is tied to added conpty.cc code in the real shipped patch, preventing impossible rebuild advice.", "reviewed_line": 79}, {"line": 96, "title": "looks for that literal in the encoding the compiler stores it in", "decision": "keep", "reason": "Actual marker bytes match the UTF-16LE encoding MSVC stores for the C++ wide literal.", "reviewed_line": 96}, {"line": 101, "title": "rejects the prebuild that shipped without the job exports", "decision": "fix", "reason": "One actual PREBUILD rejection now asserts both missing job exports and the resolved prebuild path.", "reviewed_line": 101}, {"line": 107, "title": "names where the bad native came from, so the fix is obvious", "decision": "consolidate", "reason": "Additional prebuild-path diagnostic is preserved in the same rejection assertion at original line 101.", "coverage_target": {"path": "config/scripts/ensure-native-runtime-job-ownership.test.mjs", "line": 101}}, {"line": 113, "title": "accepts a source build carrying the patch", "decision": "keep", "reason": "A source-built addon with required exports and actual marker bytes is accepted.", "reviewed_line": 107}, {"line": 120, "title": "rejects a source build that predates the Cygwin/MSYS breakaway denial", "decision": "fix", "reason": "One actual stale-source rejection now asserts the addon path, obsolete MSYS denial, and source rebuild remedy.", "reviewed_line": 114}, {"line": 126, "title": "tells that build apart by path, and says to rebuild", "decision": "consolidate", "reason": "Path and rebuild-remedy expectations are preserved in the retained stale-source rejection at original line 120.", "coverage_target": {"path": "config/scripts/ensure-native-runtime-job-ownership.test.mjs", "line": 120}}, {"line": 132, "title": "refuses rather than skip when the addon cannot be read: %s", "decision": "keep", "reason": "All absent/unreadable addon-path rows must refuse rather than silently skip validation.", "reviewed_line": 120}, {"line": 144, "title": "stays out of the way on %s", "decision": "keep", "reason": "Each irrelevant platform/native-name row proves Windows conpty validation is properly scoped.", "reviewed_line": 132}, {"line": 152, "title": "would have thrown on Windows for the very same input", "decision": "keep", "reason": "A Windows control with the same input proves irrelevant-platform cases do not merely pass due to a benign fixture.", "reviewed_line": 140}, {"line": 162, "title": "resolves the addon against node-pty lib, which is the only base callers share", "decision": "keep", "reason": "Actual addon path resolution uses node-pty's lib-relative native dir rather than caller cwd.", "reviewed_line": 150}, {"line": 172, "title": "handles the bundled layout, where the addon sits beside lib", "decision": "keep", "reason": "Bundled layout resolves the addon beside lib using the actual path calculation.", "reviewed_line": 160}, {"line": 201, "title": "accepts the addon a good same-host rebuild leaves behind", "decision": "keep", "reason": "A real same-host rebuild artifact carrying valid PE architecture and marker is accepted.", "reviewed_line": 189}, {"line": 208, "title": "rejects one that predates the denial, wherever the rebuild ran", "decision": "keep", "reason": "A rebuild artifact with the correct architecture but old breakaway behavior must reject for either host mode.", "reviewed_line": 196}, {"line": 220, "title": "refuses a same-host rebuild that reported success and produced nothing", "decision": "fix", "reason": "Missing same-host output rejects with success-report, build/Release, and ARM64 prebuild diagnostics; the retained fixture now uses arm64 to preserve original line 227.", "reviewed_line": 208}, {"line": 227, "title": "names both the addon it wanted and the prebuild that would load instead", "decision": "consolidate", "reason": "ARM64 fallback-path expectation is merged into original line 220, including its arm64 rebuild target; no target-specific diagnostic is discarded.", "coverage_target": {"path": "config/scripts/ensure-native-runtime-job-ownership.test.mjs", "line": 220}}, {"line": 237, "title": "rejects an addon of an architecture this rebuild did not target", "decision": "keep", "reason": "Actual PE machine value must match requested rebuild architecture.", "reviewed_line": 220}, {"line": 247, "title": "does not blame --arch for a file that is not a PE image", "decision": "fix", "reason": "One actual malformed-PE fixture now asserts its classification, published-prebuild fallback consequence, and truncated/quarantined guidance.", "reviewed_line": 230}, {"line": 256, "title": "still names the consequence for that file, which is the prebuild", "decision": "consolidate", "reason": "Malformed-PE fallback consequence is preserved in the same actual rejection at original line 247.", "coverage_target": {"path": "config/scripts/ensure-native-runtime-job-ownership.test.mjs", "line": 247}}, {"line": 265, "title": "accepts one a cross-arch rebuild really did emit for the target", "decision": "keep", "reason": "A real cross-architecture PE fixture for the requested target is accepted.", "reviewed_line": 241}, {"line": 274, "title": "does not judge an architecture it has no machine value for", "decision": "keep", "reason": "An unknown architecture skips only machine comparison instead of making unsupported assumptions.", "reviewed_line": 250}, {"line": 281, "title": "warns instead: %s", "decision": "keep", "reason": "Cross-host/no-install warning rows exercise the intentionally nonfatal missing-artifact boundary and actual warning output.", "reviewed_line": 257}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "5d0392135ad2071ef857994b6ad034d9e7732c2e0040ce73f1b06aee34ea2c73", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Consolidate identical rejection scenarios and their diagnostics, retaining all native safety boundaries, PE architecture checks, real patch marker linkage, and ARM64 fallback paths.", "evidence": ["config/scripts/node-pty-job-ownership.cjs", "config/patches/node-pty@1.1.0.patch", "config/scripts/windows-pe-machine.cjs"], "original_declarations": 24, "reviewed_declarations": 20, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/ensure-native-runtime.test.mjs", "sha256": "1600ee4adc16cf98be3f19aadac13b361dc4ff6b258531d15e3e2379a9ff97dd", "cases": [{"line": 36, "title": "rechecks Node native modules in fresh child processes after rebuilding", "decision": "keep", "reason": "Copied production scripts run in actual fresh processes and recheck addon loading after rebuild, including large output handling.", "reviewed_line": 36}, {"line": 80, "title": "rebuilds other failed Windows addons with patched node-pty and tracking=$tracking", "decision": "keep", "reason": "Every TrackFileAccess row checks actual Windows rebuild subprocess environment and patched node-pty integration.", "reviewed_line": 80}, {"line": 124, "title": "rebuilds patched node-pty artifacts even when the Node load check passes", "decision": "keep", "reason": "A successful load probe cannot substitute for the required source-built patched native artifact.", "reviewed_line": 124}, {"line": 157, "title": "rebuilds when patched artifacts exist but node-pty resolves to prebuilds", "decision": "keep", "reason": "A patched artifact on disk is insufficient when actual module resolution still picks the upstream prebuild.", "reviewed_line": 157}, {"line": 189, "title": "keeps the fast path when the platform-specific patched artifacts exist", "decision": "keep", "reason": "Actual platform artifact presence retains the no-rebuild fast path.", "reviewed_line": 189}, {"line": 220, "title": "finds the installed node-gyp entry from an addon without build tools on PATH", "decision": "keep", "reason": "Actual node-gyp discovery follows the installed addon dependency chain with empty PATH; the old pnpm invocation is an executable negative control.", "reviewed_line": 220}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "1600ee4adc16cf98be3f19aadac13b361dc4ff6b258531d15e3e2379a9ff97dd", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 6 declarations/all Windows TrackFileAccess rows. Real copied production scripts run fresh subprocesses around fake addon/compiler external boundaries. Captures output larger than default buffers, correct platform compile env, source-build artifact requirement despite loadability, prebuild-vs-source path, no-rebuild fast path and actual installed node-gyp command discovery with empty PATH. Historical failing pnpm invocation is a real executable boundary control, not an inline obsolete implementation. Production `ensure-native-runtime.mjs`, native-build scripts, `windows-process-tree-gyp-rebuild.mjs`.", "evidence": ["config/scripts/ensure-native-runtime.mjs", "config/scripts/windows-process-tree-gyp-rebuild.mjs"], "original_declarations": 6, "reviewed_declarations": 6, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/ephemeral-vm-runtime-store-cross-version.test.ts", "sha256": "8d0254f61d4c228400b19a6faa8bef4f35120ec0cc7e57316a92382c5cf0e3c3", "cases": [{"line": 83, "title": "`STA-4274 ${operation ?? 'disabled'}`", "decision": "keep", "reason": "Retain environment-driven cross-version driver: all eight operation branches participate in real shared-store lifecycle/rollback/upgrade checks; writes are validated by subsequent version processes in the repro harness, and routine unit execution intentionally skips.", "reviewed_line": 83}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "8d0254f61d4c228400b19a6faa8bef4f35120ec0cc7e57316a92382c5cf0e3c3", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "cross-version-driver", "rationale": "Classify environment-driven multi-version driver. One dynamic declaration; 8 actual operation branches: write-legacy, write-mixed, read, rollback-projection read, lifecycle mutation+real cleanup script proof, re-upgrade read, legacy read, unknown-operation error. Writes intentionally defer validation to other version processes in `run-ephemeral-vm-runtime-store-rollback-repro.mjs`. Keep; normal unit run skips; dedicated workflow/harness runs baseline/affected/current/reverted sources on shared persisted data and requires known negative failures. Production store, feature ledger and rollback projection modules.", "evidence": ["config/scripts/run-ephemeral-vm-runtime-store-rollback-repro.mjs", "src/shared/ephemeral-vm-runtime-store.ts"], "original_declarations": 1, "reviewed_declarations": 1, "complete_body_and_tables_reviewed": true, "inline_operations": ["write-legacy", "write-mixed", "read", "read-rollback-projection", "mutate-lifecycle", "read-after-downgrade", "read-legacy", "unknown-operation rejection"], "execution_note": "Normal unit run intentionally skipped; external cross-version repro harness reviewed but not run in this Linux batch."} +{"path": "config/scripts/file-explorer-deletion-roots-benchmark.mjs", "sha256": "d13fad3c55b87d8ea5aec4627fef69d4e3f670bf2d25ec96cc2324a610e86e7e", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "d13fad3c55b87d8ea5aec4627fef69d4e3f670bf2d25ec96cc2324a610e86e7e", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "manual-production-comparison-benchmark", "rationale": "Imports the actual production selector/path comparator and checks five input-shape equivalences against a historical performance arm; copied old code is appropriate as a comparison arm.", "evidence": ["src/renderer/src/components/right-sidebar/file-explorer-batch-deletion.ts", "src/renderer/src/components/right-sidebar/file-explorer-batch-deletion.test.ts"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "embedded_checks": [{"line": 50, "title": "five flat file/directory workloads preserve output", "decision": "keep", "reason": "All [100,0], [1000,0], [5000,0], [5000,5], [0,100] table rows compare actual production selector identity/order to the historical performance arm; these flat paths do not establish nested-removal coverage."}], "execution_note": "Classified and reviewed; standalone script not run in this batch."} +{"path": "config/scripts/file-explorer-tree-projection-benchmark.mjs", "sha256": "fcdf0f947998b6b51bcf95d1428cc68e2946b01794d517568b686d06f0636239", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "fcdf0f947998b6b51bcf95d1428cc68e2946b01794d517568b686d06f0636239", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "exploratory-prototype-benchmark", "rationale": "Algorithms and fixtures are local research prototypes with no actual production import or explicit correctness assertions; retain artifact but do not claim production validation.", "evidence": ["src/renderer/src/components/right-sidebar/file-explorer-row-projection.ts"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "execution_note": "Local research prototype; no actual production import/correctness oracle and no fabricated cases. Not run as regression validation."} +{"path": "config/scripts/foreign-sqlite-reader-worker-smoke.mjs", "sha256": "0c90a93be25e25087e16168d60773ec7fa688cb70afe3262c51905b66027bfb7", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "0c90a93be25e25087e16168d60773ec7fa688cb70afe3262c51905b66027bfb7", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "build-worker-smoke-support", "rationale": "Runs the real built SQLite worker using packaged Node, actual fixture sessions, missing-profile handling and OpenCode dispatch; rejects worker errors, early exit, timeout, and wrong results.", "evidence": ["config/scripts/build-orcad.mjs", "config/scripts/foreign-sqlite-reader-worker-smoke.test.mjs"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "embedded_checks": [{"line": 17, "title": "real SQLite binder sessions", "decision": "keep", "reason": "Actual worker output must match the session written into the temporary SQLite database."}, {"line": 22, "title": "missing Cursor profile", "decision": "keep", "reason": "Actual missing database path must yield status missing."}, {"line": 24, "title": "OpenCode list dispatch", "decision": "keep", "reason": "Actual built entry must route an empty list request to empty candidates/issues."}, {"line": 32, "title": "worker and process failure boundaries", "decision": "keep", "reason": "Timeout, worker error/exit, wrong ID/status/value, or failed runtime process aborts the smoke."}], "execution_note": "Classified and reviewed; standalone script not run in this batch."} +{"path": "config/scripts/foreign-sqlite-reader-worker-smoke.test.mjs", "sha256": "7feeaaf8f11c5c81c50e52b3195b22dd4b10a78b9d887146af51e044b94cd6b8", "cases": [{"line": 40, "title": "passes against the built entry", "decision": "keep", "reason": "Actual built worker entry reads real temporary SQLite data and satisfies the smoke response oracle.", "reviewed_line": 40}, {"line": 44, "title": "fails when the entry is missing", "decision": "keep", "reason": "Missing entry fails the actual smoke rather than reporting readiness without execution.", "reviewed_line": 44}, {"line": 48, "title": "fails when the worker answers without reading", "decision": "keep", "reason": "An inert real worker that replies without reading fails the smoke, proving response presence alone is insufficient.", "reviewed_line": 48}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "7feeaaf8f11c5c81c50e52b3195b22dd4b10a78b9d887146af51e044b94cd6b8", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep built real source/worker success, missing entry rejection, and inert worker that replies without reading. Last case proves a falsely successful response cannot satisfy smoke. No mock internal logic.", "evidence": ["config/scripts/foreign-sqlite-reader-worker-smoke.mjs"], "original_declarations": 3, "reviewed_declarations": 3, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/generate-bundled-skill-guides.test.mjs", "sha256": "926068948c4a8bf40e6fa0923f6ed2ed5170ed1353ecca95999cb9f4d2ce998e", "cases": [{"line": 74, "title": "projects stub topics as hybrid discovery stubs that reuse the guide frontmatter", "decision": "keep", "reason": "Actual generated discovery stubs preserve guide frontmatter and project intended topic content.", "reviewed_line": 74}, {"line": 93, "title": "resolves the documented cleanup path from custom, XDG, and home settings", "decision": "keep", "reason": "Documented cleanup shell snippets execute under custom, XDG, and home configurations and resolve the intended directory.", "reviewed_line": 93}, {"line": 135, "title": "keeps Vercel sandbox names valid while preserving the instance suffix", "decision": "keep", "reason": "Documented Vercel sandbox naming code executes and preserves a valid name plus instance suffix.", "reviewed_line": 135}, {"line": 178, "title": "embeds compact guides, version-matched reference packages, and append-only aliases", "decision": "keep", "reason": "Actual compact guide/reference/alias outputs preserve the shipped distribution and append-only compatibility contracts.", "reviewed_line": 178}, {"line": 237, "title": "builds deterministic artifacts and verifies the checked-in outputs", "decision": "keep", "reason": "Actual generator output is deterministic and matches committed artifacts.", "reviewed_line": 237}, {"line": 245, "title": "generates platform-identical output from CRLF guide sources (existing CRLF: %s)", "decision": "keep", "reason": "Every CRLF fixture row exercises real generator normalization, including guides, stubs, shared fragments, and references.", "reviewed_line": 245}, {"line": 283, "title": "pins guide sources, projections, and embedded output to LF in Git", "decision": "consolidate", "reason": "Replaced exact attribute-string inventory by actual autocrlf checkout of every previously listed guide/stub/shared/skill/embedded-guide path class in generated-artifact-line-ending-pin.test.mjs.", "coverage_target": {"path": "config/scripts/generated-artifact-line-ending-pin.test.mjs", "line": 9}}, {"line": 294, "title": "reports stale outputs and write mode repairs all projections", "decision": "keep", "reason": "Actual stale-output detection is repaired by write mode across generated projections.", "reviewed_line": 283}, {"line": 310, "title": "formats contributor-facing paths with forward slashes on every platform", "decision": "keep", "reason": "Contributor diagnostics use forward-slash paths even when inputs use host-specific separators.", "reviewed_line": 299}, {"line": 322, "title": "rejects mismatched source names and ambiguous aliases", "decision": "keep", "reason": "Mismatched source names and alias collisions reject through the real generator.", "reviewed_line": 311}, {"line": 346, "title": "projects one shared resolver fragment byte-for-byte into every stub", "decision": "keep", "reason": "Actual fragment composition places one identical resolver block in every discovery stub.", "reviewed_line": 335}, {"line": 358, "title": "fails loudly on an unknown, missing, duplicated, or re-inlined shared block", "decision": "keep", "reason": "Each unknown/missing/duplicated/re-inlined shared-block fixture rejects through the production composer.", "reviewed_line": 347}, {"line": 374, "title": "rejects non-Markdown and empty bundled references", "decision": "keep", "reason": "Actual bundled-reference validation rejects empty and non-Markdown reference inputs.", "reviewed_line": 363}, {"line": 409, "title": "routes every shipped reference from its own guide, in both directions", "decision": "keep", "reason": "Actual guide/reference relationships are checked in both directions so every shipped reference remains discoverable.", "reviewed_line": 398}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "54d8330848111579d46ebf42b744a8f0ceabd3fd637934457bfe5686f57fd813", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Retain actual generator, documented shell, artifact, alias, and reference behavior; move LF pinning assertions from copied attribute strings into the real Git checkout suite.", "evidence": ["config/scripts/generate-bundled-skill-guides.mjs", "config/scripts/skill-stub-composition.mjs", ".gitattributes"], "original_declarations": 14, "reviewed_declarations": 13, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/generate-monaco-associations.test.mjs", "sha256": "882a1f5921c5f06f0ab66924a61f78e6adfdc77205ec10dd91be912dc48cb40e", "cases": [{"line": 6, "title": "matches the installed editor registrations and curated Orca associations", "decision": "keep", "reason": "Actual installed Monaco AST registrations plus curated Orca associations must match the generated artifact.", "reviewed_line": 6}, {"line": 13, "title": "keeps built-in Ruby aliases alongside the curated Ruby associations", "decision": "keep", "reason": "Actual Ruby association merging preserves installed built-in aliases alongside curated aliases.", "reviewed_line": 13}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "882a1f5921c5f06f0ab66924a61f78e6adfdc77205ec10dd91be912dc48cb40e", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep actual installed Monaco AST registration+curated associations artifact equality and Ruby built-in/curated merge. Protects vendored editor evolution, not self-supplied fixture inventory. Production `generate-monaco-associations.mjs`.", "evidence": ["config/scripts/generate-monaco-associations.mjs"], "original_declarations": 2, "reviewed_declarations": 2, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/generate-runtime-required-english-catalog.test.mjs", "sha256": "ab9263d03316c1670c602dbf72ad5048f3f338734f1d984a5edd37e07bce975e", "cases": [{"line": 29, "title": "drops only entries every call site already spells identically", "decision": "keep", "reason": "Exact actual key set distinguishes identical defaults from conflicting, dynamic, unreferenced, drifted, and plural entries.", "reviewed_line": 29}, {"line": 40, "title": "keeps a plural entry even when a call site spells it identically", "decision": "remove", "reason": "Identical fixture and collectRuntimeRequiredKeys call are already covered by the first exact key-set assertion, including this plural key.", "coverage_target": {"path": "config/scripts/generate-runtime-required-english-catalog.test.mjs", "line": 29}}, {"line": 46, "title": "produces byte-identical output whatever order the call sites are visited in", "decision": "keep", "reason": "Actual catalog output is byte-identical across reversed reference order and preserves locale-free key sorting.", "reviewed_line": 42}, {"line": 64, "title": "accepts a subset carrying entries that are no longer required", "decision": "keep", "reason": "Old extra subset entries remain compatible while missing/contradicting collections stay empty.", "reviewed_line": 60}, {"line": 76, "title": "rejects a subset that is missing a required entry or contradicts en.json", "decision": "keep", "reason": "Actual subset validation separately reports a missing required entry and a stale conflicting value.", "reviewed_line": 72}, {"line": 88, "title": "rebuilds the nested catalog shape with the English values", "decision": "keep", "reason": "Actual generator rebuilds nested plural/plain catalog structure using canonical English values.", "reviewed_line": 84}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "35c528caa03ab61ab68da89e2f415a76147fe462d3c2efd6bd68cdb8302b853d", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Remove duplicate plural-key assertion already included in the same fixture exact key-set oracle; retain drift/default/plural policy and catalog output checks.", "evidence": ["config/scripts/generate-runtime-required-english-catalog.mjs"], "original_declarations": 6, "reviewed_declarations": 5, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/generate-skill-bundle-manifest.test.mjs", "sha256": "e0aa0f23215c85b2ddb123dec435c1183fe81eaa8d73c9b669bf3907b4ea29de", "cases": [{"line": 97, "title": "folds platform line endings for text identity", "decision": "keep", "reason": "Actual text identity normalizes platform line endings.", "reviewed_line": 97}, {"line": 105, "title": "classifies null-containing and invalid UTF-8 content as binary", "decision": "keep", "reason": "Null bytes and invalid UTF-8 are classified as binary rather than text-normalized.", "reviewed_line": 105}, {"line": 110, "title": "uses normalized text identity but exact executable identity", "decision": "keep", "reason": "Text digests normalize line endings while executable identity preserves exact bytes.", "reviewed_line": 110}, {"line": 121, "title": "orders files identically however they were listed", "decision": "keep", "reason": "Actual manifest/digest output is stable across filesystem enumeration order.", "reviewed_line": 121}, {"line": 145, "title": "writes a schema-3 manifest and fails verification once a skill changes", "decision": "keep", "reason": "Real generator CLI writes schema-3 output and detects a changed skill during verification.", "reviewed_line": 145}, {"line": 159, "title": "keeps every shipped SKILL.md digest and embeds the current LF bytes", "decision": "keep", "reason": "Every shipped SKILL.md digest remains in history and current embedded bytes stay LF-normalized.", "reviewed_line": 159}, {"line": 175, "title": "collects every SKILL.md version in git history, even ones never generated", "decision": "keep", "reason": "Actual temporary Git history traversal collects skill versions that never had generated manifests.", "reviewed_line": 175}, {"line": 188, "title": "fails when a digest is missing or the pull request base cannot be read", "decision": "keep", "reason": "Missing digest or unavailable PR base fails actual history verification instead of silently weakening it.", "reviewed_line": 188}, {"line": 199, "title": "merges digests without duplicates and reports any the base had but HEAD lost", "decision": "keep", "reason": "Actual digest merging deduplicates entries and reports historical digests lost from HEAD.", "reviewed_line": 199}, {"line": 208, "title": "rejects executable files in shipped skill packages", "decision": "keep", "reason": "Executable fixtures are rejected from shipped skill packages.", "reviewed_line": 208}, {"line": 222, "title": "rejects case-colliding paths", "decision": "keep", "reason": "Actual case-collision validation protects case-insensitive platform filesystems.", "reviewed_line": 222}, {"line": 231, "title": "rejects symlinks inside shipped packages", "decision": "keep", "reason": "Actual symlink fixtures are rejected from shipped packages.", "reviewed_line": 231}, {"line": 241, "title": "ignores OS-authored sidecars a working tree may carry", "decision": "keep", "reason": "OS-authored plain-file sidecars do not change actual package identity.", "reviewed_line": 241}, {"line": 260, "title": "still records an unexpected file that is not OS metadata", "decision": "keep", "reason": "Unexpected non-metadata file content remains part of the actual recorded package.", "reviewed_line": 260}, {"line": 271, "title": "keeps guarding a directory or link that only wears an OS metadata name", "decision": "keep", "reason": "A directory or symlink with an OS metadata-looking name still goes through package safety checks.", "reviewed_line": 271}, {"line": 297, "title": "skips exactly the names the scanner skips", "decision": "keep", "reason": "Generator observation and runtime scanner skip exactly the same reviewed metadata-name rows.", "reviewed_line": 297}, {"line": 329, "title": "keeps the whole release-cut job off skill regeneration", "decision": "keep", "reason": "Evaluated release-cut workflow never regenerates skill outputs or mutates digest history.", "reviewed_line": 329}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "e0aa0f23215c85b2ddb123dec435c1183fe81eaa8d73c9b669bf3907b4ea29de", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 17 declarations/all filesystem names. Real generator CLI sandbox write/stale/history/digest append-only behavior, cross-producer normalized byte/digest ordering, executable/case/symlink rejection, OS metadata plain-file treatment vs directory/link, observation parity, release-cut guard. Policy workflow inspection protects shared-index release invariants; preserve. Generic packageDigest 64hex assertion is weak but retained exact cross-order/hash identity and actual runtime scanner parity provide meaningful behavior. Production `generate-skill-bundle-manifest.mjs`, `src/main/skills/skill-package-identity.ts`, release-cut workflow.", "evidence": ["config/scripts/generate-skill-bundle-manifest.mjs", "src/main/skills/skill-package-identity.ts", ".github/workflows/release-cut.yml"], "original_declarations": 17, "reviewed_declarations": 17, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/generate-terminal-perf-html-report.test.mjs", "sha256": "062c694f99e8b632f519865b5d158bc9fded02653d9882233450b5e35700bd5d", "cases": [{"line": 62, "title": "parses labeled and bare input paths plus output flags", "decision": "keep", "reason": "Actual CLI parser handles labeled/bare paths and output flags, including invalid argument rows.", "reviewed_line": 62}, {"line": 89, "title": "writes a single-run report with scenario tables and budget status", "decision": "keep", "reason": "Actual report files produce final HTML scenario tables and correct budget status.", "reviewed_line": 89}, {"line": 129, "title": "renders parked-memory heap and live view counts as table metrics", "decision": "keep", "reason": "Parked-memory heap/live-view metrics render in tables without being treated as time budgets.", "reviewed_line": 129}, {"line": 148, "title": "marks over-budget rows as failures for the latest run", "decision": "keep", "reason": "Only the latest revision's over-budget rows are marked as failures.", "reviewed_line": 148}, {"line": 172, "title": "continues to flag slow hidden restores", "decision": "keep", "reason": "Actual hidden-restore budget violations remain visible in generated HTML.", "reviewed_line": 172}, {"line": 184, "title": "renders ordered revisions with trend charts and baseline deltas", "decision": "keep", "reason": "Actual multi-revision HTML orders trends and computes baseline percentage deltas.", "reviewed_line": 184}, {"line": 225, "title": "renders missing scenarios at older revisions as gaps, not zeros", "decision": "keep", "reason": "Missing older scenarios render as gaps rather than fabricated zero-valued observations.", "reviewed_line": 225}, {"line": 275, "title": "fails when reports contain no terminal perf annotations", "decision": "keep", "reason": "Actual empty/non-terminal report input fails instead of producing misleading output.", "reviewed_line": 275}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "062c694f99e8b632f519865b5d158bc9fded02653d9882233450b5e35700bd5d", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 8 declarations/all parser rows. Real file reports and final HTML, budgets latest-only, memory table metrics without time budgets, hidden restore gate, ordered trend/baseline percent math and missing scenarios as gaps, no terminal data rejection. Strings assert actual published document/metrics. Production `generate-terminal-perf-html-report.mjs`, `terminal-perf-report-rows.mjs` and report budgets.", "evidence": ["config/scripts/generate-terminal-perf-html-report.mjs", "config/scripts/terminal-perf-report-rows.mjs"], "original_declarations": 8, "reviewed_declarations": 8, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/generated-artifact-line-ending-pin.test.mjs", "sha256": "3ba2f2659e30d121ba4c99a36aea9529dc40c48aa0c8f8fb45e59a5fc6c99c22", "cases": [{"line": 9, "title": "keeps byte-compared artifacts and source LF in an autocrlf checkout", "decision": "fix", "reason": "Actual Git checkout verifies five additional guide/stub/shared/skill/embedded-guide path classes stay LF, retaining existing Windows-native and unrelated-path CRLF controls.", "reviewed_line": 9}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "78f9be9e0ba35a5ed31972ffdbb9145e82cae018979b0efb11875a1a7c3c6c01", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Actual autocrlf checkout now proves LF guide/stub/shared/skill/generated-guide bytes alongside existing pinned paths and CRLF controls.", "evidence": [".gitattributes", "config/scripts/generate-bundled-skill-guides.test.mjs"], "original_declarations": 1, "reviewed_declarations": 1, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/git-diff-blob-concurrency-benchmark.mjs", "sha256": "0f28ba936da60fae22428b0c5c42a0e2aa4e6d5593cf5a14f9c92a67b4ddb872", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "0f28ba936da60fae22428b0c5c42a0e2aa4e6d5593cf5a14f9c92a67b4ddb872", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "manual-git-io-comparison-benchmark", "rationale": "Executes bounded real Git IO for explicit HEAD/parent candidates, checks nonempty candidates/equal byte lengths, and compares independent strategies; does not import production loader.", "evidence": ["config/scripts/git-diff-blob-concurrency-benchmark.mjs"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "embedded_checks": [{"line": 103, "title": "bounded Git candidates exist", "decision": "keep", "reason": "Only explicit HEAD/parent path candidates are used; an empty real candidate set rejects."}, {"line": 118, "title": "strategies return equal byte lengths", "decision": "keep", "reason": "Real sequential/concurrent Git IO results must agree in resulting byte lengths before timing; this does not validate the actual loader."}], "execution_note": "Classified and reviewed; standalone script not run in this batch."} +{"path": "config/scripts/git-pull-request-diff-base.test.mjs", "sha256": "d5ec01fd3bc4522c1a47010f526371d20df987beeca4f5352dade188ff536de1", "cases": [{"line": 5, "title": "uses the merge commit first parent for pull request checkouts", "decision": "keep", "reason": "Synthetic PR merge commits select the actual first parent as the diff base.", "reviewed_line": 5}, {"line": 11, "title": "keeps the requested base outside synthetic pull request merges", "decision": "keep", "reason": "Single-parent and non-PR event inputs preserve the explicitly requested base.", "reviewed_line": 11}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "d5ec01fd3bc4522c1a47010f526371d20df987beeca4f5352dade188ff536de1", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep actual synthetic-merge first-parent selection and fallback for single-parent/non-PR events. Production `git-pull-request-diff-base.mjs`, real callers in generation gates.", "evidence": ["config/scripts/git-pull-request-diff-base.mjs"], "original_declarations": 2, "reviewed_declarations": 2, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/github-opened-issue-repository.test.ts", "sha256": "bbd534c3802fae5032e9af9bedd305840cc1de94a17a22c2abca9b464ad2c94a", "cases": [{"line": 177, "title": "scopes $openedItem.title labels under $preference to its canonical list row", "decision": "keep", "reason": "Every opened-item/preference row executes actual edit handlers and external gh routing while preserving canonical repository cache identity.", "reviewed_line": 177}, {"line": 236, "title": "loads $owner picker candidates while preference=$preference", "decision": "keep", "reason": "Every owner/preference row executes actual metadata picker routing for labels/assignees instead of trusting preference state.", "reviewed_line": 236}, {"line": 268, "title": "a $openedItem.title close only controls its own row while search lags (list=$listItem.title)", "decision": "keep", "reason": "All stale-search close matrices preserve authority for only the canonical opened repository row.", "reviewed_line": 268}, {"line": 312, "title": "keeps ordinary metadata caches distinct by canonical repository and host", "decision": "keep", "reason": "Actual metadata caches are distinct by repository and GitHub host.", "reviewed_line": 312}, {"line": 326, "title": "keeps metadata requests without an explicit target compatible", "decision": "keep", "reason": "Legacy metadata callers without an explicit target preserve the existing default API route.", "reviewed_line": 326}, {"line": 341, "title": "keeps Project row metadata on the existing slug route", "decision": "keep", "reason": "Project metadata retains the existing slug route through actual hook/API execution.", "reviewed_line": 341}, {"line": 386, "title": "rolls back a rejected fork label without changing the upstream row", "decision": "keep", "reason": "Actual failed fork-label mutation rolls back the fork state without modifying the upstream cache row.", "reviewed_line": 386}, {"line": 430, "title": "does not fall back to upstream metadata for an invalid explicit repository", "decision": "keep", "reason": "An invalid explicit repository must fail closed rather than silently mutating/loading upstream metadata.", "reviewed_line": 430}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "bbd534c3802fae5032e9af9bedd305840cc1de94a17a22c2abca9b464ad2c94a", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 8 declarations/all routing matrices. React hooks are simplified to observe actual component/hook callbacks; actual mutation/store/API repository routing runs through to mocked external gh process boundary. Covers cross-fork labels/cache identity, metadata labels/assignees, close authority under stale search, host-key isolation, old callers, Project slug route, rejection rollback and invalid explicit target fail-closed. Assertions are real output/state and external args; not mock echoes. Production actual gh edit section/mutations, useGitHubRepoMetadata, issue-field-options, issue-update, cache selectors/authority registry.", "evidence": ["src/renderer/src/components/github-item-dialog/edit-item-fields/gh-edit-section.tsx", "src/renderer/src/components/github-item-dialog/edit-item-fields/gh-edit-section-mutations.ts", "src/renderer/src/hooks/useIssueMetadata.ts", "src/main/github/issue-field-options.ts", "src/main/github/issue-update.ts"], "original_declarations": 8, "reviewed_declarations": 8, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/github-pr-assignee-repository.test.ts", "sha256": "e6dc517e18e6f46e2d3d00b1c26e363cdf2aa960a26f4ee1ca1541dbd1f283ed", "cases": [{"line": 145, "title": "keeps $owner PR assignees under $preference (remove=$assigned, legacy=$legacy)", "decision": "keep", "reason": "All five owner/preference/add-remove/legacy rows invoke actual assignee component callbacks and real mutations down to the external gh boundary, preserving canonical PR routing and WSL options.", "reviewed_line": 145}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "e6dc517e18e6f46e2d3d00b1c26e363cdf2aa960a26f4ee1ca1541dbd1f283ed", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep one declaration/5 matrix rows: add/remove upstream vs fork while preference opposes canonical PR repo, WSL options preserved, legacy URL fallback. Captures actual component toggle callback and executes real mutation+updateIssue down to gh command. Production PRAssigneesPanel and GitHub work item identity/routing modules.", "evidence": ["src/renderer/src/components/github/PRAssigneesPanel.tsx", "src/renderer/src/components/github/github-work-item-edit-mutations.ts", "src/main/github/issue-update.ts"], "original_declarations": 1, "reviewed_declarations": 1, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/hang-watchdog-memory-benchmark.mjs", "sha256": "fa5fb59c8059afd053ef09190eb6d5896423d8a95d1a99c344b18f19dc98bfb3", "cases": [], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "fa5fb59c8059afd053ef09190eb6d5896423d8a95d1a99c344b18f19dc98bfb3", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "macos-built-runtime-benchmark-and-oracle", "rationale": "Actual built Electron/watchdog measures GC, footprint/CPU, and blocked-main detection/recovery; platform and built-revision guards preserve meaningful worker-vs-historical-child comparisons. Do not run on Linux.", "evidence": ["config/scripts/hang-watchdog-process-metrics.mjs"], "original_declarations": 0, "reviewed_declarations": 0, "complete_body_and_tables_reviewed": true, "embedded_checks": [{"line": 40, "title": "real Electron GC prerequisite", "decision": "keep", "reason": "The macOS benchmark refuses to fake memory collection when GC is unavailable."}, {"line": 64, "title": "blocked main detection and recovery", "decision": "keep", "reason": "Actual built watchdog marker timestamp must fall within the synchronous main stall and selfRecovered must transition false to true."}, {"line": 360, "title": "platform and matching-built-boundary prerequisites", "decision": "keep", "reason": "macOS-only harness requires built entry and the matching worker/child contract before launching Electron."}], "execution_note": "Classified and reviewed; standalone script not run in this batch."} +{"path": "config/scripts/hang-watchdog-process-metrics.test.mjs", "sha256": "b14017bb024307c1f0c368dc6efbf4056e5ff7f9c06c1779732b0ada9bd31add", "cases": [{"line": 22, "title": "uses the de-duplicated summary for multiple processes", "decision": "keep", "reason": "Actual footprint parser uses de-duplicated summary for multiprocess output.", "reviewed_line": 22}, {"line": 33, "title": "uses the process footprint rather than auxiliary accounting for one process", "decision": "keep", "reason": "Single-process parsing uses process physical footprint instead of auxiliary accounting.", "reviewed_line": 33}, {"line": 41, "title": "rejects missing or zero footprint summaries", "decision": "keep", "reason": "Missing and zero footprint summaries fail actual parsing.", "reviewed_line": 41}, {"line": 46, "title": "parses ps CPU time %s", "decision": "keep", "reason": "Every ps CPU-time shape row checks actual units and parsing.", "reviewed_line": 46}, {"line": 54, "title": "rejects invalid CPU times", "decision": "keep", "reason": "Invalid CPU times reject instead of becoming plausible measurements.", "reviewed_line": 54}, {"line": 104, "title": "clears the heartbeat when initial CPU observation %s throws", "decision": "keep", "reason": "Every initial CPU-observation error row releases the fake-clock heartbeat after actual owner setup.", "reviewed_line": 104}, {"line": 132, "title": "preserves an invalid CPU diagnostic while releasing the heartbeat", "decision": "keep", "reason": "Invalid CPU diagnostic is retained while heartbeat resources are cleaned up.", "reviewed_line": 132}, {"line": 152, "title": "repeated failed owners leave no timers or later sends", "decision": "keep", "reason": "Repeated failed metric owners leave no timers or later heartbeat sends.", "reviewed_line": 152}, {"line": 215, "title": "keeps complete live results, observation order and heartbeat pacing", "decision": "keep", "reason": "Actual measurement sequence preserves observation order, complete results, summary units, and heartbeat pacing.", "reviewed_line": 215}, {"line": 233, "title": "keeps a sample sleep rejection and its existing cleanup", "decision": "keep", "reason": "Sample-sleep rejection survives actual cleanup without leaking heartbeat lifetime.", "reviewed_line": 233}, {"line": 240, "title": "keeps a final CPU observation failure after cleanup", "decision": "keep", "reason": "Final CPU-observation failure remains visible after heartbeat cleanup.", "reviewed_line": 240}, {"line": 247, "title": "keeps the zero floor when the CPU total decreases", "decision": "keep", "reason": "Decreasing CPU totals clamp actual reported usage to zero rather than negative values.", "reviewed_line": 247}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "b14017bb024307c1f0c368dc6efbf4056e5ff7f9c06c1779732b0ada9bd31add", "reviewer": "audit_config", "status": "reviewed", "decision": "keep", "classification": "test-suite", "rationale": "Keep 12 declarations/all parser/initial-observation rows. Tests parsing actual tool output shapes, CPU units/errors, fake-clock heartbeat/cleanup lifetime on initial/sleep/final read failures, repeated failed owners (64 iterations), real summary unit conversion/pacing and CPU zero floor. Mocks only process/perf boundaries; no real sleeps. Production `hang-watchdog-process-metrics.mjs`.", "evidence": ["config/scripts/hang-watchdog-process-metrics.mjs"], "original_declarations": 12, "reviewed_declarations": 12, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/happy-dom-mutation-observer-retention.test.ts", "sha256": "c7abb2f036f9dc2d8665c2fc5c4d1282e29f7af58d4166c1145860cdf777f991", "cases": [{"line": 25, "title": "pins the internal callback that happy-dom only holds weakly", "decision": "keep", "reason": "Actual happy-dom internal weak callback is strongly retained while observing and released on disconnect.", "reviewed_line": 25}, {"line": 42, "title": "keeps delivering records after the weak callback would have been collected", "decision": "fix", "reason": "Requires global.gc before setup and always performs real task turns/collection before asserting a second record delivery, matching Vitest --expose-gc.", "reviewed_line": 42}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "3301754ecaf60cd13354437e83bf91db633d13f7addb0609b830e9800fca9feb", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Require real exposed GC before the retained weak-callback lifetime and post-collection delivery regression; preserve actual callback pin/release checks.", "evidence": ["config/scripts/happy-dom-mutation-observer-retention.ts", "config/vitest.config.ts"], "original_declarations": 2, "reviewed_declarations": 2, "complete_body_and_tables_reviewed": true} +{"path": "config/scripts/happy-dom-offscreen-canvas.test.ts", "sha256": "c10adb495d7b9c50bd45effc275c6d1b77c92f0020b2f19734bbde0a8d761900", "cases": [{"line": 24, "title": "delegates adapter-less 2D contexts to the existing HTML canvas double", "decision": "fix", "reason": "Requires actual OffscreenCanvas and exercises its adapter-less 2D context delegation instead of substituting a missing-API branch.", "reviewed_line": 17}, {"line": 42, "title": "does not turn unsupported non-2D contexts into test doubles", "decision": "fix", "reason": "Requires actual OffscreenCanvas before checking WebGL null and no HTML fallback, removing the zero-assertion early return.", "reviewed_line": 31}, {"line": 54, "title": "keeps xterm DOM rendering open with the existing HTML canvas double", "decision": "keep", "reason": "Actual xterm Terminal.open with HTML canvas metrics proves the compatibility shim supports the real consumer.", "reviewed_line": 40}], "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", "reviewed_sha256": "0e3012dd17a430eb7061ccb1b90b43cad1bbe1aa773ed88c130c413a8b6adc78", "reviewer": "audit_config", "status": "reviewed", "decision": "fix", "classification": "test-suite", "rationale": "Require the actual OffscreenCanvas API before 2D delegation and WebGL nondelegation oracles; retain the real xterm open integration.", "evidence": ["config/scripts/happy-dom-offscreen-canvas.ts", "config/scripts/vitest-dom-setup.ts"], "original_declarations": 3, "reviewed_declarations": 3, "complete_body_and_tables_reviewed": true} diff --git a/docs/audits/test-value/reviews/mobile-0003-validation.json b/docs/audits/test-value/reviews/mobile-0003-validation.json new file mode 100644 index 00000000000..772fdc6b544 --- /dev/null +++ b/docs/audits/test-value/reviews/mobile-0003-validation.json @@ -0,0 +1,425 @@ +{ + "batch": "mobile-0003", + "reviewer": "audit_mobile", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "validation_worktree": "/home/neil/orca/workspaces/orca/comprehensive-test-audit-3", + "scope": { + "files_reviewed": 50, + "original_declarations_reviewed": 315, + "case_decisions": { + "keep": 279, + "remove": 17, + "fix": 11, + "consolidate": 8 + }, + "first_path": "mobile/src/components/keyed-bottom-drawer.test.tsx", + "last_path": "mobile/src/components/use-html-preview-link-grant.web.test.tsx", + "next_path": "mobile/src/components/use-new-workspace-execution-target.test.tsx" + }, + "changes": { + "modified_test_files": [ + "mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts", + "mobile/src/components/mobile-markdown-preview-placeholder.test.ts", + "mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx", + "mobile/src/components/new-workspace-reply-schema.test.ts", + "mobile/src/components/new-worktree-form-sheet-visibility.test.ts", + "mobile/src/components/pr-sidebar/markdown-blocks.test.ts", + "mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts", + "mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts", + "mobile/src/components/pr-state-token.test.ts", + "mobile/src/components/rich-markdown/document-lifecycle.test.ts", + "mobile/src/components/rich-markdown/editor-content.test.ts", + "mobile/src/components/rich-markdown/markdown-round-trip.test.ts", + "mobile/src/components/rich-markdown/page-stylesheet.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts", + "mobile/src/components/right-drawer-hardware-back.test.tsx", + "mobile/src/components/use-html-preview-link-grant.web.test.tsx" + ], + "removed_test_files": [ + "mobile/src/components/mobile-agent-icon-assets.test.ts", + "mobile/src/components/mobile-agent-icon-gradient.test.ts" + ], + "added_test_lines": 140, + "deleted_test_lines": 425, + "net_test_lines": -285, + "supporting_test_config_changes": [ + { + "path": "mobile/tests-typecheck-baseline.txt", + "change": "Remove only the stale src/components/mobile-agent-icon-gradient.test.ts grandfather entry after deleting its test file; authorized by the coordinating agent.", + "sha256": "b77d1c5a6409b09345aa82135382ae9b1b0c96c12591eba337781f08f65c9e0b", + "reviewed_sha256": "97153d7ba88d3607bb02f82684440ced08befe42d85e8295e306e1c1100f1120" + } + ], + "total_added_lines": 140, + "total_deleted_lines": 426, + "total_net_lines": -286, + "production_files_modified": [] + }, + "baseline": { + "result": "not-run", + "note": "No pre-edit baseline test run was performed for batch 0003. Saved original sources and hashes were preserved before editing. All 50 originals were checked byte-for-byte against the new checkout source commit; no upstream differences required reconciliation. Passing post-edit results are not represented as a baseline." + }, + "checks": [ + { + "id": "initial-targeted-repairs", + "working_directory": "mobile", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "test", + "src/components/mobile-webview-editor-web-fallbacks.test.tsx", + "src/components/mobile-diff-review-send-sheet-stacking.test.ts", + "src/components/pr-sidebar/pr-checks-presentation.test.ts", + "src/components/pr-sidebar/markdown-blocks.test.ts", + "src/components/rich-markdown/markdown-round-trip.test.ts", + "src/components/right-drawer-hardware-back.test.tsx" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-initial-validation.log", + "test_files": 6, + "tests": 61 + }, + { + "id": "retained-batch-final", + "working_directory": "mobile", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "test", + "src/components/keyed-bottom-drawer.test.tsx", + "src/components/markdown-file-path-detection.test.ts", + "src/components/markdown-href-routing.test.ts", + "src/components/markdown-inline-matcher.test.ts", + "src/components/mobile-diff-review-send-sheet-stacking.test.ts", + "src/components/mobile-markdown-android-selection.test.tsx", + "src/components/mobile-markdown-mermaid-routing.test.ts", + "src/components/mobile-markdown-preview-placeholder.test.ts", + "src/components/mobile-markdown-selectable.test.tsx", + "src/components/mobile-markdown-table.test.tsx", + "src/components/mobile-markdown-visual-lines.test.ts", + "src/components/mobile-pr-sidebar-presentation.test.ts", + "src/components/mobile-rich-markdown-editor-keyboard-inset.test.ts", + "src/components/mobile-webview-editor-web-fallbacks.test.tsx", + "src/components/mounted-bottom-drawer-keyboard-seam.test.tsx", + "src/components/mounted-bottom-drawer-page-keyboard.web.test.tsx", + "src/components/new-workspace-project-targets.test.ts", + "src/components/new-workspace-reply-schema.test.ts", + "src/components/new-worktree-agent-selection.test.ts", + "src/components/new-worktree-form-sheet-visibility.test.ts", + "src/components/pr-sidebar/PRCommentsSection.test.ts", + "src/components/pr-sidebar/PRConflictingFilesSection.test.ts", + "src/components/pr-sidebar/markdown-blocks.test.ts", + "src/components/pr-sidebar/markdown-link-scheme.test.ts", + "src/components/pr-sidebar/markdown-table-delimiter-performance.test.ts", + "src/components/pr-sidebar/markdown-tag-stripping-performance.test.ts", + "src/components/pr-sidebar/pr-actions-state.test.ts", + "src/components/pr-sidebar/pr-check-detail-content.test.ts", + "src/components/pr-sidebar/pr-checks-presentation.test.ts", + "src/components/pr-sidebar/pr-comment-card-web-avatar.test.tsx", + "src/components/pr-sidebar/pr-conflict-presentation.test.ts", + "src/components/pr-state-token.test.ts", + "src/components/rich-markdown/document-host-root.test.ts", + "src/components/rich-markdown/document-lifecycle.test.ts", + "src/components/rich-markdown/editor-content.test.ts", + "src/components/rich-markdown/editor-selection.test.ts", + "src/components/rich-markdown/markdown-code-fence-allocation.test.ts", + "src/components/rich-markdown/markdown-round-trip.test.ts", + "src/components/rich-markdown/page-stylesheet.test.ts", + "src/components/rich-markdown/rich-markdown-document-parse-time.test.ts", + "src/components/rich-markdown/rich-markdown-host-seams.test.ts", + "src/components/rich-markdown/rich-markdown-web-document-mount.test.ts", + "src/components/right-drawer-hardware-back.test.tsx", + "src/components/right-drawer-panel-width.test.ts", + "src/components/terminal-shortcut-settings-custom-keys.test.tsx", + "src/components/use-bottom-drawer-follow-up.test.tsx", + "src/components/use-connected-host-picker.test.ts", + "src/components/use-html-preview-link-grant.web.test.tsx" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-final-validation.log", + "test_files": 48, + "tests": 310, + "note": "After this full batch run, the only test changes were a void act callback block and removal of an unused import; both affected suites passed the final-cleanup run." + }, + { + "id": "existing-consolidation-coverage", + "working_directory": "mobile", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "test", + "src/components/html-preview-link-affordance.test.tsx", + "src/components/MobileRichMarkdownToolbar.test.tsx", + "src/components/use-new-worktree-drawer-navigation.test.ts", + "src/style-scoping/document-style-scoping.test.ts" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-existing-coverage.log", + "test_files": 4, + "tests": 12 + }, + { + "id": "final-cleanup-tests", + "working_directory": "mobile", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "test", + "src/components/mobile-webview-editor-web-fallbacks.test.tsx", + "src/components/use-html-preview-link-grant.web.test.tsx" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-final-cleanup-tests.log", + "test_files": 2, + "tests": 9 + }, + { + "id": "mobile-tests-typecheck", + "working_directory": "mobile", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": ["pnpm", "run", "check:tests-typecheck"], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-typecheck-final.log", + "test_files_in_program": 1110, + "grandfathered_files": 115, + "intentionally_excluded_files": 5 + }, + { + "id": "changed-test-lint", + "working_directory": ".", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "exec", + "oxlint", + "mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts", + "mobile/src/components/mobile-markdown-preview-placeholder.test.ts", + "mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx", + "mobile/src/components/new-workspace-reply-schema.test.ts", + "mobile/src/components/new-worktree-form-sheet-visibility.test.ts", + "mobile/src/components/pr-sidebar/markdown-blocks.test.ts", + "mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts", + "mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts", + "mobile/src/components/pr-state-token.test.ts", + "mobile/src/components/rich-markdown/document-lifecycle.test.ts", + "mobile/src/components/rich-markdown/editor-content.test.ts", + "mobile/src/components/rich-markdown/markdown-round-trip.test.ts", + "mobile/src/components/rich-markdown/page-stylesheet.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts", + "mobile/src/components/right-drawer-hardware-back.test.tsx", + "mobile/src/components/use-html-preview-link-grant.web.test.tsx" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-lint-final.log" + }, + { + "id": "changed-test-format", + "working_directory": ".", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "exec", + "oxfmt", + "--check", + "mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts", + "mobile/src/components/mobile-markdown-preview-placeholder.test.ts", + "mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx", + "mobile/src/components/new-workspace-reply-schema.test.ts", + "mobile/src/components/new-worktree-form-sheet-visibility.test.ts", + "mobile/src/components/pr-sidebar/markdown-blocks.test.ts", + "mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts", + "mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts", + "mobile/src/components/pr-state-token.test.ts", + "mobile/src/components/rich-markdown/document-lifecycle.test.ts", + "mobile/src/components/rich-markdown/editor-content.test.ts", + "mobile/src/components/rich-markdown/markdown-round-trip.test.ts", + "mobile/src/components/rich-markdown/page-stylesheet.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts", + "mobile/src/components/right-drawer-hardware-back.test.tsx", + "mobile/src/components/use-html-preview-link-grant.web.test.tsx", + "mobile/tests-typecheck-baseline.txt" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-format-final.log", + "note": "oxfmt matched the 18 surviving modified test files; the baseline text file has no supported formatter." + }, + { + "id": "changed-code-quality", + "working_directory": ".", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "run", + "check:code-quality:changed", + "--", + "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-code-quality-changed-final.log", + "note": "Checks the combined worktree diff; all categories reported zero new findings across 22 analyzed files." + }, + { + "id": "changed-react-doctor", + "working_directory": ".", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "run", + "check:react-doctor:changed", + "--", + "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-react-doctor-changed-final.log", + "note": "Checks the combined worktree diff; zero errors." + }, + { + "id": "diff-whitespace", + "working_directory": ".", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "git", + "diff", + "--check", + "--", + "mobile", + "docs/audits/test-value/reviews/mobile-0003.jsonl", + "docs/audits/test-value/reviews/mobile-0003-validation.json" + ], + "result": "passed", + "exit_code": 0, + "log": "/tmp/orca-mobile-0003-diff-check-final.log" + } + ], + "preliminary_checks_resolved": [ + { + "id": "initial-changed-test-lint", + "working_directory": ".", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "exec", + "oxlint", + "mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts", + "mobile/src/components/mobile-markdown-preview-placeholder.test.ts", + "mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx", + "mobile/src/components/new-workspace-reply-schema.test.ts", + "mobile/src/components/new-worktree-form-sheet-visibility.test.ts", + "mobile/src/components/pr-sidebar/markdown-blocks.test.ts", + "mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts", + "mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts", + "mobile/src/components/pr-state-token.test.ts", + "mobile/src/components/rich-markdown/document-lifecycle.test.ts", + "mobile/src/components/rich-markdown/editor-content.test.ts", + "mobile/src/components/rich-markdown/markdown-round-trip.test.ts", + "mobile/src/components/rich-markdown/page-stylesheet.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts", + "mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts", + "mobile/src/components/right-drawer-hardware-back.test.tsx", + "mobile/src/components/use-html-preview-link-grant.web.test.tsx" + ], + "result": "failed", + "log": "/tmp/orca-mobile-0003-lint.log", + "issue": "Removing the native constant-return grant case left an unused native hook import.", + "resolution": "Removed the import; final targeted oxlint passed." + }, + { + "id": "initial-mobile-tests-typecheck", + "working_directory": "mobile", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": ["pnpm", "run", "check:tests-typecheck"], + "result": "failed", + "log": "/tmp/orca-mobile-0003-typecheck.log", + "issues": [ + "The fallback test act callback returned dispatchEvent boolean instead of void.", + "The deleted gradient test remained in the grandfather baseline." + ], + "resolution": "Used a void callback block and pruned exactly that baseline entry; final ratchet passed." + }, + { + "id": "diagnostic-mobile-test-compiler", + "working_directory": "mobile", + "environment": { + "ORCA_BACKGROUND_LAUNCH": "1" + }, + "command": [ + "pnpm", + "exec", + "tsc", + "--noEmit", + "-p", + "tsconfig.test.json", + "--pretty", + "false" + ], + "result": "failed", + "exit_code": 2, + "log": "/tmp/orca-mobile-0003-tsc-errors.log", + "note": "Diagnostic run exposed the act callback error plus existing grandfathered diagnostics. The ratchet is the repository gate; final ratchet passed after the callback fix and baseline shrink." + } + ], + "review_evidence": { + "source_snapshot": "Every original sha256 matches git show at source_commit. Every original declaration location/title matches the preserved extraction, including table declarations and removed cases.", + "final_content": "Every retained file reviewed_sha256 matches final formatted contents; deleted files use null. Unchanged retained files have equal original/final hashes.", + "implementation_review": "Read all 50 actual test files and relevant production implementations. Preserved independent parser oracles, hostile-input VM deadlines, actual callback/bridge/DOM behavior, asynchronous stale-answer guards and positive/negative AST ownership controls.", + "consolidation_coverage": [ + "mobile/src/components/html-preview-link-affordance.test.tsx", + "mobile/src/components/MobileRichMarkdownToolbar.test.tsx", + "mobile/src/components/use-new-worktree-drawer-navigation.test.ts", + "mobile/src/style-scoping/document-style-scoping.test.ts" + ], + "mutation_checks": "None. The repaired discard fixture presents src/a.ts, moves the controller selection to src/b.ts and verifies the real RPC still targets src/a.ts; it directly distinguishes presented target ownership from current selection.", + "scope_guard": "Only the owned mobile test files, one stale test-typecheck baseline entry and these two review records changed for this batch. No production changes, commits, branch changes or inventory refresh were performed by this reviewer." + }, + "production_findings": [ + { + "finding": "Dormant editor timer plumbing is speculative: inputTimer initializes to null and is only reset to null; production never schedules a pending edit timer. The removed lifecycle case planted that state itself.", + "evidence": [ + "mobile/src/components/rich-markdown/document-scope.ts", + "mobile/src/components/rich-markdown/editor-content.ts", + "mobile/src/components/rich-markdown/create-rich-markdown-editor-document.ts" + ], + "action": "Finding only. Production timer fields, seams and cleanup remain untouched per the coordinating agent scope." + } + ] +} diff --git a/docs/audits/test-value/reviews/mobile-0003.jsonl b/docs/audits/test-value/reviews/mobile-0003.jsonl new file mode 100644 index 00000000000..d56cec78bc1 --- /dev/null +++ b/docs/audits/test-value/reviews/mobile-0003.jsonl @@ -0,0 +1,50 @@ +{"path":"mobile/src/components/keyed-bottom-drawer.test.tsx","sha256":"e7821bcd5eb8b63642877ded940a6d559eeeecf81dd4fbac42bfaf6e4fcfcaeb","reviewed_sha256":"e7821bcd5eb8b63642877ded940a6d559eeeecf81dd4fbac42bfaf6e4fcfcaeb","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep actual component commit/lifecycle observations, including stale callbacks and generated action sequences.","evidence":["mobile/src/components/keyed-bottom-drawer.tsx","mobile/src/components/BottomDrawer.tsx"],"cases":[{"line":143,"title":"presents a request at once when nothing is presented","decision":"keep","reason":"A first request mounts its sheet in the requesting commit without an empty frame."},{"line":150,"title":"hides the presented sheet and shows the next only after its Modal has unmounted","decision":"keep","reason":"Replacing a sheet waits for the old native Modal to unmount before mounting the next."},{"line":166,"title":"presents the latest request after a close, never one replaced before it was shown","decision":"keep","reason":"Requests superseded during closing cannot become transient native presentations."},{"line":175,"title":"a request cleared before the close finishes presents nothing afterwards","decision":"keep","reason":"Clearing a pending request leaves no later presentation after closing completes."},{"line":184,"title":"reopening the same sheet mid-close re-shows the same Modal with the new content","decision":"keep","reason":"A same-key reopen refreshes content in the original Modal instead of overlapping another."},{"line":195,"title":"switching away and back to the presented sheet mid-close re-shows it","decision":"keep","reason":"Switching back while closing revives the presented Modal safely."},{"line":207,"title":"ignores a hide that lands after a reopen and still honours the next close","decision":"keep","reason":"An obsolete hide completion cannot remove a reopened sheet or disable its next close."},{"line":222,"title":"a hide from an earlier Modal cannot close a later one","decision":"keep","reason":"A prior Modal epoch cannot hide a later presentation."},{"line":235,"title":"reports the close with the sheet that was presented","decision":"keep","reason":"Closing identifies the presented sheet instead of a newer pending request."},{"line":244,"title":"keeps one Modal, never swaps its sheet, and always settles on the latest request","decision":"keep","reason":"The seeded sequence drives real React commits and asserts independent one-Modal, stable-sheet and final-request invariants."}]} +{"path":"mobile/src/components/markdown-file-path-detection.test.ts","sha256":"3ce8a2db739360e56499854235063b946a22fbedaee29c96ecdb7b86d26f9fa4","reviewed_sha256":"3ce8a2db739360e56499854235063b946a22fbedaee29c96ecdb7b86d26f9fa4","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep independently specified platform, citation, false-positive and bounded-input behavior.","evidence":["mobile/src/components/markdown-file-path-detection.ts","mobile/src/components/mobile-markdown-inline.tsx"],"cases":[{"line":10,"title":"returns a single text segment when there is no path","decision":"keep","reason":"Path-free prose stays one unchanged text segment."},{"line":16,"title":"detects a relative source path with surrounding prose","decision":"keep","reason":"Embedded source paths split prose and carry an independently expected file destination."},{"line":25,"title":"strips a leading ./ in the path but keeps the displayed value","decision":"keep","reason":"Displayed ./ source text is preserved while its opener path is normalized."},{"line":33,"title":"keeps ../ parent-relative paths intact","decision":"keep","reason":"Parent-relative navigation remains semantically intact."},{"line":40,"title":"detects multiple paths in one run","decision":"keep","reason":"Multiple matches preserve text order and distinct destinations."},{"line":48,"title":"detects Windows relative, drive, and UNC paths","decision":"keep","reason":"Windows relative, drive and UNC source paths remain tappable on a phone."},{"line":68,"title":"detects POSIX absolute paths","decision":"keep","reason":"POSIX absolute paths preserve roots and surrounding prose."},{"line":82,"title":"detects files directly under explicit Windows and relative roots","decision":"keep","reason":"Root-level Windows and explicitly relative paths need not contain another directory."},{"line":94,"title":"detects paths with :line and :line:col suffixes","decision":"keep","reason":"Numeric line/column citations stay attached to detected destinations."},{"line":110,"title":"keeps a non-line colon tail out of the match","decision":"keep","reason":"A nonnumeric colon suffix stays outside the detected filename."},{"line":118,"title":"does not partially parse numeric-looking non-line tails","decision":"keep","reason":"Malformed numeric-looking suffixes cannot become partial navigable locations."},{"line":131,"title":"does not match bare filenames without a slash","decision":"keep","reason":"A bare prose filename is too ambiguous to create a file affordance."},{"line":137,"title":"does not match URLs","decision":"keep","reason":"Web URL fragments cannot accidentally create file-open affordances."},{"line":146,"title":"does not match protocol-relative URLs","decision":"keep","reason":"Protocol-relative web URLs stay outside file detection."},{"line":152,"title":"does not match version numbers","decision":"keep","reason":"Version-number prose remains literal."},{"line":158,"title":"does not match unknown extensions","decision":"keep","reason":"Unknown extensions do not gain misleading file controls."},{"line":164,"title":"detects scoped-package file paths with a segment-leading @","decision":"keep","reason":"Scoped package names permit an @ only at a path-segment boundary."},{"line":185,"title":"does not match emails or git URLs with a mid-token @","decision":"keep","reason":"Emails and git transport identities cannot be mistaken for files."},{"line":194,"title":"returns a single text segment when the run has no dot","decision":"keep","reason":"Dot-free long text takes the nonmatch path without changing its bytes."},{"line":199,"title":"skips detection for runs over the length cap even with dots","decision":"keep","reason":"Over-cap input stays literal even when it contains candidate dots."},{"line":206,"title":"still detects a path in a long-but-under-cap run","decision":"keep","reason":"An under-cap long run still exposes its real path."},{"line":216,"title":"accepts a slashed path code span","decision":"keep","reason":"A whole path code span is eligible for file navigation."},{"line":220,"title":"accepts Windows paths in code spans","decision":"keep","reason":"Windows path variants remain eligible inside code spans."},{"line":226,"title":"accepts a bare filename code span","decision":"keep","reason":"Code spans provide enough context to accept a bare known filename."},{"line":230,"title":"rejects multi-word code spans","decision":"keep","reason":"A multiword command cannot become a file action."},{"line":234,"title":"rejects non-file code spans","decision":"keep","reason":"Variable names without file structure remain code."},{"line":238,"title":"rejects urls in code spans","decision":"keep","reason":"URL-shaped code spans cannot enter the file-opening branch."},{"line":242,"title":"accepts scoped-package paths with a segment-leading @","decision":"keep","reason":"Scoped-package code paths retain their valid segment-leading @."},{"line":247,"title":"accepts POSIX absolute paths and :line citations","decision":"keep","reason":"Absolute and cited code paths retain their location contract across POSIX and Windows."},{"line":255,"title":"rejects emails and git URLs with a mid-token @","decision":"keep","reason":"Email/git identity code spans are excluded."},{"line":262,"title":"splits :line and :line:col suffixes","decision":"keep","reason":"The mobile adapter returns independent path/line/column field names for both suffix forms."},{"line":275,"title":"keeps Windows drive colons intact","decision":"keep","reason":"The adapter preserves Windows drive syntax while extracting only a trailing citation."},{"line":288,"title":"ignores non-numeric and zero suffixes","decision":"keep","reason":"Failed zero-location parsing returns the original source text instead of a truncated path."},{"line":303,"title":"strips a leading ./","decision":"keep","reason":"Both slash forms remove only the current-directory prefix."},{"line":308,"title":"leaves other paths unchanged","decision":"keep","reason":"Parent-directory and already normalized paths remain unchanged."}]} +{"path":"mobile/src/components/markdown-href-routing.test.ts","sha256":"91ddafa7b6de7adff114b0ee62b95a127af87864d90869f66406f3cb4da6eea5","reviewed_sha256":"91ddafa7b6de7adff114b0ee62b95a127af87864d90869f66406f3cb4da6eea5","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep the mobile adapter destinations, including its suffix and wrapped-location compatibility.","evidence":["mobile/src/components/markdown-href-routing.ts","src/shared/native-chat-href-routing.ts"],"cases":[{"line":6,"title":"routes web and mail links to the system handler","decision":"keep","reason":"Web and mail hrefs remain system-handler destinations."},{"line":21,"title":"carries a #L fragment as a :line suffix","decision":"keep","reason":"Mobile file routing converts parsed hash-line fragments to its existing colon-location argument."},{"line":36,"title":"preserves the existing wrapped reply-location contract","decision":"keep","reason":"Wrapped renderer locations remain literal rather than being parsed a second time."},{"line":43,"title":"routes file: URIs to the file opener","decision":"keep","reason":"File URIs decode independently expected POSIX and Windows destinations."},{"line":58,"title":"drops anchors, unknown schemes, and empty hrefs","decision":"keep","reason":"Anchors, unsupported schemes and empty hrefs cannot produce navigation."}]} +{"path":"mobile/src/components/markdown-inline-matcher.test.ts","sha256":"a2baa277499d2134b0885cabe21fab57811d4588f5c45042ecc55e21fdc74f59","reviewed_sha256":"a2baa277499d2134b0885cabe21fab57811d4588f5c45042ecc55e21fdc74f59","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep differential compatibility and bounded parser regressions; the old regex is an independent implementation.","evidence":["mobile/src/components/markdown-inline-matcher.ts","mobile/src/components/pr-sidebar/markdown-blocks.ts"],"cases":[{"line":32,"title":"preserves original token order","decision":"keep","reason":"Generated token streams compare offsets/order against the prior regex rather than copying the new scanner."},{"line":69,"title":"keeps $name literal within the parser deadline","decision":"keep","reason":"Hostile unmatched link labels/destinations execute the real parser under an interruptible deadline and stay literal."},{"line":77,"title":"does not repeatedly search the suffix for absent non-link tokens","decision":"keep","reason":"Ten thousand real links require only one exhausted nonlink scan, with the token count as a positive control."}]} +{"path":"mobile/src/components/mobile-agent-icon-assets.test.ts","sha256":"d9e53f844ce508d4c2954fece2a086b1be78a5d349b702c7210828b664da8c15","reviewed_sha256":null,"source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"remove","rationale":"Remove copied inventory that never imports the component asset map.","evidence":["mobile/src/components/mobile-agent-icon-assets.ts","mobile/src/components/MobileAgentIcon.tsx","mobile/src/tasks/mobile-tui-agents.ts"],"cases":[{"line":29,"title":"ships a bundled PNG on disk for every favicon-path agent","decision":"remove","reason":"Copies glyph IDs and checks derived PNG paths, so a missing/wrong real asset mapping or network fallback still passes; Metro validates literal required files during bundling."}]} +{"path":"mobile/src/components/mobile-agent-icon-gradient.test.ts","sha256":"8ebced6d92fcdaebdead9268a61ee3e139c04ddaca7c513767fe9af321c30343","reviewed_sha256":null,"source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"remove","rationale":"Remove decorative prop pin through fake SVG tags.","evidence":["mobile/src/components/MobileAgentIcon.tsx"],"cases":[{"line":44,"title":"uses valid SVG gradient stop offsets","decision":"remove","reason":"Mocks SVG validation away and compares three offsets copied from the component; it proves neither valid native SVG rendering nor visible gradient behavior."}]} +{"path":"mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts","sha256":"bd6bef6d0643fd2b837fd73437bc7a674c66f9a6231e11e28be2764439a208db","reviewed_sha256":"e38247e14c4b2df44a269b621e45a4e225436e3e949b264208f81824286cf239","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Keep lifecycle flows and repair the file-identity assertion.","evidence":["mobile/src/components/MobileDiffReviewDrawers.tsx","mobile/src/session/use-mobile-diff-review-controller.ts","mobile/src/components/keyed-bottom-drawer.tsx","mobile/src/session/mobile-diff-review-sheets.ts"],"cases":[{"line":217,"title":"Send Unsent Notes shows Send Notes only after Review Actions has closed","decision":"keep","reason":"The real actions-to-send flow waits for the source native sheet to close."},{"line":233,"title":"Review Complete → Send shows Send Notes only after Review Complete has closed","decision":"keep","reason":"Completion-to-send retains the one-Modal close gap."},{"line":245,"title":"does not open Send Notes when Review Complete closes for another reason","decision":"keep","reason":"Ordinary completion dismissal does not fabricate a send request."},{"line":255,"title":"Review Complete arriving while another sheet is open waits for that sheet to close","decision":"keep","reason":"An arriving completion result waits behind the sheet already on screen."},{"line":271,"title":"a sheet replaced before it was ever shown is never mounted","decision":"keep","reason":"A superseded pending sheet is never mounted."},{"line":288,"title":"a send list that lands after Send Notes was dismissed does not bring it back","decision":"keep","reason":"A late send-list result cannot reopen a dismissed send sheet."},{"line":302,"title":"Discard keeps its file through the close and discards the file it showed","decision":"fix","reason":"The recorder currently retains only RPC method names, so the wrong file passes. Record exact request arguments and assert the presented file/worktree destination."}]} +{"path":"mobile/src/components/mobile-markdown-android-selection.test.tsx","sha256":"48f6392ee0e227d7522277b7a54bed1fb5c2040c07a3d41b41f647247b38bf37","reviewed_sha256":"48f6392ee0e227d7522277b7a54bed1fb5c2040c07a3d41b41f647247b38bf37","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep real Android transcript selection and interactive long-press routing.","evidence":["mobile/src/components/MobileMarkdown.tsx","mobile/src/components/mobile-markdown-text.tsx","mobile/src/components/mobile-markdown-blocks.tsx"],"cases":[{"line":52,"title":"renders the transcript with no selectable span, leaving untouched spans alone","decision":"keep","reason":"Android transcript blocks disable selection without forcing nested-span flags that alter inheritance."},{"line":65,"title":"routes a long press on a tappable span or image to the row, so neither swallows it","decision":"keep","reason":"Rendered links and image controls forward their long press to the message action."},{"line":84,"title":"keeps other surfaces (task comments, previews) selectable as before","decision":"keep","reason":"Other Markdown surfaces preserve native selectable behavior."}]} +{"path":"mobile/src/components/mobile-markdown-mermaid-routing.test.ts","sha256":"44179b3ff3c53a7edf75ef1606f3a02a257c2843b2ac4e46f3515e7174278fde","reviewed_sha256":"44179b3ff3c53a7edf75ef1606f3a02a257c2843b2ac4e46f3515e7174278fde","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep real diagram component identity and streaming transitions.","evidence":["mobile/src/components/mobile-markdown-blocks.tsx","mobile/src/components/mobile-markdown-tree.ts"],"cases":[{"line":41,"title":"routes a closed mermaid fence to MermaidDiagram","decision":"keep","reason":"A complete mermaid fence reaches the diagram component."},{"line":46,"title":"keeps a streaming (unterminated) mermaid fence as raw code","decision":"keep","reason":"An unterminated fence remains code while streaming."},{"line":51,"title":"keeps identical sibling diagrams uniquely keyed","decision":"keep","reason":"Identical sibling diagrams render twice without colliding React keys."},{"line":60,"title":"preserves a completed diagram while later prose streams","decision":"keep","reason":"Appending prose preserves the completed diagram instance."},{"line":68,"title":"remounts a diagram when its source changes","decision":"keep","reason":"A changed diagram source remounts its renderer rather than retaining stale content."},{"line":77,"title":"does not route other code fences to MermaidDiagram","decision":"keep","reason":"Other fenced languages stay in the code branch."}]} +{"path":"mobile/src/components/mobile-markdown-preview-placeholder.test.ts","sha256":"c433ccf994fb3a0265d74fc17c55c57836f30070bc5f7abb3195b175b84c986e","reviewed_sha256":"5edfbc066a772b09fe02c5aab4010686106eeea39b57bd5e622dc23a5b973c26","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep boundary/collision examples; remove repetitive generated permutations.","evidence":["mobile/src/components/mobile-markdown-preview-html.ts"],"cases":[{"line":8,"title":"preserves a literal marker with %i underscores","decision":"keep","reason":"Independent lengths from zero through 16384 preserve authored markers together with inline and fenced code."},{"line":14,"title":"handles adjacent markers and repeated maximum suffixes","decision":"keep","reason":"Adjacent markers and repeated maxima expose the global-prefix selection boundary during HTML cleanup."},{"line":21,"title":"preserves authored markers across generated suffix orders and HTML islands","decision":"remove","reason":"Five hundred generated eight-marker orderings repeat collision/order/HTML-island properties already established by the explicit max, adjacency and code fixtures."}]} +{"path":"mobile/src/components/mobile-markdown-selectable.test.tsx","sha256":"5ddbbe0c391aa7b60d54d69347568a6429abb57247171a95a94751bc630eb85a","reviewed_sha256":"5ddbbe0c391aa7b60d54d69347568a6429abb57247171a95a94751bc630eb85a","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep selectable rendered blocks and nested-span inheritance.","evidence":["mobile/src/components/MobileMarkdown.tsx","mobile/src/components/mobile-markdown-text.tsx","mobile/src/components/mobile-markdown-blocks.tsx"],"cases":[{"line":70,"title":"makes %s prose selectable","decision":"keep","reason":"Table-driven prose/block variants render as selectable real native text."},{"line":99,"title":"makes the empty-content fallback selectable","decision":"keep","reason":"Empty content still supplies a selectable fallback block."},{"line":104,"title":"keeps inline spans inside their selectable block rather than splitting it","decision":"keep","reason":"Inline spans inherit the outer block selection rather than splitting ranges."}]} +{"path":"mobile/src/components/mobile-markdown-table.test.tsx","sha256":"722fe0ea49d167b647d79354fec3a97282fd736acf98f6cd45e82f770b6c52ea","reviewed_sha256":"722fe0ea49d167b647d79354fec3a97282fd736acf98f6cd45e82f770b6c52ea","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep externally meaningful table dimensions and content-based width choices.","evidence":["mobile/src/components/mobile-markdown-blocks.tsx","mobile/src/components/mobile-markdown-table-columns.ts"],"cases":[{"line":49,"title":"renders every row and column with one width per column","decision":"keep","reason":"The actual 51-by-10 rendered table retains every cell and aligns each column, with a wider independent long cell."},{"line":64,"title":"sizes a column by the text it draws, not its markdown source","decision":"keep","reason":"Displayed link text, rather than URL source length, determines width and wide CJK text occupies more space."}]} +{"path":"mobile/src/components/mobile-markdown-visual-lines.test.ts","sha256":"258d48357045d42db0decb7a3beca0528a55660539cc09c0cc7b3876799f3551","reviewed_sha256":"258d48357045d42db0decb7a3beca0528a55660539cc09c0cc7b3876799f3551","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep parser composition with independent expected directives and block boundaries.","evidence":["mobile/src/components/mobile-markdown-visual-lines.ts","mobile/src/components/use-mobile-markdown-tree.ts","mobile/src/components/mobile-markdown-blocks.tsx"],"cases":[{"line":32,"title":"turns a directive line into its own block between prose","decision":"keep","reason":"A directive splits surrounding prose into an independent visual block."},{"line":44,"title":"keeps the title exactly as written, before entity decoding and tag stripping","decision":"keep","reason":"Authored title bytes survive entity/tag cleanup unchanged."},{"line":49,"title":"accepts CRLF line endings and up to three leading spaces","decision":"keep","reason":"CRLF and allowed indentation retain a standalone visual boundary."},{"line":54,"title":"leaves directives inside fenced code, quotes, list items and inline code as text","decision":"keep","reason":"Code, blockquote, list and inline-code contexts cannot activate embedded directives."},{"line":66,"title":"resumes recognizing directives after a fence closes","decision":"keep","reason":"Closed fences permit subsequent real directives."},{"line":71,"title":"leaves malformed or path-like directives as literal text","decision":"keep","reason":"Malformed/unsafe/path-like directives remain literal text."},{"line":85,"title":"renders directives past the per-message cap as text","decision":"keep","reason":"Past the admitted message cap, extra directives render as text rather than disappearing."},{"line":95,"title":"renders no visuals for text that already spells a placeholder","decision":"keep","reason":"Authored placeholder syntax disables visual interpretation to prevent aliasing."},{"line":100,"title":"never treats a placeholder-looking line as a visual when none were protected","decision":"keep","reason":"An unprotected placeholder cannot fabricate a directive index."}]} +{"path":"mobile/src/components/mobile-pr-sidebar-presentation.test.ts","sha256":"eb638cc6ddbfe0ef151ccb416ab9c0f5a08026429eb70e3b853f6421e071dc26","reviewed_sha256":"eb638cc6ddbfe0ef151ccb416ab9c0f5a08026429eb70e3b853f6421e071dc26","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep responsive placement and measured pane-fit boundaries.","evidence":["mobile/src/components/mobile-pr-sidebar-presentation.ts"],"cases":[{"line":9,"title":"docks inline on wide layouts and overlays on narrow","decision":"keep","reason":"Wide/narrow presentation chooses the expected dock or overlay."},{"line":14,"title":"overlays on wide layouts when the measured pane cannot fit both columns","decision":"keep","reason":"Wide screens fall back to overlay when their measured pane cannot fit both columns."},{"line":20,"title":"requires both wide layout and enough measured width","decision":"keep","reason":"The exact usable-main-column boundary distinguishes 700 from 699 pixels and still requires wide layout."},{"line":32,"title":"shows the trigger on a GitHub repo in narrow/overlay mode","decision":"keep","reason":"A narrow GitHub repository exposes its sidebar entry point."},{"line":36,"title":"hides the trigger in wide/docked mode even on a GitHub repo","decision":"keep","reason":"A docked sidebar suppresses the redundant overlay control."},{"line":40,"title":"shows the trigger on a wide GitHub repo when the sidebar cannot dock","decision":"keep","reason":"A wide but undockable GitHub pane retains its overlay entry point."},{"line":44,"title":"hides the trigger on a non-GitHub repo regardless of layout","decision":"keep","reason":"Non-GitHub repositories do not advertise the GitHub sidebar."}]} +{"path":"mobile/src/components/mobile-rich-markdown-editor-keyboard-inset.test.ts","sha256":"02bb35a7b63b2d0c143d4f02292fe07ebdb5ceea8727117079467ed236f2f823","reviewed_sha256":"02bb35a7b63b2d0c143d4f02292fe07ebdb5ceea8727117079467ed236f2f823","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep measurement normalization at the actual controller boundary.","evidence":["mobile/src/components/mobile-rich-markdown-editor-keyboard-inset.ts","mobile/src/components/use-mobile-rich-markdown-editor-controller.ts"],"cases":[{"line":5,"title":"rounds finite inset measurements for native layout","decision":"keep","reason":"A fractional document measurement rounds to a native layout pixel."},{"line":9,"title":"clamps negative inset measurements to zero","decision":"keep","reason":"Negative covered space cannot lower the editor bar below zero."},{"line":13,"title":"rejects non-finite inset measurements","decision":"keep","reason":"NaN and infinity are invalid measurements, so the controller can preserve its prior inset."}]} +{"path":"mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx","sha256":"2801742877053503a3ab9c07b425df5c211e4058da9f35dbee58d84a06bf0289","reviewed_sha256":"e7ef3bc3067e36d9c59fedc9e071a3f23f4a724b0060581fb477130b80bec367","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Repair the editor mount; retain sandbox, accessibility selection and artifact confinement.","evidence":["mobile/src/components/MobileRichMarkdownEditor.tsx","mobile/src/components/MobileHtmlPreview.tsx","mobile/src/components/rich-markdown/rich-markdown-web-document-mount.ts","mobile/src/components/html-preview-link-affordance.test.tsx","mobile/src/components/MobileRichMarkdownToolbar.test.tsx","mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts","mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts"],"cases":[{"line":108,"title":"renders no plain field, because the document it degraded to is gone","decision":"fix","reason":"An absent TextInput also passes for a missing editor. Mount the actual DOM document and prove initial content, editability and edit callbacks."},{"line":121,"title":"renders the fifteen-command toolbar the phone renders","decision":"consolidate","reason":"The fifteen-label inventory duplicates the toolbar suite; retain command enablement integration in the read-only/editable transition case."},{"line":135,"title":"disables every command against a document that cannot be edited","decision":"fix","reason":"Drop the literal button count; assert a nonempty toolbar disables all commands alongside the real read-only document, then enables them after an editable update."},{"line":148,"title":"keeps the URL modal mounted and closed until a command asks for one","decision":"remove","reason":"A permanently closed mocked modal proves no command/prompt behavior; real browser URL flows and host-seam tests exercise opening and delivery."},{"line":164,"title":"never calls onKeyboardInsetChange, because the screen measures the same viewport","decision":"remove","reason":"A mount-only negative never drives a keyboard change. The document-mount and host-seam suites exercise the no-source decision and viewport events."},{"line":181,"title":"renders the artifact in a frame that can run nothing, and keeps the toggle","decision":"keep","reason":"The actual frame receives artifact bytes and a sandbox explicitly excluding script and same-origin permissions."},{"line":197,"title":"shows the source when the toggle is flipped, and takes the frame away with it","decision":"consolidate","reason":"Source activation and iframe removal are already covered for both negotiated grant answers by html-preview-link-affordance.test.tsx."},{"line":214,"title":"says which side of the toggle is showing","decision":"keep","reason":"Tab roles, group ownership and selected accessibility state follow the actual source-toggle action."},{"line":233,"title":"never puts the artifact anywhere but the frame","decision":"keep","reason":"The artifact appears only as iframe srcDoc and cannot leak into outer children or dangerouslySetInnerHTML."}]} +{"path":"mobile/src/components/mounted-bottom-drawer-keyboard-seam.test.tsx","sha256":"3b5385ad8c656a6e1cef499a0ae3253eb1c14dd4b0322d74e6fe06f3aaab1665","reviewed_sha256":"3b5385ad8c656a6e1cef499a0ae3253eb1c14dd4b0322d74e6fe06f3aaab1665","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep real keyboard event subscription, geometry and cleanup.","evidence":["mobile/src/components/mounted-bottom-drawer.tsx","mobile/src/platform/keyboard-occlusion.ts"],"cases":[{"line":137,"title":"docks a fill sheet on a keyboard already up when it opens","decision":"keep","reason":"A fill sheet opened after keyboard show seeds its layout from the existing keyboard height."},{"line":144,"title":"does not seed a content-sized sheet from a keyboard already up","decision":"keep","reason":"A content-sized sheet deliberately ignores stale existing keyboard metrics."},{"line":154,"title":"lifts with the event duration and drops back when the keyboard hides","decision":"keep","reason":"Keyboard show/hide updates actual sheet layout and event-duration animation inputs."},{"line":166,"title":"unsubscribes on unmount","decision":"keep","reason":"Unmount releases both keyboard subscriptions."}]} +{"path":"mobile/src/components/mounted-bottom-drawer-page-keyboard.web.test.tsx","sha256":"638a335e30998cde9dcc2b403d036eb02e90b57007cac02aba8a3095cb4e4bf2","reviewed_sha256":"638a335e30998cde9dcc2b403d036eb02e90b57007cac02aba8a3095cb4e4bf2","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep the real page keyboard seam instead of native Keyboard stubs.","evidence":["mobile/src/components/mounted-bottom-drawer.tsx","mobile/src/platform/keyboard-occlusion.web.ts"],"cases":[{"line":103,"title":"mounts against react-native-web, whose Keyboard has no metrics()","decision":"keep","reason":"React-native-web without metrics still mounts the real drawer through the web seam."},{"line":110,"title":"sits on the keyboard the shell says covers the page, as it does natively","decision":"keep","reason":"Shell-published keyboard coverage moves the actual fill sheet instead of waiting for inert native events."}]} +{"path":"mobile/src/components/new-workspace-project-targets.test.ts","sha256":"8c960accd11524c80e2d36d8182a92f1677f5dc6d6d5d9de0bb5c8596ea4a7ae","reviewed_sha256":"8c960accd11524c80e2d36d8182a92f1677f5dc6d6d5d9de0bb5c8596ea4a7ae","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep canonical identity, execution-host naming and target deduplication.","evidence":["mobile/src/components/new-workspace-project-targets.ts","src/shared/project-host-setup-projection.ts"],"cases":[{"line":12,"title":"groups local and SSH checkouts of the same project","decision":"keep","reason":"Same-project local and SSH checkouts group together while keeping their execution choices."},{"line":29,"title":"shows the provider slug recovered from canonical git identity","decision":"keep","reason":"Canonical git provider identity supplies an independently expected owner/repository detail."},{"line":46,"title":"labels local, SSH, and paired runtime targets as the host list names them","decision":"keep","reason":"Local platform, SSH and paired runtime targets use the actual host label contract."},{"line":78,"title":"shows one target per host when the project has multiple local worktrees","decision":"keep","reason":"Multiple checkouts on the same execution host collapse to one target without losing another host."}]} +{"path":"mobile/src/components/new-workspace-reply-schema.test.ts","sha256":"97d4b35122f8142c73ac08dfafe9dcf80b622253ce21bcdebf4a8c5dbe291dcc","reviewed_sha256":"9c9070f1272242d99a43913ff572d8e3be50ca3e07591a0cddc6cb22d4f80e37","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep malformed producer/legacy compatibility; remove enum-against-itself inventory.","evidence":["mobile/src/components/new-workspace-reply-schema.ts","mobile/src/components/use-new-workspace-setup-script.ts","mobile/src/components/use-new-workspace-runtime-context.ts"],"cases":[{"line":22,"title":"requires the hook source the drawer assigns straight into its details","decision":"keep","reason":"Required setup source cannot disappear before assignment to the drawer detail."},{"line":30,"title":"preserves an explicit null source rather than collapsing it to absent","decision":"keep","reason":"Explicit null source stays distinct from an absent source."},{"line":34,"title":"takes the recorded reply with an explicit null setupTrust without salvaging it","decision":"keep","reason":"A real recorded explicit null setupTrust reply decodes without being falsely salvaged."},{"line":41,"title":"drops a setupTrust missing the members normalizeSetupHookTrust reads","decision":"keep","reason":"Incomplete trust objects drop before consumers read their required members."},{"line":49,"title":"keeps each arm the drawer compares against","decision":"remove","reason":"Iterates SETUP_RUN_POLICIES to validate the z.enum built from that same list; this cannot detect a wrong consumer/producer policy contract."},{"line":57,"title":"drops an arm this build does not know, which behaves as run-by-default did","decision":"keep","reason":"An unknown future policy salvages away so the drawer retains its prior run-by-default fallback."},{"line":66,"title":"keeps the approvals isSetupHookTrusted reads","decision":"keep","reason":"Valid persisted approvals preserve the members the trust reader requires."},{"line":74,"title":"drops one unreadable repo without costing the others their trust","decision":"keep","reason":"One malformed repository approval is isolated without dropping another repository trust record."},{"line":86,"title":"reads a null or absent ui the way the drawer always has","decision":"keep","reason":"Absent/null UI replies preserve legacy optional-read semantics."},{"line":95,"title":"reads a non-object ui.get result as absent rather than refusing it","decision":"keep","reason":"Nonobject fulfilled ui.get results remain absent instead of introducing an unhandled rejection."}]} +{"path":"mobile/src/components/new-worktree-agent-selection.test.ts","sha256":"7e95db97b2dc751aec37875e4f70df00875a239f2a695f35599985d106a22c3f","reviewed_sha256":"7e95db97b2dc751aec37875e4f70df00875a239f2a695f35599985d106a22c3f","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep user-override and detection reconciliation behavior.","evidence":["mobile/src/components/new-worktree-agent-selection.ts","mobile/src/components/use-new-workspace-agent-selection.ts","mobile/src/tasks/workspace-agent-selection.ts"],"cases":[{"line":11,"title":"picks the preferred detected agent when there is no user override","decision":"keep","reason":"A runtime preference wins before a user makes an override and still respects detected IDs."},{"line":27,"title":"keeps an available user override","decision":"keep","reason":"An explicitly selected available agent survives a different default."},{"line":40,"title":"clears an unavailable user override after detection completes","decision":"keep","reason":"Completed detection clears an override that is no longer installed."},{"line":55,"title":"clears a disabled user override after detection completes","decision":"keep","reason":"Disabled agents cannot survive as a selectable override after detection."},{"line":70,"title":"keeps blank terminal as an explicit override","decision":"keep","reason":"Blank Terminal is a deliberate override and remains selectable without an installed agent."},{"line":85,"title":"leaves closed modal state untouched","decision":"keep","reason":"A closed modal does not reset its remembered selection based on background detection."},{"line":98,"title":"uses blank when no detected agent is known","decision":"keep","reason":"No detected agent falls back to the explicit blank terminal choice."}]} +{"path":"mobile/src/components/new-worktree-form-sheet-visibility.test.ts","sha256":"d698bf17f3f37a95f945a048ec1028e6d8e1177ad709cc6b1066005a1cd937e1","reviewed_sha256":"56588ebcb83076954b9f4dcd29da2375849449be73265f098f150e6a3b9c4625","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep distinct floor/picker/closed cases; remove the transition predicate replay.","evidence":["mobile/src/components/new-worktree-form-sheet-visibility.ts","mobile/src/components/use-new-worktree-drawer-navigation.ts","mobile/src/components/use-new-worktree-drawer-navigation.test.ts"],"cases":[{"line":5,"title":"keeps the form under the source picker","decision":"keep","reason":"The source picker retains the form floor underneath its full-height surface."},{"line":14,"title":"never leaves the mounted modal without a sheet during a drawer swap","decision":"remove","reason":"The existing navigation suite enters the real source-to-form and picker transitions and already asserts the form stays visible while the timer is pending."},{"line":20,"title":"yields the window to the content-sized pickers and the trust prompt","decision":"keep","reason":"Content-sized project/run-target/agent/trust surfaces own the window instead of retaining the form floor."},{"line":26,"title":"hides everything once the modal closes","decision":"keep","reason":"Closing the modal hides its form even if its drawer state still says form."}]} +{"path":"mobile/src/components/pr-sidebar/PRCommentsSection.test.ts","sha256":"46773635c7e583db4363b5ce8ba9774481ff0bf18837af0bed1d33ddcd22cfac","reviewed_sha256":"46773635c7e583db4363b5ce8ba9774481ff0bf18837af0bed1d33ddcd22cfac","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep actual pagination/filter event behavior.","evidence":["mobile/src/components/pr-sidebar/PRCommentsSection.tsx"],"cases":[{"line":100,"title":"resets pagination only when the user chooses a different audience filter","decision":"keep","reason":"Retapping the current audience preserves expanded pagination; changing audience resets the rendered list to its first page."}]} +{"path":"mobile/src/components/pr-sidebar/PRConflictingFilesSection.test.ts","sha256":"09e52b11c21fd62383b6f0c425c04b6d2c86a72e525c2a4cf8bb11485d32e334","reviewed_sha256":"09e52b11c21fd62383b6f0c425c04b6d2c86a72e525c2a4cf8bb11485d32e334","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep user-visible clipboard acknowledgement and refusal.","evidence":["mobile/src/components/pr-sidebar/PRConflictingFilesSection.tsx","mobile/src/components/pr-sidebar/pr-conflict-presentation.ts"],"cases":[{"line":90,"title":"says it copied when the pasteboard took the commands","decision":"keep","reason":"Activating Copy sends the real recovery commands to the clipboard and displays success after acceptance."},{"line":97,"title":"says it failed instead of saying nothing at all","decision":"keep","reason":"A refused clipboard write displays failure rather than claiming it copied."}]} +{"path":"mobile/src/components/pr-sidebar/markdown-blocks.test.ts","sha256":"08e1d2f5d821b7c13aba57d3861727067853ec3e2027cae985542a3bb9eb2747","reviewed_sha256":"e25284984552932915190fbd6504b3d790aa38e1604b35db8681f9190f70a9d0","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Keep independent parser AST expectations and repair weak/misnamed assertions.","evidence":["mobile/src/components/pr-sidebar/markdown-blocks.ts","mobile/src/components/rich-markdown/markdown-table-rows.ts"],"cases":[{"line":5,"title":"classifies headings, fenced code, quotes, lists, hr, and paragraphs","decision":"keep","reason":"Independent block fixtures classify headings, code, quotes, lists, rules and paragraphs."},{"line":31,"title":"strips HTML comments (single-line and multi-line) before parsing","decision":"keep","reason":"Single/multiline comments disappear before block parsing without losing surrounding text."},{"line":52,"title":"parses
/ into a collapsible block and
into a quote","decision":"keep","reason":"Details/summary and blockquote HTML produce their meaningful block structures."},{"line":63,"title":"keeps text around an HTML block in order and strips stray inline tags","decision":"fix","reason":"The body deliberately expects kbd tags retained at block stage. Retitle it to describe text ordering and leaving inline markup for the inline parser."},{"line":72,"title":"is total — never throws on empty, whitespace, or an unterminated fence","decision":"fix","reason":"Replace the whitespace-only not.toThrow with the expected empty block list, retaining unterminated-fence output."},{"line":79,"title":"captures the fence language (e.g. mermaid) on the code block","decision":"keep","reason":"Fence info strings reach the code block language field."},{"line":88,"title":"parses a basic pipe table","decision":"keep","reason":"Pipe header/delimiter/body lines produce an independently expected table AST."},{"line":103,"title":"reads per-column alignment from the delimiter row","decision":"keep","reason":"Colon delimiter grammar determines each column alignment."},{"line":114,"title":"keeps inline-formatting markup in cells for later inline parsing","decision":"keep","reason":"Cell inline markup survives block parsing for the inline renderer."},{"line":126,"title":"handles tables without outer pipes and escaped pipes in cells","decision":"keep","reason":"Outer pipes are optional while escaped cell pipes remain text."},{"line":138,"title":"keeps an escaped pipe that ends a row carrying no closing pipe","decision":"keep","reason":"An escaped final pipe does not create a spurious cell boundary."},{"line":150,"title":"ends a cell at the pipe following an escaped backslash","decision":"keep","reason":"A literal escaped backslash permits the following unescaped pipe to delimit a cell."},{"line":162,"title":"does not treat prose containing a pipe as a table (no delimiter row)","decision":"keep","reason":"Prose with a pipe but no delimiter remains paragraph content."},{"line":168,"title":"is total — a malformed/partial table degrades without throwing","decision":"fix","reason":"Keep bodyless-table expectations and replace ragged/empty-cell not.toThrow checks with explicit preserved cell/header structures."},{"line":182,"title":"tokenizes bold, italic, code, and links; leaves plain runs as text","decision":"keep","reason":"Inline emphasis, code and links yield independently expected token text and destinations."},{"line":195,"title":"leaves unbalanced markers as literal text","decision":"keep","reason":"Unbalanced inline markers remain literal instead of swallowing content."}]} +{"path":"mobile/src/components/pr-sidebar/markdown-link-scheme.test.ts","sha256":"5e8f9da3f32a24428606a1406426ba0594ba8ebf3016640b73f9f9d02894bf16","reviewed_sha256":"5e8f9da3f32a24428606a1406426ba0594ba8ebf3016640b73f9f9d02894bf16","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep the untrusted PR-comment opener allowlist.","evidence":["mobile/src/components/pr-sidebar/markdown-link-scheme.ts","mobile/src/components/pr-sidebar/CommentMarkdown.tsx"],"cases":[{"line":5,"title":"allows http, https, and mailto","decision":"keep","reason":"Only intended http/https/mailto destinations reach the system handler."},{"line":11,"title":"rejects unsafe and unparseable schemes","decision":"keep","reason":"Unsafe/unknown/malformed URLs do not create system navigation."},{"line":19,"title":"rejects data: URLs (XSS vector)","decision":"keep","reason":"Data URLs are excluded from untrusted comment navigation."},{"line":24,"title":"treats the scheme case-insensitively","decision":"keep","reason":"Scheme casing does not accidentally hide an allowed destination."}]} +{"path":"mobile/src/components/pr-sidebar/markdown-table-delimiter-performance.test.ts","sha256":"332be159d58386bb3a6d4c05d404b0afdedea1912e1cbe4919834e3e354ac7f0","reviewed_sha256":"332be159d58386bb3a6d4c05d404b0afdedea1912e1cbe4919834e3e354ac7f0","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep real parser cost and independent old-grammar compatibility.","evidence":["mobile/src/components/pr-sidebar/markdown-blocks.ts","mobile/src/components/rich-markdown/markdown-table-rows.ts"],"cases":[{"line":12,"title":"rejects $name without backtracking","decision":"keep","reason":"Hostile long whitespace rows remain paragraphs under an interruptible parser deadline."},{"line":25,"title":"preserves the original delimiter grammar over generated rows","decision":"keep","reason":"Exhaustive small fragment combinations compare the new cell-based parser with the prior delimiter grammar."}]} +{"path":"mobile/src/components/pr-sidebar/markdown-tag-stripping-performance.test.ts","sha256":"438616da1fe5005a311cabfd5dc448d8d8b436054660e48c0eee1550ea8d8a98","reviewed_sha256":"438616da1fe5005a311cabfd5dc448d8d8b436054660e48c0eee1550ea8d8a98","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep bounded hostile markup and independent prior-regex compatibility.","evidence":["mobile/src/components/pr-sidebar/markdown-blocks.ts"],"cases":[{"line":8,"title":"preserves an unclosed suffix after %s","decision":"keep","reason":"An unclosed repeated tag suffix stays literal within a hard deadline, with/without an earlier stripped tag."},{"line":15,"title":"preserves the original stripping grammar over generated markup","decision":"keep","reason":"Seeded markup strings compare the optimized stripper with the independent original regex."}]} +{"path":"mobile/src/components/pr-sidebar/pr-actions-state.test.ts","sha256":"a60dc1c9004f32ece3161127047569781e6112c590ed285ae74070fb869d5ec6","reviewed_sha256":"a60dc1c9004f32ece3161127047569781e6112c590ed285ae74070fb869d5ec6","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep merge/reopen availability and permitted repository merge-method selection.","evidence":["mobile/src/components/pr-sidebar/pr-actions-state.ts"],"cases":[{"line":5,"title":"merged: only unlink","decision":"keep","reason":"Merged reviews expose unlink without impossible merge/close/reopen actions."},{"line":15,"title":"closed: reopen + unlink, no merge","decision":"keep","reason":"Closed reviews allow reopen but cannot merge."},{"line":23,"title":"open and draft: merge/auto-merge/close allowed","decision":"keep","reason":"Open/draft states expose their legitimate merge, auto-merge and close actions."},{"line":35,"title":"uses squash when repository settings are unavailable","decision":"keep","reason":"Unavailable repository settings retain the expected squash default."},{"line":39,"title":"uses the repository default when it is allowed","decision":"keep","reason":"An allowed configured default is preferred."},{"line":48,"title":"falls back to an allowed method when the default is disabled","decision":"keep","reason":"A disabled default falls back to an actually allowed merge method."}]} +{"path":"mobile/src/components/pr-sidebar/pr-check-detail-content.test.ts","sha256":"af5ba9e6afefb2c09b4a7fbbc38f060622bcda0571a105623a4530cd72be99fc","reviewed_sha256":"af5ba9e6afefb2c09b4a7fbbc38f060622bcda0571a105623a4530cd72be99fc","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep actionable detail extraction and bounded rendering.","evidence":["mobile/src/components/pr-sidebar/pr-check-detail-content.ts"],"cases":[{"line":24,"title":"builds summary lines from conclusion/title/summary, skipping blanks","decision":"keep","reason":"Check conclusion/title/summary appear in order without blank lines."},{"line":31,"title":"maps annotations with a path:line locator and caps at 20","decision":"keep","reason":"Annotation locators retain file/line identity and the visible list is capped with a truncation flag."},{"line":54,"title":"falls back to \"Annotation\" when no path is present","decision":"keep","reason":"An annotation lacking a path still receives a useful locator."},{"line":73,"title":"prefers failing jobs and surfaces only their failed steps","decision":"keep","reason":"Failure-priority job selection exposes only failed steps and retains relevant log detail."},{"line":123,"title":"shows all jobs labeled \"Jobs\" when none are failing","decision":"keep","reason":"Without failures, all jobs remain visible under an honest Jobs label."}]} +{"path":"mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts","sha256":"5ac883d8c7bd9b7aa1d8c97423c26abd6768e7e8be8719568a2853d2100b8b99","reviewed_sha256":"65a7a741da1670ee5348bbe2a5ffc94c5d12bd4ded04b2bb43cb6a102583e784","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Move classifier replays into real mobile check ordering; retain summaries, identities, badge labels and reviewer state.","evidence":["mobile/src/components/pr-sidebar/pr-checks-presentation.ts","src/shared/provider-check-summary.ts"],"cases":[{"line":25,"title":"treats a completed null-conclusion check as neutral, not failure","decision":"consolidate","reason":"Exercise completed-null neutrality through the extended real sort, where neutral placement affects the visible order."},{"line":28,"title":"treats queued/in_progress as pending","decision":"consolidate","reason":"Exercise queued/in-progress states through the extended real sort rather than a direct shared-classifier replay."},{"line":32,"title":"maps failure/cancelled/timed_out to failure","decision":"consolidate","reason":"Exercise failure/cancelled/timed-out rows through the sort and its stable failure bucket."},{"line":37,"title":"maps a merge-blocking action_required gate to failure","decision":"consolidate","reason":"Exercise action-required as a leading actionable row in the extended mobile sort."},{"line":40,"title":"maps skipped to success and neutral to neutral (desktop parity)","decision":"consolidate","reason":"Exercise skipped/success and neutral placement through the extended mobile sort."},{"line":47,"title":"orders failures first, then pending, then success","decision":"fix","reason":"Extend independently expected displayed order with completed-null, neutral, queued, cancelled, timed-out, action-required and skipped cases before removing classifier replays."},{"line":55,"title":"is stable within a bucket","decision":"keep","reason":"Equivalent-severity rows keep upstream order."},{"line":65,"title":"returns the key of the first failing check in the given order","decision":"keep","reason":"The first actionable failure key follows the actual sorted collection."},{"line":73,"title":"returns null when nothing is failing","decision":"keep","reason":"A collection with no failure has no autoexpanded failure key."},{"line":84,"title":"returns a \"No checks\" summary for an empty list","decision":"keep","reason":"A successful empty read renders No checks rather than an invented outcome."},{"line":90,"title":"reads the empty header as unavailable, not absent, when the checks read failed","decision":"keep","reason":"A failed checks read renders unavailable even when the last summary is empty."},{"line":97,"title":"counts pass/pending/fail and reports worst-case outcome","decision":"keep","reason":"Mixed actual checks produce independent rollup counts, worst outcome and readable mobile label."},{"line":112,"title":"reports pending when no failures but some pending","decision":"keep","reason":"Pending work outranks passed rows when no failure is present."},{"line":120,"title":"reports success when all pass","decision":"keep","reason":"An all-passed collection reports success."},{"line":123,"title":"reports a neutral-only set as neutral with a labeled count (not empty success)","decision":"keep","reason":"A neutral-only collection remains visibly neutral with an honest count."},{"line":137,"title":"counts skipped as passed so the sidebar matches desktop and the tasks grid","decision":"keep","reason":"Skipped checks count as passed in the mobile summary."},{"line":149,"title":"prefers checkRunId, then workflowRunId, then name","decision":"keep","reason":"Numeric run identity outranks workflow identity, then display name, for stable detail caching."},{"line":157,"title":"maps each PR state to a label + status-color token matching the workspace-list badge","decision":"keep","reason":"Actual state badges retain independent readable labels and the specified status tokens."},{"line":166,"title":"returns empty for no reviewers","decision":"keep","reason":"No reviewers produces no invented row."},{"line":169,"title":"labels requested-only reviewers as Requested","decision":"keep","reason":"Outstanding requests show requester identity and Requested status."},{"line":183,"title":"maps latest-review states to labels","decision":"keep","reason":"Latest review states map to independent readable labels and severity tokens."},{"line":195,"title":"dedupes a reviewer present in both requests and reviews (requested wins)","decision":"keep","reason":"A requested reviewer already present in reviews appears only once, retaining the request status."}]} +{"path":"mobile/src/components/pr-sidebar/pr-comment-card-web-avatar.test.tsx","sha256":"19db4ab57c9519f6181dad6bebae91f6848534dbe100a5e6d3ab4f961a6a2382","reviewed_sha256":"19db4ab57c9519f6181dad6bebae91f6848534dbe100a5e6d3ab4f961a6a2382","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep native positive control and web fallback while card identity still renders.","evidence":["mobile/src/components/pr-sidebar/PRCommentCard.tsx"],"cases":[{"line":77,"title":"renders the provider image on a phone","decision":"keep","reason":"The native card actually renders the provider avatar URL."},{"line":87,"title":"renders the empty circle instead, inside the page","decision":"keep","reason":"The web card still renders its author while neither an image nor any prop contains the provider URL."}]} +{"path":"mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts","sha256":"366ae54e9585479f977d7b1fc2aba1e2143136a8da4b939c31a72bf1b7db7a82","reviewed_sha256":"97c5b66bf81d75e3c9798546d64e07bd1e76f1a732981630dd5000ab06af6e63","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep recovery commands and actual conflict view models; remove the duplicate helper truth table.","evidence":["mobile/src/components/pr-sidebar/pr-conflict-presentation.ts"],"cases":[{"line":23,"title":"is true only for CONFLICTING","decision":"remove","reason":"The direct CONFLICTING predicate duplicates the retained resolveConflictDisplay positive and MERGEABLE/UNKNOWN null outcomes."},{"line":31,"title":"builds safe mergeability refresh commands","decision":"keep","reason":"Recovery commands retain --only so an empty refresh commit cannot capture staged user files."},{"line":41,"title":"returns null when there are no conflicts","decision":"keep","reason":"Nonconflicting/unknown hosted states omit the conflict section."},{"line":46,"title":"lists conflicting files with commit metadata","decision":"keep","reason":"An actual conflict preserves file identities and behind/base commit metadata."},{"line":68,"title":"flags file-details-unavailable when conflicting but no file list","decision":"keep","reason":"Unavailable file details remain distinct from a successful empty/nonconflicting result."},{"line":80,"title":"flags unavailable when conflictSummary has an empty file list","decision":"keep","reason":"An explicitly empty host file list uses the unavailable-detail notice."},{"line":90,"title":"flags locally clean when GitHub reports a conflict that local git does not reproduce","decision":"keep","reason":"A local clean simulation still surfaces the hosted conflict with safe refresh guidance."}]} +{"path":"mobile/src/components/pr-state-token.test.ts","sha256":"a119debbec9f9121ff44642aa98c3b9f527a3d55f661c0c4fb827e175acfed3f","reviewed_sha256":"61f121841b9c5fff7bae46bc381717c7fa0d176b1ccb03f3b008ab945f96991c","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep free-form input normalization; remove duplicated token and helper-composition checks.","evidence":["mobile/src/components/pr-state-token.ts","mobile/src/components/pr-sidebar/pr-checks-presentation.ts","mobile/src/components/pr-sidebar/pr-sidebar-status-color.ts","mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts"],"cases":[{"line":8,"title":"maps PR states to the desktop-matching status palette","decision":"remove","reason":"The retained prStateBadge case already checks each independent state/token pair through the actual badge model."},{"line":15,"title":"is case-insensitive and falls back to muted for unknown states","decision":"keep","reason":"Uppercase and unknown raw workspace payload states retain normalization and muted fallback."},{"line":21,"title":"resolves to the expected concrete colors","decision":"remove","reason":"Composes token-to-color switch wrappers and compares against imported palette values without rendering either badge."},{"line":32,"title":"sidebar badge and list badge agree for %s","decision":"remove","reason":"Both sides delegate to prStateToken through the same statusColor function, so the parity comparison can pass without exercising either list or sidebar surface."}]} +{"path":"mobile/src/components/rich-markdown/document-host-root.test.ts","sha256":"4b2663f5a9cab245e99e17853fb20d49e68137519e2abca52755bf163fbc3d5d","reviewed_sha256":"4b2663f5a9cab245e99e17853fb20d49e68137519e2abca52755bf163fbc3d5d","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep independently mounted document ownership on one page.","evidence":["mobile/src/components/rich-markdown/editor-surface.ts","mobile/src/components/rich-markdown/create-rich-markdown-editor-document.ts"],"cases":[{"line":56,"title":"writes each host content into that host, and never into the other","decision":"keep","reason":"Two real roots receive their own host content instead of the first repeated editor ID."},{"line":67,"title":"serializes the surface it was started against rather than the page’s first one","decision":"keep","reason":"Serialization reads the document own surface, not the first page editor."},{"line":77,"title":"reports an edit in the second host to the second host’s own host","decision":"keep","reason":"An edit in the second root reports only to its own host."},{"line":90,"title":"leaves the other document live when one of the two is stopped","decision":"keep","reason":"Stopping one document leaves the other root listeners live."},{"line":102,"title":"reads the whole page when no root is named, which is what the WebView gets","decision":"keep","reason":"The rootless native-document contract still reads the page-wide surface."}]} +{"path":"mobile/src/components/rich-markdown/document-lifecycle.test.ts","sha256":"e4eece192c9316ece62180e2ff934e634c1da370cf833bde97540157cf0902ed","reviewed_sha256":"38c5d8767420a3e2f721cce540e8457fa5d292c5c24c2e034e2558f29e65140c","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep actual lifecycle and asynchronous stale answers; remove speculative timer fixture.","evidence":["mobile/src/components/rich-markdown/create-rich-markdown-editor-document.ts","mobile/src/components/rich-markdown/editor-listeners.ts","mobile/src/components/rich-markdown/editor-commands.ts","mobile/src/components/rich-markdown/editor-content.ts"],"cases":[{"line":65,"title":"takes its own listeners off the surface","decision":"keep","reason":"Stopping removes input/change/click/keyboard reporting listeners from the real surface."},{"line":80,"title":"stops observing the viewport, so no inset of its own reaches the next mount","decision":"keep","reason":"Stopping releases the actual viewport observer."},{"line":89,"title":"leaves a second mount a document of its own, not the first one continued","decision":"keep","reason":"Remounting gets fresh generation/content and cannot report into the stopped host."},{"line":111,"title":"is two editors when two are mounted, each reading its own scope","decision":"keep","reason":"Independent document scopes retain separate editable flags and generations over the same test markup."},{"line":130,"title":"cancels a change still waiting on a timer, which no listener removal can reach","decision":"remove","reason":"Plants inputTimer directly even though no production code schedules it; asserts a future debounce scenario that users cannot currently trigger. Record dormant production plumbing separately without changing it."},{"line":165,"title":"drops a command whose dialog answered after the host moved on","decision":"keep","reason":"An async URL answer is refused after content replacement, read-only transition or stop, with an unchanged-document positive control."},{"line":224,"title":"unwinds a start that throws rather than leaving the listeners it already installed","decision":"keep","reason":"A partially failed start unwinds listeners and never reports ready."}]} +{"path":"mobile/src/components/rich-markdown/editor-content.test.ts","sha256":"cc9efcaea2123e9735f506749fbcbfb0cef7ec26d371b4176652ecc13205b377","reviewed_sha256":"b743d2d3daef65c0f98fc9de6c2f911b45a84a66a1f50184a2bcc88c4f30b4fd","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Keep actual changes, checkbox events and host generations; drop timer-null call pins.","evidence":["mobile/src/components/rich-markdown/editor-content.ts","mobile/src/components/rich-markdown/editor-listeners.ts","mobile/src/components/rich-markdown/editor-commands.ts"],"cases":[{"line":49,"title":"carries the generation it was set under into every change","decision":"keep","reason":"Host generations remain attached to changes across actual content replacements."},{"line":61,"title":"reads a generation that is not a number as zero","decision":"keep","reason":"An invalid numeric generation retains the document zero fallback."},{"line":68,"title":"posts the change on the spot, with no timer between the edit and the host","decision":"fix","reason":"Keep immediate real edit reporting and no pending timers; remove clearTimer(null) call counts, which only pin dormant plumbing."},{"line":84,"title":"says nothing while it is rewriting itself","decision":"keep","reason":"Host replacement updates actual markup silently rather than echoing a user change."},{"line":93,"title":"stops reporting, and disables every checkbox, once it is read-only","decision":"keep","reason":"Read-only state disables actual checkboxes and suppresses edits until editable state returns."},{"line":114,"title":"writes a ticked checkbox back into the markup the next serialization reads","decision":"keep","reason":"A checkbox change updates serializable task markup and reports the expected checked Markdown."},{"line":124,"title":"reports one change for a checkbox tap, not one per event the tap raises","decision":"keep","reason":"A real checkbox click raises click/input/change but reports one host change."},{"line":139,"title":"reports one change for inline code over a selection, not one per emitting step","decision":"keep","reason":"Inline-code wrapping changes the real selection/markup and emits one change rather than duplicate reports."}]} +{"path":"mobile/src/components/rich-markdown/editor-selection.test.ts","sha256":"626a41798e3678d1de44a606524cbba0cc271d5928f0f5f88b751ed134e37863","reviewed_sha256":"626a41798e3678d1de44a606524cbba0cc271d5928f0f5f88b751ed134e37863","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep caret restoration over actual happy-dom focus and selection boundaries.","evidence":["mobile/src/components/rich-markdown/editor-selection.ts","mobile/src/components/rich-markdown/keyboard-dismiss.ts","mobile/src/components/rich-markdown/editor-commands.ts"],"cases":[{"line":105,"title":"blurs the surface, which is what closes the keyboard over a document","decision":"keep","reason":"Dismissal blurs the actual editor and the WebKit-like blur fixture removes its selection."},{"line":113,"title":"reclaims focus at the tapped caret rather than at the stale one","decision":"keep","reason":"A tap after dismissal focuses and places the caret at the new paragraph."},{"line":121,"title":"leaves an uneditable label tap to the checkbox instead of refocusing","decision":"keep","reason":"A noneditable task label does not steal focus from checkbox interaction."},{"line":131,"title":"restores the pre-dismissal caret so a command does not insert at the end","decision":"keep","reason":"A toolbar command restores the saved caret after the dismissal removed live ranges."},{"line":140,"title":"falls back to the end of the document when no caret was ever placed","decision":"keep","reason":"A command without a prior caret targets the document end."},{"line":146,"title":"drops a remembered caret whose nodes left the document","decision":"keep","reason":"Detached saved nodes cannot restore a stale caret; commands fall back to the current document."},{"line":165,"title":"puts the caret back where the dialog found it, so the command has one to act on","decision":"keep","reason":"A modal that takes focus/selection gives its URL command back the original caret."},{"line":174,"title":"falls back to the end when the dialog outlived the content it was opened over","decision":"keep","reason":"A dialog outliving detached nodes restores a safe current-document fallback."},{"line":190,"title":"runs no command when the dialog is cancelled, and leaves the caret alone","decision":"keep","reason":"Cancellation runs no command and does not restore a selection nobody will use."}]} +{"path":"mobile/src/components/rich-markdown/markdown-code-fence-allocation.test.ts","sha256":"82162ac53bd9dc37bcdd65ff0f5b80f8581c44eff27bb178f939831c3e505fa2","reviewed_sha256":"82162ac53bd9dc37bcdd65ff0f5b80f8581c44eff27bb178f939831c3e505fa2","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep boundary fence output and admitted-document serialization allocation regression.","evidence":["mobile/src/components/rich-markdown/markdown-code-fence.ts","mobile/src/components/rich-markdown/html-block-markdown.ts"],"cases":[{"line":16,"title":"chooses a fence of $length characters for the whole code block","decision":"keep","reason":"Independent empty, Unicode, isolated and long-backtick fixtures choose a fence longer than any code run."},{"line":28,"title":"serializes an admitted editable document without collecting every backtick run","decision":"keep","reason":"A near-limit actual editable document serializes a real change without building a giant match array or losing content."}]} +{"path":"mobile/src/components/rich-markdown/markdown-round-trip.test.ts","sha256":"5ece31a73137c79382c57da6843b6c4ad67c7457a6b9582f39f7b18773cf368b","reviewed_sha256":"ea5a8e62fe9e72fd3a01ed4fcf5ca4c86d4df39911eed0d796e4154b19b1edf6","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Keep DOM round-trip semantics and make the known nonprogress regression interruptible.","evidence":["mobile/src/components/rich-markdown/markdown-to-html.ts","mobile/src/components/rich-markdown/html-block-markdown.ts","mobile/src/components/rich-markdown/html-list-markdown.ts"],"cases":[{"line":57,"title":"renders and serializes nested bullet, ordered and task lists with indentation intact","decision":"keep","reason":"Nested bullet/ordered/task list structure and indentation survive the real renderer/serializer."},{"line":76,"title":"serializes a bullet list the engine nested inside a paragraph, as the flat shape does","decision":"keep","reason":"Browser-produced lists nested inside paragraphs serialize with their list markers."},{"line":91,"title":"serializes a numbered list the engine nested inside a paragraph","decision":"keep","reason":"Browser-produced nested numbered lists retain numbering."},{"line":101,"title":"reads a paragraph that holds a list and text around it as separate blocks","decision":"keep","reason":"Paragraph text before/after an embedded list becomes correctly separated Markdown blocks."},{"line":115,"title":"renders markdown entities as characters without double-escaping them","decision":"keep","reason":"Entities render as authored characters without double escaping."},{"line":122,"title":"preserves explicit ordered-list numbering through the round trip","decision":"keep","reason":"Explicit nonconsecutive ordered numbering survives serialization."},{"line":131,"title":"serializes ordered lists from the parent start when item metadata is missing","decision":"keep","reason":"Pasted ordered lists without item metadata use the parent starting number."},{"line":143,"title":"renders task checkboxes as disabled while the surface is read-only","decision":"keep","reason":"Read-only task markup disables actual checkbox elements."},{"line":150,"title":"round-trips every block the toolbar can produce","decision":"keep","reason":"Every supported toolbar block round-trips through independently written Markdown."},{"line":176,"title":"makes progress on a marker with nothing after it, rather than reading it forever","decision":"fix","reason":"Run bare-marker conversion under a VM deadline so the known synchronous nonprogress regression fails instead of hanging the worker; retain real heading/list controls."},{"line":199,"title":"renders no link for a javascript: URL, which is the one scheme it filters","decision":"keep","reason":"An unsafe JavaScript URL produces no active rendered link."},{"line":207,"title":"round-trips a code block that holds a fence of its own","decision":"keep","reason":"Code containing its own fence gets a longer enclosing fence and survives both directions."},{"line":217,"title":"round-trips a table cell that holds a pipe, and the backslash that hid it","decision":"keep","reason":"Table cells preserve literal pipes and the backslashes required to escape them."}]} +{"path":"mobile/src/components/rich-markdown/page-stylesheet.test.ts","sha256":"1b6b03036da1e70cd2b4fb1cbafd7aa5ecde9d7e8a86ad9b88eb50e6cd2798f9","reviewed_sha256":"e85b3cb743410d4bc211f6c62aac42634eec67a87a1983ae93c3e66a3db5d58c","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep editor-specific root-rule semantics; prefer the actual injected sheet for full selector confinement.","evidence":["mobile/src/style-scoping/document-style-scoping.ts","mobile/src/components/rich-markdown/document-style.ts","mobile/src/components/rich-markdown/rich-markdown-web-document-mount.ts","mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts","mobile/src/style-scoping/document-style-scoping.test.ts"],"cases":[{"line":29,"title":"reaches nothing outside the host","decision":"consolidate","reason":"The actual document-mount suite already reads the injected editor sheet; strengthen that assertion to an exact host or host-descendant prefix before removing this direct transform replay."},{"line":35,"title":"moves the document’s own rules onto the host rather than dropping them","decision":"keep","reason":"Root declarations retain the editor variables and own document behavior instead of being discarded."},{"line":49,"title":"keeps the universal rule as the host and everything in it","decision":"keep","reason":"Universal box sizing reaches the host itself as well as its descendants."},{"line":54,"title":"collapses the document’s three names to one host selector","decision":"keep","reason":"The html/body/root names collapse to one host selector."},{"line":60,"title":"refuses a document-level selector it cannot move, rather than scoping it wrongly","decision":"keep","reason":"A descendant selector rooted at body is refused instead of being silently changed or dead."},{"line":68,"title":"refuses a descendant of the document root, which reads as no leading element at all","decision":"keep","reason":"Root pseudo-selector descendants/variants are rejected while a bare root still maps to the host."},{"line":80,"title":"refuses a sheet whose shape it cannot rewrite, as the other half does","decision":"remove","reason":"The shared document-style-scoping suite already rejects at-rules and unterminated rules through both exports."}]} +{"path":"mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts","sha256":"ef1e9a997f2486cdb99923271169ce285244396de45e514fa2bd6f0e01ffe5fb","reviewed_sha256":"b2b3227a92b35c80f08ea280a76253bf8062f892d7f9600db018436ac0091e17","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep explicit import-time ownership guardrails and scanner positive/negative controls; remove list tautology.","evidence":["mobile/src/test-support/webview-document-census.ts","mobile/src/components/rich-markdown/create-rich-markdown-editor-document.ts"],"cases":[{"line":40,"title":"does no work: every effect is in a start function the hosts call","decision":"keep","reason":"An AST-based guard rejects import-time effects in every actual editor document module."},{"line":45,"title":"declares nothing that reaches an element","decision":"keep","reason":"The ownership rule rejects module declarations that capture a page element."},{"line":54,"title":"would report work in every declaration that runs as the module is evaluated","decision":"keep","reason":"Planted const/static/default-export effects prove the shared guard reports real executable shapes."},{"line":76,"title":"leaves declarations that only declare alone, so the empty list is a measurement","decision":"keep","reason":"Inert declarations prove the guard does not simply reject everything."},{"line":88,"title":"holds no mutable binding of its own: every one is a field of the scope","decision":"keep","reason":"Actual modules cannot introduce shared mutable document state outside per-call scope."},{"line":97,"title":"would name one in every shape a module can write it","decision":"keep","reason":"Planted module binding shapes prove block/export/loop syntax does not evade the ownership guard."},{"line":116,"title":"leaves a const and a function-local let alone, so the empty list is a measurement","decision":"keep","reason":"Const and function-local state remain permitted, making the empty actual-module result meaningful."},{"line":126,"title":"starts every module there is, and undoes in reverse the ones that can be undone","decision":"keep","reason":"Actual lifecycle exports must occur in the start/stop sequence with surface-first, ready-last and reverse teardown ordering."},{"line":147,"title":"finds a lifecycle export however it is written, and only when it is one","decision":"keep","reason":"Lifecycle reader controls distinguish legitimate exported scope lifecycles from other start-named acts across syntax variants."},{"line":186,"title":"would name a start the sequence forgot, which is what the comparison above is for","decision":"remove","reason":"Appending a literal string then asserting the new array differs proves only JavaScript array inequality; it never plants an omitted module start in the actual scanner input."}]} +{"path":"mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts","sha256":"240bf9840390a31326a4121fb7c40a22d2f2e6161dc2336a8c26b7b41f75f2b9","reviewed_sha256":"6147e257d9447b4eb25ce2b01154a37e5883f13a257ed3c081a97acddb370c79","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep actual host message/URL/inset/selection routing; remove default wrapper-only checks.","evidence":["mobile/src/components/rich-markdown/document-host-seams.ts","mobile/src/components/rich-markdown/document-scope.ts","mobile/src/components/rich-markdown/editor-commands.ts","mobile/src/components/rich-markdown/document-host-root.test.ts","mobile/src/components/rich-markdown/editor-selection.test.ts","mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts"],"cases":[{"line":33,"title":"clears a real timer, and a handle that was never set","decision":"remove","reason":"Tests the clearTimeout wrapper directly for a timer production never schedules; no actual document lifecycle exercises this pending-timer scenario."},{"line":47,"title":"takes the selection and the page from the window the document is running in","decision":"remove","reason":"Only compares window/document wrapper return identities; retained root, selection and real mount tests exercise those defaults through behavior."},{"line":55,"title":"routes every message to the field and nothing to the bridge","decision":"keep","reason":"An actual edit reaches the supplied host sink and leaves the shell WebView bridge untouched."},{"line":70,"title":"takes the URL from the host rather than from a dialog the shell never shows","decision":"keep","reason":"Host-prompted Link/Image URLs reach their distinct real command arguments."},{"line":84,"title":"reports no inset at all when the host has no source, and observes nothing","decision":"keep","reason":"An explicit no-source host neither posts an inset nor subscribes to a real supplied viewport."},{"line":99,"title":"reports the inset from the source the host names, before it reports ready","decision":"keep","reason":"A supplied measurement is rounded and delivered before ready so host layout initializes in order."},{"line":108,"title":"takes the caret from the selection the host names, not the window one","decision":"keep","reason":"Keyboard dismissal and command restoration use the supplied selection object without altering window selection."},{"line":164,"title":"runs its selection and its commands against the page the host names","decision":"keep","reason":"Actual toolbar commands execute against the host document rather than a global one."}]} +{"path":"mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts","sha256":"e624a37a29aad659609c1e95e3b26c4725a9bf80d28f4c2a635803dd14f9ddc7","reviewed_sha256":"4580951669ab65109e06f834eb7939620d4187bdd408f544b4ce1b92fdb22701","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Keep actual DOM/style ownership, failed-start unwind and URL command delivery.","evidence":["mobile/src/components/rich-markdown/rich-markdown-web-document-mount.ts"],"cases":[{"line":50,"title":"plants the markup in the host and reports itself ready through the seam","decision":"keep","reason":"Actual host markup becomes editable and reports ready through its host seam."},{"line":58,"title":"never reports a keyboard inset, because the screen measures the same viewport","decision":"keep","reason":"Window resize cannot create an editor inset because the mount intentionally delegates keyboard measurement to its screen."},{"line":66,"title":"injects one sheet for the page, held entirely under the host class","decision":"fix","reason":"Keep single-sheet injection across two mounts and tighten selector checks to exact host/host-descendant prefixes; remove the arbitrary stylesheet byte/selector count pins."},{"line":80,"title":"gives the host back on dispose, so every rule of the sheet matches nothing","decision":"keep","reason":"Dispose returns the host markup/class so retained stylesheet rules no longer apply."},{"line":89,"title":"leaves no listener of the first mount reporting into the second","decision":"keep","reason":"A second mount edits normally while events on the first detached surface report nothing."},{"line":110,"title":"gives the host back when the document fails to start, rather than leaving a dead one","decision":"keep","reason":"A real failed surface lookup unwinds the host class and markup."},{"line":127,"title":"answers the URL commands from the host rather than from a dialog the shell never shows","decision":"keep","reason":"Actual mounted Image commands ask the host and deliver its URL to the document command."},{"line":151,"title":"runs nothing when the host cancels, which is what the shell used to do for every URL","decision":"keep","reason":"A canceled host prompt produces no document command."}]} +{"path":"mobile/src/components/right-drawer-hardware-back.test.tsx","sha256":"8f829ce491b545f9d717419a53cb92b4c4fa827d1dbf82cae38ba66f172b1917","reviewed_sha256":"2abc189ece66a52aef573dbc96b200f79964387e71c7b3c6602b829920fe8b5d","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"fix","rationale":"Keep callback ownership and registration cleanup; strengthen the positive back-key action.","evidence":["mobile/src/components/RightDrawer.tsx","mobile/src/navigation/use-back-claim.ts"],"cases":[{"line":98,"title":"arms it on iOS while the drawer is open","decision":"fix","reason":"Invoke the registered native hardware-back callback and assert it consumes the press and closes this drawer, instead of proving registration alone."},{"line":105,"title":"releases it when the drawer hides","decision":"keep","reason":"Hiding the drawer releases its hardware-back subscription."},{"line":115,"title":"releases it on unmount, so a drawer taken off screen leaves the key alone","decision":"keep","reason":"Unmounting an open drawer releases its native claim."}]} +{"path":"mobile/src/components/right-drawer-panel-width.test.ts","sha256":"cfa9324af63499c711519499fc53e355059e5e0f298f247307ad8808b272df89","reviewed_sha256":"cfa9324af63499c711519499fc53e355059e5e0f298f247307ad8808b272df89","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep actual panel geometry bounds rather than fixed decorative values.","evidence":["mobile/src/components/right-drawer-panel-width.ts","mobile/src/components/RightDrawer.tsx"],"cases":[{"line":9,"title":"caps to the wide max width on wide layouts","decision":"keep","reason":"Wide canvases cap the panel instead of stretching across a tablet."},{"line":13,"title":"leaves a backdrop gutter on narrow layouts","decision":"keep","reason":"Narrow canvases retain a tappable backdrop gutter."},{"line":17,"title":"honors an explicit widthPx but never exceeds the window width","decision":"keep","reason":"Explicit panel requests respect the available screen width."},{"line":22,"title":"never returns a negative width on tiny windows","decision":"keep","reason":"A tiny window never produces negative panel geometry."},{"line":26,"title":"clamps a negative explicit widthPx to zero","decision":"keep","reason":"An invalid negative explicit request clamps to zero."}]} +{"path":"mobile/src/components/terminal-shortcut-settings-custom-keys.test.tsx","sha256":"2e2ddf71703459c8e0d666c6f8944ec5dfa0062d35f2ca09676bcaf7667018f3","reviewed_sha256":"2e2ddf71703459c8e0d666c6f8944ec5dfa0062d35f2ca09676bcaf7667018f3","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep actual optimistic settings and persisted list behavior under delayed/refused storage.","evidence":["mobile/src/components/TerminalShortcutSettings.tsx","mobile/src/terminal/terminal-custom-keys.ts","mobile/src/storage/use-serialized-stored-state.ts"],"cases":[{"line":140,"title":"keeps a key removed when the list is reordered before the removal is saved","decision":"keep","reason":"A removal followed by reorder before storage acceptance preserves both edits in displayed and actually stored keys."},{"line":154,"title":"shows the key again when the store refuses its removal","decision":"keep","reason":"A refused removal restores both the visible row and the last accepted stored list."}]} +{"path":"mobile/src/components/use-bottom-drawer-follow-up.test.tsx","sha256":"b2e976d229c062cdda5fed47ac4acaa11cb5f526341617af9010f03c4577c52c","reviewed_sha256":"b2e976d229c062cdda5fed47ac4acaa11cb5f526341617af9010f03c4577c52c","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep post-unmount action delivery and cancellation.","evidence":["mobile/src/components/use-bottom-drawer-follow-up.ts","mobile/src/components/BottomDrawer.tsx"],"cases":[{"line":29,"title":"opens the next surface once, after the source drawer has unmounted","decision":"keep","reason":"A real drawer handoff invokes its next action exactly once and only after source unmount."},{"line":41,"title":"does not queue work for a backdrop or swipe dismissal","decision":"keep","reason":"Ordinary dismissal closes the source without creating queued follow-up work."},{"line":50,"title":"drops queued work when its screen unmounts","decision":"keep","reason":"Unmounting the owning screen cancels a queued action even if a late close callback fires."}]} +{"path":"mobile/src/components/use-connected-host-picker.test.ts","sha256":"e00bce4e0a7e7249207a2679151a1f8c1e1ac4f79f79fa2463b2a34c8e79685e","reviewed_sha256":"e00bce4e0a7e7249207a2679151a1f8c1e1ac4f79f79fa2463b2a34c8e79685e","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"keep","rationale":"Keep real picker actions, privacy and topology transitions.","evidence":["mobile/src/components/use-connected-host-picker.ts","mobile/src/transport/host-endpoint-label.ts"],"cases":[{"line":53,"title":"runs the action on the only offered host without a picker","decision":"keep","reason":"An explicitly offered sole host runs its action without showing an unnecessary picker."},{"line":63,"title":"offers only the hosts passed in","decision":"keep","reason":"The actual hook restricts options to the offered hosts and delivers the chosen host after closing."},{"line":76,"title":"runs nothing when the picker is dismissed","decision":"keep","reason":"Backdrop dismissal cannot run the pending host action."},{"line":88,"title":"disambiguates path-routed hosts without exposing endpoint paths","decision":"keep","reason":"Equal host names/endpoints disambiguate by safe host ID without exposing endpoint path secrets."},{"line":103,"title":"does not expose malformed legacy endpoint details","decision":"keep","reason":"Malformed legacy endpoints use an honest safe label without leaking path/query secrets."},{"line":118,"title":"closes a stale picker when an offered host disconnects","decision":"keep","reason":"A disconnect invalidates the open offered host set and closes its stale picker."},{"line":128,"title":"does not reopen a stale picker if its old host set returns while closing","decision":"keep","reason":"Returning topology cannot reopen an offer already canceled during closing."},{"line":141,"title":"keeps a selected host through an unrelated topology change while closing","decision":"keep","reason":"A selected connected host survives unrelated topology changes while its close completes."},{"line":153,"title":"drops a selection that disconnects while the picker is closing","decision":"keep","reason":"A selected host disconnecting before close completion cannot receive an action."}]} +{"path":"mobile/src/components/use-html-preview-link-grant.web.test.tsx","sha256":"88507d031d249cfe346fca157afea2f10fd79b7a4fb32bfa53712d94f40180d1","reviewed_sha256":"305ff1a9e20308a4fab4a01e3c82123403ef7a4b15fc6755b9af76cfcd5df318","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"audit_mobile","status":"reviewed","decision":"consolidate","rationale":"Keep negotiated real-bridge and manifest compatibility; remove native constant pin.","evidence":["mobile/src/components/use-html-preview-link-grant.web.ts","mobile/src/components/use-html-preview-link-grant.ts","mobile/src/mobile-web-shell/bridge/bridge-port-pair-test-harness.ts","src/shared/mobile-web-bundle/manifest-contract.ts"],"cases":[{"line":64,"title":"is granted when the shell named it for this route","decision":"keep","reason":"A real bridge init carrying the optional navigation grant enables the page reader."},{"line":71,"title":"is refused by a shell that cancels the navigation but did not grant this route","decision":"keep","reason":"A shell with navigate but without the external-opening grant cannot advertise working preview links."},{"line":75,"title":"is refused by a shell too old to have heard of it at all","decision":"keep","reason":"A legacy shell with no grant vocabulary fails closed while the preview keeps its other content."},{"line":81,"title":"is unconditional on native, where the preview is its own WebView","decision":"remove","reason":"Calling a native hook whose entire implementation returns true checks a constant rather than opening an actual native preview link."},{"line":87,"title":"is a name the bundle manifest will carry, on either lane","decision":"keep","reason":"The actual manifest accepts the special grant on required/optional lanes while rejecting its invalid dotted spelling."}]} diff --git a/docs/audits/test-value/reviews/root-0007-validation.json b/docs/audits/test-value/reviews/root-0007-validation.json new file mode 100644 index 00000000000..7487cfa53ce --- /dev/null +++ b/docs/audits/test-value/reviews/root-0007-validation.json @@ -0,0 +1,55 @@ +{ + "batch": "root-0007", + "reviewer": "root", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "platform": "Linux", + "reviewed_files": 3, + "original_declaration_sites": 22, + "case_decisions": { + "keep": 8, + "remove": 8, + "fix": 6 + }, + "review_scope": "Read all original bodies and tables in the action contract and both docs suites, plus the action modules, docs build/routing/layout/media/formatting paths. Source-regex inventories were assessed separately from actual externally interpreted Actions metadata.", + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node --test .github/actions/cloud-sql-rollout-lease/action-contract.test.mjs .github/actions/cloud-sql-rollout-lease/storage-lease.test.mjs docs/site/tests/docs-package.test.mjs docs/site/tests/search-excerpt.test.mjs", + "result": "28 tests passed; zero failures/skips. Includes the existing 14 storage lease tests retained in root-0006.", + "log": "/tmp/orca-root-0007-tests.log" + }, + { + "command": "pnpm exec oxfmt --write .github/actions/cloud-sql-rollout-lease/action-contract.test.mjs .github/actions/cloud-sql-rollout-lease/README.md docs/site/tests/docs-package.test.mjs docs/site/tests/search-excerpt.test.mjs", + "result": "Passed for files included by repository formatter configuration. Explicitly removed trailing blank EOF lines from edited tests." + }, + { + "command": "pnpm exec oxlint --no-ignore --format json .github/actions/cloud-sql-rollout-lease/action-contract.test.mjs docs/site/tests/docs-package.test.mjs docs/site/tests/search-excerpt.test.mjs", + "result": "Zero diagnostics across 2 files. The hidden .github action file is excluded by the linter even with this invocation; it is exercised by the actual node:test run." + }, + { + "command": "git diff --check -- .github/actions/cloud-sql-rollout-lease docs/site/tests", + "result": "Passed." + } + ], + "mutations": [ + { + "method": "Import each mutated formatter through a data URL in a temporary copy of the actual revised test module, then run the matching retained test under node --test. No repository production file was modified.", + "cases": [ + "Replace linkedText.includes('>') with true: unclosed angle test fails with ERR_SCRIPT_EXECUTION_TIMEOUT.", + "Replace protectedCode.includes(']') with true: unclosed bracket test fails with ERR_SCRIPT_EXECUTION_TIMEOUT." + ], + "result": "Both independent guard-removal mutations caught; each child exits 1.", + "log": "/tmp/orca-root-0007-mutations.log" + } + ], + "important_retained_boundaries": [ + "Shipped Actions node24/main/post/always metadata and caller inputs determine external runner behavior, so these metadata contract tests remain.", + "Docs media links are discovered from current content and checked against actual public assets. GIF helpers return independently expected URLs with matching files. Required fonts and licensing notices remain checked.", + "Formatter tables preserve escapes, malformed tags/brackets, highlighted matches and code. Long malformed inputs run the actual function under a VM deadline." + ], + "limitations": [ + "No product runtime or wire behavior changes. macOS/Windows native paths are not involved in this batch; VM deadlines and path operations use Node cross-platform APIs.", + "Action source self-containment and one metadata-host literal scan were removed; README no longer claims the test enforces artifact independence.", + "Docs source-text, layout/style and historical filename blacklists were removed. Passing retained unit tests does not establish every deployed route or visual behavior. Real docs build is covered by CI; no new UI validation is claimed.", + "This is a completed three-file batch; archived proof files are separately reviewed and recorded in later batches. Supporting reads here do not establish their completion." + ] +} diff --git a/docs/audits/test-value/reviews/root-0007.jsonl b/docs/audits/test-value/reviews/root-0007.jsonl new file mode 100644 index 00000000000..4e293fdab90 --- /dev/null +++ b/docs/audits/test-value/reviews/root-0007.jsonl @@ -0,0 +1,3 @@ +{"path":".github/actions/cloud-sql-rollout-lease/action-contract.test.mjs","sha256":"854ccd6d3fd2f71e230368c584df88c1a1393fdc5505fe2a4d4f0c666499bb88","reviewer":"root","evidence":[".github/actions/cloud-sql-rollout-lease/action.yml",".github/actions/cloud-sql-rollout-lease/main.mjs",".github/actions/cloud-sql-rollout-lease/post.mjs",".github/actions/cloud-sql-rollout-lease/gcloud-access-token.mjs",".github/actions/cloud-sql-rollout-lease/storage-lease.test.mjs"],"cases":[{"line":10,"title":"is a node24 JavaScript action with an always-run post step","decision":"keep","reason":"Actions interprets this shipped metadata: the entrypoint and unconditional post lifecycle determine whether owned leases are released on failure/cancel."},{"line":19,"title":"declares the inputs the wave-chain callers depend on","decision":"keep","reason":"The external action input contract supplies run identity and default release behavior to independent workflow callers."},{"line":27,"title":"stays self-contained so it can be duplicated into the public repo","decision":"remove","reason":"Shallow regex import and directory inventories do not establish runnable artifact independence; dynamic imports and runtime resolution escape the scan."},{"line":46,"title":"never reaches for the GCE metadata server","decision":"remove","reason":"Scanning for one host literal does not establish the authentication path; actual token-source behavior is covered by the separately reviewed storage suite."}],"source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewed_sha256":"711d8a6d0afc2dcaaf8f233c2894685bb3e72481d62722be05ccc8261372e324","status":"reviewed","decision":"consolidate","rationale":"Retain Actions lifecycle/input metadata while removing shallow import/host source scans."} +{"path":"docs/site/tests/docs-package.test.mjs","sha256":"6bf5305dbf19474175c2e6d9918c257616ba45525f74e25ccb0cdbd0893d1559","reviewer":"root","evidence":["docs/site/package.json","docs/site/source.config.ts","docs/site/src/lib/source.ts","docs/site/src/lib/demoMedia.mjs","docs/site/src/lib/docs-og-image.tsx","docs/site/THIRD_PARTY_NOTICES.md","docs/site/next.config.ts","docs/site/versioning.config.ts"],"cases":[{"line":43,"title":"docs package has an isolated, reproducible app contract","decision":"remove","reason":"Copied manifest, dependency and pinned version inventory is already exercised by frozen dependency installation and the real docs build."},{"line":68,"title":"all customer-facing docs pages and navigation metadata are present","decision":"fix","reason":"Retain nonempty content/navigation discovery and per-file metadata validation; remove minimum counts and copied page inventory that reject intentional content changes."},{"line":104,"title":"every local media URL referenced by docs resolves in public assets","decision":"keep","reason":"Discover actual referenced media from current docs and check the published asset tree, catching broken customer URLs independently of a copied list."},{"line":125,"title":"docs content does not link to routes that only exist on the marketing site","decision":"fix","reason":"Retain deployment-boundary link checks and require nonempty discovery so missing content cannot pass vacuously."},{"line":135,"title":"published docs do not retain private source provenance","decision":"remove","reason":"Historical provenance strings are a small source blacklist rather than a general publication boundary; arbitrary renamed material passes."},{"line":151,"title":"reviewed private demo media stays outside the publication boundary","decision":"remove","reason":"Three copied historical filenames do not establish whether current published assets are private; intentional content changes otherwise need test edits."},{"line":161,"title":"docs routes stay namespaced and the generated source uses /docs as its base URL","decision":"remove","reason":"Large source-regex and file inventories mix routing, styling and layout implementation; actual namespaced behavior belongs to the built app verification."},{"line":211,"title":"GIF media helpers use the shared poster and video variants","decision":"fix","reason":"Retain helper output and real referenced asset checks; remove unrelated whats-new directory absence inventory."},{"line":225,"title":"versioning seam keeps current docs stable without claiming live versioned routes","decision":"remove","reason":"Checks future scaffold literals and README phrasing instead of calling the version path function or resolving deployed routes."},{"line":239,"title":"OG image fonts ship with their required third-party notice","decision":"fix","reason":"Retain required binary font and license publication assets; remove source-style regex unrelated to font availability."},{"line":254,"title":"docs app has no marketing-only route or analytics dependency","decision":"remove","reason":"Scanning source imports and two directory names is an incomplete dependency/route blacklist rather than observed behavior."}],"source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewed_sha256":"9bd380102a154119728c1c4a1fbbcc877b6fd4a1f22fdc307dcdad3f8ce26c31","status":"reviewed","decision":"consolidate","rationale":"Retain discovered content, deployment links, media helper outputs and font/license assets; trim copied manifest/page/source/style inventories and add nonempty discovery guards."} +{"path":"docs/site/tests/search-excerpt.test.mjs","sha256":"0f0fe3753174cf76f27e443dcb710a67cadf388a6bead9b0c926a974d01abbc5","reviewer":"root","evidence":["docs/site/src/components/docs/search-excerpt.mjs","docs/site/src/components/docs/SearchDialog.tsx"],"cases":[{"line":6,"title":"unterminated escaped link destinations do not backtrack exponentially","decision":"keep","reason":"The real formatter runs on long malformed link destinations under a VM deadline, with independent expected text."},{"line":20,"title":"link destinations retain escaped closing parentheses and literal escapes","decision":"keep","reason":"Input/output tables protect distinct escaping and destination-parsing cases."},{"line":30,"title":"search excerpts omit inline Markdown syntax","decision":"keep","reason":"Observed formatter output protects customer excerpt rendering for common Markdown syntax."},{"line":39,"title":"search excerpts preserve highlighted matches inside Markdown","decision":"keep","reason":"Actual mixed code/highlight/link outputs protect token preservation and nested stripping order."},{"line":63,"title":"unclosed angles avoid the HTML matcher without changing excerpt text","decision":"fix","reason":"Replace global replace monkeypatch and exact regex-source spy with bounded execution of a long unclosed-angle input; disabling the production guard must time out."},{"line":81,"title":"tag guards preserve malformed markup, protected code and highlighted matches","decision":"keep","reason":"Distinct malformed markup, code, highlight and link tables specify actual output independently."},{"line":111,"title":"unclosed brackets avoid link matchers without changing excerpt text","decision":"fix","reason":"Replace internal regex spy with bounded actual formatter execution on long unclosed brackets; disabling the production guard must time out."}],"source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewed_sha256":"331358ef182ec591c9502f760c73ac87f7d0554924785ab1b1c30d7308b49984","status":"reviewed","decision":"fix","rationale":"Replace implementation spies with bounded actual formatter execution."} diff --git a/docs/audits/test-value/reviews/root-0008-validation.json b/docs/audits/test-value/reviews/root-0008-validation.json new file mode 100644 index 00000000000..94901d1ff92 --- /dev/null +++ b/docs/audits/test-value/reviews/root-0008-validation.json @@ -0,0 +1,33 @@ +{ + "batch": "root-0008", + "reviewer": "root", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "platform": "Linux", + "reviewed_files": 5, + "original_declaration_sites": 0, + "manual_assertion_groups": 5, + "production_changes": false, + "review_scope": "Read all five original scripts/support modules and relevant actual auth operation/waiter, CDP writer/queue and task tracker/frame/retention/string-owner bodies. Narrow batch from earlier pending archive notes; other archive candidates remain unreviewed.", + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node --expose-gc docs/audits/claude-task-retention/reproduce.cjs", + "result": "Passed all 36 before/after GC arms with baseline sensitivity and fixed/cleanup thresholds.", + "log": "/tmp/orca-root-0008-task-proof.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node docs/audits/cdp-stream-retention/reproduce.mjs", + "result": "Completed 128 MiB manual measurement with eight samples and cleanup. No assertion-bearing test pass is claimed.", + "log": "/tmp/orca-root-0008-cdp-measurement.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node --expose-gc docs/audits/auth-filesystem-wait-retention/reproduce.cjs /tmp/orca-root-0008-auth-results.json", + "result": "Exit 1 before phases: intentional reverse-patch source guard rejects evolved promise-settlement-waiters.ts. Retained as archived proof, not a current-head passing suite.", + "log": "/tmp/orca-root-0008-auth-proof.log" + } + ], + "limitations": [ + "No production, UI, wire or platform behavior changes. These measurements ran on Linux Node; no Electron or cross-platform memory result is claimed.", + "Archived auth proof requires its matching source graph; old before/after results are historical evidence. It was not rewritten to accept a different graph.", + "This review classifies five standalone/support files only. Other root-0008 pending-note candidates still require full review and records." + ] +} diff --git a/docs/audits/test-value/reviews/root-0008.jsonl b/docs/audits/test-value/reviews/root-0008.jsonl new file mode 100644 index 00000000000..1369861a84a --- /dev/null +++ b/docs/audits/test-value/reviews/root-0008.jsonl @@ -0,0 +1,5 @@ +{"path":"docs/audits/auth-filesystem-wait-retention/reproduce.cjs","sha256":"2208bd827a1a0777b9686b18d36ae0af4a34897479fd07187e239a91af54bff2","reviewed_sha256":"2208bd827a1a0777b9686b18d36ae0af4a34897479fd07187e239a91af54bff2","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-before-after-gc-proof","rationale":"Preserve historical assertion-bearing proof and its deliberate source fences. It bundles actual before/after auth operations and verifies retained references, cancellation and settlement semantics; it is not a current-head CI suite. Current execution correctly rejects upstream source drift, which must not be disguised as a pass or bypassed.","evidence":["docs/audits/auth-filesystem-wait-retention/sources.cjs","docs/audits/auth-filesystem-wait-retention/settlement-order.cjs","src/main/rate-limits/auth-filesystem-operation.ts","src/shared/promise-settlement-waiters.ts"],"cases":[{"line":52,"title":"retention(false/true): 128 abandoned waits at unresolved, settled and dropped stages","decision":"keep","reason":"Weak references, actual abort listener counts and late raw settlement distinguish detached caller objects from an unresolved shared operation. Plain/amplified arms assert candidate reason retention, settled one-reason retention and complete release after owner drop. Controller/payload counts before drop are measurements, not extra collection guarantees.","expanded_arms_per_phase":2},{"line":84,"title":"controls: result delivery, cancellation reasons, admission and sibling survival","decision":"keep","reason":"Actual operation calls and promise settlements verify one raw call, late/settled delivery, raw rejection identity, pre-aborted refusal, four falsy/custom reasons, abort listener removal and a surviving live waiter. Controlled raw promises model an already-started local operation; no natural filesystem stall is claimed."},{"line":217,"title":"before/after settlement-order parity and source provenance","decision":"keep","reason":"The imported settlement-order table uses two wait-start positions, two raw outcomes and six microtask positions (24 per phase); compares full outcomes from independently bundled source variants, records imported hashes, and enforces an outer 15-second deadline.","settlement_order_arms_per_phase":24}],"execution":"Rejected source drift in src/shared/promise-settlement-waiters.ts before phases ran; no current proof pass claimed."} +{"path":"docs/audits/auth-filesystem-wait-retention/sources.cjs","sha256":"115aced3091797efe36bb8814faf88c0822d4168b317473f4867128a59e6dd16","reviewed_sha256":"115aced3091797efe36bb8814faf88c0822d4168b317473f4867128a59e6dd16","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-proof-source-loader","rationale":"Exact reverse patch and recorded baseline SHA-256 bind an archive comparison to its documented source. Its failure on evolved source is an intentional provenance guard; retain without weakening it.","evidence":["docs/audits/auth-filesystem-wait-retention/fix.patch","docs/audits/auth-filesystem-wait-retention/source-versions.json"],"cases":[],"execution":"Source-fence rejection observed from the real proof entrypoint."} +{"path":"docs/audits/auth-filesystem-wait-retention/settlement-order.cjs","sha256":"7648792560e1840df44da64bfd15ec88a4ce38b9c70f686a965788ae014956c9","reviewed_sha256":"7648792560e1840df44da64bfd15ec88a4ce38b9c70f686a965788ae014956c9","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"manual-proof-parameter-table","rationale":"Support table executes real shared-operation waits with controlled raw settlement and abort scheduling; caller compares returned outcomes across old/new sources. It does not implement production settlement selection.","evidence":["docs/audits/auth-filesystem-wait-retention/reproduce.cjs","src/main/rate-limits/auth-filesystem-operation.ts"],"cases":[{"line":3,"title":"2 wait positions x 2 raw outcomes x 6 microtask delays","decision":"keep","reason":"Each of 24 combinations creates its own actual operation and attaches fulfillment/rejection observers, then records the actual winner. Keep as archival parity support; current source fence prevents execution.","expanded_rows":24}]} +{"path":"docs/audits/cdp-stream-retention/reproduce.mjs","sha256":"f9e5f6c91d19427f959ed3cce60fe1d186b534d933e7dbf38cbc4d218a044379","reviewed_sha256":"f9e5f6c91d19427f959ed3cce60fe1d186b534d933e7dbf38cbc4d218a044379","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"manual-measurement-benchmark","rationale":"Preserve useful manual measurements from the real bundled CDP writer and a real paused loopback WebSocket. It emits socket/RSS samples without behavioral assertions or a bound, so successful exit is a completed measurement and not an automated test pass. Automated behavior lives in cdp-client-response-writer.test.ts.","evidence":["src/main/browser/cdp-client-response-writer.ts","src/shared/ws-outbound-backpressure-queue.ts","src/main/browser/cdp-client-response-writer.test.ts"],"cases":[],"execution":"Completed Linux Node v26.8.1 measurement: 128 x 1 MiB events, eight samples; writer terminated stalled socket at queue cap. No RSS threshold or natural incident attribution claimed.","automated_test_cases":0} +{"path":"docs/audits/claude-task-retention/reproduce.cjs","sha256":"a06b6373a26ff3faee61068aa60bce4dbcd358c2fa5adc5864063a77ee7720e7","reviewed_sha256":"a06b6373a26ff3faee61068aa60bce4dbcd358c2fa5adc5864063a77ee7720e7","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"manual-before-after-gc-proof","rationale":"Keep actual task tracker/reader GC proof: the baseline removes only the production retained-string copy, not a copied tracker implementation. Covers live, settled and recently-removed task ownership under three ingress shapes, and verifies cleanup. This is a manual Node/V8 memory proof rather than routine unit CI.","evidence":["src/main/claude/claude-background-task-tracker.ts","src/main/claude/claude-background-task-frames.ts","src/main/claude/claude-settled-background-tasks.ts","src/shared/own-retained-string.ts"],"cases":[{"line":126,"title":"2 count/size choices x 3 ingress shapes x 3 retention states x before/after","decision":"keep","reason":"All 36 arms use actual producer frames. Baseline must retain at least 75% of the parent bytes; fixed owner must retain under 1 MiB, and every arm must release under 1 MiB after clear. Description field only; visibleTextChars is measured and does not assert content parity or coverage of other fields.","expanded_arms":36}],"execution":"All 36 asserted arms passed on Linux Node v26.8.1 with --expose-gc. Max fixed retained heap 88,664 bytes; min baseline retained heap 2,108,136 bytes; max after-clear delta 42,744 bytes."} diff --git a/docs/audits/test-value/reviews/root-0009-validation.json b/docs/audits/test-value/reviews/root-0009-validation.json new file mode 100644 index 00000000000..01863e37293 --- /dev/null +++ b/docs/audits/test-value/reviews/root-0009-validation.json @@ -0,0 +1,33 @@ +{ + "batch": "root-0009", + "reviewer": "root", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "reviewed_files": 5, + "original_declaration_sites": 4, + "manual_driver_groups": 2, + "production_changes": false, + "review_scope": "Read all original three proof candidates plus source loader/config. Cross-check actual permanent destroyed-guest suite/fixture, registration-ownership suite, session/recovery/registry, dispatcher/cache and composition/native ownership boundaries. Permanent suite reads are evidence only and are not separately promoted to reviewed by this batch.", + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node docs/audits/browser-registration-reply-retention/reproduce.mjs", + "result": "Exit 1 at intentional reverse-patch fence: production browser-page-webview-guest-session.ts changed. No phases ran.", + "log": "/tmp/orca-root-0009-registration-proof.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node docs/audits/browser-destroyed-guest-retention/reproduce.mjs", + "result": "Exit 1 during esbuild launcher setup: historical run-process.ts module was removed upstream. No phases ran.", + "log": "/tmp/orca-root-0009-destroyed-proof.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node -e 'require(\"./docs/audits/browser-closed-result-retention/sources.cjs\").loadSources()'", + "result": "Exit 1: actual loader rejects changed browser-client-host-command-state.ts caller hash. Hash-fenced suite not executed.", + "log": "/tmp/orca-root-0009-closed-source.log" + } + ], + "limitations": [ + "These are explicitly archived source-bound proofs/support, preserved unchanged. Their historical results do not establish current-head runtime behavior.", + "No UI, native guest, subprocess proof phase, external host or app window was launched. No cross-platform/native memory result is claimed.", + "Current-head permanent suites remain separate audit candidates even where read as evidence.", + "Acknowledged-tab, branch/history and editor lifetime files in pending archive notes remain unreviewed." + ] +} diff --git a/docs/audits/test-value/reviews/root-0009.jsonl b/docs/audits/test-value/reviews/root-0009.jsonl new file mode 100644 index 00000000000..4d5cb05d007 --- /dev/null +++ b/docs/audits/test-value/reviews/root-0009.jsonl @@ -0,0 +1,5 @@ +{"path":"docs/audits/browser-closed-result-retention/scenario.test.mjs","sha256":"93a44e2b2583f397d5c08d29d9de3e1413a9185b893264bf4d468276d8d13ed5","reviewed_sha256":"93a44e2b2583f397d5c08d29d9de3e1413a9185b893264bf4d468276d8d13ed5","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-hash-fenced-gc-suite","rationale":"Preserve a bounded historical actual-source proof with four meaningful lifecycle/source-portability cases. Uses real dispatcher, executor, automation descriptor, native-navigation wrapper and composition, with controlled native promises. Its exact caller/source graph has evolved; source loader currently rejects drift before any cases run. No current test pass or natural incident attribution claimed.","evidence":["docs/audits/browser-closed-result-retention/sources.cjs","docs/audits/browser-closed-result-retention/vitest.config.mjs","src/main/browser/browser-client-host-command-dispatcher.ts","src/main/browser/browser-client-host-command-result-cache.ts","src/main/browser/browser-client-page-command-executor-test-harness.ts","src/main/browser/browser-client-page-automation-runtime.ts","src/main/browser/browser-route-guest-lifecycle.ts","src/main/browser/paired-runtime-browser-client-host-teardown.ts"],"cases":[{"line":93,"title":"keeps completed actual automation results behind one pending native navigation after close timeout","decision":"keep","reason":"Thirty-two real automation result objects observed only by WeakRef distinguish closed result-cache retention from native handler custody. Checks canceled queued input, abort/closed admission, repeat close and pending whenClosed, then resolves native port in finally and verifies actual route/session release. The 15ms join is intentional timed-boundary coverage, not an arbitrary sleep."},{"line":234,"title":"does not retain late completed cancellation records while a sibling native handler remains owned","decision":"keep","reason":"Settles one actual controlled handler after close while another remains pending; checks late record/cache eviction and unsettled dispatcher, then rejects sibling and checks final cleanup. Covers a distinct late-settlement retaining path."},{"line":282,"title":"preserves open replay and generation fencing independently of closed cache release","decision":"keep","reason":"Observes actual Promise identity, one handler invocation, stale-generation refusal and explicit forget release; it does not infer duplicate delivery from a capability flag."},{"line":318,"title":"loads identical canonical hashes from synthetic CRLF source and patch reads","decision":"keep","reason":"Injected filesystem reads supply actual CRLF source/patch bytes to the real loader, comparing reconstructed before/after graphs and canonical hashes. This tests archive portability rather than copied production text."}],"execution":"Not run: actual source loader rejects changed browser-client-host-command-state.ts caller hash before suite setup. Existing recorded results are historical."} +{"path":"docs/audits/browser-closed-result-retention/sources.cjs","sha256":"9d05c182b2052265dae299ae328d1db039168bbd84608a1a6f8ad5f9df75fbbc","reviewed_sha256":"9d05c182b2052265dae299ae328d1db039168bbd84608a1a6f8ad5f9df75fbbc","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-proof-source-loader","rationale":"Keep canonical-LF reverse patch plus before/fixed/caller hash fences. The four-case suite includes a real CRLF read control. Changed caller hashes must be reviewed against the archived graph rather than silently accepted.","evidence":["docs/audits/browser-closed-result-retention/fix.patch","docs/audits/browser-closed-result-retention/source-versions.json","docs/audits/browser-closed-result-retention/scenario.test.mjs"],"cases":[]} +{"path":"docs/audits/browser-closed-result-retention/vitest.config.mjs","sha256":"b85dd0f517b27434995e63088fab1ff22f0e8815791fc4fa440f2d6ab298ef06","reviewed_sha256":"b85dd0f517b27434995e63088fab1ff22f0e8815791fc4fa440f2d6ab298ef06","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-proof-runner-configuration","rationale":"Non-test support loads the hash-fenced source variants at actual production module IDs and restricts suites/workers. Source transforms do not duplicate production semantics. Preserve with its matching historical graph; current caller drift prevents startup.","evidence":["docs/audits/browser-closed-result-retention/sources.cjs","config/vitest.config.ts"],"cases":[]} +{"path":"docs/audits/browser-destroyed-guest-retention/reproduce.mjs","sha256":"8a9b3316089cdae9409a6375b29a0a9f51742e2f78cd4558b4ab6a9027cf2752","reviewed_sha256":"8a9b3316089cdae9409a6375b29a0a9f51742e2f78cd4558b4ab6a9027cf2752","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-before-after-driver","rationale":"Keep the historical exact-boundary mutation runner. It transforms the real destruction guard and augments the actual nine-case regression suite with map-count observations, with bounded child work and finally cleanup. Main has since removed the referenced run-process.ts launcher, so it is not a current-head runnable validation command. Do not replace the historical source graph or claim pass.","evidence":["src/main/browser/browser-manager-destroyed-guest.test.ts","src/main/browser/browser-manager-destroyed-guest-test-fixture.ts","src/main/browser/browser-manager-guest-navigation-policy.ts","src/main/browser/browser-manager-state.ts","src/main/browser/browser-manager-registration.ts","src/main/browser/browser-manager-download-lifecycle.ts"],"cases":[{"line":132,"title":"before/after destruction-guard mutation with 1000-guest callback observations","decision":"keep","reason":"Actual manager regressions require expected baseline failures and fixed successes plus callback retention counts. EventEmitter guest ports control lifecycle only; manager registration/cleanup maps own observations. Script records child exit codes but its pass expression checks reports/counts, so no stronger exit/timeout guarantee is asserted here."}],"execution":"Exit 1 during bundle setup: historical src/shared/child-process/run-process.ts no longer exists; no before/after cases ran."} +{"path":"docs/audits/browser-registration-reply-retention/reproduce.mjs","sha256":"7dcc15e63d1fdc16866240e0dbf96ab0532ebc7115cda78399d879c11f7d0221","reviewed_sha256":"7dcc15e63d1fdc16866240e0dbf96ab0532ebc7115cda78399d879c11f7d0221","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-before-after-driver","rationale":"Keep the historical in-memory reverse-patch driver and actual registration-ownership regressions. It compares retained closed IDs and unregister accounting under deferred IPC replies. Production session source has changed, and its explicit patch fence currently rejects that drift; rewriting the archive to a different source graph would erase its provenance.","evidence":["src/renderer/src/components/browser-pane/host-guest/browser-page-registration-ownership.test.ts","src/renderer/src/components/browser-pane/host-guest/browser-page-webview-guest-session.ts","src/renderer/src/components/browser-pane/host-guest/browser-page-guest-recovery.ts","src/renderer/src/components/browser-pane/host-guest/webview-registry.ts","docs/audits/browser-registration-reply-retention/fix.patch"],"cases":[{"line":119,"title":"before/after late-registration mutation with 1000 closed guest IDs","decision":"keep","reason":"Real session/recovery/registry suite covers closed owners, replacements, same-element remounts, current hidden/inconclusive replies and repair ownership. Count observer augments its existing assertion rather than implementing registry behavior. Pass expression checks expected report/counts, while exit codes are observations only."}],"execution":"Exit 1 at reverse-patch fence for browser-page-webview-guest-session.ts before child setup; no current-head proof pass claimed."} diff --git a/docs/audits/test-value/reviews/root-0010-validation.json b/docs/audits/test-value/reviews/root-0010-validation.json new file mode 100644 index 00000000000..4587d7aa97f --- /dev/null +++ b/docs/audits/test-value/reviews/root-0010-validation.json @@ -0,0 +1,23 @@ +{ + "batch": "root-0010", + "reviewer": "root", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "reviewed_files": 4, + "original_declaration_sites": 4, + "manual_control_groups": 2, + "production_changes": false, + "review_scope": "Read every lifecycle case, fixture/table, loader control and source-overlay body. Cross-check actual current model bridge, shell cleanup hook, disposal controller and legacy surface. The archived graph is intentionally different from evolved current product behavior.", + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 ORCA_CLOSED_MODEL_LOADER_OUTPUT=/tmp/orca-root-0010-loader-results.json node docs/audits/closed-editor-model-lifetime/loader-controls.cjs", + "result": "Exit 1 at intentional dependency hash fence for node_modules/zustand/package.json. No controls or lifecycle cases ran; no current-head pass claimed.", + "log": "/tmp/orca-root-0010-loader.log" + } + ], + "limitations": [ + "Files retained unchanged as explicitly archived actual-source proofs/support. Historical Node/Electron results are not new validation.", + "The source/dependency graph must match its manifest to reproduce. No hash weakening, dependency downgrade, app window, native Monaco widget or rendered UI check was performed.", + "Monaco logical character counts and disposal identities do not establish native allocation size or incident memory growth.", + "Permanent current-head editor tests remain separate audit candidates." + ] +} diff --git a/docs/audits/test-value/reviews/root-0010.jsonl b/docs/audits/test-value/reviews/root-0010.jsonl new file mode 100644 index 00000000000..644cfe5df77 --- /dev/null +++ b/docs/audits/test-value/reviews/root-0010.jsonl @@ -0,0 +1,4 @@ +{"path":"docs/audits/closed-editor-model-lifetime/lifecycle.test.mjs","sha256":"afc0b7e45e056d1f730ac58f266094471b58187646c91b4436b909544a3a4e29","reviewed_sha256":"afc0b7e45e056d1f730ac58f266094471b58187646c91b4436b909544a3a4e29","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-hash-fenced-lifecycle-suite","rationale":"Preserve four meaningful actual-store/model lifetime scenarios from a named historical source graph. Installed Monaco creates real models; shell/panel bodies are explicit ports and cleanup uses actual surface/store/hook paths. This is model disposal identity evidence, not native editor behavior or heap/RSS. Current dependency/source fences prevent startup against evolved code; no current-head pass claimed.","evidence":["docs/audits/closed-editor-model-lifetime/sources.cjs","docs/audits/closed-editor-model-lifetime/vitest.config.mjs","src/renderer/src/lib/editor-model-registry.ts","src/renderer/src/components/editor/useClosedEditorTabCleanup.ts","src/renderer/src/components/editor/closed-editor-tab-controller.ts","src/renderer/src/components/editor/closed-editor-tab-disposal.ts","src/renderer/src/components/TerminalLegacyEditorSurface.tsx","src/renderer/src/store/slices/store-test-helpers.ts"],"cases":[{"line":142,"title":"measures distinct last-file closes when the final editor removes the panel","decision":"keep","reason":"Eight distinct actual Monaco models and real Store close actions expose the last-editor panel-unmount lifetime. Asserts both panel/store removal and remaining model count after a microtask; seeded paths/256KiB content are bounded fixtures, not field measurements."},{"line":163,"title":"disposes a closed model while another file keeps the panel mounted","decision":"keep","reason":"Actual model identities distinguish closed-model disposal from the independent live sibling that keeps the panel mounted. Positive sibling control rules out disposing all models."},{"line":180,"title":"measures a close while hidden followed by another editor remount","decision":"keep","reason":"Hides the real legacy surface before actual file close, then opens another model and remounts; checks old model disposal and total current models. Exercises hidden cleanup without equating a normal unmount with closure."},{"line":202,"title":"preserves a still-open model across a normal panel unmount and remount","decision":"keep","reason":"Checks the same actual open model survives hiding and remains the registry instance after remount. It controls the false repair of unconditional model disposal."}]} +{"path":"docs/audits/closed-editor-model-lifetime/loader-controls.cjs","sha256":"4cdcf0309ff0acce00cff5f5b17ce91236f5eaa27245de65c651dd4c6535a352","reviewed_sha256":"4cdcf0309ff0acce00cff5f5b17ce91236f5eaa27245de65c651dd4c6535a352","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-source-loader-controls","rationale":"Keep explicit source-graph portability and drift controls for this historical proof. They test loader reconstruction rather than copied editor behavior. Current installed Zustand package hash differs from the recorded manifest, so loader rejects before these controls run; do not rewrite the manifest to bypass provenance.","evidence":["docs/audits/closed-editor-model-lifetime/sources.cjs","docs/audits/closed-editor-model-lifetime/source-versions.json","docs/audits/closed-editor-model-lifetime/main-context.patch"],"cases":[{"line":15,"title":"2 historical graphs x 2 variants with LF/CRLF/publication read ports","decision":"keep","reason":"Compares actual loader-reconstructed hashes for normal reads, CRLF source reads and a virtual published checkout, across all four graph/variant combinations. Keep as archive reconstruction support."},{"line":43,"title":"reject a deliberately changed fixed source graph","decision":"keep","reason":"Injects actual changed setup bytes and requires loader rejection. The adjacent alias string check establishes historical context composition only; it is not an editor-alias runtime test."}]} +{"path":"docs/audits/closed-editor-model-lifetime/sources.cjs","sha256":"d5914770eb9db3c75b153b55d7f2f94415d3ab1850bc5b021be1165d104828be","reviewed_sha256":"d5914770eb9db3c75b153b55d7f2f94415d3ab1850bc5b021be1165d104828be","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-proof-source-loader","rationale":"Non-test support validates dependencies, source variants, exact forward/reverse patches and historical main/worktree context before yielding module contents. Canonical LF permits CRLF checkouts while all hashes stay fenced. Retain as archive provenance rather than adapt old source hashes to current behavior.","evidence":["docs/audits/closed-editor-model-lifetime/source-versions.json","docs/audits/closed-editor-model-lifetime/fix.patch","docs/audits/closed-editor-model-lifetime/main-context.patch","docs/audits/closed-editor-model-lifetime/loader-controls.cjs"],"cases":[]} +{"path":"docs/audits/closed-editor-model-lifetime/vitest.config.mjs","sha256":"bfe98cdc66445e31801a9b64f698f158110dc7a8b1ec8f92ef7f99a5fb296444","reviewed_sha256":"bfe98cdc66445e31801a9b64f698f158110dc7a8b1ec8f92ef7f99a5fb296444","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-proof-runner-configuration","rationale":"Non-test support resolves named source overlays and rejects unfenced repository imports, then runs only the historical four-case headless DOM suite with one worker. This source closure prevents accidental current-source mixing. Current dependency drift correctly stops it before tests.","evidence":["docs/audits/closed-editor-model-lifetime/sources.cjs","docs/audits/closed-editor-model-lifetime/lifecycle.test.mjs","config/vitest.config.ts"],"cases":[]} diff --git a/docs/audits/test-value/reviews/root-0011-validation.json b/docs/audits/test-value/reviews/root-0011-validation.json new file mode 100644 index 00000000000..d18d951b50e --- /dev/null +++ b/docs/audits/test-value/reviews/root-0011-validation.json @@ -0,0 +1,39 @@ +{ + "batch": "root-0011", + "reviewer": "root", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "reviewed_files": 2, + "original_declaration_sites": 9, + "manual_driver_groups": 1, + "case_decisions": { + "keep": 9, + "fix": 1 + }, + "production_changes": false, + "review_scope": "Read complete permanent source-budget fixture and all nine bodies, archival driver, actual current history collector/reader, branch proof/replay and bounded-file reader. Current history uses two streaming ancestry passes; archival proof describes the earlier one-read contract.", + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node config/scripts/run-vitest.mjs run --config config/vitest.config.ts src/main/claude/claude-history-window-source-budget.test.ts", + "result": "9 tests passed, zero skips/failures.", + "log": "/tmp/orca-root-0011-history-suite.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node docs/audits/claude-history-window-budget/reproduce.mjs", + "result": "Exit 1 at intentional reverse-patch source fence for claude-structured-history-window.ts; archival phases not run.", + "log": "/tmp/orca-root-0011-history-proof.log" + }, + { + "command": "pnpm exec oxfmt --check src/main/claude/claude-history-window-source-budget.test.ts", + "result": "Passed." + }, + { + "command": "pnpm exec oxlint src/main/claude/claude-history-window-source-budget.test.ts", + "result": "Passed, no diagnostics." + } + ], + "limitations": [ + "Only test wording/comment changed; no assertion, file/protocol/runtime behavior changed. Shared Node path/file APIs preserve cross-platform scope; local validation was Linux.", + "Largest stream chunk is not a retained-memory, heap, RSS or leak measurement. Existing real source/descriptor/prompt/growth/error assertions are retained.", + "Branch-proof streaming archives remain unreviewed and are excluded from this batch, even though their entrypoint drift was inspected." + ] +} diff --git a/docs/audits/test-value/reviews/root-0011.jsonl b/docs/audits/test-value/reviews/root-0011.jsonl new file mode 100644 index 00000000000..61fa3d477b5 --- /dev/null +++ b/docs/audits/test-value/reviews/root-0011.jsonl @@ -0,0 +1,2 @@ +{"path":"src/main/claude/claude-history-window-source-budget.test.ts","sha256":"be03c827e7cfba7dc2bf73737ec333b58fedfa977c0ddf80884af11cce554539","reviewed_sha256":"9b0cce04e523d73270911fdbb1a2446c5208d0f1d218352432d77d876b768f5c","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"fix","classification":"current-unit-regression-suite","rationale":"Retain actual file/stream/proof/replay boundary coverage and correct one unsupported resident-memory claim to the measured chunk-size property. No assertion or production behavior changed.","evidence":["src/main/claude/claude-structured-history-window.ts","src/main/claude/claude-transcript-branch-proof.ts","src/shared/node-bounded-file-reader.ts"],"cases":[{"line":152,"title":"reads a stable history without changing prompt evidence","decision":"keep","reason":"Actual transcript file and actual history reader retain the expected latest provider item and consistent boundary."},{"line":158,"title":"streams two passes over one descriptor rather than one whole-file read","decision":"keep","reason":"Real FileHandle/stream wrappers observe one open, two stream passes and twice the source bytes. The fixture does not implement history selection or replay."},{"line":166,"title":"opens no second pass when nothing followed the anchor","decision":"keep","reason":"Retains the valid anchor marker while removing only the later record, so empty output is a proven consistent boundary rather than a torn/unprovable transcript."},{"line":184,"title":"resolves a source past the legacy whole-file limit instead of refusing it","decision":"keep","reason":"Actual valid JSONL larger than 16 MiB must return the latest history item and read beyond the old total-file bound."},{"line":197,"title":"keeps resident bytes bounded by the chunk size, not the file size","decision":"fix","reason":"Rename to the actual observed property: reads a large history in chunks smaller than 1 MiB. peakChunkBytes measures individual stream chunks, not resident or retained heap; preserve the assertion and correct the comment rather than claiming a memory bound it cannot prove."},{"line":204,"title":"refuses a single record too large to frame","decision":"keep","reason":"A real oversized JSONL record exercises the per-record framer bound independently of the accepted large total file."},{"line":212,"title":"replays a concurrent repair at the grown size, not the pinned one","decision":"keep","reason":"Injects real file growth after descriptor stat, completing a torn record. Latest+grown item identities, three passes and one descriptor establish the retried proof and replay observe the same repaired snapshot."},{"line":237,"title":"preserves the inconsistent result on a read error","decision":"keep","reason":"The actual opened read stream is destroyed with a controlled error; result must remain inconsistent, with afterEach checking every opened handle closes."},{"line":242,"title":"does not open a source without an anchor","decision":"keep","reason":"Actual reader must reject the unproven boundary before opening/reading any transcript; this is an admission property with observed filesystem effects."}]} +{"path":"docs/audits/claude-history-window-budget/reproduce.mjs","sha256":"f7ce76164924bc9272af0d199f5698f44030252768f4287ae839f0c6b7d42630","reviewed_sha256":"f7ce76164924bc9272af0d199f5698f44030252768f4287ae839f0c6b7d42630","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-before-after-driver","rationale":"Preserve historical reverse-patch proof with real files, post-stat growth injection, original seven-case source-budget suite, process outcome checks and finally cleanup. Production history now uses two streaming ancestry passes and the permanent suite has nine cases; current exact patch fence correctly rejects the old graph. Historical evidence is not a current-head passing validation.","evidence":["docs/audits/claude-history-window-budget/fix.patch","src/main/claude/claude-history-window-source-budget.test.ts","src/main/claude/claude-structured-history-window.ts","src/shared/node-bounded-file-reader.ts","src/main/claude/claude-transcript-branch-proof.ts"],"cases":[{"line":128,"title":"historical source-budget before/after comparison","decision":"keep","reason":"Checks exactly one expected baseline failure, six baseline controls and seven fixed successes, both child exit codes and no timeouts. Source transforms run actual reader modules; current source drift prevents phases and must not be bypassed."}]} diff --git a/docs/audits/test-value/reviews/root-0012-validation.json b/docs/audits/test-value/reviews/root-0012-validation.json new file mode 100644 index 00000000000..17de2641f6c --- /dev/null +++ b/docs/audits/test-value/reviews/root-0012-validation.json @@ -0,0 +1,32 @@ +{ + "batch": "root-0012", + "reviewer": "root", + "source_commit": "8d94ed06570adb2b7300cf16fe9f43b4680e3f2b", + "reviewed_files": 8, + "original_declaration_sites": 0, + "manual_case_records": 96, + "production_changes": false, + "review_scope": "Read complete eight archive source/driver/support files, every static fixture and expanded table, transform/provenance and actual current branch graph/reader/framer. Read current resolver, recovery and history suites as supporting evidence; do not mark those permanent files reviewed here. Historical rewind suite and verifier module are absent from current source.", + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node --expose-gc docs/audits/claude-branch-proof-streaming/reproduce.cjs /tmp/orca-root-0012-branch-proof-results.json", + "result": "Exit 1 at exact reverse-patch source fence before all phases. No current proof pass.", + "log": "/tmp/orca-root-0012-branch-proof.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node docs/audits/claude-branch-proof-streaming/regressions.mjs /tmp/orca-root-0012-regression-results.json", + "result": "Exit 1 at exact reverse-patch source fence before runner startup. No suites ran.", + "log": "/tmp/orca-root-0012-regressions.log" + }, + { + "command": "node parityCases() enumeration; original/final SHA-256 reconciliation", + "result": "51 table fixtures enumerated, all eight original/final files match source commit. Enumeration is not test execution." + } + ], + "limitations": [ + "Archived historical graph retained unchanged; no dependency downgrade, source fence weakening, production mutation or app window.", + "No current-head parity/allocation/growth/duration/verifier/regression passes claimed. Static declaration hints are zero; explicit manual case records classify standalone assertions.", + "Archived regressor asserts report success, not exact file/case totals; verifier injection flag is not asserted. Scope claims reflect those limits.", + "Memory samples and synthetic timing do not identify incident causes or guarantee a total memory cap." + ] +} diff --git a/docs/audits/test-value/reviews/root-0012.jsonl b/docs/audits/test-value/reviews/root-0012.jsonl new file mode 100644 index 00000000000..64ae0e958ce --- /dev/null +++ b/docs/audits/test-value/reviews/root-0012.jsonl @@ -0,0 +1,8 @@ +{"path":"docs/audits/claude-branch-proof-streaming/sources.cjs","sha256":"36821771ed1e2aeed1587300e891943c77048c8d16f1f810aacee369de74792e","reviewed_sha256":"36821771ed1e2aeed1587300e891943c77048c8d16f1f810aacee369de74792e","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-proof-source-loader","rationale":"Non-test support reverses one exact patch, verifies the original full-reader hash, and applies individually unique experimental edits. This preserves an independent old implementation instead of comparing the new reader with a copied equivalent. Current evolved source intentionally fails the reverse-patch fence; retain the historical graph without weakening hashes.","evidence":["docs/audits/claude-branch-proof-streaming/fix.patch","docs/audits/claude-branch-proof-streaming/candidate-transform.json","src/main/claude/claude-transcript-branch-proof.ts","src/main/claude/claude-transcript-branch-graph.ts","src/main/native-chat/transcript-stream-lines.ts","src/main/claude/claude-structured-history-window.ts"],"cases":[]} +{"path":"docs/audits/claude-branch-proof-streaming/regressions.mjs","sha256":"ddebeeee655ba5b97b370c3caad9aa086f2b88d3180df0af9b337483958b3088","reviewed_sha256":"ddebeeee655ba5b97b370c3caad9aa086f2b88d3180df0af9b337483958b3088","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-compatibility-driver","rationale":"Preserve explicit three-variant actual-suite compatibility experiment. Transform is scoped to the reader and the production variant uses its actual checked-out module. Runner is closed and scratch removed. Historical rewind suite and runtime verifier paths have since retired; startup rejects source drift before any current tests. Report success alone does not assert the historical expected count of 68 per phase.","evidence":["docs/audits/claude-branch-proof-streaming/sources.cjs","src/main/native-chat/session-file-resolver.test.ts","src/main/claude/claude-structured-session-recovery.test.ts","src/main/claude/claude-structured-history-window.test.ts","docs/audits/claude-branch-proof-streaming/regression-results.json"],"cases":[{"line":22,"title":"baseline actual resolver/rewind/recovery/history suite group","decision":"keep","reason":"Runs the four named historical production suites through Vitest, closes it and asserts JSON success. Useful compatibility control in its source graph; no current-head pass or exact-count guarantee claimed."},{"line":22,"title":"candidate actual resolver/rewind/recovery/history suite group","decision":"keep","reason":"Runs the four named historical production suites through Vitest, closes it and asserts JSON success. Useful compatibility control in its source graph; no current-head pass or exact-count guarantee claimed."},{"line":22,"title":"windowCandidate actual resolver/rewind/recovery/history suite group","decision":"keep","reason":"Runs the four named historical production suites through Vitest, closes it and asserts JSON success. Useful compatibility control in its source graph; no current-head pass or exact-count guarantee claimed."}]} +{"path":"docs/audits/claude-branch-proof-streaming/reproduce.cjs","sha256":"824d6d1048f136b314e181f4e8f8d8cc73aa6a4c5a96abb497639e2f4623e4f1","reviewed_sha256":"824d6d1048f136b314e181f4e8f8d8cc73aa6a4c5a96abb497639e2f4623e4f1","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-differential-allocation-driver","rationale":"Keep actual-source differential proof: reconstructed original full-file reader is the independent oracle for file/string variants; explicit error classes prevent all variants agreeing on universal failure. Records provenance and real bundle input hashes, uses real files and cleans temporary modules. Growth, allocation, duration and verifier assertions are classified in their own support rows. Current source fence prevents all proof phases.","evidence":["docs/audits/claude-branch-proof-streaming/sources.cjs","docs/audits/claude-branch-proof-streaming/parity-cases.cjs","docs/audits/claude-branch-proof-streaming/growth.cjs","docs/audits/claude-branch-proof-streaming/allocation.cjs","docs/audits/claude-branch-proof-streaming/duration.cjs","docs/audits/claude-branch-proof-streaming/verifier.cjs","docs/audits/claude-branch-proof-streaming/provenance.json","src/main/claude/claude-transcript-branch-proof.ts","src/main/claude/claude-transcript-branch-graph.ts","src/main/native-chat/transcript-stream-lines.ts","src/main/claude/claude-structured-history-window.ts"],"cases":[{"line":40,"title":"source and quoted-call-site provenance","decision":"keep","reason":"Requires original complete source hashes and exact recorded call-site text before running experiments. Relevant reproduction guard, not a copied product behavior test."},{"line":94,"title":"51 static parity scenarios across three file/string implementations","decision":"keep","reason":"Checks all six outcomes against the independent original file reader, plus expected fulfillment/error class. Case table separately records every scenario; historical snapshots are not current validation."},{"line":129,"title":"missing-file ENOENT across all three readers","decision":"keep","reason":"Calls actual APIs with an absent real path and requires ENOENT for each variant. Distinct filesystem error propagation control."}]} +{"path":"docs/audits/claude-branch-proof-streaming/parity-cases.cjs","sha256":"b30e9219d96fd34015c884d45e12477be23fcc2bccd699f4d48e72aab5b63d0a","reviewed_sha256":"b30e9219d96fd34015c884d45e12477be23fcc2bccd699f4d48e72aab5b63d0a","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-differential-fixture-table","rationale":"Read all fixtures and expanded loops: 51 actual static transcripts distinguish malformed/torn/UTF-8 boundaries, graph identity/session/order conflicts, intent-controlled historical rewinds and 10000/10001 ancestry limits. Table supplies actual inputs and independent expected success/error class; no duplicated implementation.","evidence":["docs/audits/claude-branch-proof-streaming/reproduce.cjs","docs/audits/claude-branch-proof-streaming/candidate-transform.json","src/main/claude/claude-transcript-branch-proof.ts","src/main/claude/claude-transcript-branch-graph.ts","src/main/native-chat/transcript-stream-lines.ts","src/main/claude/claude-structured-history-window.ts"],"cases":[{"line":19,"title":"initial","decision":"keep","reason":"Actual transcript fixture for initial; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":20,"title":"same","decision":"keep","reason":"Actual transcript fixture for same; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":21,"title":"descendant","decision":"keep","reason":"Actual transcript fixture for descendant; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":22,"title":"valid-unterminated-tail","decision":"keep","reason":"Actual transcript fixture for valid-unterminated-tail; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":23,"title":"blank-lines-crlf","decision":"keep","reason":"Actual transcript fixture for blank-lines-crlf; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":24,"title":"torn-tail","decision":"keep","reason":"Actual transcript fixture for torn-tail; preserve independent old-reader parity and explicit rejection with ClaudeTranscriptTailIncompleteError across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":25,"title":"terminated-malformed-tail","decision":"keep","reason":"Actual transcript fixture for terminated-malformed-tail; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":26,"title":"malformed-middle","decision":"keep","reason":"Actual transcript fixture for malformed-middle; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":27,"title":"malformed-before-blank-tail","decision":"keep","reason":"Actual transcript fixture for malformed-before-blank-tail; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":28,"title":"non-object-null","decision":"keep","reason":"Actual transcript fixture for non-object-null; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":29,"title":"non-object-array","decision":"keep","reason":"Actual transcript fixture for non-object-array; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":30,"title":"missing-marker","decision":"keep","reason":"Actual transcript fixture for missing-marker; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":31,"title":"marker-before-leaf","decision":"keep","reason":"Actual transcript fixture for marker-before-leaf; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":32,"title":"wrong-marker-session","decision":"keep","reason":"Actual transcript fixture for wrong-marker-session; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":38,"title":"empty-marker-leaf","decision":"keep","reason":"Actual transcript fixture for empty-marker-leaf; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":39,"title":"missing-marker-leaf","decision":"keep","reason":"Actual transcript fixture for missing-marker-leaf; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":40,"title":"last-marker-wins","decision":"keep","reason":"Actual transcript fixture for last-marker-wins; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":43,"title":"last-marker-sibling","decision":"keep","reason":"Actual transcript fixture for last-marker-sibling; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":49,"title":"duplicate-identical-after-marker","decision":"keep","reason":"Actual transcript fixture for duplicate-identical-after-marker; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":55,"title":"duplicate-conflicting-parent","decision":"keep","reason":"Actual transcript fixture for duplicate-conflicting-parent; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":55,"title":"duplicate-conflicting-session","decision":"keep","reason":"Actual transcript fixture for duplicate-conflicting-session; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":55,"title":"duplicate-conflicting-sidechain","decision":"keep","reason":"Actual transcript fixture for duplicate-conflicting-sidechain; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":57,"title":"append-order-on-proof-path","decision":"keep","reason":"Actual transcript fixture for append-order-on-proof-path; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":63,"title":"append-order-outside-proof-path","decision":"keep","reason":"Actual transcript fixture for append-order-outside-proof-path; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":70,"title":"missing-old-ancestor","decision":"keep","reason":"Actual transcript fixture for missing-old-ancestor; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":71,"title":"cycle","decision":"keep","reason":"Actual transcript fixture for cycle; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":72,"title":"missing-previous-cursor","decision":"keep","reason":"Actual transcript fixture for missing-previous-cursor; preserve independent old-reader parity and explicit rejection with ClaudeTranscriptPreviousCursorMissingError across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":78,"title":"previous-foreign-session","decision":"keep","reason":"Actual transcript fixture for previous-foreign-session; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":91,"title":"disallowed-leaf-sidechain","decision":"keep","reason":"Actual transcript fixture for disallowed-leaf-sidechain; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":97,"title":"disallowed-old-ancestor-sidechain","decision":"keep","reason":"Actual transcript fixture for disallowed-old-ancestor-sidechain; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":91,"title":"disallowed-leaf-parent-tool","decision":"keep","reason":"Actual transcript fixture for disallowed-leaf-parent-tool; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":97,"title":"disallowed-old-ancestor-parent-tool","decision":"keep","reason":"Actual transcript fixture for disallowed-old-ancestor-parent-tool; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":91,"title":"disallowed-leaf-result","decision":"keep","reason":"Actual transcript fixture for disallowed-leaf-result; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":97,"title":"disallowed-old-ancestor-result","decision":"keep","reason":"Actual transcript fixture for disallowed-old-ancestor-result; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":91,"title":"disallowed-leaf-stream","decision":"keep","reason":"Actual transcript fixture for disallowed-leaf-stream; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":97,"title":"disallowed-old-ancestor-stream","decision":"keep","reason":"Actual transcript fixture for disallowed-old-ancestor-stream; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":91,"title":"disallowed-leaf-init","decision":"keep","reason":"Actual transcript fixture for disallowed-leaf-init; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":97,"title":"disallowed-old-ancestor-init","decision":"keep","reason":"Actual transcript fixture for disallowed-old-ancestor-init; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":104,"title":"rewind","decision":"keep","reason":"Actual transcript fixture for rewind; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":108,"title":"rewind-without-intent","decision":"keep","reason":"Actual transcript fixture for rewind-without-intent; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":114,"title":"rewind-wrong-target","decision":"keep","reason":"Actual transcript fixture for rewind-wrong-target; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":120,"title":"rewind-no-previous","decision":"keep","reason":"Actual transcript fixture for rewind-no-previous; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":126,"title":"rewind-to-same","decision":"keep","reason":"Actual transcript fixture for rewind-to-same; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":127,"title":"rewind-to-sibling","decision":"keep","reason":"Actual transcript fixture for rewind-to-sibling; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":133,"title":"old-ancestor-before-large-body","decision":"keep","reason":"Actual transcript fixture for old-ancestor-before-large-body; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":146,"title":"utf8-crosses-64k-file-chunk","decision":"keep","reason":"Actual transcript fixture for utf8-crosses-64k-file-chunk; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":147,"title":"unicode-identities","decision":"keep","reason":"Actual transcript fixture for unicode-identities; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":150,"title":"invalid-utf8-replacement-in-message","decision":"keep","reason":"Actual transcript fixture for invalid-utf8-replacement-in-message; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":159,"title":"invalid-utf8-in-torn-tail","decision":"keep","reason":"Actual transcript fixture for invalid-utf8-in-torn-tail; preserve independent old-reader parity and explicit rejection with ClaudeTranscriptTailIncompleteError across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":169,"title":"ancestry-depth-10000","decision":"keep","reason":"Actual transcript fixture for ancestry-depth-10000; preserve independent old-reader parity and explicit successful proof across three file APIs and their string twins. This is an archived scenario, not a current pass."},{"line":169,"title":"ancestry-depth-10001","decision":"keep","reason":"Actual transcript fixture for ancestry-depth-10001; preserve independent old-reader parity and explicit rejection with Error across three file APIs and their string twins. This is an archived scenario, not a current pass."}]} +{"path":"docs/audits/claude-branch-proof-streaming/growth.cjs","sha256":"6c3e29d47c6e0c689143de932161a2cf9c65662c748ae0ef69f96be264ebb132","reviewed_sha256":"6c3e29d47c6e0c689143de932161a2cf9c65662c748ae0ef69f96be264ebb132","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-real-file-growth-controls","rationale":"Keep 24 real-file deterministic growth/error/descriptor controls. Intercepts actual Node filesystem boundaries, restores every hook, checks injection occurred and original descriptor closes; compares observed prefix outcomes against the original implementation. Private bindings intentionally limit this archived runtime experiment; no simulated filesystem or portable integration claim.","evidence":["docs/audits/claude-branch-proof-streaming/reproduce.cjs","docs/audits/claude-branch-proof-streaming/sources.cjs","docs/audits/claude-branch-proof-streaming/provenance.json","src/main/claude/claude-transcript-branch-proof.ts","src/main/claude/claude-transcript-branch-graph.ts","src/main/native-chat/transcript-stream-lines.ts","src/main/claude/claude-structured-history-window.ts"],"cases":[{"line":27,"title":"small-regular-file","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. small-regular-file. Retain for the fenced historical source graph; no current pass."},{"line":28,"title":"exact-512k-regular-file","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. exact-512k-regular-file. Retain for the fenced historical source graph; no current pass."},{"line":29,"title":"nonaligned-large-regular-file","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. nonaligned-large-regular-file. Retain for the fenced historical source graph; no current pass."},{"line":30,"title":"initially-empty-file","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. initially-empty-file. Retain for the fenced historical source graph; no current pass."},{"line":31,"title":"new-malformed-tail","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. new-malformed-tail. Retain for the fenced historical source graph; no current pass."},{"line":32,"title":"parse-error-closes-reader","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. parse-error-closes-reader. Retain for the fenced historical source graph; no current pass."},{"line":33,"title":"empty-file-closes-reader","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. empty-file-closes-reader. Retain for the fenced historical source graph; no current pass."},{"line":34,"title":"read-error-closes-reader","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. read-error-closes-reader. Retain for the fenced historical source graph; no current pass."},{"line":35,"title":"stat-error-closes-reader","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. stat-error-closes-reader. Retain for the fenced historical source graph; no current pass."},{"line":37,"title":"restat-failure-keeps-missing-marker","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. restat-failure-keeps-missing-marker. Retain for the fenced historical source graph; no current pass."},{"line":42,"title":"replacement-cannot-prove-original-growth","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. replacement-cannot-prove-original-growth. Retain for the fenced historical source graph; no current pass."},{"line":43,"title":"shrink-cannot-prove-growth","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. shrink-cannot-prove-growth. Retain for the fenced historical source graph; no current pass."},{"line":45,"title":"growth-preserves-conflict","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. growth-preserves-conflict. Retain for the fenced historical source graph; no current pass."},{"line":50,"title":"growth-preserves-wrong-session","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. growth-preserves-wrong-session. Retain for the fenced historical source graph; no current pass."},{"line":55,"title":"growth-preserves-append-order","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. growth-preserves-append-order. Retain for the fenced historical source graph; no current pass."},{"line":59,"title":"path-replacement-keeps-opened-file","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. path-replacement-keeps-opened-file. Retain for the fenced historical source graph; no current pass."},{"line":60,"title":"path-deletion-keeps-opened-file","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. path-deletion-keeps-opened-file. Retain for the fenced historical source graph; no current pass."},{"line":62,"title":"truncation-leaves-complete-prefix","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. truncation-leaves-complete-prefix. Retain for the fenced historical source graph; no current pass."},{"line":67,"title":"truncation-leaves-torn-tail","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. truncation-leaves-torn-tail. Retain for the fenced historical source graph; no current pass."},{"line":72,"title":"prefix-descendant-under-growth","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. prefix-descendant-under-growth. Retain for the fenced historical source graph; no current pass."},{"line":78,"title":"prefix-rewind-under-growth","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. prefix-rewind-under-growth. Retain for the fenced historical source graph; no current pass."},{"line":84,"title":"missing-previous-repaired-by-growth","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. missing-previous-repaired-by-growth. Retain for the fenced historical source graph; no current pass."},{"line":89,"title":"missing-marker-repaired-by-growth","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. missing-marker-repaired-by-growth. Retain for the fenced historical source graph; no current pass."},{"line":91,"title":"torn-prefix-repaired-by-growth","decision":"keep","reason":"Exercise actual opened file and compare permitted prefix/refresh outcomes, then require original descriptor closure. torn-prefix-repaired-by-growth. Retain for the fenced historical source graph; no current pass."}]} +{"path":"docs/audits/claude-branch-proof-streaming/verifier.cjs","sha256":"2ce5e8b25136f9553cfa39185391803623a4d0c91995b0b7d3ad45c4c2ff33d4","reviewed_sha256":"2ce5e8b25136f9553cfa39185391803623a4d0c91995b0b7d3ad45c4c2ff33d4","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-runtime-verifier-controls","rationale":"Keep 10 historical real-file verifier scenarios using exact extracted production method and real reader/retry timer; controls only live-owner, path and fresh-hook ports. Explicit one-attempt assertions distinguish internal refresh from caller retries. Extraction is fenced; current runtime file has retired, so this is historical evidence only. Injection flag is recorded locally but not asserted: no stronger hook-fired guarantee claimed.","evidence":["docs/audits/claude-branch-proof-streaming/reproduce.cjs","docs/audits/claude-branch-proof-streaming/sources.cjs","docs/audits/claude-branch-proof-streaming/provenance.json","src/main/claude/claude-transcript-branch-proof.ts","src/main/claude/claude-transcript-branch-graph.ts","src/main/native-chat/transcript-stream-lines.ts","src/main/claude/claude-structured-history-window.ts"],"cases":[{"line":41,"title":"growing-empty-prefix-refreshed-internally","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. growing-empty-prefix-refreshed-internally. Retain for the fenced historical source graph; no current pass."},{"line":47,"title":"growing-missing-marker-refreshed-internally","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. growing-missing-marker-refreshed-internally. Retain for the fenced historical source graph; no current pass."},{"line":53,"title":"growing-missing-previous-refreshed-internally","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. growing-missing-previous-refreshed-internally. Retain for the fenced historical source graph; no current pass."},{"line":59,"title":"static-empty-fatal","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. static-empty-fatal. Retain for the fenced historical source graph; no current pass."},{"line":60,"title":"static-missing-marker-fatal","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. static-missing-marker-fatal. Retain for the fenced historical source graph; no current pass."},{"line":62,"title":"static-missing-previous-fatal","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. static-missing-previous-fatal. Retain for the fenced historical source graph; no current pass."},{"line":68,"title":"growing-conflict-fatal","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. growing-conflict-fatal. Retain for the fenced historical source graph; no current pass."},{"line":74,"title":"growing-session-mismatch-fatal","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. growing-session-mismatch-fatal. Retain for the fenced historical source graph; no current pass."},{"line":80,"title":"growing-append-order-fatal","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. growing-append-order-fatal. Retain for the fenced historical source graph; no current pass."},{"line":86,"title":"successful-prefix-stays-prefix","decision":"keep","reason":"Exercise extracted actual verifier with real transcript; assert configured error/first-attempt refreshed success or stable-prefix result. successful-prefix-stays-prefix. Retain for the fenced historical source graph; no current pass."}]} +{"path":"docs/audits/claude-branch-proof-streaming/allocation.cjs","sha256":"93bdb172e14624a5ff7b30974e3e1c56fafc5724e8b4f973275ead9063e099c9","reviewed_sha256":"93bdb172e14624a5ff7b30974e3e1c56fafc5724e8b4f973275ead9063e099c9","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-allocation-measurement","rationale":"Keep real-file allocation comparison with correct leaf/relation asserted on every invocation. Forced GC at actual JSON.parse boundaries measures transient sampled heap/external bytes, not natural RSS or a leak. Only the 64 large-payload arm asserts half-baseline peak; other arms are explicit measurements/controls. JSON.parse is restored in finally.","evidence":["docs/audits/claude-branch-proof-streaming/reproduce.cjs","src/main/claude/claude-transcript-branch-proof.ts","src/main/claude/claude-transcript-branch-graph.ts","src/main/native-chat/transcript-stream-lines.ts","src/main/claude/claude-structured-history-window.ts"],"cases":[{"line":79,"title":"16 records x 512 KiB payload","decision":"keep","reason":"Real-file sampled allocation control with correct branch asserted; no relative threshold."},{"line":80,"title":"64 records x 512 KiB payload","decision":"keep","reason":"Independent full-reader baseline vs both streaming variants must show less than half sampled live heap; correct branch remains required."},{"line":81,"title":"64 records x empty payload","decision":"keep","reason":"Record-count allocation control separates graph retention from payload bodies; correctness asserted, memory reported."},{"line":82,"title":"one record x 8 MiB payload","decision":"keep","reason":"Large-single-record control exposes remaining whole-record allocation; correctness asserted, memory reported without claiming a total cap."}]} +{"path":"docs/audits/claude-branch-proof-streaming/duration.cjs","sha256":"5b24ded05da1b21c1e63d2cde33437a016b61780ecca3a30f9430e0dd689f81d","reviewed_sha256":"5b24ded05da1b21c1e63d2cde33437a016b61780ecca3a30f9430e0dd689f81d","source_commit":"8d94ed06570adb2b7300cf16fe9f43b4680e3f2b","reviewer":"root","status":"reviewed","decision":"keep","classification":"archived-manual-duration-benchmark","rationale":"Keep explicit whole-proof timing comparison on one stable actual 8193-line file, two warm rounds and five measured rounds in alternating order without forced GC. Correct output is required every call. Reports medians without a hardware-dependent speed threshold.","evidence":["docs/audits/claude-branch-proof-streaming/reproduce.cjs","src/main/claude/claude-transcript-branch-proof.ts","src/main/claude/claude-transcript-branch-graph.ts","src/main/native-chat/transcript-stream-lines.ts","src/main/claude/claude-structured-history-window.ts"],"cases":[{"line":6,"title":"8192 transcript records plus marker, two warm/five timed alternating rounds","decision":"keep","reason":"Actual independent baseline and finite-window reader must both return correct descendant proof each round. Timing is measurement rather than a performance gate."}]} diff --git a/docs/audits/test-value/reviews/root-0013-validation.json b/docs/audits/test-value/reviews/root-0013-validation.json new file mode 100644 index 00000000000..de3421da323 --- /dev/null +++ b/docs/audits/test-value/reviews/root-0013-validation.json @@ -0,0 +1,26 @@ +{ + "batch": "root-0013", + "reviewer": "root", + "source_commit": "533df41f73db3827e0d2d33a82df53b0cdfe47f8", + "reviewed_files": 1, + "original_declaration_sites": 7, + "repeat_review": true, + "production_changes": false, + "review_scope": "Reconcile sole stale inventory file after rebasing onto merged main. Read complete seven test bodies, fixture and actual build/tsrs command/selection support. Existing source hash and case records remain as history; new row supersedes them.", + "checks": [ + { + "command": "ORCA_BACKGROUND_LAUNCH=1 node config/scripts/run-vitest.mjs run --config config/vitest.config.ts config/scripts/build-cli.test.mjs", + "result": "7 tests passed, zero skips. Includes actual installed TypeScript/Bun/tsrs output and type-error behavior on Linux x64.", + "log": "/tmp/orca-root-0013-build-cli.log" + }, + { + "command": "ORCA_BACKGROUND_LAUNCH=1 pnpm install --frozen-lockfile", + "result": "Passed after rebase; installed updated pinned Bun 1.4.4 and tsrs 0.18.0.", + "log": "/tmp/orca-audit-3-post-rebase-install.log" + } + ], + "limitations": [ + "Suite unchanged by this batch; upstream platform-gate reuse preserves original behavior. Local validation covers Linux x64, not separate macOS/Windows hosts.", + "Seven declaration records include explicitly recorded multiple-negative and compiler/error body arms; runtime declarations are not multiplied in aggregate." + ] +} diff --git a/docs/audits/test-value/reviews/root-0013.jsonl b/docs/audits/test-value/reviews/root-0013.jsonl new file mode 100644 index 00000000000..6bbc08dd46d --- /dev/null +++ b/docs/audits/test-value/reviews/root-0013.jsonl @@ -0,0 +1 @@ +{"path":"config/scripts/build-cli.test.mjs","sha256":"3e609e5b2b405f6906f23f6ba2cde8f4996b28ab434dde2a6c5e36b5e5fbd8fc","cases":[{"line":65,"title":"checks the emit project first, retains all CPU cores and preserves the TypeScript emitter","decision":"keep","reason":"Compile invocation checks typecheck-before-emission and the project, CPU and emitter options affecting output."},{"line":104,"title":"does not emit when checking fails or the pinned Bun is missing","decision":"keep","reason":"Failed checking or missing pinned Bun must suppress emission.","subcases":["typecheck failure suppresses emitter","missing pinned Bun suppresses emitter"]},{"line":119,"title":"propagates emitter failures","decision":"keep","reason":"Signal failure from the emitter must propagate to the build."},{"line":129,"title":"rejects unknown compiler selections before emission","decision":"keep","reason":"Unknown compiler selection fails before any emitted output."},{"line":137,"title":"produces byte-identical JavaScript, declarations and maps with the real compilers","decision":"keep","reason":"Actual compiler outputs, declarations and maps match an independently invoked TypeScript baseline."},{"line":169,"title":"blocks output for real type errors and rejects compiler version drift","decision":"keep","reason":"Real type errors block emission and incompatible installed compiler versions fail.","subcases":["real invalid TypeScript prevents emitter","incompatible installed TypeScript version prevents emitter"]},{"line":195,"title":"the optional compiler preserves emitted bytes and blocks output on type errors","decision":"keep","reason":"Optional Rust compiler emits identical real artifacts and refuses a new output directory after type errors.","subcases":["optional actual compiler produces same artifacts as actual Bun plus TypeScript baseline","real invalid TypeScript produces no new failed output directory"]}],"reviewer":"root","status":"reviewed","decision":"keep","rationale":"Reread all seven complete bodies and actual build/compiler selection. Upstream replaces a copied platform predicate with production supportsTsrs(), which retains the same supported platforms. Keep real emitted artifact comparisons and deliberate error inputs. No new code edits; this row supersedes the stale initial review without counting the file twice.","evidence":["config/scripts/build-cli.mjs","config/scripts/tsrs-typecheck-compiler.mjs","config/scripts/run-typecheck-projects-in-parallel.mjs","config/scripts/pinned-bun-executable.mjs"],"source_commit":"533df41f73db3827e0d2d33a82df53b0cdfe47f8","reviewed_sha256":"3e609e5b2b405f6906f23f6ba2cde8f4996b28ab434dde2a6c5e36b5e5fbd8fc","classification":"current-suite-rereview-after-upstream-change"} diff --git a/docs/site/tests/docs-package.test.mjs b/docs/site/tests/docs-package.test.mjs index 71665c98b1b..06b35a04207 100644 --- a/docs/site/tests/docs-package.test.mjs +++ b/docs/site/tests/docs-package.test.mjs @@ -40,60 +40,12 @@ function isMediaPath(urlPath) { return /\.(?:gif|jpe?g|png|webp|mp4|svg|ico)$/i.test(urlPath.split(/[?#]/, 1)[0]) } -test('docs package has an isolated, reproducible app contract', async () => { - const packageJson = JSON.parse(await read('package.json')) - - assert.equal(packageJson.name, '@orca/docs') - assert.equal(packageJson.private, true) - assert.equal(packageJson.packageManager.split('+')[0], 'pnpm@12.14.0') - assert.equal(packageJson.engines.node, '24.x') - assert.equal(packageJson.scripts.build, 'next build') - assert.equal(packageJson.scripts.postinstall, 'fumadocs-mdx') - assert.equal(packageJson.scripts.prebuild, 'fumadocs-mdx') - for (const dependency of [ - 'fumadocs-core', - 'fumadocs-mdx', - 'fumadocs-ui', - 'next', - 'react', - 'react-dom' - ]) { - assert.ok(packageJson.dependencies[dependency], `missing runtime dependency: ${dependency}`) - } - assert.ok(packageJson.devDependencies.typescript) - assert.ok(packageJson.devDependencies.vercel) - assert.ok(existsSync(path.join(siteRoot, 'pnpm-lock.yaml'))) -}) - -test('all customer-facing docs pages and navigation metadata are present', async () => { +test('docs content and navigation metadata are discoverable', async () => { const pages = await walkFiles(contentRoot, '.mdx') - assert.ok( - pages.length >= 57, - `expected at least the current 57 docs pages, found ${pages.length}` - ) - - for (const relativePath of [ - 'index.mdx', - 'install.mdx', - 'first-session.mdx', - 'agents/supported.mdx', - 'cli/reference.mdx', - 'remote-servers.mdx', - 'review/github.mdx', - 'settings.mdx', - 'troubleshooting.mdx' - ]) { - assert.ok( - existsSync(path.join(contentRoot, relativePath)), - `missing docs page: ${relativePath}` - ) - } + assert.ok(pages.length > 0, 'expected docs content pages') const navigationFiles = await walkFiles(contentRoot, 'meta.json') - assert.ok( - navigationFiles.length >= 8, - `expected at least the current navigation files, found ${navigationFiles.length}` - ) + assert.ok(navigationFiles.length > 0, 'expected navigation metadata') for (const file of navigationFiles) { const metadata = JSON.parse(await readFile(file, 'utf8')) assert.ok(metadata.title, `navigation title missing in ${file}`) @@ -124,6 +76,7 @@ test('every local media URL referenced by docs resolves in public assets', async test('docs content does not link to routes that only exist on the marketing site', async () => { const files = await walkFiles(contentRoot, '.mdx') + assert.ok(files.length > 0, 'expected docs content pages') for (const file of files) { const content = await readFile(file, 'utf8') for (const match of content.matchAll(/\]\((\/(?!docs(?:\/|[)#]))[^)\s]+)\)/g)) { @@ -132,82 +85,6 @@ test('docs content does not link to routes that only exist on the marketing site } }) -test('published docs do not retain private source provenance', async () => { - const files = [ - ...(await walkFiles(contentRoot, '.mdx')), - ...(await walkFiles(contentRoot, 'meta.json')), - path.join(siteRoot, 'README.md') - ] - for (const file of files) { - const content = await readFile(file, 'utf8') - assert.doesNotMatch( - content, - /orca-(?:internal|marketing-website)|147cdfd|jinwoo@stably\.ai|demo-generation/i, - path.relative(siteRoot, file) - ) - } -}) - -test('reviewed private demo media stays outside the publication boundary', async () => { - const files = await walkFiles(publicRoot) - for (const file of files) { - assert.doesNotMatch( - path.relative(publicRoot, file), - /(?:codex-account-switcher|default-agent-opening|any-cli-agent)/i - ) - } -}) - -test('docs routes stay namespaced and the generated source uses /docs as its base URL', async () => { - const source = await read('src/lib/source.ts') - const sourceConfig = await read('source.config.ts') - const rootPage = await read('src/app/page.tsx') - const nextConfig = await read('next.config.ts') - const searchDialog = await read('src/components/docs/SearchDialog.tsx') - const appLayout = await read('src/app/layout.tsx') - const docsLayout = await read('src/app/docs/layout.tsx') - const ogImage = await read('src/lib/docs-og-image.tsx') - const header = await read('src/components/layout/DocsHeader.tsx') - const footer = await read('src/components/layout/DocsFooter.tsx') - const appFiles = await walkFiles(path.join(siteRoot, 'src', 'app')) - - assert.match(source, /baseUrl:\s*['"]\/docs['"]+/) - assert.match( - sourceConfig, - /dir:\s*['"]content\/docs['"]|dir:\s*docsVersioning\.current\.sourceDir/ - ) - assert.match(sourceConfig, /light:\s*['"]github-light['"]+/) - assert.match(sourceConfig, /dark:\s*['"]github-dark-high-contrast['"]+/) - assert.match(rootPage, /redirect\(['"]\/docs['"]\)/) - assert.match(nextConfig, /assetPrefix:\s*['"]\/docs-static['"]+/) - assert.match(searchDialog, /api:\s*['"]\/docs\/api\/search['"]+/) - assert.doesNotMatch(appLayout, /forcedTheme|className=['"][^'"]*\bdark\b/) - assert.match(docsLayout, / file.endsWith(path.join('docs', '[[...slug]]', 'page.tsx')))) - assert.ok( - appFiles.every((file) => { - const relative = path.relative(path.join(siteRoot, 'src', 'app'), file) - return ( - relative.startsWith(`docs${path.sep}`) || - ['globals.css', 'layout.tsx', 'page.tsx'].includes(relative) - ) - }) - ) -}) - test('GIF media helpers use the shared poster and video variants', async () => { const media = await import(pathToFileURL(path.join(siteRoot, 'src', 'lib', 'demoMedia.mjs')).href) assert.equal(media.posterFor('/docs/orca-design-mode.gif'), '/docs/posters/orca-design-mode.jpg') @@ -219,21 +96,6 @@ test('GIF media helpers use the shared poster and video variants', async () => { assert.ok(existsSync(path.join(publicRoot, 'docs', 'posters', `${name}.jpg`))) assert.ok(existsSync(path.join(publicRoot, 'docs', 'videos', `${name}.mp4`))) } - assert.equal(existsSync(path.join(publicRoot, 'whats-new')), false) -}) - -test('versioning seam keeps current docs stable without claiming live versioned routes', async () => { - const versioning = await read('versioning.config.ts') - const readme = await read('README.md') - - assert.match( - versioning, - /sourceDir:\s*['"]content\/docs['"]|sourceDir:\s*docsVersioning\.current\.sourceDir/ - ) - assert.match(versioning, /urlPrefix:\s*['"]\/docs['"]/) - assert.match(versioning, /versionsDir:\s*['"]content\/versions['"]+/) - assert.match(readme, /future snapshots|future versioned|versioned/i) - assert.doesNotMatch(readme, /packages\/docs/) }) test('OG image fonts ship with their required third-party notice', async () => { @@ -245,22 +107,6 @@ test('OG image fonts ship with their required third-party notice', async () => { } const notice = await read('THIRD_PARTY_NOTICES.md') - const ogImage = await read('src/lib/docs-og-image.tsx') assert.match(notice, /SIL OPEN FONT LICENSE Version 1\.1/) assert.match(notice, /Copyright \(c\) 2023 Vercel/) - assert.doesNotMatch(ogImage, /linear-gradient|boxShadow/) -}) - -test('docs app has no marketing-only route or analytics dependency', async () => { - const sourceFiles = await walkFiles(path.join(siteRoot, 'src')) - for (const file of sourceFiles) { - const content = await readFile(file, 'utf8') - assert.doesNotMatch( - content, - /(?:from|import)\s+['"`][^'"`]*(?:posthog|plausible|segment)|marketing-website/i, - file - ) - } - assert.equal(existsSync(path.join(siteRoot, 'src', 'app', 'download')), false) - assert.equal(existsSync(path.join(siteRoot, 'src', 'app', 'pricing')), false) }) diff --git a/docs/site/tests/search-excerpt.test.mjs b/docs/site/tests/search-excerpt.test.mjs index 8d32de2e761..9ce21d1c874 100644 --- a/docs/site/tests/search-excerpt.test.mjs +++ b/docs/site/tests/search-excerpt.test.mjs @@ -60,22 +60,14 @@ test('search excerpts preserve highlighted matches inside Markdown', () => { ) }) -test('unclosed angles avoid the HTML matcher without changing excerpt text', () => { - const input = '<'.repeat(8192) - const replace = String.prototype.replace - let tagMatcherCalls = 0 - String.prototype.replace = function (pattern, ...args) { - if (pattern instanceof RegExp && pattern.source === '<[^>]+>' && pattern.flags === 'g') { - tagMatcherCalls += 1 - } - return Reflect.apply(replace, this, [pattern, ...args]) - } - try { - assert.equal(stripSearchExcerptMarkdown(input), input) - } finally { - String.prototype.replace = replace - } - assert.equal(tagMatcherCalls, 0) +test('unclosed angles finish within the excerpt budget without changing text', () => { + const input = '<'.repeat(131_072) + const result = runInNewContext( + 'strip(input)', + { strip: stripSearchExcerptMarkdown, input }, + { timeout: 250 } + ) + assert.equal(result, input) }) test('tag guards preserve malformed markup, protected code and highlighted matches', () => { @@ -108,24 +100,12 @@ test('tag guards preserve malformed markup, protected code and highlighted match } }) -test('unclosed brackets avoid link matchers without changing excerpt text', () => { - const input = '['.repeat(4096) - const replace = String.prototype.replace - let linkMatcherCalls = 0 - String.prototype.replace = function (pattern, ...args) { - if ( - pattern instanceof RegExp && - pattern.source.includes('\\[') && - pattern.source.includes('\\]') - ) { - linkMatcherCalls += 1 - } - return Reflect.apply(replace, this, [pattern, ...args]) - } - try { - assert.equal(stripSearchExcerptMarkdown(input), input) - } finally { - String.prototype.replace = replace - } - assert.equal(linkMatcherCalls, 0) +test('unclosed brackets finish within the excerpt budget without changing text', () => { + const input = '['.repeat(131_072) + const result = runInNewContext( + 'strip(input)', + { strip: stripSearchExcerptMarkdown, input }, + { timeout: 250 } + ) + assert.equal(result, input) }) diff --git a/mobile/src/components/mobile-agent-icon-assets.test.ts b/mobile/src/components/mobile-agent-icon-assets.test.ts deleted file mode 100644 index 7020d4b4977..00000000000 --- a/mobile/src/components/mobile-agent-icon-assets.test.ts +++ /dev/null @@ -1,36 +0,0 @@ -import { existsSync } from 'node:fs' -import path from 'node:path' -import { describe, expect, it } from 'vitest' -import type { TuiAgent } from '../../../src/shared/tui-agent' -import { MOBILE_TUI_AGENT_FAVICON_DOMAINS } from '../tasks/mobile-tui-agents' - -// Agents that render a hand-authored glyph in MobileAgentIcon and therefore -// never reach the favicon/bundled-asset path. -const GLYPH_AGENT_IDS = new Set([ - 'claude', - 'claude-agent-teams', - 'codex', - 'pi', - 'omp', - 'aider' -]) - -const dirname = import.meta.dirname -const assetsDir = path.resolve(dirname, '../../../src/shared/agent-icons') - -// Why: these agents previously loaded from Google's favicon service, which is -// unreachable in some regions/offline (#8451). Every one that lacks a glyph -// must ship a bundled PNG so the icon renders without a network request. -const agentsNeedingBundledIcon = Object.keys(MOBILE_TUI_AGENT_FAVICON_DOMAINS).filter( - (id): id is TuiAgent => !GLYPH_AGENT_IDS.has(id as TuiAgent) -) - -describe('mobile bundled agent icons', () => { - it('ships a bundled PNG on disk for every favicon-path agent', () => { - for (const id of agentsNeedingBundledIcon) { - expect(existsSync(path.join(assetsDir, `${id}.png`)), `missing bundled icon for ${id}`).toBe( - true - ) - } - }) -}) diff --git a/mobile/src/components/mobile-agent-icon-gradient.test.ts b/mobile/src/components/mobile-agent-icon-gradient.test.ts deleted file mode 100644 index c2221b62771..00000000000 --- a/mobile/src/components/mobile-agent-icon-gradient.test.ts +++ /dev/null @@ -1,61 +0,0 @@ -import { createElement } from 'react' -import { act, create, type ReactTestRenderer } from 'react-test-renderer' -import { afterEach, describe, expect, it, vi } from 'vitest' -import { MobileAgentIcon } from './MobileAgentIcon' - -vi.mock('react-native', () => ({ - Image: 'Image', - StyleSheet: { create: (styles: unknown) => styles }, - Text: 'Text', - View: 'View' -})) - -vi.mock('lucide-react-native', () => ({ - Terminal: 'Terminal' -})) - -vi.mock('react-native-svg', () => ({ - default: 'Svg', - Defs: 'Defs', - G: 'G', - LinearGradient: 'LinearGradient', - Path: 'Path', - Stop: 'Stop' -})) - -vi.mock('./mobile-agent-icon-assets', () => ({ - MOBILE_AGENT_ICON_ASSETS: {} -})) - -vi.mock('./AgentIcons', () => ({ - ClaudeIcon: 'ClaudeIcon', - OpenAIIcon: 'OpenAIIcon' -})) - -describe('MobileAgentIcon OMP gradient', () => { - let renderer: ReactTestRenderer | null = null - - afterEach(() => { - act(() => renderer?.unmount()) - renderer = null - vi.restoreAllMocks() - }) - - it('uses valid SVG gradient stop offsets', async () => { - const consoleError = vi.spyOn(console, 'error').mockImplementation((...args) => { - if (typeof args[0] !== 'string' || !args[0].includes('react-test-renderer is deprecated')) { - throw new Error(String(args[0])) - } - }) - await act(async () => { - renderer = create(createElement(MobileAgentIcon, { agentId: 'omp' })) - }) - consoleError.mockRestore() - - expect(renderer.root.findAllByType('Stop').map((stop) => stop.props.offset)).toEqual([ - '0', - '0.5', - '1' - ]) - }) -}) diff --git a/mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts b/mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts index f0e865dd4d1..d1034335e1e 100644 --- a/mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts +++ b/mobile/src/components/mobile-diff-review-send-sheet-stacking.test.ts @@ -103,6 +103,7 @@ const SAVE_REPLY = { id: 'save', ok: true, result: {}, _meta: { runtimeId: 'runt let renderer: ReactTestRenderer | null = null let controller: Controller let replies: Map +let requests: { method: string; params: unknown }[] function Screen({ client }: { client: RpcClient }) { controller = useMobileDiffReviewController({ @@ -123,14 +124,16 @@ function Screen({ client }: { client: RpcClient }) { } /** Every RPC waits until the test answers it, so each case controls when a load or save lands. */ -async function mountScreen(): Promise { +async function mountScreen(snapshot: ReviewScreenState = SNAPSHOT): Promise { replies = new Map() - const sendRequest = vi.fn((method: string) => { + requests = [] + const sendRequest = vi.fn((method: string, params: unknown) => { + requests.push({ method, params }) const reply = deferred() replies.set(method, reply) return reply.promise }) - loadSnapshot.mockResolvedValue(SNAPSHOT) + loadSnapshot.mockResolvedValue(snapshot) await act(async () => { // oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: the operations under test only call `sendRequest`. renderer = create(createElement(Screen, { client: { sendRequest } as unknown as RpcClient })) @@ -300,12 +303,25 @@ describe('review screen sheets never stack', () => { }) it('Discard keeps its file through the close and discards the file it showed', async () => { - await mountScreen() + await mountScreen({ + ...SNAPSHOT, + status: { + ...SNAPSHOT.status, + entries: [ + ...SNAPSHOT.status.entries, + { path: 'src/b.ts', status: 'modified', area: 'unstaged' } + ] + } + }) const target = controller.currentItem! act(() => controller.openSheet({ kind: 'discard', target })) + act(() => controller.moveFile('next')) + expect(controller.currentItem?.filePath).toBe('src/b.ts') press(drawer('Discard File'), 'Discard') expect(shownSheets()).toEqual([]) expect(textOf(drawer('Discard File')).join(' ')).toContain(target.filePath) - expect(replies.has('git.discard')).toBe(true) + expect(requests.filter((request) => request.method === 'git.discard')).toEqual([ + { method: 'git.discard', params: { worktree: 'id:wt-1', filePath: 'src/a.ts' } } + ]) }) }) diff --git a/mobile/src/components/mobile-markdown-preview-placeholder.test.ts b/mobile/src/components/mobile-markdown-preview-placeholder.test.ts index f751608af78..94b266df9ad 100644 --- a/mobile/src/components/mobile-markdown-preview-placeholder.test.ts +++ b/mobile/src/components/mobile-markdown-preview-placeholder.test.ts @@ -17,17 +17,4 @@ describe('mobile Markdown code placeholder collisions', () => { `${literal} and \`
\`` ) }) - - it('preserves authored markers across generated suffix orders and HTML islands', () => { - let seed = 173 - for (let sample = 0; sample < 500; sample++) { - const literals: string[] = [] - for (let index = 0; index < 8; index++) { - seed = (Math.imul(seed, 1664525) + 1013904223) >>> 0 - literals.push(`${marker}${'_'.repeat(seed % 32)}${index}${suffix}`) - } - const text = literals.join(' ') + ' and `Array`' - expect(normalizeMobileMarkdownPreviewHtml(`

${text}

`)).toBe(text) - } - }) }) diff --git a/mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx b/mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx index bff4cb55f6c..a00aab7e963 100644 --- a/mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx +++ b/mobile/src/components/mobile-webview-editor-web-fallbacks.test.tsx @@ -1,20 +1,4 @@ -/** - * The two `react-native-webview` consumers on the page, pinned through the test renderer. - * - * Both native components put their surface inside a `WebView`, which has no browser counterpart: - * importing it runs a codegen lookup that throws, and the route manifest imports every route, so - * one such import takes the whole bundle down rather than one editor. - * - * Ruling 26 makes C7.6's fallbacks debt rather than done, and both are paid now. The preview - * renders the artifact in a sealed `srcdoc` frame with the toggle intact; the rich Markdown editor - * mounts the same document program the WebView runs, under the same fifteen-command toolbar. What a - * browser does with either — the frame's sandbox, the editor's commands, its listeners across a - * remount — is not a question this renderer can answer, and is measured in - * `mobile-web-app-html-preview-render.test.mjs` and - * `mobile-web-app-rich-markdown-render.test.mjs` instead. What is pinned here is the shape above - * the document: that the plain field is gone, that the toolbar is the one both siblings render, and - * that the two props the page answers differently are answered differently. - */ +// @vitest-environment happy-dom import { createElement } from 'react' import { act, create, type ReactTestRenderer } from 'react-test-renderer' import { afterEach, describe, expect, it, vi } from 'vitest' @@ -24,11 +8,6 @@ vi.mock('react-native', async () => { (name: string) => ({ children, ...props }: { children?: React.ReactNode }) => React.createElement(name, props, children) - // The one mock that forwards a ref: the editor's `dismissKeyboard` blurs through it, and a - // function component would have swallowed it. - const TextInput = React.forwardRef( - ({ children, ...props }, ref) => React.createElement('TextInput', { ...props, ref }, children) - ) return { // The native preview's external-link opener reaches for this at module load, and a named import // missing from a mocked module throws before any case runs. @@ -37,7 +16,7 @@ vi.mock('react-native', async () => { ScrollView: host('ScrollView'), StyleSheet: { create: (styles: unknown) => styles, hairlineWidth: 1 }, Text: host('Text'), - TextInput, + TextInput: host('TextInput'), View: host('View') } }) @@ -64,8 +43,6 @@ vi.mock('lucide-react-native', () => ({ Strikethrough: () => null })) -// The modal is a bottom drawer with an animation and a portal, none of which this file is about: -// what it pins is that the editor carries one and that it is shut. vi.mock('./TextInputModal', async () => { const React = await import('react') return { @@ -84,12 +61,14 @@ function findHosts(renderer: ReactTestRenderer, type: string) { return renderer.root.findAll((node) => node.type === type) } -/** `createNodeMock` is how a ref to a host element gets anything at all under this renderer, and - * the editor's `dismissKeyboard` reaches the field through one. */ -function render(element: React.ReactElement, node?: unknown): ReactTestRenderer { +function render( + element: React.ReactElement, + node: HTMLElement = document.createElement('div') +): ReactTestRenderer { let renderer: ReactTestRenderer | null = null + document.body.appendChild(node) act(() => { - renderer = create(element, node === undefined ? undefined : { createNodeMock: () => node }) + renderer = create(element, { createNodeMock: () => node }) }) if (renderer === null) { throw new Error('nothing mounted') @@ -102,76 +81,66 @@ afterEach(() => { for (const renderer of renderers.splice(0)) { act(() => renderer.unmount()) } + document.body.innerHTML = '' + document.head.innerHTML = '' }) describe('the rich markdown editor on the page', () => { - it('renders no plain field, because the document it degraded to is gone', () => { + it('mounts the editor document with its content and reports edits to the host', () => { + const host = document.createElement('div') + const onChange = vi.fn() const renderer = render( createElement(MobileRichMarkdownEditor, { content: '# Title\n\nbody', editable: true, - onChange: vi.fn() - }) + onChange + }), + host ) - // The whole of C7.6's sibling: one `TextInput` holding the Markdown source, and a notice bar - // over it saying so. Both go, because the page runs the real document now. + const surface = host.querySelector('#editor')! + expect(surface.querySelector('h1')?.textContent).toBe('Title') + expect(surface.querySelector('p')?.textContent).toBe('body') + expect(surface.getAttribute('contenteditable')).toBe('true') + expect(onChange).not.toHaveBeenCalled() expect(findHosts(renderer, 'TextInput')).toEqual([]) + + act(() => { + surface.innerHTML = '

edited

' + surface.dispatchEvent(new Event('input', { bubbles: true })) + }) + expect(onChange.mock.calls).toEqual([['edited']]) }) - it('renders the fifteen-command toolbar the phone renders', () => { - const renderer = render( + it('keeps the document and toolbar read-only until editing is enabled', () => { + const host = document.createElement('div') + const onChange = vi.fn() + const editor = (editable: boolean) => createElement(MobileRichMarkdownEditor, { content: 'body', - editable: true, - onChange: vi.fn() + editable, + onChange }) - ) + const renderer = render(editor(false), host) + const surface = host.querySelector('#editor')! const buttons = findHosts(renderer, 'Pressable') - expect(buttons).toHaveLength(15) - expect(buttons.map((node) => node.props.accessibilityLabel)).toContain('Image') - expect(buttons.filter((node) => node.props.disabled === true)).toEqual([]) - }) - - it('disables every command against a document that cannot be edited', () => { - const renderer = render( - createElement(MobileRichMarkdownEditor, { - content: 'body', - editable: false, - onChange: vi.fn() - }) - ) - const buttons = findHosts(renderer, 'Pressable') - expect(buttons).toHaveLength(15) + expect(buttons.length).toBeGreaterThan(0) expect(buttons.filter((node) => node.props.disabled !== true)).toEqual([]) - }) + expect(surface.getAttribute('contenteditable')).toBe('false') + act(() => { + surface.dispatchEvent(new Event('input', { bubbles: true })) + }) + expect(onChange).not.toHaveBeenCalled() - it('keeps the URL modal mounted and closed until a command asks for one', () => { - // The seam `window.prompt` could not be: both shells cancel the dialog without showing it, so - // Link and Image did nothing at all on the phone. Whether the modal opens on a command is the - // render check's to measure; that the page carries one, shut, is this file's. - const renderer = render( - createElement(MobileRichMarkdownEditor, { - content: 'body', - editable: true, - onChange: vi.fn() - }) - ) - const modals = findHosts(renderer, 'TextInputModal') - expect(modals).toHaveLength(1) - expect(modals[0]?.props.visible).toBe(false) - }) - - it('never calls onKeyboardInsetChange, because the screen measures the same viewport', () => { - const onKeyboardInsetChange = vi.fn() - render( - createElement(MobileRichMarkdownEditor, { - content: 'body', - editable: true, - onChange: vi.fn(), - onKeyboardInsetChange - }) - ) - expect(onKeyboardInsetChange).not.toHaveBeenCalled() + act(() => renderer.update(editor(true))) + const enabled = findHosts(renderer, 'Pressable') + expect(enabled).toHaveLength(buttons.length) + expect(enabled.filter((node) => node.props.disabled === true)).toEqual([]) + expect(surface.getAttribute('contenteditable')).toBe('true') + act(() => { + surface.innerHTML = '

accepted

' + surface.dispatchEvent(new Event('input', { bubbles: true })) + }) + expect(onChange.mock.calls).toEqual([['accepted']]) }) }) @@ -194,23 +163,6 @@ describe('the html preview on the page', () => { expect(findHosts(renderer, 'Pressable')).toHaveLength(2) }) - it('shows the source when the toggle is flipped, and takes the frame away with it', () => { - const renderSource = vi.fn(renderSourceMarker) - const renderer = render(createElement(MobileHtmlPreview, { html: '

hi

', renderSource })) - expect(findHosts(renderer, 'SourceView')).toHaveLength(0) - - const toSource = findHosts(renderer, 'Pressable').find( - (node) => node.props.accessibilityLabel === 'View HTML source' - ) - expect(toSource).toBeDefined() - act(() => toSource?.props.onPress()) - - expect(findHosts(renderer, 'SourceView')).toHaveLength(1) - expect(renderSource).toHaveBeenCalled() - // The artifact is not parsed anywhere while Source is showing. - expect(findHosts(renderer, 'iframe')).toHaveLength(0) - }) - it('says which side of the toggle is showing', () => { const renderer = render( createElement(MobileHtmlPreview, { html: '

hi

', renderSource: renderSourceMarker }) diff --git a/mobile/src/components/new-workspace-reply-schema.test.ts b/mobile/src/components/new-workspace-reply-schema.test.ts index ebacbdfc27e..117db098699 100644 --- a/mobile/src/components/new-workspace-reply-schema.test.ts +++ b/mobile/src/components/new-workspace-reply-schema.test.ts @@ -2,8 +2,7 @@ import { describe, expect, it } from 'vitest' import type { z } from 'zod' import { newWorkspaceRepoHooksSchema, - newWorkspaceUiTrustSchema, - SETUP_RUN_POLICIES + newWorkspaceUiTrustSchema } from './new-workspace-reply-schema' function reads(schema: z.ZodType, value: unknown): T { @@ -45,15 +44,6 @@ describe('the drawer requires only what it reads unguarded', () => { }) describe('the setup run policy is a closed enum with the call site defaulting it', () => { - // The arm list is pinned to SetupRunPolicy in the schema module, where tsc looks. - it('keeps each arm the drawer compares against', () => { - for (const policy of SETUP_RUN_POLICIES) { - expect( - reads(newWorkspaceRepoHooksSchema, { source: null, setupRunPolicy: policy }).setupRunPolicy - ).toBe(policy) - } - }) - it('drops an arm this build does not know, which behaves as run-by-default did', () => { expect( reads(newWorkspaceRepoHooksSchema, { source: null, setupRunPolicy: 'on-tuesdays' }) diff --git a/mobile/src/components/new-worktree-form-sheet-visibility.test.ts b/mobile/src/components/new-worktree-form-sheet-visibility.test.ts index dfbad5abf50..df87ee12cc8 100644 --- a/mobile/src/components/new-worktree-form-sheet-visibility.test.ts +++ b/mobile/src/components/new-worktree-form-sheet-visibility.test.ts @@ -8,15 +8,6 @@ describe('resolveNewWorktreeFormSheetVisible', () => { ) }) - // The host Modal stays mounted across every drawer swap, so a transition that - // renders no sheet is a transparent tap-swallowing screen with no way out if - // the queued transition never lands. - it('never leaves the mounted modal without a sheet during a drawer swap', () => { - expect( - resolveNewWorktreeFormSheetVisible({ modalVisible: true, drawerView: 'transition' }) - ).toBe(true) - }) - it('yields the window to the content-sized pickers and the trust prompt', () => { for (const drawerView of ['project', 'runTarget', 'agent', 'trust']) { expect(resolveNewWorktreeFormSheetVisible({ modalVisible: true, drawerView })).toBe(false) diff --git a/mobile/src/components/pr-sidebar/markdown-blocks.test.ts b/mobile/src/components/pr-sidebar/markdown-blocks.test.ts index 0501200e19e..ebefb8d71ef 100644 --- a/mobile/src/components/pr-sidebar/markdown-blocks.test.ts +++ b/mobile/src/components/pr-sidebar/markdown-blocks.test.ts @@ -60,7 +60,7 @@ describe('parseMarkdownBlocks', () => { ]) }) - it('keeps text around an HTML block in order and strips stray inline tags', () => { + it('keeps text around HTML blocks in order and leaves inline tags for inline parsing', () => { const blocks = parseMarkdownBlocks('Before.\n
q
\nAfter X.') expect(blocks).toEqual([ { kind: 'paragraph', text: 'Before.' }, @@ -71,7 +71,7 @@ describe('parseMarkdownBlocks', () => { it('is total — never throws on empty, whitespace, or an unterminated fence', () => { expect(parseMarkdownBlocks('')).toEqual([]) - expect(() => parseMarkdownBlocks(' \n\n ')).not.toThrow() + expect(parseMarkdownBlocks(' \n\n ')).toEqual([]) const open = parseMarkdownBlocks('```\nunterminated') expect(open).toEqual([{ kind: 'code', text: 'unterminated', lang: '' }]) }) @@ -171,10 +171,18 @@ describe('parseMarkdownBlocks tables', () => { expect(headerOnly).toEqual([ { kind: 'table', headers: ['A', 'B'], align: ['left', 'left'], rows: [] } ]) - // Ragged rows (fewer/more cells than headers) must not throw. const ragged = ['| A | B | C |', '| --- | --- | --- |', '| 1 |', '| 1 | 2 | 3 | 4 |'] - expect(() => parseMarkdownBlocks(ragged.join('\n'))).not.toThrow() - expect(() => parseMarkdownBlocks('|||\n|:-:|')).not.toThrow() + expect(parseMarkdownBlocks(ragged.join('\n'))).toEqual([ + { + kind: 'table', + headers: ['A', 'B', 'C'], + align: ['left', 'left', 'left'], + rows: [['1'], ['1', '2', '3', '4']] + } + ]) + expect(parseMarkdownBlocks('|||\n|:-:|')).toEqual([ + { kind: 'table', headers: ['', ''], align: ['center'], rows: [] } + ]) }) }) diff --git a/mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts b/mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts index 5510d688307..c7f3d6ea26d 100644 --- a/mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts +++ b/mobile/src/components/pr-sidebar/pr-checks-presentation.test.ts @@ -1,7 +1,6 @@ import { describe, expect, it } from 'vitest' import type { PRCheckDetail } from '../../../../src/shared/github/check-types' import { - checkOutcome, firstFailingCheckKey, getPRReviewerRows, prCheckKey, @@ -21,36 +20,32 @@ function check(over: Partial): PRCheckDetail { } } -describe('checkOutcome', () => { - it('treats a completed null-conclusion check as neutral, not failure', () => { - expect(checkOutcome(check({ status: 'completed', conclusion: null }))).toBe('neutral') - }) - it('treats queued/in_progress as pending', () => { - expect(checkOutcome(check({ status: 'queued', conclusion: null }))).toBe('pending') - expect(checkOutcome(check({ status: 'in_progress', conclusion: null }))).toBe('pending') - }) - it('maps failure/cancelled/timed_out to failure', () => { - expect(checkOutcome(check({ conclusion: 'failure' }))).toBe('failure') - expect(checkOutcome(check({ conclusion: 'cancelled' }))).toBe('failure') - expect(checkOutcome(check({ conclusion: 'timed_out' }))).toBe('failure') - }) - it('maps a merge-blocking action_required gate to failure', () => { - expect(checkOutcome(check({ conclusion: 'action_required' }))).toBe('failure') - }) - it('maps skipped to success and neutral to neutral (desktop parity)', () => { - expect(checkOutcome(check({ conclusion: 'skipped' }))).toBe('success') - expect(checkOutcome(check({ conclusion: 'neutral' }))).toBe('neutral') - }) -}) - describe('sortPRChecks', () => { - it('orders failures first, then pending, then success', () => { + it('orders actionable failures, pending work, neutral checks, then successes', () => { const checks = [ check({ name: 'ok', conclusion: 'success' }), check({ name: 'pending', status: 'in_progress', conclusion: null }), - check({ name: 'broke', conclusion: 'failure' }) + check({ name: 'completed-without-conclusion', conclusion: null }), + check({ name: 'skipped', conclusion: 'skipped' }), + check({ name: 'broke', conclusion: 'failure' }), + check({ name: 'queued', status: 'queued', conclusion: null }), + check({ name: 'cancelled', conclusion: 'cancelled' }), + check({ name: 'neutral', conclusion: 'neutral' }), + check({ name: 'timed-out', conclusion: 'timed_out' }), + check({ name: 'action-required', conclusion: 'action_required' }) ] - expect(sortPRChecks(checks).map((c) => c.name)).toEqual(['broke', 'pending', 'ok']) + expect(sortPRChecks(checks).map((c) => c.name)).toEqual([ + 'broke', + 'cancelled', + 'timed-out', + 'action-required', + 'pending', + 'queued', + 'completed-without-conclusion', + 'neutral', + 'ok', + 'skipped' + ]) }) it('is stable within a bucket', () => { const checks = [ diff --git a/mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts b/mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts index 73ff9253ac5..4c898a58bfe 100644 --- a/mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts +++ b/mobile/src/components/pr-sidebar/pr-conflict-presentation.test.ts @@ -2,7 +2,6 @@ import { describe, expect, it } from 'vitest' import type { PRInfo } from '../../../../src/shared/github/pull-request-types' import { buildMergeabilityRefreshCommands, - hasMergeConflicts, resolveConflictDisplay } from './pr-conflict-presentation' @@ -19,14 +18,6 @@ function pr(over: Partial): PRInfo { } } -describe('hasMergeConflicts', () => { - it('is true only for CONFLICTING', () => { - expect(hasMergeConflicts(pr({ mergeable: 'CONFLICTING' }))).toBe(true) - expect(hasMergeConflicts(pr({ mergeable: 'MERGEABLE' }))).toBe(false) - expect(hasMergeConflicts(pr({ mergeable: 'UNKNOWN' }))).toBe(false) - }) -}) - describe('resolveConflictDisplay', () => { it('builds safe mergeability refresh commands', () => { expect(buildMergeabilityRefreshCommands()).toBe( diff --git a/mobile/src/components/pr-state-token.test.ts b/mobile/src/components/pr-state-token.test.ts index a34a077dd6e..d9b0d2bdeb0 100644 --- a/mobile/src/components/pr-state-token.test.ts +++ b/mobile/src/components/pr-state-token.test.ts @@ -1,40 +1,10 @@ import { describe, expect, it } from 'vitest' import { prStateToken } from './pr-state-token' -import { prStateBadge } from './pr-sidebar/pr-checks-presentation' -import { statusColor } from './pr-sidebar/pr-sidebar-status-color' -import { colors } from '../theme/mobile-theme' describe('prStateToken', () => { - it('maps PR states to the desktop-matching status palette', () => { - expect(prStateToken('merged')).toBe('statusPurple') - expect(prStateToken('open')).toBe('statusGreen') - expect(prStateToken('closed')).toBe('statusRed') - expect(prStateToken('draft')).toBe('textSecondary') - }) - it('is case-insensitive and falls back to muted for unknown states', () => { expect(prStateToken('MERGED')).toBe('statusPurple') expect(prStateToken('unknown')).toBe('textSecondary') expect(prStateToken('')).toBe('textSecondary') }) - - it('resolves to the expected concrete colors', () => { - expect(statusColor(prStateToken('merged'))).toBe(colors.statusPurple) - expect(statusColor(prStateToken('open'))).toBe(colors.statusGreen) - expect(statusColor(prStateToken('closed'))).toBe(colors.statusRed) - expect(statusColor(prStateToken('draft'))).toBe(colors.textSecondary) - }) -}) - -describe('workspace-list and PR-sidebar palette agreement', () => { - // Both surfaces must resolve the SAME color for the same state so the - // linked-PR badge and the sidebar state badge never drift. - it.each(['open', 'closed', 'merged', 'draft'] as const)( - 'sidebar badge and list badge agree for %s', - (state) => { - const listColor = statusColor(prStateToken(state)) - const sidebarColor = statusColor(prStateBadge(state).token) - expect(sidebarColor).toBe(listColor) - } - ) }) diff --git a/mobile/src/components/rich-markdown/document-lifecycle.test.ts b/mobile/src/components/rich-markdown/document-lifecycle.test.ts index 19b681f6904..f06956ea72b 100644 --- a/mobile/src/components/rich-markdown/document-lifecycle.test.ts +++ b/mobile/src/components/rich-markdown/document-lifecycle.test.ts @@ -1,13 +1,7 @@ // @vitest-environment happy-dom -import { afterEach, describe, expect, it, vi } from 'vitest' +import { afterEach, describe, expect, it } from 'vitest' import { quietRichMarkdownEditorHost } from './rich-markdown-editor-host.test-support' -import { - createRichMarkdownEditorDocument, - startRichMarkdownEditorDocument, - stopRichMarkdownEditorDocument -} from './create-rich-markdown-editor-document' -import { createRichMarkdownEditorScope } from './document-scope' -import { emitChange, setMarkdown } from './editor-content' +import { createRichMarkdownEditorDocument } from './create-rich-markdown-editor-document' import { RICH_MARKDOWN_EDITOR_MARKUP } from './document-markup' import type { MobileRichMarkdownEditorMessage } from '../mobile-rich-markdown-editor-contract' import type { RichMarkdownEditorDocument } from './document-host-seams' @@ -127,41 +121,6 @@ describe('an editor document that is stopped', () => { expect(first).toEqual([{ type: 'change', markdown: 'shared markup', generation: 3 }]) }) - it('cancels a change still waiting on a timer, which no listener removal can reach', () => { - // A listener comes off with the element it was on; a scheduled callback holds the scope and - // would fire into a document the host has already unmounted. Nothing schedules the handle - // today, so the pending change is planted here — the seam and the field exist for the day - // something does, and the cancel has to already be in `stop` when it arrives. - const posted: MobileRichMarkdownEditorMessage[] = [] - plantMarkup() - vi.useFakeTimers() - try { - const scope = createRichMarkdownEditorScope( - quietRichMarkdownEditorHost({ - postToHost: (message) => posted.push(message), - keyboardInsetSource: () => null - }) - ) - startRichMarkdownEditorDocument(scope) - setMarkdown(scope, 'body', 2) - posted.length = 0 - - // The control: while the document is running, the pending change is posted. - scope.inputTimer = window.setTimeout(() => emitChange(scope), 0) - vi.runAllTimers() - expect(posted).toEqual([{ type: 'change', markdown: 'body', generation: 2 }]) - - posted.length = 0 - scope.inputTimer = window.setTimeout(() => emitChange(scope), 0) - stopRichMarkdownEditorDocument(scope) - expect(scope.inputTimer).toBe(null) - vi.runAllTimers() - expect(posted).toEqual([]) - } finally { - vi.useRealTimers() - } - }) - it('drops a command whose dialog answered after the host moved on', async () => { // `promptForUrl` is a modal on the page, so it is a task boundary: between the toolbar press // and the URL coming back, the host can replace the content, make the editor read-only or diff --git a/mobile/src/components/rich-markdown/editor-content.test.ts b/mobile/src/components/rich-markdown/editor-content.test.ts index 1d2592d247b..169ab355587 100644 --- a/mobile/src/components/rich-markdown/editor-content.test.ts +++ b/mobile/src/components/rich-markdown/editor-content.test.ts @@ -19,12 +19,10 @@ const started: RichMarkdownEditorDocument[] = [] function editorDocument() { document.body.innerHTML = RICH_MARKDOWN_EDITOR_MARKUP const posted: MobileRichMarkdownEditorMessage[] = [] - const cleared: (number | null)[] = [] const document_ = createRichMarkdownEditorDocument( quietRichMarkdownEditorHost({ postToHost: (message) => posted.push(message), - keyboardInsetSource: () => null, - clearTimer: (handle) => cleared.push(handle) + keyboardInsetSource: () => null }) ) started.push(document_) @@ -32,7 +30,6 @@ function editorDocument() { return { handle: document_.send, posted, - cleared, editor: document.getElementById('editor')!, type: () => document.getElementById('editor')!.dispatchEvent(new Event('input')) } @@ -66,8 +63,6 @@ describe('the editor document content', () => { }) it('posts the change on the spot, with no timer between the edit and the host', () => { - // There is no debounce, and the pending handle is cleared before every replacement so that - // adding one later cannot leak a change from the content it has already replaced. const editor = editorDocument() vi.useFakeTimers() try { @@ -78,7 +73,6 @@ describe('the editor document content', () => { } finally { vi.useRealTimers() } - expect(editor.cleared).toEqual([null, null]) }) it('says nothing while it is rewriting itself', () => { diff --git a/mobile/src/components/rich-markdown/markdown-round-trip.test.ts b/mobile/src/components/rich-markdown/markdown-round-trip.test.ts index 952d13cdefc..d09a8155bc0 100644 --- a/mobile/src/components/rich-markdown/markdown-round-trip.test.ts +++ b/mobile/src/components/rich-markdown/markdown-round-trip.test.ts @@ -1,4 +1,5 @@ // @vitest-environment happy-dom +import { runInNewContext } from 'node:vm' import { describe, expect, it } from 'vitest' import { quietRichMarkdownEditorHost } from './rich-markdown-editor-host.test-support' import { createRichMarkdownEditorScope } from './document-scope' @@ -178,22 +179,22 @@ describe('the editor document, from markdown and back', () => { // after the hashes and `parseListLine` needs text after the marker, so neither consumed the // line and the index never moved: `markdownToHtml` looped forever on a one-line source the // host could hand it from any file. Bare markers are text. - expect(markdownToHtml(createRichMarkdownEditorScope(quietRichMarkdownEditorHost()), '# ')).toBe( - '

#

' - ) - expect(markdownToHtml(createRichMarkdownEditorScope(quietRichMarkdownEditorHost()), '- ')).toBe( - '

-

' - ) - expect( - markdownToHtml(createRichMarkdownEditorScope(quietRichMarkdownEditorHost()), '1. ') - ).toBe('

1.

') + const render = (markdown: string) => + runInNewContext( + 'markdownToHtml(scope, markdown)', + { + markdownToHtml, + scope: createRichMarkdownEditorScope(quietRichMarkdownEditorHost()), + markdown + }, + { timeout: 250 } + ) + expect(render('# ')).toBe('

#

') + expect(render('- ')).toBe('

-

') + expect(render('1. ')).toBe('

1.

') // The control, so the guard is not swallowing the readers it falls back from. - expect( - markdownToHtml(createRichMarkdownEditorScope(quietRichMarkdownEditorHost()), '# ok') - ).toBe('

ok

') - expect( - markdownToHtml(createRichMarkdownEditorScope(quietRichMarkdownEditorHost()), '- ok') - ).toBe('

  • ok

') + expect(render('# ok')).toBe('

ok

') + expect(render('- ok')).toBe('

  • ok

') }) it('renders no link for a javascript: URL, which is the one scheme it filters', () => { diff --git a/mobile/src/components/rich-markdown/page-stylesheet.test.ts b/mobile/src/components/rich-markdown/page-stylesheet.test.ts index b572d0d1795..b3e703b63c2 100644 --- a/mobile/src/components/rich-markdown/page-stylesheet.test.ts +++ b/mobile/src/components/rich-markdown/page-stylesheet.test.ts @@ -26,12 +26,6 @@ function selectorsOf(css: string): string[] { } describe('the editor stylesheet on the page', () => { - it('reaches nothing outside the host', () => { - const selectors = selectorsOf(scopeDocumentStyleToHost(richMarkdownEditorStyle(), PREFIX)) - expect(selectors.length).toBeGreaterThan(40) - expect(selectors.filter((one) => one !== PREFIX && !one.startsWith(`${PREFIX} `))).toEqual([]) - }) - it('moves the document’s own rules onto the host rather than dropping them', () => { const scoped = scopeDocumentStyleToHost(richMarkdownEditorStyle(), PREFIX) // The variables every other rule reads. Dropped, the sheet would render unstyled while every @@ -76,11 +70,4 @@ describe('the editor stylesheet on the page', () => { // The bare name is still the host itself, which is the case the sheet actually has. expect(scopeDocumentStyleToHost(':root { color: red; }', PREFIX)).toContain(`${PREFIX} {`) }) - - it('refuses a sheet whose shape it cannot rewrite, as the other half does', () => { - expect(() => - scopeDocumentStyleToHost('@media (min-width: 1px) { .a { color: red; } }', PREFIX) - ).toThrow('at-rules cannot be scoped') - expect(() => scopeDocumentStyleToHost('.a { color: red;', PREFIX)).toThrow('never closes') - }) }) diff --git a/mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts b/mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts index 343f33ddba7..fed9bb684f7 100644 --- a/mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts +++ b/mobile/src/components/rich-markdown/rich-markdown-document-parse-time.test.ts @@ -182,10 +182,4 @@ describe('the rich Markdown editor document at parse time', () => { ) ).toEqual([[], [], []]) }) - - it('would name a start the sequence forgot, which is what the comparison above is for', () => { - const planted = sequenceCallsTo('startRichMarkdownEditorDocument') - expect(planted).not.toContain('startEditorCommands') - expect([...planted, 'startEditorCommands'].sort()).not.toEqual(planted.slice().sort()) - }) }) diff --git a/mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts b/mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts index 5766e0e7cdd..d120c25bd81 100644 --- a/mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts +++ b/mobile/src/components/rich-markdown/rich-markdown-host-seams.test.ts @@ -2,7 +2,6 @@ import { afterEach, describe, expect, it, vi } from 'vitest' import { quietRichMarkdownEditorHost } from './rich-markdown-editor-host.test-support' import { createRichMarkdownEditorDocument } from './create-rich-markdown-editor-document' -import { createRichMarkdownEditorScope } from './document-scope' import { RICH_MARKDOWN_EDITOR_MARKUP } from './document-markup' import type { MobileRichMarkdownEditorMessage } from '../mobile-rich-markdown-editor-contract' import type { RichMarkdownEditorDocument, RichMarkdownEditorHost } from './document-host-seams' @@ -29,28 +28,6 @@ afterEach(() => { vi.unstubAllGlobals() }) -describe('the editor document host seams, by default', () => { - it('clears a real timer, and a handle that was never set', () => { - const scope = createRichMarkdownEditorScope(quietRichMarkdownEditorHost()) - const fired = vi.fn() - vi.useFakeTimers() - try { - scope.clearTimer(window.setTimeout(fired, 0)) - vi.runAllTimers() - expect(fired).not.toHaveBeenCalled() - expect(() => scope.clearTimer(null)).not.toThrow() - } finally { - vi.useRealTimers() - } - }) - - it('takes the selection and the page from the window the document is running in', () => { - const scope = createRichMarkdownEditorScope(quietRichMarkdownEditorHost()) - expect(scope.getDocument()).toBe(document) - expect(scope.getSelection()).toBe(window.getSelection()) - }) -}) - describe('the editor document host seams, once the page sets them', () => { it('routes every message to the field and nothing to the bridge', () => { const postMessage = vi.fn<(data: string) => void>() diff --git a/mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts b/mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts index 1c6234d2af7..0c69e85bf3b 100644 --- a/mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts +++ b/mobile/src/components/rich-markdown/rich-markdown-web-document-mount.test.ts @@ -69,12 +69,12 @@ describe('the editor document mounted in the page', () => { const sheets = document.querySelectorAll('#orca-rich-markdown-document-style') expect(sheets).toHaveLength(1) const text = sheets[0]!.textContent ?? '' - expect(text.length).toBeGreaterThan(1000) const selectors = [...text.matchAll(/(?:^|\})\s*([^{}]+)\{/g)].flatMap((match) => match[1]!.split(',').map((one) => one.trim()) ) - expect(selectors.length).toBeGreaterThan(40) - expect(selectors.filter((one) => !one.startsWith(`.${RICH_MARKDOWN_HOST_CLASS}`))).toEqual([]) + expect(selectors.length).toBeGreaterThan(0) + const prefix = `.${RICH_MARKDOWN_HOST_CLASS}` + expect(selectors.filter((one) => one !== prefix && !one.startsWith(`${prefix} `))).toEqual([]) }) it('gives the host back on dispose, so every rule of the sheet matches nothing', () => { diff --git a/mobile/src/components/right-drawer-hardware-back.test.tsx b/mobile/src/components/right-drawer-hardware-back.test.tsx index f12a9616e9b..b5b8145c090 100644 --- a/mobile/src/components/right-drawer-hardware-back.test.tsx +++ b/mobile/src/components/right-drawer-hardware-back.test.tsx @@ -63,18 +63,18 @@ function DrawerBody(): null { return null } -function drawer(visible: boolean): ReactElement { +function drawer(visible: boolean, onClose: () => void = () => {}): ReactElement { return ( - {}}> + ) } -function render(visible: boolean): ReactTestRenderer { +function render(visible: boolean, onClose?: () => void): ReactTestRenderer { let renderer!: ReactTestRenderer act(() => { - renderer = create(drawer(visible)) + renderer = create(drawer(visible, onClose)) }) return renderer } @@ -95,10 +95,15 @@ afterEach(() => { * `use-back-claim.web.ts` and is tested there. */ describe('the right drawer and the phone hardware back button', () => { - it('arms it on iOS while the drawer is open', () => { - const renderer = render(true) + it('consumes an iOS hardware back press and closes the open drawer', () => { + const onClose = vi.fn() + const renderer = render(true, onClose) expect(native.addEventListener).toHaveBeenCalledTimes(1) expect(native.addEventListener.mock.calls[0]?.[0]).toBe('hardwareBackPress') + const handler = native.addEventListener.mock.calls[0]![1] + expect(onClose).not.toHaveBeenCalled() + act(() => expect(handler()).toBe(true)) + expect(onClose).toHaveBeenCalledTimes(1) act(() => renderer.unmount()) }) diff --git a/mobile/src/components/use-html-preview-link-grant.web.test.tsx b/mobile/src/components/use-html-preview-link-grant.web.test.tsx index b458a4f475b..5de42342c2a 100644 --- a/mobile/src/components/use-html-preview-link-grant.web.test.tsx +++ b/mobile/src/components/use-html-preview-link-grant.web.test.tsx @@ -28,7 +28,6 @@ import { type BridgePortPair } from '../mobile-web-shell/bridge/bridge-port-pair-test-harness' import { useHtmlPreviewLinkGrant } from './use-html-preview-link-grant.web' -import { useHtmlPreviewLinkGrant as useHtmlPreviewLinkGrantNatively } from './use-html-preview-link-grant' const held: { granted: boolean | null } = { granted: null } @@ -78,10 +77,6 @@ describe('whether a link in the HTML preview opens, on the web', () => { expect(await mount(createFakeBridgePortPair({ routeGrants: [] }))).toBe(false) }) - it('is unconditional on native, where the preview is its own WebView', () => { - expect(useHtmlPreviewLinkGrantNatively()).toBe(true) - }) - // Checked against the contract rather than by eye: a route naming a grant the manifest refuses // never reaches a shell, so the preview would hide its links for a reason no screen could report. it('is a name the bundle manifest will carry, on either lane', () => { diff --git a/mobile/tests-typecheck-baseline.txt b/mobile/tests-typecheck-baseline.txt index 10bb77f63a3..30f2b0b9d8a 100644 --- a/mobile/tests-typecheck-baseline.txt +++ b/mobile/tests-typecheck-baseline.txt @@ -17,7 +17,6 @@ src/components/agent-monitoring-indicators.test.ts src/components/bottom-drawer-close-lifecycle.test.ts src/components/bottom-drawer-window-handback.test.ts src/components/codex-reset-credit-capability.test.ts -src/components/mobile-agent-icon-gradient.test.ts src/components/pr-sidebar/PRCommentsSection.test.ts src/diagnostics/connection-diagnostics-submission.test.ts src/dictation/mobile-dictation-setup.test.ts diff --git a/src/main/claude/claude-history-window-source-budget.test.ts b/src/main/claude/claude-history-window-source-budget.test.ts index 90d74b94e37..910a1003ae2 100644 --- a/src/main/claude/claude-history-window-source-budget.test.ts +++ b/src/main/claude/claude-history-window-source-budget.test.ts @@ -194,10 +194,10 @@ describe('Claude provider history source budget', () => { expect(state.bytesRead).toBeGreaterThan(2 * LEGACY_LIMIT) }) - it('keeps resident bytes bounded by the chunk size, not the file size', async () => { + it('reads a large history in chunks smaller than 1 MiB', async () => { await writeFile(state.path, padTo(LEGACY_LIMIT + 1)) expect((await read()).boundaryConsistent).toBe(true) - // A whole-file read would show one chunk the size of the transcript. + // Bound chunks handed to the framer; this does not measure retained memory. expect(state.peakChunkBytes).toBeLessThan(1024 * 1024) })