starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-11-06 20:17:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stop native chat jumping when Codex starts a foreground command (#26503)

Browse Source 
* Keep foreground Codex commands out of the background strip

* Run the command-strip host regression in Node

* Exercise retained commands after their source turns end
This commit is contained in:
Brennan Benson
2026-10-08 13:02:03 -07:00
committed by GitHub
parent 5de53910aa
commit a062abffd2
18 changed files with 549 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/codex/codex-background-command-tracker.test.ts
+23 -3
View File
@@ -35,6 +35,23 @@ function command(method: string, id = 'exec', threadId = 'root') {
}
describe('persistent command ownership', () => {
it('promotes only the launching turn and recognizes a start delivered after its end', () => {
const tracker = new CodexBackgroundCommandTracker('root')
tracker.observe(command('item/started'))
expect(tracker.tasks()).toEqual([])
expect(tracker.endTurn('root', 'another-turn')).toEqual([])
expect(tracker.endTurn('child', 'turn')).toEqual([])
expect(tracker.tasks()).toEqual([])
expect(tracker.endTurn('root', 'turn')).toHaveLength(1)
expect(tracker.tasks()).toHaveLength(1)
expect(tracker.endTurn('root', 'turn')).toEqual([])
tracker.observe(command('item/started', 'late'))
expect(tracker.tasks()).toHaveLength(2)
tracker.clear()
tracker.observe(command('item/started', 'new'))
expect(tracker.tasks()).toEqual([])
})
it('preflights finite metadata capacity and admits work again after process completion', () => {
const tracker = new CodexBackgroundCommandTracker('root', 700)
const first = command('item/started', 'first')
@@ -43,12 +60,12 @@ describe('persistent command ownership', () => {
tracker.observe(first)
expect(tracker.canObserve(second)).toBe(false)
expect(() => tracker.observe(second)).toThrow('not admitted')
expect(tracker.tasks()).toHaveLength(1)
expect(tracker.threadCommands('root')).toHaveLength(1)
expect(tracker.retainedMetadataBytes).toBeLessThanOrEqual(700)
tracker.observe(command('item/completed', 'first'))
expect(tracker.canObserve(second)).toBe(true)
tracker.observe(second)
expect(tracker.tasks()).toHaveLength(1)
expect(tracker.threadCommands('root')).toHaveLength(1)
expect(tracker.retainedMetadataBytes).toBeLessThanOrEqual(700)
tracker.clear()
expect(tracker.retainedMetadataBytes).toBe(0)
@@ -73,10 +90,11 @@ describe('persistent command ownership', () => {
deliver(command('item/started'))
const originalKey = rows.find(({ body }) => body.kind === 'tool-call')?.key
deliver(notification('turn/completed', { turn: { id: 'turn' } }))
tracker.endTurn('root', 'turn')
expect(rows.filter(({ body }) => body.kind === 'tool-call').map(({ body }) => body)).toEqual([
expect.objectContaining({ state: 'running' })
])
expect(tracker.tasks()).toHaveLength(1)
expect(tracker.threadCommands('root')).toHaveLength(1)
deliver(
notification('item/commandExecution/outputDelta', { itemId: 'exec', delta: 'late output' })
)
@@ -102,6 +120,7 @@ describe('persistent command ownership', () => {
})
)
expect(tracker.tasks(new Set(['child']))).toEqual([])
tracker.endTurn('child', 'turn')
expect(tracker.tasks()).toEqual([
{ id: 'codex-command:thread:child:child-exec', kind: 'command', description: 'sleep 30' }
])
@@ -119,6 +138,7 @@ describe('persistent command ownership', () => {
tracker.observe(command('item/started', `short-${index}`))
tracker.observe(command('item/completed', `short-${index}`))
}
tracker.endTurn('root', 'turn')
expect(tracker.tasks()).toEqual([
{ id: 'codex-command:primary:long-lived', kind: 'command', description: 'sleep 30' }
])