From a070b00dda92b51a5db962ea31f10553dceafd02 Mon Sep 17 00:00:00 2001
From: Frederic Barthelemy <git@fbartho.com>
Date: Sat, 12 Sep 2026 17:08:34 -0700
Subject: [PATCH] test(editor): guard the details start hook's early exit by
 scan count

The 1000ms ceiling passed even with the early return removed, since the
guarded per-paragraph scans cost far less than the bound on this input.
Assert markdownFenceRanges/markdownCodeSpanRanges call counts instead:
zero for a toggle-free document, one per call whose remaining source
holds the toggle. The wall-clock check survives as an opt-in benchmark
gated by ORCA_DETAILS_SCAN_BENCH, matching this repo's existing
bench-test convention.

# Conflicts:
#	src/renderer/src/components/editor/markdown-scan-ranges.test.ts
---
 .../editor/markdown-scan-ranges.test.ts       | 81 ++++++++++++++++++-
 1 file changed, 80 insertions(+), 1 deletion(-)

diff --git a/src/renderer/src/components/editor/markdown-scan-ranges.test.ts b/src/renderer/src/components/editor/markdown-scan-ranges.test.ts
index c5914498edf..5c9d501e45d 100644
--- a/src/renderer/src/components/editor/markdown-scan-ranges.test.ts
+++ b/src/renderer/src/components/editor/markdown-scan-ranges.test.ts
@@ -1,6 +1,11 @@
-import { describe, expect, it } from 'vitest'
+import { afterEach, describe, expect, it, vi } from 'vitest'
 import { findDetailsBlockStart } from './details-markdown-html'
 import { markdownCodeSpanRanges, markdownFenceRanges } from './markdown-scan-ranges'
+import * as markdownScanRanges from './markdown-scan-ranges'
+
+afterEach(() => {
+  vi.restoreAllMocks()
+})
 
 describe('markdownCodeSpanRanges', () => {
   it('reports a span whose backtick run closes on an equal run', () => {
@@ -76,6 +81,80 @@ describe('findDetailsBlockStart with fenced content', () => {
   })
 })
 
+describe('findDetailsBlockStart cost on documents without a toggle', () => {
+  it('never scans fence or code-span ranges for a toggle-free document', () => {
+    const fenceSpy = vi.spyOn(markdownScanRanges, 'markdownFenceRanges')
+    const codeSpanSpy = vi.spyOn(markdownScanRanges, 'markdownCodeSpanRanges')
+    const paragraphs = Array.from(
+      { length: 300 },
+      (_, index) => `Paragraph ${index} ${'lorem ipsum dolor sit amet '.repeat(25)}`
+    )
+    const document = paragraphs.join('\n\n')
+    expect(document.length).toBeGreaterThan(200_000)
+
+    let offset = 0
+    for (const paragraph of paragraphs) {
+      expect(findDetailsBlockStart(document.slice(offset))).toBe(-1)
+      offset += paragraph.length + 2
+    }
+
+    expect(fenceSpy).not.toHaveBeenCalled()
+    expect(codeSpanSpy).not.toHaveBeenCalled()
+  })
+
+  it('scans ranges only for calls whose remaining source holds the toggle', () => {
+    const fenceSpy = vi.spyOn(markdownScanRanges, 'markdownFenceRanges')
+    const codeSpanSpy = vi.spyOn(markdownScanRanges, 'markdownCodeSpanRanges')
+    const paragraphs = Array.from({ length: 300 }, (_, index) => `Paragraph ${index}.`)
+    paragraphs.push('<details>\n<summary>S</summary>\n\nbody\n\n</details>')
+    const document = paragraphs.join('\n\n')
+
+    let offset = 0
+    let found = -1
+    for (const paragraph of paragraphs) {
+      const relative = findDetailsBlockStart(document.slice(offset))
+      if (relative !== -1) {
+        found = offset + relative
+      }
+      offset += paragraph.length + 2
+    }
+
+    expect(found).toBe(document.indexOf('<details>'))
+    expect(fenceSpy).toHaveBeenCalledTimes(paragraphs.length)
+    expect(codeSpanSpy).toHaveBeenCalledTimes(paragraphs.length)
+  })
+
+  it.skipIf(process.env.ORCA_DETAILS_SCAN_BENCH !== '1')('benchmarks a large toggle-free document', () => {
+    const paragraphs = Array.from(
+      { length: 300 },
+      (_, index) => `Paragraph ${index} ${'lorem ipsum dolor sit amet '.repeat(25)}`
+    )
+    const document = paragraphs.join('\n\n')
+
+    const started = performance.now()
+    let offset = 0
+    for (const paragraph of paragraphs) {
+      expect(findDetailsBlockStart(document.slice(offset))).toBe(-1)
+      offset += paragraph.length + 2
+    }
+
+    process.stdout.write(`${JSON.stringify({ elapsedMs: performance.now() - started })}\n`)
+  })
+
+  it('still finds a toggle that follows a long run of prose', () => {
+    const prose = Array.from({ length: 300 }, (_, index) => `Paragraph ${index}.`).join('\n\n')
+    const document = `${prose}\n\n<details>\n<summary>S</summary>\n\nbody\n\n</details>`
+
+    expect(findDetailsBlockStart(document)).toBe(document.indexOf('<details>'))
+  })
+
+  it('finds an uppercase opening tag the lowercase fast path misses', () => {
+    const document = 'Prose paragraph.\n\n<DETAILS>\n<summary>S</summary>\n\nbody\n\n</DETAILS>'
+
+    expect(findDetailsBlockStart(document)).toBe(document.indexOf('<DETAILS>'))
+  })
+})
+
 describe('markdownFenceRanges', () => {
   it('covers the opening delimiter, content, and closing delimiter', () => {
     const content = ['```', 'x', '```', ''].join('\n')