From aaea2c6c33c9ebfef008d0a3a7d3257d69ea01ec Mon Sep 17 00:00:00 2001 From: Neil Date: Tue, 10 Nov 2026 16:41:50 -0800 Subject: [PATCH] fix(cloud): one Sign in on Agent accounts when signed out; muted note under Sign-ins by host --- .../AgentAccountsPane.fixture.tsx | 3 +-- .../overview/AgentAccountsOverview.tsx | 27 +++++-------------- .../overview/AgentAccountsOverviewSection.tsx | 11 +------- src/renderer/src/i18n/locales/en.json | 4 +-- 4 files changed, 9 insertions(+), 36 deletions(-) diff --git a/src/renderer/src/components/settings/agent-accounts/AgentAccountsPane.fixture.tsx b/src/renderer/src/components/settings/agent-accounts/AgentAccountsPane.fixture.tsx index 8d20a5ec429..0ac84022be3 100644 --- a/src/renderer/src/components/settings/agent-accounts/AgentAccountsPane.fixture.tsx +++ b/src/renderer/src/components/settings/agent-accounts/AgentAccountsPane.fixture.tsx @@ -71,8 +71,7 @@ const BASE = { signedOutOfOrca: false, summary: '', onOpenRow: noop, - onAction: noop, - onSignIn: noop + onAction: noop } const OVERVIEW_PROBES = { diff --git a/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverview.tsx b/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverview.tsx index d40a5684c30..e1fdadf2e00 100644 --- a/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverview.tsx +++ b/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverview.tsx @@ -4,7 +4,6 @@ import React, { useState } from 'react' import { useTranslate, type Translate } from '@/i18n/use-translate' import { Badge } from '@/components/ui/badge' import { Button } from '@/components/ui/button' -import { InlineError } from '@/components/ui/inline-error' import { Skeleton } from '@/components/ui/skeleton' import { cn } from '@/lib/utils' import { @@ -27,7 +26,6 @@ export type AgentAccountsOverviewProps = { summary: string onOpenRow: (row: OverviewRow) => void onAction: (row: OverviewRow, action: OverviewAction) => void - onSignIn: () => void } function actionLabel(action: OverviewAction, t: Translate): string { @@ -125,6 +123,12 @@ export function AgentAccountsOverview(props: AgentAccountsOverviewProps): React. 'Where Claude and Codex are signed in, and which key they use. Orca never copies a sign-in between machines.' )}

+ {/* One Sign in button lives in the Orca Cloud card above; this is only a muted note. */} + {props.signedOutOfOrca ? ( +

+ {t('agentAccountsOverview.signedOutNote', 'Sign in to Orca to see Orca Cloud here.')} +

+ ) : null} - {props.signedOutOfOrca ? ( - - {t('agentAccountsOverview.signIn', 'Sign in')} - - } - /> - ) : null}
{props.loading ? (
diff --git a/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverviewSection.tsx b/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverviewSection.tsx index c83b39d4a31..744545b9db8 100644 --- a/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverviewSection.tsx +++ b/src/renderer/src/components/settings/agent-accounts/overview/AgentAccountsOverviewSection.tsx @@ -3,10 +3,7 @@ import React, { useEffect, useMemo, useState } from 'react' import { useAppStore } from '@/store' import { useTranslate } from '@/i18n/use-translate' -import { - reloadOrcaCloudAgentAccounts, - useOrcaCloudAgentAccounts -} from '@/lib/orca-cloud/orca-cloud-agent-accounts-store' +import { useOrcaCloudAgentAccounts } from '@/lib/orca-cloud/orca-cloud-agent-accounts-store' import { openAgentHostPanel } from '../../../agent-host-panel/agent-host-panel-store' import { ORCA_CLOUD_ACCOUNTS_SECTION_ID } from '../OrcaCloudAccounts' import { @@ -114,12 +111,6 @@ export function AgentAccountsOverviewSection(): React.JSX.Element { summary={summary} onOpenRow={(row) => open(row)} onAction={onAction} - onSignIn={() => - void useAppStore - .getState() - .connectCurrentOrcaProfile() - .then(() => reloadOrcaCloudAgentAccounts()) - } /> ) } diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json index cbef75e39d8..4c14c29ad7e 100644 --- a/src/renderer/src/i18n/locales/en.json +++ b/src/renderer/src/i18n/locales/en.json @@ -27939,9 +27939,7 @@ "filter": "Show", "all": "All", "attention": "Needs attention · {{count}}", - "signedOut": "Sign in to Orca to see cloud workspaces here.", - "signedOutDetail": "Hosts on this computer’s list are shown below.", - "signIn": "Sign in", + "signedOutNote": "Sign in to Orca to see Orca Cloud here.", "host": "Host", "actions": "Actions", "openRow": "Open agent accounts for {{host}}",