From abeccc5905064520ac251d5850bd45a25a96cd3c Mon Sep 17 00:00:00 2001
From: Jinwoo-H <jinwoo0825@gmail.com>
Date: Thu, 10 Sep 2026 15:50:43 -0400
Subject: [PATCH] feat(ai-vault-search): expose the index handle a composed
 reader queries

PR 4's engine reads the index this store owns. One getter lets it compose over
the store's handle instead of opening a second connection to the same file,
and it carries the two rules this PR measured: never hold a read transaction
across an await, and no `.iterate()` outliving its statement. Either pins a
read snapshot, and a checkpoint cannot pass one, so the WAL grows without
bound for as long as it is held (10 MB to 266 MB on the write benchmark).
---
 .../session-search-file-write.test.ts             |  8 ++++++++
 src/main/ai-vault-search/session-search-store.ts  | 15 +++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/src/main/ai-vault-search/session-search-file-write.test.ts b/src/main/ai-vault-search/session-search-file-write.test.ts
index 63b1c9a897d..148179cb230 100644
--- a/src/main/ai-vault-search/session-search-file-write.test.ts
+++ b/src/main/ai-vault-search/session-search-file-write.test.ts
@@ -491,6 +491,14 @@ it('writes nothing for an incomplete read and owes the file a whole re-read', ()
   expect(errors).toEqual([])
 })
 
+it('exposes the handle a composed reader queries through', () => {
+  replayTranscriptRead({ messages: userMessages('composedreader', 3) })
+
+  // PR 4's engine reads through this rather than opening a second connection,
+  // so it sees a write the moment the transaction commits.
+  expect(store.connection.prepare('SELECT count(*) AS n FROM messages').get()).toEqual({ n: 3 })
+})
+
 it('closes twice without turning the second call into an error', () => {
   store.close()
   // node:sqlite throws ERR_INVALID_STATE on a second close of one handle, and a
diff --git a/src/main/ai-vault-search/session-search-store.ts b/src/main/ai-vault-search/session-search-store.ts
index 55d524cd342..50ffff83258 100644
--- a/src/main/ai-vault-search/session-search-store.ts
+++ b/src/main/ai-vault-search/session-search-store.ts
@@ -45,6 +45,21 @@ export class SessionSearchStore {
     this.writer = new SessionSearchIndexWriter(this.db)
   }
 
+  /**
+   * The index handle, for a reader composed over this store (PR 4's engine).
+   *
+   * Two rules come with it, both measured in this PR. **Never hold a read
+   * transaction across an `await`**: a checkpoint cannot pass an open read
+   * snapshot, so a paginated read that opened `BEGIN` and yielded between pages
+   * takes the WAL from 10 MB to 266 MB and it does not come back. And **no
+   * `.iterate()` that outlives its statement**, which is the same pin by
+   * another name. Every retrieval a single synchronous statement is the whole
+   * contract.
+   */
+  get connection(): SyncDatabase {
+    return this.db
+  }
+
   setAcceptingWrites(accept: boolean): void {
     this.acceptingWrites = accept
   }