mirror of
https://github.com/stablyai/orca.git
synced 2026-10-23 16:03:49 +00:00
ci(e2e): actually run the Docker-SSH specs in the changed-specs lane
"I am surprised this was not caught" has a mechanical answer: these tests do not run. A spec that reads ORCA_E2E_SSH_DOCKER test.skip()s itself when it is unset, and exactly one place in CI set it — gated on tests/e2e/ephemeral-vm-provisioned- root.spec.ts being among the changed files. So editing any SSH spec ran it as a skip and reported green. Eighteen specs reference that variable, including both reconnect regressions I have been chasing. Now it is also enabled when any changed spec references the variable, which is the same grep -l idiom the @headful check two lines below already uses. The original clause stays: that spec needs Docker without naming the variable, so replacing it rather than adding to it would have traded one silent skip for another. Simulated against the real files — the reconnect spec, the original trigger, a multi-spec change, a non-Docker SSH spec, and a deleted path — enabling in the first three, staying off in the last two, and not failing the step on a path that no longer exists.
This commit is contained in:
@@ -241,7 +241,11 @@ jobs:
|
||||
exit 0
|
||||
fi
|
||||
E2E_ENV=(SKIP_BUILD=1 ORCA_E2E_FORWARD_APP_LOGS=1 ORCA_E2E_WEB_CLIENT=1)
|
||||
if printf '%s\n' "${TEST_FILES[@]}" | grep -qx 'tests/e2e/ephemeral-vm-provisioned-root.spec.ts'; then
|
||||
# Second clause: a spec that reads ORCA_E2E_SSH_DOCKER test.skip()s itself without it, so
|
||||
# naming only one trigger silently skipped every other Docker-SSH spec in this lane.
|
||||
# The first clause stays because that spec needs Docker without referencing the variable.
|
||||
if printf '%s\n' "${TEST_FILES[@]}" | grep -qx 'tests/e2e/ephemeral-vm-provisioned-root.spec.ts' \
|
||||
|| grep -l 'ORCA_E2E_SSH_DOCKER' "${TEST_FILES[@]}" >/dev/null 2>&1; then
|
||||
E2E_ENV+=(ORCA_E2E_SSH_DOCKER=1)
|
||||
fi
|
||||
E2E_PROJECT_ARGS=()
|
||||
|
||||
Reference in New Issue
Block a user