From b070d9b40d9520045242bcce5982ee401d4d4597 Mon Sep 17 00:00:00 2001 From: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Date: Wed, 12 Aug 2026 17:47:19 -0700 Subject: [PATCH] ci: install Electron before the cross-version wire job The suite imports host/renderer wire modules that load Electron. Without the package binary, Electron's installer downloads at import time and has no retry, so a single GitHub CDN flake fails the job before any test runs. --- .github/workflows/pr.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 3c9678a5a8d..0c1fabb58ad 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -305,6 +305,12 @@ jobs: with: native-runtime: node + # Same as the sharded `test` job: importing host/renderer wire modules + # loads Electron, and Electron's own installer has no retry. The dedicated + # script retries GitHub CDN flakes instead of failing the suite at import. + - name: Install Electron package binary for tests + run: node config/scripts/install-electron-package-binary.mjs + # A path filter that matches nothing exits 1 ("No test files found"), so this # lane cannot report success while running zero tests. - name: Old/new client and server terminal journey