From b28fec317801b4b7086207db64cb0f41e30140db Mon Sep 17 00:00:00 2001 From: Neil Date: Thu, 17 Sep 2026 23:58:01 -0700 Subject: [PATCH] test(memory): rebase the pending runtime-close proof onto the squashed base `fix.patch` recorded a baseline taken against #21001's pre-squash branch tip. Squash-merging #21001 replaced that tip with a single commit, so the recorded hunks no longer reverse-applied and `reproduce.mjs` aborted with `Source changed: use-terminal-pane-close-actions.ts` -- confirmed by running it before regenerating rather than assuming the rebase alone would fix it. Regenerated against `main` and re-run: 5 pass / 10 fail before, 15 pass / 0 fail after, exit 0, and every `results.json` hash recomputed from the run rather than hand-edited. --- docs/audits/pending-runtime-pane-close/fix.patch | 12 ++++++------ docs/audits/pending-runtime-pane-close/results.json | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/audits/pending-runtime-pane-close/fix.patch b/docs/audits/pending-runtime-pane-close/fix.patch index a81e3e8aad9..b3c53432eaa 100644 --- a/docs/audits/pending-runtime-pane-close/fix.patch +++ b/docs/audits/pending-runtime-pane-close/fix.patch @@ -1,5 +1,5 @@ diff --git a/src/renderer/src/components/terminal-pane/retire-unbound-ipc-terminal-pane.ts b/src/renderer/src/components/terminal-pane/retire-unbound-ipc-terminal-pane.ts -index 081a33fc89..a3235fea66 100644 +index 081a33fc895..a3235fea66a 100644 --- a/src/renderer/src/components/terminal-pane/retire-unbound-ipc-terminal-pane.ts +++ b/src/renderer/src/components/terminal-pane/retire-unbound-ipc-terminal-pane.ts @@ -1,21 +1,16 @@ @@ -54,17 +54,17 @@ index 081a33fc89..a3235fea66 100644 return } diff --git a/src/renderer/src/components/terminal-pane/use-terminal-pane-close-actions.ts b/src/renderer/src/components/terminal-pane/use-terminal-pane-close-actions.ts -index f3966b1f75..4f13f41b61 100644 +index ea85e929e81..3e8dd463a30 100644 --- a/src/renderer/src/components/terminal-pane/use-terminal-pane-close-actions.ts +++ b/src/renderer/src/components/terminal-pane/use-terminal-pane-close-actions.ts @@ -1,5 +1,6 @@ - import { useCallback, useImperativeHandle } from 'react' + import { useCallback, useImperativeHandle, useRef } from 'react' import { useAppStore } from '../../store' +import { retireUnboundRuntimeTerminalPane } from './retire-unbound-runtime-terminal-pane' import type { PaneExternalDropTarget } from '@/lib/pane-manager/pane-manager' import { makePaneKey } from '../../../../shared/stable-pane-id' import { closeWebRuntimeTerminal } from '@/runtime/web-runtime-session' -@@ -59,6 +60,13 @@ export function useTerminalPaneCloseActions(controller: TerminalPaneBindingContr +@@ -61,6 +62,13 @@ export function useTerminalPaneCloseActions(controller: TerminalPaneBindingContr } setTerminalErrorsByPaneId((current) => clearPaneTerminalError(current, paneId)) if (leafId) { @@ -79,7 +79,7 @@ index f3966b1f75..4f13f41b61 100644 } else { syncPanePtyLayoutBinding(paneId, null) diff --git a/src/renderer/src/runtime/runtime-rpc-client.ts b/src/renderer/src/runtime/runtime-rpc-client.ts -index eb04233cc9..719e54eac8 100644 +index eb04233cc91..719e54eac89 100644 --- a/src/renderer/src/runtime/runtime-rpc-client.ts +++ b/src/renderer/src/runtime/runtime-rpc-client.ts @@ -95,7 +95,7 @@ export async function callRuntimeRpc( @@ -92,7 +92,7 @@ index eb04233cc9..719e54eac8 100644 options: { timeoutMs?: number diff --git a/src/renderer/src/store/terminals/terminal-tab-close-providers.ts b/src/renderer/src/store/terminals/terminal-tab-close-providers.ts -index 322d4106c7..4ba425d95d 100644 +index 322d4106c7e..4ba425d95d2 100644 --- a/src/renderer/src/store/terminals/terminal-tab-close-providers.ts +++ b/src/renderer/src/store/terminals/terminal-tab-close-providers.ts @@ -1,5 +1,9 @@ diff --git a/docs/audits/pending-runtime-pane-close/results.json b/docs/audits/pending-runtime-pane-close/results.json index 0897bf441f9..c8c14337687 100644 --- a/docs/audits/pending-runtime-pane-close/results.json +++ b/docs/audits/pending-runtime-pane-close/results.json @@ -6,8 +6,8 @@ "after": "f52f4b50d94e71506921788e3b49db547dbd879569d80151429adaeaa5865571" }, "src/renderer/src/components/terminal-pane/use-terminal-pane-close-actions.ts": { - "before": "22b379ff8b5277841ec4f701ed45206567266029aed8d8e0876ee4cc77d12c1b", - "after": "eeef3c514c2b74ee7c563a2679a71c880277728ed6058b838983fae08fdd642a" + "before": "bbfeb2385fd120a7a1407d043011fb689b5c2b652c31150de44061f1edb76a7b", + "after": "d9f0c08d82e70180f4e3c28ca33815314c580ba59c65cb3c5004079b56c3f227" }, "src/renderer/src/runtime/runtime-rpc-client.ts": { "before": "d0ae689153ba0d972ba7a10484c2024bf9fd08c8628bd43009396aa0f653058e",