From b4a419a66cc7cdcf2cf429b39f5614d2b2a47a05 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sat, 14 Nov 2026 19:13:58 -0800 Subject: [PATCH] fix(quick-commands): scroll the editor body with a div so Advanced options stay reachable (#42586) Chromium does not wheel-scroll an overflowing
, so on short windows or high UI scaling the Edit Quick Command dialog body could not be scrolled down to the Advanced section. Move the overflow onto a plain wrapper div and keep the fieldset for the disabled state and key handling. Fixes #42576 --- .../TerminalQuickCommandDialog.tsx | 131 +++++++++--------- 1 file changed, 67 insertions(+), 64 deletions(-) diff --git a/src/renderer/src/components/terminal-quick-commands/TerminalQuickCommandDialog.tsx b/src/renderer/src/components/terminal-quick-commands/TerminalQuickCommandDialog.tsx index 27d743108a6..6890cbf8876 100644 --- a/src/renderer/src/components/terminal-quick-commands/TerminalQuickCommandDialog.tsx +++ b/src/renderer/src/components/terminal-quick-commands/TerminalQuickCommandDialog.tsx @@ -235,73 +235,76 @@ export function TerminalQuickCommandDialog({ -
{ - if ( - event.defaultPrevented || - !(event.target instanceof Node) || - !event.currentTarget.contains(event.target) - ) { - return - } - if ( - isSelectAllShortcut(event) && - (event.target instanceof HTMLInputElement || - event.target instanceof HTMLTextAreaElement) - ) { - event.preventDefault() - event.stopPropagation() - event.target.select() - return - } - if (isScreenSubmitShortcut(event) && canSave) { - event.preventDefault() - void saveDraft() - } - }} - > -
- -
- - + {/* Why: Chromium won't wheel-scroll an overflowing fieldset, so a plain div owns the overflow. */} +
+
{ + if ( + event.defaultPrevented || + !(event.target instanceof Node) || + !event.currentTarget.contains(event.target) + ) { + return + } + if ( + isSelectAllShortcut(event) && + (event.target instanceof HTMLInputElement || + event.target instanceof HTMLTextAreaElement) + ) { + event.preventDefault() + event.stopPropagation() + event.target.select() + return + } + if (isScreenSubmitShortcut(event) && canSave) { + event.preventDefault() + void saveDraft() + } + }} + > +
+ +
+ + +
-
- + - -
+ +
+