From b621f923bdcfc20ee8017ec24bcf5c4b11c681e6 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sat, 1 Aug 2026 22:23:01 -0700 Subject: [PATCH] Record the shortcut-guard fixture shape in the IME rules A Process-key fixture cannot fail, so it certifies a guard it never ran. Co-authored-by: Orca --- AGENTS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/AGENTS.md b/AGENTS.md index 0dcbfad3371..9d5f85f4f1e 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -60,6 +60,7 @@ These rules bind any change to keyboard handling, the chat composer, the termina - `attachCustomKeyEventHandler` returning `false` does **not** call `preventDefault()`, and it bypasses xterm's `CompositionHelper` entirely. Pair the two deliberately. - Never normalize IME output at commit. Normalize only at path handling and equality/search comparison. - Add a recorded event-trace fixture for the trace that motivated the change, plus a paired negative test proving non-IME behavior is unchanged. +- Test a shortcut guard with the marked-but-real key shape (`key: 'Enter'`, `keyCode: 13`, `isComposing: true`), not `key: 'Process'`. A `Process` chord never resolves to an action, so the test passes with the guard deleted. Delete the guard and watch it fail before trusting it. ## Git Provider Compatibility