Remove redundant SSH target row in add project

Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Jinwoo-H
2026-06-13 00:58:22 -07:00
co-authored by Orca
parent 7f46ca2151
commit b8afa5e861
4 changed files with 58 additions and 12 deletions
@@ -275,3 +275,4 @@ Done means: reviewers and future agents can understand the vision, implementatio
- [x] 2026-06-13: Replaced the generic remote-server Automation manual-run block with explicit checking, disconnected/unreachable, graph-not-ready, and update-required disabled states derived from saved runtime status before the current unsupported manual-run fallback. Verified with focused automation availability tests, targeted oxlint, and full `pnpm run typecheck`.
- [x] 2026-06-13: Guarded backend automation ownership for runtime-host repos: newly saved/updated runtime-owned automations now record `remote_host_service`, and main-process dispatch resolution skips runtime targets before desktop renderer dispatch until durable remote scheduling exists. Verified with persistence and automation service regressions, targeted oxlint, and full `pnpm run typecheck`.
- [x] 2026-06-13: Preserved exact GitLab provider identity for item-specific Tasks flows by threading `GitLabWorkItem.projectRef` into the task source context used for detail pages and Start Workspace handoff. Verified with TaskPage source-boundary regression, targeted oxlint, and full `pnpm run typecheck`.
- [x] 2026-06-13: Removed the redundant locked SSH target row from the Add Project remote-path step after the host has already been selected, while preserving a compact reconnect action for disconnected locked hosts. Fresh Electron validation connected a Docker SSH target through Orca's relay IPC, added `/home/orca/host-context-e2e-local` via Add Project, and created a remote SSH worktree at `/home/orca/goldfish`; screenshots were added to the dark-background report. Verified with focused Add Project tests, targeted oxlint, and remote filesystem checks.
@@ -113,6 +113,11 @@
Add Project host selection now keeps disconnected SSH hosts visible but disabled,
and falls back to Local Mac instead of selecting a host that cannot be used.
</li>
<li class="fix">
The locked SSH Add Project path screen no longer shows a redundant
<code>SSH target</code> row or button-like host field after the host was already
selected on the previous step.
</li>
</ul>
</section>
@@ -168,6 +173,16 @@
selected. Restored the SSH status to connected afterward so the app is ready for manual
inspection.
</li>
<li class="pass">
Fresh-profile validation on 2026-06-13 connected a Docker SSH target through Orca's
real <code>ssh.connect</code> IPC/relay path, then added
<code>/home/orca/host-context-e2e-local</code> through the visible Add Project SSH flow.
</li>
<li class="pass">
From that SSH project, created a new SSH worktree. The remote filesystem contains
<code>/home/orca/goldfish</code> as a Git worktree on branch <code>goldfish</code>,
and Orca activated <code>repo-id::/home/orca/goldfish</code>.
</li>
</ul>
</section>
@@ -191,6 +206,16 @@
branch-routing tests, shared host-model tests, and another full
<code>pnpm run typecheck</code> pass.
</li>
<li class="pass">
Focused locked-SSH Add Project regression test passed:
<code>src/renderer/src/components/sidebar/AddRepoDialogStepContent.test.tsx</code>,
9 tests.
</li>
<li class="pass">
Targeted lint passed for
<code>AddRepoRemoteStep.tsx</code> and
<code>AddRepoDialogStepContent.test.tsx</code>.
</li>
<li class="warn">
Docker/SSH verification intentionally used throwaway paths under <code>/home/orca</code>
and an isolated Orca profile; evidence images are uncommitted.
@@ -272,6 +297,18 @@
<img src="artifacts/host-context-automations-ssh-source-unavailable.png" alt="Automations SSH source unavailable" />
<figcaption>Automations distinguishes a connected SSH host from an unavailable remote automation source.</figcaption>
</figure>
<figure>
<img src="artifacts/host-context-electron-ssh-connected.png" alt="Fresh profile with SSH connected" />
<figcaption>Fresh profile after connecting the Docker SSH target through Orca's SSH relay path.</figcaption>
</figure>
<figure>
<img src="artifacts/host-context-electron-ssh-project-added.png" alt="SSH project added through Add Project" />
<figcaption>Visible Add Project SSH flow added the remote Git repository and activated the primary workspace.</figcaption>
</figure>
<figure>
<img src="artifacts/host-context-electron-ssh-worktree-created.png" alt="SSH worktree created" />
<figcaption>New Worktree from the SSH project created and activated a remote SSH worktree.</figcaption>
</figure>
</section>
</main>
</body>