From bd8f2ea5afc77c675489ea6c903f6852df229bcc Mon Sep 17 00:00:00 2001 From: orca-bug-scan-bot Date: Tue, 12 May 2026 20:06:10 -0700 Subject: [PATCH] fix: address pr-bug-scan validated finding from #1700 Clear initializedHandlesRef on reconnect so the auto-resubscribed scrollback frame re-inits xterm instead of being dropped by the has(handle) guard. --- mobile/app/h/[hostId]/session/[worktreeId].tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mobile/app/h/[hostId]/session/[worktreeId].tsx b/mobile/app/h/[hostId]/session/[worktreeId].tsx index eeccbaf5798..925e95abc86 100644 --- a/mobile/app/h/[hostId]/session/[worktreeId].tsx +++ b/mobile/app/h/[hostId]/session/[worktreeId].tsx @@ -1428,6 +1428,13 @@ export default function SessionScreen() { if (initializedHandlesRef.current.size === 0) { setTerminalsLoaded(false) } + // Why: on reconnect the RPC client auto-resends terminal.subscribe and + // the server sends a fresh scrollback frame. The subscribe handler drops + // scrollback when initializedHandlesRef already contains the handle, so + // we'd keep stale pre-disconnect content (and lose any output emitted + // during the disconnect). Clear the flag so the fresh snapshot calls + // ref.init(...) and replaces the buffer. + initializedHandlesRef.current.clear() let disposed = false const timers: ReturnType[] = [] function addTimer(fn: () => void, ms: number) {