From c0b3a12af99d4d46d943f034c623664695e7bbc7 Mon Sep 17 00:00:00 2001 From: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Date: Sat, 27 Jun 2026 23:27:25 -0700 Subject: [PATCH] Fix mutable variable capturing in remote transport test Avoid mutating a local `let` variable from inside a Promise executor closure by wrapping the rejection callback in a `const` object. --- .../terminal-pane/remote-runtime-pty-transport.test.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/renderer/src/components/terminal-pane/remote-runtime-pty-transport.test.ts b/src/renderer/src/components/terminal-pane/remote-runtime-pty-transport.test.ts index 8078125dc5e..be8ddca879a 100644 --- a/src/renderer/src/components/terminal-pane/remote-runtime-pty-transport.test.ts +++ b/src/renderer/src/components/terminal-pane/remote-runtime-pty-transport.test.ts @@ -387,7 +387,9 @@ describe('createRemoteRuntimePtyTransport', () => { }) it('ignores stale attach subscription rejection after reattaching a newer remote terminal', async () => { - let rejectOldSubscription: ((error: Error) => void) | null = null + const oldSubscription = { + reject: null as ((error: Error) => void) | null + } const newStream = { streamId: 2, sendInput: vi.fn(() => true), @@ -400,7 +402,7 @@ describe('createRemoteRuntimePtyTransport', () => { .mockImplementationOnce( () => new Promise((_resolve, reject) => { - rejectOldSubscription = reject + oldSubscription.reject = reject }) ) .mockResolvedValueOnce(newStream) @@ -431,7 +433,7 @@ describe('createRemoteRuntimePtyTransport', () => { }) await vi.waitFor(() => expect(subscribeTerminal).toHaveBeenCalledTimes(2)) - rejectOldSubscription?.(new Error('terminal_handle_stale')) + oldSubscription.reject?.(new Error('terminal_handle_stale')) await Promise.resolve() await Promise.resolve()