From c22f4b00f2c9ad277cb01d54d1f7b979b4dba667 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sat, 10 Oct 2026 00:27:48 -0700 Subject: [PATCH] fix(agents): show DeepSeek icon for observed Build sessions (#26863) Co-authored-by: Wooseong Kim --- src/renderer/src/components/agent/AgentCombobox.test.tsx | 7 +++++++ src/renderer/src/lib/agent-catalog.tsx | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/renderer/src/components/agent/AgentCombobox.test.tsx b/src/renderer/src/components/agent/AgentCombobox.test.tsx index d9dd02c751f..7ac5a9187bc 100644 --- a/src/renderer/src/components/agent/AgentCombobox.test.tsx +++ b/src/renderer/src/components/agent/AgentCombobox.test.tsx @@ -210,6 +210,13 @@ describe('AgentCombobox', () => { expect(markup).not.toContain(' { + const markup = renderToStaticMarkup() + + expect(markup).toContain(AGENT_FAVICON_ASSETS.dsh) + expect(AGENT_CATALOG.map((agent) => agent.id)).not.toContain('dsb') + }) + it('renders bundled favicons for favicon-domain agents instead of the remote Google service', () => { // Why: previously loaded from Google's favicon service (#8451). Iterate the // full asset map so missing files/key mismatches fail the test. diff --git a/src/renderer/src/lib/agent-catalog.tsx b/src/renderer/src/lib/agent-catalog.tsx index 80056139437..ea3f814c7f3 100644 --- a/src/renderer/src/lib/agent-catalog.tsx +++ b/src/renderer/src/lib/agent-catalog.tsx @@ -84,7 +84,9 @@ export function AgentIcon({ // Why: prefer the favicon bundled at build time so the icon renders without a // live network request — Google's favicon service is unreachable in some // regions and offline, which left these icons broken (#8451). - const bundledFaviconUrl = AGENT_FAVICON_ASSETS[agent] + // Why: recognition-only DSB shares the bundled DeepSeek mark. + const iconAgent = agent === 'dsb' ? 'dsh' : agent + const bundledFaviconUrl = AGENT_FAVICON_ASSETS[iconAgent] // Why: one resolved src for guard + attribute so empty `iconUrl` cannot pass // a truthy `||` check while `??` still renders a broken ``. const iconSrc = catalogEntry?.iconUrl ?? bundledFaviconUrl