From c4e122f8028fe59391a2b1386ecf69a216c043b2 Mon Sep 17 00:00:00 2001 From: Neil Date: Sat, 12 Sep 2026 03:02:03 -0700 Subject: [PATCH] ci: keep diagnostic artifact outages from failing tests --- .github/workflows/e2e.yml | 2 ++ .github/workflows/unit-tests.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index f97c22e5ae0..f42d1184ce9 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -190,6 +190,8 @@ jobs: - name: Upload E2E shard assignment if: always() + # Diagnostic upload outages must not change the test verdict. + continue-on-error: true uses: actions/upload-artifact@v7 with: name: e2e-shard-${{ matrix.shard_name }}-attempt-${{ github.run_attempt }} diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 641f56d7498..b21feae3230 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -72,6 +72,8 @@ jobs: - name: Upload unit shard assignment if: always() + # Diagnostic upload outages must not change the test verdict. + continue-on-error: true uses: actions/upload-artifact@v7 with: name: unit-shard-node-${{ matrix.node }}-${{ matrix.shard }}-attempt-${{ github.run_attempt }}