From c5dd720a92e4293d82f130825d56405b7168ddb2 Mon Sep 17 00:00:00 2001
From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>
Date: Tue, 28 Jul 2026 18:32:31 -0700
Subject: [PATCH] test(skills): pin entry-limit to the scan root, not the
 crossing directory
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Both entry-budget fixtures crossed the bound in the same directory they named,
so swapping recordIssue(rootPath) for recordIssue(directory) at either guard
passed the whole suite — the dialog would surface a nested path and no test
would say so. Cross the budget below the root instead.
---
 .../skills/skill-plugin-cache-scan.test.ts    | 25 ++++++++++++-------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/src/main/skills/skill-plugin-cache-scan.test.ts b/src/main/skills/skill-plugin-cache-scan.test.ts
index 0658b665426..f176c89d388 100644
--- a/src/main/skills/skill-plugin-cache-scan.test.ts
+++ b/src/main/skills/skill-plugin-cache-scan.test.ts
@@ -47,13 +47,16 @@ describe('plugin skill candidate scan', () => {
       })
     )
 
+    // Budget: the root's two vendor dirents, one's, and its skill's — so the count is
+    // crossed inside 'two', not at the root. That is what pins the issue to the scan
+    // root the dialog can name rather than whichever directory happened to cross it.
     const result = await scanKnownPluginSkillCandidates(root, new Set(['orca-cli']), {
-      maximumEntries: 1
+      maximumEntries: 4
     })
 
-    // Why: the walk ends before descending, so both real skills go unseen. The issue is
-    // all that stops the dialog reporting all-clear over a scan that never reached them.
-    expect(result.candidates).toEqual([])
+    // Why: the second vendor's skill goes unseen. The issue is all that stops the dialog
+    // reporting all-clear over a scan that never reached it.
+    expect(result.candidates).toEqual([{ name: 'orca-cli', path: join(root, 'one', 'orca-cli') }])
     expect(result.issues).toEqual([{ path: root, reason: 'entry-limit', errorCode: null }])
   })
 
@@ -63,18 +66,22 @@ describe('plugin skill candidate scan', () => {
     // spends the whole scan on missing paths. Only this guard bounds that.
     const root = await mkdtemp(join(tmpdir(), 'orca-plugin-entry-limit-declared-'))
     temporaryDirectories.push(root)
-    const candidate = join(root, 'a-skills', 'orca-cli')
-    await mkdir(join(root, '.codex-plugin'), { recursive: true })
+    // Why: the manifest sits under a vendor directory, not at the scan root, so the
+    // directory whose declared roots cross the budget is not the root the issue names.
+    const packageRoot = join(root, 'vendor')
+    const candidate = join(packageRoot, 'a-skills', 'orca-cli')
+    await mkdir(join(packageRoot, '.codex-plugin'), { recursive: true })
     await mkdir(candidate, { recursive: true })
     await writeFile(
-      join(root, '.codex-plugin', 'plugin.json'),
+      join(packageRoot, '.codex-plugin', 'plugin.json'),
       '{"skills":["./a-skills","./missing-one","./missing-two"]}\n'
     )
     await writeFile(join(candidate, 'SKILL.md'), '# Orca CLI\n')
 
-    // Budget: the root's two dirents, a-skills', the skill's, and the first declared root.
+    // Budget: the root's dirent, the vendor's two, a-skills', the skill's, and the first
+    // declared root.
     const result = await scanKnownPluginSkillCandidates(root, new Set(['orca-cli']), {
-      maximumEntries: 5
+      maximumEntries: 6
     })
 
     // Why: the declared root that exists was fully walked, so the bound is being crossed by