starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-08 08:02:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(release): pass the draft-verify tag on Windows pwsh (#21851)

Browse Source 
The Windows matrix defaults to pwsh, so assert-github-release-is-draft.mjs
received an empty argv and failed with "tag is required" after the signed
installer was already uploaded. Force bash, interpolate the tag in YAML,
and fall back to env TAG.
This commit is contained in:
Neil
2026-09-20 16:01:01 -07:00
committed by GitHub
parent ec82173130
commit cb715898cd
4 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/scripts/assert-github-release-is-draft.test.mjs
+4
View File
@@ -128,13 +128,17 @@ describe('release draft workflow contract', () => {
expect(electronBuilderConfig.publish.releaseType).toBe('draft')
expect(cutCheckout.with['fetch-tags']).toBe(true)
expect(linuxDraftStep.shell).toBe('bash')
expect(linuxDraftStep.run).toContain('assert-github-release-is-draft.mjs')
expect(linuxDraftStep.run).toContain('needs.cut.outputs.tag')
expect(publishRelease.run).toContain('gh release edit')
expect(publishRelease.run).toContain('--draft=false')
expect(macSteps.indexOf(abortParentStep)).toBeLessThan(macSteps.indexOf(macPublishStep))
expect(abortParentStep.env.PARENT_RUN).toBe('${{ inputs.release_run_id }}')
expect(abortParentStep.run).toContain('refusing to publish mac artifacts')
expect(macDraftStep.shell).toBe('bash')
expect(macDraftStep.run).toContain('assert-github-release-is-draft.mjs')
expect(macDraftStep.run).toContain('inputs.tag')
expect(macPublishStep.with.command).toContain('-c.publish.releaseType=draft')
const linuxCommands = releaseWorkflow.jobs.build.strategy.matrix.include