From ccdd3ba2a032830e4eb9eb7b65d5e766f6649ebc Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Fri, 13 Nov 2026 16:54:46 -0800 Subject: [PATCH] Skip empty terminal component maps during span edits Avoid per-column component lookups and deletions when no component exceptions exist, retaining existing run and mixed-glyph editing. Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com> --- src/main/daemon/emulation/headless-content-origins.ts | 6 ++++-- src/main/daemon/emulation/headless-origin-line-edits.ts | 8 +++++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/main/daemon/emulation/headless-content-origins.ts b/src/main/daemon/emulation/headless-content-origins.ts index b4865d3e2e0..9281e266b37 100644 --- a/src/main/daemon/emulation/headless-content-origins.ts +++ b/src/main/daemon/emulation/headless-content-origins.ts @@ -96,8 +96,10 @@ export class HeadlessContentOrigins { this.pending = undefined const state = this.lines.get(pending.line)! const components = state.components - for (let index = pending.start; index < pending.end; index++) { - components.delete(index) + if (components.size) { + for (let index = pending.start; index < pending.end; index++) { + components.delete(index) + } } this.assign(pending.line, { runs: writeTerminalOrigins( diff --git a/src/main/daemon/emulation/headless-origin-line-edits.ts b/src/main/daemon/emulation/headless-origin-line-edits.ts index bac263767c3..9e13b87f392 100644 --- a/src/main/daemon/emulation/headless-origin-line-edits.ts +++ b/src/main/daemon/emulation/headless-origin-line-edits.ts @@ -13,15 +13,17 @@ export function replaceOriginCells( from = 0 ): OriginLineState { const copied: [number, TerminalOriginRuns][] = [] - for (let index = from; source && index < from + end - start; index++) { + for (let index = from; source?.components.size && index < from + end - start; index++) { const runs = source.components.get(index) if (runs) { copied.push([index - from + start, runs]) } } const components = target.components - for (let index = start; index < end; index++) { - components.delete(index) + if (components.size) { + for (let index = start; index < end; index++) { + components.delete(index) + } } for (const [index, runs] of copied) { components.set(index, runs)