fix: pr-bug-scan findings from #1551 (#1571)

Re-added the `item.type !== 'pr'` guard around the relocated 'Start workspace from issue' button in GHEditSection so PRs no longer show it.

### Findings addressed
-  **[medium]** `src/renderer/src/components/GitHubItemDialog.tsx` — 'Start workspace from issue' now renders on PRs

Rebased onto current main; removed the now-redundant early `return null` for PRs at the top of GHEditSection so the per-button guard is reachable and labels/assignees popovers remain available on PRs.

Co-authored-by: orca-bot <bot@stably.ai>
This commit is contained in:
buf0-bot[bot]
2026-05-07 23:06:47 -07:00
committed by GitHub
co-authored by orca-bot
parent 98d3deaa13
commit cd686f58d0
@@ -1924,10 +1924,6 @@ function GHEditSection({
[item.number, repoPath, projectOrigin, localAssignees, patchProjectRowIfNeeded, run]
)
if (item.type === 'pr') {
return null
}
const checkIcon = (
<svg className="size-2.5" viewBox="0 0 12 12" fill="none">
<path
@@ -2101,15 +2097,17 @@ function GHEditSection({
</PopoverContent>
</Popover>
<Button
size="sm"
onClick={() => onUse(item)}
className="ml-auto gap-2"
aria-label="Start workspace from issue"
>
Start workspace from issue
<ArrowRight className="size-4" />
</Button>
{item.type !== 'pr' ? (
<Button
size="sm"
onClick={() => onUse(item)}
className="ml-auto gap-2"
aria-label="Start workspace from issue"
>
Start workspace from issue
<ArrowRight className="size-4" />
</Button>
) : null}
</div>
)
}