From cd686f58d0c3d3fc9191f7d8ee56e7c4ee6c2a3a Mon Sep 17 00:00:00 2001
From: "buf0-bot[bot]" <252831055+buf0-bot[bot]@users.noreply.github.com>
Date: Thu, 7 May 2026 23:06:47 -0700
Subject: [PATCH] fix: pr-bug-scan findings from #1551 (#1571)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Re-added the `item.type !== 'pr'` guard around the relocated 'Start workspace from issue' button in GHEditSection so PRs no longer show it.

### Findings addressed
- ✅ **[medium]** `src/renderer/src/components/GitHubItemDialog.tsx` — 'Start workspace from issue' now renders on PRs

Rebased onto current main; removed the now-redundant early `return null` for PRs at the top of GHEditSection so the per-button guard is reachable and labels/assignees popovers remain available on PRs.

Co-authored-by: orca-bot <bot@stably.ai>
---
 .../src/components/GitHubItemDialog.tsx       | 24 +++++++++----------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/renderer/src/components/GitHubItemDialog.tsx b/src/renderer/src/components/GitHubItemDialog.tsx
index 1c04c23abb6..01303cf362c 100644
--- a/src/renderer/src/components/GitHubItemDialog.tsx
+++ b/src/renderer/src/components/GitHubItemDialog.tsx
@@ -1924,10 +1924,6 @@ function GHEditSection({
     [item.number, repoPath, projectOrigin, localAssignees, patchProjectRowIfNeeded, run]
   )
 
-  if (item.type === 'pr') {
-    return null
-  }
-
   const checkIcon = (
     <svg className="size-2.5" viewBox="0 0 12 12" fill="none">
       <path
@@ -2101,15 +2097,17 @@ function GHEditSection({
         </PopoverContent>
       </Popover>
 
-      <Button
-        size="sm"
-        onClick={() => onUse(item)}
-        className="ml-auto gap-2"
-        aria-label="Start workspace from issue"
-      >
-        Start workspace from issue
-        <ArrowRight className="size-4" />
-      </Button>
+      {item.type !== 'pr' ? (
+        <Button
+          size="sm"
+          onClick={() => onUse(item)}
+          className="ml-auto gap-2"
+          aria-label="Start workspace from issue"
+        >
+          Start workspace from issue
+          <ArrowRight className="size-4" />
+        </Button>
+      ) : null}
     </div>
   )
 }