From d3fedb9ba970ccca8ca0e663f9d82f05d54b6187 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Wed, 15 Jul 2026 16:53:29 -0700 Subject: [PATCH] ci(computer-e2e): run native-smoke vitest with the shared config (#8909) The native-smoke job ran bare `pnpm vitest run ` with no --config. There is no root-level vitest/vite config, so vitest fell back to its built-in defaults: a 5000ms testTimeout and no Windows worker cap. The real csc.exe launcher-compile tests (build-windows-cli-launcher and ssh-remote-cli-launcher) cold-start in 1.4-7.4s on hosted Windows and tipped over the 5s default, failing the PR check. Pass --config config/vitest.config.ts like every other vitest invocation in the repo (pnpm test, pr.yml) so the job gets the shared 30s timeout and Windows maxWorkers:4 cap (less CPU contention -> lower compile variance). Positional file args still filter to just the listed files. --- .github/workflows/computer-e2e.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/computer-e2e.yml b/.github/workflows/computer-e2e.yml index 76595f338a6..3023d414abe 100644 --- a/.github/workflows/computer-e2e.yml +++ b/.github/workflows/computer-e2e.yml @@ -75,8 +75,12 @@ jobs: npm install -g node-gyp@11.5.0 echo "npm_config_node_gyp=$(npm root -g)/node-gyp/bin/node-gyp.js" >> "$GITHUB_ENV" - run: pnpm install --frozen-lockfile + # Why: without --config, bare vitest ignores config/vitest.config.ts (there + # is no root config) and falls back to the 5s default timeout with no + # Windows worker cap, so the real csc.exe launcher-compile tests time out + # on hosted Windows. Use the shared config so this job matches pnpm test. - run: >- - pnpm vitest run + pnpm vitest run --config config/vitest.config.ts config/scripts/build-windows-cli-launcher.test.mjs src/main/ssh/ssh-remote-cli-launcher.test.ts config/scripts/computer-e2e-workflow.test.mjs