From db34fa92e586676c8293dd560c4faa8e82727824 Mon Sep 17 00:00:00 2001
From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com>
Date: Wed, 12 Aug 2026 22:11:39 -0700
Subject: [PATCH] fix(test): widen the replay-callback meta type for snapshot
 dimensions

The replay meta now carries snapshotCols/snapshotRows, but seven local callback
types in the test file still declared only clearBeforeReplay, so the web
typecheck failed on two assignment sites while the suites themselves passed.
---
 .../terminal-pane/pty-connection.test.ts      | 54 ++++++++++++++++---
 1 file changed, 46 insertions(+), 8 deletions(-)

diff --git a/src/renderer/src/components/terminal-pane/pty-connection.test.ts b/src/renderer/src/components/terminal-pane/pty-connection.test.ts
index b5e215426f4..84571eb1e15 100644
--- a/src/renderer/src/components/terminal-pane/pty-connection.test.ts
+++ b/src/renderer/src/components/terminal-pane/pty-connection.test.ts
@@ -309,7 +309,10 @@ type ConnectCallbacks = {
     data: string,
     meta?: { seq?: number; rawLength?: number; background?: boolean; droppedOutput?: boolean }
   ) => void
-  onReplayData?: (data: string, meta?: { clearBeforeReplay?: boolean }) => void
+  onReplayData?: (
+    data: string,
+    meta?: { clearBeforeReplay?: boolean; snapshotCols?: number; snapshotRows?: number }
+  ) => void
   onError?: (msg: string) => void
   onWriteUnavailable?: () => void
   onOutputPauseChanged?: (paused: boolean, supported: boolean) => void
@@ -9524,7 +9527,12 @@ describe('connectPanePty', () => {
       current:
         | ((
             data: string,
-            meta?: { clearBeforeReplay?: boolean; pendingEscapeTailAnsi?: string }
+            meta?: {
+              clearBeforeReplay?: boolean
+              pendingEscapeTailAnsi?: string
+              snapshotCols?: number
+              snapshotRows?: number
+            }
           ) => void)
         | null
     } = { current: null }
@@ -17304,7 +17312,12 @@ describe('connectPanePty', () => {
     enableActiveRuntimeEnvironment()
     const transport = createMockTransport('remote:env-1@@terminal-1')
     const capturedReplayCallback: {
-      current: ((data: string, meta?: { clearBeforeReplay?: boolean }) => void) | null
+      current:
+        | ((
+            data: string,
+            meta?: { clearBeforeReplay?: boolean; snapshotCols?: number; snapshotRows?: number }
+          ) => void)
+        | null
     } = { current: null }
     transport.connect.mockImplementation(async ({ callbacks }: { callbacks: ConnectCallbacks }) => {
       capturedReplayCallback.current = callbacks.onReplayData ?? null
@@ -17342,7 +17355,12 @@ describe('connectPanePty', () => {
     enableActiveRuntimeEnvironment()
     const transport = createMockTransport('remote:env-1@@terminal-1')
     const capturedReplayCallback: {
-      current: ((data: string, meta?: { clearBeforeReplay?: boolean }) => void) | null
+      current:
+        | ((
+            data: string,
+            meta?: { clearBeforeReplay?: boolean; snapshotCols?: number; snapshotRows?: number }
+          ) => void)
+        | null
     } = { current: null }
     transport.connect.mockImplementation(async ({ callbacks }: { callbacks: ConnectCallbacks }) => {
       capturedReplayCallback.current = callbacks.onReplayData ?? null
@@ -17381,7 +17399,12 @@ describe('connectPanePty', () => {
     enableActiveRuntimeEnvironment()
     const transport = createMockTransport('remote:env-1@@terminal-1')
     const capturedReplayCallback: {
-      current: ((data: string, meta?: { clearBeforeReplay?: boolean }) => void) | null
+      current:
+        | ((
+            data: string,
+            meta?: { clearBeforeReplay?: boolean; snapshotCols?: number; snapshotRows?: number }
+          ) => void)
+        | null
     } = { current: null }
     transport.connect.mockImplementation(async ({ callbacks }: { callbacks: ConnectCallbacks }) => {
       capturedReplayCallback.current = callbacks.onReplayData ?? null
@@ -17415,7 +17438,12 @@ describe('connectPanePty', () => {
     enableActiveRuntimeEnvironment()
     const transport = createMockTransport('remote:env-1@@terminal-1')
     const capturedReplayCallback: {
-      current: ((data: string, meta?: { clearBeforeReplay?: boolean }) => void) | null
+      current:
+        | ((
+            data: string,
+            meta?: { clearBeforeReplay?: boolean; snapshotCols?: number; snapshotRows?: number }
+          ) => void)
+        | null
     } = { current: null }
     transport.connect.mockImplementation(async ({ callbacks }: { callbacks: ConnectCallbacks }) => {
       capturedReplayCallback.current = callbacks.onReplayData ?? null
@@ -17457,7 +17485,12 @@ describe('connectPanePty', () => {
     const { connectPanePty } = await import('./pty-connection')
     const transport = createMockTransport('pty-id')
     const capturedReplayCallback: {
-      current: ((data: string, meta?: { clearBeforeReplay?: boolean }) => void) | null
+      current:
+        | ((
+            data: string,
+            meta?: { clearBeforeReplay?: boolean; snapshotCols?: number; snapshotRows?: number }
+          ) => void)
+        | null
     } = { current: null }
     transport.connect.mockImplementation(async ({ callbacks }: { callbacks: ConnectCallbacks }) => {
       capturedReplayCallback.current = callbacks.onReplayData ?? null
@@ -17492,7 +17525,12 @@ describe('connectPanePty', () => {
     const { connectPanePty } = await import('./pty-connection')
     const transport = createMockTransport('pty-id')
     const capturedReplayCallback: {
-      current: ((data: string, meta?: { clearBeforeReplay?: boolean }) => void) | null
+      current:
+        | ((
+            data: string,
+            meta?: { clearBeforeReplay?: boolean; snapshotCols?: number; snapshotRows?: number }
+          ) => void)
+        | null
     } = { current: null }
     transport.connect.mockImplementation(async ({ callbacks }: { callbacks: ConnectCallbacks }) => {
       capturedReplayCallback.current = callbacks.onReplayData ?? null