mirror of
https://github.com/stablyai/orca.git
synced 2026-10-26 16:02:42 +00:00
fix(native-chat): retry not-yet-flushed transcripts instead of settling into a permanent error (#8418)
* fix(native-chat): retry not-yet-flushed transcripts instead of settling into a permanent error A freshly-created session's transcript .jsonl lands on disk seconds to minutes after the process starts. Native chat's one-shot read raced that first flush: a miss became a permanent "No transcript found" error and the live-tail subscription silently degraded to a no-op, so the pane never recovered even after the file appeared. - transcript-reader/read-cache: mark the miss with notFound so callers can tell "not flushed yet" from a real parse/IO error (never cached). - transcript-watch: poll resolve+install (500ms backoff, 5s cap) for the subscription's lifetime instead of returning a dead no-op watcher. - use-native-chat-live-session: retry a notFound read with backoff for up to 60s while staying in the loading state, and let live appends render over a stale initial-read error. Fixes #8401 Claude-Session: https://claude.ai/code/session_01HA5g3X7wCakBttBpDru9Fp * fix(native-chat): address CodeRabbit review — ENOENT retryable, content over spinner, blank-id guard, unref poll timer - transcript-reader: an ENOENT after a successful resolve is the same first-flush/rotation race as an unresolved path — mark it notFound. - use-native-chat-live-session: live appends landing mid-retry render instead of the loading state (mirrors the stale-error gate). - transcript-watch: bail out for a blank session id with no explicit file (nothing to resolve-poll), and unref the poll timer so headless serve shutdown is never held open by an unresolvable session. Claude-Session: https://claude.ai/code/session_01HA5g3X7wCakBttBpDru9Fp --------- Co-authored-by: kaynan <kaynan.camargo@terceiro-sky.com.br>
This commit is contained in:
co-authored by
kaynan
parent
527c692b71
commit
dc4fb2aa03
@@ -110,6 +110,19 @@ describe('readNativeChatTranscriptCached', () => {
|
||||
expect('error' in result && result.error).toBeTruthy()
|
||||
})
|
||||
|
||||
// Why: a just-created session's transcript can take up to minutes to exist on
|
||||
// disk (#8401) — the miss must be marked notFound so watch/renderer callers
|
||||
// retry instead of settling into a permanent error, and it must never be
|
||||
// cached (a real error already isn't cached; this locks in the same for a miss).
|
||||
it('marks a resolve miss as notFound and does not cache it', async () => {
|
||||
await seedSession('present-2', 1)
|
||||
const first = await readNativeChatTranscriptCached('claude', 'absent-2')
|
||||
expect('error' in first && first.notFound).toBe(true)
|
||||
expect(readSpy).not.toHaveBeenCalled()
|
||||
const second = await readNativeChatTranscriptCached('claude', 'absent-2')
|
||||
expect(second).not.toBe(first)
|
||||
})
|
||||
|
||||
// Why: two worktrees can present the SAME (agent, sessionId) via different
|
||||
// transcript files — e.g. the same session resumed into a second worktree,
|
||||
// which writes a new transcript file. Keying the cache by sessionId let one
|
||||
|
||||
Reference in New Issue
Block a user