From dcb1d047cf8f51dc8bdd91f5de2c308b082c5134 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Wed, 26 Aug 2026 21:15:41 -0700 Subject: [PATCH] chore: preserve upstream skill dialog formatting --- .../components/skills/SkillInstallDialog.tsx | 31 ++-------- .../skills/SkillInstallManagementDialog.tsx | 57 +++---------------- 2 files changed, 14 insertions(+), 74 deletions(-) diff --git a/src/renderer/src/components/skills/SkillInstallDialog.tsx b/src/renderer/src/components/skills/SkillInstallDialog.tsx index cc0ee06b198..c5498ac6b3d 100644 --- a/src/renderer/src/components/skills/SkillInstallDialog.tsx +++ b/src/renderer/src/components/skills/SkillInstallDialog.tsx @@ -91,12 +91,7 @@ export function SkillInstallDialog({ const resolveLink = useCallback(async (value: string): Promise => { const shareId = parseSkillShareId(value) if (!shareId) { - setError( - translate( - 'auto.components.skills.install.enterShareLink', - 'Enter an Orca skill share link.' - ) - ) + setError(translate('auto.components.skills.install.enterShareLink', 'Enter an Orca skill share link.')) return } setBusy(true) @@ -108,22 +103,14 @@ export function SkillInstallDialog({ setError( operation.status === 'unconfigured' ? operation.message - : translate( - 'auto.components.skills.install.shareUnavailable', - 'This share is unavailable. The link may be invalid, expired, or revoked.' - ) + : translate('auto.components.skills.install.shareUnavailable', 'This share is unavailable. The link may be invalid, expired, or revoked.') ) return } setPreview({ shareId, version: operation.value.version }) } catch (cause) { console.warn('[skills] share resolution failed:', cause) - setError( - translate( - 'auto.components.skills.install.shareUnavailable', - 'This share is unavailable. The link may be invalid, expired, or revoked.' - ) - ) + setError(translate('auto.components.skills.install.shareUnavailable', 'This share is unavailable. The link may be invalid, expired, or revoked.')) } finally { setBusy(false) } @@ -217,10 +204,7 @@ export function SkillInstallDialog({ if (operation.status !== 'ok') { setError( operation.status === 'reconnect-required' - ? translate( - 'auto.components.skills.install.reconnectBeforeInstalling', - 'Reconnect your Orca account before installing.' - ) + ? translate('auto.components.skills.install.reconnectBeforeInstalling', 'Reconnect your Orca account before installing.') : operation.message ) return @@ -252,12 +236,7 @@ export function SkillInstallDialog({ ...(environmentId === 'local' || environmentId.startsWith('ssh:') ? {} : { environmentId }) }) if (!cancelled.cancelled) { - setError( - translate( - 'auto.components.skills.install.destinationAlreadyFinished', - 'The destination had already finished this installation.' - ) - ) + setError(translate('auto.components.skills.install.destinationAlreadyFinished', 'The destination had already finished this installation.')) } } diff --git a/src/renderer/src/components/skills/SkillInstallManagementDialog.tsx b/src/renderer/src/components/skills/SkillInstallManagementDialog.tsx index 0479aae20fd..a760af0335e 100644 --- a/src/renderer/src/components/skills/SkillInstallManagementDialog.tsx +++ b/src/renderer/src/components/skills/SkillInstallManagementDialog.tsx @@ -91,12 +91,7 @@ export function SkillInstallManagementDialog({ return } console.warn('[skills] managed install listing failed:', cause) - setError( - translate( - 'auto.components.skills.install.inspectManagedFailed', - 'Orca could not inspect managed installs on this machine.' - ) - ) + setError(translate('auto.components.skills.install.inspectManagedFailed', 'Orca could not inspect managed installs on this machine.')) } finally { if (generation === loadGeneration.current) { setBusy(false) @@ -126,10 +121,7 @@ export function SkillInstallManagementDialog({ if (operation.status !== 'ok') { setError( operation.status === 'reconnect-required' - ? translate( - 'auto.components.skills.install.reconnectForVersionHistory', - 'Reconnect your Orca account to load version history.' - ) + ? translate('auto.components.skills.install.reconnectForVersionHistory', 'Reconnect your Orca account to load version history.') : operation.message ) return @@ -141,12 +133,7 @@ export function SkillInstallManagementDialog({ return } console.warn('[skills] package history failed:', cause) - setError( - translate( - 'auto.components.skills.install.versionHistoryUnavailable', - 'Version history is unavailable for this skill.' - ) - ) + setError(translate('auto.components.skills.install.versionHistoryUnavailable', 'Version history is unavailable for this skill.')) } finally { if (generation === detailGeneration.current) { setBusy(false) @@ -182,12 +169,7 @@ export function SkillInstallManagementDialog({ installedNames.has(skill.name) ) if (selectedSkills.length === 0) { - setError( - translate( - 'auto.components.skills.install.bundleSkillsMissing', - 'This version does not contain any of the installed bundle skills.' - ) - ) + setError(translate('auto.components.skills.install.bundleSkillsMissing', 'This version does not contain any of the installed bundle skills.')) return } const operation = await window.api.skills.installBundlePackageVersion({ @@ -212,10 +194,7 @@ export function SkillInstallManagementDialog({ if (operation.status !== 'ok') { setError( operation.status === 'reconnect-required' - ? translate( - 'auto.components.skills.install.reconnectBeforeVersionChange', - 'Reconnect your Orca account before changing versions.' - ) + ? translate('auto.components.skills.install.reconnectBeforeVersionChange', 'Reconnect your Orca account before changing versions.') : operation.message ) return @@ -241,10 +220,7 @@ export function SkillInstallManagementDialog({ if (operation.status !== 'ok') { setError( operation.status === 'reconnect-required' - ? translate( - 'auto.components.skills.install.reconnectBeforeVersionChange', - 'Reconnect your Orca account before changing versions.' - ) + ? translate('auto.components.skills.install.reconnectBeforeVersionChange', 'Reconnect your Orca account before changing versions.') : operation.message ) return @@ -258,12 +234,7 @@ export function SkillInstallManagementDialog({ } } catch (cause) { console.warn('[skills] version installation failed:', cause) - setError( - translate( - 'auto.components.skills.install.versionVerificationFailed', - 'Orca could not verify the requested version.' - ) - ) + setError(translate('auto.components.skills.install.versionVerificationFailed', 'Orca could not verify the requested version.')) } finally { installProgress.finish() setBusy(false) @@ -279,12 +250,7 @@ export function SkillInstallManagementDialog({ ...(environmentId === 'local' || environmentId.startsWith('ssh:') ? {} : { environmentId }) }) if (!cancelled.cancelled) { - setError( - translate( - 'auto.components.skills.install.destinationAlreadyFinished', - 'The destination had already finished this installation.' - ) - ) + setError(translate('auto.components.skills.install.destinationAlreadyFinished', 'The destination had already finished this installation.')) } } @@ -329,12 +295,7 @@ export function SkillInstallManagementDialog({ } } catch (cause) { console.warn('[skills] managed removal failed:', cause) - setError( - translate( - 'auto.components.skills.install.removeFailed', - 'Orca could not safely remove this skill.' - ) - ) + setError(translate('auto.components.skills.install.removeFailed', 'Orca could not safely remove this skill.')) } finally { setBusy(false) }