starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-24 16:03:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

build(windows): refuse a node-pty that cannot own a PTY tree

Browse Source 
A shipped Windows install loaded node-pty's upstream prebuild, which omits Orca's patched job-object exports. The Windows test lane rebuilt node-pty before testing, so its green result did not describe the install or release preflight path.

Share the job-ownership assertion with the native rebuild probe. A loadable but unpatched ConPTY native now selects only node-pty for a source rebuild. Resolve node-addon-api's gyp project absolutely so that rebuild also works from long pnpm worktree paths, and run the repair regression in the Windows lane.

Refs #16059.
This commit is contained in:
Neil
2026-08-23 13:45:00 -07:00
parent d1127b9939
commit e1fe67a96d
12 changed files with 302 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/pr.yml
+1
View File
@@ -642,6 +642,7 @@ jobs:
- name: Test Windows-specific boundaries
run: >-
pnpm exec vitest run --config config/vitest.config.ts
config/scripts/rebuild-native-deps.test.mjs
src/main/providers/windows-conpty-wide-char-duplication.node-pty.test.ts
src/main/providers/pty-repaint-wide-char-buffer.node-pty.test.ts
src/shared/child-process/windows-command-line.win32.test.ts