From e5f5cd825dd3540ef44a339952bfcc7f03e79c58 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Thu, 27 Aug 2026 15:32:38 -0700 Subject: [PATCH] fix(mobile): stop accessory repeats after IME send failure --- ...se-terminal-live-accessory-input-commit.test.ts | 14 ++++++++++++++ .../use-terminal-live-accessory-input-commit.ts | 7 ++++--- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/mobile/src/terminal/use-terminal-live-accessory-input-commit.test.ts b/mobile/src/terminal/use-terminal-live-accessory-input-commit.test.ts index 2542b315a8f..84be68ec5ae 100644 --- a/mobile/src/terminal/use-terminal-live-accessory-input-commit.test.ts +++ b/mobile/src/terminal/use-terminal-live-accessory-input-commit.test.ts @@ -165,6 +165,20 @@ describe('terminal live accessory input commit hook', () => { expect(result).toEqual({ kind: 'handled' }) }) + it('Given held text with a failed control send When committed Then reports the accessory input as suppressed', async () => { + const harness = createAccessoryInputCommitHarness({ + heldText: '한', + pendingHandle: 'terminal-a', + sendResult: false + }) + + const result = await harness.commit({ bytes: '\x1b' }) + + expect(harness.flushPendingLiveInputText).toHaveBeenCalledWith('terminal-a') + expect(harness.sent).toEqual(['\x1b']) + expect(result).toEqual({ kind: 'suppress-raw' }) + }) + it('Given raw accessory bytes with no held text When committed Then allows the raw send without flushing', async () => { // Given const harness = createAccessoryInputCommitHarness({ pendingHandle: null }) diff --git a/mobile/src/terminal/use-terminal-live-accessory-input-commit.ts b/mobile/src/terminal/use-terminal-live-accessory-input-commit.ts index 0893ae16098..729dab19a01 100644 --- a/mobile/src/terminal/use-terminal-live-accessory-input-commit.ts +++ b/mobile/src/terminal/use-terminal-live-accessory-input-commit.ts @@ -84,12 +84,13 @@ export function useTerminalLiveAccessoryInputCommit({ applyLiveInputMirror(activeHandle, editedText) return { kind: 'handled' } } - case 'commit-held-then-send': - await sendTerminalLiveControlAfterPendingFlush( + case 'commit-held-then-send': { + const sent = await sendTerminalLiveControlAfterPendingFlush( () => flushPendingLiveInputText(activeHandle), () => sendLiveTerminalInputRef.current(activeHandle, decision.bytes) ) - return { kind: 'handled' } + return sent ? { kind: 'handled' } : { kind: 'suppress-raw' } + } default: decision satisfies never return { kind: 'handled' }