test: remove 140 low-value tests (#39644)

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
This commit is contained in:
OrcaWin
2026-11-07 17:40:01 -08:00
committed by GitHub
co-authored by OrcaWin
parent 62cb2dde86
commit e833bb703c
67 changed files with 46 additions and 3580 deletions
@@ -1,75 +0,0 @@
import { beforeEach, describe, expect, it, vi } from 'vitest'
const mocks = vi.hoisted(() => ({ sidebar: vi.fn(), checks: vi.fn() }))
vi.mock('./pull-request-sidebar-query', () => ({ readPullRequestSidebarQuery: mocks.sidebar }))
vi.mock('../check/complete-pr-check-observation', () => ({
readCompletePRCheckObservation: mocks.checks
}))
import {
readSharedPRCheckObservation,
readSharedPullRequestSidebarQuery
} from './shared-pr-provider-reads'
const REPO = { owner: 'acme', repo: 'orca' }
const SCOPE = 'local-runtime'
describe('shared PR provider reads', () => {
beforeEach(() => {
mocks.sidebar.mockReset()
mocks.checks.mockReset()
})
it('sends one request per PR for every checkout of one account, and none across accounts', async () => {
mocks.sidebar.mockImplementation(async () => ({ number: 12 }))
const reads = [
readSharedPullRequestSidebarQuery(REPO, 12, { cwd: '/repo' }, SCOPE),
readSharedPullRequestSidebarQuery(
{ owner: 'ACME', repo: 'orca' },
12,
{ cwd: '/repo-wt' },
SCOPE
),
readSharedPullRequestSidebarQuery(
REPO,
12,
{ cwd: '/repo', ghAccount: { host: 'github.com', user: 'other' } },
SCOPE
),
readSharedPullRequestSidebarQuery(REPO, 12, { cwd: '/repo' }, 'wsl:Ubuntu')
]
expect(mocks.sidebar).toHaveBeenCalledTimes(3)
const [first, second] = await Promise.all(reads)
expect(first).toBe(second)
})
it('shares a check read only for the same head', async () => {
mocks.checks.mockImplementation(() => new Promise(() => {}))
void readSharedPRCheckObservation(REPO, 12, 'aaa', { cwd: '/repo' }, SCOPE)
void readSharedPRCheckObservation(REPO, 12, 'aaa', { cwd: '/repo-wt' }, SCOPE)
void readSharedPRCheckObservation(REPO, 12, 'bbb', { cwd: '/repo' }, SCOPE)
expect(mocks.checks).toHaveBeenCalledTimes(2)
})
it('lets a bounded watch read join a full read, but never serve one', async () => {
mocks.sidebar.mockImplementation(() => new Promise(() => {}))
void readSharedPullRequestSidebarQuery(REPO, 12, { cwd: '/repo' }, SCOPE, {
checkPageLimit: 10
})
void readSharedPullRequestSidebarQuery(REPO, 12, { cwd: '/repo' }, SCOPE)
void readSharedPullRequestSidebarQuery(REPO, 12, { cwd: '/repo' }, SCOPE, {
checkPageLimit: 10
})
expect(mocks.sidebar).toHaveBeenCalledTimes(2)
expect(mocks.sidebar.mock.calls.map((call) => call[3])).toEqual([10, undefined])
})
it('starts a fresh read for a user refresh instead of joining one begun before the click', async () => {
mocks.sidebar.mockImplementation(() => new Promise(() => {}))
void readSharedPullRequestSidebarQuery(REPO, 13, { cwd: '/repo' }, SCOPE)
void readSharedPullRequestSidebarQuery(REPO, 13, { cwd: '/repo' }, SCOPE, { userRefresh: true })
// Later ordinary callers share the refresh's read.
void readSharedPullRequestSidebarQuery(REPO, 13, { cwd: '/repo-wt' }, SCOPE)
expect(mocks.sidebar).toHaveBeenCalledTimes(2)
})
})