From ef21574a41ee1552af3b111bcd61f85876a67dc2 Mon Sep 17 00:00:00 2001 From: OrcaWin Date: Tue, 27 Oct 2026 15:16:02 -0700 Subject: [PATCH] fix(sidebar): remove Claude subagent-view eye indicator (#34558) * fix(sidebar): drop Claude subagent-view eye icon; badge viewed subagent only Co-Authored-By: Claude * fix(sidebar): hide subagent-view indicator on collapsed rows too Co-Authored-By: Claude --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com> Co-authored-by: Claude --- .../components/ClaudeAgentViewIndicator.tsx | 63 ------------------- .../dashboard/DashboardAgentRow.tsx | 2 - .../dashboard/use-claude-agent-row-view.ts | 19 ++---- .../worktree-card-compact-agent-row.tsx | 2 - .../sidebar/worktree-card-compact-agents.tsx | 5 -- src/renderer/src/i18n/locales/en.json | 5 -- 6 files changed, 5 insertions(+), 91 deletions(-) delete mode 100644 src/renderer/src/components/ClaudeAgentViewIndicator.tsx diff --git a/src/renderer/src/components/ClaudeAgentViewIndicator.tsx b/src/renderer/src/components/ClaudeAgentViewIndicator.tsx deleted file mode 100644 index 93708c4e426..00000000000 --- a/src/renderer/src/components/ClaudeAgentViewIndicator.tsx +++ /dev/null @@ -1,63 +0,0 @@ -import { Tooltip, TooltipContent, TooltipTrigger } from './ui/tooltip' -import { Eye } from 'lucide-react' -import { translate } from '@/i18n/i18n' -import type { DashboardAgentRow } from './dashboard/useDashboardData' -import { useClaudeAgentRowView } from './dashboard/use-claude-agent-row-view' -import { getAgentRowPrimaryText } from '../../../shared/agent-row-primary-text' - -export function ClaudeAgentViewIndicator({ - view, - showChild = true, - showName = false -}: { - view: { current: boolean; agentId?: string; child: boolean; label?: string } | null - showChild?: boolean - showName?: boolean -}) { - if (!view || (!view.current && (view.child || !showChild))) { - return null - } - const label = view.current - ? translate('auto.components.ClaudeAgentViewIndicator.viewing', 'Currently viewing') - : translate( - 'auto.components.ClaudeAgentViewIndicator.viewingChild', - 'Viewing subagent {{name}}', - { name: view.label } - ) - return ( - - - - - - - {label} - {view.agentId && ( -

- {translate( - 'auto.components.ClaudeAgentViewIndicator.returnHint', - 'Click the parent row to return. Esc stops this subagent. Enter sends your draft to this subagent.' - )} -

- )} - - - ) -} - -export function ClaudeAgentSummaryViewIndicator({ agent }: { agent: DashboardAgentRow }) { - const view = useClaudeAgentRowView(agent) - return ( - - ) -} diff --git a/src/renderer/src/components/dashboard/DashboardAgentRow.tsx b/src/renderer/src/components/dashboard/DashboardAgentRow.tsx index da76fb243d3..1710681883b 100644 --- a/src/renderer/src/components/dashboard/DashboardAgentRow.tsx +++ b/src/renderer/src/components/dashboard/DashboardAgentRow.tsx @@ -2,7 +2,6 @@ import React, { useState, useCallback } from 'react' import { cn } from '@/lib/utils' import { viewClaudeAgentFromRow } from '@/lib/claude-agent-row-view' import { useClaudeAgentRowView } from './use-claude-agent-row-view' -import { ClaudeAgentViewIndicator } from '@/components/ClaudeAgentViewIndicator' import { AgentStateDot, agentStateLabel, @@ -298,7 +297,6 @@ const DashboardAgentRow = React.memo(function DashboardAgentRow({ > {displayLabel} - {model && ( (item.providerId ?? item.id) === view.agentId) - const legacyChild = parent.subagents?.find((item) => item.id === view.agentId) - const label = - viewedChild?.name || - viewedChild?.description || - viewedChild?.agentType || - legacyChild?.description || - legacyChild?.agentType || - view.agentId - return { current, agentId: view.agentId, child, label, focused } + const current = + agent.rowSource === 'subagent' + ? view.agentId === (agent.childRow?.providerId ?? agent.childRow?.id) + : !view.agentId + return { current, focused } } diff --git a/src/renderer/src/components/sidebar/worktree-card-compact-agent-row.tsx b/src/renderer/src/components/sidebar/worktree-card-compact-agent-row.tsx index 2059a30ea01..aff304156ed 100644 --- a/src/renderer/src/components/sidebar/worktree-card-compact-agent-row.tsx +++ b/src/renderer/src/components/sidebar/worktree-card-compact-agent-row.tsx @@ -8,7 +8,6 @@ import { formatAgentTypeLabel } from '@/lib/agent-status' import { cn } from '@/lib/utils' import { viewClaudeAgentFromRow } from '@/lib/claude-agent-row-view' import { useClaudeAgentRowView } from '@/components/dashboard/use-claude-agent-row-view' -import { ClaudeAgentViewIndicator } from '@/components/ClaudeAgentViewIndicator' import { getAgentDotState } from './worktree-card-agent-summary' import { getAgentRowPrimaryText } from '../../../../shared/agent-row-primary-text' import { formatAgentToolPreview } from '@/lib/agent-row-tool-preview' @@ -249,7 +248,6 @@ export const CompactAgentRow = React.memo(function CompactAgentRow({ )} - {model && ( agent.paneKey === focusedPaneKey) const summary = summarizeAgents(agents, subjectLabel) const groups = buildSummaryAgentGroups(agents) const visibleGroups = groups.slice(0, 3) @@ -135,7 +131,6 @@ export function CompactAgentSummaryButton({ onPointerDown={stopPointerPropagation} onDragStart={stopPointerPropagation} > - {!expanded && focusedAgent && } {expanded ? ( {subjectLabel} diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json index f8dc73a6d70..bfaf5dabfde 100644 --- a/src/renderer/src/i18n/locales/en.json +++ b/src/renderer/src/i18n/locales/en.json @@ -19209,11 +19209,6 @@ "cancelled": "This plain SSH terminal was closed before it started.", "terminalUnavailable": "Orca couldn’t open a terminal here.", "openHint": "Keeps you working on the host while Orca can’t set up there." - }, - "ClaudeAgentViewIndicator": { - "viewing": "Currently viewing", - "viewingChild": "Viewing subagent {{name}}", - "returnHint": "Click the parent row to return. Esc stops this subagent. Enter sends your draft to this subagent." } }, "i18n": {